Re: [Mesa-dev] [PATCH] i965: Make TCS precompile use the TES primitive mode when available.

Reviewed-by: Jordan Justen On 2016-01-01 23:23:51, Kenneth Graunke wrote: > If there's a linked TES program, we should just use the actual > primitive mode. If not, just guess triangles (as we did before). > > Signed-off-by: Kenneth Graunke >

[Mesa-dev] [Bug 93561] ninja: error: '$(PRIVATE_SCRIPT)', needed by 'out/target/product/rpi2/gen/STATIC_LIBRARIES/libmesa_dri_common_intermediates/xmlpool/options.h', missing and no known rule to make

https://bugs.freedesktop.org/show_bug.cgi?id=93561 Bug ID: 93561 Summary: ninja: error: '$(PRIVATE_SCRIPT)', needed by 'out/target/product/rpi2/gen/STATIC_LIBRARIES/libmesa_ dri_common_intermediates/xmlpool/options.h', missing

Re: [Mesa-dev] [PATCH 1/2] glsl: Fix undefined shifts.

Reviewed-by: Jordan Justen On 2015-12-30 12:26:25, Matt Turner wrote: > Shifting into the sign bit if undefined, as is shifting by 32. > --- > src/glsl/ir_constant_expression.cpp | 10 +- > src/glsl/nir/nir_opcodes.py | 6 +++--- > 2 files changed, 8

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #59 from pavi...@yahoo.fr --- I hope the bug you filed about this will have some attention. https://code.google.com/p/chromium/issues/detail?id=505969 But you didn't said if something still need to be fixed in nouveau ;) -- You are

[Mesa-dev] [PATCH v3] gallium/tests: fix build with clang compiler

Nested functions are supported as an extension in GNU C, but Clang don't support them. This fixes compilation errors when (manually) building compute.c, or by setting --enable-gallium-tests to the configure script. Changes from v3: - refactor by introducing test_default_init() Changes from v2:

Re: [Mesa-dev] [PATCH v4] nv50, nvc0: optimize coherent buffer checking at draw time

Reviewed-by: Ilia Mirkin On Sat, Jan 2, 2016 at 12:09 PM, Samuel Pitoiset wrote: > Instead of iterating over all the buffer resources looking for coherent > buffers, we keep track of a context-wide count. This will save some > iterations (and CPU

[Mesa-dev] [PATCH] arb_indirect_parameters: add basic rendering tests

Creates an array with 3 draws, the last of which is "bad", and makes sure that the "bad" one is never drawn. Parameter count is supplied from an earlier XFB draw to ensure that proper fencing occurs. Signed-off-by: Ilia Mirkin --- tests/spec/CMakeLists.txt

Re: [Mesa-dev] [PATCH 2/2] glsl: Handle bits=32 case in bitfieldInsert/bitfieldExtract.

On 2015-12-30 13:26:48, Ilia Mirkin wrote: > On Wed, Dec 30, 2015 at 3:26 PM, Matt Turner wrote: > > The OpenGL specifications for these functions say: > > > >The result will be undefined if or is negative, or if > >the sum of and is greater than the number of bits

Re: [Mesa-dev] [PATCH v3] gallium/tests: fix build with clang compiler

omg I don't know why folks insist on using gnuc nested functions they are insane. Thanks for working though this one! Reviewed-by: Edward O'Callaghan On 2016-01-03 04:20, Samuel Pitoiset wrote: Nested functions are supported as an extension in GNU C, but Clang

[Mesa-dev] [PATCH v4] nv50, nvc0: optimize coherent buffer checking at draw time

Instead of iterating over all the buffer resources looking for coherent buffers, we keep track of a context-wide count. This will save some iterations (and CPU cycles) in 99.99% case because usually coherent buffers are not so used. Changes from v4: - fix flag for textures Changes from v3: -

Re: [Mesa-dev] [PATCH] arb_indirect_parameters: add basic rendering tests

Errr... wrong list. And forgot to add to all.py. Please disregard, will send a fixed version to the right list shortly. On Sat, Jan 2, 2016 at 3:02 PM, Ilia Mirkin wrote: > Creates an array with 3 draws, the last of which is "bad", and makes > sure that the "bad" one is

Re: [Mesa-dev] [PATCH 5/9] gallium/radeon: always add +DumpCode to the LLVM target machine for LLVM <= 3.5

What's the reason for always having +DumpCode? Generating the assembly is some overhead that's usually unnecessary. Even if it's a small part of the profiles I've seen, it still seems like a natural thing to just skip. From what I can tell it should be dependent on any of the shader dumping

Re: [Mesa-dev] [PATCH 0/9] RadeonSI: Some shaders cleanups

This looks much better now :) For the series: Reviewed-by: Nicolai Hähnle On 01.01.2016 09:13, Marek Olšák wrote: Hi, These are shader cleanups mostly around si_compile_llvm. You may wonder why the "move si_shader_binary_upload out of xxx" patches. They are part of

[Mesa-dev] [PATCH 5/6] nvc0/ir: add support for PK2H/UP2H

Signed-off-by: Ilia Mirkin --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 1 + .../drivers/nouveau/codegen/nv50_ir_emit_nvc0.cpp | 5 - .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 23 ++

[Mesa-dev] [PATCH 3/6] gallium: add PIPE_CAP_TGSI_PACK_HALF_FLOAT to indicate UP2H/PK2H support

Signed-off-by: Ilia Mirkin --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c | 1 +

[Mesa-dev] [PATCH 6/6] r600: add support for PK2H/UP2H

Signed-off-by: Ilia Mirkin --- src/gallium/drivers/r600/r600_pipe.c | 2 +- src/gallium/drivers/r600/r600_shader.c | 102 +++-- 2 files changed, 99 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c

[Mesa-dev] [PATCH 4/6] st/mesa: use PK2H/UP2H when supported

Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_context.c| 2 ++ src/mesa/state_tracker/st_context.h| 1 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 16 +++- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 2/6] tgsi: update PK2H/UP2H channel behavior info

--- src/gallium/auxiliary/tgsi/tgsi_info.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_info.c b/src/gallium/auxiliary/tgsi/tgsi_info.c index 3b40c3d..c078b6f 100644 --- a/src/gallium/auxiliary/tgsi/tgsi_info.c +++

[Mesa-dev] [PATCH 1/6] gallium: document PK2H/UP2H

Signed-off-by: Ilia Mirkin --- src/gallium/docs/source/tgsi.rst | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index 955ece8..f69998f 100644 ---

[Mesa-dev] [PATCH 1/5] glapi: add ARB_indirect_parameters definitions

Signed-off-by: Ilia Mirkin --- src/mapi/glapi/gen/ARB_indirect_parameters.xml | 30 ++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 6 +- src/mesa/main/extensions_table.h |

[Mesa-dev] [PATCH 0/5] Add ARB_indirect_parameters support

The nvc0 patch applies on top of some unpublished patches, see https://github.com/imirkin/mesa/commits/tmp4 for the full thing. The whole series applies on top of the ARB_multi_draw_indirect patches I sent earlier (with potential minor modifications). There is some type confusion between the

[Mesa-dev] [PATCH 4/5] st/mesa: expose ARB_indirect_parameters when the backend driver allows

Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_cb_bufferobjects.c | 1 + src/mesa/state_tracker/st_extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_bufferobjects.c b/src/mesa/state_tracker/st_cb_bufferobjects.c

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #15 from Ilia Mirkin --- (In reply to Alex Perez from comment #14) > Ping. I am still experiencing problems with incorrect colors with the very > latest Mesa, compiled from a fresh git checkout today. Mesa

[Mesa-dev] [PATCH 2/5] mesa: add parameter buffer, used for ARB_indirect_parameters

Signed-off-by: Ilia Mirkin --- src/mesa/main/bufferobj.c| 15 +++ src/mesa/main/get.c | 5 + src/mesa/main/get_hash_params.py | 4 src/mesa/main/mtypes.h | 1 + 4 files changed, 25 insertions(+) diff --git

[Mesa-dev] [PATCH 3/3] llvmpipe: add sse code for fixed position calculation

From: Roland Scheidegger This is quite a few less instructions, albeit still do the 2 64bit muls with scalar c code (they'd need way more shuffles, plus fixup for the signed mul so it totally doesn't seem worth it - x86 can do 32x32->64bit signed scalar muls natively just

[Mesa-dev] [Bug 72877] Wrong colors with Mesa 9.2 and Mesa 10.0 on PPC Linux systems

https://bugs.freedesktop.org/show_bug.cgi?id=72877 --- Comment #14 from Alex Perez --- Ping. I am still experiencing problems with incorrect colors with the very latest Mesa, compiled from a fresh git checkout today. -- You are receiving this mail because: You are the

Re: [Mesa-dev] [PATCH 0/5] Add ARB_indirect_parameters support

In this series patches 1-4 are: Reviewed-by: Edward O'Callaghan No idea what is happening in patch 5 to say anything either way. On 2016-01-03 07:38, Ilia Mirkin wrote: The nvc0 patch applies on top of some unpublished patches, see

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

There is quite a bit of rename churn happening here at the same time as the bring up of ureg support for image declarations. Would it be possible to split the rename churn out from the actual behavioral changes please? On 2016-01-03 15:37, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH 0/8] gallium: add shader buffer support

In this series patches 2-8 are: Reviewed-by: Edward O'Callaghan with some commentary on patch 1. Kind Regards, On 2016-01-03 15:37, Ilia Mirkin wrote: This provides enough support in TGSI to support shader buffers. I do away with the defunct TGSI_FILE_RESOURCE

Re: [Mesa-dev] [PATCH 1/6] gallium: document PK2H/UP2H

This series is: Reviewed-by: Edward O'Callaghan On 2016-01-03 11:37, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- src/gallium/docs/source/tgsi.rst | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

On Sun, Jan 3, 2016 at 2:33 AM, wrote: > There is quite a bit of rename churn happening here at the same time as the > bring up of ureg support for image declarations. > Would it be possible to split the rename churn out from the actual > behavioral changes please?

[Mesa-dev] [PATCH 6/8] gallium: add PIPE_SHADER_CAP_MAX_SHADER_BUFFERS

Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/gallivm/lp_bld_limits.h| 1 + src/gallium/auxiliary/tgsi/tgsi_exec.h | 1 + src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/freedreno/freedreno_screen.c | 2 ++

[Mesa-dev] [PATCH 0/8] gallium: add shader buffer support

This provides enough support in TGSI to support shader buffers. I do away with the defunct TGSI_FILE_RESOURCE (renaming it into TGSI_FILE_IMAGE to work with pipe_image_view), and add a brand new TGSI_FILE_BUFFER. At the declaration level, this can have an ATOMIC qualifier (and later a SHARED

[Mesa-dev] [PATCH 5/8] tgsi: update atomic op docs

Specify that the operation only applies to the x component, not per-component as previously specified. This is unnecessary for GL and creates additional complications for images which need to support these operations as well. Signed-off-by: Ilia Mirkin ---

[Mesa-dev] [PATCH 4/8] tgsi: add a is_store property

Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_info.c | 446 - src/gallium/auxiliary/tgsi/tgsi_info.h | 1 + 2 files changed, 224 insertions(+), 223 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_info.c

[Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_build.c| 62 + src/gallium/auxiliary/tgsi/tgsi_dump.c | 10 +-- src/gallium/auxiliary/tgsi/tgsi_parse.c| 4 +- src/gallium/auxiliary/tgsi/tgsi_parse.h

[Mesa-dev] [PATCH 3/8] tgsi: provide a way to encode memory qualifiers for SSBO

Each load/store on most hardware can specify what caching to do. Since SSBO allows individual variables to also have separate caching modes, allow loads/stores to have the qualifiers instead of attempting to encode them in declarations. Signed-off-by: Ilia Mirkin ---

[Mesa-dev] [PATCH 7/8] gallium: add PIPE_CAP_SHADER_BUFFER_OFFSET_ALIGNMENT

Signed-off-by: Ilia Mirkin --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c | 1 +

[Mesa-dev] [PATCH 2/8] ureg: add buffer support to ureg

Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_dump.c | 5 +++ src/gallium/auxiliary/tgsi/tgsi_strings.c | 1 + src/gallium/auxiliary/tgsi/tgsi_text.c | 5 +++ src/gallium/auxiliary/tgsi/tgsi_ureg.c | 52 ++

[Mesa-dev] [PATCH 8/8] gallium: add a RESQ opcode to query info about a resource

Signed-off-by: Ilia Mirkin --- src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +- src/gallium/docs/source/tgsi.rst | 12 src/gallium/include/pipe/p_shader_tokens.h | 1 + 3 files changed, 14 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/6] i965: Add state bit to trigger re-emission of color calculator state.

This will be used on Gen8+ to make sure that the color calculator state pointers are re-emitted when switching back to the 3D pipeline after some GPGPU workload due to a hardware workaround. There are other state bits already defined that could be used to achieve the same effect but they all

[Mesa-dev] [PATCH 4/6] i965/gen4-5: Emit MI_FLUSH as required prior to switching pipelines.

AFAIK brw_emit_select_pipeline() is only called once during context init on Gen4-5, at which point the pipeline is likely to be already idle so it may just happen to work by luck regardless of the MI_FLUSH. --- src/mesa/drivers/dri/i965/brw_misc_state.c | 13 + 1 file changed, 13

[Mesa-dev] [PATCH 3/6] i965/gen6-7: Implement stall and flushes required prior to switching pipelines.

Switching the current pipeline while it's not completely idle or the read and write caches aren't flushed can lead to corruption. Fixes misrendering of at least the following Khronos CTS test: ES31-CTS.shader_image_load_store.basic-allTargets-store-fs The stall and flushes are no longer

[Mesa-dev] [PATCH 5/6] i965/gen7: Emit stall and dummy primitive draw after switching to the 3D pipeline.

This hardware bug can supposedly lead to a hang on IVB and VLV. --- src/mesa/drivers/dri/i965/brw_misc_state.c | 24 1 file changed, 24 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c index

[Mesa-dev] [PATCH 2/6] i965/gen8+: Invalidate color calc state when switching to the GPGPU pipeline.

This hardware bug can cause a hang on context restore while the current pipeline is set to GPGPU (BDWGFX HSD 1909593). In addition to clearing the valid bit, mark the CC state as dirty to make sure that the CC indirect state pointer is re-emitted when we switch back to the 3D pipeline. ---

[Mesa-dev] [PATCH 6/6] i965/gen7.5+: Disable resource streamer during GPGPU workloads.

The RS and hardware binding tables are only supported on the 3D pipeline and can lead to corruption if left enabled during a GPGPU workload. Disable it when switching to the GPGPU (or media) pipeline and re-enable it when switching back to the 3D pipeline. ---

[Mesa-dev] [PATCH 0/6] i965: GPGPU/3D pipeline switching fixes.

The PIPELINE_SELECT command has a number of awkward restrictions we don't currently take into account while switching between the GPGPU and 3D pipeline, what in some cases can lead to corruption or hangs. This series should implement all workarounds mentioned in the hardware spec ("BXML » GT » MI