[Mesa-dev] [RFC PATCH] mesa: Add MESA_SHADER_CAPTURE_PATH for writing .shader_test files.

This writes linked shader programs to .shader_test files to $MESA_SHADER_CAPTURE_PATH in the format used by shader-db (http://cgit.freedesktop.org/mesa/shader-db). It supports both GLSL shaders and ARB programs. All stages that are linked together are written in a single .shader_test file. This

Re: [Mesa-dev] [RFC PATCH] mesa: Add MESA_SHADER_CAPTURE_PATH for writing .shader_test files.

On Monday, January 18, 2016 7:05:21 AM PST Kenneth Graunke wrote: > diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c > index 126786c..030d9a1 100644 > --- a/src/mesa/main/shaderapi.c > +++ b/src/mesa/main/shaderapi.c > @@ -96,6 +96,20 @@ _mesa_get_shader_flags(void) > return

Re: [Mesa-dev] [PATCH] mesa: Move sanity check of BindVertexBuffer for OpenGL ES 3.1

Note to myself the new tests need to go before the old one. > -Original Message- > From: Marta Lofstedt [mailto:marta.lofst...@linux.intel.com] > Sent: Friday, January 8, 2016 2:56 PM > To: mesa-dev@lists.freedesktop.org > Cc: Lofstedt, Marta > Subject: [PATCH] mesa: Move sanity check of

Re: [Mesa-dev] [PATCH] glsl: Don't abbreviate tessellation shader stage names.

Reviewed-by: Iago Toral Quiroga On Mon, 2016-01-18 at 06:02 -0800, Kenneth Graunke wrote: > I have a patch that writes shaders as .shader_test files, and it uses > this function to create the headers (i.e. [vertex shader]). > > [tess ctrl shader] isn't a valid shader_runner

Re: [Mesa-dev] Bugzilla (Was: [Bug 93686] Performance improvement : Please consider hardware ɢᴘᴜ rendering in llvmpipe)

Hi, On 18 January 2016 at 12:48, Jose Fonseca wrote: > There's something weird going on with bugzilla and maybe ytrezq's browser. > mesa-dev received a lot of CC add/remove notification emails from bugzilla, > but if you look at

[Mesa-dev] [PATCH] glsl: Don't abbreviate tessellation shader stage names.

I have a patch that writes shaders as .shader_test files, and it uses this function to create the headers (i.e. [vertex shader]). [tess ctrl shader] isn't a valid shader_runner header - it's spelled out as [tessellation control shader]. There's no real reason to abbreviate it, so spell it out.

[Mesa-dev] [Bug 93686] Performance improvement ?=:=?UTF-8?Q? Please consider hardware ɢᴘᴜ rendering in llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=93686 Christian König changed: What|Removed |Added Status|RESOLVED|CLOSED ---

Re: [Mesa-dev] [PATCH 02/10] glsl: keep track of ssbo variable being accessed, add access params

On Mon, 2016-01-18 at 00:51 -0500, Ilia Mirkin wrote: > Currently any access params (coherent/volatile/restrict) are being lost > when lowering to the ssbo load/store intrinsics. Keep track of the > variable being used, and bake its access params in as the last arg of > the load/store intrinsics.

[Mesa-dev] [PATCH 1/5] glsl: allow duplicate layout-qualifier-names

This is added by ARB_enhanced_layouts although it doesn't fit into any of the six main changes so we enable this independently. From the ARB_enhanced_layouts spec: "More than one layout qualifier may appear in a single declaration. Additionally, the same layout-qualifier-name can occur

[Mesa-dev] [PATCH 2/5] glsl: split layout_defaults into specific types

This will allow merging of duplicate layout qualifiers as allowed by ARB_shading_language_420pack Cc: Matt Turner --- src/glsl/glsl_parser.yy | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/src/glsl/glsl_parser.yy

[Mesa-dev] Allow duplicate layout qualifiers V2

After sending out V1 where I didn't fix the global default merging (just issued and error), I got motivated and fixed it properly. There are two changes here. 1. ARB_enhanced_layouts Allows duplicates within a single layout qualifier e.g. layout(location = 0, location = 1) out vec4 a; 2.

[Mesa-dev] [PATCH 3/5] glsl: move default layout qualifier rules out of the parser

Cc: Matt Turner --- src/glsl/ast_type.cpp | 22 +- src/glsl/glsl_parser.yy | 29 ++--- 2 files changed, 23 insertions(+), 28 deletions(-) diff --git a/src/glsl/ast_type.cpp b/src/glsl/ast_type.cpp index 4e75016..e59d1b2 100644

[Mesa-dev] [PATCH 4/5] glsl: update parser to allow duplicate default layout qualifiers

In order to only create a single node for each default declaration we add a new boolean parameter to the in/out merge function to only create one once we reach the rightmost layout qualifier. From the ARB_shading_language_420pack spec: "More than one layout qualifier may appear in a single

[Mesa-dev] [PATCH 5/5] glsl: allow multiple layout qualifiers for a single declaration

From the ARB_shading_language_420pack spec: "More than one layout qualifier may appear in a single declaration. If the same layout-qualifier-name occurs in multiple layout qualifiers for the same declaration, the last one overrides the former ones." The parser was already failing

Re: [Mesa-dev] [PATCH] nv50/ir: swap the least-ref'd source into src1 when both const/imm

On Mon, Jan 18, 2016 at 4:14 AM, Ilia Mirkin wrote: > The whole point of inlining sources is to reduce loads. We can end up in > a situation where one value is used a lot of times, and one value is > used only once per instruction. The once-per-instruction one is the one >

[Mesa-dev] [PATCH] nv50/ir: swap the least-ref'd source into src1 when both const/imm

The whole point of inlining sources is to reduce loads. We can end up in a situation where one value is used a lot of times, and one value is used only once per instruction. The once-per-instruction one is the one that should get inlined, but with the previous algorithm, it was given no

Re: [Mesa-dev] [PATCH] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

Reviewed-by: Marek Olšák Marek On Sun, Jan 17, 2016 at 6:26 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +- > src/gallium/docs/source/tgsi.rst | 17

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

https://bugs.freedesktop.org/show_bug.cgi?id=90264 avsa...@gmail.com changed: What|Removed |Added CC||avsa...@gmail.com -- You are

[Mesa-dev] [PATCH 4/6] compiler: move the glsl_types C wrapper alongside their C++ brethren

From: Emil Velikov At a later stage we might want to split out the NIR specific [XXX: which one was it], as to make things move obvious and rename the files appropriately. This patch aims to split it out of nir. Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH 1/6] compiler: introduce a libcompiler static library

From: Emil Velikov Currently it's an empty library, although it'll be used to store common code between GLSL and NIR that is compiler specific (rather than generic as the one in src/util). XXX: strictly speaking we could add a python/mako parser to generate the

[Mesa-dev] [PATCH 6/6] glsl: move to compiler/

From: Emil Velikov Signed-off-by: Emil Velikov --- XXX: to avoid getting stuck (due to it's size), the file movements have been trimmed out :-) configure.ac | 1 - src/Makefile.am

[Mesa-dev] [PATCH 0/6] Move nir/glsl to src/compiler, take 2

Hi all, Here is another attempt at splitting up nir, glsl and the rest. The gist is that we have three independent static libraries - compiler, nir and glsl. Thus we don't need to pull nir if working with glsl and vice versa. For compilation purposes the three (not to mention mesa ir) _are_

Re: [Mesa-dev] [PATCH 10/10] trace: add support for set_shader_buffers

Reviewed-by: Marek Olšák Marek On Mon, Jan 18, 2016 at 6:51 AM, Ilia Mirkin wrote: > --- > src/gallium/drivers/trace/tr_context.c| 38 > +++ > src/gallium/drivers/trace/tr_dump_state.c | 18 +++ >

Re: [Mesa-dev] [PATCH 07/10] st/mesa: add support for memory barrier intrinsics

On Mon, Jan 18, 2016 at 6:51 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 32 > ++ > 1 file changed, 32 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

For 1-4, Reviewed-by: Marek Olšák I'm not very familiar with the code in 2, but the changes seem reasonable. Also, and I know this is not your mistake, but still, mtypes.h has: struct gl_atomic_buffer_binding AtomicBufferBindings[MAX_COMBINED_ATOMIC_BUFFERS]; But

[Mesa-dev] [PATCH 3/6] nir: move glsl_types.{cpp,h} to compiler

From: Emil Velikov Allows us to remove the SCons workaround :-) Signed-off-by: Emil Velikov --- src/compiler/Makefile.sources | 2 ++ src/{glsl/nir => compiler}/glsl_types.cpp | 2 +-

[Mesa-dev] [PATCH 2/6] nir: move shader_enums.[ch] to compiler

From: Emil Velikov This way one can reuse it in glsl, nir or other infrastructure without pulling nir as dependency. Signed-off-by: Emil Velikov --- Android.mk | 1 + src/SConscript

[Mesa-dev] [PATCH 5/6] nir: move to compiler/

From: Emil Velikov Signed-off-by: Emil Velikov --- XXX: to avoid getting stuck (due to it's size), the file movements have been trimmed out :-) src/compiler/Android.gen.mk| 91 ++

[Mesa-dev] [Bug 93686] Performance improvement ?=:=?UTF-8?Q? Please consider hardware ɢᴘᴜ rendering in llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=93686 --- Comment #34 from Daniel Stone --- @ytrezq: Please stop CCing so many people. Everyone involved is already aware of the discussion (and has already come to a set view on this which is unlikely to change); adding further

Re: [Mesa-dev] [PATCH 05/10] st/mesa: add support for SSBO binding and GLSL intrinsics

This looks good except glsl_to_tgsi, which I'm not familiar with. Also, you use more than 80 characters per line where it can't be justified that it improves readability. Marek On Mon, Jan 18, 2016 at 6:51 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH 06/10] st/mesa: use RESQ to find buffer size

Reviewed-by: Marek Olšák Marek On Mon, Jan 18, 2016 at 6:51 AM, Ilia Mirkin wrote: > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 22 ++ > 1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 08/10] st/mesa: add shader buffer barrier bit

Reviewed-by: Marek Olšák Marek On Mon, Jan 18, 2016 at 6:51 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/gallium/include/pipe/p_defines.h | 1 + > src/mesa/state_tracker/st_cb_texturebarrier.c | 4

Re: [Mesa-dev] [PATCH 09/10] st/mesa: enable ARB_shader_storage_buffer_object when supported

Reviewed-by: Marek Olšák Marek On Mon, Jan 18, 2016 at 6:51 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > src/mesa/state_tracker/st_extensions.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[Mesa-dev] Bugzilla (Was: [Bug 93686] Performance improvement : Please consider hardware ɢᴘᴜ rendering in llvmpipe)

On 18/01/16 12:21, bugzilla-dae...@freedesktop.org wrote: *Comment # 34 on bug 93686 from Daniel Stone * @ytrezq: Please stop CCing so many people.

Re: [Mesa-dev] [RFC PATCH] mesa: Add MESA_SHADER_CAPTURE_PATH for writing .shader_test files.

On Mon, Jan 18, 2016 at 07:05:21AM -0800, Kenneth Graunke wrote: > This writes linked shader programs to .shader_test files to > $MESA_SHADER_CAPTURE_PATH in the format used by shader-db > (http://cgit.freedesktop.org/mesa/shader-db). > > It supports both GLSL shaders and ARB programs. All

Re: [Mesa-dev] [RFC PATCH] mesa: Add MESA_SHADER_CAPTURE_PATH for writing .shader_test files.

Hi, On 18.01.2016 17:05, Kenneth Graunke wrote: This writes linked shader programs to .shader_test files to $MESA_SHADER_CAPTURE_PATH in the format used by shader-db (http://cgit.freedesktop.org/mesa/shader-db). It supports both GLSL shaders and ARB programs. All stages that are linked

Re: [Mesa-dev] [PATCH 06/10] st/mesa: use RESQ to find buffer size

Reviewed-by: Edward O'Callaghan On 2016-01-18 16:51, Ilia Mirkin wrote: --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

Re: [Mesa-dev] [PATCH 1/9] gallium: Add PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY

On Mon, Jan 18, 2016 at 6:52 PM, Nicolai Hähnle wrote: > > > On 18.01.2016 18:50, Ilia Mirkin wrote: >> >> On Mon, Jan 18, 2016 at 5:22 PM, Nicolai Hähnle >> wrote: >>> >>> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c >>>

[Mesa-dev] [PATCH v2 07/10] st/mesa: add support for memory barrier intrinsics

Signed-off-by: Ilia Mirkin v1 -> v2: use TGSI_MEMBAR defines --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 45 ++ 1 file changed, 45 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH v2 05/10] st/mesa: add support for SSBO binding and GLSL intrinsics

Signed-off-by: Ilia Mirkin v1 -> v2: some 80 char reformatting --- src/mesa/Makefile.sources| 1 + src/mesa/state_tracker/st_atom.c | 5 + src/mesa/state_tracker/st_atom.h | 5 + src/mesa/state_tracker/st_atom_storagebuf.c

[Mesa-dev] [PATCH v2 10/10] trace: add support for set_shader_buffers

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/gallium/drivers/trace/tr_context.c| 38 +++ src/gallium/drivers/trace/tr_dump_state.c | 18 +++ src/gallium/drivers/trace/tr_dump_state.h | 2 ++ 3

[Mesa-dev] [PATCH v2 04/10] st/mesa: add atomic counter support

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/mesa/Makefile.sources| 1 + src/mesa/program/ir_to_mesa.cpp | 4 + src/mesa/state_tracker/st_atom.c | 5 + src/mesa/state_tracker/st_atom.h

[Mesa-dev] [PATCH v2 09/10] st/mesa: enable ARB_shader_storage_buffer_object when supported

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index ce88b4a..cec1634

[Mesa-dev] [PATCH v2 08/10] st/mesa: add shader buffer barrier bit

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/gallium/include/pipe/p_defines.h | 1 + src/mesa/state_tracker/st_cb_texturebarrier.c | 4 2 files changed, 5 insertions(+) diff --git a/src/gallium/include/pipe/p_defines.h

[Mesa-dev] [PATCH v2 06/10] st/mesa: use RESQ to find buffer size

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák Reviewed-by: Edward O'Callaghan --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/9] gallium: Add PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY

On 18.01.2016 18:50, Ilia Mirkin wrote: On Mon, Jan 18, 2016 at 5:22 PM, Nicolai Hähnle wrote: diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c b/src/gallium/drivers/nouveau/nv30/nv30_screen.c index 90f..1ae557d 100644 ---

Re: [Mesa-dev] [PATCH 2/2] i965: Implement compute sampler state atom.

On Mon, Jan 18, 2016 at 12:37:18PM -0800, Francisco Jerez wrote: > Fixes a number of GLES31 CTS failures and hangs on various hardware: > > ES31-CTS.texture_gather.plain-gather-depth-2d > ES31-CTS.texture_gather.plain-gather-depth-2darray > ES31-CTS.texture_gather.plain-gather-depth-cube >

Re: [Mesa-dev] Mesa for OpenVMS

On Mon, 2016-01-18 at 16:47 +0100, Jouk Jansen wrote: > Hi All, > > I updated my patches to get Mesa working on OpenVMS systems. Patches > against > a version extracted from the git-repository can be found here: > > http://nchrem.tnw.tudelft.nl/openvms/software2.html#Mesa > > All changes in

[Mesa-dev] [PATCH v2 00/10] st/mesa: add shader buffer support

Incorporated feedback from Marek, as well as the R-b's that were sent. Ilia Mirkin (10): tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics glsl: keep track of ssbo variable being accessed, add access params st/mesa: add PROGRAM_BUFFER, stop using gl_register_file st/mesa:

[Mesa-dev] [PATCH v2 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák (v1) v1 -> v2: add defines for the various bits --- src/gallium/auxiliary/tgsi/tgsi_info.c | 2 +- src/gallium/docs/source/tgsi.rst | 17 +

[Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH v2 02/10] glsl: keep track of ssbo variable being accessed, add access params

Currently any access params (coherent/volatile/restrict) are being lost when lowering to the ssbo load/store intrinsics. Keep track of the variable being used, and bake its access params in as the last arg of the load/store intrinsics. Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH 4/9] st/mesa: Accelerate PBO uploads

On 18.01.2016 17:22, Nicolai Hähnle wrote: +static void * +create_pbo_upload_shader(struct pipe_context *pipe) +{ + struct ureg_program *ureg; + struct ureg_dst out; + struct ureg_src sampler; + struct ureg_src pos; + struct ureg_src const0; + struct ureg_dst temp0; + + ureg=

Re: [Mesa-dev] [PATCH 2/9] gallium: Add PIPE_CAP_SURFACE_REINTERPRET_BLOCKS

On Mon, Jan 18, 2016 at 5:22 PM, Nicolai Hähnle wrote: > diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c > b/src/gallium/drivers/freedreno/freedreno_screen.c > index 69a55d4..92798fb 100644 > --- a/src/gallium/drivers/freedreno/freedreno_screen.c > +++

[Mesa-dev] Mesa for OpenVMS

Hi All, I updated my patches to get Mesa working on OpenVMS systems. Patches against a version extracted from the git-repository can be found here: http://nchrem.tnw.tudelft.nl/openvms/software2.html#Mesa All changes in the c-code are marked by #ifdef __VMS #endif. The other files are

[Mesa-dev] [Bug 86326] clEnqueueNDRangeKernel global_work_offset ignored

https://bugs.freedesktop.org/show_bug.cgi?id=86326 Jan Vesely changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 1/9] gallium: Add PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY

On Mon, Jan 18, 2016 at 5:22 PM, Nicolai Hähnle wrote: > diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c > b/src/gallium/drivers/nouveau/nv30/nv30_screen.c > index 90f..1ae557d 100644 > --- a/src/gallium/drivers/nouveau/nv30/nv30_screen.c > +++

Re: [Mesa-dev] [PATCH] util/u_pstipple.c: copy immediates during transformation

On 18.01.2016 17:54, Jose Fonseca wrote: On 18/01/16 20:28, Nicolai Hähnle wrote: From: Nicolai Hähnle Apparently, nobody has combined stippling with a fragment shader containing immediates in almost five years... Fixes a bug in Kodi with radeonsi reported by

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

On Mon, Jan 18, 2016 at 6:06 AM, Marek Olšák wrote: > For 1-4, > > Reviewed-by: Marek Olšák > > I'm not very familiar with the code in 2, but the changes seem reasonable. > > Also, and I know this is not your mistake, but still, mtypes.h has: > > struct

Re: [Mesa-dev] [PATCH] glsl: fix interface block error message

Reviewed-by: Ilia Mirkin On Mon, Jan 18, 2016 at 10:41 PM, Timothy Arceri wrote: > Print the stream value not the pointer to the expression, > also use the unsigned format specifier. > > Cc: 11.1 > --- >

Re: [Mesa-dev] [PATCH] mesa: Move sanity check of BindVertexBuffer for OpenGL ES 3.1

Confirmed that patch fixes all the seen regressions; Reviewed-by: Tapani Pälli On 01/08/2016 03:55 PM, Marta Lofstedt wrote: From: Marta Lofstedt Sanity check of BindVertexBuffer for OpenGL ES in _mesa_handle_bind_buffer_gen breaks OpenGL ES

[Mesa-dev] [PATCH] gallium: make image views non-persistent objects

Make them akin to shader buffers, with no refcounting/etc. Just used to pass data about the bound image in ->set_shader_images. Signed-off-by: Ilia Mirkin --- I don't really see a reason why these were refcounted objects. It seems like it would be convenient to make these

[Mesa-dev] [PATCH] glsl: fix interface block error message

Print the stream value not the pointer to the expression, also use the unsigned format specifier. Cc: 11.1 --- src/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index

[Mesa-dev] [PATCH v2] glsl: fix consumer_stage restriction to separate shader objects

Commit 781d278 did not restrict consumer_stage only to separate shader objects, which is when we don't know if the consumer stage would be a fragment shader added later. In normal programs, when consumer_stage == -1, it is because they are not consumed. Fixes 4 piglit regressions added by commit

Re: [Mesa-dev] [PATCH v2 02/10] glsl: keep track of ssbo variable being accessed, add access params

So actually this isn't enough. For named blocks, the variable in question is the block var, not the actual field. So I also need to add a glsl_struct_field. And a few related items. Will resend this patch (potentially as a handful of patches). On Mon, Jan 18, 2016 at 9:30 PM, Ilia Mirkin

[Mesa-dev] [PATCH v3 2/10] glsl: keep track of ssbo variable being accessed, add access params

Currently any access params (coherent/volatile/restrict) are being lost when lowering to the ssbo load/store intrinsics. Keep track of the variable being used, and bake its access params in as the last arg of the load/store intrinsics. Sometimes the variable being accessed is the actual block

[Mesa-dev] [PATCH v3 1.5/10] glsl: always initialize image_* fields, copy them on interface init

Interfaces can have image properties set in case they are buffer interfaces. Make sure not to lose this information. Signed-off-by: Ilia Mirkin --- src/glsl/builtin_variables.cpp | 5 + src/glsl/nir/glsl_types.cpp| 5 + src/glsl/nir/glsl_types.h | 3 ++- 3

Re: [Mesa-dev] [android-x86-devel] Re: need-help: how to change to newest mesa in android-x86?

On Mon, Jan 18, 2016 at 5:18 PM, Rob Herring wrote: > On Fri, Jan 15, 2016 at 3:10 PM, Dave Airlie wrote: >>> >>> well, nothing specific, but for example early on we had some confusion >>> in drm_gralloc (when adding dmabuf fd support) about who close()d

Re: [Mesa-dev] [PATCH 2/2] llvmpipe: turn depth clears into full depth/stencil clears for d24x8 formats

On 18/01/16 03:33, srol...@vmware.com wrote: From: Roland Scheidegger If we have a d24x8 format, there is no stencil. Therefore, we can always clear these bits too, which means this will be some kind of memset rather than read-modify-write. This is good for some 7% increase

Re: [Mesa-dev] [RFC PATCH] mesa: Add MESA_SHADER_CAPTURE_PATH for writing .shader_test files.

On Monday, January 18, 2016 8:53:18 AM PST Ben Widawsky wrote: > On Mon, Jan 18, 2016 at 07:05:21AM -0800, Kenneth Graunke wrote: > > This writes linked shader programs to .shader_test files to > > $MESA_SHADER_CAPTURE_PATH in the format used by shader-db > >

Re: [Mesa-dev] [PATCH] util/u_pstipple.c: copy immediates during transformation

On Mon, Jan 18, 2016 at 9:28 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Apparently, nobody has combined stippling with a fragment shader > containing immediates in almost five years... Well, I don't know about other drivers, but r300g and

[Mesa-dev] [PATCH 0/9] st/mesa: accelerate texture uploads from PBOs

Hi everybody, this series is based on Fredrik Höglund's older patch to accelerate texture image uploads from PBOs. In parallel to this, I have also extended a bunch of piglit tests to exercise the PBO upload path a bit more, and at least on radeonsi the tests are looking good. Compared to

[Mesa-dev] [PATCH 4/9] st/mesa: Accelerate PBO uploads

From: Fredrik Höglund Create a PIPE_BUFFER sampler view on the pixel-unpack buffer, and draw the image on the texture with a fragment shader that maps fragment coordinates to buffer coordinates. Modifications by Nicolai Hähnle: - various cleanups and fixes (e.g. error handling,

[Mesa-dev] [PATCH 6/9] st/mesa: inline the implementation of _mesa_store_compressed_teximage

From: Nicolai Hähnle We will write our own version of texsubimage for PBO uploads, and we will want to call that here as well. --- src/mesa/state_tracker/st_cb_texture.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/9] gallium: Add PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY

From: Nicolai Hähnle This cap indicates that the driver only supports R, RG, RGB and RGBA formats for PIPE_BUFFER sampler views. --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/freedreno/freedreno_screen.c | 2 ++

[Mesa-dev] [PATCH 9/9] gallium/radeon: support PIPE_CAP_SURFACE_REINTERPRET_BLOCKS

From: Nicolai Hähnle This is already used internally in the transfer_map implementation for compressed textures, so the only real change here is the adjusted surface size computation. --- src/gallium/drivers/r600/r600_pipe.c | 2 +-

[Mesa-dev] [PATCH 8/9] st/mesa: implement PBO upload for glCompressedTex(Sub)Image

From: Nicolai Hähnle --- src/mesa/state_tracker/st_cb_texture.c | 118 + 1 file changed, 118 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index 1c4f5ba..cfd6d90 100644 ---

[Mesa-dev] [PATCH 7/9] st/mesa: redirect CompressedTexSubImage to our own implementation

From: Nicolai Hähnle This is where PBO upload will go. --- src/mesa/state_tracker/st_cb_texture.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c

[Mesa-dev] [PATCH 5/9] st/mesa: implement PBO upload for multiple layers

From: Nicolai Hähnle Use instancing to generate two triangles for each destination layer and use a geometry shader to route the layer index. --- src/mesa/state_tracker/st_cb_texture.c | 145 +++-- src/mesa/state_tracker/st_context.h| 2

Re: [Mesa-dev] [RFC PATCH] mesa: Add MESA_SHADER_CAPTURE_PATH for writing .shader_test files.

On Tuesday, January 19, 2016 9:40:25 AM PST Timothy Arceri wrote: > On Mon, 2016-01-18 at 07:05 -0800, Kenneth Graunke wrote: > > @@ -1047,6 +1061,32 @@ link_program(struct gl_context *ctx, GLuint > > program) > > > > _mesa_glsl_link_shader(ctx, shProg); > > > > + /* Capture .shader_test

Re: [Mesa-dev] [android-x86-devel] Re: need-help: how to change to newest mesa in android-x86?

On Fri, Jan 15, 2016 at 3:10 PM, Dave Airlie wrote: >> >> well, nothing specific, but for example early on we had some confusion >> in drm_gralloc (when adding dmabuf fd support) about who close()d the >> fd's. Resulting in same fd getting closed twice (although some >>

Re: [Mesa-dev] [RFC PATCH] mesa: Add MESA_SHADER_CAPTURE_PATH for writing .shader_test files.

On Mon, 2016-01-18 at 07:05 -0800, Kenneth Graunke wrote: > This writes linked shader programs to .shader_test files to > $MESA_SHADER_CAPTURE_PATH in the format used by shader-db > (http://cgit.freedesktop.org/mesa/shader-db). > > It supports both GLSL shaders and ARB programs. All stages that

Re: [Mesa-dev] [PATCH] util/u_pstipple.c: copy immediates during transformation

On 18/01/16 20:28, Nicolai Hähnle wrote: From: Nicolai Hähnle Apparently, nobody has combined stippling with a fragment shader containing immediates in almost five years... Fixes a bug in Kodi with radeonsi reported by Christian König. Good find. I don't know how

Re: [Mesa-dev] [PATCH 1/2] i965: Trigger CS state reemission when new sampler state is uploaded.

Series Reviewed-by: Jordan Justen On 2016-01-18 12:37:17, Francisco Jerez wrote: > This reuses the NEW_SAMPLER_STATE_TABLE state bit (currently only used > on pre-Gen7 hardware) to signal that the sampler state tables have > changed in order to make sure that the GPGPU

[Mesa-dev] [PATCH] util/u_pstipple.c: copy immediates during transformation

From: Nicolai Hähnle Apparently, nobody has combined stippling with a fragment shader containing immediates in almost five years... Fixes a bug in Kodi with radeonsi reported by Christian König. Cc: "11.0 11.1" Tested-by: Christian

Re: [Mesa-dev] [PATCH 0/9] st/mesa: accelerate texture uploads from PBOs

Arghh... the various debugging printf()s are still in the patches that I sent out, those are obviously not supposed to be there. The cleaned up version is at http://cgit.freedesktop.org/~nh/mesa/log/?h=pbo-upload On Mon, Jan 18, 2016 at 5:22 PM, Nicolai Hähnle wrote: > Hi

[Mesa-dev] [PATCH 1/2] i965: Trigger CS state reemission when new sampler state is uploaded.

This reuses the NEW_SAMPLER_STATE_TABLE state bit (currently only used on pre-Gen7 hardware) to signal that the sampler state tables have changed in order to make sure that the GPGPU interface descriptor is updated. --- src/mesa/drivers/dri/i965/brw_sampler_state.c | 2 +-

[Mesa-dev] [PATCH 2/2] i965: Implement compute sampler state atom.

Fixes a number of GLES31 CTS failures and hangs on various hardware: ES31-CTS.texture_gather.plain-gather-depth-2d ES31-CTS.texture_gather.plain-gather-depth-2darray ES31-CTS.texture_gather.plain-gather-depth-cube ES31-CTS.texture_gather.offset-gather-depth-2d

Re: [Mesa-dev] [PATCH] st/mesa: restore the stObj's size if it was cleared out

On 17.01.2016 16:34, Ilia Mirkin wrote: An issue could still occur if the base level is set, but fixing that would require a lot more logic. This fixes the recently-failing texelFetch 3D tests because the mipmaps were no longer being generated, which in turn caused the copying logic to be hit,

[Mesa-dev] [PATCH 3/9] st/mesa: use the correct address generation functions in st_TexSubImage blit

From: Nicolai Hähnle We need to tell the address generation functions about the dimensionality of the texture to correctly implement the part of Section 3.8.1 (Texture Image Specification) of the OpenGL 2.1 specification which says: "For the purposes of decoding the