Re: [Mesa-dev] [PATCH 16/25] radeonsi: add PS prolog

2016-02-19 Thread Nicolai Hähnle
On 19.02.2016 06:39, Marek Olšák wrote: On Tue, Feb 16, 2016 at 5:31 PM, Nicolai Hähnle wrote: So, patches 12-16 also look good to me except for the comments I've sent on 12-14. Does this mean I can add your Rb on those? Yes indeed. Nicolai Marek

[Mesa-dev] [PATCH 2/2] st/mesa: add GL_ARB_shader_atomic_counter_ops support

2016-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_extensions.c | 4 +- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 60 +++--- 2 files changed, 57 insertions(+), 7 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c

[Mesa-dev] [PATCH 1/2] mesa: add GL_ARB_shader_atomic_counter_ops support

2016-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_functions.cpp | 110 +++ src/compiler/glsl/glcpp/glcpp-parse.y| 3 + src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 +

[Mesa-dev] [Bug 94040] clGetPlatformIDs causes futex race condition

2016-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94040 b...@bob131.so changed: What|Removed |Added Attachment #121851|0 |1 is obsolete|

[Mesa-dev] [Bug 94040] clGetPlatformIDs causes futex race condition

2016-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94040 --- Comment #9 from b...@bob131.so --- Created attachment 121851 --> https://bugs.freedesktop.org/attachment.cgi?id=121851=edit Complete Blender backtraces -- You are receiving this mail because: You are the QA Contact for the bug. You are

[Mesa-dev] [Bug 94040] clGetPlatformIDs causes futex race condition

2016-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94040 --- Comment #10 from b...@bob131.so --- Sorry, I completely forgot you asked for those. Enjoy ;) -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH] mesa: add GL_OES_gpu_shader5 and GL_EXT_gpu_shader5 support

2016-02-19 Thread Ilia Mirkin
The two extensions are identical, and are largely taking bits of already existing desktop functionality. We continue to do a poor job of supporting the 'precise' keyword, just like we do on desktop. This passes the relevant dEQP tests that I could find. Signed-off-by: Ilia Mirkin

[Mesa-dev] [Bug 94195] [llvmpipe] Does not build with LLVM 3.7.x on Windows

2016-02-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94195 Jose Fonseca changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 22/22] meta/blit: Use GL_EXT_shader_samples_identical in MSAA-SS resolve blit

2016-02-19 Thread Roland Scheidegger
Am 19.02.2016 um 11:57 schrieb Iago Toral: > On Thu, 2016-02-18 at 16:13 -0800, Ian Romanick wrote: >> On 02/18/2016 01:47 PM, Ian Romanick wrote: >>> On 02/18/2016 08:44 AM, Neil Roberts wrote: I made a pathological test case (attached) which repeatedly renders into an MSAA FBO and then

Re: [Mesa-dev] [Libva] vaPutSurface never returns

2016-02-19 Thread Vasilis Liaskovitis
Hi, On Fri, Feb 19, 2016 at 5:04 PM, Emil Velikov wrote: > Was about to mention the same thing as Christian :-) > > Vasilis, is there any reason why you're using vdpau + the vdpau to > vaapi adapter, as opposed to the gallium vaapi target directly ? > Someone on

Re: [Mesa-dev] [PATCH 0/4] OpenSWR driver addition

2016-02-19 Thread Jose Fonseca
On 18/02/16 23:46, Brian Paul wrote: On 02/17/2016 06:53 PM, Tim Rowley wrote: This patch series adds the OpenSWR driver, a new software rasterizer project by Intel. The goal of this project is to create a high performance, highly scalable renderer targeted towards visualization workloads.

Re: [Mesa-dev] [PATCH] nv50: do not advertise about compute shaders

2016-02-19 Thread Pierre Moreau
Reviewed-by: Pierre Moreau On 08:25 PM - Feb 19 2016, Samuel Pitoiset wrote: > Compute shaders are totally unsupported. This avoids Clover to > report that OpenCL is supported on Tesla because it's a lie. > > Signed-off-by: Samuel Pitoiset >

[Mesa-dev] [PATCH] nv50: do not advertise about compute shaders

2016-02-19 Thread Samuel Pitoiset
Compute shaders are totally unsupported. This avoids Clover to report that OpenCL is supported on Tesla because it's a lie. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Mesa-dev] [PATCH] st/mesa: force depth mode to GL_RED for sized depth/stencil formats

2016-02-19 Thread Ilia Mirkin
On Wed, Feb 17, 2016 at 3:26 PM, Kenneth Graunke wrote: > On Wednesday, February 17, 2016 8:21:32 AM PST Ilia Mirkin wrote: >> See commit 9db2098d for the i965 version of this. >> >> This fixes depth in a bunch of dEQP EXT_texture_border_clamp tests. And >> probably other

Re: [Mesa-dev] [PATCH] nv50: do not advertise about compute shaders

2016-02-19 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Fri, Feb 19, 2016 at 2:25 PM, Samuel Pitoiset wrote: > Compute shaders are totally unsupported. This avoids Clover to > report that OpenCL is supported on Tesla because it's a lie. > > Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH 1/3] glsl: add gl_MaxSamples, new in GL 4.5 / GL ES 3.2

2016-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_variables.cpp | 3 +++ src/compiler/glsl/glsl_parser_extras.cpp | 3 +++ src/compiler/glsl/glsl_parser_extras.h | 3 +++ 3 files changed, 9 insertions(+) diff --git a/src/compiler/glsl/builtin_variables.cpp

[Mesa-dev] [PATCH 2/3] mesa: add ES3_1_compatibility extension enable

2016-02-19 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions_table.h b/src/mesa/main/extensions_table.h index 3a90bc9..c30ce16 100644 ---

[Mesa-dev] [PATCH 3/3] glsl: add ARB_ES3_1_compatibility support

2016-02-19 Thread Ilia Mirkin
Oddly a bunch of the features it adds are actually from ESSL 3.20. But the spec is quite clear, oh well. Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_functions.cpp | 66 +++- src/compiler/glsl/builtin_variables.cpp | 16

Re: [Mesa-dev] [PATCH v2] egl_dri2: set correct error code if swapbuffers fails

2016-02-19 Thread Emil Velikov
On 19 February 2016 at 16:48, Tapani Pälli wrote: > On 02/19/2016 06:23 PM, Emil Velikov wrote: >> >> On 19 February 2016 at 05:40, Tapani Pälli wrote: >>> >>> Pinging Emil with this one .. >>> >> Should have mentioned it beforehand - I pushed it

Re: [Mesa-dev] [PATCH v2] egl_dri2: set correct error code if swapbuffers fails

2016-02-19 Thread Tapani Pälli
On 02/19/2016 06:23 PM, Emil Velikov wrote: On 19 February 2016 at 05:40, Tapani Pälli wrote: Pinging Emil with this one .. Should have mentioned it beforehand - I pushed it yesterday. Hopefully others won't object :-) OK thanks, I cannot spot it in the current tree

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl: support EGL_LARGEST_PBUFFER in eglCreatePbufferSurface(...)

2016-02-19 Thread Emil Velikov
On 19 February 2016 at 05:34, Tapani Pälli wrote: > > On 02/18/2016 08:19 PM, Emil Velikov wrote: >> >> Hi guys, >> >> On 15 February 2016 at 10:54, Tapani Pälli wrote: >>> >>> From: Daniel Czarnowski >>> >>> Patch

Re: [Mesa-dev] [PATCH v2] egl_dri2: set correct error code if swapbuffers fails

2016-02-19 Thread Emil Velikov
On 19 February 2016 at 05:40, Tapani Pälli wrote: > Pinging Emil with this one .. > Should have mentioned it beforehand - I pushed it yesterday. Hopefully others won't object :-) Thanks Emil ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] anv: fix warning about unused width variable.

2016-02-19 Thread Jason Ekstrand
On Tue, Feb 16, 2016 at 6:23 PM, Dave Airlie wrote: > From: Dave Airlie > > We don't use width outside the debug clause here. > Thanks > --- > src/vulkan/gen_pack_header.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [Libva] vaPutSurface never returns

2016-02-19 Thread Emil Velikov
Was about to mention the same thing as Christian :-) Vasilis, is there any reason why you're using vdpau + the vdpau to vaapi adapter, as opposed to the gallium vaapi target directly ? Mesa 11.0.x has the said target (toggle with --enable-va at configure time), although there has been quite a

Re: [Mesa-dev] [PATCH v2 1/2] mesa: add GL_OES_texture_border_clamp support

2016-02-19 Thread Ilia Mirkin
On Feb 19, 2016 8:05 AM, "Samuel Iglesias Gonsálvez" wrote: > > On Wed, Feb 17, 2016 at 08:46:36PM -0500, Ilia Mirkin wrote: > > Only minor differences to the existing ARB_texture_border_clamp support. > > > > Signed-off-by: Ilia Mirkin > > --- > > > >

Re: [Mesa-dev] [PATCH 22/22] meta/blit: Use GL_EXT_shader_samples_identical in MSAA-SS resolve blit

2016-02-19 Thread Iago Toral
On Fri, 2016-02-19 at 11:47 +, Neil Roberts wrote: > Iago Toral writes: > > > I don't know much about this, but using shader_samples_identical > > should only give a benefit if we actually get identical samples, > > otherwise it means more work, right? I noticed that the

Re: [Mesa-dev] [PATCH v2 1/2] mesa: add GL_OES_texture_border_clamp support

2016-02-19 Thread Samuel Iglesias Gonsálvez
On Wed, Feb 17, 2016 at 08:46:36PM -0500, Ilia Mirkin wrote: > Only minor differences to the existing ARB_texture_border_clamp support. > > Signed-off-by: Ilia Mirkin > --- > > v1 -> v2: added a patch to add the EXT version of this extension > > docs/GL3.txt

Re: [Mesa-dev] [PATCH 22/22] meta/blit: Use GL_EXT_shader_samples_identical in MSAA-SS resolve blit

2016-02-19 Thread Neil Roberts
Iago Toral writes: > I don't know much about this, but using shader_samples_identical > should only give a benefit if we actually get identical samples, > otherwise it means more work, right? I noticed that the test renders a > quad with random colors for each vertex that will

Re: [Mesa-dev] [PATCH 16/25] radeonsi: add PS prolog

2016-02-19 Thread Marek Olšák
On Tue, Feb 16, 2016 at 5:31 PM, Nicolai Hähnle wrote: > So, patches 12-16 also look good to me except for the comments I've sent on > 12-14. Does this mean I can add your Rb on those? Marek ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] glsl: fix standalone compiler

2016-02-19 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Wed, Feb 17, 2016 at 04:32:11PM -0500, Rob Clark wrote: > From: Rob Clark > > Need to set some non-zero limits for MaxCombinedUniformComponents, > otherwise we hit an "Too many shader uniform components"

Re: [Mesa-dev] [PATCH] i965: Add missing null checks in intel_mipmap_tree.c

2016-02-19 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Wed, Feb 17, 2016 at 05:07:00PM +0200, Juha-Pekka Heikkila wrote: > Just check miptree_create() returned other than NULL as everywhere > else in the file. > > Signed-off-by: Juha-Pekka Heikkila > ---

Re: [Mesa-dev] [PATCH 22/22] meta/blit: Use GL_EXT_shader_samples_identical in MSAA-SS resolve blit

2016-02-19 Thread Iago Toral
On Thu, 2016-02-18 at 16:13 -0800, Ian Romanick wrote: > On 02/18/2016 01:47 PM, Ian Romanick wrote: > > On 02/18/2016 08:44 AM, Neil Roberts wrote: > >> I made a pathological test case (attached) which repeatedly renders into > >> an MSAA FBO and then blits it to the screen and measures the

Re: [Mesa-dev] [PATCH 01/22] i965/meta: Delete unused layer shader uniform

2016-02-19 Thread Iago Toral
On Thu, 2016-02-18 at 16:38 +0100, Iago Toral wrote: > I sent minor comments to patches 3 and 4. I think you should fix the > commit log for the latter at least. Otherwise, patches 1-6 are: > > Reviewed-by: Iago Toral Quiroga And patches 7-22 are also: Reviewed-by: Iago Toral

Re: [Mesa-dev] [PATCH v2] mesa: add GL_OES_texture_stencil8 support

2016-02-19 Thread Eduardo Lima Mitev
Patch needs rebase, but see a comment below. On 02/18/2016 02:27 AM, Ilia Mirkin wrote: > It's basically the same thing as GL_ARB_texture_stencil8 except that > glCopyTexImage isn't supported, so add STENCIL_INDEX to the list of > invalid GLES formats for glCopyTexImage. > > Signed-off-by: Ilia

Re: [Mesa-dev] [PATCH] anv: fix warning about unused width variable.

2016-02-19 Thread Eduardo Lima Mitev
On 02/17/2016 03:23 AM, Dave Airlie wrote: > From: Dave Airlie > > We don't use width outside the debug clause here. > --- This issue is still valid, but patch needs rebasing. There are at least two instances of this problem in gen7_pack.h, maybe more in the rest of pack

Re: [Mesa-dev] [PATCH 2/2] trace: assorted whitespace and formatting fixes

2016-02-19 Thread Eduardo Lima Mitev
Both patches are: Reviewed-by: Eduardo Lima Mitev On 02/19/2016 01:31 AM, Brian Paul wrote: > --- > src/gallium/drivers/trace/tr_context.c | 60 > ++ > 1 file changed, 31 insertions(+), 29 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 20/22] meta/blit: Don't dynamically select the MSAA "emit" function

2016-02-19 Thread Iago Toral
On Wed, 2016-02-17 at 17:58 -0800, Ian Romanick wrote: > From: Ian Romanick > > Just include all 3 versions in the shader. The GLSL type system will > pick the correct one. This simplifies the code a bit, and it helps pave > the way for additional simplifications. >

Re: [Mesa-dev] [Libva] vaPutSurface never returns

2016-02-19 Thread Christian König
Questions for VDPAU should probably go to either the Mesa list or the VDPAU list, libva is completely unrelated to this. Well is it possible that you just locked up the GPU? Please take a look at /sys/kernel/debug/dri/0/radeon_fence_info and dmesg. Regards, Christian. Am 18.02.2016 um 23:43

Re: [Mesa-dev] [PATCH] mesa: Fix test for big-endian architecture in compiler.h

2016-02-19 Thread Jochen Rollwagen
Am 16.02.2016 um 12:40 schrieb Jonathan Gray: On Tue, Feb 16, 2016 at 08:13:45PM +1100, Jonathan Gray wrote: On Tue, Feb 16, 2016 at 10:37:47AM +0200, Oded Gabbay wrote: On Tue, Feb 16, 2016 at 9:23 AM, Jonathan Gray wrote: On Fri, Feb 12, 2016 at 10:01:21AM +0100, Jochen

Re: [Mesa-dev] [PATCH] mesa: small optimization of _mesa_expand_bitmap()

2016-02-19 Thread Kenneth Graunke
On Thursday, February 18, 2016 8:53:09 AM PST Brian Paul wrote: > Avoid a per-pixel multiply. > --- > src/mesa/main/image.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally

Re: [Mesa-dev] [PATCH 3/3] glsl: fix emit_inline_matrix_constructor for doubles

2016-02-19 Thread Kenneth Graunke
On Friday, February 19, 2016 9:25:02 AM PST Iago Toral Quiroga wrote: > Specifically, for the case where we initialize a dmat with a source > matrix that has fewer columns/rows. > --- > src/compiler/glsl/ast_function.cpp | 19 +-- > 1 file changed, 13 insertions(+), 6 deletions(-)

[Mesa-dev] [PATCH 2/3] glsl: Mark float constants as such

2016-02-19 Thread Iago Toral Quiroga
So we don't generate double to conversion float code --- src/compiler/glsl/ast_function.cpp | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp index 238993e..2ed61de 100644 ---

[Mesa-dev] [PATCH 1/3] glsl: fix indentation in emit_inline_matrix_constructor

2016-02-19 Thread Iago Toral Quiroga
--- src/compiler/glsl/ast_function.cpp | 150 ++--- 1 file changed, 75 insertions(+), 75 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp b/src/compiler/glsl/ast_function.cpp index c7fdcb2..238993e 100644 --- a/src/compiler/glsl/ast_function.cpp +++

[Mesa-dev] [PATCH 3/3] glsl: fix emit_inline_matrix_constructor for doubles

2016-02-19 Thread Iago Toral Quiroga
Specifically, for the case where we initialize a dmat with a source matrix that has fewer columns/rows. --- src/compiler/glsl/ast_function.cpp | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/ast_function.cpp