Re: [Mesa-dev] [PATCH 0/9] Skip automatic execsize for instructions with a width of 4

2016-03-08 Thread Pohjolainen, Topi
On Mon, Mar 07, 2016 at 10:48:49AM +0100, Samuel Iglesias Gons?lvez wrote: > Hello, > > There is only one patch from this series that has been reviewed (patch > 1). > > Our plans is to start sending patches for adding fp64 support to i965 > driver in the coming weeks but they depend on these patc

Re: [Mesa-dev] [PATCH] scons: build osmesa swrast and gallium

2016-03-08 Thread Andreas Fänger
> -Ursprüngliche Nachricht- > Von: Roland Scheidegger > Gesendet: Dienstag, 8. März 2016 18:26 > Betreff: Re: [Mesa-dev] [PATCH] scons: build osmesa swrast and gallium > > Not that I really care what you can or can't build (and I won't comment on > build changes), what are those features l

Re: [Mesa-dev] [PATCH 0/9] Skip automatic execsize for instructions with a width of 4

2016-03-08 Thread Pohjolainen, Topi
On Mon, Mar 07, 2016 at 10:48:49AM +0100, Samuel Iglesias Gons?lvez wrote: > Hello, > > There is only one patch from this series that has been reviewed (patch > 1). > > Our plans is to start sending patches for adding fp64 support to i965 > driver in the coming weeks but they depend on these patc

Re: [Mesa-dev] [PATCH 0/9] Skip automatic execsize for instructions with a width of 4

2016-03-08 Thread Pohjolainen, Topi
On Wed, Mar 09, 2016 at 09:07:44AM +0200, Pohjolainen, Topi wrote: > On Mon, Mar 07, 2016 at 10:48:49AM +0100, Samuel Iglesias Gons?lvez wrote: > > Hello, > > > > There is only one patch from this series that has been reviewed (patch > > 1). > > > > Our plans is to start sending patches for addin

Re: [Mesa-dev] [PATCH] scons: build osmesa swrast and gallium

2016-03-08 Thread Andreas Fänger
> -Ursprüngliche Nachricht- > Von: Emil Velikov > Gesendet: Dienstag, 8. März 2016 18:52 > Betreff: Re: [Mesa-dev] [PATCH] scons: build osmesa swrast and gallium > > >> -Ursprüngliche Nachricht- > >> Von: Emil Velikov [mailto:emil.l.veli...@gmail.com] > >> Gesendet: Dienstag, 8. M

Re: [Mesa-dev] [PATCH 0/9] Skip automatic execsize for instructions with a width of 4

2016-03-08 Thread Pohjolainen, Topi
On Mon, Mar 07, 2016 at 10:48:49AM +0100, Samuel Iglesias Gons?lvez wrote: > Hello, > > There is only one patch from this series that has been reviewed (patch > 1). > > Our plans is to start sending patches for adding fp64 support to i965 > driver in the coming weeks but they depend on these patc

Re: [Mesa-dev] [PATCH] glsl: Fix segfault when lhs is error_type TCS

2016-03-08 Thread Timothy Arceri
On Wed, 2016-03-09 at 17:02 +1100, Timothy Arceri wrote: > It seem expected that both lhs and rhs could be of type error_type > in this code however the TCS wasn't expecting it. I'll fix that commit message :P It seems expected that both lhs and rhs can be of type error_type in this code however

Re: [Mesa-dev] [PATCH 00/26] RadeonSI getting ready for interop with HSA/OpenCL

2016-03-08 Thread Nicolai Hähnle
On 02.03.2016 11:36, Marek Olšák wrote: Hi, This patch series contains necessary radeonsi changes in order to support OpenGL-OpenCL interop. This only covers buffer and texture sharing. Patches 1-16, 18-21, 25, and 26 are Reviewed-by: Nicolai Hähnle The changes can be summarized to: - wr

Re: [Mesa-dev] [PATCH 20/26] radeonsi: disable DCC on handle export if expecting write access

2016-03-08 Thread Nicolai Hähnle
On 02.03.2016 11:36, Marek Olšák wrote: From: Marek Olšák This should be okay except that sampler views and images are not re-set. --- src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ src/gallium/drivers/radeon/r600_texture.c | 33 +++ src/gallium/drivers/

Re: [Mesa-dev] [PATCH 17/26] gallium/radeon: disable CMASK on handle export if sharing doesn't allow it

2016-03-08 Thread Nicolai Hähnle
On 08.03.2016 14:35, Marek Olšák wrote: On Tue, Mar 8, 2016 at 4:41 AM, Michel Dänzer wrote: On 03.03.2016 01:36, Marek Olšák wrote: From: Marek Olšák The disabling of CMASK is simple, but notifying all contexts about it is not: - The screen must have a list of all contexts. - Each context m

Re: [Mesa-dev] [PATCH] mesa: Make glGetInteger64v convert float/doubles to 32-bit integers.

2016-03-08 Thread Dave Airlie
On 9 March 2016 at 15:42, Kenneth Graunke wrote: > According to the GL 4.4 core specification, section 2.2.2 ("Data > Conversions For State Query Commands"): > > "If a command returning integer data is called, such as GetIntegerv or > GetInteger64v, a boolean value of TRUE or FALSE is interpreted

[Mesa-dev] [PATCH] nvc0: add support for TGSI FMA ops

2016-03-08 Thread Ilia Mirkin
This will allow the nouveau backend to not try and split up ops that are fused in GLSL. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 5 + src/gallium/drivers/nouveau/nvc0/nvc0_screen.c| 3 ++- 2 files changed, 7 insertions(+), 1 delet

[Mesa-dev] [PATCH] glsl: Fix segfault when lhs is error_type TCS

2016-03-08 Thread Timothy Arceri
It seem expected that both lhs and rhs could be of type error_type in this code however the TCS wasn't expecting it. Fixes segfault in an enhanced layouts GL CTS test. --- src/compiler/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to

[Mesa-dev] [Bug 94456] dEQP-GLES3.functional.state_query.floats.{blend_color, color_clear_value, depth_clear_value}_getinteger64 fail

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94456 Kenneth Graunke changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@l

[Mesa-dev] [PATCH] mesa: Make glGetInteger64v convert float/doubles to 32-bit integers.

2016-03-08 Thread Kenneth Graunke
According to the GL 4.4 core specification, section 2.2.2 ("Data Conversions For State Query Commands"): "If a command returning integer data is called, such as GetIntegerv or GetInteger64v, a boolean value of TRUE or FALSE is interpreted as one or zero, respectively. A floating-point value is r

[Mesa-dev] [Bug 94456] dEQP-GLES3.functional.state_query.floats.{blend_color, color_clear_value, depth_clear_value}_getinteger64 fail

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94456 --- Comment #1 from Kenneth Graunke --- According to the GL 4.4 core specification, section 2.2.2 ("Data Conversions For State Query Commands"): "If a command returning integer data is called, such as GetIntegerv or GetInteger64v, a boo

[Mesa-dev] [PATCH] i965: Set a proper _BaseFormat for window system renderbuffers in ES.

2016-03-08 Thread Kenneth Graunke
intel_alloc_private_renderbuffer_storage did: rb->_BaseFormat = _mesa_base_fbo_format(ctx, internalFormat); Unfortunately, internalFormat was usually an unsized format (such as GL_DEPTH_COMPONENT). In OpenGL ES, _mesa_base_fbo_format() refuses to accept unsized formats, and returns 0 rather t

Re: [Mesa-dev] [PATCH 05/10] radeonsi: ignore PIPE_BIND_LINEAR in si_is_format_supported

2016-03-08 Thread Michel Dänzer
On 08.03.2016 21:21, Christian König wrote: > From: Christian König > > Linear layout should work for all formats as well. The hardware actually doesn't support linear e.g. for compressed formats or depth/stencil formats. -- Earthling Michel Dänzer | http://www.amd

Re: [Mesa-dev] [PATCH 5/5] st/dri: implement the GL interop DRI extension (v2)

2016-03-08 Thread Michel Dänzer
On 09.03.2016 07:52, Marek Olšák wrote: > From: Marek Olšák > > v2: - set interop_version > - simplify the offset_after macro [...] > @@ -1417,6 +1422,254 @@ static const __DRIrobustnessExtension dri2Robustness > = { > .base = { __DRI2_ROBUSTNESS, 1 } > }; > > +#define offset_after(

Re: [Mesa-dev] [PATCH] mesa: Raise GL_INVALID_ENUM for bad textarget in FramebufferTexture*D

2016-03-08 Thread Kenneth Graunke
On Tuesday, March 8, 2016 7:22:18 PM PST Ilia Mirkin wrote: > Actually I filed a dEQP bug for that one: > > https://code.google.com/p/android/issues/detail?id=200911 > > The text says "An INVALID_OPERATION error is generated if texture is > not zero and textarget is not one of TEXTURE_2D, > TEXTU

Re: [Mesa-dev] [PATCH 1/5] include/GL: add mesa_glinterop.h for OpenGL-OpenCL interop (v3)

2016-03-08 Thread Michel Dänzer
On 09.03.2016 07:29, Marek Olšák wrote: > On Tue, Mar 8, 2016 at 4:39 PM, Marek Olšák wrote: >> On Sat, Mar 5, 2016 at 9:53 AM, Michel Dänzer wrote: >>> On 04.03.2016 04:46, Marek Olšák wrote: +/** + * Device information returned by Mesa. + */ +typedef struct _mesa_glinte

[Mesa-dev] [Bug 94447] glsl/glcpp/tests/glcpp-test-cr-lf regression

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94447 Kenneth Graunke changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |kenn...@whitecape.org

[Mesa-dev] [Bug 94447] glsl/glcpp/tests/glcpp-test-cr-lf regression

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94447 Kenneth Graunke changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. |intel-3d-bugs@lists.freedes

[Mesa-dev] [Bug 94447] glsl/glcpp/tests/glcpp-test-cr-lf regression

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94447 Kenneth Graunke changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from Kenneth G

[Mesa-dev] [PATCH] glcpp: Fix locations when encounting "#".

2016-03-08 Thread Kenneth Graunke
We were failing to reset our location tracking when encountering a NEWLINE in the state. Rip the code from the <*>{NEWLINE} rule, which handles this properly. Also, update 146-version-first-hash.c to have proper expectations. When I introduced the test, I didn't verify that the line/column numbe

Re: [Mesa-dev] [PATCH 17/26] gallium/radeon: disable CMASK on handle export if sharing doesn't allow it

2016-03-08 Thread Michel Dänzer
On 09.03.2016 04:35, Marek Olšák wrote: > On Tue, Mar 8, 2016 at 4:41 AM, Michel Dänzer wrote: >> On 03.03.2016 01:36, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> The disabling of CMASK is simple, but notifying all contexts about it is >>> not: >>> - The screen must have a list of all conte

Re: [Mesa-dev] [PATCH RFC 0/2] GBM API extension to support fusing KMS and render devices

2016-03-08 Thread Michel Dänzer
On 08.03.2016 20:36, Daniel Stone wrote: > > GLX is pretty much a dead end here, and there's not a lot we can do > about it. But EGL/X11 is a very real thing that works today (given > that you need it for newer GL versions, I believe ... ?), [...] You believe wrong. See the GLX_ARB_create_conte

[Mesa-dev] [Bug 94447] glsl/glcpp/tests/glcpp-test-cr-lf regression

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94447 --- Comment #4 from Kenneth Graunke --- My test actually exposed another preprocessor bug. Namely, the character location is wrong for hashes on a single line. # #error foo currently generates: 0:1(3): preprocessor error: #error foo which ha

Re: [Mesa-dev] [PATCH 09/10] i965: Add and use is_scheduling_barrier() function.

2016-03-08 Thread Ian Romanick
On 03/08/2016 04:47 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Fri, Mar 4, 2016 at 8:49 PM, Francisco Jerez >> wrote: >>> Matt Turner writes: >>> Though there is a lot of overlap with has_side_effects(), these do mean different things. >>> >>> Can we do it the other way

[Mesa-dev] [Bug 94447] glsl/glcpp/tests/glcpp-test-cr-lf regression

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94447 --- Comment #3 from Kenneth Graunke --- I didn't run "make check". I ran glcpp-test directly. I didn't know glcpp-test-cr-lf existed. It looks like the new 146-* tests pass normal testing, but fail glcpp-test-cr-lf, with different newline term

Re: [Mesa-dev] [PATCH 1/2] dri: add backbuffer use flag

2016-03-08 Thread Ian Romanick
On 03/08/2016 11:11 AM, Marek Olšák wrote: > On Wed, Mar 2, 2016 at 12:05 AM, Marek Olšák wrote: >> On Wed, Mar 2, 2016 at 12:01 AM, Ian Romanick wrote: >>> On 03/01/2016 01:41 PM, Marek Olšák wrote: From: Axel Davy This will be used by the next commit. --- include/GL/i

[Mesa-dev] [PATCH] i965/cfg: Remove redundant #pragma once.

2016-03-08 Thread Francisco Jerez
brw_cfg.h already has include guards, remove the "#pragma once" which is redundant and non-standard. --- src/mesa/drivers/dri/i965/brw_cfg.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_cfg.h b/src/mesa/drivers/dri/i965/brw_cfg.h index 405020b..a2ca6b1 100644 -

[Mesa-dev] [Bug 94456] dEQP-GLES3.functional.state_query.floats.{blend_color, color_clear_value, depth_clear_value}_getinteger64 fail

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94456 Bug ID: 94456 Summary: dEQP-GLES3.functional.state_query.floats.{blend_color, color_clear_value,depth_clear_value}_getinteger64 fail Product: Mesa Version: git Hardware: Ot

[Mesa-dev] [PATCH] i965: Remove useless IR self-destruct backend_shader method.

2016-03-08 Thread Francisco Jerez
From the point it's constructed the CFG contains the only existing copy of the program IR, and it never becomes invalid. Calling backend_shader::invalidate_cfg would have destroyed the program structure irrecoverably -- We weren't calling it at all for a good reason. --- src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH] egl: adds EGL_KHR_reusable_sync to egl_dri

2016-03-08 Thread Dongwon Kim
This patch enables an EGL extension, EGL_KHR_reusable_sync. This new extension basically provides a way for multiple APIs or threads to be excuted synchronously via a "reusable sync" primitive shared by those threads/API calls. This was implemented based on the specification at https://www.khrono

[Mesa-dev] [Bug 94452] dEQP-GLES3.functional.negative_api.texture.generatemipmap fails

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94452 Bug ID: 94452 Summary: dEQP-GLES3.functional.negative_api.texture.generatemip map fails Product: Mesa Version: git Hardware: Other OS: All Statu

Re: [Mesa-dev] [PATCH 09/10] i965: Add and use is_scheduling_barrier() function.

2016-03-08 Thread Francisco Jerez
Matt Turner writes: > On Fri, Mar 4, 2016 at 8:49 PM, Francisco Jerez wrote: >> Matt Turner writes: >> >>> Though there is a lot of overlap with has_side_effects(), these do mean >>> different things. >> >> Can we do it the other way around and implement is_scheduling_barrier() >> in terms of h

[Mesa-dev] [Bug 94447] glsl/glcpp/tests/glcpp-test-cr-lf regression

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94447 --- Comment #2 from Vinson Lee --- (In reply to Ian Romanick from comment #1) > That is odd. Since Ken added some tests, I would think he would have seen > such a failure. > > Vinson, what were you building this on? I can reproduce the make ch

[Mesa-dev] [Bug 94383] build error on i386 when enabling swr

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94383 --- Comment #4 from Tim Rowley --- Hmm, interesting problem. In drivers/swr/avx[2], we set the compiler code generation in AM_CXXFLAGS with -march=. This works fine for normal development building of mesa. In the distribution build environment

[Mesa-dev] [Bug 94447] glsl/glcpp/tests/glcpp-test-cr-lf regression

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94447 --- Comment #1 from Ian Romanick --- That is odd. Since Ken added some tests, I would think he would have seen such a failure. Vinson, what were you building this on? -- You are receiving this mail because: You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH] mesa: Raise GL_INVALID_ENUM for bad textarget in FramebufferTexture*D

2016-03-08 Thread Ilia Mirkin
Actually I filed a dEQP bug for that one: https://code.google.com/p/android/issues/detail?id=200911 The text says "An INVALID_OPERATION error is generated if texture is not zero and textarget is not one of TEXTURE_2D, TEXTURE_2D_MULTISAMPLE, or one of the cube map face targets from table 8.21". A

[Mesa-dev] [PATCH] mesa: Raise GL_INVALID_ENUM for bad textarget in FramebufferTexture*D

2016-03-08 Thread Kenneth Graunke
dEQP-GLES3.functional.negative_api.buffer.framebuffer_texture2d expects glFramebufferTexture[123]D to raise GL_INVALID_ENUM when supplied a completely bogus textarget parameter (i.e. 0x). This patch changes our behavior from GL_INVALID_OPERATION to GL_INVALID_ENUM in this case. The spec i

Re: [Mesa-dev] [PATCH] winsys/amdgpu: enlarge buffer_indices_hashlist

2016-03-08 Thread Marek Olšák
Pushed. Do you even have push access? Marek On Wed, Mar 9, 2016 at 12:50 AM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Tue, Mar 8, 2016 at 4:01 PM, Bas Nieuwenhuizen > wrote: >> Enlarge the buffer hashlist to prevent large numbers of misses >> due to adding more buffers t

Re: [Mesa-dev] [PATCH] winsys/amdgpu: enlarge buffer_indices_hashlist

2016-03-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Mar 8, 2016 at 4:01 PM, Bas Nieuwenhuizen wrote: > Enlarge the buffer hashlist to prevent large numbers of misses > due to adding more buffers than can be cached in the hashlist. > > The game I tested had CS's with up to 1500 buffers and the overhead > of

[Mesa-dev] [Bug 94447] glsl/glcpp/tests/glcpp-test-cr-lf regression

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94447 Bug ID: 94447 Summary: glsl/glcpp/tests/glcpp-test-cr-lf regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW Keywords: bise

Re: [Mesa-dev] [PATCH] nv50/ir: Check for valid insn instead of defs size

2016-03-08 Thread Ilia Mirkin
Patch is fine, description is wrong (or at least inaccurate). The real issue is that function arguments have defs, but no defining instruction. As a result, there's nothing to do when allocating registers. This has nothing to do with $r0, but it does have something to do with the fact that nv50 co

Re: [Mesa-dev] [PATCH] nv50/ir: Check for valid insn instead of defs size

2016-03-08 Thread Samuel Pitoiset
This seems like correct. Reviewed-by: Samuel Pitoiset On 02/25/2016 02:03 AM, Pierre Moreau wrote: On Tesla cards, the first register $r0 contains the thread id; later generations use a specialised register for it. In order to prevent the register from being given to anyone, and thus lose the

Re: [Mesa-dev] [PATCH 1/6] anv/meta: Minimize height of images used for copies

2016-03-08 Thread Anuj Phogat
On Tue, Mar 8, 2016 at 1:00 PM, Nanley Chery wrote: > From: Nanley Chery > > In addition to demystifying the value being added to the height, > this future-proofs the code for new tiling modes and keeps the > image height as small as possible. > > v2: Actually use the smallest height possible. >

Re: [Mesa-dev] [PATCH 09/10] i965: Add and use is_scheduling_barrier() function.

2016-03-08 Thread Matt Turner
On Fri, Mar 4, 2016 at 8:49 PM, Francisco Jerez wrote: > Matt Turner writes: > >> Though there is a lot of overlap with has_side_effects(), these do mean >> different things. > > Can we do it the other way around and implement is_scheduling_barrier() > in terms of has_side_effects()? has_side_ef

[Mesa-dev] [PATCH 2/5] dri_interface: add interface for GL interop with other APIs (v2)

2016-03-08 Thread Marek Olšák
From: Marek Olšák v2: - use const --- include/GL/internal/dri_interface.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 2b49a29..84731a0 100644 --- a/include/GL/internal/dri_interfa

[Mesa-dev] [PATCH 5/5] st/dri: implement the GL interop DRI extension (v2)

2016-03-08 Thread Marek Olšák
From: Marek Olšák v2: - set interop_version - simplify the offset_after macro --- src/gallium/state_trackers/dri/dri2.c | 255 ++ 1 file changed, 255 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c ind

[Mesa-dev] [PATCH 4/5] glx: implement GLX part of interop interface (v2)

2016-03-08 Thread Marek Olšák
From: Marek Olšák v2: - use const --- src/glx/Makefile.am | 1 + src/glx/dri2_glx.c | 11 +++--- src/glx/dri2_priv.h | 16 src/glx/dri3_glx.c | 5 +++ src/glx/dri3_priv.h | 10 + src/glx/dri_common_interop.c | 92 +

[Mesa-dev] [PATCH 3/5] egl: implement EGL part of interop interface (v2)

2016-03-08 Thread Marek Olšák
From: Marek Olšák v2: - use const --- src/egl/drivers/dri2/egl_dri2.c | 32 ++ src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/main/eglapi.c | 72 + src/egl/main/eglapi.h | 9 ++ 4 files changed, 114 insertions(+)

[Mesa-dev] [PATCH 1/5] include/GL: add mesa_glinterop.h for OpenGL-OpenCL interop (v4)

2016-03-08 Thread Marek Olšák
From: Marek Olšák v2: - use "enum" to define stuff v3: - more comments, define MESA_GLINTEROP_UNSUPPORTED v4: - add mesa_glinterop_device_info::interop_version - more comments - remove #define MESA_GLINTEROP_VERSION - use const for "in" --- include/GL/mesa_glinterop.h | 272 +

Re: [Mesa-dev] [PATCH 1/5] include/GL: add mesa_glinterop.h for OpenGL-OpenCL interop (v3)

2016-03-08 Thread Marek Olšák
On Tue, Mar 8, 2016 at 4:39 PM, Marek Olšák wrote: > On Sat, Mar 5, 2016 at 9:53 AM, Michel Dänzer wrote: >> On 04.03.2016 04:46, Marek Olšák wrote: >>> >>> +/** >>> + * Device information returned by Mesa. >>> + */ >>> +typedef struct _mesa_glinterop_device_info { >>> + uint32_t size; /* size

Re: [Mesa-dev] [PATCH 3/3] glsl: don't always reject shaders with mismatching ifc blocks

2016-03-08 Thread Timothy Arceri
On Tue, 2016-03-08 at 10:37 -0500, Ilia Mirkin wrote: > On Tue, Mar 8, 2016 at 8:47 AM, Timothy Arceri > wrote: > > Since we store some member qualifiers in the interface type > > we need to be more careful about rejecting shaders just because > > the pointer doesn't match. Its perfectly valid for

Re: [Mesa-dev] [PATCH 3/3] glsl: don't always reject shaders with mismatching ifc blocks

2016-03-08 Thread Timothy Arceri
On Tue, 2016-03-08 at 16:24 +0100, Samuel Iglesias Gonsálvez wrote: > On Wed, 2016-03-09 at 00:47 +1100, Timothy Arceri wrote: > > Since we store some member qualifiers in the interface type > > we need to be more careful about rejecting shaders just because > > the pointer doesn't match. Its perfe

Re: [Mesa-dev] [PATCH] anv/meta: Use ISL to get the image tile height

2016-03-08 Thread Nanley Chery
On Tue, Mar 08, 2016 at 10:41:24AM -0800, Anuj Phogat wrote: > On Fri, Mar 4, 2016 at 2:03 PM, Nanley Chery wrote: > > From: Nanley Chery > > > > In addition to making the height addition more understandable, this > > future-proofs the code for new tiling modes and keeps the image > > height as s

[Mesa-dev] [PATCH 2/6] anv/meta: Store src and dst usage flags in a variable

2016-03-08 Thread Nanley Chery
From: Nanley Chery Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_meta_blit.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_meta_blit.c b/src/intel/vulkan/anv_meta_blit.c index ecd4d2d..82b79b8 100644 --- a/src/intel/vulkan/anv_meta_bl

[Mesa-dev] [PATCH 6/6] anv/blit2d: Use the tiling enum for simplicity

2016-03-08 Thread Nanley Chery
From: Nanley Chery Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_meta_blit2d.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_meta_blit2d.c b/src/intel/vulkan/anv_meta_blit2d.c index d49b470..6f07342 100644 --- a/src/intel/vulkan/anv_meta_

[Mesa-dev] [PATCH 1/6] anv/meta: Minimize height of images used for copies

2016-03-08 Thread Nanley Chery
From: Nanley Chery In addition to demystifying the value being added to the height, this future-proofs the code for new tiling modes and keeps the image height as small as possible. v2: Actually use the smallest height possible. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_meta_blit.c

[Mesa-dev] [PATCH 4/6] anv/meta: Split anv_meta_blit.c into three files

2016-03-08 Thread Nanley Chery
From: Nanley Chery The new organization is as follows: * anv_meta_blit.c: Blit and state setup/teardown commands * anv_meta_copy.c: Copy and update commands * anv_meta_blit2d.c: 2D Blitter API commands Also, change the formatting to contain most lines within 80 columns. Signed-off-by: Nanley Ch

[Mesa-dev] [PATCH 5/6] anv/meta: Prefix anv_ to meta_emit_blit()

2016-03-08 Thread Nanley Chery
From: Nanley Chery Follow the convention for non-static functions. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_meta.h| 2 +- src/intel/vulkan/anv_meta_blit.c | 4 ++-- src/intel/vulkan/anv_meta_blit2d.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/s

[Mesa-dev] [PATCH 3/6] anv/meta: Make meta_emit_blit() public

2016-03-08 Thread Nanley Chery
From: Nanley Chery This can be reverted if the only other consumer, anv_meta_blit2d(), uses a different method. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_meta.h | 11 +++ src/intel/vulkan/anv_meta_blit.c | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --

Re: [Mesa-dev] [PATCH v2 1/2] nvc0: rework the validation path for 3D

2016-03-08 Thread Ilia Mirkin
Thanks. Series is Reviewed-by: Ilia Mirkin On Tue, Mar 8, 2016 at 3:36 PM, Samuel Pitoiset wrote: > This exposes an interface for state validation that will be also used > to rework the compute validation path. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nvc0/nvc0_co

[Mesa-dev] [PATCH v2 2/2] nvc0: add a new validation path for compute

2016-03-08 Thread Samuel Pitoiset
This makes use of the new state validation interface to be consistent with 3d. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 46 +++-- src/gallium/drivers/nouveau/nvc0/nve4_compute.c | 41 ++ 2 files changed, 39 inser

[Mesa-dev] [PATCH v2 1/2] nvc0: rework the validation path for 3D

2016-03-08 Thread Samuel Pitoiset
This exposes an interface for state validation that will be also used to rework the compute validation path. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 10 +- .../drivers/nouveau/nvc0/nvc0_state_validate.c | 36 ++ src/gall

[Mesa-dev] [PATCH 1/3] radeon/uvd: handle HEVC main 10 decode

2016-03-08 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang Reviewed-by: Alex Deucher --- src/gallium/drivers/radeon/radeon_uvd.c | 69 +++-- 1 file changed, 58 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon/radeon_uvd.c index 6ea07

[Mesa-dev] [PATCH 2/3] radeon/video: enable HEVC main 10 decode

2016-03-08 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang Reviewed-by: Christian König Reviewed-by: Alex Deucher --- src/gallium/drivers/radeon/radeon_video.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_video.c b/src/gallium/drivers/radeon/radeon_video.c ind

Re: [Mesa-dev] [PATCH 1/2] nvc0: rework the validation path for 3D

2016-03-08 Thread Samuel Pitoiset
On 03/08/2016 09:11 PM, Ilia Mirkin wrote: On Tue, Mar 8, 2016 at 3:08 PM, Samuel Pitoiset wrote: This exposes an interface for state validation that will be also used to rework the compute validation path. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/Makefile.sources

Re: [Mesa-dev] [PATCH 1/2] nvc0: rework the validation path for 3D

2016-03-08 Thread Ilia Mirkin
On Tue, Mar 8, 2016 at 3:08 PM, Samuel Pitoiset wrote: > This exposes an interface for state validation that will be also used > to rework the compute validation path. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/Makefile.sources | 1 + > src/gallium/drivers/nouv

[Mesa-dev] [PATCH 1/2] nvc0: rework the validation path for 3D

2016-03-08 Thread Samuel Pitoiset
This exposes an interface for state validation that will be also used to rework the compute validation path. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/Makefile.sources | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 3 -- .../drivers/nouveau/nvc0/nvc0_sta

[Mesa-dev] [PATCH 2/2] nvc0: add a new validation path for compute

2016-03-08 Thread Samuel Pitoiset
This makes use of the new state validation interface to be consistent with 3d. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 47 +++-- src/gallium/drivers/nouveau/nvc0/nve4_compute.c | 42 +++--- 2 files changed, 41 inser

[Mesa-dev] [PATCH 3/3] st/va: add HEVC main 10 profile

2016-03-08 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang Reviewed-by: Christian König Reviewed-by: Alex Deucher --- src/gallium/state_trackers/va/va_private.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/va_private.h b/src/gallium/state_trackers/va/va_private.h inde

[Mesa-dev] [PATCH v2 2/2] mesa: docs: Intel i965 hardware limits.

2016-03-08 Thread Sarah Sharp
v2: - use \name doxygen format instead of @defgroup, which creates a separate module - addresses comments by Ian back in December 8<->8 This should help the next person working on hardware enabling figure out where in the Intel P

[Mesa-dev] [PATCH v2 1/2] mesa: docs: i965: Use correct doxygen groupings syntax

2016-03-08 Thread Sarah Sharp
v2: - use \name doxygen format instead of @defgroup, which creates a separate module - addresses comments by Ian back in December 8<->8 When reading the source code, it's useful to indicate that a group of fields in a struct are

Re: [Mesa-dev] [PATCH 17/26] gallium/radeon: disable CMASK on handle export if sharing doesn't allow it

2016-03-08 Thread Marek Olšák
On Tue, Mar 8, 2016 at 4:41 AM, Michel Dänzer wrote: > On 03.03.2016 01:36, Marek Olšák wrote: >> From: Marek Olšák >> >> The disabling of CMASK is simple, but notifying all contexts about it is not: >> - The screen must have a list of all contexts. >> - Each context must have a monotonic counter

Re: [Mesa-dev] [PATCH 09/26] gallium/radeon: buffer valid range tracking only works with unshared buffers

2016-03-08 Thread Marek Olšák
On Tue, Mar 8, 2016 at 4:40 AM, Michel Dänzer wrote: > On 03.03.2016 01:36, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeon/r600_buffer_common.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c >> b/src/g

Re: [Mesa-dev] [PATCH 1/2] dri: add backbuffer use flag

2016-03-08 Thread Marek Olšák
On Wed, Mar 2, 2016 at 12:05 AM, Marek Olšák wrote: > On Wed, Mar 2, 2016 at 12:01 AM, Ian Romanick wrote: >> On 03/01/2016 01:41 PM, Marek Olšák wrote: >>> From: Axel Davy >>> >>> This will be used by the next commit. >>> --- >>> include/GL/internal/dri_interface.h | 1 + >>> src/egl/drive

Re: [Mesa-dev] [PATCH 15/21] nir: Add a function for comparing cursors

2016-03-08 Thread Connor Abbott
On Tue, Mar 8, 2016 at 1:34 PM, Jason Ekstrand wrote: > > > On Wed, Feb 24, 2016 at 10:45 PM, Connor Abbott wrote: >> >> On Sat, Feb 13, 2016 at 9:14 PM, Jason Ekstrand >> wrote: >> > --- >> > src/compiler/nir/nir.c | 63 >> > ++ >> > src/compiler

Re: [Mesa-dev] [PATCH] anv/meta: Use ISL to get the image tile height

2016-03-08 Thread Anuj Phogat
On Fri, Mar 4, 2016 at 2:03 PM, Nanley Chery wrote: > From: Nanley Chery > > In addition to making the height addition more understandable, this > future-proofs the code for new tiling modes and keeps the image > height as small as possible. > > Signed-off-by: Nanley Chery > --- > src/intel/vul

Re: [Mesa-dev] [PATCH] nir: Add a pass for lower indirect variable dereferences

2016-03-08 Thread Jason Ekstrand
On Wed, Feb 24, 2016 at 10:25 PM, Connor Abbott wrote: > On Sat, Feb 13, 2016 at 8:48 PM, Jason Ekstrand > wrote: > > This new pass lowers load/store_var intrinsics that act on indirect > derefs > > to if-ladder of direct load/store_var intrinsics. The if-ladders > perform a > > simple binary s

Re: [Mesa-dev] [PATCH 15/21] nir: Add a function for comparing cursors

2016-03-08 Thread Jason Ekstrand
On Wed, Feb 24, 2016 at 10:45 PM, Connor Abbott wrote: > On Sat, Feb 13, 2016 at 9:14 PM, Jason Ekstrand > wrote: > > --- > > src/compiler/nir/nir.c | 63 > ++ > > src/compiler/nir/nir.h | 2 ++ > > 2 files changed, 65 insertions(+) > > > > diff

[Mesa-dev] [Bug 92877] Add support for libglvnd

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 Kyle Brenneman changed: What|Removed |Added CC||kyle.brenne...@gmail.com -- You are re

[Mesa-dev] [Bug 92877] Add support for libglvnd

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 --- Comment #1 from Kyle Brenneman --- The current libglvnd interface only allows a dispatch table for each vendor library. Using libglvnd's dispatching in place of Mesa's would either require changing that interface or exposing Mesa as multiple

Re: [Mesa-dev] [PATCH] nv50, nvc0: make sure to destroy the mutex used for blits

2016-03-08 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Tue, Mar 8, 2016 at 1:01 PM, Samuel Pitoiset wrote: > This mutex is initialized when the blitter is created, but it is never > destroyed. This doesn't hurt anything but it makes sense to destroy it > at blitter deletion. > > Signed-off-by: Samuel Pitoiset > --- > sr

[Mesa-dev] [PATCH] nv50, nvc0: make sure to destroy the mutex used for blits

2016-03-08 Thread Samuel Pitoiset
This mutex is initialized when the blitter is created, but it is never destroyed. This doesn't hurt anything but it makes sense to destroy it at blitter deletion. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv50/nv50_surface.c | 1 + src/gallium/drivers/nouveau/nvc0/nvc0_surfa

[Mesa-dev] [PATCH] gallium/swr: remove use of BYTE from swr driver

2016-03-08 Thread Tim Rowley
Remove use of a win32-style type leaked from the swr rasterizer. --- src/gallium/drivers/swr/swr_memory.h| 8 src/gallium/drivers/swr/swr_scratch.cpp | 8 src/gallium/drivers/swr/swr_screen.cpp | 4 ++-- src/gallium/drivers/swr/swr_state.cpp | 8 4 files changed,

Re: [Mesa-dev] [PATCH] scons: build osmesa swrast and gallium

2016-03-08 Thread Emil Velikov
On 8 March 2016 at 12:06, Andreas Fänger wrote: >> -Ursprüngliche Nachricht- >> Von: Emil Velikov [mailto:emil.l.veli...@gmail.com] >> Gesendet: Dienstag, 8. März 2016 12:33 >> >> On 8 March 2016 at 11:04, Andreas Fänger wrote: >> > This patch makes it possible to build classic osmesa/swr

Re: [Mesa-dev] [PATCH] scons: build osmesa swrast and gallium

2016-03-08 Thread Roland Scheidegger
Not that I really care what you can or can't build (and I won't comment on build changes), what are those features lacking in llvmpipe, beside from anisotropic filtering (which I always considered essentially useless for a software renderer, albeit interesting if you're curious about the math invol

Re: [Mesa-dev] [PATCH RFC 0/2] GBM API extension to support fusing KMS and render devices

2016-03-08 Thread Emil Velikov
Hi Dan, Summarising and stating some unsaid assumptions. Assumptions: - The proposed solution is a replacement of the wrapped drivers approach. No, it's meant to introduce an API mostly gears towards DRI_PRIME setups. - Wrapped drivers will/could/should be done outside the SoC world (i.e. with

[Mesa-dev] [Bug 94383] build error on i386 when enabling swr

2016-03-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94383 Fabio Pedretti changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

Re: [Mesa-dev] [PATCH 1/5] include/GL: add mesa_glinterop.h for OpenGL-OpenCL interop (v3)

2016-03-08 Thread Marek Olšák
On Thu, Mar 3, 2016 at 11:56 PM, Emil Velikov wrote: > Hi Marek, > > A small question, and a few trivial suggestions. Hopefully I'm not too > late for the party. > > On 3 March 2016 at 19:46, Marek Olšák wrote: > >> +typedef struct _mesa_glinterop_device_info { >> + uint32_t size; /* size of th

Re: [Mesa-dev] [PATCH 1/5] include/GL: add mesa_glinterop.h for OpenGL-OpenCL interop (v3)

2016-03-08 Thread Marek Olšák
On Sat, Mar 5, 2016 at 9:53 AM, Michel Dänzer wrote: > On 04.03.2016 04:46, Marek Olšák wrote: >> >> +/** >> + * Device information returned by Mesa. >> + */ >> +typedef struct _mesa_glinterop_device_info { >> + uint32_t size; /* size of this structure */ > > Callees determine how much data they

Re: [Mesa-dev] [PATCH 3/3] glsl: don't always reject shaders with mismatching ifc blocks

2016-03-08 Thread Ilia Mirkin
On Tue, Mar 8, 2016 at 8:47 AM, Timothy Arceri wrote: > Since we store some member qualifiers in the interface type > we need to be more careful about rejecting shaders just because > the pointer doesn't match. Its perfectly valid for some qualifiers > such as precision to not match across shader

Re: [Mesa-dev] [PATCH] i965/fs: Recognize constants can be loaded by subtracting from 1.0.

2016-03-08 Thread Iago Toral
On Mon, 2016-02-29 at 22:06 -0800, Matt Turner wrote: > Some shaders from Synmark contain this loop: > >for (float i = 0.02; i < 0.9; i += 0.11) > > and in its body it uses both i and (1.0 - i). All 16 immediates are > promoted to registers (they're used by 3-src MAD instructions). By > recog

Re: [Mesa-dev] [PATCH 3/3] glsl: don't always reject shaders with mismatching ifc blocks

2016-03-08 Thread Samuel Iglesias Gonsálvez
On Wed, 2016-03-09 at 00:47 +1100, Timothy Arceri wrote: > Since we store some member qualifiers in the interface type > we need to be more careful about rejecting shaders just because > the pointer doesn't match. Its perfectly valid for some qualifiers > such as precision to not match across shade

Re: [Mesa-dev] [PATCH] glsl: avoid stack smashing when there are too many attributes

2016-03-08 Thread Iago Toral
On Tue, 2016-03-08 at 10:01 -0500, Ilia Mirkin wrote: > On Tue, Mar 8, 2016 at 9:54 AM, Iago Toral wrote: > > On Sun, 2016-03-06 at 12:21 -0500, Ilia Mirkin wrote: > >> This fixes a crash in > >> > >> dEQP-GLES3.functional.transform_feedback.array_element.separate.points.lowp_mat3x2 > >> > >> and

[Mesa-dev] [PATCH] winsys/amdgpu: enlarge buffer_indices_hashlist

2016-03-08 Thread Bas Nieuwenhuizen
Enlarge the buffer hashlist to prevent large numbers of misses due to adding more buffers than can be cached in the hashlist. The game I tested had CS's with up to 1500 buffers and the overhead of amdgpu_lookup_buffer for various sizes was: 4096 1.97% (new value) 2048 4.37% 1024 6.92% 512 9.47%

Re: [Mesa-dev] [PATCH] glsl: avoid stack smashing when there are too many attributes

2016-03-08 Thread Ilia Mirkin
On Tue, Mar 8, 2016 at 9:54 AM, Iago Toral wrote: > On Sun, 2016-03-06 at 12:21 -0500, Ilia Mirkin wrote: >> This fixes a crash in >> >> dEQP-GLES3.functional.transform_feedback.array_element.separate.points.lowp_mat3x2 >> >> and likely others. The vertex shader has > 16 input variables (without >

  1   2   >