Re: [Mesa-dev] [RFC] i965/dbg: Expose cases hitting a presumably dead optimization

2016-03-11 Thread Pohjolainen, Topi
On Fri, Mar 11, 2016 at 05:59:37PM -0800, Jason Ekstrand wrote: >On Fri, Mar 11, 2016 at 4:40 AM, Topi Pohjolainen ><[1]topi.pohjolai...@intel.com> wrote: > > The logic iterates over param[] which contains pointers to > uniform storage set during linking (see >

Re: [Mesa-dev] [PATCH] i965: Ignore glPointSize when GL_POINT_SIZE_ARRAY_OES is enabled

2016-03-11 Thread Kenneth Graunke
On Wednesday, March 2, 2016 10:58:46 AM PST Plamena Manolova wrote: > When a user defines a point size array and enables it, the point > size value set via glPointSize should be ignored. To achieve this, > we can simply set ctx->VertexProgram.PointSizeEnabled whenever > GL_POINT_SIZE_ARRAY_OES is

Re: [Mesa-dev] [RFC] i965/dbg: Expose cases hitting a presumably dead optimization

2016-03-11 Thread Jason Ekstrand
On Fri, Mar 11, 2016 at 4:40 AM, Topi Pohjolainen < topi.pohjolai...@intel.com> wrote: > The logic iterates over param[] which contains pointers to > uniform storage set during linking (see > link_assign_uniform_locations()). > > The pointers are unique and it should be impossible to find >

Re: [Mesa-dev] [PATCH 01/14] nir: Add explicitly sized types

2016-03-11 Thread Jason Ekstrand
On Thu, Mar 10, 2016 at 11:33 PM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > > > On 11/03/16 01:08, Jason Ekstrand wrote: > > On Thu, Mar 10, 2016 at 4:00 PM, Connor Abbott > > wrote: > > > >> On Mon, Mar

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

2016-03-11 Thread Martin Peres
On 10/03/16 20:07, Adam Jackson wrote: On Thu, 2016-03-10 at 10:53 -0700, Kyle Brenneman wrote: On 03/10/2016 10:47 AM, Martin Peres wrote: That could be a hacky way of handling the case where multiple 3D drivers could be used to drive the same GPU. This may be necessary in the future if two

[Mesa-dev] [Bug 92877] Add support for libglvnd

2016-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92877 --- Comment #2 from Emil Velikov --- Need to give it a bit more thought, but I'm mostly confident that per context dispatch table should be we enough. Sorry head has been busy with other stuff recently (family member

Re: [Mesa-dev] Mesa include guard style. (Was: [PATCH] i965/cfg: Remove redundant #pragma once.)

2016-03-11 Thread Eric Anholt
Ian Romanick writes: > On 03/10/2016 05:53 PM, Francisco Jerez wrote: >> Iago Toral writes: >> >>> On Wed, 2016-03-09 at 19:04 -0800, Francisco Jerez wrote: Matt Turner writes: > On Wed, Mar 9, 2016 at 1:37 PM,

Re: [Mesa-dev] [PATCH 1/5] include/GL: add mesa_glinterop.h for OpenGL-OpenCL interop (v3)

2016-03-11 Thread Emil Velikov
On 9 March 2016 at 18:36, Marek Olšák wrote: > On Wed, Mar 9, 2016 at 6:51 PM, Emil Velikov wrote: >> On 9 March 2016 at 17:11, Marek Olšák wrote: >>> On Wed, Mar 9, 2016 at 4:31 PM, Emil Velikov >>>

Re: [Mesa-dev] [PATCH 1/5] include/GL: add mesa_glinterop.h for OpenGL-OpenCL interop (v3)

2016-03-11 Thread Emil Velikov
On 9 March 2016 at 18:17, Marek Olšák wrote: > On Wed, Mar 9, 2016 at 6:58 PM, Emil Velikov wrote: >> On 9 March 2016 at 17:28, Marek Olšák wrote: >>> On Wed, Mar 9, 2016 at 4:47 PM, Emil Velikov >>>

[Mesa-dev] [PATCH] swrast: Delete the unused 'slice' parameter

2016-03-11 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/swrast/s_texture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/swrast/s_texture.c b/src/mesa/swrast/s_texture.c index 9ccd0e3..6ea7b6c 100644 --- a/src/mesa/swrast/s_texture.c +++

Re: [Mesa-dev] LLVMInitializeAMDGPU* undefined?

2016-03-11 Thread Emil Velikov
Hi Chih-Wei, On 11 March 2016 at 02:09, Chih-Wei Huang wrote: > 2016年3月10日 下午6:47於 "Marek Olšák" 寫道: >> >> Those functions are only supported by LLVM 3.7 and later, and if you >> have such a version, the AMDGPU backend must be enabled in your LLVM >>

Re: [Mesa-dev] [PATCH 2/4] r600g: remove TGSI->LLVM translation

2016-03-11 Thread Jan Vesely
On Fri, 2016-03-11 at 20:48 +0100, Marek Olšák wrote: > On Fri, Mar 11, 2016 at 7:24 PM, Jan Vesely > wrote: > > > > On Fri, 2016-03-11 at 18:48 +0100, Marek Olšák wrote: > > > > > > Can you paste the build failures please? > > In file included from

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

2016-03-11 Thread Adam Jackson
On Fri, 2016-03-11 at 11:12 -0700, Kyle Brenneman wrote: > All right, here's an updated draft of the Issues section. How does it look? > > Issues >  1)  Should GLX_VENDOR_NAMES_EXT contain a single vendor name or a list of >  names? > >  UNRESOLVED: Allow a list of names. >

Re: [Mesa-dev] [GSoC2016] Interested in implementing "Soft" double precision floating point support

2016-03-11 Thread Ian Romanick
On 03/10/2016 03:09 PM, Dylan Baker wrote: > Quoting Marek Olšák (2016-03-10 06:57:57) >> On Thu, Mar 10, 2016 at 3:30 PM, tournier.elie >> wrote: >>> First, thank you all for your answers. >>> >>> So if I summarize what was said, we need >>> Ian: >>> - add >>> -

[Mesa-dev] [Bug 94503] OpenCL segfaults during compilation

2016-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94503 --- Comment #1 from Matt Arsenault --- This compiles fine with trunk llvm. This backtrace looks sort of familiar, and I think it was fixed within the last 3 months -- You are receiving this mail because: You are the assignee

[Mesa-dev] [Bug 94503] OpenCL segfaults during compilation

2016-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94503 Bug ID: 94503 Summary: OpenCL segfaults during compilation Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] mesa: Fix error condition for 1d array texture

2016-03-11 Thread Alejandro Piñeiro
On 11/03/16 20:15, Anuj Phogat wrote: > yoffset is also applicable to 1d array textures. > > Signed-off-by: Anuj Phogat > --- > I don't know if it fixes any test, but it looked incorrect to me. No one fixed doing a piglit all.py run (also no regression). Didn't test with a

Re: [Mesa-dev] [PATCH 08/10] nir: Simplify 0 < fabs(a)

2016-03-11 Thread Matt Turner
On Fri, Mar 11, 2016 at 11:21 AM, Ian Romanick wrote: > On 03/11/2016 08:51 AM, Patrick Baggett wrote: >> On Fri, Mar 11, 2016 at 10:21 AM, Ian Romanick wrote: >>> On 03/10/2016 01:24 PM, Patrick Baggett wrote: On Thu, Mar 10, 2016 at 3:08 PM,

Re: [Mesa-dev] [PATCH] radeonsi: avoid crash when a sampler state is bound for a buffer texture

2016-03-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Mar 11, 2016 at 5:17 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Sampler states don't really make sense with buffer textures, but the PBO > upload code sets one because apparently

Re: [Mesa-dev] [PATCH 2/4] r600g: remove TGSI->LLVM translation

2016-03-11 Thread Marek Olšák
On Fri, Mar 11, 2016 at 7:24 PM, Jan Vesely wrote: > On Fri, 2016-03-11 at 18:48 +0100, Marek Olšák wrote: >> Can you paste the build failures please? > > In file included from compute_memory_pool.c:42:0: > evergreen_compute_internal.h:43:2: error: unknown type name

Re: [Mesa-dev] [PATCH 08/10] nir: Simplify 0 < fabs(a)

2016-03-11 Thread Ian Romanick
On 03/11/2016 08:51 AM, Patrick Baggett wrote: > On Fri, Mar 11, 2016 at 10:21 AM, Ian Romanick wrote: >> On 03/10/2016 01:24 PM, Patrick Baggett wrote: >>> On Thu, Mar 10, 2016 at 3:08 PM, Patrick Baggett >>> wrote: On Thu, Mar 10, 2016 at

[Mesa-dev] [PATCH] mesa: Fix error condition for 1d array texture

2016-03-11 Thread Anuj Phogat
yoffset is also applicable to 1d array textures. Signed-off-by: Anuj Phogat --- I don't know if it fixes any test, but it looked incorrect to me. src/mesa/main/texgetimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/texgetimage.c

Re: [Mesa-dev] [PATCH] egl: fix for multiple window surfaces per single window

2016-03-11 Thread Ian Romanick
Most of comments that follow are related to Mesa coding standards. Many of these comments apply to "egl: updating surface size on x11" and "egl: Fix for not setting EGL_BAD_MATCH by eglCreatePbufferSurface.". I'm not sure how you're sending these patches, but you really, really should use

Re: [Mesa-dev] [PATCH 2/4] r600g: remove TGSI->LLVM translation

2016-03-11 Thread Jan Vesely
On Fri, 2016-03-11 at 18:48 +0100, Marek Olšák wrote: > Can you paste the build failures please? In file included from compute_memory_pool.c:42:0: evergreen_compute_internal.h:43:2: error: unknown type name ‘LLVMContextRef’   LLVMContextRef llvm_ctx;   ^ In file included from

Re: [Mesa-dev] [PATCH 2/4] r600g: remove TGSI->LLVM translation

2016-03-11 Thread Grazvydas Ignotas
On Fri, Mar 11, 2016 at 7:48 PM, Marek Olšák wrote: > Can you paste the build failures please? In file included from compute_memory_pool.c:42:0: evergreen_compute_internal.h:43:2: error: unknown type name ‘LLVMContextRef’ LLVMContextRef llvm_ctx; ^ evergreen_compute.c: In

Re: [Mesa-dev] Mesa include guard style. (Was: [PATCH] i965/cfg: Remove redundant #pragma once.)

2016-03-11 Thread Ian Romanick
On 03/10/2016 05:53 PM, Francisco Jerez wrote: > Iago Toral writes: > >> On Wed, 2016-03-09 at 19:04 -0800, Francisco Jerez wrote: >>> Matt Turner writes: >>> On Wed, Mar 9, 2016 at 1:37 PM, Francisco Jerez wrote: >

Re: [Mesa-dev] GLX extension for vendor name lookup in libglvnd

2016-03-11 Thread Kyle Brenneman
All right, here's an updated draft of the Issues section. How does it look? Issues 1) Should GLX_VENDOR_NAMES_EXT contain a single vendor name or a list of names? UNRESOLVED: Allow a list of names. Allowing multiple names would allow for multiple client-side

Re: [Mesa-dev] [PATCH 2/3] st/mesa: set TGSI property NEXT_SHADER

2016-03-11 Thread Grazvydas Ignotas
On Thu, Mar 10, 2016 at 7:36 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 35 > ++ > 1 file changed, 35 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 2/4] r600g: remove TGSI->LLVM translation

2016-03-11 Thread Marek Olšák
Can you paste the build failures please? Marek On Fri, Mar 11, 2016 at 5:11 PM, Jan Vesely wrote: > On Fri, 2016-03-11 at 16:01 +0100, Marek Olšák wrote: >> From: Marek Olšák >> >> It was useful for testing and as a prototype for radeonsi bringup,

Re: [Mesa-dev] [PATCH] egl: updating surface size on x11

2016-03-11 Thread Matt Turner
On Fri, Mar 11, 2016 at 12:24 AM, Pielech, Adrian wrote: > I've found that EGLSurface width and height are not updated after window > resizing on x11. > Here is the patch for this issue. > > --- > src/egl/drivers/dri2/platform_x11.c | 16 > 1 file

Re: [Mesa-dev] [PATCH 08/10] nir: Simplify 0 < fabs(a)

2016-03-11 Thread Patrick Baggett
On Fri, Mar 11, 2016 at 10:21 AM, Ian Romanick wrote: > On 03/10/2016 01:24 PM, Patrick Baggett wrote: >> On Thu, Mar 10, 2016 at 3:08 PM, Patrick Baggett >> wrote: >>> On Thu, Mar 10, 2016 at 12:25 PM, Ian Romanick wrote:

Re: [Mesa-dev] [PATCH 1/3] gallium: add TGSI property NEXT_SHADER

2016-03-11 Thread Nicolai Hähnle
Good idea. Series is Reviewed-by: Nicolai Hähnle On 10.03.2016 12:36, Marek Olšák wrote: From: Marek Olšák Radeonsi needs to know which shader stage will execute after a shader in order to make the best decision about which shader variant to

Re: [Mesa-dev] [PATCH v2] radeonsi: Lazily re-set sampler views after disabling DCC

2016-03-11 Thread Nicolai Hähnle
On 10.03.2016 11:57, Bas Nieuwenhuizen wrote: Clear DCC flags if necessary when binding a new sampler view. v2: Do not reset DCC flags of bound sampler views. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeon/r600_texture.c | 2 --

Re: [Mesa-dev] [PATCH 08/10] nir: Simplify 0 < fabs(a)

2016-03-11 Thread Ian Romanick
On 03/10/2016 01:24 PM, Patrick Baggett wrote: > On Thu, Mar 10, 2016 at 3:08 PM, Patrick Baggett > wrote: >> On Thu, Mar 10, 2016 at 12:25 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Sandy Bridge / Ivy Bridge

[Mesa-dev] [PATCH] radeonsi: avoid crash when a sampler state is bound for a buffer texture

2016-03-11 Thread Nicolai Hähnle
From: Nicolai Hähnle Sampler states don't really make sense with buffer textures, but the PBO upload code sets one because apparently nouveau needs it. It would be nice to work that out at some point, but in any case being defensive here is a good idea. Bugzilla:

Re: [Mesa-dev] [PATCH 2/4] r600g: remove TGSI->LLVM translation

2016-03-11 Thread Jan Vesely
On Fri, 2016-03-11 at 16:01 +0100, Marek Olšák wrote: > From: Marek Olšák > > It was useful for testing and as a prototype for radeonsi bringup, > but it's not used anymore and doesn't support OpenGL 3.3 even. This breaks OpenCL on pre-SI (does not even build). Jan > ---

Re: [Mesa-dev] [PATCH] gallium/swr: Resource management

2016-03-11 Thread Kyriazis, George
Reviewed-By: George Kyriazis > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of BruceCherniak > Sent: Wednesday, March 9, 2016 7:30 PM > To: mesa-dev@lists.freedesktop.org > Subject: [Mesa-dev] [PATCH] gallium/swr: Resource management > >

[Mesa-dev] [PATCH 3/4] r600g: flatten if (1) statement after removal of TGSI->LLVM

2016-03-11 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/r600_shader.c | 160 - 1 file changed, 79 insertions(+), 81 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 49a1876..77658f5

[Mesa-dev] [PATCH 2/4] r600g: remove TGSI->LLVM translation

2016-03-11 Thread Marek Olšák
From: Marek Olšák It was useful for testing and as a prototype for radeonsi bringup, but it's not used anymore and doesn't support OpenGL 3.3 even. --- configure.ac | 15 +- src/gallium/drivers/r600/Makefile.am | 8 -

[Mesa-dev] [PATCH 1/4] gallium/radeon: remove old CS tracing

2016-03-11 Thread Marek Olšák
From: Marek Olšák Cons: - it was only integrated in r600g - it doesn't work with GPUVM - it records buffer contents at the end of IBs instead of at the beginning, so the replay isn't exact - it lacks an IB parser and user-friendliness A better solution is apitrace in

[Mesa-dev] [PATCH 4/4] gallium/radeon: remove remnants of R600 TGSI->LLVM

2016-03-11 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/radeon_llvm.h| 17 - src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 3 --- 2 files changed, 20 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_llvm.h

[Mesa-dev] [PATCH 2/2] i965/fs: fix copy propagation of partially invalidated entries

2016-03-11 Thread Iago Toral Quiroga
We were not invalidating entries with a src that reads more than 1 register when we find writes that overwrite any register read by entry->src after the first. This leads to incorrect copy propagation because we re-use entries from the ACP that have been partially invalidated. ---

[Mesa-dev] [PATCH 1/2] i965/fs: fix copy/constant propagation regioning checks

2016-03-11 Thread Iago Toral Quiroga
We were not accounting for reg_suboffset in the check for the start of the region. Also, fs_reg::regs_read() already takes the stride into account, so we should not multiply its result by the stride again. Incidentally, the stride fix opens more possibilities for copy-propagation which uncovered

[Mesa-dev] [RFC] i965/dbg: Expose cases hitting a presumably dead optimization

2016-03-11 Thread Topi Pohjolainen
The logic iterates over param[] which contains pointers to uniform storage set during linking (see link_assign_uniform_locations()). The pointers are unique and it should be impossible to find matching entries. I couldn't find any regressions with test system. In addition I tried several

[Mesa-dev] [PATCH] glsl: dont remove arrays from interface type when lowering

2016-03-11 Thread Timothy Arceri
Commit d6863acb9f40 added support for interface block arrays but when storing the interface type in the lowering pass it stored the type with arrays removed. Commit 4b97c581b4f8 went on to work around this by adding flags to the IR from_named_ifc_block_array and from_named_ifc_block_nonarray.

[Mesa-dev] [Bug 94491] osmesa gallium build with scons on windows is missing a lot of GL* symbols

2016-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94491 --- Comment #1 from Andreas Fänger --- Created attachment 10 --> https://bugs.freedesktop.org/attachment.cgi?id=10=edit dumpbin-osmesa-10.5.9-swrast -- You are receiving this mail because: You are the assignee

[Mesa-dev] [Bug 94491] osmesa gallium build with scons on windows is missing a lot of GL* symbols

2016-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94491 Bug ID: 94491 Summary: osmesa gallium build with scons on windows is missing a lot of GL* symbols Product: Mesa Version: git Hardware: Other OS: Windows

[Mesa-dev] [Bug 94489] osmesa gallium build with scons on linux contains no OSMesa* and GL* symbols

2016-03-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94489 Bug ID: 94489 Summary: osmesa gallium build with scons on linux contains no OSMesa* and GL* symbols Product: Mesa Version: git Hardware: Other OS: Linux

Re: [Mesa-dev] [PATCH] st/mesa: check that the image unit is valid in st_bind_images

2016-03-11 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Mar 11, 2016 at 12:27 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/mesa/state_tracker/st_atom_image.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH] egl: updating surface size on x11

2016-03-11 Thread Michel Dänzer
On 11.03.2016 17:24, Pielech, Adrian wrote: > I've found that EGLSurface width and height are not updated after window > resizing on x11. > Here is the patch for this issue. > > --- > src/egl/drivers/dri2/platform_x11.c | 16 > 1 file changed, 16 insertions(+) > > diff --git

Re: [Mesa-dev] LLVMInitializeAMDGPU* undefined?

2016-03-11 Thread Marek Olšák
On Fri, Mar 11, 2016 at 4:50 AM, Jan Vesely wrote: > On Fri, 2016-03-11 at 10:09 +0800, Chih-Wei Huang wrote: >> 2016年3月10日 下午6:47於 "Marek Olšák" 寫道: >> > >> > >> > Those functions are only supported by LLVM 3.7 and later, and if >> > you >> > have such a

[Mesa-dev] [PATCH] egl: fix for multiple window surfaces per single window

2016-03-11 Thread Pielech, Adrian
Current implementation of eglCreateWindowSurface() is against to the EGL specification, because it allows creating multiple surfaces per single window. --- src/egl/main/eglapi.c | 109 +- 1 file changed, 107 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH v2] scons: build osmesa swrast and gallium

2016-03-11 Thread Andreas Fänger
This patch makes it possible to build classic osmesa/swrast on windows again. Although there is a gallium version of osmesa now, the swrast version still has more features lacking in llvmpipe, e.g. anisotropic filtering. This reverts commit 69db422218b0264b5b8eef45bd003a2544e9cbd6 and

[Mesa-dev] [PATCH v2] scons: build osmesa swrast and gallium

2016-03-11 Thread Andreas Fänger
Here is the updated patch once more to include the "v2" label and to add the 11.2 stable tag as suggested by Emil Velikov. The 2nd version of the patch also reverts changes to Makefile.am Andreas Fänger (1): scons: build osmesa swrast and gallium src/mesa/drivers/SConscript | 2 ++

[Mesa-dev] [PATCH] egl: updating surface size on x11

2016-03-11 Thread Pielech, Adrian
I've found that EGLSurface width and height are not updated after window resizing on x11. Here is the patch for this issue. --- src/egl/drivers/dri2/platform_x11.c | 16 1 file changed, 16 insertions(+) diff --git a/src/egl/drivers/dri2/platform_x11.c