[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2016-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #61 from James Jones --- I'm on paternity leave from January 25th - April 15th. While I'm out, please contact the following people: linux-b...@nvidia.com for Linux graphics bug triage issues Damien Leone

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2016-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 --- Comment #60 from Furkan --- Has this been resolved for anybody? I'm running Xorg 1.18.2 and Mesa 11.2rc3. I still get the same corruption, with both DRI2 and DRI3. -- You are receiving this mail because: You are the

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-25 Thread Stéphane Marchesin
On Wed, Mar 23, 2016 at 5:22 PM, Rob Herring wrote: > On Fri, Mar 4, 2016 at 12:07 PM, Rob Clark wrote: >> On Fri, Mar 4, 2016 at 12:59 PM, Rob Clark wrote: >>> So, I've been advocating that for android, gallium drivers use >>>

[Mesa-dev] [Bug 94711] Patch for pb_reference to explicitly handle NULL src

2016-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94711 Bug ID: 94711 Summary: Patch for pb_reference to explicitly handle NULL src Product: Mesa Version: 11.1 Hardware: Other OS: All Status: NEW Severity:

[Mesa-dev] [Bug 94710] Patch for dangling disp->DriverData pointer in error path

2016-03-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94710 Bug ID: 94710 Summary: Patch for dangling disp->DriverData pointer in error path Product: Mesa Version: 11.1 Hardware: Other OS: All Status:

Re: [Mesa-dev] [PATCH 06/11] glapi: Fix whitespace droppings when printing the license header

2016-03-25 Thread Dylan Baker
Quoting Dylan Baker (2016-03-25 16:01:00) > Quoting Adam Jackson (2016-03-24 11:10:01) > > Signed-off-by: Adam Jackson > > --- > > src/mapi/glapi/gen/gl_XML.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/mapi/glapi/gen/gl_XML.py

Re: [Mesa-dev] [PATCH 2/2] anv/blit2d: Add a function to create an ImageView

2016-03-25 Thread Jason Ekstrand
Both are Reviewed-by: Jason Ekstrand On Fri, Mar 25, 2016 at 4:38 PM, Nanley Chery wrote: > From: Nanley Chery > > This function differs from the open-coded implementation in that the > ImageView's width is determined by

[Mesa-dev] [PATCH 1/2] anv/image: Enable specifying a surface's minimum pitch

2016-03-25 Thread Nanley Chery
From: Nanley Chery This is required to create multiple, horizontally adjacent, max-width images from one blit2d surface. This is also required for more accurate width specification of surfaces within a larger surface (which is seen as the smaller surface's enclosing

[Mesa-dev] [PATCH 2/2] anv/blit2d: Add a function to create an ImageView

2016-03-25 Thread Nanley Chery
From: Nanley Chery This function differs from the open-coded implementation in that the ImageView's width is determined by the caller and is not unconditionally set to match the number of texels within the surface's pitch. Signed-off-by: Nanley Chery

[Mesa-dev] [PATCH 24/26] nir/lower_out_to_temp: Add an "entrypoint" parameter

2016-03-25 Thread Jason Ekstrand
Previously, the pass assumed that the entrypoint would be whatever function happened to have the name "main". We really shouldn't trust in the function names. --- src/compiler/nir/glsl_to_nir.cpp| 2 +- src/compiler/nir/nir.h | 4 +++-

[Mesa-dev] [PATCH 16/26] i965: Implement the new imod and irem opcodes

2016-03-25 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 32 ++ src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 32 ++ 2 files changed, 64 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp

[Mesa-dev] [PATCH 09/26] nir/builder: Add a helper for storing to variable derefs

2016-03-25 Thread Jason Ekstrand
--- src/compiler/nir/nir_builder.h | 16 1 file changed, 16 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index 4df79f5..e9c409b 100644 --- a/src/compiler/nir/nir_builder.h +++ b/src/compiler/nir/nir_builder.h @@ -399,6 +399,22 @@

[Mesa-dev] [PATCH 21/26] i965/nir: Provide a default LOD for buffer textures

2016-03-25 Thread Jason Ekstrand
Our hardware requires an LOD for all texelFetch commands even if they are on buffer textures. GLSL IR gives us an LOD of 0 in that case, but the LOD is really rather meaningless. This commit allows other NIR producers to be more lazy and not provide one at all. ---

[Mesa-dev] [PATCH 26/26] nir/dead_variables: Configurably work with any variable mode

2016-03-25 Thread Jason Ekstrand
The old version of the pass only worked on globals and locals and always left inputs, outputs, uniforms, etc. alone. --- src/compiler/nir/nir.h | 2 +- src/compiler/nir/nir_remove_dead_variables.c | 33

[Mesa-dev] [PATCH 19/26] nir: Add an opcode for stomping a 32-bit value to 16-bit precision

2016-03-25 Thread Jason Ekstrand
This correlates directly to the SPIR-V opcode OpQuantizeToF16 --- src/compiler/nir/nir_opcodes.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_opcodes.py b/src/compiler/nir/nir_opcodes.py index 7c8a322..d6b658d 100644 --- a/src/compiler/nir/nir_opcodes.py +++

[Mesa-dev] [PATCH 25/26] nir: Add a helper for getting the current block from a cursor

2016-03-25 Thread Jason Ekstrand
--- src/compiler/nir/nir.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 45f208a..03c1f76 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -1936,6 +1936,17 @@ typedef struct { }; } nir_cursor;

[Mesa-dev] [PATCH 13/26] nir/lower_system_values: Add support for several computed values

2016-03-25 Thread Jason Ekstrand
--- src/compiler/nir/nir.h | 3 ++ src/compiler/nir/nir_lower_system_values.c | 74 -- 2 files changed, 74 insertions(+), 3 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 907dc34..d46858e 100644 ---

[Mesa-dev] [PATCH 15/26] nir: Add more modulus opcodes

2016-03-25 Thread Jason Ekstrand
These are all needed for SPIR-V --- src/compiler/nir/nir_opcodes.py | 16 +++- src/compiler/nir/nir_opt_algebraic.py | 1 + 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opcodes.py b/src/compiler/nir/nir_opcodes.py index 553f924..7c8a322

[Mesa-dev] [PATCH 03/26] nir/intrinsics: Add a vulkan_resource_index intrinsic

2016-03-25 Thread Jason Ekstrand
This is used to facilitate the Vulkan binding model where each resource is described by a (descriptor set, binding, array index) tuple. --- src/compiler/nir/nir.h| 12 src/compiler/nir/nir_intrinsics.h | 20 src/compiler/nir/nir_print.c | 2 ++

[Mesa-dev] [PATCH 01/26] nir/Makefile: Fix alphabetization

2016-03-25 Thread Jason Ekstrand
--- src/compiler/Makefile.sources | 6 +++--- src/compiler/nir/Makefile.sources | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/compiler/Makefile.sources b/src/compiler/Makefile.sources index 1f85172..0aee200 100644 --- a/src/compiler/Makefile.sources +++

[Mesa-dev] [PATCH 18/26] nir/algebraic: Add lowering for ldexp

2016-03-25 Thread Jason Ekstrand
The algorithm used is different from both the naieve suggestion from the GLSL spec and the one used in GLSL IR today. Unfortunately, the GLSL IR implementation doesn't handle some of the corner cases correctly and neither does a naieve f * 2.0^exp implementation. Assuming that hardware does the

[Mesa-dev] [PATCH 12/26] glsl/shader_enums: Add the other two compute builtins

2016-03-25 Thread Jason Ekstrand
These weren't added before because they are actually calculated values that are computed from other inputs. However, in order to handle them in nir_lower_system_values, it's nice for them to have a cannonical locaiton. --- src/compiler/shader_enums.c | 2 ++ src/compiler/shader_enums.h | 2 ++ 2

[Mesa-dev] [PATCH 10/26] nir/builder: Add a helper for creating undefs

2016-03-25 Thread Jason Ekstrand
--- src/compiler/nir/nir_builder.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index e9c409b..3dc7c25 100644 --- a/src/compiler/nir/nir_builder.h +++ b/src/compiler/nir/nir_builder.h @@ -75,6 +75,20 @@

[Mesa-dev] [PATCH 17/26] i965/fs: Move the code for load/store_shared to emit_cs_intrinsic

2016-03-25 Thread Jason Ekstrand
They are compute-shader only and that's where the code for doing atomics on shared variables lives so it seemes to make sense. --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 152 +++ 1 file changed, 76 insertions(+), 76 deletions(-) diff --git

[Mesa-dev] [PATCH 20/26] i965: Add an implemnetation of nir_op_fquantize2f16

2016-03-25 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 28 src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 25 + 2 files changed, 53 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index

[Mesa-dev] [PATCH 11/26] glsl/shader_enums: Add an enum for Vulkan InstanceIndex

2016-03-25 Thread Jason Ekstrand
In Vulkan, you have InstanceIndex which begins at the base instance value rather than the zero-based InstanceID of GL. --- src/compiler/shader_enums.c | 1 + src/compiler/shader_enums.h | 7 +++ 2 files changed, 8 insertions(+) diff --git a/src/compiler/shader_enums.c

[Mesa-dev] [PATCH 05/26] nir/types: Add a wrapper for count_attribute_slots

2016-03-25 Thread Jason Ekstrand
--- src/compiler/nir_types.cpp | 7 +++ src/compiler/nir_types.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index 3669cfe..70e9cd3 100644 --- a/src/compiler/nir_types.cpp +++ b/src/compiler/nir_types.cpp @@ -124,6 +124,13

[Mesa-dev] [PATCH 08/26] nir/builder: Add a helper for building fdot instructions

2016-03-25 Thread Jason Ekstrand
--- src/compiler/nir/nir_builder.h | 17 + 1 file changed, 17 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h index b245f48..4df79f5 100644 --- a/src/compiler/nir/nir_builder.h +++ b/src/compiler/nir/nir_builder.h @@ -305,6 +305,23 @@

[Mesa-dev] [PATCH 14/26] nir/sweep: Sweep function parameters

2016-03-25 Thread Jason Ekstrand
They are no longer in the list of local variables so we need to explicitly sweep them. --- src/compiler/nir/nir_sweep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/compiler/nir/nir_sweep.c b/src/compiler/nir/nir_sweep.c index 5c62154..b22f0f5 100644 ---

[Mesa-dev] [PATCH 02/26] nir: Add a descriptor_set field to nir_variable

2016-03-25 Thread Jason Ekstrand
This is needed for supporting the Vulkan binding model --- src/compiler/nir/glsl_to_nir.cpp | 1 + src/compiler/nir/nir.h | 5 + 2 files changed, 6 insertions(+) diff --git a/src/compiler/nir/glsl_to_nir.cpp b/src/compiler/nir/glsl_to_nir.cpp index f6e1a17..efef9f5 100644 ---

[Mesa-dev] [PATCH 22/26] nir: Add a helper for getting the unique function in a shader

2016-03-25 Thread Jason Ekstrand
--- src/compiler/nir/nir.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index d46858e..d39c5fd 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -1816,6 +1816,17 @@ typedef struct nir_shader {

[Mesa-dev] [PATCH 07/26] nir: Add a pass for gathering various bits of shader info

2016-03-25 Thread Jason Ekstrand
--- src/compiler/Makefile.sources | 1 + src/compiler/nir/Makefile.sources | 1 + src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_gather_info.c | 126 + 4 files changed, 129 insertions(+) create mode 100644

[Mesa-dev] [PATCH 23/26] nir/lower_out_to_temp: Steal the output's constant initializer

2016-03-25 Thread Jason Ekstrand
--- src/compiler/nir/nir_lower_outputs_to_temporaries.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir_lower_outputs_to_temporaries.c b/src/compiler/nir/nir_lower_outputs_to_temporaries.c index 71b06b8..80c9af4 100644 ---

[Mesa-dev] [PATCH 06/26] nir: Add a helper for getting an attribute slot mask for a variable

2016-03-25 Thread Jason Ekstrand
--- src/compiler/nir/nir.h | 28 1 file changed, 28 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 68df76c..57b1a87 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -348,6 +348,34 @@ nir_variable_is_global(const

[Mesa-dev] [PATCH 04/26] nir: Add a variable_foreach_safe helper

2016-03-25 Thread Jason Ekstrand
--- src/compiler/nir/nir.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 33bb1fd..68df76c 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -339,6 +339,9 @@ typedef struct nir_variable { #define

[Mesa-dev] [PATCH 00/26] nir: Miscelaneous things needed for SPIR-V and Vulkan

2016-03-25 Thread Jason Ekstrand
This patch series adds a bunch of random things that are used by the SPIR-V front-end and by our Vulkan driver. It's in no particular order (other than ensuring that it builds) and most of the newly added things don't have a consumer outside our Vulkan driver. With this series and the one for

Re: [Mesa-dev] [PATCH 08/11] glapi: Harden GLX request size processing

2016-03-25 Thread Dylan Baker
Quoting Adam Jackson (2016-03-24 11:10:03) [snip] > @@ -620,9 +617,10 @@ class PrintGlxReqSize_c(PrintGlxReqSize_common): > if s == 0: s = 1 > > sig += "(%u,%u)" % (f.offset_of(p.counter), s) > -size += '%s%s' % (plus, p.size_string()) > -

Re: [Mesa-dev] [PATCH 06/11] glapi: Fix whitespace droppings when printing the license header

2016-03-25 Thread Dylan Baker
Quoting Adam Jackson (2016-03-24 11:10:01) > Signed-off-by: Adam Jackson > --- > src/mapi/glapi/gen/gl_XML.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py > index 2e7123e..e11f6fc 100644 >

Re: [Mesa-dev] [PATCH 01/11] glx: Unbreak generating some of the xorg glx headers

2016-03-25 Thread Dylan Baker
Quoting Adam Jackson (2016-03-24 11:09:56) > Broken by: > > commit 9ace0b542241c77ae82a0835ac8a09e2a7510eaf > Author: Dylan Baker > Date: Wed May 20 15:49:11 2015 -0700 > > glapi: glX_proto_size.py: use argparse instead of getopt > > Which changed

Re: [Mesa-dev] [PATCH 01/11] glx: Unbreak generating some of the xorg glx headers

2016-03-25 Thread Dylan Baker
Quoting Adam Jackson (2016-03-24 10:58:40) > Broken by: > > commit 9ace0b542241c77ae82a0835ac8a09e2a7510eaf > Author: Dylan Baker > Date: Wed May 20 15:49:11 2015 -0700 > > glapi: glX_proto_size.py: use argparse instead of getopt > > Which changed

Re: [Mesa-dev] [PATCH 4/5] radeon/vce: add Polaris11 VCE firmware support

2016-03-25 Thread Alex Deucher
On Fri, Mar 25, 2016 at 6:12 PM, Dieter Nützel wrote: > Hello all AMD guys, > > does that mean, that Polaris 10 didn't have VCE support? > Or is it the same for both? It's the same FW version for both. Alex > > With VCE support and the like Polaris 10 looks like the right

Re: [Mesa-dev] [PATCH 4/5] radeon/vce: add Polaris11 VCE firmware support

2016-03-25 Thread Dieter Nützel
Hello all AMD guys, does that mean, that Polaris 10 didn't have VCE support? Or is it the same for both? With VCE support and the like Polaris 10 looks like the right thing for me. Thanks a lot for 'day one' support...;-) -Dieter Am 23.03.2016 19:43, schrieb Alex Deucher: From: Sonny

[Mesa-dev] [PATCH] glsl: Don't require matching centroid qualifiers

2016-03-25 Thread Jordan Justen
Note: This patch appears to violate older OpenGL and OpenGLES specs. The OpenGLES GLSL 3.1 and OpenGL GLSL 4.3 specifications both remove the requirement for the output and input centroid qualifiers to match. The deqp dEQP-GLES3.functional.shaders.linkage.varying.rules.differing_interpolation_2

Re: [Mesa-dev] [PATCH] gallium: Formatted code in pb_buffer_fenced.c according to style guide.

2016-03-25 Thread Brian Paul
On 03/24/2016 07:03 PM, Thomas Helland wrote: Welcome to the community! Some small comments. We usually write patch messages in present tense. So, "Format code in ". Some more comments below. On Mar 25, 2016 01:24, "Rovanion Luckey"

[Mesa-dev] [PATCH] svga: avoid freeing non-malloced memory

2016-03-25 Thread Brian Paul
svga_shader_expand() will fall back to using non-malloced memory for emit.buf if malloc fails. We should check if the memory is malloced before freeing it in the error path of svga_tgsi_vgpu9_translate. Original patch by Thomas Hindoe Paaboel Andersen . Remove trivial

Re: [Mesa-dev] [PATCH] svga: avoid freeing non-malloced memory

2016-03-25 Thread Brian Paul
On 03/24/2016 04:36 PM, Thomas Hindoe Paaboel Andersen wrote: svga_shader_expand will fall back to using non-malloced memory for emit.buf if malloc fails. We should check if the memory is malloced before freeing it in the error path of svga_tgsi_vgpu9_translate. --- All we need to do is check if

Re: [Mesa-dev] [PATCH] st/xa: emit sampler view declarations in shaders

2016-03-25 Thread Charmaine Lee
Tested and Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, March 25, 2016 1:08 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] st/xa: emit sampler view declarations in shaders

[Mesa-dev] [PATCH] st/xa: emit sampler view declarations in shaders

2016-03-25 Thread Brian Paul
Fixes recent regressions with the VMware gallium driver. --- src/gallium/state_trackers/xa/xa_tgsi.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/gallium/state_trackers/xa/xa_tgsi.c b/src/gallium/state_trackers/xa/xa_tgsi.c index 5d8b807..a50393d 100644 ---

Re: [Mesa-dev] [PATCH v2 00/15] i965: Rework uniform handling in the back-end

2016-03-25 Thread Jason Ekstrand
On Tue, Mar 22, 2016 at 3:33 PM, Jason Ekstrand wrote: > This is mostly a re-send of a patch series I've had floating around in one > form or a while for quite some time. It's basically the same except that > the original version was missing a work-around for Sandy Bridge.

Re: [Mesa-dev] [PATCH] i965: Whack UAV bit when FS discards and there are no color writes.

2016-03-25 Thread Jason Ekstrand
On Thu, Mar 24, 2016 at 7:45 PM, Francisco Jerez wrote: > Francisco Jerez writes: > > > Jason Ekstrand writes: > > > >> On Thu, Mar 24, 2016 at 5:50 PM, Kenneth Graunke > > >> wrote: > >> > >>>

Re: [Mesa-dev] [PATCH 17/17] GL3.txt: Mark ARB_framebuffer_no_attachments as done

2016-03-25 Thread Ilia Mirkin
On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan > --- > docs/GL3.txt | 2 +- > docs/relnotes/11.3.0.html | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH 03/17] mesa/st: Set _NumSamples in update_framebuffer_state()

2016-03-25 Thread Ilia Mirkin
On Fri, Mar 25, 2016 at 8:11 AM, wrote: > On 2016-03-25 22:20, Ilia Mirkin wrote: >> >> On Mar 25, 2016 4:43 AM, wrote: >>> >>> >>> On 2016-03-25 14:02, Ilia Mirkin wrote: On Thu, Mar 24, 2016 at 8:11 PM, Edward

Re: [Mesa-dev] [PATCH 03/17] mesa/st: Set _NumSamples in update_framebuffer_state()

2016-03-25 Thread eocallaghan
On 2016-03-25 22:20, Ilia Mirkin wrote: On Mar 25, 2016 4:43 AM, wrote: On 2016-03-25 14:02, Ilia Mirkin wrote: On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan wrote: Using PIPE_FORMAT_NONE to indicate what MSAA modes are

Re: [Mesa-dev] [PATCH 03/17] mesa/st: Set _NumSamples in update_framebuffer_state()

2016-03-25 Thread Ilia Mirkin
On Mar 25, 2016 4:43 AM, wrote: > > On 2016-03-25 14:02, Ilia Mirkin wrote: >> >> On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan >> wrote: >>> >>> Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported >>> with a

[Mesa-dev] [PATCH v2] gallium: Format code in pb_buffer_fenced.c according to style guide.

2016-03-25 Thread Rovanion Luckey
This is a tiny housekeeping patch which does the following: * Replaced tabs with three spaces. * Formatted oneline and multiline code comments. Some doxygen comments weren't marked as such and some code comments were marked as doxygen comments. * Spaces between if- and

Re: [Mesa-dev] [PATCH] nv50/ra: `isinf()` is in namespace `std` since C++11

2016-03-25 Thread Pierre Moreau
I'll resend a patch following Jose's suggestion, probably on Sunday. There are just too many things happening before that. Pierre > On 25 Mar 2016, at 00:36, Jose Fonseca wrote: > >> On 24/03/16 22:07, Ilia Mirkin wrote: >>> On Sat, Mar 19, 2016 at 6:30 PM, Jose Fonseca

Re: [Mesa-dev] [PATCH 15/17] nvc0: handle the case where there are no framebuffer attachments

2016-03-25 Thread eocallaghan
On 2016-03-25 14:29, Ilia Mirkin wrote: Please leave this and the next patch out of your series. I'm going to need to retest everything carefully once the core support is in (and I get a bit of time). Done. Be sure to remove my Rb if you made changes and i`ll review it again. Thanks,

Re: [Mesa-dev] [PATCH 10/17] gallium/util: Ensure util_framebuffer_get_num_samples() is valid

2016-03-25 Thread eocallaghan
On 2016-03-25 14:20, Ilia Mirkin wrote: Instead of introducing buggy code in patch 6/17 and then fixing it up here, you need to fold this with patch 6 so that it's all done at the same time. Yea, can do. Cheers, On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan

Re: [Mesa-dev] [PATCH 03/17] mesa/st: Set _NumSamples in update_framebuffer_state()

2016-03-25 Thread eocallaghan
On 2016-03-25 14:02, Ilia Mirkin wrote: On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan wrote: Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported with a framebuffer using no attachment. Signed-off-by: Edward O'Callaghan