Re: [Mesa-dev] [PATCH] nv50: Dont illegally change format after surface_create() call

2016-03-26 Thread Ilia Mirkin
It's driver-internal and perfectly legal. It will also not work this way for depth/stencil textures... NAK On Mar 26, 2016 10:59 PM, "Edward O'Callaghan" wrote: > This was the wrong way to force a resource format, fix it in nv50. > > NOTE: Needs testing from

Re: [Mesa-dev] [PATCH] mesa: remove initialized field from uniform storage

2016-03-26 Thread eocallaghan
Reviewed-by: Edward O'Callaghan On 2016-03-27 14:51, Timothy Arceri wrote: The only place this was used was in a gallium debug function that had to be manually enabled. --- src/compiler/glsl/ir_uniform.h | 5

[Mesa-dev] [PATCH] mesa: remove initialized field from uniform storage

2016-03-26 Thread Timothy Arceri
The only place this was used was in a gallium debug function that had to be manually enabled. --- src/compiler/glsl/ir_uniform.h | 5 src/compiler/glsl/link_uniform_initializers.cpp | 4 --- src/compiler/glsl/link_uniforms.cpp | 1 - src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH] nv50: Dont illegally change format after surface_create() call

2016-03-26 Thread Edward O'Callaghan
This was the wrong way to force a resource format, fix it in nv50. NOTE: Needs testing from someone with nv hw. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/nouveau/nv50/nv50_surface.c | 67 - 1 file changed, 33 insertions(+),

[Mesa-dev] [PATCH 12/14] radeonsi: Enable ARB_framebuffer_no_attachments

2016-03-26 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index abb39e4..da918d9 100644 ---

[Mesa-dev] [PATCH 05/14] mesa/st: Use _mesa_geometric_ functions appropriately

2016-03-26 Thread Edward O'Callaghan
Change references to gl_framebuffer::Width, Height, MaxNumLayers and Visual::samples to use the _mesa_geometric_ convenience functions for those places where the geometry of the gl_framebuffer is needed. This is in contrast to the geometry of the intersection of the attachments of the

[Mesa-dev] [PATCH 13/14] r600g: Enable ARB_framebuffer_no_attachments

2016-03-26 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/r600/r600_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 4b91874..7b4f9cb 100644 ---

[Mesa-dev] [PATCH 08/14] mesa/st: Update framebuffer state with no.of samples, layers

2016-03-26 Thread Edward O'Callaghan
Handle the case of ARB_framebuffer_no_attachment. Also, kill off a dead debug printf() call while we are here. Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_atom_framebuffer.c | 8 +--- 1 file

[Mesa-dev] [PATCH 06/14] gallium: Put no.of {samples, layers} into pipe_framebuffer_state

2016-03-26 Thread Edward O'Callaghan
Here we store the number of samples and layers directly in the pipe_framebuffer_state so that in the case of ARB_framebuffer_no_attachment we may make use of them directly. Further, we adjust various gallium/auxiliary helper functions accordingly. V2: Convert branches in

[Mesa-dev] [PATCH 14/14] GL3.txt: Mark ARB_framebuffer_no_attachments as done

2016-03-26 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- docs/GL3.txt | 2 +- docs/relnotes/11.3.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 88c14c4..2468251 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@

[Mesa-dev] [PATCH 02/14] gallium: Obtain ARB_framebuffer_no_attachment constants

2016-03-26 Thread Edward O'Callaghan
Set default values for the constants required in ARB_framebuffer_no_attachments and obtained the number of layers from ``PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS``. We also obtain the MaxFramebufferSamples value using a query back to the driver for PIPE_FORMAT_NONE. Signed-off-by: Edward O'Callaghan

[Mesa-dev] [PATCH 04/14] mesa: Add comment to framebuffer_parameteri()

2016-03-26 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- src/mesa/main/fbobject.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index bb8d4c3..42f40b2 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@

[Mesa-dev] [PATCH 09/14] softpipe: Set samples and layers in set_framebuffer_state() cb

2016-03-26 Thread Edward O'Callaghan
Carries across the number of samples and layers state in the 'softpipe_set_framebuffer_state()' callback. This state is part of 'ARB_framebuffer_no_attachments' support. Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák ---

[Mesa-dev] [PATCH 11/14] radeonsi: Improve assert info out of si_set_framebuffer_state()

2016-03-26 Thread Edward O'Callaghan
Lets give the developer a little hand if we are going to assert on a zero literal at the end of a branch. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/radeonsi/si_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Mesa-dev] [PATCH 01/14] gallium: Add PIPE_CAP_FRAMEBUFFER_NO_ATTACHMENT

2016-03-26 Thread Edward O'Callaghan
Add PIPE_CAP to determine if the GL extension 'GL_ARB_framebuffer_no_attachments' shall be supported. The driver is required to support 'PIPE_FORMAT_NONE' via its 'is_format_supported()' callback in order to determine the MSAA modes the hardware supports so that values requested from the

[Mesa-dev] [PATCH 03/14] mesa/st: Set _NumSamples in update_framebuffer_state()

2016-03-26 Thread Edward O'Callaghan
Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported with a framebuffer using no attachment. V.2: Rewrite MSAA mode loop to be more general. Signed-off-by: Edward O'Callaghan --- src/mesa/state_tracker/st_atom_framebuffer.c | 52

[Mesa-dev] [PATCH 10/14] radeonsi: Allow 16 samples MSAA mode for PIPE_FORMAT_NONE

2016-03-26 Thread Edward O'Callaghan
For ARB_framebuffer_no_attachment; A is_format_supported() query with 'PIPE_FORMAT_NONE' passed implies a query of the number of samples supported from the framebuffer with no attachment. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 07/14] gallium/trace: Dump no.of samples and layers in fb state

2016-03-26 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan Reviewed-by: Marek Olšák --- src/gallium/drivers/trace/tr_dump_state.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/trace/tr_dump_state.c

[Mesa-dev] V.+9000 ARB_framebuffer_no_attachment

2016-03-26 Thread Edward O'Callaghan
Here we go again.. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] nvc0: disable primitive restart and index bias during blits

2016-03-26 Thread Ilia Mirkin
Back in the dawn of time, we used to do immediate uploads for the vertex data, and all was well. However Maxwell dropped support for immediate vertex data, so we started feeding in a VBO (in all cases). But we forgot to disable some things that apply in such cases, specifically primitive restart

[Mesa-dev] [PATCH] gallium/p_context.h: Make comment more readable

2016-03-26 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan --- src/gallium/include/pipe/p_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_context.h b/src/gallium/include/pipe/p_context.h index ee68fdd..1c97e82 100644 ---

Re: [Mesa-dev] [PATCH] glsl/ast: Implicit conversion from double to float is not allowed

2016-03-26 Thread Dave Airlie
On 21 February 2016 at 04:08, Kenneth Graunke wrote: > On Saturday, February 20, 2016 1:30:46 PM PST Andres Gomez wrote: >> Also, renamed get_conversion_operation to avoid >> future misunderstandings. >> --- I posted the same patch long ago, Tapani said this, not sure if

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-26 Thread Rob Clark
On Sat, Mar 26, 2016 at 7:09 PM, Stéphane Marchesin wrote: > > On Mar 26, 2016 16:05, "Rob Clark" wrote: >> >> On Sat, Mar 26, 2016 at 6:42 PM, Stéphane Marchesin >> wrote: >> > >> > On Mar 26, 2016 3:09 PM, "Rob

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-26 Thread Stéphane Marchesin
On Mar 26, 2016 16:05, "Rob Clark" wrote: > > On Sat, Mar 26, 2016 at 6:42 PM, Stéphane Marchesin > wrote: > > > > On Mar 26, 2016 3:09 PM, "Rob Clark" wrote: > >> > >> On Fri, Mar 25, 2016 at 9:38 PM, Stéphane Marchesin

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-26 Thread Rob Clark
On Sat, Mar 26, 2016 at 6:42 PM, Stéphane Marchesin wrote: > > On Mar 26, 2016 3:09 PM, "Rob Clark" wrote: >> >> On Fri, Mar 25, 2016 at 9:38 PM, Stéphane Marchesin >> wrote: >> > On Wed, Mar 23, 2016 at 5:22 PM, Rob Herring

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-26 Thread Stéphane Marchesin
On Mar 26, 2016 3:09 PM, "Rob Clark" wrote: > > On Fri, Mar 25, 2016 at 9:38 PM, Stéphane Marchesin wrote: > > On Wed, Mar 23, 2016 at 5:22 PM, Rob Herring wrote: > >> On Fri, Mar 4, 2016 at 12:07 PM, Rob Clark

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 9:38 PM, Stéphane Marchesin wrote: > On Wed, Mar 23, 2016 at 5:22 PM, Rob Herring wrote: >> On Fri, Mar 4, 2016 at 12:07 PM, Rob Clark wrote: >>> On Fri, Mar 4, 2016 at 12:59 PM, Rob Clark

Re: [Mesa-dev] [PATCH 26/26] nir/dead_variables: Configurably work with any variable mode

2016-03-26 Thread Rob Clark
On Sat, Mar 26, 2016 at 5:43 PM, Jason Ekstrand wrote: > > > On Sat, Mar 26, 2016 at 8:22 AM, Rob Clark wrote: >> >> On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand >> wrote: >> > The old version of the pass only worked on globals

Re: [Mesa-dev] [PATCH 22/26] nir: Add a helper for getting the unique function in a shader

2016-03-26 Thread Jason Ekstrand
On Sat, Mar 26, 2016 at 8:12 AM, Rob Clark wrote: > On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand > wrote: > > > > btw, will there be some point where we actually don't want to inline > everything for vulkan and/or gl? Adreno does have call/return >

Re: [Mesa-dev] [PATCH 26/26] nir/dead_variables: Configurably work with any variable mode

2016-03-26 Thread Jason Ekstrand
On Sat, Mar 26, 2016 at 8:22 AM, Rob Clark wrote: > On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand > wrote: > > The old version of the pass only worked on globals and locals and always > > left inputs, outputs, uniforms, etc. alone. > > --- > >

[Mesa-dev] [PATCH 16/16] mesa/st: add support for NIR as possible driver IR

2016-03-26 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/compiler/nir/nir.h | 2 + .../drivers/freedreno/ir3/ir3_compiler_nir.c | 8 + src/mesa/Makefile.sources | 1 +

[Mesa-dev] [PATCH 15/16] mesa/st: add nir pass for lowering builtin uniforms

2016-03-26 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_nir.h | 28 +++ src/mesa/state_tracker/st_nir_lower_builtin.c | 242 ++ 3

Re: [Mesa-dev] [PATCH 1/1] vc4: Remove unused include from vc4_nir_lower_txf_ms.c

2016-03-26 Thread Rob Clark
+Eric (since I know at least when I am busier on kernel side stuff I don't watch mesa-dev as closely) On Sat, Mar 26, 2016 at 5:09 PM, Rhys Kidd wrote: > On Saturday, March 19, 2016, Rhys Kidd wrote: >> >> Found with grep and inspection. Test compiled on

[Mesa-dev] [PATCH 14/16] mesa/st: split the type_size calculation into it's own file

2016-03-26 Thread Rob Clark
From: Rob Clark We'll want to re-use this for NIR. Signed-off-by: Rob Clark --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 64 +-- src/mesa/state_tracker/st_glsl_types.cpp

[Mesa-dev] [PATCH 13/16] glsl: export accessor for builtin-uniform descriptors

2016-03-26 Thread Rob Clark
From: Rob Clark We'll need this for a nir pass to lower builtin-uniform access. Signed-off-by: Rob Clark --- src/compiler/glsl/builtin_variables.cpp | 24 +++- src/compiler/glsl/ir.h | 3 +++ 2 files

[Mesa-dev] [PATCH 12/16] nir/lower-io: add support for lowering inputs

2016-03-26 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- src/compiler/nir/nir.h | 2 +- src/compiler/nir/nir_lower_io_to_temporaries.c | 55 +- src/mesa/drivers/dri/i965/brw_nir.c| 2 +- 3

[Mesa-dev] [PATCH 11/16] nir/lower-io: split out some helper fxns

2016-03-26 Thread Rob Clark
From: Rob Clark Prep work to reduce the noise in the next patch. Signed-off-by: Rob Clark --- src/compiler/nir/nir_lower_io_to_temporaries.c | 95 +++--- 1 file changed, 57 insertions(+), 38 deletions(-) diff --git

[Mesa-dev] [PATCH 10/16] nir: rename lower_outputs_to_temporaries -> lower_io_to_temporaries

2016-03-26 Thread Rob Clark
From: Rob Clark Since it will gain support to lower inputs, give it a more generic name. Signed-off-by: Rob Clark --- src/compiler/Makefile.sources | 2 +- src/compiler/nir/nir.h | 2 +-

[Mesa-dev] [PATCH 09/16] nir: move callsite of lower_outputs_to_temporaries

2016-03-26 Thread Rob Clark
From: Rob Clark Going to convert this pass to parameterized lower_io_to_temporaries, and we want the user to be able to specify whether to lower outputs or inputs or both. The restriction of running this pass before validate to avoid output reads no longer applies.

[Mesa-dev] [PATCH 08/16] nir: lower-io-types pass

2016-03-26 Thread Rob Clark
From: Rob Clark A pass to lower complex (struct/array/mat) inputs/outputs to primitive types. This allows, for example, linking that removes unused components of a larger type which is not indirectly accessed. In the near term, it is needed for gallium (mesa/st)

[Mesa-dev] [PATCH 07/16] nir: passthrough-edgeflags support

2016-03-26 Thread Rob Clark
From: Rob Clark Handled by tgsi_emulate for glsl->tgsi case. Signed-off-by: Rob Clark Reviewed-by: Connor Abbott --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h

[Mesa-dev] [PATCH 06/16] nir: clamp-color-output support

2016-03-26 Thread Rob Clark
From: Rob Clark Handled by tgsi_emulate for glsl->tgsi case. Signed-off-by: Rob Clark Reviewed-by: Connor Abbott --- src/compiler/Makefile.sources| 1 + src/compiler/nir/nir.h

[Mesa-dev] [PATCH 05/16] nir: add lowering pass for glBitmap

2016-03-26 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Connor Abbott --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 7 ++ src/compiler/nir/nir_lower_bitmap.c | 166

[Mesa-dev] [PATCH 04/16] nir: add lowering pass for glDrawPixels

2016-03-26 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Connor Abbott --- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h | 13 ++ src/compiler/nir/nir_builder.h | 2 +-

[Mesa-dev] [PATCH 03/16] nir: add lowering pass for y-transform

2016-03-26 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Connor Abbott --- src/compiler/Makefile.sources| 1 + src/compiler/nir/nir.h | 12 ++

Re: [Mesa-dev] [PATCH 1/1] vc4: Remove unused include from vc4_nir_lower_txf_ms.c

2016-03-26 Thread Rhys Kidd
On Saturday, March 19, 2016, Rhys Kidd wrote: > Found with grep and inspection. Test compiled on RPi hw. > Assists any future effort to remove TGSI as an intermediate stage. > > Signed-off-by: Rhys Kidd > > --- >

[Mesa-dev] [PATCH 02/16] gallium: add NIR as a possible IR

2016-03-26 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Roland Scheidegger --- src/gallium/include/pipe/p_defines.h | 1 + src/gallium/include/pipe/p_screen.h | 9 + src/gallium/include/pipe/p_state.h | 6 ++

[Mesa-dev] [PATCH 01/16] gallium: refactor pipe_shader_state to support multiple IR's

2016-03-26 Thread Rob Clark
The goal is to allow the pipe driver to request something other than TGSI, but detect whether what is getting is TGSI vs what it requested. The pipe drivers will always have to support TGSI (and convert that into whatever it is that they prefer), but in some cases we should be able to skip the

[Mesa-dev] [PATCH 00/16] gallium: add support for NIR as alternate IR

2016-03-26 Thread Rob Clark
From: Rob Clark Ok, hopefully (close to the) last iteration of this patchset. Quite a lot of it has r-b's by now. There a few new nir bits (in particular, the "lower-io-types" pass and some updates to the "lower-outputs-to- temporaries" pass. Some of that will have

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965: Fix brw_render_cache_set_check_flush's PIPE_CONTROLs.

2016-03-26 Thread Francisco Jerez
Kenneth Graunke writes: > Our driver uses the brw_render_cache mechanism to track buffers we've > rendered to and are about to sample from. > > Previously, we did a single PIPE_CONTROL with the following bits set: > - Render Target Flush > - Depth Cache Flush > - Texture

[Mesa-dev] [PATCH] xlib: add support for GLX_ARB_create_context

2016-03-26 Thread Brian Paul
This adds the glXCreateContextAttribsARB() function for the xlib/swrast driver. This allows more piglit tests to run with this driver. For example, without this patch we get: $ bin/fbo-generatemipmap-1d -auto piglit: error: waffle_config_choose failed due to WAFFLE_ERROR_UNSUPPORTED_

[Mesa-dev] [PATCH 2/2] st/mesa: simplify st_generate_mipmap()

2016-03-26 Thread Brian Paul
The whole st_generate_mipmap() function was overly complicated. Now we just call the new _mesa_prepare_mipmap_levels() function to prepare the texture mipmap memory, then call the generate function which fills in the texture images. This fixes a failed assertion in llvmpipe/softpipe which is hit

[Mesa-dev] [PATCH 1/2] mesa: new _mesa_prepare_mipmap_levels() function for mipmap generation

2016-03-26 Thread Brian Paul
Simplifies the loops in generate_mipmap_uncompressed() and generate_mipmap_compressed(). Will be used in the state tracker too. Could probably be used in the meta code. If so, some additional clean-ups can be done after that. --- src/mesa/main/mipmap.c | 89

[Mesa-dev] [Bug 91100] [softpipe] piglit egl-create-pbuffer-surface regression

2016-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91100 --- Comment #2 from Martin Peres --- (In reply to Vinson Lee from comment #1) > mesa: 1e8435ce0cce671024ebf9c5465ea8bdcb563b69 (master 11.3.0-devel) > > This regression is still present. Sorry, I missed this email twice!

Re: [Mesa-dev] [PATCH 24/26] nir/lower_out_to_temp: Add an "entrypoint" parameter

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > Previously, the pass assumed that the entrypoint would be whatever function > happened to have the name "main". We really shouldn't trust in the > function names. heh, ok, this one will be more conflict than not w/

Re: [Mesa-dev] [PATCH 09/26] nir/builder: Add a helper for storing to variable derefs

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > Reviewed-by: Rob Clark > --- > src/compiler/nir/nir_builder.h | 16 > 1 file changed, 16 insertions(+) > > diff --git a/src/compiler/nir/nir_builder.h

Re: [Mesa-dev] [PATCH 01/26] nir/Makefile: Fix alphabetization

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > Reviewed-by: Rob Clark > --- > src/compiler/Makefile.sources | 6 +++--- > src/compiler/nir/Makefile.sources | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 15/26] nir: Add more modulus opcodes

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > These are all needed for SPIR-V Reviewed-by: Rob Clark > --- > src/compiler/nir/nir_opcodes.py | 16 +++- > src/compiler/nir/nir_opt_algebraic.py | 1 + > 2 files changed, 16

Re: [Mesa-dev] [PATCH 10/26] nir/builder: Add a helper for creating undefs

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > Reviewed-by: Rob Clark > --- > src/compiler/nir/nir_builder.h | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/src/compiler/nir/nir_builder.h

Re: [Mesa-dev] [PATCH 05/26] nir/types: Add a wrapper for count_attribute_slots

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > Reviewed-by: Rob Clark > --- > src/compiler/nir_types.cpp | 7 +++ > src/compiler/nir_types.h | 3 +++ > 2 files changed, 10 insertions(+) > > diff --git a/src/compiler/nir_types.cpp

Re: [Mesa-dev] [PATCH 07/26] nir: Add a pass for gathering various bits of shader info

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/Makefile.sources | 1 + > src/compiler/nir/nir.h | 1 + > src/compiler/nir/nir_gather_info.c | 126 >

Re: [Mesa-dev] [PATCH 14/26] nir/sweep: Sweep function parameters

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > They are no longer in the list of local variables so we need to explicitly > sweep them. Reviewed-by: Rob Clark > --- > src/compiler/nir/nir_sweep.c | 2 ++ > 1 file changed, 2 insertions(+) >

Re: [Mesa-dev] [PATCH 23/26] nir/lower_out_to_temp: Steal the output's constant initializer

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > Reviewed-by: Rob Clark > --- > src/compiler/nir/nir_lower_outputs_to_temporaries.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 02/26] nir: Add a descriptor_set field to nir_variable

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > This is needed for supporting the Vulkan binding model > --- > src/compiler/nir/glsl_to_nir.cpp | 1 + > src/compiler/nir/nir.h | 5 + > 2 files changed, 6 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 04/26] nir: Add a variable_foreach_safe helper

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > Reviewed-by: Rob Clark > --- > src/compiler/nir/nir.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index 33bb1fd..68df76c 100644

Re: [Mesa-dev] [PATCH 25/26] nir: Add a helper for getting the current block from a cursor

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > Reviewed-by: Rob Clark > --- > src/compiler/nir/nir.h | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index

Re: [Mesa-dev] [PATCH 19/26] nir: Add an opcode for stomping a 32-bit value to 16-bit precision

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > This correlates directly to the SPIR-V opcode OpQuantizeToF16 Reviewed-by: Rob Clark > --- > src/compiler/nir/nir_opcodes.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Mesa-dev] [PATCH 03/26] nir/intrinsics: Add a vulkan_resource_index intrinsic

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > This is used to facilitate the Vulkan binding model where each resource is > described by a (descriptor set, binding, array index) tuple. > --- > src/compiler/nir/nir.h| 12 >

Re: [Mesa-dev] [PATCH 13/26] nir/lower_system_values: Add support for several computed values

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > --- > src/compiler/nir/nir.h | 3 ++ > src/compiler/nir/nir_lower_system_values.c | 74 > -- > 2 files changed, 74 insertions(+), 3 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 26/26] nir/dead_variables: Configurably work with any variable mode

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > The old version of the pass only worked on globals and locals and always > left inputs, outputs, uniforms, etc. alone. > --- > src/compiler/nir/nir.h | 2 +- >

Re: [Mesa-dev] [PATCH 22/26] nir: Add a helper for getting the unique function in a shader

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > btw, will there be some point where we actually don't want to inline everything for vulkan and/or gl? Adreno does have call/return instructions (which I haven't really played with too much but I've seen blob use them

Re: [Mesa-dev] [PATCH 08/26] nir/builder: Add a helper for building fdot instructions

2016-03-26 Thread Rob Clark
On Fri, Mar 25, 2016 at 7:12 PM, Jason Ekstrand wrote: > Reviewed-by: Rob Clark > --- > src/compiler/nir/nir_builder.h | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/src/compiler/nir/nir_builder.h

Re: [Mesa-dev] [PATCH] i965: Fix brw_render_cache_set_check_flush's PIPE_CONTROLs.

2016-03-26 Thread Jason Ekstrand
On Mar 26, 2016 12:55 AM, "Kenneth Graunke" wrote: > > Our driver uses the brw_render_cache mechanism to track buffers we've > rendered to and are about to sample from. > > Previously, we did a single PIPE_CONTROL with the following bits set: > - Render Target Flush > -

[Mesa-dev] [PATCH] compiler/glsl: invalidate float suffixes for glsl 1.10

2016-03-26 Thread Lars Hamre
Invalidates float suffixes for glsl 1.10 Fixes the following piglit tests: tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-capital-f.vert tests/spec/glsl-1.10/compiler/literals/invalid-float-suffix-f.vert` Signed-off-by: Lars Hamre ---

[Mesa-dev] [Bug 90264] [Regression, bisected] Tooltip corruption in Chrome

2016-03-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90264 Marius Cirsta changed: What|Removed |Added CC||e...@anholt.net,

[Mesa-dev] [PATCH] i965: Fix brw_render_cache_set_check_flush's PIPE_CONTROLs.

2016-03-26 Thread Kenneth Graunke
Our driver uses the brw_render_cache mechanism to track buffers we've rendered to and are about to sample from. Previously, we did a single PIPE_CONTROL with the following bits set: - Render Target Flush - Depth Cache Flush - Texture Cache Invalidate - VF Cache Invalidate - Instruction Cache

[Mesa-dev] [PATCH 1/3] radeon/r600_query.c: Minor style fix

2016-03-26 Thread Edward O'Callaghan
Signed-off-by: Edward O'Callaghan Reviewed-by: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_query.c

[Mesa-dev] [PATCH 3/3] mesa/st: Remove GLSLVersion clamping

2016-03-26 Thread Edward O'Callaghan
While here, remove itermediate glsl_feature_level variable. Signed-off-by: Edward O'Callaghan --- src/mesa/state_tracker/st_extensions.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c

[Mesa-dev] V.2 Misc asortment of minor fixes

2016-03-26 Thread Edward O'Callaghan
This series; * Minor style fix * Return type warning * Removes GLSL version clamping for higher than 4.1. Remove 'glsl_feature_level' itermediate variable and use 'consts->GLSLVersion' directly following Nicolai's advice. ___ mesa-dev mailing list

[Mesa-dev] [PATCH 2/3] radeon/r600: Fix return type in failure branch

2016-03-26 Thread Edward O'Callaghan
Commit `d4e847ea` introduced a warning about making an integer from a pointer without a cast, fix it here. Signed-off-by: Edward O'Callaghan --- src/gallium/drivers/radeon/r600_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git