Re: [Mesa-dev] [PATCH] glsl/list: make nodes safe for double removal, etc.

On Mon, 2016-04-04 at 11:04 -0400, Rob Clark wrote: > On Mon, Apr 4, 2016 at 10:34 AM, Iago Toral wrote: > > On Sat, 2016-04-02 at 17:09 -0400, Rob Clark wrote: > >> From: Rob Clark > >> > >> It's no extra overhead to do a _self_link() and it eliminates a class of > >> potential problems. > > > >

Re: [Mesa-dev] About border values in fp64 conversion tests

Hi, I haven't had any other feedback than Ilia's (thanks Ilia!) so my doubts still stand. I'd welcome more info regarding this topic. Thanks! Br. On Tue, 2016-03-15 at 17:46 +0200, Andres Gomez wrote: > Hi, > > as complementary work to the one done to "Add FP64 support to the > i965 > shader

Re: [Mesa-dev] [PATCH] glsl/list: make nodes safe for double removal, etc.

On Saturday, April 2, 2016 5:09:27 PM PDT Rob Clark wrote: > From: Rob Clark > > It's no extra overhead to do a _self_link() and it eliminates a class of > potential problems. > > Signed-off-by: Rob Clark > Dared-by: Jason Ekstrand > --- > src/compiler/glsl/list.h | 15 +++ > 1 fi

[Mesa-dev] [PATCH] nir/glsl_to_nir: add bit-size info to add_instr()

Signed-off-by: Samuel Iglesias Gonsálvez --- This would replace this patch [0] in the series. [0] https://lists.freedesktop.org/archives/mesa-dev/2016-March/111347.html src/compiler/nir/glsl_to_nir.cpp | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 4/6] glsl: fully split apart buffer block arrays

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 In general, I don't see anything wrong with this series, just minor things in this patch. Once they are fixed and if piglit/dEQP don't complain, add my R-b to this series: Reviewed-by: Samuel Iglesias Gonsálvez On 03/04/16 13:16, Timothy Arceri w

Re: [Mesa-dev] [PATCH 4/6] glsl: fully split apart buffer block arrays

On Tue, 2016-04-05 at 12:05 +0200, Samuel Iglesias Gonsálvez wrote: > In general, I don't see anything wrong with this series, just minor > things in this patch. > > Once they are fixed and if piglit/dEQP don't complain, add my R-b to > this series: > > Reviewed-by: Samuel Iglesias Gonsálvez >

[Mesa-dev] [PATCH 0/2] Extra check for GenQueriesARB and DeleteQueriesARB

From: Kevin Rogovin This patch sequence enforces an extra check for GenQueriesARB and DeleteQueriesARB that is not preset in GenQueries and DeleteQueries. Kevin Rogovin (2): Differentiate between GenQueries and GenQueriesARB Differentiate between DeleteQueries and DeleteQueriesARB src/mapi

[Mesa-dev] [PATCH 1/2] Differentiate between GenQueries and GenQueriesARB

From: Kevin Rogovin The extension, GL_ARB_occlusion_queries mandates that an INVALID_OPERATION should be thrown if GenQueriesARB is called while a query is active. In contrast, the GL spec has no such requirement for GenQueries. This patch unaliases the two functions and has that the ARB variant

[Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

From: Kevin Rogovin The extension, GL_ARB_occlusion_queries mandates that an INVALID_OPERATION should be thrown if DeleteQueriesARB is called while a query is active. In contrast, the GL spec has no such requirement for DeleteQueries. This patch unaliases the two functions and has that the ARB va

Re: [Mesa-dev] [PATCH 20/20] radeonsi: enable TGSI support cap for compute shaders

On Sat, Apr 2, 2016 at 3:11 PM, Bas Nieuwenhuizen wrote: > Signed-off-by: Bas Nieuwenhuizen > --- > docs/GL3.txt | 4 ++-- > docs/relnotes/11.3.0.html | 1 + > src/gallium/drivers/radeon/r600_pipe_common.c | 21 - > src/g

Re: [Mesa-dev] [PATCH 12/20] radeonsi: rework compute scratch buffer

On Mon, Apr 4, 2016 at 6:51 PM, Marek Olšák wrote: > On Sat, Apr 2, 2016 at 3:10 PM, Bas Nieuwenhuizen > wrote: >> Instead of having a scratch buffer per program, have one per >> context. >> >> Also removed the per kernel wave count calculations, but >> that only helped if the total number of wav

Re: [Mesa-dev] [PATCH] glsl/list: make nodes safe for double removal, etc.

On Tue, Apr 5, 2016 at 3:11 AM, Iago Toral wrote: > On Mon, 2016-04-04 at 11:04 -0400, Rob Clark wrote: >> On Mon, Apr 4, 2016 at 10:34 AM, Iago Toral wrote: >> > On Sat, 2016-04-02 at 17:09 -0400, Rob Clark wrote: >> >> From: Rob Clark >> >> >> >> It's no extra overhead to do a _self_link() and

Re: [Mesa-dev] [PATCH] r600g: Change default behaviour for undefined COLOR0

Reviewed-by: Marek Olšák Marek On Sun, Apr 3, 2016 at 9:53 PM, Axel Davy wrote: > d3d 9 needs COLOR0 to be 1.0 on all channels when > undefined. 0.0 for the others is fine. > GL behaviour is undefined. > > Signed-off-by: Axel Davy > --- > src/gallium/drivers/r600/evergreen_state.c | 4 >

Re: [Mesa-dev] [PATCH 07/12] glsl: Add arb_cull_distance support

On 05.04.2016 01:32, Timothy Arceri wrote: On Mon, 2016-04-04 at 15:07 +0200, Tobias Klausmann wrote: On 04.04.2016 04:48, Timothy Arceri wrote: On Mon, 2016-04-04 at 12:15 +1000, Dave Airlie wrote: From: Tobias Klausmann Signed-off-by: Tobias Klausmann Const.MaxClipPlanes); + } else if

Re: [Mesa-dev] [PATCH 2/6] dri: extend fence extension to support native fd fences

On Mon, Apr 4, 2016 at 2:25 PM, Rob Clark wrote: > On Mon, Apr 4, 2016 at 7:49 AM, Marek Olšák wrote: >> On Fri, Apr 1, 2016 at 10:29 PM, Rob Clark wrote: >>> From: Rob Clark >>> >>> Required to implement EGL_ANDROID_native_fence_sync. >>> >>> Signed-off-by: Rob Clark >>> --- >>> include/GL/i

Re: [Mesa-dev] [PATCH 4/6] gallium: add way for drivers to create fences without flushing

On Mon, Apr 4, 2016 at 2:43 PM, Rob Clark wrote: > Hmm, what are the requirements of eglClientWaitSyncKHR() about having > current context bound? Not being thread-safe (ie. being associated w/ > current ctx) is pretty important to allow apps that create fences at > in-opportune times to not force

Re: [Mesa-dev] [PATCH] radeon: Change AA sample locations for EG+

Reviewed-by: Marek Olšák EG 8x MSAA seems different by mistake. Marek On Sun, Apr 3, 2016 at 10:39 PM, Axel Davy wrote: > This sets the AA location to the d3d11 > spec. > EG/NI 8X MSAA is left as is. Not sure > why it was set different to Cayman, so > let it as is. > > Signed-off-by: Axel Davy

Re: [Mesa-dev] [PATCH] doxygen: update glsl link

2016-04-05 4:04 GMT+02:00 Rhys Kidd : > On 4 April 2016 at 17:44, Emil Velikov wrote: > >> On 4 April 2016 at 21:38, Elie TOURNIER wrote: >> > --- >> > doxygen/glsl.doxy | 7 +++ >> > 1 file changed, 3 insertions(+), 4 deletions(-) >> > >> > diff --git a/doxygen/glsl.doxy b/doxygen/glsl.dox

Re: [Mesa-dev] [PATCH v3] egl: add EGL_KHR_reusable_sync to egl_dri

Thanks. I've pushed this patch along with an update to Mesa release notes. Marek On Tue, Apr 5, 2016 at 2:14 AM, Dongwon Kim wrote: > This patch enables an EGL extension, EGL_KHR_reusable_sync. > This new extension basically provides a way for multiple APIs or > threads to be excuted synchronous

Re: [Mesa-dev] [PATCH] doxygen: update glsl link

On Tuesday, April 5, 2016, tournier.elie wrote: > 2016-04-05 4:04 GMT+02:00 Rhys Kidd >: > >> On 4 April 2016 at 17:44, Emil Velikov > > wrote: >> >>> On 4 April 2016 at 21:38, Elie TOURNIER >> > wrote: >>> > --- >>> > doxygen/glsl.doxy | 7 +++ >>> > 1 file changed, 3 insertions(+), 4 dele

Re: [Mesa-dev] [PATCH 2/4] radeonsi: use bounded indexing for samplers

Bas, feel free to push patches 1 & 2. Marek On Mon, Apr 4, 2016 at 10:56 PM, Nicolai Hähnle wrote: > Patches 1 & 2 are > > Reviewed-by: Nicolai Hähnle > > On 04.04.2016 06:41, Bas Nieuwenhuizen wrote: >> >> Signed-off-by: Bas Nieuwenhuizen >> --- >> src/gallium/drivers/radeonsi/si_shader.c |

Re: [Mesa-dev] [PATCH v3] egl: add EGL_KHR_reusable_sync to egl_dri

Hi Dongwon, On 5 April 2016 at 01:14, Dongwon Kim wrote: > This patch enables an EGL extension, EGL_KHR_reusable_sync. > This new extension basically provides a way for multiple APIs or > threads to be excuted synchronously via a "reusable sync" > primitive shared by those threads/API calls. > >

Re: [Mesa-dev] [PATCH 2/6] dri: extend fence extension to support native fd fences

On Tue, Apr 5, 2016 at 4:08 PM, Rob Clark wrote: > On Tue, Apr 5, 2016 at 8:55 AM, Marek Olšák wrote: >> On Mon, Apr 4, 2016 at 2:25 PM, Rob Clark wrote: >>> On Mon, Apr 4, 2016 at 7:49 AM, Marek Olšák wrote: On Fri, Apr 1, 2016 at 10:29 PM, Rob Clark wrote: > From: Rob Clark > >

Re: [Mesa-dev] About border values in fp64 conversion tests

Pretty sure this should be all undefined. double->int isn't really any different than float->int there where you can have values which are too large too. Note that for float->int (and it should be the same for doubles) d3d10 requires that you clamp to destination type range, and NaN gets converted

Re: [Mesa-dev] [PATCH 2/6] dri: extend fence extension to support native fd fences

On Tue, Apr 5, 2016 at 10:29 AM, Marek Olšák wrote: > On Tue, Apr 5, 2016 at 4:08 PM, Rob Clark wrote: >> On Tue, Apr 5, 2016 at 8:55 AM, Marek Olšák wrote: >>> On Mon, Apr 4, 2016 at 2:25 PM, Rob Clark wrote: On Mon, Apr 4, 2016 at 7:49 AM, Marek Olšák wrote: > On Fri, Apr 1, 2016 at

Re: [Mesa-dev] [PATCH 2/6] dri: extend fence extension to support native fd fences

On Tue, Apr 5, 2016 at 8:55 AM, Marek Olšák wrote: > On Mon, Apr 4, 2016 at 2:25 PM, Rob Clark wrote: >> On Mon, Apr 4, 2016 at 7:49 AM, Marek Olšák wrote: >>> On Fri, Apr 1, 2016 at 10:29 PM, Rob Clark wrote: From: Rob Clark Required to implement EGL_ANDROID_native_fence_sync.

Re: [Mesa-dev] [PATCH 4/6] gallium: add way for drivers to create fences without flushing

On Tue, Apr 5, 2016 at 9:04 AM, Marek Olšák wrote: > On Mon, Apr 4, 2016 at 2:43 PM, Rob Clark wrote: >> Hmm, what are the requirements of eglClientWaitSyncKHR() about having >> current context bound? Not being thread-safe (ie. being associated w/ >> current ctx) is pretty important to allow app

Re: [Mesa-dev] [PATCH 2/4] i965/fs: Make the repclear shader support either a uniform or a flat input

On Mon, Apr 4, 2016 at 11:04 PM, Jordan Justen wrote: > On 2016-04-04 15:51:13, Jason Ekstrand wrote: > > In the Vulkan driver we use a single flat input instead of a uniform > > because setting up push constants is more disruptive to the pipeline than > > setting up another vertex input. This u

Re: [Mesa-dev] [PATCH 2/4] i965/fs: Make the repclear shader support either a uniform or a flat input

On Tue, Apr 5, 2016 at 6:39 AM, Michael Schellenberger Costa < mschellenbergerco...@googlemail.com> wrote: > Hi Jason, > Hi Michael, FYI, please remember CC the mailing list when you send review feedback. :-) > tiny nitpick (therefore not on list) > > Am 05.04.2016 um 00:51 schrieb Jason Ekstr

[Mesa-dev] [PATCH 9/9] mesa: automake: update and reuse X86_SSE41_FILES list

From: Emil Velikov Signed-off-by: Emil Velikov --- src/mesa/Makefile.am | 6 ++ src/mesa/Makefile.sources | 4 +++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/Makefile.am b/src/mesa/Makefile.am index 8dc44fd..3903818 100644 --- a/src/mesa/Makefile.am +++ b/

[Mesa-dev] [PATCH 8/9] compiler: android: flesh out nir into separate makefile

From: Emil Velikov Signed-off-by: Emil Velikov --- src/compiler/Android.mk| 25 ++ .../{Android.gen.mk => Android.nir.gen.mk} | 0 src/{loader/Android.mk => compiler/Android.nir.mk} | 21 ++ 3 files changed, 14 insertions(

[Mesa-dev] [PATCH 7/9] compiler: automake: flesh out nir into separate makefile.

From: Emil Velikov Analogous to previous commit - improved readability at the expense of an extra file. Signed-off-by: Emil Velikov --- src/compiler/Makefile.am | 71 +-- src/compiler/{Makefile.am => Makefile.nir.am} | 37 -- 2 files cha

[Mesa-dev] [PATCH 2/9] glsl: move the scons build script a level up

From: Emil Velikov It will allow us to remove the duplicate glsl/Makefile.sources. Signed-off-by: Emil Velikov --- src/compiler/Makefile.am | 2 +- src/compiler/SConscript | 2 +- src/compiler/{glsl/SConscript => SConscript.glsl} | 36 ++

[Mesa-dev] [PATCH 1/9] Part revert "gallium/auxiliary: don't build NIR sources with MSVC2008 flags"

From: Emil Velikov This reverts commit 41c7912d04111a7e3b75a438c5cbbd7edc0fee25 but leaves out the pragma [that inspired the original commit]. Building mesa requires MSVC2013 or later, thus we no longer need this. Conflicts: src/gallium/auxiliary/Makefile.am --- src/gallium/auxiliary/M

[Mesa-dev] [PATCH 4/9] configure.ac: update the path of the generated files

From: Emil Velikov ... in order to determine if we need bison/flex. Failing to locate the files will lead to mandating bison/flex even when building from a release tarball. CC: "11.2" Signed-off-by: Emil Velikov --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 6/9] compiler: automake: split out glsl into separate makefile

From: Emil Velikov Preserve the functionality while keeping the files smaller and more readable. Signed-off-by: Emil Velikov --- src/compiler/Makefile.am | 195 + src/compiler/{Makefile.am => Makefile.glsl.am} | 104 - 2 files changed,

[Mesa-dev] [PATCH 3/9] glsl: move the android build scripts a level up

From: Emil Velikov Analogous to previous commit. Signed-off-by: Emil Velikov --- Android.mk| 1 - src/compiler/{glsl/Android.gen.mk => Android.glsl.gen.mk} | 13 +++-- src/compiler/{glsl/Android.mk => Android.glsl.mk} | 2 +- sr

[Mesa-dev] [PATCH 5/9] compiler: remove {glsl, nir}/Makefile.sources

From: Emil Velikov No longer used as of last commit. Signed-off-by: Emil Velikov --- src/compiler/Makefile.am | 4 +- src/compiler/glsl/Makefile.am | 228 - src/compiler/glsl/Makefile.sources | 223 src/c

[Mesa-dev] [PATCH 0/9] Remove duplicated src/compiler/*/Makefile.sources

Hi all, I believe the title says it all. Additionally there are a couple of nice fixes (patches 1, 4 and 9) and a few possibly controversial changes in - patches 6, 7 and 8. The later split the contents of the Makefiles preserving the parallelism. -Emil ___

Re: [Mesa-dev] [PATCH 03/16] nir: add lowering pass for y-transform

On 26 March 2016 at 21:02, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > Reviewed-by: Connor Abbott > --- > src/compiler/Makefile.sources| 1 + > src/compiler/nir/nir.h | 12 ++ > src/compiler/nir/nir_lower_wpos_ytransform.c | 310 >

Re: [Mesa-dev] [PATCH 2/2] i965/tiled_memcpy: Protect against wrong alignments

Am 05.04.2016 um 03:04 schrieb Jason Ekstrand: > It's possible, when doing an x-tiled copy, to end up with a case where the > bytes parameter is equal to 16 but the pointer is not actually aligned. > This causes asserts in debug mode and segfaults in release builds due to > doing an aligned operati

Re: [Mesa-dev] [PATCH 15/16] mesa/st: add nir pass for lowering builtin uniforms

On 26 March 2016 at 21:02, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/mesa/Makefile.sources | 2 + > src/mesa/state_tracker/st_nir.h | 28 +++ > src/mesa/state_tracker/st_nir_lower_builtin.c | 242 > +

Re: [Mesa-dev] [PATCH 2/2] i965/tiled_memcpy: Protect against wrong alignments

On Tue, Apr 5, 2016 at 10:12 AM, Roland Scheidegger wrote: > Am 05.04.2016 um 03:04 schrieb Jason Ekstrand: > > It's possible, when doing an x-tiled copy, to end up with a case where > the > > bytes parameter is equal to 16 but the pointer is not actually aligned. > > This causes asserts in debug

Re: [Mesa-dev] [PATCH 03/16] nir: add lowering pass for y-transform

On Tue, Apr 5, 2016 at 1:06 PM, Emil Velikov wrote: > On 26 March 2016 at 21:02, Rob Clark wrote: >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> Reviewed-by: Connor Abbott >> --- >> src/compiler/Makefile.sources| 1 + >> src/compiler/nir/nir.h |

Re: [Mesa-dev] [PATCH 15/16] mesa/st: add nir pass for lowering builtin uniforms

On Tue, Apr 5, 2016 at 1:14 PM, Emil Velikov wrote: > On 26 March 2016 at 21:02, Rob Clark wrote: >> From: Rob Clark >> >> Signed-off-by: Rob Clark >> --- >> src/mesa/Makefile.sources | 2 + >> src/mesa/state_tracker/st_nir.h | 28 +++ >> src/mesa/state_tra

[Mesa-dev] [PATCH] trace: add missing set_shader_images()

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/trace/tr_context.c| 39 ++ src/gallium/drivers/trace/tr_dump_state.c | 40 +++ src/gallium/drivers/trace/tr_dump_state.h | 2 ++ 3 files changed, 81 insertions(+) diff --git a/src/

Re: [Mesa-dev] [PATCH 16/16] mesa/st: add support for NIR as possible driver IR

Hi Rob, Not sure if there's a series that split things up ? I believe my comments will be applicable either way. On 26 March 2016 at 21:02, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > src/compiler/nir/nir.h | 2 + > .../drivers/freedre

Re: [Mesa-dev] [PATCH 0/9] Remove duplicated src/compiler/*/Makefile.sources

On Tue, Apr 5, 2016 at 9:49 AM, Emil Velikov wrote: > Hi all, > > I believe the title says it all. Additionally there are a couple of nice > fixes (patches 1, 4 and 9) and a few possibly controversial changes in - > patches 6, 7 and 8. The later split the contents of the Makefiles > preserving th

Re: [Mesa-dev] [PATCH] clover: Fix build against clang SVN >= r265359

On Tue, Apr 05, 2016 at 03:43:35PM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > Signed-off-by: Michel Dänzer I pushed this, thanks. -Tom > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/state_track

Re: [Mesa-dev] [PATCH 4/9] configure.ac: update the path of the generated files

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/9] Remove duplicated src/compiler/*/Makefile.sources

On 5 April 2016 at 18:47, Jason Ekstrand wrote: > On Tue, Apr 5, 2016 at 9:49 AM, Emil Velikov > wrote: >> >> Hi all, >> >> I believe the title says it all. Additionally there are a couple of nice >> fixes (patches 1, 4 and 9) and a few possibly controversial changes in - >> patches 6, 7 and 8. T

Re: [Mesa-dev] [PATCH 2/2] i965/tiled_memcpy: Protect against wrong alignments

Am 05.04.2016 um 19:19 schrieb Jason Ekstrand: > > > On Tue, Apr 5, 2016 at 10:12 AM, Roland Scheidegger > wrote: > > Am 05.04.2016 um 03:04 schrieb Jason Ekstrand: > > It's possible, when doing an x-tiled copy, to end up with a case > where the > > by

Re: [Mesa-dev] [PATCH 00/16] gallium: add support for NIR as alternate IR

Hi Rob, I have 2 questions. 1) Do you have any data about performance of shader compilation between: GLSL -> TGSI -> driver IR -> bytecode -and- GLSL -> NIR -> driver IR -> bytecode 2) What's the quality of the driver IR when it comes out of NIR? Is it optimized well? Thanks, Marek On Sat,

[Mesa-dev] Merging the Vulkan driver

All, We are getting very close to being able to merge the Vulkan driver into mesa master. I've got around 30 patches on the mailing list that are still awaiting review. Once those get merged, the diff between the "vulkan" and "master" branches is basically zero except for adding new files. The

Re: [Mesa-dev] [PATCH 00/16] gallium: add support for NIR as alternate IR

On Tue, Apr 5, 2016 at 3:25 PM, Marek Olšák wrote: > Hi Rob, > > I have 2 questions. > > 1) Do you have any data about performance of shader compilation between: > > GLSL -> TGSI -> driver IR -> bytecode > -and- > GLSL -> NIR -> driver IR -> bytecode > I can't compare this directly, since for me

[Mesa-dev] [PATCH v2] dri/i965: fix incorrect rgbFormat in intelCreateBuffer().

It is incorrect to assume that pixel format is always in BGR byte order. We need to check bitmask parameters (such as |redMask|) to determine whether the RGB or BGR byte order is requested. Furthermore when parameter |sRGBCapable| is set to false, we should be using UNORM format by default. v2: r

Re: [Mesa-dev] [PATCH v2] dri/i965: fix incorrect rgbFormat in intelCreateBuffer().

On Tue, Apr 5, 2016 at 4:33 PM, Haixia Shi wrote: > It is incorrect to assume that pixel format is always in BGR byte order. > We need to check bitmask parameters (such as |redMask|) to determine whether > the RGB or BGR byte order is requested. > > Furthermore when parameter |sRGBCapable| is set

Re: [Mesa-dev] [PATCH v2] dri/i965: fix incorrect rgbFormat in intelCreateBuffer().

CC Stephane In my opinion we should not assume sRGB-capable when alpha is requested, because UNORM is the more common use case. I actually have a use case where alpha is requested but not sRGBCapable, and if we assume SRGB by default then we will get really white-washed faded color. On Tue, Apr 5

Re: [Mesa-dev] [PATCH v2] dri/i965: fix incorrect rgbFormat in intelCreateBuffer().

On Tue, Apr 5, 2016 at 4:57 PM, Haixia Shi wrote: > CC Stephane > > In my opinion we should not assume sRGB-capable when alpha is requested, > because UNORM is the more common use case. I actually have a use case where > alpha is requested but not sRGBCapable, and if we assume SRGB by default > th

[Mesa-dev] [Bug 94168] Incorrect rendering when running Populous 3 on wine using DDraw->WineD3D->OpenGL wrapper [apitrace]

https://bugs.freedesktop.org/show_bug.cgi?id=94168 --- Comment #1 from Marek Olšák --- Can this be reproduced on i965? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing

Re: [Mesa-dev] [PATCH] r600g: fix and optimize tgsi_cmp when using ABS and NEG modifier

On Sat, Apr 2, 2016 at 11:45 AM, Patrick Rudolph wrote: > Are there optimizations done on TGSI ? > I can't find any file in src/gallium/auxiliary/tgsi that does so. Since this is for Nine, only the driver can do optimizations. r600_shader.c is probably the best place to optimize this (or SB). Ma

Re: [Mesa-dev] [PATCH v3] egl: add EGL_KHR_reusable_sync to egl_dri

Hi Emil, I don't think I still have a chance to update this to version 4 since this has already been pushed according to Marek... However, I will follow up your suggestion with a separate patch once this is completely merged.. -DW On Tue, Apr 05, 2016 at 03:09:41PM +0100, Emil Velikov wrote: >

Re: [Mesa-dev] [PATCH 1/2] i965/tiled_memcpy: Add alignment assumption decorations

On 04/04/2016 06:04 PM, Jason Ekstrand wrote: > This should help GCC when inlining memcpy to be able to better choose an > aligned version. It should also fix potential performance issues in the > next commit. > --- > src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 30 > +++-

Re: [Mesa-dev] [PATCH 2/2] i965/tiled_memcpy: Protect against wrong alignments

On 04/04/2016 06:04 PM, Jason Ekstrand wrote: > It's possible, when doing an x-tiled copy, to end up with a case where the > bytes parameter is equal to 16 but the pointer is not actually aligned. > This causes asserts in debug mode and segfaults in release builds due to > doing an aligned operatio

Re: [Mesa-dev] [PATCH 03/20] radeonsi: add shared memory

On 02.04.2016 08:10, Bas Nieuwenhuizen wrote: Declares the shared memory as a global variable so that LLVM is aware of it and it does not conflict with passes like AMDGPUPromoteAlloca. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeon/radeon_llvm.h | 3 ++ .../driver

Re: [Mesa-dev] [PATCH 05/20] radeonsi: implement shared atomics

On 02.04.2016 08:10, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_shader.c | 89 +++- 1 file changed, 88 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/rade

Re: [Mesa-dev] [PATCH 08/20] radeonsi: implement TGSI compute shader creation

On 02.04.2016 08:10, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 72 +++ 1 file changed, 54 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/r

Re: [Mesa-dev] [PATCH 2/2] i965/tiled_memcpy: Protect against wrong alignments

On Tue, Apr 5, 2016 at 4:26 PM, Chad Versace wrote: > On 04/04/2016 06:04 PM, Jason Ekstrand wrote: > > It's possible, when doing an x-tiled copy, to end up with a case where > the > > bytes parameter is equal to 16 but the pointer is not actually aligned. > > This causes asserts in debug mode an

Re: [Mesa-dev] [PATCH 05/20] radeonsi: implement shared atomics

On Wed, Apr 6, 2016 at 1:42 AM, Nicolai Hähnle wrote: > On 02.04.2016 08:10, Bas Nieuwenhuizen wrote: >> >> Signed-off-by: Bas Nieuwenhuizen >> --- >> src/gallium/drivers/radeonsi/si_shader.c | 89 >> +++- >> 1 file changed, 88 insertions(+), 1 deletion(-) >> >> dif

Re: [Mesa-dev] [PATCH 2/2] i965/tiled_memcpy: Protect against wrong alignments

Am 06.04.2016 um 01:50 schrieb Jason Ekstrand: > On Tue, Apr 5, 2016 at 4:26 PM, Chad Versace > wrote: > > On 04/04/2016 06:04 PM, Jason Ekstrand wrote: > > It's possible, when doing an x-tiled copy, to end up with a case > where the > > bytes parame

Re: [Mesa-dev] [PATCH 13/20] radeonsi: only emit compute shader state when switching shaders

There's a dangling-pointer error waiting to happen with emitted_bo when the last launched shader is deleted. It seems safer to use emitted_shader rather than emitted_bo, and then NULL that in si_delete_compute_state if required. Cheers, Nicolai On 02.04.2016 08:10, Bas Nieuwenhuizen wrote:

Re: [Mesa-dev] [PATCH 16/20] radeonsi: split setting graphics and compute descriptors

On 02.04.2016 08:10, Bas Nieuwenhuizen wrote: Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 3 ++ src/gallium/drivers/radeonsi/si_descriptors.c | 60 ++- src/gallium/drivers/radeonsi/si_state.h | 7 +++- src/gallium/driv

Re: [Mesa-dev] [PATCH v2] dri/i965: fix incorrect rgbFormat in intelCreateBuffer().

Are you referring to the following check mesa_format _mesa_get_render_format(const struct gl_context *ctx, mesa_format format) { if (ctx->Color.sRGBEnabled) return format; else return _mesa_get_srgb_format_linear(format); } So if the platform sets ctx->Color.sRGBEnabled = false

Re: [Mesa-dev] [PATCH v2] dri/i965: fix incorrect rgbFormat in intelCreateBuffer().

Sounds right. That's glEnable/glDisable(GL_FRAMEBUFFER_SRGB). It defaults to off for desktop GL, and on for GL ES (why? no clue.) On Tue, Apr 5, 2016 at 8:11 PM, Haixia Shi wrote: > Are you referring to the following check > > mesa_format > _mesa_get_render_format(const struct gl_context *ctx, me

Re: [Mesa-dev] [PATCH 00/20] GL compute shaders for radeonsi

On 02.04.2016 08:10, Bas Nieuwenhuizen wrote: This series implements OpenGL compute shader for radeonsi. It is based off master + Nicolai Hähnle's SSBO patches. It depends on two patches for LLVM that have not been committed yet: - D18340 - D18559 The series is also available as the si-co

Re: [Mesa-dev] [PATCH] trace: add missing set_shader_images()

Reviewed-by: Nicolai Hähnle On 05.04.2016 12:37, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/trace/tr_context.c| 39 ++ src/gallium/drivers/trace/tr_dump_state.c | 40 +++ src/gallium/drivers/trac

Re: [Mesa-dev] [PATCH] glsl: allow conservative depth qualifiers in GLSL 420

On Mon, Apr 4, 2016 at 2:33 PM, Matt Turner wrote: > On Sat, Apr 2, 2016 at 6:12 PM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> >> Noticed by inspection. >> >> src/compiler/glsl/ast_to_hir.cpp | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/src/com

[Mesa-dev] [PATCH v3] dri/i965: fix incorrect rgbFormat in intelCreateBuffer().

It is incorrect to assume that pixel format is always in BGR byte order. We need to check bitmask parameters (such as |redMask|) to determine whether the RGB or BGR byte order is requested. v2: reformat code to stay within 80 character per line limit. v3: just fix the byte order problem first and

[Mesa-dev] [PATCH 1/2] i965/fs: Add a flat_inputs field to prog_data

--- src/mesa/drivers/dri/i965/brw_compiler.h | 6 ++ src/mesa/drivers/dri/i965/brw_fs.cpp | 31 +++ 2 files changed, 37 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_compiler.h b/src/mesa/drivers/dri/i965/brw_compiler.h index 231e000..3c7e382 10064

[Mesa-dev] [PATCH 2/2] i965/sf_state: Pull flat_enables out of prog_data

Previously, we were walking over the shader source to figure out which inputs should be marked flat. Now, we can just pull it out of prog_data. This is needed for properly setting up 3DSTATE_SF/SBE for Vulkan and it also means that it will get properly cached. --- src/mesa/drivers/dri/i965/brw_st

[Mesa-dev] [PATCH 0/6] i965/vec4: Add indirect push constant support

This little series applies on top of the bigger series to do indirect push constants in the FS backend. This series allows us to do indirect push constants in the vec4 backend as well. As it currently stands, it should be behaviourly identical for the GL driver to what we had before this series.

[Mesa-dev] [PATCH 1/6] i965/vec4: Move can_do_writemask to vec4_instruction

--- src/mesa/drivers/dri/i965/brw_ir_vec4.h| 1 + src/mesa/drivers/dri/i965/brw_vec4.cpp | 28 +++ .../dri/i965/brw_vec4_dead_code_eliminate.cpp | 31 +- 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/src/mesa/driv

[Mesa-dev] [PATCH 4/6] i965/vec4: Handle MOV_INDIRECT in pack_uniform_registers

--- src/mesa/drivers/dri/i965/brw_vec4.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index e2aa109..6433fc5 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp +++ b/src/mesa/drivers/dri/

[Mesa-dev] [PATCH 6/6] i965: Push everything if pull_param == NULL

--- src/mesa/drivers/dri/i965/brw_fs.cpp | 10 -- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 6 ++ 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index fe1bf97..91cd00f 100644

[Mesa-dev] [PATCH 3/6] i965/vec4: Add support for SHADER_OPCODE_MOV_INDIRECT

--- src/mesa/drivers/dri/i965/brw_vec4.cpp | 1 + src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 67 2 files changed, 68 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 87b5ff9..e2aa109 10064

[Mesa-dev] [PATCH 2/6] i965/vec4: Use can_do_writemask in can_reswizzle

--- src/mesa/drivers/dri/i965/brw_vec4.cpp | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index 4d0efa8..87b5ff9 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp +++ b/src/mesa/drivers/

[Mesa-dev] [PATCH 5/6] i965/vec4: Support full std140 layout for push constants

Up until now, we have been able to assume that all push constants are vec4-aligned because this is what the GL driver gives us. In Vulkan, we need to be able to support full std140 because we get the layout from the client. --- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 30 +

Re: [Mesa-dev] [PATCH 1/2] i965/fs: Add a flat_inputs field to prog_data

On 06/04/16 05:12, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_compiler.h | 6 ++ > src/mesa/drivers/dri/i965/brw_fs.cpp | 31 +++ > 2 files changed, 37 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_compiler.h > b/src/mesa/dri

Re: [Mesa-dev] [PATCH 2/2] i965/sf_state: Pull flat_enables out of prog_data

Reviewed-by: Samuel Iglesias Gonsálvez On 06/04/16 05:12, Jason Ekstrand wrote: > Previously, we were walking over the shader source to figure out which > inputs should be marked flat. Now, we can just pull it out of prog_data. > This is needed for properly setting up 3DSTATE_SF/SBE for Vulkan a