Re: [Mesa-dev] [PATCH v2 00/15] i965: Rework uniform handling in the back-end

On Apr 7, 2016 10:01 PM, "Matt Turner" wrote: > > On Tue, Mar 22, 2016 at 3:33 PM, Jason Ekstrand wrote: > > This is mostly a re-send of a patch series I've had floating around in one > > form or a while for quite some time. It's basically the same except that > > the original version was missin

Re: [Mesa-dev] [PATCH] st/va: avoid dereference after free

Hi Thomas and Emil, I tested it and pushed. Thx a lot. On 6 April 2016 at 21:34, Thomas H.P. Andersen wrote: > > > On Sun, Mar 6, 2016 at 10:08 AM, Thomas H.P. Andersen > wrote: > >> >> >> On Sat, Mar 5, 2016 at 1:30 PM, Emil Velikov >> wrote: >> >>> Hi Thomas, >>> >>> On 5 March 2016 at 12:07

Re: [Mesa-dev] [PATCH v2 00/15] i965: Rework uniform handling in the back-end

On Tue, Mar 22, 2016 at 3:33 PM, Jason Ekstrand wrote: > This is mostly a re-send of a patch series I've had floating around in one > form or a while for quite some time. It's basically the same except that > the original version was missing a work-around for Sandy Bridge. For a > while, I wasn'

Re: [Mesa-dev] Merging the Vulkan driver

On Thu, Apr 7, 2016 at 4:34 PM, Grazvydas Ignotas wrote: > Hi, > > On Tue, Apr 5, 2016 at 10:30 PM, Jason Ekstrand wrote: >> I know we don't usually do merges in this project, but >> the Vulkan driver is big and has a lot of history that we would like to >> preserve. If you're strongly opposed t

Re: [Mesa-dev] [PATCH] glsl: handle unsigned int wraparound in link_shaders()

On Thu, 2016-04-07 at 11:22 -0400, Lars Hamre wrote: > NOTES: > * Reposting due to no response last week > * Someone with access will need to commit this patch after the review >   process > > check_explicit_uniform_locations() returns a -1 when the extension > ARB_explicit_uniform_location is not

Re: [Mesa-dev] [PATCH 3/3] i965/tiled_memoyp: Get rid of the direction parameter to get_memcpy

Am 07.04.2016 um 22:56 schrieb Jason Ekstrand: > Now that we can use the much simpler rgba8_copy function, we don't need to > hand different functions out based on direction. > --- > src/mesa/drivers/dri/i965/intel_pixel_read.c | 3 +-- > src/mesa/drivers/dri/i965/intel_tex_image.c| 3 +--

Re: [Mesa-dev] [PATCH 2/2] gallium: pause queries for all meta ops

Am 08.04.2016 um 02:11 schrieb Marek Olšák: > From: Marek Olšák > > --- > src/gallium/auxiliary/cso_cache/cso_context.c | 4 > src/gallium/auxiliary/cso_cache/cso_context.h | 1 + > src/gallium/auxiliary/hud/hud_context.c | 1 + > src/gallium/auxiliary/postprocess/pp_run.c| 1 + >

Re: [Mesa-dev] [PATCH] st/mesa: fix glReadBuffer() assertion failure

On 04/07/2016 06:17 PM, Roland Scheidegger wrote: Am 08.04.2016 um 01:45 schrieb Brian Paul: If the first call in a GL app is glReadPixels(GL_FRONT) we'd fail the assert(st->ctx->FragmentProgram._Current) at st_atom_shader.c:114 in update_fp(). This is because we were calling st_validate_state(

Re: [Mesa-dev] [PATCH] st/mesa: fix glReadBuffer() assertion failure

Am 08.04.2016 um 01:45 schrieb Brian Paul: > If the first call in a GL app is glReadPixels(GL_FRONT) we'd fail the > assert(st->ctx->FragmentProgram._Current) at st_atom_shader.c:114 in > update_fp(). > > This is because we were calling st_validate_state() without first > updating Mesa state with

[Mesa-dev] [PATCH 2/2] gallium: pause queries for all meta ops

From: Marek Olšák --- src/gallium/auxiliary/cso_cache/cso_context.c | 4 src/gallium/auxiliary/cso_cache/cso_context.h | 1 + src/gallium/auxiliary/hud/hud_context.c | 1 + src/gallium/auxiliary/postprocess/pp_run.c| 1 + src/gallium/auxiliary/util/u_blit.c | 1 + src/ga

[Mesa-dev] [PATCH 1/2] gallium: add pipe_context::set_active_query_state for pausing queries

From: Marek Olšák --- src/gallium/docs/source/context.rst | 3 +++ src/gallium/drivers/ddebug/dd_context.c | 9 + src/gallium/drivers/freedreno/freedreno_query.c | 6 ++ src/gallium/drivers/i915/i915_query.c | 6 ++ src/gallium/drivers/ilo/ilo_qu

Re: [Mesa-dev] [PATCH 3/3] i965/tiled_memoyp: Get rid of the direction parameter to get_memcpy

On Thu, Apr 7, 2016 at 1:56 PM, Jason Ekstrand wrote: > Now that we can use the much simpler rgba8_copy function, we don't need to > hand different functions out based on direction. > --- Typo in the subject, and PATCH 2/3 needs a bugzilla link. The series is Reviewed-by: Matt Turner I notice

Re: [Mesa-dev] Merging the Vulkan driver

On Thu, Apr 7, 2016 at 4:48 PM, Jason Ekstrand wrote: > > > On Thu, Apr 7, 2016 at 4:34 PM, Grazvydas Ignotas > wrote: > >> Hi, >> >> On Tue, Apr 5, 2016 at 10:30 PM, Jason Ekstrand >> wrote: >> > I know we don't usually do merges in this project, but >> > the Vulkan driver is big and has a lot

Re: [Mesa-dev] Merging the Vulkan driver

On Thu, Apr 7, 2016 at 4:34 PM, Grazvydas Ignotas wrote: > Hi, > > On Tue, Apr 5, 2016 at 10:30 PM, Jason Ekstrand > wrote: > > I know we don't usually do merges in this project, but > > the Vulkan driver is big and has a lot of history that we would like to > > preserve. If you're strongly opp

[Mesa-dev] [PATCH] st/mesa: fix glReadBuffer() assertion failure

If the first call in a GL app is glReadPixels(GL_FRONT) we'd fail the assert(st->ctx->FragmentProgram._Current) at st_atom_shader.c:114 in update_fp(). This is because we were calling st_validate_state() without first updating Mesa state with _mesa_update_state(). The regression came from commit

[Mesa-dev] [PATCH 2/4] nir: Silence unused "options" warning in algebraic passes.

Some passes may not refer to options->..., at which point the compiler will warn about an unused variable. Just cast to void unconditionally to shut it up. Signed-off-by: Kenneth Graunke --- src/compiler/nir/nir_algebraic.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/n

[Mesa-dev] [PATCH 4/4] i965: Port INTEL_PRECISE_TRIG=1 to NIR.

This makes the extra multiply visible to NIR's algebraic optimizations (for constant reassociation) as well as constant folding. This means that when the result of sin/cos are multiplied by an constant, we can eliminate the extra multiply altogether, reducing the cost of the workaround. It also m

[Mesa-dev] [PATCH 3/4] i965: Pass brw_compiler into brw_preprocess_nir() instead of is_scalar.

I want to be able to read other fields. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_nir.c | 6 -- src/mesa/drivers/dri/i965/brw_nir.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_nir.c b/src/mesa/drivers/dri/i965/

[Mesa-dev] [PATCH 1/4] nir: Do basic constant reassociation.

Many shaders contain expression trees of the form: const_1 * (value * const_2) Reorganizing these to (const_1 * const_2) * value will allow constant folding to combine the constants. Sometimes, these constants are 2 and 0.5, so we can remove a multiply altogether. Other times, it can

Re: [Mesa-dev] Merging the Vulkan driver

Hi, On Tue, Apr 5, 2016 at 10:30 PM, Jason Ekstrand wrote: > I know we don't usually do merges in this project, but > the Vulkan driver is big and has a lot of history that we would like to > preserve. If you're strongly opposed to doing a merge, please speak up now! I fear issues like the one

Re: [Mesa-dev] [PATCH v2 04/15] i965/fs: Add support for MOV_INDIRECT on pre-Broadwell hardware

On Tue, Mar 22, 2016 at 3:33 PM, Jason Ekstrand wrote: > While we're at it, we also add support for the possibility that the > indirect is, in fact, a constant. This shouldn't happen in the common case > (if it does, that means NIR failed to constant-fold something), but it's > possible so we sho

Re: [Mesa-dev] [PATCH v2 03/15] i965/fs: Fix regs_read() for MOV_INDIRECT with a non-zero subnr

On Thu, Apr 7, 2016 at 2:30 PM, Matt Turner wrote: > On Tue, Mar 22, 2016 at 3:33 PM, Jason Ekstrand > wrote: > > The subnr field is in bytes so we don't need to multiply by type_sz. > > --- > > src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >

Re: [Mesa-dev] [PATCH 13/15] i965/fs: Add support for MOV_INDIRECT on pre-Broadwell hardware

On Thu, Apr 7, 2016 at 2:37 PM, Matt Turner wrote: > On Wed, Dec 9, 2015 at 8:23 PM, Jason Ekstrand > wrote: > > While we're at it, we also add support for the possibility that the > > indirect is, in fact, a constant. This shouldn't happen in the common > case > > (if it does, that means NIR f

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On 04/07/2016 08:50 PM, Ian Romanick wrote: On 04/07/2016 10:57 AM, Stéphane Marchesin wrote: On Thu, Apr 7, 2016 at 10:44 AM, Miklós Máté wrote: On 04/07/2016 12:40 PM, Stéphane Marchesin wrote: On Thu, Apr 7, 2016 at 3:37 AM, Miklós Máté wrote: On 04/07/2016 12:25 PM, Stéphane Marchesin w

Re: [Mesa-dev] [PATCH v2 02/15] i965/fs: Don't force MASK_DISABLE on INDIRECT_MOV instructions

On Thu, Apr 7, 2016 at 2:16 PM, Matt Turner wrote: > On Tue, Mar 22, 2016 at 3:33 PM, Jason Ekstrand > wrote: > > It should work fine without it and the visitor can set it if it wants. > > --- > > Does this need to be a separate patch? Ease of testing or something? > Mostly that it's conceptual

Re: [Mesa-dev] [PATCH] radeonsi: do per-pixel clipping based on viewport states

On 07.04.2016 14:17, Marek Olšák wrote: On Thu, Apr 7, 2016 at 7:56 PM, Nicolai Hähnle wrote: On 06.04.2016 19:06, Marek Olšák wrote: From: Marek Olšák In other words, vport scissors are derived from viewport states. If the scissor test is enabled, the intersection of both is used. The gua

Re: [Mesa-dev] [PATCH 13/15] i965/fs: Add support for MOV_INDIRECT on pre-Broadwell hardware

On Wed, Dec 9, 2015 at 8:23 PM, Jason Ekstrand wrote: > While we're at it, we also add support for the possibility that the > indirect is, in fact, a constant. This shouldn't happen in the common case > (if it does, that means NIR failed to constant-fold something), but it's > possible so we shou

Re: [Mesa-dev] [PATCH v2 03/15] i965/fs: Fix regs_read() for MOV_INDIRECT with a non-zero subnr

On Tue, Mar 22, 2016 at 3:33 PM, Jason Ekstrand wrote: > The subnr field is in bytes so we don't need to multiply by type_sz. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/dr

[Mesa-dev] [PATCH v2] doxygen: update glsl link

Signed-off-by: Elie TOURNIER --- doxygen/glsl.doxy | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/doxygen/glsl.doxy b/doxygen/glsl.doxy index 9915ba2..ef71a4a 100644 --- a/doxygen/glsl.doxy +++ b/doxygen/glsl.doxy @@ -9,11 +9,12 @@ PROJECT_NAME = "Mesa GLSL

Re: [Mesa-dev] [PATCH v2 02/15] i965/fs: Don't force MASK_DISABLE on INDIRECT_MOV instructions

On Tue, Mar 22, 2016 at 3:33 PM, Jason Ekstrand wrote: > It should work fine without it and the visitor can set it if it wants. > --- Does this need to be a separate patch? Ease of testing or something? ___ mesa-dev mailing list mesa-dev@lists.freedeskt

Re: [Mesa-dev] [PATCH v2 11/15] i965/vec4: Use MOV_INDIRECT instead of reladdr for indirect push constants

There are a bunch of tabs in this patch you can get rid of. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/3] i965/tiled_memoyp: Get rid of the direction parameter to get_memcpy

Now that we can use the much simpler rgba8_copy function, we don't need to hand different functions out based on direction. --- src/mesa/drivers/dri/i965/intel_pixel_read.c | 3 +-- src/mesa/drivers/dri/i965/intel_tex_image.c| 3 +-- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 +--

[Mesa-dev] [PATCH 1/3] i965/tiled_memcpy: Add aligned mem_copy parameters to the [de]tiling functions

Each of the [de]tiling functions has three mem_copy calls: 1) Left edge to tile boundary 2) Tile boundary to tile boundary in a loop 3) Tile boundary to right edge Copies 2 and 3 start at a tile edge so the pointer to tiled memory is guaranteed to be at least 16-byte aligned. Copy 1, on the o

[Mesa-dev] [PATCH 2/3] i965/tiled_memcpy: Rework the RGBA -> BGRA mem_copy functions

This splits the two copy functions into three: One for unaligned copies, one for aligned sources, and one for aligned destinations. Thanks to the previous commit, we are now guaranteed that the aligned ones will *only* operate on aligned memory so they should be safe. --- src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH] nv50/ir: do not try to attach JOIN ops to ATOM

On Thu, Apr 7, 2016 at 4:48 PM, Samuel Pitoiset wrote: > > > On 04/07/2016 10:46 PM, Ilia Mirkin wrote: >> >> On Thu, Apr 7, 2016 at 4:42 PM, Samuel Pitoiset >> wrote: >>> >>> This might result in an INVALID_OPCODE dmesg error in case a join is >>> attached to an atomic operation. >>> >>> Spotted

Re: [Mesa-dev] [PATCH] nv50/ir: do not try to attach JOIN ops to ATOM

On 04/07/2016 10:46 PM, Ilia Mirkin wrote: On Thu, Apr 7, 2016 at 4:42 PM, Samuel Pitoiset wrote: This might result in an INVALID_OPCODE dmesg error in case a join is attached to an atomic operation. Spotted with arb_shader_image_load_store-host-mem-barrier on GK104. Signed-off-by: Samuel P

Re: [Mesa-dev] [PATCH] nv50/ir: do not try to attach JOIN ops to ATOM

On Thu, Apr 7, 2016 at 4:42 PM, Samuel Pitoiset wrote: > This might result in an INVALID_OPCODE dmesg error in case a join is > attached to an atomic operation. > > Spotted with arb_shader_image_load_store-host-mem-barrier on GK104. > > Signed-off-by: Samuel Pitoiset > Cc: mesa-sta...@lists.freed

Re: [Mesa-dev] [PATCH v2 12/15] i965/fs: Use UD type for offsets in VARYING_PULL_CONSTANT_LOAD

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] nv50/ir: do not try to attach JOIN ops to ATOM

This might result in an INVALID_OPCODE dmesg error in case a join is attached to an atomic operation. Spotted with arb_shader_image_load_store-host-mem-barrier on GK104. Signed-off-by: Samuel Pitoiset Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole

Re: [Mesa-dev] [PATCH 1/2] gallium: add pipe_depth_state::disable_occlusion_queries

Am 07.04.2016 um 10:37 schrieb Marek Olšák: > On Thu, Apr 7, 2016 at 3:22 AM, Roland Scheidegger wrote: >> Where's the doc bits... >> >> But aside from that, this doesn't look quite right to me. Doesn't really >> feel like depth state (more like context one to suspend queries), and >> more importa

Re: [Mesa-dev] [PATCH] radeonsi: do per-pixel clipping based on viewport states

On Thu, Apr 7, 2016 at 7:56 PM, Nicolai Hähnle wrote: > On 06.04.2016 19:06, Marek Olšák wrote: >> >> From: Marek Olšák >> >> In other words, vport scissors are derived from viewport states. >> If the scissor test is enabled, the intersection of both is used. >> >> The guard band will disable cli

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On 04/07/2016 10:57 AM, Stéphane Marchesin wrote: > On Thu, Apr 7, 2016 at 10:44 AM, Miklós Máté wrote: >> On 04/07/2016 12:40 PM, Stéphane Marchesin wrote: >>> >>> On Thu, Apr 7, 2016 at 3:37 AM, Miklós Máté wrote: On 04/07/2016 12:25 PM, Stéphane Marchesin wrote: On Apr

Re: [Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

On 04/07/2016 06:17 AM, Rogovin, Kevin wrote: > Hello, > >> typo -> ...query (same goes for patch 1/2) > > I hate typos. Thanks for pointing it out. > >> Please correct me if I'm wrong, but I think we cannot unalias functions once >> they're in. >> It will break the backwards compatibility we'

Re: [Mesa-dev] [PATCH 0/2] Extra check for GenQueriesARB and DeleteQueriesARB

On 04/06/2016 10:29 PM, Ian Romanick wrote: > On 04/06/2016 07:47 PM, Kenneth Graunke wrote: >> On Tuesday, April 5, 2016 2:26:59 PM PDT kevin.rogo...@intel.com wrote: >>> From: Kevin Rogovin >>> >>> This patch sequence enforces an extra check >>> for GenQueriesARB and DeleteQueriesARB that >>> is

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On 04/07/2016 07:57 PM, Stéphane Marchesin wrote: On Thu, Apr 7, 2016 at 10:44 AM, Miklós Máté wrote: On 04/07/2016 12:40 PM, Stéphane Marchesin wrote: On Thu, Apr 7, 2016 at 3:37 AM, Miklós Máté wrote: On 04/07/2016 12:25 PM, Stéphane Marchesin wrote: On Apr 7, 2016 02:27, "Michel Dänzer"

[Mesa-dev] [PATCH 2/2 v5] dri/i965: fix incorrect rgbFormat in intelCreateBuffer().

It is incorrect to assume that pixel format is always in BGR byte order. We need to check bitmask parameters (such as |redMask|) to determine whether the RGB or BGR byte order is requested. v2: reformat code to stay within 80 character per line limit. v3: just fix the byte order problem first and

[Mesa-dev] [PATCH 1/2 v2] dri/i965: extend GLES3 sRGB workaround to cover all formats

It is incorrect to assume BGRA byte order for the GLES3 sRGB workaround. v2: use _mesa_get_srgb_format_linear to handle all formats Signed-off-by: Haixia Shi Reviewed-by: Stéphane Marchesin Cc: kenneth.w.grau...@intel.com Change-Id: I5a081d7eaa7544afff0e7874cffef80d3f69a401 --- src/mesa/drive

Re: [Mesa-dev] [PATCH v2 0/8] gallium, radeonsi: raise number of samplers to 32

Le jeudi 7 avril 2016, 12:35:07 CEST Nicolai Hähnle a écrit : > Hi, > > following feedback from Brian and Bas, minor changes to make the series more > paranoid: three v2 patches and one new patch, using 1u << idx instead of 1 > << idx and adding assert(sizeof(bitfield) * 8 >= PIPE_MAX_SAMPLERS) in

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On Thu, Apr 7, 2016 at 10:44 AM, Miklós Máté wrote: > On 04/07/2016 12:40 PM, Stéphane Marchesin wrote: >> >> On Thu, Apr 7, 2016 at 3:37 AM, Miklós Máté wrote: >>> >>> On 04/07/2016 12:25 PM, Stéphane Marchesin wrote: >>> >>> >>> On Apr 7, 2016 02:27, "Michel Dänzer" wrote: On 07.04.2

Re: [Mesa-dev] [PATCH] radeonsi: do per-pixel clipping based on viewport states

On 06.04.2016 19:06, Marek Olšák wrote: From: Marek Olšák In other words, vport scissors are derived from viewport states. If the scissor test is enabled, the intersection of both is used. The guard band will disable clipping, so we have to clip per-pixel. --- src/gallium/drivers/radeonsi/si

[Mesa-dev] [PATCH 3/3] i965: Check eu/subslices are > 0

Now that the check is restricted to gen8+, we should always get back a non-zero positive value for the EU and subslice counts. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/in

[Mesa-dev] [PATCH 1/3] i965: Extract SSEU configuration info

Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_screen.c | 35 +++- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index c6eb50a..8c687b3 100644 --- a/

[Mesa-dev] [PATCH 2/3] i965: Fix eu/subslice warning

Older gen platforms do not actually return a value for sublice and eu total (IMO, confusingly) they return -ENODEV. This patch defers the SSEU setup until we have the actual GPU generation to avoid useless warnings when running on older platforms with older kernels. Reported-by: Mark Janes Signed

Re: [Mesa-dev] [PATCH v2 1/8] util/pstipple: stronger guard against no free samplers (v2)

On Thu, Apr 7, 2016 at 1:35 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > When hasFixedUnit is false, polygon stippling will fail when there is no free > sampler available. Make the corresponding guard more robust in preparation > of raising PIPE_MAX_SAMPLERS to 32. > > The literal 1 is a

Re: [Mesa-dev] [PATCH v2 3/8] tgsi/scan: add an assert for the size of the samplers_declared bitfield

On 04/07/2016 11:35 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle The literal 1 is a (signed) int, and shifting into the sign bit is undefined in C, so change occurences of 1 to 1u. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --g

Re: [Mesa-dev] [PATCH v2 07/26] nir: Add a pass for gathering various bits of shader info

On Fri, Apr 1, 2016 at 4:20 PM, Jason Ekstrand wrote: > Reviewed-by: Rob Clark > Cc: Kenneth Graunke > > v2: Pull get_io_offset into nir_gather_info and add an assert that our > shader is for one of the supported stages. (Ken) > --- > src/compiler/Makefile.sources | 1 + > src/compi

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On 04/07/2016 12:40 PM, Stéphane Marchesin wrote: On Thu, Apr 7, 2016 at 3:37 AM, Miklós Máté wrote: On 04/07/2016 12:25 PM, Stéphane Marchesin wrote: On Apr 7, 2016 02:27, "Michel Dänzer" wrote: On 07.04.2016 18:01, Marek Olšák wrote: On Thu, Apr 7, 2016 at 7:32 AM, Ian Romanick wrote:

[Mesa-dev] [PATCH v2 7/8] radeonsi: expand the compressed color and depth texture masks to 64 bits

From: Nicolai Hähnle This is in preparation of raising the number of exposed sampler views to 32 bits, which will raise the total number of sampler views to 33 for the polygon stipple texture. That texture should never be compressed (and it's certainly not a depth texture), but this approach seem

[Mesa-dev] [PATCH v2 1/8] util/pstipple: stronger guard against no free samplers (v2)

From: Nicolai Hähnle When hasFixedUnit is false, polygon stippling will fail when there is no free sampler available. Make the corresponding guard more robust in preparation of raising PIPE_MAX_SAMPLERS to 32. The literal 1 is a (signed) int, and shifting into the sign bit is undefined in C, so

[Mesa-dev] [PATCH v2 8/8] radeonsi: raise number of samplers per shader to 32

From: Nicolai Hähnle Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94835 Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.h b/src/gallium/drivers/radeons

[Mesa-dev] [PATCH v2 6/8] radeonsi: replace magic 16 by SI_NUM_USER_SAMPLERS

From: Nicolai Hähnle Reviewed-by: Bas Nieuwenhuizen Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 12e0d50..10b3a03 10

[Mesa-dev] [PATCH v2 5/8] gallium: raise PIPE_MAX_SAMPLERS to 32

From: Nicolai Hähnle The previous value of 18 was motivated by having drivers that want to expose 16 samplers but also use some additional samplers for internal use. Raising the value even higher isn't going to hurt that case. On the other hand, some drivers actually use PIPE_MAX_SAMPLERS as the

[Mesa-dev] [PATCH v2 4/8] st/glsl_to_tgsi: make samplers_used an uint32_t (v2)

From: Nicolai Hähnle It is used as a bitfield, so it seems cleaner to keep it unsigned. The literal 1 is a (signed) int, and shifting into the sign bit is undefined in C, so change occurences of 1 to 1u. v2: add an assert for bitfield size and use 1u << idx Reviewed-by: Brian Paul (v1) Review

[Mesa-dev] [PATCH v2 0/8] gallium, radeonsi: raise number of samplers to 32

Hi, following feedback from Brian and Bas, minor changes to make the series more paranoid: three v2 patches and one new patch, using 1u << idx instead of 1 << idx and adding assert(sizeof(bitfield) * 8 >= PIPE_MAX_SAMPLERS) in a number of places. Thanks, Nicolai

[Mesa-dev] [PATCH v2 3/8] tgsi/scan: add an assert for the size of the samplers_declared bitfield

From: Nicolai Hähnle The literal 1 is a (signed) int, and shifting into the sign bit is undefined in C, so change occurences of 1 to 1u. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src

[Mesa-dev] [PATCH v2 2/8] draw/aaline: stronger guard against no free samplers (v2)

From: Nicolai Hähnle Line anti-aliasing will fail when there is no free sampler available. Make the corresponding guard more robust in preparation of raising PIPE_MAX_SAMPLERS to 32. The literal 1 is a (signed) int, and shifting into the sign bit is undefined in C, so change occurences of 1 to 1

[Mesa-dev] [PATCH] glsl: handle unsigned int wraparound in link_shaders()

NOTES: * Reposting due to no response last week * Someone with access will need to commit this patch after the review process check_explicit_uniform_locations() returns a -1 when the extension ARB_explicit_uniform_location is not found. We were storing the result in num_explicit_uniform_locs as

Re: [Mesa-dev] [PATCH 2/2] i965/tiled_memcpy: Protect against wrong alignments

I realized this morning that there is a lot better way to do this. Consider these patches rescinded. On Apr 4, 2016 6:00 PM, "Jason Ekstrand" wrote: > It's possible, when doing an x-tiled copy, to end up with a case where the > bytes parameter is equal to 16 but the pointer is not actually aligne

Re: [Mesa-dev] [PATCH] nouveau: codegen: Take src swizzle into account on loads

That's wrong. The spec for the instruction needs to be clarified... The current nouveau impl is correct - only the .x of the address should be loaded, with up to 16 bytes read into the destination. On Thu, Apr 7, 2016 at 9:27 AM, Hans de Goede wrote: > The llvm TGSI backend does things like: > >

[Mesa-dev] [Bug 94168] Incorrect rendering when running Populous 3 on wine using DDraw->WineD3D->OpenGL wrapper [apitrace]

https://bugs.freedesktop.org/show_bug.cgi?id=94168 --- Comment #5 from Grazvydas Ignotas --- The cursor is animating, I even tried the game itself (there is a link to free demo in wine bug) and the cursor does animate properly even when inputs are not touched. FWIW I'm using DRI3 on X.Org 1.18.1

[Mesa-dev] [PATCH] nouveau: codegen: Take src swizzle into account on loads

The llvm TGSI backend does things like: LOAD TEMP[0].y, MEMORY[0]., TEMP[0].x Expecting the data at address TEMP[0].x to get loaded to TEMP[0].y. Before this commit the data at TEMP[0].x + 4 would be loaded instead. This commit fixes this. Signed-off-by: Hans de Goede --- src/gallium/drive

Re: [Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

Hello, > typo -> ...query (same goes for patch 1/2) I hate typos. Thanks for pointing it out. > Please correct me if I'm wrong, but I think we cannot unalias functions once > they're in. > It will break the backwards compatibility we're trying to manage with glapi. > If we want to > retain i

[Mesa-dev] [Bug 94168] Incorrect rendering when running Populous 3 on wine using DDraw->WineD3D->OpenGL wrapper [apitrace]

https://bugs.freedesktop.org/show_bug.cgi?id=94168 --- Comment #4 from Marek Olšák --- (In reply to Grazvydas Ignotas from comment #2) > i965 seems to be fine, at least matches LIBGL_ALWAYS_SOFTWARE. Actually, what exactly did you see? You need to run the trace with a low frame rate to be able

[Mesa-dev] [Bug 94168] Incorrect rendering when running Populous 3 on wine using DDraw->WineD3D->OpenGL wrapper [apitrace]

https://bugs.freedesktop.org/show_bug.cgi?id=94168 --- Comment #3 from Marek Olšák --- Then it must be a DRI state tracker bug. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On Thu, Apr 7, 2016 at 3:37 AM, Miklós Máté wrote: > On 04/07/2016 12:25 PM, Stéphane Marchesin wrote: > > > On Apr 7, 2016 02:27, "Michel Dänzer" wrote: >> >> On 07.04.2016 18:01, Marek Olšák wrote: >> > On Thu, Apr 7, 2016 at 7:32 AM, Ian Romanick >> > wrote: >> >> Why would you do that? I've

Re: [Mesa-dev] [PATCH 7/7] radeonsi: raise number of samplers per shader to 32

For the series: Reviewed-by: Marek Olšák Marek On Thu, Apr 7, 2016 at 12:47 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94835 > --- > src/gallium/drivers/radeonsi/si_state.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 delet

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On 04/07/2016 12:25 PM, Stéphane Marchesin wrote: On Apr 7, 2016 02:27, "Michel Dänzer" > wrote: > > On 07.04.2016 18:01, Marek Olšák wrote: > > On Thu, Apr 7, 2016 at 7:32 AM, Ian Romanick > wrote: > >> Why would you do that? I've NAKe

Re: [Mesa-dev] [PATCH 0/7] gallium, radeonsi: raise number of samplers to 32

On Thu, Apr 7, 2016 at 12:11 PM, Marek Olšák wrote: > On Thu, Apr 7, 2016 at 2:18 AM, Bas Nieuwenhuizen > wrote: >> Hi Nicolai, >> >> Patches 1-2 and 5-6 are >> >> Reviewed-by: Bas Nieuwenhuizen >> >> However, for increasing the limits there are several cases which still >> use signed shifts (i.

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On Apr 7, 2016 02:27, "Michel Dänzer" wrote: > > On 07.04.2016 18:01, Marek Olšák wrote: > > On Thu, Apr 7, 2016 at 7:32 AM, Ian Romanick wrote: > >> Why would you do that? I've NAKed this patch several times. > > > > You NAKed the previous version of the patch, not this one. I guess > > that me

Re: [Mesa-dev] [PATCH 0/7] gallium, radeonsi: raise number of samplers to 32

On Thu, Apr 7, 2016 at 2:18 AM, Bas Nieuwenhuizen wrote: > Hi Nicolai, > > Patches 1-2 and 5-6 are > > Reviewed-by: Bas Nieuwenhuizen > > However, for increasing the limits there are several cases which still > use signed shifts (i.e. 1 << ...) which is undefined behavior shifting > into bit 31.

Re: [Mesa-dev] [PATCH v2] radeonsi: use guard band clipping

On Thu, Apr 7, 2016 at 3:27 AM, Grigori Goronzy wrote: > With the previous changes to handling of viewport clipping, it is > almost trivial to add proper support for guard band clipping. Select a > suitable integer clipping value to keep inside the rasterizer's guard > band range of [-32768, 3276

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On 07.04.2016 18:01, Marek Olšák wrote: > On Thu, Apr 7, 2016 at 7:32 AM, Ian Romanick wrote: >> Why would you do that? I've NAKed this patch several times. > > You NAKed the previous version of the patch, not this one. I guess > that means NAK for this one too. I'd be interested in a specific

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On Mar 23, 2016 17:13, "Miklós Máté" wrote: > > This fixes premature deallocation on unbind, and introduces > support for deleting GLX drawables while they are current to a context. > > Note that in practice this also introduces a resource leak, because nobody > uses the GLX 1.3 glXDestroyWindow a

Re: [Mesa-dev] [PATCH 7/8] glx: fix the refcounting of dri drawables

On Thu, Apr 7, 2016 at 7:32 AM, Ian Romanick wrote: > Why would you do that? I've NAKed this patch several times. You NAKed the previous version of the patch, not this one. I guess that means NAK for this one too. OK. Marek ___ mesa-dev mailing list m

Re: [Mesa-dev] [PATCH 1/2] gallium: add pipe_depth_state::disable_occlusion_queries

On Thu, Apr 7, 2016 at 3:22 AM, Roland Scheidegger wrote: > Where's the doc bits... > > But aside from that, this doesn't look quite right to me. Doesn't really > feel like depth state (more like context one to suspend queries), and > more importantly it should most likely apply to all queries, no

Re: [Mesa-dev] [PATCH 05/26] nir/types: Add a wrapper for count_attribute_slots

Hi, I pushed this patch to master. We are using it on our vertex_attrib_64bit work, and it is easier to have it on master, as we are rebasing really often. I talked the other day with Rob Clark, and he was ok with pushing if I want. So this is a FYI, so you are aware of the pushing. Thanks BR