Re: [Mesa-dev] [PATCH 0/6] nir: Make the nir_foreach helpers consistent

Patches 1, 4 and 5 need rebasing. Patches 2, 3 and 6 are: Reviewed-by: Eduardo Lima Mitev Thanks for fixing this! it has annoyed me too. Eduardo On 04/27/2016 05:41 AM, Jason Ekstrand wrote: > I think things started out consistent when we first merged NIR since there >

Re: [Mesa-dev] [PATCH] glsl: move uniform block validation to link_uniform_blocks.cpp

Reviewed-by: Eduardo Lima Mitev Thanks! On 04/27/2016 05:20 AM, Timothy Arceri wrote: > --- > src/compiler/glsl/link_uniform_blocks.cpp | 53 > +++ > src/compiler/glsl/link_uniforms.cpp | 53 > --- > 2 files

[Mesa-dev] [PATCH 6/6] nir: Switch the arguments to nir_foreach_def

This matches the "foreach x in container" pattern found in many other programming languages. Generated by the following regular expression: s/nir_foreach_def(\([^,]*\),\s*\([^,]*\))/nir_foreach_def(\2, \1)/ --- src/compiler/nir/nir.h | 4 ++--

[Mesa-dev] [PATCH 3/6] nir: Switch the arguments to nir_foreach_parallel_copy_entry

This matches the "foreach x in container" pattern found in many other programming languages. --- src/compiler/nir/nir.c | 4 ++-- src/compiler/nir/nir.h | 2 +- src/compiler/nir/nir_from_ssa.c | 6 +++--- src/compiler/nir/nir_print.c| 2 +- 4 files changed, 7 insertions(+),

[Mesa-dev] [PATCH 5/6] nir: Switch the arguments to nir_foreach_use and friends

This matches the "foreach x in container" pattern found in many other programming languages. Generated by the following regular expression: s/nir_foreach_use(\([^,]*\),\s*\([^,]*\))/nir_foreach_use(\2, \1)/ and similar expressions for nir_foreach_use_safe, etc. --- src/compiler/nir/nir.c

[Mesa-dev] [PATCH 1/6] nir: Switch the arguments to nir_foreach_instr

This matches the "foreach x in container" pattern found in many other programming languages. Generated by the following regular expression: s/nir_foreach_instr(\([^,]*\),\s*\([^,]*\))/nir_foreach_instr(\2, \1)/ and similar expressions for nir_foreach_instr_safe etc. --- src/compiler/nir/nir.c

[Mesa-dev] [PATCH 2/6] nir: Switch the arguments to nir_foreach_phi_src

This matches the "foreach x in container" pattern found in many other programming languages. Generated by the following regular expression: s/nir_foreach_phi_src(\([^,]*\),\s*\([^,]*\))/nir_foreach_phi_src(\2, \1)/ and a similar expression for nir_foreach_phi_src_safe. ---

[Mesa-dev] [PATCH 4/6] nir: Switch the arguments to nir_foreach_function

This matches the "foreach x in container" pattern found in many other programming languages. Generated by the following regular expression: s/nir_foreach_function(\([^,]*\),\s*\([^,]*\))/nir_foreach_function(\2, \1)/ --- src/compiler/nir/nir.h | 2 +-

[Mesa-dev] [PATCH 0/6] nir: Make the nir_foreach helpers consistent

I think things started out consistent when we first merged NIR since there weren't a lot of helpers. Over time, however, more nir_foreach helpers have been added and they haven't had a consistent argument order. This has been annoying me for a while ("Which way does this one work again?") and

[Mesa-dev] [PATCH] glsl: move uniform block validation to link_uniform_blocks.cpp

--- src/compiler/glsl/link_uniform_blocks.cpp | 53 +++ src/compiler/glsl/link_uniforms.cpp | 53 --- 2 files changed, 53 insertions(+), 53 deletions(-) diff --git a/src/compiler/glsl/link_uniform_blocks.cpp

Re: [Mesa-dev] [PATCH piglit v2] Test that glShaderSource does not change compile status.

On Tuesday, April 26, 2016 1:08:02 PM PDT Jamey Sharp wrote: > OpenGL 4.5 Core Profile section 7.1, in the documentation for > CompileShader, says: "Changing the source code of a shader object with > ShaderSource does not change its compile status or the compiled shader > code." (I haven't checked

Re: [Mesa-dev] [PATCH] glShaderSource must not change compile status.

On Monday, April 25, 2016 10:06:40 PM PDT Jamey Sharp wrote: > OpenGL 4.5 Core Profile section 7.1, in the documentation for > CompileShader, says: "Changing the source code of a shader object with > ShaderSource does not change its compile status or the compiled shader > code." (I haven't checked

Re: [Mesa-dev] [PATCH] vbo: Return INVALID_OPERATION during draw with a mapped buffer

On Monday, April 25, 2016 5:54:28 PM PDT Jordan Justen wrote: > Fixes the OpenGLES 3.1 CTS: > * ESEXT-CTS.draw_elements_base_vertex_tests.invalid_mapped_bos > > Because this is triggering the error message after the normal API > validation phase, we don't have the API function name available,

Re: [Mesa-dev] [PATCH] vbo: Return INVALID_OPERATION during draw with a mapped buffer

On Monday, April 25, 2016 5:54:28 PM PDT Jordan Justen wrote: > Fixes the OpenGLES 3.1 CTS: > * ESEXT-CTS.draw_elements_base_vertex_tests.invalid_mapped_bos > > Because this is triggering the error message after the normal API > validation phase, we don't have the API function name available,

Re: [Mesa-dev] [PATCH 7/7] softpipe: add support for compute shaders.

Am 27.04.2016 um 03:05 schrieb Dave Airlie: > On 27 April 2016 at 11:00, Dave Airlie wrote: So far I've set the execmask to 1 active channel, I'm contemplating changing that though and using less machines. >>> Ah yes, I think that would indeed be desirable. >> >>

Re: [Mesa-dev] [PATCH v2] glsl: fix lowering outputs for early/nested returns

Thanks again, I will make/modify those piglit tests. Regards, Lars Hamre On Tue, Apr 26, 2016 at 9:20 PM, Timothy Arceri wrote: > On Tue, 2016-04-26 at 19:50 -0400, Lars Hamre wrote: >> v2: limit lowerings to return statments in main() >> >> Return statements in

Re: [Mesa-dev] [PATCH v2] glsl: fix lowering outputs for early/nested returns

On Tue, 2016-04-26 at 19:50 -0400, Lars Hamre wrote: > v2: limit lowerings to return statments in main() > > Return statements in conditional blocks were not having their > output varyings lowered correctly. > > This patch fixes the following piglit tests: >

Re: [Mesa-dev] [PATCH] anv/formats: Return proper error code for unsupported formats

Good catch! Reviewed-by: Jason Ekstrand Why does it cause an assert? On Tue, Apr 26, 2016 at 3:35 PM, Nanley Chery wrote: > From: Nanley Chery > > Fixes some failures in dEQP-VK.api.info.image_format_properties.* and >

Re: [Mesa-dev] [PATCH 7/7] softpipe: add support for compute shaders.

On 27 April 2016 at 11:00, Dave Airlie wrote: >>> So far I've set the execmask to 1 active channel, I'm contemplating >>> changing that >>> though and using less machines. >> Ah yes, I think that would indeed be desirable. > > I'll look into it, though it's not that trivial,

Re: [Mesa-dev] [PATCH 7/7] softpipe: add support for compute shaders.

>> So far I've set the execmask to 1 active channel, I'm contemplating >> changing that >> though and using less machines. > Ah yes, I think that would indeed be desirable. I'll look into it, though it's not that trivial, since you might have a 1x20x1 layout, also having to make sure each thread

[Mesa-dev] [PATCH v2] glsl: fix lowering outputs for early/nested returns

v2: limit lowerings to return statments in main() Return statements in conditional blocks were not having their output varyings lowered correctly. This patch fixes the following piglit tests: /spec/glsl-1.10/execution/vs-float-main-return /spec/glsl-1.10/execution/vs-vec2-main-return

[Mesa-dev] [PATCH] i965: Fix the render ring prelude on Gen4-5.

My intention was to have the render ring prelude occur at the first point where we start emiting render commands into a batch. Gen4-5 have a single ring that handles both BLT and 3D commands, so it's possible to have a BLT -> RENDER transition in the middle of a batch (not just at the start when

Re: [Mesa-dev] [PATCH 7/7] softpipe: add support for compute shaders.

Am 26.04.2016 um 23:18 schrieb Dave Airlie: > On 27 April 2016 at 06:07, Roland Scheidegger wrote: >> Am 26.04.2016 um 06:42 schrieb Dave Airlie: >>> From: Dave Airlie >>> >>> This enables ARB_compute_shader on softpipe. I've only >>> tested this with

[Mesa-dev] [PATCH] anv/formats: Return proper error code for unsupported formats

From: Nanley Chery Fixes some failures in dEQP-VK.api.info.image_format_properties.* and enables the test group to execute without assert failing. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94896 Signed-off-by: Nanley Chery ---

Re: [Mesa-dev] [PATCH 1/6] nir/algebraic: Do better error reporting of bad expressions

Quoting Jason Ekstrand (2016-04-26 14:31:10) > > > On Tue, Apr 26, 2016 at 12:47 PM, Dylan Baker wrote: > > Quoting Jason Ekstrand (2016-04-25 21:39:19) > > Previously, if an exception was encountered anywhere, nir_algebraic > would > > just die in a fire

[Mesa-dev] [PATCH 2/2] softpipe: bump 3D texture limit to 2048

From: Dave Airlie The GL4.1 spec bumps this to 2048, so we should do so. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_limits.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_limits.h

[Mesa-dev] [PATCH 1/2] softpipe: allow r32 xchg on shader images.

From: Dave Airlie This is part of OES_shader_image_atomic.txt. Signed-off-by: Dave Airlie --- src/gallium/drivers/softpipe/sp_image.c | 40 + 1 file changed, 40 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] swr: autogenerate swr_context_llvm.h

Reviewed-by: Bruce Cherniak , with addition of .gitignore on commit. -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Tim Rowley Sent: Tuesday, April 26, 2016 11:55 AM To: mesa-dev@lists.freedesktop.org Subject:

[Mesa-dev] [Bug 95159] Cannot build EGL without x11 headers after interop patchset

https://bugs.freedesktop.org/show_bug.cgi?id=95159 --- Comment #1 from Youry --- Created attachment 123283 --> https://bugs.freedesktop.org/attachment.cgi?id=123283=edit Patch -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

[Mesa-dev] [Bug 95159] Cannot build EGL without x11 headers after interop patchset

https://bugs.freedesktop.org/show_bug.cgi?id=95159 Bug ID: 95159 Summary: Cannot build EGL without x11 headers after interop patchset Product: Mesa Version: git Hardware: ARM OS: Linux (All)

Re: [Mesa-dev] [PATCH 1/6] nir/algebraic: Do better error reporting of bad expressions

On Tue, Apr 26, 2016 at 12:47 PM, Dylan Baker wrote: > Quoting Jason Ekstrand (2016-04-25 21:39:19) > > Previously, if an exception was encountered anywhere, nir_algebraic would > > just die in a fire with no indication whatsoever as to where the actual > bug > > is.

Re: [Mesa-dev] [PATCH 00/47] nir: rewrite nir_foreach_block() and friends

On Tue, Apr 26, 2016 at 12:27 PM, Jason Ekstrand wrote: > Status update: > > I've rebased on master, applied my own review comments and couple of bugs > and pushed it here: > > > https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/nir-foreach-block-v3 > > Changes over

Re: [Mesa-dev] [PATCH 7/7] softpipe: add support for compute shaders.

On 27 April 2016 at 06:07, Roland Scheidegger wrote: > Am 26.04.2016 um 06:42 schrieb Dave Airlie: >> From: Dave Airlie >> >> This enables ARB_compute_shader on softpipe. I've only >> tested this with piglit so far, and I hopefully plan >> on integrating

Re: [Mesa-dev] [PATCH 4/4] i965: Enable ARB_texture_stencil8 and OES_texture_stencil8 on Gen8+.

Series is: Reviewed-by: Chris Forbes On Wed, Apr 27, 2016 at 3:33 AM, Thomas Helland wrote: > I guess you should also update GL4.4 section in GL3.txt. > And add the extension to the release notes. > Either a follow up patch or squashed into this

Re: [Mesa-dev] [PATCH] anv: honor DESTDIR when installing icd file

On Sun 17 Apr 2016, Laurent Carlier wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=94969 > --- > src/intel/vulkan/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for the fix. I pushed this to master with my r-b. ___

Re: [Mesa-dev] [PATCH 0/2] two super simple patches

On Sun 17 Apr 2016, Eduardo Lima Mitev wrote: > Both patches are: > > Reviewed-by: Eduardo Lima Mitev > > Thanks! > Eduardo > > On 04/16/2016 09:26 PM, Juha-Pekka Heikkila wrote: > > These are just fixes for error paths. > > > > Juha-Pekka Heikkila (2): > > meta: Avoid

Re: [Mesa-dev] [PATCH] mesa: add tags file to gitignore

On Sat 16 Apr 2016, Grazvydas Ignotas wrote: > For ctags users like me. > > Signed-off-by: Grazvydas Ignotas > --- > I have no commit access, if this patch is ok, please someone push. Hi Grazvydas, I just pushed your patch. ___

[Mesa-dev] [PATCH piglit v2] Test that glShaderSource does not change compile status.

OpenGL 4.5 Core Profile section 7.1, in the documentation for CompileShader, says: "Changing the source code of a shader object with ShaderSource does not change its compile status or the compiled shader code." (I haven't checked older versions of the spec.) This test creates a shader, compiles

Re: [Mesa-dev] [PATCH 7/7] softpipe: add support for compute shaders.

Am 26.04.2016 um 06:42 schrieb Dave Airlie: > From: Dave Airlie > > This enables ARB_compute_shader on softpipe. I've only > tested this with piglit so far, and I hopefully plan > on integrating it with my vulkan work. I'll get to > testing it with deqp more later. > > The

Re: [Mesa-dev] [PATCH 1/6] nir/algebraic: Do better error reporting of bad expressions

Quoting Jason Ekstrand (2016-04-25 21:39:19) > Previously, if an exception was encountered anywhere, nir_algebraic would > just die in a fire with no indication whatsoever as to where the actual bug > is. This commit makes it print out the particular search-and-replace > expression that is

Re: [Mesa-dev] OpenCL max VRAM setting

Hi Bo, I am not aware of any environment variables that do that. However you can change the limit in the source code. You can change the single allocation size limit in src/gallium/drivers/radeon/r600_pipe_common.c where max_mem_alloc_size is set to 256MiB. You can change that, and then the

[Mesa-dev] [Bug 95036] make check egl-symbols-check regression

https://bugs.freedesktop.org/show_bug.cgi?id=95036 Marek Olšák changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] OpenCL max VRAM setting

Hi all, First time poster here. Is there any way I can change global memory size and max allocable memory size for an OpenCL program? My card has 4GB or VRAM, but seems like I can only use a quarter of it for OCL, and I can only use a quarter of the quarter for a single block of allocation. Is

Re: [Mesa-dev] [PATCH 00/47] nir: rewrite nir_foreach_block() and friends

Status update: I've rebased on master, applied my own review comments and couple of bugs and pushed it here: https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/nir-foreach-block-v3 Changes over what Connor sent: 1) Minor cosmetic changes to the iteration helper functions 2) Fixed a bug

[Mesa-dev] [Bug 95036] make check egl-symbols-check regression

https://bugs.freedesktop.org/show_bug.cgi?id=95036 Jose Fonseca changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |mar...@gmail.com

Re: [Mesa-dev] [PATCH] glx: Don't enclose includes inside `extern "C" { }`.

On 04/26/2016 12:55 PM, Jose Fonseca wrote: Ran `make check` inside src/glx to verify everything compiles and links correctly. https://bugs.freedesktop.org/show_bug.cgi?id=95158 --- src/glx/dri2_priv.h | 8 src/glx/glx_error.h

[Mesa-dev] [PATCH] glx: Don't enclose includes inside `extern "C" { }`.

Ran `make check` inside src/glx to verify everything compiles and links correctly. https://bugs.freedesktop.org/show_bug.cgi?id=95158 --- src/glx/dri2_priv.h | 8 src/glx/glx_error.h | 8

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #22 from Roland Scheidegger --- (In reply to David Lonie from comment #21) > > I wonder what the test expects, I haven't seen anything but NaN coords with > > that sampler ;-). That can't have possibly given

Re: [Mesa-dev] [PATCH 2/2] gk110/ir: add emission for (a OP b) OP c

On 04/26/2016 07:19 PM, Ilia Mirkin wrote: Presumably this should also be CC'd to stable? I don't know when we'd emit something like that, but presumably it can happen. Well, it's only used by the lowering pass for surfaces, so I'm not sure if it's really required to backport it because

Re: [Mesa-dev] [PATCH 2/2] gk110/ir: add emission for (a OP b) OP c

Presumably this should also be CC'd to stable? I don't know when we'd emit something like that, but presumably it can happen. Does the GM107 emitter handle this case? In any case, this series is Reviewed-by: Ilia Mirkin On Tue, Apr 26, 2016 at 1:11 PM, Samuel Pitoiset

[Mesa-dev] [Bug 94994] OSMesaGetProcAdress always fails on mangled OSMesa

https://bugs.freedesktop.org/show_bug.cgi?id=94994 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH 1/2] nvc0/ir: fix wrong emission of (a OP b) OP c

The third source must be emitted at offset 49 instead of 17 and the not modifier is at 52 instead of 20. If you look a bit above in emitLogicOp() you will see that the dest is emitted at 17 which confirms that src(2) is obviously wrong. Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH 2/2] gk110/ir: add emission for (a OP b) OP c

This is pretty similar to NVC0 except that offsets have changed. Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 26 ++ 1 file changed, 26 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] swr: autogenerate swr_context_llvm.h

Could I put in a good word for adding it to .gitignore as well? On Tue, Apr 26, 2016 at 12:55 PM, Tim Rowley wrote: > --- > src/gallium/drivers/swr/Makefile.am| 7 ++ > src/gallium/drivers/swr/Makefile.sources | 1 - >

Re: [Mesa-dev] [PATCH v3 10/24] nv50/ir: re-introduce TGSI lowering pass for images

Reviewed-by: Ilia Mirkin On Tue, Apr 26, 2016 at 12:52 PM, Samuel Pitoiset wrote: > This is loosely based on the previous lowering pass wrote by calim > four years ago. I did clean the code and fixed some issues. > > v3: use getDst(0) for STORE

Re: [Mesa-dev] [PATCH v3 18/24] nvc0/ir: add indirect support for images on Kepler

Reviewed-by: Ilia Mirkin On Tue, Apr 26, 2016 at 12:53 PM, Samuel Pitoiset wrote: > This fixes arb_shader_image_load_store-indexing and > arb_shader_image_load_store-max-images. > > v2: - do not set r to 0xff that's just useless > - use an

[Mesa-dev] [PATCH] swr: autogenerate swr_context_llvm.h

--- src/gallium/drivers/swr/Makefile.am| 7 ++ src/gallium/drivers/swr/Makefile.sources | 1 - .../rasterizer/jitter/scripts/gen_llvm_types.py| 3 + src/gallium/drivers/swr/swr_context.h | 8 +- src/gallium/drivers/swr/swr_context_llvm.h

[Mesa-dev] [PATCH v3 18/24] nvc0/ir: add indirect support for images on Kepler

This fixes arb_shader_image_load_store-indexing and arb_shader_image_load_store-max-images. v2: - do not set r to 0xff that's just useless - use an assert to make sure tex.r == 0 Signed-off-by: Samuel Pitoiset Reviewed-by: Ilia Mirkin (v1)

[Mesa-dev] [PATCH v3 10/24] nv50/ir: re-introduce TGSI lowering pass for images

This is loosely based on the previous lowering pass wrote by calim four years ago. I did clean the code and fixed some issues. v3: use getDst(0) for STORE indirect accesses v2: drop .raw code which is unused for now Signed-off-by: Samuel Pitoiset ---

Re: [Mesa-dev] [PATCH v2 18/24] nvc0/ir: add indirect support for images on Kepler

On 04/26/2016 03:22 AM, Ilia Mirkin wrote: On Mon, Apr 25, 2016 at 4:15 PM, Samuel Pitoiset wrote: This fixes arb_shader_image_load_store-indexing and arb_shader_image_load_store-max-images. Signed-off-by: Samuel Pitoiset Reviewed-by:

Re: [Mesa-dev] [PATCH 0/6] nir: Implement a load-combine pass

Hi, Any chance to get this looked at? Thanks! Eduardo On 04/14/2016 06:52 PM, Eduardo Lima Mitev wrote: > Hi, > > This is a series adding a new NIR pass that will combine redundant SSBO, > shared variable and image load instructions. It is based on a previous series > that Iago Toral [1]

Re: [Mesa-dev] [PATCH v2 22/24] nvc0: inform users that 3D images are not fully supported

On 04/26/2016 03:28 AM, Ilia Mirkin wrote: On Mon, Apr 25, 2016 at 4:15 PM, Samuel Pitoiset wrote: 3D images are a bit more complicated to implement and will probably requires a bunch of headaches and we don't care for now because they do not seem to be really used

Re: [Mesa-dev] [PATCH v2 14/24] nv50/ir: make use of OP_SUQ for surfaces query

On 04/26/2016 03:17 AM, Ilia Mirkin wrote: On Mon, Apr 25, 2016 at 4:15 PM, Samuel Pitoiset wrote: This implements RESQ for surfaces which comes from imageSize() GLSL bultin. As the dimensions are sticked into the driver constant buffer, this only has to be lowered

Re: [Mesa-dev] [PATCH v2 10/24] nv50/ir: re-introduce TGSI lowering pass for images

On 04/26/2016 03:13 AM, Ilia Mirkin wrote: On Mon, Apr 25, 2016 at 4:14 PM, Samuel Pitoiset wrote: This is loosely based on the previous lowering pass wrote by calim four years ago. I did clean the code and fixed some issues. v2: drop .raw code which is unused for

Re: [Mesa-dev] [PATCH v2 03/24] nvc0: bind images on compute shaders for Kepler

On 04/26/2016 03:08 AM, Ilia Mirkin wrote: On Mon, Apr 25, 2016 at 4:14 PM, Samuel Pitoiset wrote: Old surfaces validation code will be removed once images are completely done for Fermi/Kepler, that explains why I only disable it for now. This also introduces

Re: [Mesa-dev] [PATCH 4/4] i965: Enable ARB_texture_stencil8 and OES_texture_stencil8 on Gen8+.

I guess you should also update GL4.4 section in GL3.txt. And add the extension to the release notes. Either a follow up patch or squashed into this one is fine with me. Regards, Thomas On Apr 26, 2016 12:25, "Kenneth Graunke" wrote: > > Stencil texturing is required by ES

[Mesa-dev] [PATCH] st/glsl_to_tgsi: reduce stack explosion in recursive expression visitor

From: Nicolai Hähnle In optimized builds, visit(ir_expression *) experiences inlining with gcc that leads the function to have a roughly 32KB stack frame. This is a problem given that the function is called recursively. In non-optimized builds, the stack frame is much

Re: [Mesa-dev] [PATCH] tgsi: move to using vector for system values.

On 04/25/2016 05:49 PM, Dave Airlie wrote: From: Dave Airlie For compute support some of the system values are .xyz types, so move to using a vector instead of a single channel. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/draw/draw_gs.c

Re: [Mesa-dev] [PATCH] tgsi/exec: fix system value handling.

On 04/25/2016 09:06 PM, Dave Airlie wrote: From: Dave Airlie a) SysSemanticToIndex needs to be indexed with the semantic name not the decl->Declaration.Semantic. b) doing this in run is too late, as the mappings are all setup prior to run in the execs. This fixes

Re: [Mesa-dev] [PATCH 5/7] tgsi/exec: implement restartable machine.

On 04/25/2016 10:42 PM, Dave Airlie wrote: From: Dave Airlie This lets us restart the machine at a PC value, and exits the machine when we hit a barrier. Compute shaders will then execute all the threads up to the barrier, then restart the machines after the barrier once

Re: [Mesa-dev] [PATCH 2/4] mesa: Disallow CopyTexSubImage on stencil formats in ES.

On 04/26/2016 04:25 AM, Kenneth Graunke wrote: Fixes - ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8 - ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8_multisample Signed-off-by: Kenneth Graunke --- src/mesa/main/teximage.c | 9 + 1 file

[Mesa-dev] [Bug 94955] Uninitialized variables leads to random segfaults (valgrind log, apitrace attached)

https://bugs.freedesktop.org/show_bug.cgi?id=94955 --- Comment #21 from David Lonie --- Thanks for the fix! > Comment # 20 on bug 94955 from Roland Scheidegger > (In reply to Bruce Cherniak from comment #19) > > Thanks Roland!  You patch fixes the segv I get when

Re: [Mesa-dev] gallium r300 driver for PowerPC

I have done some more debugging and I do have a question. The clearest, repeatable issue I am seeing is when I run glxgears in apitrace. The crash always occrs at GLXChooseVisual. It returns NULL and from the documentation this means that it is encountering an undefined attribute. I see this when

Re: [Mesa-dev] [PATCH 0/6] nir/algebraic: bit size improvements

Patches 1-5 are: Reviewed-by: Iago Toral Quiroga I'll have a look at patch 6 tomorrow. On Mon, 2016-04-25 at 21:39 -0700, Jason Ekstrand wrote: > This little series makes some bit size improvements to nir_algebraic. In > particular, it adds a mechanism that allows you to

Re: [Mesa-dev] [PATCH 8/9] i965: Implement ARB_query_buffer_object for HSW+

On 04/22/2016 07:18 AM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/drivers/dri/i965/Makefile.sources | 1 + > src/mesa/drivers/dri/i965/brw_context.c | 4 +- > src/mesa/drivers/dri/i965/brw_context.h | 5 + >

Re: [Mesa-dev] [PATCH] radeonsi: fix build error because of missing param

On Tue, Apr 26, 2016 at 6:48 AM, Oded Gabbay wrote: > Signed-off-by: Oded Gabbay > Cc: "11.1 11.2" Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_state.c | 2 +- >

[Mesa-dev] [PATCH v2] glsl: do not raise uninitialized warning with in/inout function parameters

It silence by default warnings with function parameters, as the parameters need to be processed in order to have the actual and the formal parameter, and the function signature. Then it raises the warning if needed at verify_parameter_modes where other in/inout modes checks are done. v2: fix

[Mesa-dev] [PATCH v2] glsl: add a empty set_is_lhs on ast_node

Just to allow to call set_is_lhs on any ast_node without a casting. Useful when processing a ast_node list that we know it contain ast_expression. v2: comment out new_value to avoid unused parameter warning (Ian Romanick) --- src/compiler/glsl/ast.h | 2 ++

Re: [Mesa-dev] [PATCH] glShaderSource must not change compile status.

On Tue, 2016-04-26 at 13:49 +0200, Ian Romanick wrote: > On 04/26/2016 12:57 PM, Timothy Arceri wrote: > > > > On Tue, 2016-04-26 at 09:29 +0200, Ian Romanick wrote: > > > > > > On 04/26/2016 07:06 AM, Jamey Sharp wrote: > > > > > > > > > > > > OpenGL 4.5 Core Profile section 7.1, in the

Re: [Mesa-dev] [PATCH 0/2] glsl: solve "uninitialized variable" warning false positive with function parameters

On 26/04/16 14:00, Ian Romanick wrote: > Other than the formatting nits in patch 2, I think this series is fine. Thanks for the feedback. I will update the patches and send a v2 soon. > One nagging problem... we don't have any way to test this, and, as a > result, none of it is tested. Can we

Re: [Mesa-dev] [PATCH 0/2] glsl: solve "uninitialized variable" warning false positive with function parameters

Other than the formatting nits in patch 2, I think this series is fine. One nagging problem... we don't have any way to test this, and, as a result, none of it is tested. Can we fix that? There are 'make check' tests in the Mesa tree for the preprocessor. Could we hook up something like that

Re: [Mesa-dev] [PATCH 2/2] glsl: do not raise uninitialized warning with in/inout function parameters

On 04/19/2016 07:48 PM, Alejandro Piñeiro wrote: > It silence by default warnings with function parameters, as the > parameters need to be processed in order to have the actual and the > formal parameter, and the function signature. Then it raises the > warning if needed at verify_parameter_modes

Re: [Mesa-dev] [PATCH 1/2] glsl: add a empty set_is_lhs on ast_node

On 04/19/2016 07:48 PM, Alejandro Piñeiro wrote: > Just to allow to call set_is_lhs on any ast_node without a casting. Useful > when processing a ast_node list that we know it contain ast_expression. > --- > > Worth to note that ast_node has other dummy implementations, like > ast_node::hir. > >

Re: [Mesa-dev] [PATCH] glShaderSource must not change compile status.

On 04/26/2016 12:57 PM, Timothy Arceri wrote: > On Tue, 2016-04-26 at 09:29 +0200, Ian Romanick wrote: >> On 04/26/2016 07:06 AM, Jamey Sharp wrote: >>> >>> OpenGL 4.5 Core Profile section 7.1, in the documentation for >>> CompileShader, says: "Changing the source code of a shader object >>> with

Re: [Mesa-dev] [PATCH 1/4] i965: Fix MapTextureImage for multi-slice/level stencil buffers.

Series is Reviewed-by: Ian Romanick The hack you remove in patch 4 always bothered me. Good riddance! On 04/26/2016 12:25 PM, Kenneth Graunke wrote: > We called intel_miptree_get_image_offset() to get the image offsets > for the current level/slice, but then

Re: [Mesa-dev] [PATCH 0/2] glsl: solve "uninitialized variable" warning false positive with function parameters

Gentle after-one-week ping. On 19/04/16 19:48, Alejandro Piñeiro wrote: > This series solves the false positive that Ilia found recently. > > On the thread I mention that my preferred option would be try to set > is_lhs before processing the function parameters on a pass similar to >

Re: [Mesa-dev] [PATCH v4 0/4] Fix OpenGL 1.3 big-endian support in r600g

Oded Gabbay wrote: On Tue, Apr 26, 2016 at 1:26 PM, Andy Furniss wrote: Oded Gabbay wrote: Oded Gabbay (4): r600g/radeonsi: send endian info to format translation functions r600g: set endianess of 16/32-bit buffers according to do_endian_swap r600g: use do_endian_swap in

Re: [Mesa-dev] [PATCH] glShaderSource must not change compile status.

On Tue, 2016-04-26 at 09:29 +0200, Ian Romanick wrote: > On 04/26/2016 07:06 AM, Jamey Sharp wrote: > > > > OpenGL 4.5 Core Profile section 7.1, in the documentation for > > CompileShader, says: "Changing the source code of a shader object > > with > > ShaderSource does not change its compile

Re: [Mesa-dev] [PATCH v4 0/4] Fix OpenGL 1.3 big-endian support in r600g

On Tue, Apr 26, 2016 at 1:26 PM, Andy Furniss wrote: > Oded Gabbay wrote: > >> Oded Gabbay (4): r600g/radeonsi: send endian info to format >> translation functions r600g: set endianess of 16/32-bit buffers >> according to do_endian_swap r600g: use do_endian_swap in color >>

[Mesa-dev] [PATCH] radeonsi: fix build error because of missing param

Signed-off-by: Oded Gabbay Cc: "11.1 11.2" --- src/gallium/drivers/radeonsi/si_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/x11: authenticate before doing chipset id ioctls

> From: Matt Turner > Date: Mon, 25 Apr 2016 14:37:56 -0700 > > On Tue, Apr 19, 2016 at 10:48 AM, Emil Velikov > wrote: > > On 19 April 2016 at 03:29, Jonathan Gray wrote: > >> For systems without udev or sysfs that use drm ioctls

Re: [Mesa-dev] [PATCH v4 0/4] Fix OpenGL 1.3 big-endian support in r600g

Oded Gabbay wrote: Oded Gabbay (4): r600g/radeonsi: send endian info to format translation functions r600g: set endianess of 16/32-bit buffers according to do_endian_swap r600g: use do_endian_swap in color swapping functions r600g: use do_endian_swap in texture swapping function I get a build

[Mesa-dev] [PATCH 4/4] i965: Enable ARB_texture_stencil8 and OES_texture_stencil8 on Gen8+.

Stencil texturing is required by ES 3.1. Apparently we never actually turned it on. Do that now. Also turn on the desktop extension. Fixes nine dEQP-GLES31.functional tests: stencil_texturing.format.stencil_index8_2d texture.border_clamp.formats.stencil_index8.nearest_size_pot

[Mesa-dev] [PATCH 3/4] mesa: Try to fix CopyTex[Sub]Image of stencil textures.

ES prohibits this, but GL appears to allow it. We at least need this much, or else we'll crash as there's no source to read from. This fixed crashes in the ES tests before I realized I needed to prohibit stencil instead. Signed-off-by: Kenneth Graunke ---

[Mesa-dev] [PATCH 1/4] i965: Fix MapTextureImage for multi-slice/level stencil buffers.

We called intel_miptree_get_image_offset() to get the image offsets for the current level/slice, but then proceeded to ignore the results and clobber level/slice 0 every time. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94713 Signed-off-by: Kenneth Graunke ---

[Mesa-dev] [PATCH 2/4] mesa: Disallow CopyTexSubImage on stencil formats in ES.

Fixes - ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8 - ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8_multisample Signed-off-by: Kenneth Graunke --- src/mesa/main/teximage.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 2/6] nir/algebraic: Use "uint" instead of "unsigned" for uint types

Reviewed-by: Samuel Iglesias Gonsálvez On 26/04/16 06:39, Jason Ekstrand wrote: > This is consistent with the rename done for the rest of NIR. Currently, > "bool" is the only type specifier used in nir_opt_algebraic.py so this is > really a no-op. > --- >

Re: [Mesa-dev] [PATCH 5/6] nir/opt_algebraic: Fix some expressions with ambiguous bit sizes

Reviewed-by: Samuel Iglesias Gonsálvez On 26/04/16 06:39, Jason Ekstrand wrote: > --- > src/compiler/nir/nir_opt_algebraic.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/compiler/nir/nir_opt_algebraic.py >

Re: [Mesa-dev] [PATCH 4/6] nir/search: Respect the bit_size parameter on nir_search_value

On 26/04/16 06:39, Jason Ekstrand wrote: > --- > src/compiler/nir/nir_opt_algebraic.py | 5 - > src/compiler/nir/nir_search.c | 14 ++ > 2 files changed, 18 insertions(+), 1 deletion(-) > > diff --git a/src/compiler/nir/nir_opt_algebraic.py >

Re: [Mesa-dev] [PATCH] glsl: Checks for interpolation into its own function.

On 04/04/16 18:50, Andres Gomez wrote: > This generalizes the validation also to be done for variables inside > interface blocks, which, for some cases, was missing. > > For a discussion about the additional validation cases included see >

  1   2   >