[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #20 from kilobug --- I just tried with latest Mesash->CompileStatus = GL_FALSE; -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #21 from kilobug --- (In reply to kilobug from comment #20) > I just tried with latest Mesash->CompileStatus = GL_FALSE; Hrm sorry didn't finish my comment, sorry for the noise :/ So, I just tried with latest Mesa from Oibaf's PPA o

Re: [Mesa-dev] [PATCH 27/59] i965/fs: add a stride helper

On Wed, 2016-05-04 at 13:59 -0700, Francisco Jerez wrote: > Iago Toral writes: > > > On Wed, 2016-05-04 at 01:15 -0700, Francisco Jerez wrote: > >> Iago Toral writes: > >> > >> > On Mon, 2016-05-02 at 18:48 -0700, Francisco Jerez wrote: > >> >> Samuel Iglesias Gonsálvez writes: > >> >> > >> >

Re: [Mesa-dev] [PATCH 27/59] i965/fs: add a stride helper

On Thu, 2016-05-05 at 09:15 +0200, Iago Toral wrote: > On Wed, 2016-05-04 at 13:59 -0700, Francisco Jerez wrote: > > Iago Toral writes: > > > > > On Wed, 2016-05-04 at 01:15 -0700, Francisco Jerez wrote: > > >> Iago Toral writes: > > >> > > >> > On Mon, 2016-05-02 at 18:48 -0700, Francisco Jere

Re: [Mesa-dev] [PATCH 2/2] mesa/compute: drop pointless casts.

LGTM: Reviewed-by: Alejandro Piñeiro On 05/05/16 02:41, Dave Airlie wrote: > From: Dave Airlie > > We already are a GLintptr, casting won't help. > > Signed-off-by: Dave Airlie > --- > src/mesa/main/api_validate.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/

Re: [Mesa-dev] [PATCH 1/2] mesa/compute: move compute checks around for tests.

So as far as I understand, on that test there is no active program and indirect length is wrong, and fails because it was expecting the second error. Is that right? Unless Im wrong, when the OpenGL spec specifies the Error cases, it doesn't specify any kind of priority (which error should be raise

Re: [Mesa-dev] [PATCH v2] nir: fix assert for wildcard pairs

On 05/05/2016 04:37 AM, Thomas H.P. Andersen wrote: > > > On Wed, May 4, 2016 at 7:46 AM, Eduardo Lima Mitev > wrote: > > Good catch! > > Reviewed-by: Eduardo Lima Mitev > > > > Thanks! I do not have commit access. Can I ask you

Re: [Mesa-dev] [PATCH] mesa/ubo: add missing compute cases for ubo/atomic buffers

On Wed, May 4, 2016 at 8:12 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes: GL43-CTS.compute_shader.resource-ubo > > Signed-off-by: Dave Airlie > --- > src/mesa/main/uniforms.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uni

Re: [Mesa-dev] [PATCH 2/2] mesa/compute: drop pointless casts.

On Wed, May 4, 2016 at 5:41 PM, Dave Airlie wrote: > From: Dave Airlie > > We already are a GLintptr, casting won't help. > > Signed-off-by: Dave Airlie > --- > src/mesa/main/api_validate.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/main/api_validate

[Mesa-dev] [PATCH 1/2] mesa/main: add a comment to clarify INTERNALFORMAT_PREFERRED

The comment clarifies that the driver is called only to try to get a preferred internalformat, and that it was already checked if the format is supported or not. --- src/mesa/main/formatquery.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/formatquery.c b/sr

[Mesa-dev] [PATCH 2/2] i965/formatquery: remove INTERNALFORMAT_PREFERRED implementation

Right now the implementation only checks if the internalformat is supported or not. But that implementation is wrong, returning unsupported for some internalformats. Additionally, checking if the internalformat is supported or not is already done at mesa/main before calling the driver hook, so this

Re: [Mesa-dev] [PATCH 01/13] i965: Add a dependency on libisl

On Fri, Apr 22, 2016 at 11:19:04AM -0700, Chad Versace wrote: > On 04/22/2016 10:50 AM, Jason Ekstrand wrote: > > > > > > On Fri, Apr 22, 2016 at 10:15 AM, Jonathan Gray > > wrote: > > > > On Fri, Apr 22, 2016 at 05:31:29PM +0100, Emil Velikov wrote: > >> On 22 April 2016

[Mesa-dev] [PATCH] i965: Only enable ARB_query_buffer_object for newer kernels on Haswell.

On Haswell, we need version 6 of the kernel command parser in order to write the math registers. Our implementation of ARB_query_buffer_object heavily relies on MI_MATH, so we should only advertise it when MI_MATH is available. We're going to want to use MI_MATH in more places in the future. To m

Re: [Mesa-dev] [PATCH 06/23] i965/fs: fix copy/constant propagation regioning checks

On Tue, 2016-05-03 at 17:28 -0700, Jordan Justen wrote: > On 2016-05-03 05:21:55, Samuel Iglesias Gonsálvez wrote: > > From: Iago Toral Quiroga > > > > We were not accounting for reg_suboffset in the check for the start > > of the region. This meant that would allow copy-propagation even if > > t

[Mesa-dev] [PATCH 1/3] glsl: Apply memory qualifiers to vars inside named block interfaces

This is missing and memory qualifiers are currently being ignored for SSBOs. --- src/compiler/glsl/ast_to_hir.cpp | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index c5cd48f..5a1fc9f 1

[Mesa-dev] [PATCH 3/3] nir: Put nir_variable's memory qualifiers in its own struct

ARB_shader_storage_buffer_object allows for memory qualifiers defined for ARB_shader_image_load_store, to be applied to SSBOs using the same semantics. So, for clarity, we might want to take these qualifiers out into its own category, rather than putting them inside the 'image' specific struct. I

[Mesa-dev] [PATCH 2/3] nir/print: Print memory qualifiers in a variable declaration

--- src/compiler/nir/nir_print.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c index 9a77faf..a36561e 100644 --- a/src/compiler/nir/nir_print.c +++ b/src/compiler/nir/nir_print.c @@ -354,6 +354,13 @@ print_var_decl(nir_variab

Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

On 03/05/16 01:10, Kenneth Graunke wrote: > On Friday, April 29, 2016 1:29:53 PM PDT Samuel Iglesias Gonsálvez wrote: >> When there is a mix of definitions of uniforms with 32-bit or 64-bit >> data type sizes, the driver ends up doing misaligned access to double >> based variables in the push con

Re: [Mesa-dev] [PATCH 05/23] i965/fs: fix copy-propagation with suboffset from constants

On Tue, 2016-05-03 at 16:21 -0700, Jordan Justen wrote: > On 2016-05-03 05:21:54, Samuel Iglesias Gonsálvez wrote: > > From: Iago Toral Quiroga > > > > The current code ignores the suboffet in the instruction's source > > and just uses the one from the constant. This is not correct > > when the i

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using Mesa.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 --- Comment #17 from David Lonie --- Thanks for the info Jose, I'll make a note of that for the future. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

Re: [Mesa-dev] [PATCH] i965: Only enable ARB_query_buffer_object for newer kernels on Haswell.

On 2016-05-05 03:15:51, Kenneth Graunke wrote: > On Haswell, we need version 6 of the kernel command parser in order to > write the math registers. Our implementation of ARB_query_buffer_object > heavily relies on MI_MATH, so we should only advertise it when MI_MATH > is available. > Doh! Comman

Re: [Mesa-dev] [PATCH 00/14] RadeonSI: SDMA texture copy rewrite

On Wed, May 4, 2016 at 7:43 PM, Marek Olšák wrote: > Hi, > > This patch series completely rewrites texture copying with SDMA for CIK & VI. > It only uses the "partial" copy packets, which makes it a lot simpler (one > packet per layered/3D copy). Most of the complexity is in handling hw > limit

Re: [Mesa-dev] [PATCH 00/14] RadeonSI: SDMA texture copy rewrite

On Thu, May 5, 2016 at 5:57 PM, Alex Deucher wrote: > On Wed, May 4, 2016 at 7:43 PM, Marek Olšák wrote: >> Hi, >> >> This patch series completely rewrites texture copying with SDMA for CIK & >> VI. It only uses the "partial" copy packets, which makes it a lot simpler >> (one packet per layered

Re: [Mesa-dev] [PATCH 00/14] RadeonSI: SDMA texture copy rewrite

On Thu, May 5, 2016 at 12:17 PM, Marek Olšák wrote: > On Thu, May 5, 2016 at 5:57 PM, Alex Deucher wrote: >> On Wed, May 4, 2016 at 7:43 PM, Marek Olšák wrote: >>> Hi, >>> >>> This patch series completely rewrites texture copying with SDMA for CIK & >>> VI. It only uses the "partial" copy packe

Re: [Mesa-dev] [PATCH] radeonsi: set DECOMPRESS_Z_ON_FLUSH if nr_samples >= 4

Reviewed-by: Nicolai Hähnle On 04.05.2016 17:35, Marek Olšák wrote: From: Marek Olšák Vulkan always sets this. It only affects in-place Z decompression. This is recommended for performance, but what app uses MSAA depth texturing? --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file

Re: [Mesa-dev] PCI on PowerPC

Hi Mathieu, discussions of the kernel drivers should be sent to dri-de...@lists.freedesktop.org instead. Thanks, Nicolai On 03.05.2016 01:42, Mathieu Malaterre wrote: Dear all, I've tested a patch against radeon_drc.c so that the default mode is now PCI on PowerPC arch. This is the result

Re: [Mesa-dev] [PATCH 00/14] RadeonSI: SDMA texture copy rewrite

> There is one more hardware limitation that can cause VM faults with T2L > copies and needs a workaround. The exact workaround is still under > discussion, but I think this is good enough for review already. BTW, the T2L VM fault is completely harmless. It's caused by SDMA reading more entries

[Mesa-dev] [PATCH] r600g: use the hw MSAA resolving if formats are compatible

From: Marek Olšák This allows resolving RGBA into RGBX. This should improve HL2 Lost Coast performance. --- src/gallium/drivers/r600/r600_blit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/drivers/r600/r600_blit.c inde

Re: [Mesa-dev] [PATCH] r600g: use the hw MSAA resolving if formats are compatible

On Thu, May 5, 2016 at 1:03 PM, Marek Olšák wrote: > From: Marek Olšák > > This allows resolving RGBA into RGBX. > This should improve HL2 Lost Coast performance. Reviewed-by: Alex Deucher > --- > src/gallium/drivers/r600/r600_blit.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

Re: [Mesa-dev] [PATCH] i965: Only enable ARB_query_buffer_object for newer kernels on Haswell.

On Thursday, May 5, 2016 8:17:03 AM PDT Jordan Justen wrote: > On 2016-05-05 03:15:51, Kenneth Graunke wrote: > > On Haswell, we need version 6 of the kernel command parser in order to > > write the math registers. Our implementation of ARB_query_buffer_object > > heavily relies on MI_MATH, so we

[Mesa-dev] [PATCH] nir: fix nir_before/after_cf_node() for function impls

Signed-off-by: Connor Abbott --- src/compiler/nir/nir.h | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 98451c6..8316b0d 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -1995,19 +

Re: [Mesa-dev] [PATCH] nir: fix nir_before/after_cf_node() for function impls

On Thu, May 5, 2016 at 10:10 AM, Connor Abbott wrote: > Signed-off-by: Connor Abbott > --- > src/compiler/nir/nir.h | 22 ++ > 1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h > index 98451c6..8316b0d 100644 >

Re: [Mesa-dev] [PATCH 1/2] meta/blit: Don't blend integer values during MSAA resolves

On Wed, May 4, 2016 at 4:22 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/common/meta_blit.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/common/meta_blit.c > b/src/mesa/drivers/common/meta_blit.c > index 6761238..bb79c46 100644 >

Re: [Mesa-dev] [PATCH 2/2] i965/borp: Don't blend integer values during MSAA resolves

Typo in subject: s/borp/blorp/ On Wed, May 4, 2016 at 4:22 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 30 > ++-- > 1 file changed, 19 insertions(+), 11 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp > b/s

Re: [Mesa-dev] [PATCH] i965: Only enable ARB_query_buffer_object for newer kernels on Haswell.

On 2016-05-05 10:11:24, Kenneth Graunke wrote: > On Thursday, May 5, 2016 8:17:03 AM PDT Jordan Justen wrote: > > On 2016-05-05 03:15:51, Kenneth Graunke wrote: > > > > > > + /* Haswell requires command parser version 6 in order to write to the > > > +* MI_MATH GPR registers, and version 7

Re: [Mesa-dev] [v4 01/11] i965/blorp: Set full resolve for lossless compressed

On Thu, Apr 21, 2016 at 02:58:56PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp > b/src/mesa/drive

Re: [Mesa-dev] [v4 02/11] i965: Relax assertion of halign == 16 for lossless compressed aux

On Thu, Apr 21, 2016 at 02:58:57PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > b/src/mesa/dri

Re: [Mesa-dev] [v4 02/11] i965: Relax assertion of halign == 16 for lossless compressed aux

On Thu, May 05, 2016 at 10:51:32AM -0700, Ben Widawsky wrote: > On Thu, Apr 21, 2016 at 02:58:57PM +0300, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > >

Re: [Mesa-dev] [v4 03/11] i965/gen9: Prepare surface state setup for lossless compression

On Thu, Apr 21, 2016 at 02:58:58PM +0300, Topi Pohjolainen wrote: > v2 (Ben): Use combination of msaa_layout and number of samples > instead of introducing explicit type for lossless > compression (intel_miptree_is_lossless_compressed()). > v3 (Ben): Do not set fast claer state

Re: [Mesa-dev] [PATCH] nir: fix nir_before/after_cf_node() for function impls

On Thu, May 5, 2016 at 1:20 PM, Jason Ekstrand wrote: > On Thu, May 5, 2016 at 10:10 AM, Connor Abbott wrote: >> >> Signed-off-by: Connor Abbott >> --- >> src/compiler/nir/nir.h | 22 ++ >> 1 file changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/src/compiler/nir/

Re: [Mesa-dev] [v4 04/11] i965: Add helper for lossless compression support

On Thu, Apr 21, 2016 at 02:58:59PM +0300, Topi Pohjolainen wrote: > v2: Check explicitly against base type of GL_FLOAT instead of > using _mesa_is_format_integer_color(). Otherwise we miss > GL_UNSIGNED_NORMALIZED. > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/int

[Mesa-dev] [PATCH] nir: fix block iterator to not forget fxn->end_block

From: Rob Clark With the switch to new block iterator macro, we silently stopped iterating over the end-block. Which caused nir_index_blocks() to not index the end-block. Resulting in funny looking nir_print's like: impl main { block block_0: /* preds: */ intrinsic copy

Re: [Mesa-dev] [PATCH 00/11] update swr rasterizer

Reviewed-by: Bruce Cherniak > On May 3, 2016, at 11:13 AM, Tim Rowley wrote: > > Smallish changes this time around, some changes that hopefully > start improving coverity's opinion of the rasterizer, and a small > performance tweak. > > Tim Rowley (11): > swr: [rasterizer] Whitespace cleanup

[Mesa-dev] [PATCH] radeonsi: Compute correct LDS size for fragment shaders.

No sure where the 36 came from, but we clearly need at least 48 bytes per attribute per primitive. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_shader.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH] glsl: trap atomic operations on illegal image formats in compiler.

From: Dave Airlie This fixes: GL43-CTS.shader_image_load_store.negative-compileErrors where shader 9 was being compiled with atomic operation on an r16i. Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_function.cpp | 21 + src/compiler/glsl/builtin_functions.cpp

Re: [Mesa-dev] [PATCH] glsl: trap atomic operations on illegal image formats in compiler.

On Thu, May 5, 2016 at 3:19 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes: > GL43-CTS.shader_image_load_store.negative-compileErrors > > where shader 9 was being compiled with atomic operation on an r16i. > > Signed-off-by: Dave Airlie > --- > src/compiler/glsl/ast_function.cpp

Re: [Mesa-dev] [PATCH] [rfc] mesa/debug_output: fix returned message length.

On 4 May 2016 at 06:52, Dave Airlie wrote: > From: Dave Airlie > > This fixes both: > GL43-CTS.khr_debug.receiveing_messages > GL43-CTS.khr_debug.groups Lols, this breaks GL43-CTS.gtf43.GL2ExtensionTests.debug.debug and the spec states the lengths include the NULL terminator, so ignore this pat

[Mesa-dev] [PATCH 4/7] i965: Support textures with multiple planes

From: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/brw_compiler.h | 1 + src/mesa/drivers/dri/i965/brw_context.h | 2 +- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 13 src/mesa/drivers/dri/i965/brw_shader.cpp | 9 ++ src/mesa/dri

[Mesa-dev] [PATCH 6/7] i965: Allow creating planar YUV __DRIimages

From: Kristian Høgsberg Kristensen Lift the resctriction we had before and allow creation of images with multiple planes. We still require all the planes to be within the same bo. --- src/mesa/drivers/dri/i965/intel_screen.c | 33 ++-- 1 file changed, 19 insertions(+)

[Mesa-dev] [PATCH 1/7] nir: Add new 'plane' texture source type

From: Kristian Høgsberg Kristensen This will be used to select the plane to sample from for planar textures. --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_print.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 4693ab5.

[Mesa-dev] [PATCH 2/7] nir: Add a lowering pass for YUV textures

From: Kristian Høgsberg Kristensen This lowers sampling from YUV textures to 1) one or more texture instructions to sample each plane and 2) color space conversion to RGB. --- src/compiler/nir/nir.h | 7 +++ src/compiler/nir/nir_lower_tex.c | 118 +

[Mesa-dev] [PATCH 3/7] i965: Create multiple miptrees planar YUV images

From: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 ++ src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 ++ src/mesa/drivers/dri/i965/intel_tex_image.c | 73 ++- src/mesa/drivers/dri/i965/intel_tex_obj.h | 2 + 4 files chang

[Mesa-dev] [PATCH 7/7] dri: Add YVU formats

From: Kristian Høgsberg Kristensen --- include/GL/internal/dri_interface.h | 5 + src/mesa/drivers/dri/i965/intel_screen.c | 26 ++ 2 files changed, 31 insertions(+) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index 8

[Mesa-dev] [PATCH 0/7] Support for samplerExternalOES YUV EGLImages

From: Kristian Høgsberg Kristensen This patche series adds support for importing YUV buffers as EGLImages and sampling from them using samplerExternalOES. This series implements the sampling by lowering the texture operation to 1-3 texture operations from the YUV planes and inserts color space co

[Mesa-dev] [PATCH 5/7] i965: Invoke lowering pass for YUV textures

From: Kristian Høgsberg Kristensen --- src/mesa/drivers/dri/i965/brw_compiler.h | 7 +++ src/mesa/drivers/dri/i965/brw_nir.c | 4 src/mesa/drivers/dri/i965/brw_wm.c | 29 + 3 files changed, 40 insertions(+) diff --git a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH] mesa/shader_query: add missing subroutines cases

From: Dave Airlie ARRAY_SIZE and LOCATION should accept the SUBROUTINE_UNIFORM types. Fixes: GL43-CTS.program_interface_query.subroutines-vertex GL43-CTS.program_interface_query.subroutines-tess-control GL43-CTS.program_interface_query.subroutines-tess-eval GL43-CTS.program_interface_query.subro

Re: [Mesa-dev] [PATCH 2/7] nir: Add a lowering pass for YUV textures

On Thu, May 5, 2016 at 5:04 PM, Kristian Høgsberg wrote: > From: Kristian Høgsberg Kristensen > > This lowers sampling from YUV textures to 1) one or more texture > instructions to sample each plane and 2) color space conversion to RGB. > --- > src/compiler/nir/nir.h | 7 +++ > src/

[Mesa-dev] [PATCH] mesa/compute: Fix indirect dispatch buffer size check on 32-bit systems

2655265fcba9017e793026c76e490e04db088c8f, but for compute. Signed-off-by: Jordan Justen Cc: Kenneth Graunke --- I don't know if there is a test that this fixes, but it seems like we should handle it the same as the draw case. Note that the draw indirect param is a pointer, whereas it is a

Re: [Mesa-dev] [PATCH] mesa/compute: Fix indirect dispatch buffer size check on 32-bit systems

Reviewed-by: Jason Ekstrand On Thu, May 5, 2016 at 5:38 PM, Jordan Justen wrote: > 2655265fcba9017e793026c76e490e04db088c8f, but for compute. > > Signed-off-by: Jordan Justen > Cc: Kenneth Graunke > --- > > I don't know if there is a test that this fixes, but it seems like we > should handl

[Mesa-dev] [PATCH 1/3] nir/algebraic: Separate ffma lowering from fusing

The i965 driver has its own pass for fusing mul+add combinations that's much smarter than what nir_opt_algebraic can do so we don't want to get the nir_opt_algebraic one just because we didn't set lower_ffma. --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_opt_algebraic

[Mesa-dev] [PATCH 2/3] ptn: Emit mul+add for MAD

Unlike fma() in GLSL, MAD in ARB programs is 100% splittable. Just emit the split version and let the optimizer fuse them later. Shader-db results on Haswell: total instructions in shared programs: 7560379 -> 7560300 (-0.00%) instructions in affected programs: 143928 -> 143849 (-0.05%)

[Mesa-dev] [PATCH 3/3] i965: Stop splitting fma() prior to optimization

According to the GLSL spec, if the user uses fma directly and you have it in your hardware, you shouldn't split it. For a while now, we've been splitting all fma's up-front and then planned to fuse them later. The only reason why this possibly helped before was for ARB programs which is handled b

Re: [Mesa-dev] [PATCH 3/3] i965: Stop splitting fma() prior to optimization

On Thu, May 5, 2016 at 8:51 PM, Jason Ekstrand wrote: > According to the GLSL spec, if the user uses fma directly and you have it > in your hardware, you shouldn't split it. For a while now, we've been > splitting all fma's up-front and then planned to fuse them later. The only > reason why this

Re: [Mesa-dev] [PATCH 3/3] i965: Stop splitting fma() prior to optimization

On May 5, 2016 6:13 PM, "Ilia Mirkin" wrote: > > On Thu, May 5, 2016 at 8:51 PM, Jason Ekstrand wrote: > > According to the GLSL spec, if the user uses fma directly and you have it > > in your hardware, you shouldn't split it. For a while now, we've been > > splitting all fma's up-front and then

Re: [Mesa-dev] [PATCH 3/3] i965: Stop splitting fma() prior to optimization

On Thu, May 5, 2016 at 6:22 PM, Jason Ekstrand wrote: > > On May 5, 2016 6:13 PM, "Ilia Mirkin" wrote: > > > > On Thu, May 5, 2016 at 8:51 PM, Jason Ekstrand > wrote: > > > According to the GLSL spec, if the user uses fma directly and you have > it > > > in your hardware, you shouldn't split it

[Mesa-dev] [PATCH] glsl: validate subroutine types match function signature.

From: Dave Airlie This fixes: GL43-CTS.shader_subroutine.subroutines_incompatible_with_subroutine_type It just makes sure the signatures match as well as the return types. Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_to_hir.cpp | 18 ++ 1 file changed, 18 insertions(+)

Re: [Mesa-dev] [PATCH 3/3] i965: Stop splitting fma() prior to optimization

On Thu, May 5, 2016 at 8:51 PM, Jason Ekstrand wrote: > According to the GLSL spec, if the user uses fma directly and you have it > in your hardware, you shouldn't split it. For a while now, we've been > splitting all fma's up-front and then planned to fuse them later. The only > reason why this

[Mesa-dev] [PATCH] glsl: produce a linker error for a subroutine uniform with no functions.

From: Dave Airlie If a subroutine uniform is declared with no functions backing it, that isn't legal, so we should fail to link. Fixes: GL43-CTS.shader_subroutine.subroutine_uniform_wo_matching_subroutines Signed-off-by: Dave Airlie --- src/compiler/glsl/linker.cpp | 4 1 file changed, 4

Re: [Mesa-dev] [PATCH] glsl: trap atomic operations on illegal image formats in compiler.

Dave Airlie writes: > From: Dave Airlie > > This fixes: > GL43-CTS.shader_image_load_store.negative-compileErrors > > where shader 9 was being compiled with atomic operation on an r16i. > > Signed-off-by: Dave Airlie > --- > src/compiler/glsl/ast_function.cpp | 21 + >

Re: [Mesa-dev] [04.5/11] i965: Add flag telling if miptree is for client consumption

On Mon, Apr 25, 2016 at 08:10:01PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 9 + > 2 files changed, 13 insertions(+), 3 deletions(-) > > diff --git

Re: [Mesa-dev] [v5 05/11] i965: Deferred allocation of mcs for lossless compressed

On Mon, Apr 25, 2016 at 08:10:02PM +0300, Topi Pohjolainen wrote: > Until not mcs was associated to single sampled buffers only for ^ now > fast clear purposes and it was therefore the responsibility of the > clear logic to allocate the aux buffer when needed. Now that normal > 3D render

Re: [Mesa-dev] [PATCH 3/3] i965: Stop splitting fma() prior to optimization

On May 5, 2016 6:35 PM, "Connor Abbott" wrote: > > On Thu, May 5, 2016 at 8:51 PM, Jason Ekstrand wrote: > > According to the GLSL spec, if the user uses fma directly and you have it > > in your hardware, you shouldn't split it. For a while now, we've been > > splitting all fma's up-front and th

[Mesa-dev] [Bug 95266] Geometry missing from rendering, only when using gallivm.

https://bugs.freedesktop.org/show_bug.cgi?id=95266 Ilia Mirkin changed: What|Removed |Added Summary|Geometry missing from |Geometry missing from |r

Re: [Mesa-dev] [PATCH 2/7] nir: Add a lowering pass for YUV textures

On Thu, May 5, 2016 at 5:37 PM, Jason Ekstrand wrote: > > > On Thu, May 5, 2016 at 5:04 PM, Kristian Høgsberg wrote: >> >> From: Kristian Høgsberg Kristensen >> >> This lowers sampling from YUV textures to 1) one or more texture >> instructions to sample each plane and 2) color space conversion

Re: [Mesa-dev] [PATCH] glsl: trap atomic operations on illegal image formats in compiler.

On 6 May 2016 at 11:41, Francisco Jerez wrote: > Dave Airlie writes: > >> From: Dave Airlie >> >> This fixes: >> GL43-CTS.shader_image_load_store.negative-compileErrors >> >> where shader 9 was being compiled with atomic operation on an r16i. >> >> Signed-off-by: Dave Airlie >> --- >> src/comp

Re: [Mesa-dev] [v4 06/11] i965/blorp: Prepare blits for lossless compression

On Thu, Apr 21, 2016 at 02:59:01PM +0300, Topi Pohjolainen wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp.cpp | 2 +- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 26 +- > 2 files changed, 22 insertions(+), 6 deletions(-) >

[Mesa-dev] [PATCH v2] nir: Put nir_variable's memory qualifiers in its own struct

ARB_shader_storage_buffer_object allows for memory qualifiers defined for ARB_shader_image_load_store, to be applied to SSBOs using the same semantics. So, for clarity, we might want to take these qualifiers out into its own category, rather than putting them inside the 'image' specific struct. I

Re: [Mesa-dev] [v4 06/11] i965/blorp: Prepare blits for lossless compression

On Thu, May 05, 2016 at 11:01:54PM -0700, Ben Widawsky wrote: > On Thu, Apr 21, 2016 at 02:59:01PM +0300, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/brw_blorp.cpp | 2 +- > > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 26 > > ++

[Mesa-dev] [PATCH v2 56/59] i965/fs: push first double-based uniforms in push constant buffer

When there is a mix of definitions of uniforms with 32-bit or 64-bit data type sizes, the driver ends up doing misaligned access to double based variables in the push constant buffer. To fix this, this patch pushes first all the 64-bit variables and then the rest. Then, all the variables would be

Re: [Mesa-dev] [v4 06/11] i965/blorp: Prepare blits for lossless compression

On Fri, May 06, 2016 at 09:30:27AM +0300, Pohjolainen, Topi wrote: > On Thu, May 05, 2016 at 11:01:54PM -0700, Ben Widawsky wrote: > > On Thu, Apr 21, 2016 at 02:59:01PM +0300, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > > src/mesa/drivers/dri/i965/brw_blorp.cpp