Re: [Mesa-dev] [PATCH 29/28] i965/blorp: Get rid of the blorp_prog_data_int() helper

2016-05-13 Thread Pohjolainen, Topi
On Fri, May 13, 2016 at 12:27:01AM -0700, Jason Ekstrand wrote: >On Fri, May 13, 2016 at 12:07 AM, Pohjolainen, Topi ><[1]topi.pohjolai...@intel.com> wrote: > > On Wed, May 11, 2016 at 11:37:10AM -0700, Jason Ekstrand wrote: > > The helper was initially created to allow us to set

Re: [Mesa-dev] Android: apps crashed on Intel Gen9 GPU

2016-05-13 Thread Pohjolainen, Topi
On Thu, May 12, 2016 at 12:25:25AM +0800, Chih-Wei Huang wrote: > Testing android-x86 with mesa 11.2.2, > I found the Google Play crashed forever on > a device with Intel Gen9 GPU (e.g., Skylake). > > After analyzing, the i965 driver seems to assume > irb->mt is not null. For example in > brw_meta

Re: [Mesa-dev] [PATCH 29/28] i965/blorp: Get rid of the blorp_prog_data_int() helper

2016-05-13 Thread Jason Ekstrand
On Fri, May 13, 2016 at 12:07 AM, Pohjolainen, Topi < topi.pohjolai...@intel.com> wrote: > On Wed, May 11, 2016 at 11:37:10AM -0700, Jason Ekstrand wrote: > > The helper was initially created to allow us to set reasonable defaults > as > > we mutated the brw_blorp_prog_data structure in preparatio

Re: [Mesa-dev] [PATCH 21/28] i965/blorp: Add initial support for NIR-based blit shaders

2016-05-13 Thread Jason Ekstrand
On Thu, May 12, 2016 at 10:04 PM, Pohjolainen, Topi < topi.pohjolai...@intel.com> wrote: > On Tue, May 10, 2016 at 04:16:41PM -0700, Jason Ekstrand wrote: > > Many of the more complex cases still fall back to the old shader builder. > > --- > > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 425 >

Re: [Mesa-dev] [PATCH 30/28] i965/blorp: Stop doing f2i(i2f(sample_id))

2016-05-13 Thread Pohjolainen, Topi
On Thu, May 12, 2016 at 04:27:38PM -0700, Jason Ekstrand wrote: > NIR gets kind of awkward when you have a 3-component vector with two floats > and one int. This led to us accidentally going through float for the > sample index. It doesn't hurt anything but it also isn't needed. I suppose it wou

Re: [Mesa-dev] [PATCH 29/28] i965/blorp: Get rid of the blorp_prog_data_int() helper

2016-05-13 Thread Pohjolainen, Topi
On Wed, May 11, 2016 at 11:37:10AM -0700, Jason Ekstrand wrote: > The helper was initially created to allow us to set reasonable defaults as > we mutated the brw_blorp_prog_data structure in preparation for NIR. Now > that everything is going through brw_blorp_compile_nir_shader() which fully > fi

Re: [Mesa-dev] [PATCH] glsl: make sure that texture(bias) variants are only exposed in fs

2016-05-13 Thread Nicolai Hähnle
Thanks! Reviewed-by: Nicolai Hähnle On 13.05.2016 00:12, Ilia Mirkin wrote: Many were already marked as fs_only, but not all. This fixes the remaining ir_txb entries. Signed-off-by: Ilia Mirkin --- src/compiler/glsl/builtin_functions.cpp | 74 - 1 file chan

Re: [Mesa-dev] [PATCH 28/28] i965/blorp: Delete the old blorp shader emit code

2016-05-13 Thread Pohjolainen, Topi
On Tue, May 10, 2016 at 04:16:48PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/Makefile.sources |2 - > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp| 1288 > +-- > src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 145 --- > src/mesa/drivers/dr

[Mesa-dev] [PATCH] i965: Make exec_size 16 word/byte registers use exec_size halving again.

2016-05-13 Thread Kenneth Graunke
In a5d7e144eaf43fee37e6ff9e2de194407087632b, Connor generalized the exec_size halving code to handle more cases. However, he accidentally made exec_size 16 instructions with word/byte types skip the halving code, producing invalid regions, and regressing a lot of Piglit tests on some 965GM systems

Re: [Mesa-dev] [PATCH 27/28] i965/blorp: Refactor coordinate munging

2016-05-13 Thread Pohjolainen, Topi
On Tue, May 10, 2016 at 04:16:47PM -0700, Jason Ekstrand wrote: > The original code-flow tried to map original blorp. This puts things more > where they belong and simplifies some of the logic. Nice, this was one of the things that gave me a headache in the original. It was troublesome to check w

<    1   2