Re: [Mesa-dev] [PATCH] i965: Shrink stage_prog_data param array length

2016-05-28 Thread Jason Ekstrand
Thanks for fixing this! Rb On May 28, 2016 23:02, "Jordan Justen" wrote: > It appears we were over-allocating these arrays. > > Previously we would use nir->num_uniforms directly for scalar > programs, and multiply it by 4 for vec4 programs. > > Instead we should have been dividing by 4 in both

[Mesa-dev] [PATCH] i965: Shrink stage_prog_data param array length

2016-05-28 Thread Jordan Justen
It appears we were over-allocating these arrays. Previously we would use nir->num_uniforms directly for scalar programs, and multiply it by 4 for vec4 programs. Instead we should have been dividing by 4 in both cases to convert from bytes to a gl_constant_value count. The size of gl_constant_valu

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/4] glx: fix error code when there is no context bound

2016-05-28 Thread Tapani Pälli
On 05/27/2016 08:16 PM, Emil Velikov wrote: On Friday, 27 May 2016, Tapani Pälli > wrote: On 05/26/2016 05:16 PM, Emil Velikov wrote: Hi all, On 29 February 2016 at 07:14, Tapani Pälli wrote: On 02/22/2016 10:16 PM, Ia

[Mesa-dev] [PATCH] st/mesa: fix setting of point_size_per_vertex in ES contexts

2016-05-28 Thread Ilia Mirkin
GL ES 2.0+ does not have a GL_PROGRAM_POINT_SIZE enable, unlike desktop GL. So we have to go and check the last pre-rasterizer stage to see whether it outputs a point size or not. This fixes a number of dEQP tests that use a geometry or tessellation shader to emit points primitives. Signed-off-by

[Mesa-dev] [Bug 95374] ARK:survival of the fittest fails when GL4.3 is enabled.

2016-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95374 --- Comment #2 from Shawn Starr --- If you use MESA_GLSL_VERSION_OVERRIDE=150 / 330 it works fine, 430 will cause it to crash. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH 13/25] i965/fs: Skip SIMD lowering destination zipping if possible.

2016-05-28 Thread Francisco Jerez
Jason Ekstrand writes: > On Fri, May 27, 2016 at 7:05 PM, Francisco Jerez > wrote: > >> Skipping the temporary allocation and copy instructions is easy (just >> return dst), but the conditions used to find out whether the copy can >> be optimized out safely without breaking the program are rathe

[Mesa-dev] [Bug 95374] ARK:survival of the fittest fails when GL4.3 is enabled.

2016-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95374 Shawn Starr changed: What|Removed |Added CC||shawn.st...@rogers.com -- You are receivi

Re: [Mesa-dev] [PATCH 00/25] i965: Scalar back-end support for SIMD32, part 4.

2016-05-28 Thread Jason Ekstrand
On Fri, May 27, 2016 at 7:05 PM, Francisco Jerez wrote: > This fixes the few code quality regressions from the previous series > enabling SIMD32 CS codegen in the back-end -- AFAICT by the end of the > series we can finally enable GL 4.3 on all Gen8+ hardware. > > Patches 1-8 delay the SIMD lower

Re: [Mesa-dev] [PATCH 24/25] i965/fs: Skip gen4 pre/post-send dependency workaronds for the first/last block.

2016-05-28 Thread Jason Ekstrand
On Fri, May 27, 2016 at 7:06 PM, Francisco Jerez wrote: > We know that there cannot be any destination dependency race if we > reach the beginning or end of the program without having found any > other instruction the send could possibly race with. This avoids > emitting a pile of useless moves

Re: [Mesa-dev] [PATCH 23/25] i965/fs: Allow scalar source regions on SNB math instructions.

2016-05-28 Thread Jason Ekstrand
The code changes look correct to me. I'm CCing matt in case he knows something about why this wouldn't work the way the docs say. (It is Sandy Bridge after all) On Fri, May 27, 2016 at 7:06 PM, Francisco Jerez wrote: > I haven't found any evidence that this isn't supported by the > hardware, i

Re: [Mesa-dev] [PATCH 13/25] i965/fs: Skip SIMD lowering destination zipping if possible.

2016-05-28 Thread Jason Ekstrand
On Fri, May 27, 2016 at 7:05 PM, Francisco Jerez wrote: > Skipping the temporary allocation and copy instructions is easy (just > return dst), but the conditions used to find out whether the copy can > be optimized out safely without breaking the program are rather > complex: The destination must

Re: [Mesa-dev] [PATCH 07/25] i965/fs: Implement opt_sampler_eot() in terms of logical sends.

2016-05-28 Thread Francisco Jerez
Jason Ekstrand writes: > On Sat, May 28, 2016 at 1:21 PM, Francisco Jerez > wrote: > >> Jason Ekstrand writes: >> >> > On Fri, May 27, 2016 at 7:05 PM, Francisco Jerez >> > wrote: >> > >> >> This makes the whole LOAD_PAYLOAD munging unnecessary which simplifies >> >> the code and will allow th

Re: [Mesa-dev] [PATCH 10/25] i965/fs: Generalize regions_overlap() from copy propagation to handle non-VGRF files.

2016-05-28 Thread Jason Ekstrand
On Fri, May 27, 2016 at 7:05 PM, Francisco Jerez wrote: > This will be useful in several places. The only externally visible > difference (other than non-VGRF files being supported now) is that the > region sizes are now passed in byte units instead of in GRF units > because the loss of precisio

Re: [Mesa-dev] [PATCH 07/25] i965/fs: Implement opt_sampler_eot() in terms of logical sends.

2016-05-28 Thread Jason Ekstrand
On Sat, May 28, 2016 at 1:21 PM, Francisco Jerez wrote: > Jason Ekstrand writes: > > > On Fri, May 27, 2016 at 7:05 PM, Francisco Jerez > > wrote: > > > >> This makes the whole LOAD_PAYLOAD munging unnecessary which simplifies > >> the code and will allow the optimization to succeed in more cas

Re: [Mesa-dev] [PATCH 07/25] i965/fs: Implement opt_sampler_eot() in terms of logical sends.

2016-05-28 Thread Francisco Jerez
Jason Ekstrand writes: > On Fri, May 27, 2016 at 7:05 PM, Francisco Jerez > wrote: > >> This makes the whole LOAD_PAYLOAD munging unnecessary which simplifies >> the code and will allow the optimization to succeed in more cases >> independent of whether the LOAD_PAYLOAD instruction can be found

[Mesa-dev] [Bug 96242] Latest mesa from git doesn't build - Python3 not found

2016-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96242 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 96176] Cannot build non-intel drivers without python3.

2016-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96176 Vinson Lee changed: What|Removed |Added CC||joro-2...@t-online.de --- Comment #3 from V

Re: [Mesa-dev] [PATCH] i965: add missing return in if statement

2016-05-28 Thread Jason Ekstrand
On Sat, May 28, 2016 at 4:16 AM, Thomas Hindoe Paaboel Andersen < pho...@gmail.com> wrote: > Re-add the "return false" that was removed in > 0c02d7002d6c005b4c1fe997b5ef5916978dd183 > > It seems that something went wrong when merging the patch. The patch > sent to the mailing list does not directl

Re: [Mesa-dev] [PATCH 00/25] i965: Scalar back-end support for SIMD32, part 4.

2016-05-28 Thread Jason Ekstrand
On Fri, May 27, 2016 at 7:05 PM, Francisco Jerez wrote: > This fixes the few code quality regressions from the previous series > enabling SIMD32 CS codegen in the back-end -- AFAICT by the end of the > series we can finally enable GL 4.3 on all Gen8+ hardware. > > Patches 1-8 delay the SIMD lower

Re: [Mesa-dev] [PATCH 08/25] SQUASH: i965/fs: Add basic dataflow check to opt_sampler_eot().

2016-05-28 Thread Jason Ekstrand
On Fri, May 27, 2016 at 7:05 PM, Francisco Jerez wrote: > The sampler EOT optimization pass naively assumes that the texturing > instruction provides all the data used by the FB write just because > they're standing next to each other. The least we should be checking > is whether the source and

Re: [Mesa-dev] [PATCH 07/25] i965/fs: Implement opt_sampler_eot() in terms of logical sends.

2016-05-28 Thread Jason Ekstrand
On Fri, May 27, 2016 at 7:05 PM, Francisco Jerez wrote: > This makes the whole LOAD_PAYLOAD munging unnecessary which simplifies > the code and will allow the optimization to succeed in more cases > independent of whether the LOAD_PAYLOAD instruction can be found or > not. > --- > src/mesa/drive

Re: [Mesa-dev] [PATCH 00/29] Make more use of bitmasks

2016-05-28 Thread Dieter Nützel
From: Mathias Fröhlich Hi all, following a series with performance improvements for cpu/draw bound applications. This part makes more use of the bitmask/ffs technique for iterating a set of enabled items. The gains are not huge but they are noticable for some of my favourite workloads. Please

Re: [Mesa-dev] [PATCH] nvc0: make use of NVC0_CB_AUX_XXX_SIZE as much as possible

2016-05-28 Thread Samuel Pitoiset
On 05/27/2016 08:26 PM, Ilia Mirkin wrote: TBH I don't like this. The way it is now, there's an obvious correlation between the numbers uploaded, and the for loops/etc which actually stick the data into the pushbuf. After your change, it's not at all clear, and should those numbers become disco

Re: [Mesa-dev] [PATCH 1/2] nvc0: drop unused surfaces formats conversion builtins

2016-05-28 Thread Samuel Pitoiset
On 05/27/2016 08:27 PM, Ilia Mirkin wrote: But it will be used in the future, when we need to support dynamic formats, with OpenCL. I'd rather leave this in. Well, this is not going to happen soon, even not this year I would assume. But okay, I'll leave this in. -ilia On Fri, May 27,

Re: [Mesa-dev] [PATCH 25/25] i965: Expose GL 4.3 on Gen8+.

2016-05-28 Thread Jason Ekstrand
Rb On May 27, 2016 7:13 PM, "Francisco Jerez" wrote: > ARB_compute_shader was apparently the last feature missing. > --- > src/mesa/drivers/dri/i965/intel_extensions.c | 2 +- > src/mesa/drivers/dri/i965/intel_screen.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] swr: [rasterizer] Do not define _mm256_storeu2_m128i with icc.

2016-05-28 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley > On May 25, 2016, at 11:18 PM, Vinson Lee wrote: > > Fix build error with icc. > > CXX libswrAVX_la-swr_clear.lo > icpc: command line warning #10006: ignoring unknown option > '-Wdelete-non-virtual-dtor' > In file included from ./rasterizer/jitter/jit_api.h(31),

Re: [Mesa-dev] Drivers/Gallium/swr is missing from the list of Mesa components when entering a new bug

2016-05-28 Thread Rowley, Timothy O
> On May 27, 2016, at 7:10 AM, Rob Clark wrote: > > On Fri, May 27, 2016 at 5:39 AM, Emil Velikov > wrote: >> On 27 May 2016 at 09:44, Michel Dänzer wrote: >>> On 27.05.2016 16:37, ⚛ wrote: Hello. Please add "Drivers/Gallium/swr" to the list "Component" at https://bugs.fr

[Mesa-dev] [Bug 95374] ARK:survival of the fittest fails when GL4.3 is enabled.

2016-05-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95374 --- Comment #1 from Bas Nieuwenhuizen --- I managed to extract an error message from the function that create the message box: "The global shader cache file '/mnt/extern/games/steam/steamapps/common/ARK SOTF/Engine/GlobalShaderCache-GLSL_430.bin

[Mesa-dev] [PATCH] i965: add missing return in if statement

2016-05-28 Thread Thomas Hindoe Paaboel Andersen
Re-add the "return false" that was removed in 0c02d7002d6c005b4c1fe997b5ef5916978dd183 It seems that something went wrong when merging the patch. The patch sent to the mailing list does not directly match what was committed. https://lists.freedesktop.org/archives/mesa-dev/2016-May/118198.html ---

Re: [Mesa-dev] [PATCH 11/29] mesa: Use bitmask/ffs to iterate enabled lights for building ff shader keys.

2016-05-28 Thread Mathias Fröhlich
Hi Erik, On Friday, May 27, 2016 12:38:39 Erik Faye-Lund wrote: > >> This takes the code from something very obvious and easy to follow to > >> something you'll have to think twice about the correctness of... > > > > IMO that is a matter of if you are used to that or not. > > When I saw this first