[Mesa-dev] [PATCH] st/mesa: use first image's dimensions when finalizing texture

2016-06-04 Thread Ilia Mirkin
In the case where we can't guess the base level size, just use the first image's dims. The width0/height0/depth0 on stObj may not have been set at this point. Observed in a trace that set up levels 2..9 of a 2d texture, and set the base level to 2, with height 1. This made the guess logic always ba

[Mesa-dev] [PATCH] mesa/glsl: stop using GL shader type internally

2016-06-04 Thread Timothy Arceri
Instead use the internal gl_shader_stage enum everywhere. This makes things more consistent and gets rid of unnecessary conversions. Ideally it would be nice to remove the Type field from gl_shader altogether but currently it is used to differentiate between gl_shader and gl_shader_program in the

[Mesa-dev] [Bug 96381] Texture artifacts with immutable texture storage and mipmaps

2016-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96381 Bas Nieuwenhuizen changed: What|Removed |Added Component|Other |Drivers/Gallium/radeonsi QA

[Mesa-dev] [Bug 96358] SSO: wrong interface validation between GS and VS (regresion due to latest gles 3.1)

2016-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96358 Ian Romanick changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |i...@freedesktop.org |o

[Mesa-dev] [Bug 96381] Texture artifacts with immutable texture storage and mipmaps

2016-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96381 --- Comment #1 from Ilia Mirkin --- Renders fine on nvc0 and nv50, both 11.2 and master. Sounds like a radeonsi issue, not mesa core. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

[Mesa-dev] [Bug 96381] Texture artifacts with immutable texture storage and mipmaps

2016-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96381 Fabian Maurer changed: What|Removed |Added CC||dark.shad...@web.de -- You are receivin

[Mesa-dev] [Bug 96381] Texture artifacts with immutable texture storage and mipmaps

2016-06-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96381 Bug ID: 96381 Summary: Texture artifacts with immutable texture storage and mipmaps Product: Mesa Version: 11.2 Hardware: Other OS: Linux (All)

Re: [Mesa-dev] [PATCH] anv/entrypoints: don't go using wayland/xcb unless they are configured

2016-06-04 Thread Emil Velikov
On 5 June 2016 at 00:12, Dave Airlie wrote: > On 5 June 2016 at 08:51, Emil Velikov wrote: >> On 4 June 2016 at 21:55, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> The fix in: >>> anv: let anv_entrypoints_gen.py generate proper Wayland/Xcb guards >>> >>> breaks things if wayland headers are

Re: [Mesa-dev] [PATCH] anv/entrypoints: don't go using wayland/xcb unless they are configured

2016-06-04 Thread Dave Airlie
On 5 June 2016 at 08:51, Emil Velikov wrote: > On 4 June 2016 at 21:55, Dave Airlie wrote: >> From: Dave Airlie >> >> The fix in: >> anv: let anv_entrypoints_gen.py generate proper Wayland/Xcb guards >> >> breaks things if wayland headers aren't installed. >> >> Separate things out properly to a

Re: [Mesa-dev] [PATCH] anv/entrypoints: don't go using wayland/xcb unless they are configured

2016-06-04 Thread Emil Velikov
On 4 June 2016 at 21:55, Dave Airlie wrote: > From: Dave Airlie > > The fix in: > anv: let anv_entrypoints_gen.py generate proper Wayland/Xcb guards > > breaks things if wayland headers aren't installed. > > Separate things out properly to avoid that problem. > > Reported-by: Arjan van de Ven > S

[Mesa-dev] [PATCH] anv/pipeline: Add support for caching the push constant map

2016-06-04 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: Kristian Høgsberg Kristensen --- src/intel/vulkan/anv_pipeline_cache.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline_cache.c b/src/intel/vulkan/anv_pipeline_cache.c index 62d

Re: [Mesa-dev] [PATCH] anv/entrypoints: don't go using wayland/xcb unless they are configured

2016-06-04 Thread Jason Ekstrand
On Sat, Jun 4, 2016 at 1:55 PM, Dave Airlie wrote: > From: Dave Airlie > > The fix in: > anv: let anv_entrypoints_gen.py generate proper Wayland/Xcb guards > > breaks things if wayland headers aren't installed. > > Separate things out properly to avoid that problem. > > Reported-by: Arjan van de

[Mesa-dev] [PATCH] anv/entrypoints: don't go using wayland/xcb unless they are configured

2016-06-04 Thread Dave Airlie
From: Dave Airlie The fix in: anv: let anv_entrypoints_gen.py generate proper Wayland/Xcb guards breaks things if wayland headers aren't installed. Separate things out properly to avoid that problem. Reported-by: Arjan van de Ven Signed-off-by: Dave Airlie --- src/intel/vulkan/Makefile.am |

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: don't validate pipeline in GL debug contexts

2016-06-04 Thread Ilia Mirkin
On Sat, Jun 4, 2016 at 3:36 PM, Ian Romanick wrote: > How about if you give me a chance to actually fix the problem instead of > papering over it? That sounds fine too. It's causing real problems for debugging right now though (glretrace creates debug contexts by default), which is why I wanted t

Re: [Mesa-dev] tilers and out-of-order rendering..

2016-06-04 Thread Rob Clark
On Fri, Jun 3, 2016 at 8:53 AM, Rob Clark wrote: > Ok, so I had a really evil thought that I wanted to bounce off > people.. it's a quite different approach from the more obvious one > discussed below (and which I've already started implementing) > > Basically, idea is to have a wrapper pipe driv

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: don't validate pipeline in GL debug contexts

2016-06-04 Thread Ian Romanick
How about if you give me a chance to actually fix the problem instead of papering over it? On June 4, 2016 10:17:59 AM Ilia Mirkin wrote: This is causing problems with glretrace and various traces I've seen, including F1 2015 and PCSX2. I haven't carefully debugged what's going on, but the g

[Mesa-dev] [PATCH 2/2] nvc0: reduce overhead from always marking images dirty

2016-06-04 Thread Ilia Mirkin
We would revalidate images when anything was touched at all. Which is unfortunate, since the state tracker does not use CSO's to reduce the workload. So instead implement a protocol to ensure that something has changed before revalidating all the images. Signed-off-by: Ilia Mirkin Cc: "12.0" ---

[Mesa-dev] [PATCH 1/2] nvc0: reduce overhead from always marking buffers dirty

2016-06-04 Thread Ilia Mirkin
We would revalidate buffers when anything was touched at all. Which is unfortunate, since the state tracker does not use CSO's to reduce the workload. So instead implement a protocol to ensure that something has changed before revalidating all the SSBOs. Signed-off-by: Ilia Mirkin Cc: "12.0" ---

[Mesa-dev] [PATCH 1/2] st/mesa: revalidate image atoms when a texture is updated

2016-06-04 Thread Ilia Mirkin
A texture may be redefined with _NEW_TEXTURE, which might have been bound to a shader image slot. We have to revalidate the image atoms to pick up on the new resource. Signed-off-by: Ilia Mirkin Cc: "12.0" --- src/mesa/state_tracker/st_atom_image.c | 12 ++-- 1 file changed, 6 insertion

[Mesa-dev] [PATCH 2/2] st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-04 Thread Ilia Mirkin
We were previously unconditionally doing this for arrays and ubo's, and ignoring texture/storage/atomic buffers. Instead use the usage history to determine which atoms need to be revalidated. Signed-off-by: Ilia Mirkin Cc: "12.0" --- src/mesa/state_tracker/st_cb_bufferobjects.c | 15 +++

[Mesa-dev] [PATCH] mesa: don't validate pipeline in GL debug contexts

2016-06-04 Thread Ilia Mirkin
This is causing problems with glretrace and various traces I've seen, including F1 2015 and PCSX2. I haven't carefully debugged what's going on, but the games do work fine when tracing, which most likely points to the validation logic not being suitable for desktop GL. I've left in the ability to f

Re: [Mesa-dev] [PATCH] glsl: fix uninitialized instance variable

2016-06-04 Thread Rob Clark
On Sat, Jun 4, 2016 at 7:51 AM, Jan Ziak (⚛) atom-symbol.net <0xe2.0x9a.0...@gmail.com> wrote: > Valgrind detected that variable ir_copy_propagation_visitor::killed_all > is uninitialized. > > Signed-off-by: Jan Ziak (⚛) atom-symbol.net <0xe2.0x9a.0...@gmail.com> Reviewed-by: Rob Clark > --- >

Re: [Mesa-dev] [PATCH 0/9] radeonsi: speed up no-op descriptor uploads

2016-06-04 Thread Bas Nieuwenhuizen
On Fri, Jun 3, 2016 at 7:01 PM, Nicolai Hähnle wrote: > Hi, > > it is quite common that few or even no descriptors (except for vertex > buffers) change between draw calls, but the function call overhead and > branchiness of the code that is involved in figuring out that nothing > changes takes a s

[Mesa-dev] [PATCH] glsl: fix uninitialized instance variable

2016-06-04 Thread
Valgrind detected that variable ir_copy_propagation_visitor::killed_all is uninitialized. Signed-off-by: Jan Ziak (⚛) atom-symbol.net <0xe2.0x9a.0...@gmail.com> --- src/compiler/glsl/opt_copy_propagation.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/opt_copy_propagatio

Re: [Mesa-dev] [PATCH] clover: Pass unquoted compiler arguments to Clang

2016-06-04 Thread Francisco Jerez
Vedran Miletić writes: > OpenCL apps can quote arguments they pass to the OpenCL compiler, most > commonly include paths containing spaces. If the OpenCL compiler was > called via a shell, the shell would remove (single or double) quotes > before passing the argument to the compiler. Since we cal