Re: [Mesa-dev] [PATCH 2/5] glsl: Optionally lower TES gl_PatchVerticesIn to a uniform.

2016-06-09 Thread Alejandro Piñeiro
On 09/06/16 05:50, Kenneth Graunke wrote: > On Wednesday, June 8, 2016 7:45:16 PM PDT Alejandro Piñeiro wrote: >> On 02/06/16 23:09, Kenneth Graunke wrote: >>> i965 has no special hardware for this, so we need to pass this value in >>> as a uniform (unless the TES is linked against a TCS, in which

Re: [Mesa-dev] [PATCH 4/5] glsl: Optionally lower TCS gl_PatchVerticesIn to a uniform.

2016-06-09 Thread Alejandro Piñeiro
On 09/06/16 05:44, Kenneth Graunke wrote: > On Wednesday, June 8, 2016 7:45:43 PM PDT Alejandro Piñeiro wrote: >> On 02/06/16 23:09, Kenneth Graunke wrote: >>> i965 has no special hardware for this, so the best way to implement >>> this is to pass it in via a uniform. >> Is this comment accurate? O

Re: [Mesa-dev] [PATCH 4/5] glsl: Optionally lower TCS gl_PatchVerticesIn to a uniform.

2016-06-09 Thread Alejandro Piñeiro
Assuming that you are sure about Ian's doubt: Reviewed-by: Alejandro Piñeiro On 02/06/16 23:09, Kenneth Graunke wrote: > i965 has no special hardware for this, so the best way to implement > this is to pass it in via a uniform. > > Signed-off-by: Kenneth Graunke > Cc: mesa-sta...@lists.freedesk

Re: [Mesa-dev] [PATCH 5/5] i965: Use a uniform for gl_PatchVerticesIn in the TCS on Gen8+.

2016-06-09 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 02/06/16 23:09, Kenneth Graunke wrote: > We still need to recompile the passthrough shader when this value > changes, as it also affects the output vertex count. But otherwise, > we can eliminate recompiles on Gen8+. > > We probably want to do this for Gen7 as w

[Mesa-dev] [PATCH 3/3] i965: Use the correct number of threads for compute shaders.

2016-06-09 Thread Kenneth Graunke
We were programming the number of threads per subslice, when we should have been programming the total number of threads on the GPU as a whole. Thanks to Curro and Jordan for helping track this down! On Skylake GT3e: - Improves performance in Unreal's Elemental Demo by roughly 1.5-1.7x. - Improve

[Mesa-dev] [PATCH 1/3] i965: Fix shared local memory size for Gen9+.

2016-06-09 Thread Kenneth Graunke
Skylake changes the representation of shared local memory size: Size | 0 kB | 1 kB | 2 kB | 4 kB | 8 kB | 16 kB | 32 kB | 64 kB | --- Gen7-8 |0 | none | none |1 |2 | 3 | 4 | 5 | --

[Mesa-dev] [PATCH 2/3] i965: Set subslice_total on Haswell.

2016-06-09 Thread Kenneth Graunke
We'll use this for compute shader thread counts shortly. Cc: "12.0" Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/intel_screen.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) I'm not sure whether I want to commit this or not...there still seem to be some issues on Ha

Re: [Mesa-dev] [PATCH] st/dri: Clear drawable texture_mask in dri2_invalidate_drawable

2016-06-09 Thread Nicolai Hähnle
Looks reasonable. Reviewed-by: Nicolai Hähnle On 09.06.2016 08:44, Michel Dänzer wrote: From: Michel Dänzer This makes sure that dri_set_tex_buffer2 -> dri_drawable_validate_att will re-create the front left attachment buffer after the drawable got invalidated. Fixes window contents not upd

[Mesa-dev] llvmpipe FMA

2016-06-09 Thread Jose Fonseca
This is a short patch series I wrote many weekends ago to leverage FMA3 instructions in llvmpipe where available This was done with Roland's assistence on spare time and has been reviewed by him already. I'm sending it mostly just a heads up for other developers out there, just in case it interfe

[Mesa-dev] [PATCH 1/2] util, gallivm: Explicitly enable/disable fma attribute.

2016-06-09 Thread Jose Fonseca
As suggested by Roland Scheidegger. Use the same logic as f16c, since fma requires VEX encoding. But disable FMA on LLVM 3.3 without MCJIT. Reviewed-by: Roland Scheidegger --- src/gallium/auxiliary/gallivm/lp_bld_init.c | 2 ++ src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 9 + src

[Mesa-dev] [PATCH 2/2] gallivm: Use llvm.fmuladd.*.

2016-06-09 Thread Jose Fonseca
Reviewed-by: Roland Scheidegger --- src/gallium/auxiliary/draw/draw_llvm.c | 15 ++-- src/gallium/auxiliary/gallivm/lp_bld_arit.c| 90 +- src/gallium/auxiliary/gallivm/lp_bld_arit.h| 15 src/gallium/auxiliary/gallivm/lp_bld_format_srgb.c | 3 +

Re: [Mesa-dev] [PATCH 13/15] st/mesa: use c99 initializer for st_gl_api

2016-06-09 Thread Marek Olšák
I think you need VMWare's permission to push this, as it depends on what MSVC can do. Marek On Tue, Jun 7, 2016 at 6:33 PM, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov > --- > src/mesa/state_tracker/st_manager.c | 26 +- > 1 file changed, 1

Re: [Mesa-dev] [rfc] ARB_gpu_shader_int64 support (softpipe/llvmpipe)

2016-06-09 Thread Marek Olšák
I'd prefer a normal pipe cap instead of per shader. Marek On Jun 9, 2016 6:03 AM, "Dave Airlie" wrote: > On 9 June 2016 at 10:48, Dave Airlie wrote: > > I started this quite a while back, and decided to spend some > > time on it again, since it's the basis for a bunch of the newer > > GL extens

Re: [Mesa-dev] [PATCH] st/dri: Clear drawable texture_mask in dri2_invalidate_drawable

2016-06-09 Thread Marek Olšák
Reviewed-by: Marek Olšák On Jun 9, 2016 10:26 AM, "Nicolai Hähnle" wrote: > Looks reasonable. > > Reviewed-by: Nicolai Hähnle > > On 09.06.2016 08:44, Michel Dänzer wrote: > >> From: Michel Dänzer >> >> This makes sure that dri_set_tex_buffer2 -> dri_drawable_validate_att >> will re-create the

[Mesa-dev] [PATCH 1/2] vl: support luma keying for interlaced surfaces as well

2016-06-09 Thread Christian König
From: Christian König We had the CSC code twice in there, factor it out into a separate function. Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_compositor.c | 76 +--- 1 file changed, 41 insertions(+), 35 deletions(-) diff --git a/src/gallium/auxil

[Mesa-dev] [PATCH 2/2] st/vdpau: we support lumakeying now

2016-06-09 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/vdpau/query.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/vdpau/query.c b/src/gallium/state_trackers/vdpau/query.c index a279ad3..912bf97 100644 --- a/src/gallium/state_tracke

[Mesa-dev] Two luma keying follow ups

2016-06-09 Thread Christian König
Hi guys, Two minor things I've noticed after pushing the original patches. The first one is that we only changed the function for progressive frames in the compositor. Add luma keying for interlaced frames as well. The second issue is that we have forgotten to claim support for lumakeying now.

[Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch (in src/gallium/drivers/nouveau/codegen/)

2016-06-09 Thread Stephan Bergmann
see attached 0001-Avoid-ASan-new-delete-type-mismatch.patch >From 653d9da624c56fab05ed568133f30640b9e75b4f Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Thu, 9 Jun 2016 15:21:46 +0200 Subject: [PATCH] Avoid ASan new-delete-type-mismatch ...when Function::domTree is created as DominatorTr

Re: [Mesa-dev] [PATCH] st/dri: Clear drawable texture_mask in dri2_invalidate_drawable

2016-06-09 Thread Alex Deucher
On Thu, Jun 9, 2016 at 2:44 AM, Michel Dänzer wrote: > From: Michel Dänzer > > This makes sure that dri_set_tex_buffer2 -> dri_drawable_validate_att > will re-create the front left attachment buffer after the drawable got > invalidated. > > Fixes window contents not updating until the window is r

Re: [Mesa-dev] [PATCH 1/3] i965: Fix shared local memory size for Gen9+.

2016-06-09 Thread Ilia Mirkin
On Jun 9, 2016 4:10 AM, "Kenneth Graunke" wrote: > > Skylake changes the representation of shared local memory size: > > Size | 0 kB | 1 kB | 2 kB | 4 kB | 8 kB | 16 kB | 32 kB | 64 kB | > --- > Gen7-8 |0 | none | none |1

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch (in src/gallium/drivers/nouveau/codegen/)

2016-06-09 Thread Ilia Mirkin
Please send the patch inline, and in such a way that I'll be able to apply it with git am. Git send-email does the right thing, FYI. On Jun 9, 2016 9:26 AM, "Stephan Bergmann" wrote: > see attached 0001-Avoid-ASan-new-delete-type-mismatch.patch > > ___

Re: [Mesa-dev] [PATCH 13/15] st/mesa: use c99 initializer for st_gl_api

2016-06-09 Thread Emil Velikov
On 9 June 2016 at 11:50, Marek Olšák wrote: > I think you need VMWare's permission to push this, as it depends on > what MSVC can do. > I believe that this shouldn't be an issue as of commit 1cadfe08c4109d2c117cbae2c82edee1293a8016 Author: Jose Fonseca Date: Thu Feb 11 11:07:33 2016 +

Re: [Mesa-dev] [PATCH 13/15] st/mesa: use c99 initializer for st_gl_api

2016-06-09 Thread Brian Paul
Named initializers are OK with MSVC 2013 so this should be fine. -Brian On 06/09/2016 04:50 AM, Marek Olšák wrote: I think you need VMWare's permission to push this, as it depends on what MSVC can do. Marek On Tue, Jun 7, 2016 at 6:33 PM, Emil Velikov wrote: From: Emil Velikov Signed-of

Re: [Mesa-dev] [PATCH 05/23] mesa: add support for 64-bit integer uniforms.

2016-06-09 Thread Brian Paul
On 06/08/2016 06:48 PM, Dave Airlie wrote: From: Dave Airlie This hooks up the API to the internals for 64-bit integer uniforms. Signed-off-by: Dave Airlie --- src/mesa/main/uniform_query.cpp | 60 +- src/mesa/main/uniforms.c| 170 ++

Re: [Mesa-dev] [PATCH 1/3] i965: Fix shared local memory size for Gen9+.

2016-06-09 Thread Jason Ekstrand
On Jun 9, 2016 1:10 AM, "Kenneth Graunke" wrote: > > Skylake changes the representation of shared local memory size: > > Size | 0 kB | 1 kB | 2 kB | 4 kB | 8 kB | 16 kB | 32 kB | 64 kB | > --- > Gen7-8 |0 | none | none |1

Re: [Mesa-dev] [PATCH 19/23] gallium/tgsi: add support for 64-bit integer immediates.

2016-06-09 Thread Brian Paul
On 06/08/2016 06:48 PM, Dave Airlie wrote: From: Dave Airlie This adds support to TGSI for 64-bit integer immediates. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_dump.c | 14 ++ src/gallium/auxiliary/tgsi/tgsi_exec.c | 244 - src/gal

Re: [Mesa-dev] [PATCH 1/3] i965: Fix shared local memory size for Gen9+.

2016-06-09 Thread Jason Ekstrand
Another comment: Please fix Vulkan while you're at it. I don't want to have to debug this twice. On Jun 9, 2016 1:10 AM, "Kenneth Graunke" wrote: > Skylake changes the representation of shared local memory size: > > Size | 0 kB | 1 kB | 2 kB | 4 kB | 8 kB | 16 kB | 32 kB | 64 kB | >

[Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

2016-06-09 Thread Stephan Bergmann
...when Function::domTree is created as DominatorTree in Function::convertToSSA (src/gallium/drivers/nouveau/codegen/nv50_ir_ssa.cpp) but destroyed only as base Graph in ~Function (src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp). --- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 37

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

2016-06-09 Thread Ilia Mirkin
Is this all because Graph doesn't have a virtual destructor? We don't construct/destruct those too often, I'd much rather just make it virtual rather than moving DominatorTree. On Thu, Jun 9, 2016 at 10:52 AM, Stephan Bergmann wrote: > ...when Function::domTree is created as DominatorTree in > F

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

2016-06-09 Thread Stephan Bergmann
On 06/09/2016 05:01 PM, Ilia Mirkin wrote: Is this all because Graph doesn't have a virtual destructor? We don't construct/destruct those too often, I'd much rather just make it virtual rather than moving DominatorTree. Yes, that of course also works. Corresponding patch coming. __

Re: [Mesa-dev] [PATCH 18/23] gallium: add opcode and types for 64-bit integers.

2016-06-09 Thread Roland Scheidegger
Am 09.06.2016 um 02:48 schrieb Dave Airlie: > From: Dave Airlie > > This just adds the basic support for 64-bit opcodes, > and the new types. > > Signed-off-by: Dave Airlie > --- > src/gallium/auxiliary/tgsi/tgsi_info.c | 54 > ++ > src/gallium/auxiliary/tgsi/t

Re: [Mesa-dev] [PATCH 0/2] Move u_bit_scan from gallium to util.

2016-06-09 Thread Brian Paul
On 06/08/2016 11:03 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi all, I just put the two leading patches to move u_bit_scan from gallium to util. The architecture handling of ffs{,ll} is merged with what is available in the mesa/util directory. It compiles and works here and

Re: [Mesa-dev] [PATCH 19/23] gallium/tgsi: add support for 64-bit integer immediates.

2016-06-09 Thread Roland Scheidegger
Am 09.06.2016 um 16:43 schrieb Brian Paul: > On 06/08/2016 06:48 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> This adds support to TGSI for 64-bit integer immediates. >> >> Signed-off-by: Dave Airlie >> --- >> src/gallium/auxiliary/tgsi/tgsi_dump.c | 14 ++ >> src/gallium/auxiliary/t

Re: [Mesa-dev] [PATCH] i965/gen9: Don't change halign and valign to fit in fast copy blit

2016-06-09 Thread Ben Widawsky
On Wed, Jun 08, 2016 at 11:28:12AM -0700, Anuj Phogat wrote: > An update in graphics specs has deleted the halign and valign fields > from XY_FAST_COPY_BLT command. See mesa commit 97f0f91. > > Cc: Ben Widawsky > Signed-off-by: Anuj Phogat Reviewed-by: Ben Widawsky > --- > src/mesa/drivers/dr

[Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

2016-06-09 Thread Stephan Bergmann
...when Function::domTree is created as DominatorTree in Function::convertToSSA (src/gallium/drivers/nouveau/codegen/nv50_ir_ssa.cpp) but destroyed only as base Graph in ~Function (src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp). --- src/gallium/drivers/nouveau/codegen/nv50_ir_graph.h | 2 +-

[Mesa-dev] [PATCH v3] radeonsi: Reinitialize all descriptors in CE preamble.

2016-06-09 Thread Bas Nieuwenhuizen
This fixes a problem with the CE preamble and restoring only stuff in the preamble when needed. To illustrate suppose we have two graphics IB's 1 and 2, which are submitted in that order. Furthermore suppose IB 1 does not use CE ram, but IB 2 does, and we have a context switch at the start of IB

Re: [Mesa-dev] [PATCH 1/3] i965: Fix shared local memory size for Gen9+.

2016-06-09 Thread Kenneth Graunke
On Thursday, June 9, 2016 10:00:40 AM PDT Ilia Mirkin wrote: > On Jun 9, 2016 4:10 AM, "Kenneth Graunke" wrote: > > > > Skylake changes the representation of shared local memory size: > > > > Size | 0 kB | 1 kB | 2 kB | 4 kB | 8 kB | 16 kB | 32 kB | 64 kB | > >

Re: [Mesa-dev] [PATCH 1/3] i965: Fix shared local memory size for Gen9+.

2016-06-09 Thread Kenneth Graunke
On Thursday, June 9, 2016 10:50:53 AM PDT Kenneth Graunke wrote: > On Thursday, June 9, 2016 10:00:40 AM PDT Ilia Mirkin wrote: > > On Jun 9, 2016 4:10 AM, "Kenneth Graunke" wrote: > > > > > > Skylake changes the representation of shared local memory size: > > > > > > Size | 0 kB | 1 kB | 2 kB

Re: [Mesa-dev] prep work for 64-bit integer support

2016-06-09 Thread Ian Romanick
On 06/08/2016 02:15 PM, Dave Airlie wrote: > While writing ARB_gpu_shader_int64 I realised I needed to change > a lot of existing checks for doubles to 64bit, so I decided to > do that as much in advance as possible. I didn't know you were working on that. I just started poking at more general si

Re: [Mesa-dev] [PATCH 0/2] Move u_bit_scan from gallium to util.

2016-06-09 Thread Brian Paul
On 06/09/2016 09:35 AM, Brian Paul wrote: On 06/08/2016 11:03 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi all, I just put the two leading patches to move u_bit_scan from gallium to util. The architecture handling of ffs{,ll} is merged with what is available in the mesa/util

Re: [Mesa-dev] [PATCH] automake: get in-tree `make distclean' working again.

2016-06-09 Thread Emil Velikov
On 8 June 2016 at 16:23, Eric Engestrom wrote: > On Wed, Jun 08, 2016 at 03:44:39PM +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> With earlier commit we've handled the `make distclean' out of tree >> build, yet we failed to attribute that for in-tree builds the test >> condition will ret

Re: [Mesa-dev] prep work for 64-bit integer support

2016-06-09 Thread Ilia Mirkin
On Thu, Jun 9, 2016 at 2:07 PM, Ian Romanick wrote: > On 06/08/2016 02:15 PM, Dave Airlie wrote: >> While writing ARB_gpu_shader_int64 I realised I needed to change >> a lot of existing checks for doubles to 64bit, so I decided to >> do that as much in advance as possible. > > I didn't know you we

Re: [Mesa-dev] [PATCH 01/23] mapi: add support for ARB_gpu_shader_int64.

2016-06-09 Thread Ian Romanick
As far as I can tell, ARB_gpu_shader_int64 and AMD_gpu_shader_int64 are, excluding naming differences, identical. I think we should just expose both. On 06/08/2016 05:48 PM, Dave Airlie wrote: > From: Dave Airlie > > Just add the boilerplate xml code. > > Signed-off-by: Dave Airlie > --- > s

Re: [Mesa-dev] [PATCH 0/2] Move u_bit_scan from gallium to util.

2016-06-09 Thread Brian Paul
On 06/09/2016 12:10 PM, Brian Paul wrote: On 06/09/2016 09:35 AM, Brian Paul wrote: On 06/08/2016 11:03 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi all, I just put the two leading patches to move u_bit_scan from gallium to util. The architecture handling of ffs{,ll} is mer

Re: [Mesa-dev] [PATCH 19/23] gallium/tgsi: add support for 64-bit integer immediates.

2016-06-09 Thread Marek Olšák
On Thu, Jun 9, 2016 at 4:43 PM, Brian Paul wrote: > On 06/08/2016 06:48 PM, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This adds support to TGSI for 64-bit integer immediates. >> >> Signed-off-by: Dave Airlie >> --- >> src/gallium/auxiliary/tgsi/tgsi_dump.c | 14 ++ >> src/gallium/

Re: [Mesa-dev] [PATCH 19/23] gallium/tgsi: add support for 64-bit integer immediates.

2016-06-09 Thread Ilia Mirkin
On Thu, Jun 9, 2016 at 2:41 PM, Marek Olšák wrote: > On Thu, Jun 9, 2016 at 4:43 PM, Brian Paul wrote: >> On 06/08/2016 06:48 PM, Dave Airlie wrote: >>> >>> From: Dave Airlie >>> >>> This adds support to TGSI for 64-bit integer immediates. >>> >>> Signed-off-by: Dave Airlie >>> --- >>> src/ga

Re: [Mesa-dev] [PATCH 04/23] glsl: add basic arb_gpu_shader_int64 types

2016-06-09 Thread Ian Romanick
On 06/08/2016 05:48 PM, Dave Airlie wrote: > From: Dave Airlie > > This adds the builtins and the lexer support. > > To avoid too many warnings, it adds basic > support to the type in a few other places > in mesa, mostly in the trivial places. > > It also adds a query to be used later for > if

Re: [Mesa-dev] [PATCH 09/23] glsl/ir: add support for 64-bit integer conversions.

2016-06-09 Thread Ian Romanick
On 06/08/2016 05:48 PM, Dave Airlie wrote: > From: Dave Airlie > > This adds all the conversions in the world, I'm not 100% > sure of all of these are needed, but add all of them and > we can cut them down later. I think we'll probably need them all. A couple of trivial comments below. With th

Re: [Mesa-dev] [PATCH 10/23] glsl: add 64-bit integer support for constant expressions

2016-06-09 Thread Ian Romanick
On 06/08/2016 05:48 PM, Dave Airlie wrote: > From: Dave Airlie > > This just adds the new operations and add 64-bit integer > support to all the existing cases where it is needed. > > Signed-off-by: Dave Airlie There's a bunch of mixed tabs-and-spaces below. > --- > src/compiler/glsl/ir_cons

[Mesa-dev] [PATCH 2/2] vl/dri3: support receiving new pixmap for front buffer

2016-06-09 Thread Leo Liu
With gstreamer-vaapi, the temporay pixmap for front buffer got realloc each time, so when we receive a new pixmap for each frame, get a new front buffer for it. This also fix Totem player playback corruption. Signed-off-by: Leo Liu Cc: "12.0" --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 7 +

[Mesa-dev] [PATCH 1/2] vl/dri3: get Makefile properly

2016-06-09 Thread Leo Liu
in order to accommodate scons build Signed-off-by: Leo Liu Cc: "12.0" --- src/gallium/auxiliary/Makefile.am | 7 +++ src/gallium/auxiliary/Makefile.sources| 4 +++- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 4 3 files changed, 10 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [AppVeyor] mesa master #1560 failed

2016-06-09 Thread AppVeyor
Build mesa 1560 failed Commit 5e2d25894b by Samuel Pitoiset on 5/25/2016 7:17 PM: mesa: Let compute shaders work in compatibility profiles\n\nThe extension is already advertised in compatibility profile, but\nthe _mesa_has_compute_shaders only returns true in c

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: don't validate pipeline in GL debug contexts

2016-06-09 Thread Ilia Mirkin
On Sat, Jun 4, 2016 at 3:44 PM, Ilia Mirkin wrote: > On Sat, Jun 4, 2016 at 3:36 PM, Ian Romanick wrote: >> How about if you give me a chance to actually fix the problem instead of >> papering over it? > > That sounds fine too. It's causing real problems for debugging right > now though (glretrac

Re: [Mesa-dev] prep work for 64-bit integer support

2016-06-09 Thread Ian Romanick
On 06/09/2016 11:26 AM, Ilia Mirkin wrote: > On Thu, Jun 9, 2016 at 2:07 PM, Ian Romanick wrote: >> On 06/08/2016 02:15 PM, Dave Airlie wrote: >>> While writing ARB_gpu_shader_int64 I realised I needed to change >>> a lot of existing checks for doubles to 64bit, so I decided to >>> do that as much

Re: [Mesa-dev] prep work for 64-bit integer support

2016-06-09 Thread Ilia Mirkin
On Thu, Jun 9, 2016 at 4:11 PM, Ian Romanick wrote: > On 06/09/2016 11:26 AM, Ilia Mirkin wrote: >> On Thu, Jun 9, 2016 at 2:07 PM, Ian Romanick wrote: >>> On 06/08/2016 02:15 PM, Dave Airlie wrote: While writing ARB_gpu_shader_int64 I realised I needed to change a lot of existing check

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] i965: Set subslice_total on Haswell.

2016-06-09 Thread Francisco Jerez
Kenneth Graunke writes: > We'll use this for compute shader thread counts shortly. > > Cc: "12.0" > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/intel_screen.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > I'm not sure whether I want to commit this or not.

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] i965: Use the correct number of threads for compute shaders.

2016-06-09 Thread Francisco Jerez
Kenneth Graunke writes: > We were programming the number of threads per subslice, when we should > have been programming the total number of threads on the GPU as a whole. > > Thanks to Curro and Jordan for helping track this down! > > On Skylake GT3e: > - Improves performance in Unreal's Element

Re: [Mesa-dev] [PATCH 19/23] gallium/tgsi: add support for 64-bit integer immediates.

2016-06-09 Thread Dave Airlie
> I haven't been following the 'double' work so dumb questions/comments: > > First, could you document the new opcodes in gallium/docs/source/tgsi.rst? Yup already done in my tree. > > In the case of micro_u64seq(), etc. why doesn't it do > > dst->u64[0] = src[0].u64[0] == src[1].u64[0] ? ~0UL :

Re: [Mesa-dev] [PATCH] isl: Replace bash generator with python generator

2016-06-09 Thread Dylan Baker
Emil, should this take an argument, or is it fine as is? I was going to ask Matt, but he's on vacation... Dylan signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo

Re: [Mesa-dev] [PATCH] isl: Replace bash generator with python generator

2016-06-09 Thread Emil Velikov
On 9 June 2016 at 21:56, Dylan Baker wrote: > Emil, should this take an argument, or is it fine as is? I was going to > ask Matt, but he's on vacation... > As Jason, suggested - it's better if the build provides the output filename. Can we please do that ? IIRC some of the existing python scripts

Re: [Mesa-dev] prep work for 64-bit integer support

2016-06-09 Thread Marek Olšák
On Thu, Jun 9, 2016 at 10:28 PM, Ilia Mirkin wrote: > On Thu, Jun 9, 2016 at 4:11 PM, Ian Romanick wrote: >> On 06/09/2016 11:26 AM, Ilia Mirkin wrote: >>> On Thu, Jun 9, 2016 at 2:07 PM, Ian Romanick wrote: On 06/08/2016 02:15 PM, Dave Airlie wrote: > While writing ARB_gpu_shader_int64

Re: [Mesa-dev] [PATCH] isl: Replace bash generator with python generator

2016-06-09 Thread Dylan Baker
Quoting Emil Velikov (2016-06-09 14:12:46) > On 9 June 2016 at 21:56, Dylan Baker wrote: > > Emil, should this take an argument, or is it fine as is? I was going to > > ask Matt, but he's on vacation... > > > As Jason, suggested - it's better if the build provides the output > filename. Can we ple

Re: [Mesa-dev] [PATCH] nv50: reinstate dedicated constbuf push path

2016-06-09 Thread Samuel Pitoiset
The logic sounds quite familiar to nvc0 as you said. :) I have just started a full piglit run with this patch applied. On 06/06/2016 01:07 AM, Ilia Mirkin wrote: This was disabled due to occasionally incorrect behavior when trying to upload data. It later became apparent that nvc0 also had a si

Re: [Mesa-dev] Mesa (master): mesa: Let compute shaders work in compatibility profiles

2016-06-09 Thread Brian Paul
This change seems to have broke the Windows build. I'm digging into it... -Brian On 06/09/2016 01:10 PM, Samuel Pitoiset wrote: Module: Mesa Branch: master Commit: 5e2d25894b962aae9158261897e13843377e3b95 URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_m

Re: [Mesa-dev] [PATCH] isl: Replace bash generator with python generator

2016-06-09 Thread Dylan Baker
Quoting Dylan Baker (2016-06-09 15:06:42) > Quoting Emil Velikov (2016-06-09 14:12:46) > > On 9 June 2016 at 21:56, Dylan Baker wrote: > > > Emil, should this take an argument, or is it fine as is? I was going to > > > ask Matt, but he's on vacation... > > > > > As Jason, suggested - it's better i

Re: [Mesa-dev] Mesa (master): mesa: Let compute shaders work in compatibility profiles

2016-06-09 Thread Samuel Pitoiset
On 06/10/2016 12:21 AM, Brian Paul wrote: This change seems to have broke the Windows build. I'm digging into it... mmh, I saw the AppVeyor notification but usually it seems to be unreliable. Let me know what's going on, thanks. -Brian On 06/09/2016 01:10 PM, Samuel Pitoiset wrote: M

[Mesa-dev] [PATCH 2/2] gallivm: Fix trivial sign warnings

2016-06-09 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/auxiliary/gallivm/lp_bld_conv.c | 4 ++-- src/gallium/auxiliary/gallivm/lp_bld_logic.c| 10 ++ src/gallium/auxiliary/gallivm/lp_bld_pack.c | 2 +- src/gallium/auxiliary/gallivm/lp_bld_printf.c | 7 +++ src/gallium/auxiliary/ga

[Mesa-dev] [PATCH 1/2] vl: Fix trivial sign compare warnings

2016-06-09 Thread Jan Vesely
Signed-off-by: Jan Vesely --- src/gallium/auxiliary/vl/vl_deint_filter.c | 3 ++- src/gallium/auxiliary/vl/vl_idct.c | 3 ++- src/gallium/auxiliary/vl/vl_matrix_filter.c| 2 +- src/gallium/auxiliary/vl/vl_median_filter.c| 5 +++-- src/gallium/auxiliary/vl/vl_mpeg12_bitstre

Re: [Mesa-dev] Mesa (master): mesa: Let compute shaders work in compatibility profiles

2016-06-09 Thread Brian Paul
Some sort of linker error. The appveyor pages shows the details. I still haven't figured it out. -Brian On 06/09/2016 04:28 PM, Samuel Pitoiset wrote: On 06/10/2016 12:21 AM, Brian Paul wrote: This change seems to have broke the Windows build. I'm digging into it... mmh, I saw the AppV

Re: [Mesa-dev] [PATCH] nv50: reinstate dedicated constbuf push path

2016-06-09 Thread Samuel Pitoiset
At least, piglit is happy with your patch, go ahead. Reviewed-by: Samuel Pitoiset On 06/10/2016 12:13 AM, Samuel Pitoiset wrote: The logic sounds quite familiar to nvc0 as you said. :) I have just started a full piglit run with this patch applied. On 06/06/2016 01:07 AM, Ilia Mirkin wrote:

Re: [Mesa-dev] Mesa (master): mesa: Let compute shaders work in compatibility profiles

2016-06-09 Thread Nanley Chery
On Thu, Jun 09, 2016 at 04:41:36PM -0600, Brian Paul wrote: > Some sort of linker error. The appveyor pages shows the details. I still > haven't figured it out. > I wrote a patch sometime ago that changes the macro to avoid referencing the table. I can send it out to the list if you'd like. -

[Mesa-dev] [PATCH] fixup!: isl: Replace bash generator with python generator

2016-06-09 Thread Emil Velikov
Android build + shipt the correct files in the tarball. --- Untested, but I'm 90% sure that it'll do. src/intel/isl/Android.mk | 7 --- src/intel/isl/Makefile.am | 3 ++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/intel/isl/Android.mk b/src/intel/isl/Android.mk index

Re: [Mesa-dev] [PATCH 1/2] vl: Fix trivial sign compare warnings

2016-06-09 Thread Emil Velikov
Hi Jan, Can I bother you with a couple of related fixes while you're touching these lines ? On 9 June 2016 at 23:40, Jan Vesely wrote: > @@ -327,7 +327,8 @@ create_stage1_frag_shader(struct vl_idct *idct) > struct ureg_dst l[4][2], r[2]; > struct ureg_dst *fragment; > > - int i, j; Ki

Re: [Mesa-dev] [PATCH 12/15] gallium: remove st_api::get_proc_address hook

2016-06-09 Thread Emil Velikov
On 7 June 2016 at 17:33, Emil Velikov wrote: > From: Emil Velikov > > It has been unused for a long time, plus makes the gallium dri modules > require an extra glapi symbol relative to their classic counterparts. > > Signed-off-by: Emil Velikov > --- > We can keep the hook, if other (non-public)

Re: [Mesa-dev] [PATCH 1/2] vl/dri3: get Makefile properly

2016-06-09 Thread Emil Velikov
Hi Leo, On 9 June 2016 at 20:11, Leo Liu wrote: > in order to accommodate scons build > IIRC Jose fixed the SCons build (Makefile.sources actually) a while back. One do does not build any of VL with scons so I'm not sure what you with with "accommodate" here. Can you please elaborate ? Thanks Em

Re: [Mesa-dev] [PATCH 1/2] mesa: Fix region overlap conditions for rectangles with a shared edge

2016-06-09 Thread Anuj Phogat
On Fri, Dec 11, 2015 at 2:41 PM, Anuj Phogat wrote: > From OpenGL 4.0 spec, section 4.3.2 "Copying Pixels": > "The pixels corresponding to these buffers are copied from the source > rectangle bounded by the locations (srcX0, srcY 0) and (srcX1, srcY 1) > to the destination rectangle bounded by t

Re: [Mesa-dev] [PATCH 2/2] Android: move libdrm settings to top-level Android.common.mk

2016-06-09 Thread Emil Velikov
Hi Rob, On 8 June 2016 at 00:27, Rob Herring wrote: > Fix warnings like these due to HAVE_LIBDRM being inconsistently defined: > > external/libdrm/include/drm/drm.h:839:30: warning: redefinition of typedef > 'drm_clip_rect_t' is a C11 feature [-Wtypedef-redefinition] > typedef struct drm_clip_re

Re: [Mesa-dev] [PATCH 1/2] vl/dri3: get Makefile properly

2016-06-09 Thread Leo Liu
On 06/09/2016 07:13 PM, Emil Velikov wrote: Hi Leo, On 9 June 2016 at 20:11, Leo Liu wrote: in order to accommodate scons build IIRC Jose fixed the SCons build (Makefile.sources actually) a while back. One do does not build any of VL with scons so I'm not sure what you with with "accommoda

Re: [Mesa-dev] [PATCH 12/15] gallium: remove st_api::get_proc_address hook

2016-06-09 Thread Brian Paul
On 06/09/2016 05:10 PM, Emil Velikov wrote: On 7 June 2016 at 17:33, Emil Velikov wrote: From: Emil Velikov It has been unused for a long time, plus makes the gallium dri modules require an extra glapi symbol relative to their classic counterparts. Signed-off-by: Emil Velikov --- We can kee

Re: [Mesa-dev] [PATCH 1/2] vl/dri3: get Makefile properly

2016-06-09 Thread Emil Velikov
On 10 June 2016 at 00:25, Leo Liu wrote: > Jose was suggesting two approaches to fix scons build, he did a very quick > fix back then with the second approach. > The patch here is his first approach, and I think this is more proper. > Personally I'm fine with either approach. If you prefer this o

[Mesa-dev] [PATCH] glsl/ir: remove TABs in ir_constant_expression.cpp

2016-06-09 Thread Dave Airlie
From: Dave Airlie Adding 64-bit integers support was going to make this file worse, just remove the tabs from it now. Signed-off-by: Dave Airlie --- src/compiler/glsl/ir_constant_expression.cpp | 1070 +- 1 file changed, 535 insertions(+), 535 deletions(-) diff --git a

Re: [Mesa-dev] [PATCH] glsl/ir: remove TABs in ir_constant_expression.cpp

2016-06-09 Thread Timothy Arceri
On Fri, 2016-06-10 at 10:00 +1000, Dave Airlie wrote: > From: Dave Airlie > > Adding 64-bit integers support was going to make this file worse, > just remove the tabs from it now. > > Signed-off-by: Dave Airlie Skimmed over it seems fine Acked-by: Timothy Arceri > --- >  src/compiler/glsl/i

[Mesa-dev] [PATCH v2] isl: Replace bash generator with python generator

2016-06-09 Thread Dylan Baker
This replaces the current bash generator with a python based generator using mako. It's quite fast and works with both python 2.7 and python 3.5, and should work with 3.3+ and maybe even 3.2. It produces an almost identical file except for a minor layout changes, and the addition of a "generated f

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Ilia Mirkin
On Wed, Jun 8, 2016 at 5:48 PM, Fredrik Höglund wrote: > On Wednesday 08 June 2016, Ilia Mirkin wrote: >> Glancing at the code (I don't even have a piglit checkout here): >> >> static void >> set_ubo_binding(struct gl_context *ctx, ...) >> ... >>/* If this is a real buffer object, mark it has

[Mesa-dev] [PATCH 4/4] radeonsi: convert to 64-bitness checks instead of doubles.

2016-06-09 Thread Dave Airlie
From: Dave Airlie This converts to testing for 64-bit types and renames some things in anticipation of 64-bit integer support. Signed-off-by: Dave Airlie --- src/gallium/drivers/radeon/radeon_llvm.h | 7 +++--- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 29 +++-

[Mesa-dev] gallium + radeonsi : 64-bit prep work

2016-06-09 Thread Dave Airlie
This is extracted from my 64-bit integer series and should be applied first, it just cleans up the 64-bit type checking. It adds a new macro, the cleans up gallivm and radeonsi to use it, along with cleaning up a few double specific things. Dave. ___ m

[Mesa-dev] [PATCH 2/4] gallium/gallivm: use 64-bit test instead of doubles.

2016-06-09 Thread Dave Airlie
From: Dave Airlie This just makes some generic code that currently emits double suitable for emitting 64-bit values. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 73 - 1 file changed, 36 insertions(+), 37 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 1/4] gallium/tgsi: add 64-bitness type check function.

2016-06-09 Thread Dave Airlie
From: Dave Airlie Currently this just doubles, but we'll convert users to this so making adding 64-bit integers easier. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_info.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_info.h b/src

[Mesa-dev] [PATCH 3/4] gallivm: make non-float return code bitcast consistent.

2016-06-09 Thread Dave Airlie
From: Dave Airlie This just uses the same form across the fetches. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/galli

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Ilia Mirkin
On Thu, Jun 9, 2016 at 9:07 PM, Ilia Mirkin wrote: > On Wed, Jun 8, 2016 at 5:48 PM, Fredrik Höglund wrote: >> On Wednesday 08 June 2016, Ilia Mirkin wrote: >>> Glancing at the code (I don't even have a piglit checkout here): >>> >>> static void >>> set_ubo_binding(struct gl_context *ctx, ...) >>

[Mesa-dev] [PATCH] gallivm: more 64-bit integer prep work.

2016-06-09 Thread Dave Airlie
From: Dave Airlie This converts one other place to using the new helper. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi.c b/src/gallium/au

Re: [Mesa-dev] [PATCH] st/dri: Clear drawable texture_mask in dri2_invalidate_drawable

2016-06-09 Thread Michel Dänzer
On 09.06.2016 22:39, Alex Deucher wrote: > On Thu, Jun 9, 2016 at 2:44 AM, Michel Dänzer wrote: >> From: Michel Dänzer >> >> This makes sure that dri_set_tex_buffer2 -> dri_drawable_validate_att >> will re-create the front left attachment buffer after the drawable got >> invalidated. >> >> Fixes

Re: [Mesa-dev] prep work for 64-bit integer support

2016-06-09 Thread Dave Airlie
>> >> I'm in no way opposed to having shareable "fudging" logic, so that it >> can be used by drivers with less sophisticated backends, or ones that >> are getting less development interest. Just want to make sure that a >> way to let the backend just deal with it remains. > > For r600, the lowerin

Re: [Mesa-dev] [PATCH 2/2] vl/dri3: support receiving new pixmap for front buffer

2016-06-09 Thread Michel Dänzer
On 10.06.2016 04:11, Leo Liu wrote: > With gstreamer-vaapi, the temporay pixmap for front buffer got realloc "gets reallocated"? > each time, so when we receive a new pixmap for each frame, get a new > front buffer for it. > > This also fix Totem player playback corruption. "fixes" > Signed-o

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Roland Scheidegger
Am 10.06.2016 um 03:11 schrieb Ilia Mirkin: > On Thu, Jun 9, 2016 at 9:07 PM, Ilia Mirkin wrote: >> On Wed, Jun 8, 2016 at 5:48 PM, Fredrik Höglund wrote: >>> On Wednesday 08 June 2016, Ilia Mirkin wrote: Glancing at the code (I don't even have a piglit checkout here): static void

[Mesa-dev] [PATCH v2 2/2] gallivm: Fix trivial sign warnings

2016-06-09 Thread Jan Vesely
From: Jan Vesely v2: include whitespace fixes Signed-off-by: Jan Vesely --- src/gallium/auxiliary/gallivm/lp_bld_conv.c | 4 ++-- src/gallium/auxiliary/gallivm/lp_bld_logic.c| 10 ++ src/gallium/auxiliary/gallivm/lp_bld_pack.c | 2 +- src/gallium/auxiliary/gallivm/lp_bld_

[Mesa-dev] [PATCH v2 1/2] vl: Fix trivial sign compare warnings

2016-06-09 Thread Jan Vesely
From: Jan Vesely v2: add whitepace fixes Signed-off-by: Jan Vesely --- src/gallium/auxiliary/vl/vl_deint_filter.c | 3 ++- src/gallium/auxiliary/vl/vl_idct.c | 6 ++ src/gallium/auxiliary/vl/vl_matrix_filter.c| 2 +- src/gallium/auxiliary/vl/vl_median_filter.c| 5 ++

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Roland Scheidegger
Am 10.06.2016 um 04:58 schrieb Roland Scheidegger: > Am 10.06.2016 um 03:11 schrieb Ilia Mirkin: >> On Thu, Jun 9, 2016 at 9:07 PM, Ilia Mirkin wrote: >>> On Wed, Jun 8, 2016 at 5:48 PM, Fredrik Höglund wrote: On Wednesday 08 June 2016, Ilia Mirkin wrote: > Glancing at the code (I don't

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Ilia Mirkin
On Thu, Jun 9, 2016 at 10:58 PM, Roland Scheidegger wrote: > Am 10.06.2016 um 03:11 schrieb Ilia Mirkin: >> On Thu, Jun 9, 2016 at 9:07 PM, Ilia Mirkin wrote: >>> On Wed, Jun 8, 2016 at 5:48 PM, Fredrik Höglund wrote: On Wednesday 08 June 2016, Ilia Mirkin wrote: > Glancing at the code

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-09 Thread Ilia Mirkin
On Thu, Jun 9, 2016 at 11:13 PM, Roland Scheidegger wrote: > Am 10.06.2016 um 04:58 schrieb Roland Scheidegger: >> Am 10.06.2016 um 03:11 schrieb Ilia Mirkin: >>> On Thu, Jun 9, 2016 at 9:07 PM, Ilia Mirkin wrote: On Wed, Jun 8, 2016 at 5:48 PM, Fredrik Höglund wrote: > On Wednesday 08

  1   2   >