Re: [Mesa-dev] [PATCH v2 22/34] i965/surface_state: Rename brw_update to gen4_update

On Thu, Jun 23, 2016 at 02:00:21PM -0700, Jason Ekstrand wrote: > We're about to add generic versions which work across gens and those should > have the brw name. > --- > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 22 +++--- > 1 file changed, 11 insertions(+), 11

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On Mon, Jun 27, 2016 at 6:08 PM, Samuel Pitoiset wrote: > > > On 06/28/2016 12:06 AM, Ilia Mirkin wrote: >> >> On Mon, Jun 27, 2016 at 6:05 PM, Ilia Mirkin wrote: >>> >>> On Mon, Jun 27, 2016 at 6:04 PM, Samuel Pitoiset >>>

Re: [Mesa-dev] [RFC] Coding style scripts (Was Re: [PATCH 1/2] gallium: replace [0-9]*.f with [0-9]*.0f)

On 27.06.2016 19:52, Jose Fonseca wrote: > > BTW, I've been using http://editorconfig.org/ on several projects. It's > widely supported by many editors including Emacs. > > There's even Python based tools to check editorconfig ( >

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

On Mon, Jun 27, 2016 at 6:30 PM, Gurchetan Singh wrote: > Hi Ilia, > > The changes for get.c where prompted by the es3fIntegerStateQueryTests (see > modules/gles3/functional/es3fIntegerStateQueryTests.cpp in the dEQP tree). > Specifically, these few lines: > >>> const

Re: [Mesa-dev] [PATCH] gm107/ir: make sure that flagsDef is set when emitting setcond

Reviewed-by: Ilia Mirkin Moderately sure this should work... On Mon, Jun 27, 2016 at 6:59 PM, Samuel Pitoiset wrote: > Rely on the existence of a second destination when emitting a setcond > flag is dangerous, because this doesn't mean that the

Re: [Mesa-dev] [PATCH] mesa/st: Include nir.h for nir_shader symbol.

On Mon, Jun 27, 2016 at 6:45 PM, Vinson Lee wrote: > Fix this build error with GCC 4.4. > > CC state_tracker/st_nir_lower_builtin.lo > In file included from state_tracker/st_nir_lower_builtin.c:61: > state_tracker/st_nir.h:34: error: redefinition of typedef

Re: [Mesa-dev] [PATCH 4/7] glsl: pass symbols to find_matching_signature() rather than shader

On Tue, 2016-06-28 at 11:52 +1000, Timothy Arceri wrote: > This will allow us to later split gl_shader into two structs. > --- >  src/compiler/glsl/link_functions.cpp | 47 +- > -- >  1 file changed, 22 insertions(+), 25 deletions(-) > > diff --git

[Mesa-dev] [PATCH 7/7] glsl/main: remove unused params and make function static

--- src/compiler/glsl/builtin_functions.cpp | 2 +- src/compiler/glsl/standalone_scaffolding.cpp | 4 +--- src/compiler/glsl/standalone_scaffolding.h | 2 +- src/mesa/drivers/common/meta.c | 2 +- src/mesa/main/ff_fragment_shader.cpp | 2 +- src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH 4/7] glsl: pass symbols to find_matching_signature() rather than shader

This will allow us to later split gl_shader into two structs. --- src/compiler/glsl/link_functions.cpp | 47 +--- 1 file changed, 22 insertions(+), 25 deletions(-) diff --git a/src/compiler/glsl/link_functions.cpp b/src/compiler/glsl/link_functions.cpp index

[Mesa-dev] [PATCH 5/7] glsl/mesa: split gl_shader in two

There are two distinctly different uses of this struct. The first is to store GL shader objects. The second is to store information about a shader stage thats been linked. The two uses actually share few fields and there is clearly confusion about their use. For example the linked shaders map one

[Mesa-dev] [PATCH 6/7] glsl: simplify link_uniform_blocks()

There is only ever one shader so simplify the input params. --- src/compiler/glsl/link_uniform_blocks.cpp | 7 ++- src/compiler/glsl/linker.cpp | 5 ++--- src/compiler/glsl/linker.h| 3 +-- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 3/7] glsl: pass symbols rather than shader to _mesa_get_main_function_signature()

This will allow us to split gl_shader into two different structs, one for shader objects and one for linked shaders. --- src/compiler/glsl/builtin_functions.cpp | 4 ++-- src/compiler/glsl/builtin_variables.cpp | 2 +- src/compiler/glsl/ir.h | 2 +- src/compiler/glsl/linker.cpp

[Mesa-dev] Split gl_shader in two and clean-ups

There are two distinctly different uses of this struct. The first is to store GL shader objects. The second is to store information about a shader stage thats been linked. The only place the new structs overlap is the shader layout fields and I intend to split that out into a third struct once

[Mesa-dev] [PATCH 2/7] mesa: don't use drivers NewShader function when creating shader objects

The drivers function only needs to be used when creating a struct for linked shaders. --- src/mesa/main/shaderapi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 07250cd..142e750 100644 ---

[Mesa-dev] [PATCH 1/7] glsl: make cross_validate_globals() more generic

Rather than passing in gl_shader we now pass in the IR. This will allow us to later split gl_shader into two structs. One for use as a linked per stage shader struct and one for use as a GL shader object. --- src/compiler/glsl/linker.cpp | 413 ++- 1 file

[Mesa-dev] [PATCH] mesa/st: Include nir.h for nir_shader symbol.

Fix this build error with GCC 4.4. CC state_tracker/st_nir_lower_builtin.lo In file included from state_tracker/st_nir_lower_builtin.c:61: state_tracker/st_nir.h:34: error: redefinition of typedef ‘nir_shader’ ../../src/compiler/nir/nir.h:1830: note: previous declaration of ‘nir_shader’

Re: [Mesa-dev] [PATCH 2/3] st/omx: add support for nouveau / interlaced

Hi Julien and Christian, I got a patch attached to fix the "fillout" problem, and please review. But we still need to fix transcoding issue with interlaced as true. Our transcode support tunneling, basic the decode buffer will be used directly for encode. Thanks, Leo

Re: [Mesa-dev] [PATCH 3/4] glx: Fix indirect multi-texture GL_DOUBLE coordinate arrays.

This patch is Reviewed-by: Ian Romanick On 06/23/2016 11:15 AM, Matt Turner wrote: > From: Colin McDonald > > There is no draw arrays protocol support for multi-texture coordinate > arrays, so it is implemented by sending batches of

Re: [Mesa-dev] [PATCH 1/4] glx: Call __glXInitVertexArrayState() with a usable gc.

On 06/23/2016 11:15 AM, Matt Turner wrote: > From: Colin McDonald > > For each indirect context the indirect vertex array state must be initialised > by __glXInitVertexArrayState in indirect_vertex_array.c. As noted in the > routine header it requires that the glx

Re: [Mesa-dev] [PATCH 4/4] glx: Undo memory allocation checking damage.

On 06/23/2016 11:15 AM, Matt Turner wrote: > This partially reverts commit d41f5396f3cb619729021390c273f838d92f11fb. > > That untested commit broke the tex-skipped-unit piglit test and the > arbvparray Mesa demo when run with indirect GLX. > > state->array_state is used during initialization, so

Re: [Mesa-dev] [PATCH 2/4] glx: Correct opcode typos in __indirect_glTexCoordPointer.

On 06/23/2016 11:15 AM, Matt Turner wrote: > From: Colin McDonald > > At the same time, replace opcode numbers with names in > __indirect_glVertexAttribPointer. > > Reviewed-by: Matt Turner > Bugzilla:

Re: [Mesa-dev] [PATCH] mesa: Close fp on error path.

It looks like there's another premature return around line 10087. On 06/27/2016 04:31 PM, Matt Turner wrote: > --- > src/mesa/main/dlist.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c > index 3845d2e..1cf814b 100644 >

[Mesa-dev] [PATCH 2/2] intel: Removing PCI IDs that are no longer listed as Kabylake.

This is unusual. Usually IDs listed on early stages of platform definition are kept there as reserved for later use. However these IDs here are not listed anymore in any of steppings and devices IDs tables for Kabylake on configurations overview section of BSpec. So it is better removing them

[Mesa-dev] [PATCH 1/2] intel: Add more Kabylake PCI IDs.

The spec has been updated adding new PCI IDs. v2: Avoid using "H" instead of HALO to keep names uniform - DK. Cc: Dhinakaran Pandiyan Signed-off-by: Rodrigo Vivi --- intel/intel_chipset.h | 14 ++ 1 file changed, 10

Re: [Mesa-dev] [PATCH 1/4] isl: Fix isl_tiling_is_any_y()

Reviewed-by: Jason Ekstrand On Mon, Jun 27, 2016 at 4:35 PM, Nanley Chery wrote: > Signed-off-by: Nanley Chery > --- > src/intel/isl/isl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH 3/4] anv/blit2d: Copy with stencil sources when needed

In the next patch, ISL will unconditionally perform verification of a surface's tiling and usage. Since it will require that w-tiled images be stencil buffers, create a stencil surface to copy from a w-tiled/stencil surface. Signed-off-by: Nanley Chery ---

[Mesa-dev] [PATCH 2/4] anv/image: Simplify initialization of the isl_tiling

Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 77d9931..b3f5f5c 100644 --- a/src/intel/vulkan/anv_image.c +++

[Mesa-dev] [PATCH 4/4] Revert "isl: Don't filter tiling flags if a specific tiling bit is set"

This reverts commit 091f1da902c71ac8d3d27b325a118e2f683f1ae5. Although a user may specify a specfic tiling bit, ISL should still prevent incompatible tiling/surface combinations. Signed-off-by: Nanley Chery --- Prior to patch

[Mesa-dev] [PATCH 1/4] isl: Fix isl_tiling_is_any_y()

Signed-off-by: Nanley Chery --- src/intel/isl/isl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index ef86228..64aced8 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -989,7 +989,7 @@

[Mesa-dev] [PATCH] mesa: Close fp on error path.

--- src/mesa/main/dlist.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 3845d2e..1cf814b 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -10366,7 +10366,7 @@ print_list(struct gl_context *ctx, GLuint

[Mesa-dev] [PATCH] gm107/ir: make sure that flagsDef is set when emitting setcond

Rely on the existence of a second destination when emitting a setcond flag is dangerous, because this doesn't mean that the flag has been correctly set. Instead rely on flagsDef like what emitX() does for flagsSrc. Signed-off-by: Samuel Pitoiset Cc:

[Mesa-dev] [PATCH] doc: improve INTEL_DEBUG documentation

Remove 'reg' option that does not actually exist, elaborate more about 'sync' and add the missing options. Signed-off-by: Grazvydas Ignotas --- no commit access, if this is ok please somebody push docs/envvars.html | 12 ++-- 1 file changed, 10 insertions(+), 2

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

Hi Ilia, The changes for get.c where prompted by the es3fIntegerStateQueryTests (see modules/gles3/functional/es3fIntegerStateQueryTests.cpp in the dEQP tree). Specifically, these few lines: >> const GLint validInitialValues[] = {GL_BACK, GL_NONE}; >> m_verifier->verifyIntegerAnyOf(m_testCtx,

Re: [Mesa-dev] [PATCH 2/7] glsl: Avoid aliasing violations.

On Mon, Jun 27, 2016 at 3:27 PM, Brian Paul wrote: > On 06/27/2016 03:42 PM, Matt Turner wrote: >> >> --- >> src/compiler/glsl/ir_constant_expression.cpp| 11 +++ >> src/compiler/glsl/link_uniform_initializers.cpp | 3 +-- >> 2 files changed, 4 insertions(+),

Re: [Mesa-dev] [PATCH 2/7] glsl: Avoid aliasing violations.

On 06/27/2016 03:42 PM, Matt Turner wrote: --- src/compiler/glsl/ir_constant_expression.cpp| 11 +++ src/compiler/glsl/link_uniform_initializers.cpp | 3 +-- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/ir_constant_expression.cpp

Re: [Mesa-dev] [PATCH v2] gm107/ir: add missing setcond flags for LOP variants

Reviewed-by: Ilia Mirkin On Mon, Jun 27, 2016 at 6:13 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > Cc: > --- >

[Mesa-dev] [PATCH v2] gm107/ir: add missing setcond flags for LOP variants

Signed-off-by: Samuel Pitoiset Cc: --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On 06/28/2016 12:06 AM, Ilia Mirkin wrote: On Mon, Jun 27, 2016 at 6:05 PM, Ilia Mirkin wrote: On Mon, Jun 27, 2016 at 6:04 PM, Samuel Pitoiset wrote: On 06/28/2016 12:02 AM, Ilia Mirkin wrote: This loses you saturation. Does the target

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On Mon, Jun 27, 2016 at 6:05 PM, Ilia Mirkin wrote: > On Mon, Jun 27, 2016 at 6:04 PM, Samuel Pitoiset > wrote: >> >> >> On 06/28/2016 12:02 AM, Ilia Mirkin wrote: >>> >>> This loses you saturation. Does the target account for this? >> >> >> No

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On Mon, Jun 27, 2016 at 6:04 PM, Samuel Pitoiset wrote: > > > On 06/28/2016 12:02 AM, Ilia Mirkin wrote: >> >> This loses you saturation. Does the target account for this? > > > No saturate flag for FADD32I. That's not what I asked.

Re: [Mesa-dev] [PATCH 2/2] gm107/ir: make use of LOP32I for all immediates

Reviewed-by: Ilia Mirkin On Mon, Jun 27, 2016 at 5:55 PM, Samuel Pitoiset wrote: > LOP only allows to emit 19-bits immediates. > > Signed-off-by: Samuel Pitoiset > Cc: > --- >

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

On 06/28/2016 12:02 AM, Ilia Mirkin wrote: This loses you saturation. Does the target account for this? No saturate flag for FADD32I. On Mon, Jun 27, 2016 at 5:55 PM, Samuel Pitoiset wrote: FADD only allows to emit 19-bits immediates. Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH] gm107/ir: add missing setcond flags for LOP variants

On 06/28/2016 12:01 AM, Ilia Mirkin wrote: Hm, dangerous: CodeEmitterGM107::emitCC(int pos) { emitField(pos, 1, insn->defExists(1)); } That should *probably* be insn->flagsDef >= 0. IIRC I fixed up gf100/gk110 before. But that might have been nv50-specific, I forget (which has somewhat

Re: [Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

This loses you saturation. Does the target account for this? On Mon, Jun 27, 2016 at 5:55 PM, Samuel Pitoiset wrote: > FADD only allows to emit 19-bits immediates. > > Signed-off-by: Samuel Pitoiset > Cc:

Re: [Mesa-dev] [PATCH] gm107/ir: add missing setcond flags for LOP variants

Hm, dangerous: CodeEmitterGM107::emitCC(int pos) { emitField(pos, 1, insn->defExists(1)); } That should *probably* be insn->flagsDef >= 0. IIRC I fixed up gf100/gk110 before. But that might have been nv50-specific, I forget (which has somewhat different flags). On Mon, Jun 27, 2016 at 5:55

[Mesa-dev] [PATCH 2/2] gm107/ir: make use of LOP32I for all immediates

LOP only allows to emit 19-bits immediates. Signed-off-by: Samuel Pitoiset Cc: --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/2] gm107/ir: make use of FADD32I for all immediates

FADD only allows to emit 19-bits immediates. Signed-off-by: Samuel Pitoiset Cc: --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] gm107/ir: add missing setcond flags for LOP variants

Signed-off-by: Samuel Pitoiset Cc: --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp

Re: [Mesa-dev] [PATCH] miptree: Skip attempts to make unsupported images

On Mon, Jun 27, 2016 at 11:30 AM, Nanley Chery wrote: > This causes tests that attempt to create linear depth buffers on > Gen7+ (unsupported), to be skipped. > > Signed-off-by: Nanley Chery > --- > src/tests/func/miptree/miptree.c | 39

[Mesa-dev] [PATCH 4/7] mesa: Avoid aliasing violation in FXT1.

--- src/mesa/main/texcompress_fxt1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/texcompress_fxt1.c b/src/mesa/main/texcompress_fxt1.c index ae339e1..c5646fb 100644 --- a/src/mesa/main/texcompress_fxt1.c +++ b/src/mesa/main/texcompress_fxt1.c @@ -177,8

[Mesa-dev] [PATCH 3/7] swrast: Avoid aliasing violation.

--- src/mesa/swrast/s_masking.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/swrast/s_masking.c b/src/mesa/swrast/s_masking.c index c95587b..c10bf1a 100644 --- a/src/mesa/swrast/s_masking.c +++ b/src/mesa/swrast/s_masking.c @@ -56,8 +56,8 @@

[Mesa-dev] [PATCH 1/7] glsl: Separate overlapping sentinel nodes in exec_list.

I do appreciate the cleverness, but unfortunately it prevents a lot more cleverness in the form of additional compiler optimizations brought on by -fstrict-aliasing. No difference in OglBatch7 (n=20). Co-authored-by: Davin McCall --- src/compiler/glsl/ast.h

[Mesa-dev] [PATCH 5/7] mesa: Avoid aliasing violation in uniform_query.cpp.

--- src/mesa/main/uniform_query.cpp | 45 - 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 127f097..3e460b0 100644 --- a/src/mesa/main/uniform_query.cpp +++

[Mesa-dev] [PATCH 6/7] glx: Avoid aliasing violations.

Compilers are perfectly capable of generating efficient code for calls like these to memcpy(). --- src/glx/packrender.h | 34 -- src/glx/packsingle.h | 15 +-- 2 files changed, 25 insertions(+), 24 deletions(-) diff --git a/src/glx/packrender.h

[Mesa-dev] [PATCH 2/7] glsl: Avoid aliasing violations.

--- src/compiler/glsl/ir_constant_expression.cpp| 11 +++ src/compiler/glsl/link_uniform_initializers.cpp | 3 +-- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/ir_constant_expression.cpp b/src/compiler/glsl/ir_constant_expression.cpp index

[Mesa-dev] [PATCH 0/7] mesa: Enable -fstrict-aliasing

Based on work by Davin McCall from last summer. The biggest change is to exec_list. Previously, the head and tail sentinels overlapped, saving the size of a pointer. Unfortunately this is not allowed by the aliasing rules. I have fixed all warnings GCC reports in my normal

[Mesa-dev] [PATCH 7/7] mesa: Drop -fno-strict-aliasing.

Improves performance of OglBatch7 by 4.06851% +/- 1.17925% (n=169) on Haswell, and cuts ~18k of .text: text data bss dec hex filename 5824627 28781629384 6141827 5db783 before/i965_dri.so 5806354 28781629384 6123554 5d7022 after/i965_dri.so ---

Re: [Mesa-dev] [PATCH 1/2] clover: Fix kernel metadata retrieval after clang r273425

On Wed, 2016-06-22 at 20:52 -0400, Jan Vesely wrote: > Signed-off-by: Jan Vesely sorry for an early ping, but at least the first patch is needed to unbreak clover with recent llvm (otherwise all kernel launches fail with unknown kernel name) thanks, Jan > --- >  

Re: [Mesa-dev] [PATCH 2/3] st/omx: add support for nouveau / interlaced

Hi Leo, Sorry for the inconvenience, could you let me know how to reproduce the problem ? I have been playing with some gst pipelines and they all work but I can only test with nouveau driver. Cheers Julien On 27 June 2016 at 21:35, Leo Liu wrote: > This patch break omx

[Mesa-dev] [PATCH 1/2] tgsi/exec: consolidate conversion from 64-bit code.

From: Dave Airlie These 3 functions could be collapsed into a single one, passing in some control values. --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 87 +++--- 1 file changed, 27 insertions(+), 60 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

On Mon, Jun 27, 2016 at 4:17 PM, Gurchetan Singh wrote: > There a few places in the code where clearing and reading are done on > incorrect > buffers for GLES contexts. See comments for details. This fixes 75 GLES3 > dEQP tests on the surfaceless platform with no

[Mesa-dev] [Bug 96698] [swrast] piglit glsl-array-bounds-05 regression

https://bugs.freedesktop.org/show_bug.cgi?id=96698 Bug ID: 96698 Summary: [swrast] piglit glsl-array-bounds-05 regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH 2/3] st/omx: add support for nouveau / interlaced

This patch break omx decode to file, it got seg fault. Will take look further. Regards, Leo On 06/27/2016 04:16 AM, Julien Isorce wrote: Signed-off-by: Julien Isorce --- src/gallium/state_trackers/omx/vid_dec.c | 51 1 file changed,

Re: [Mesa-dev] [PATCH 1/3] st/omx: retrieve preferred interlaced and buffer_formats

On 06/27/2016 04:16 AM, Julien Isorce wrote: Interlaced can be true for nouveau driver. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/omx/vid_dec.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

There a few places in the code where clearing and reading are done on incorrect buffers for GLES contexts. See comments for details. This fixes 75 GLES3 dEQP tests on the surfaceless platform with no regressions. v2: Corrected unclear comment --- src/mesa/main/buffers.c | 14 --

Re: [Mesa-dev] [PATCH] docs: update MESA_DEBUG envvar documentation.

On 27/06/16 15:45, Brian Paul wrote: > On 06/27/2016 02:10 AM, Alejandro Piñeiro wrote: >> silent, flush, incomplete_tex and incomplete_fbo flags were not >> documented (see src/mesa/main.debug.c for more info). >> >> FP is not checked anymore. >> --- >> >> Didn't know about the flush option for

Re: [Mesa-dev] [Piglit] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

On 27/06/16 18:12, Ilia Mirkin wrote: > On Mon, Jun 27, 2016 at 6:36 AM, Alejandro Piñeiro > wrote: >> >> On 27/06/16 12:33, Alejandro Piñeiro wrote: >>> On 27/06/16 03:08, Grazvydas Ignotas wrote: On Sat, Jun 25, 2016 at 4:54 PM, Alejandro Piñeiro

Re: [Mesa-dev] [PATCH v2 19/34] i965/state: Add a helper for emitting a surface state using isl

On Thu, Jun 23, 2016 at 02:00:18PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_state.h| 8 +++ > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 83 > > 2 files changed, 91 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

On Mon, Jun 27, 2016 at 3:06 PM, Kenneth Graunke wrote: > On Monday, June 27, 2016 11:43:28 AM PDT Matt Turner wrote: >> On Mon, Jun 27, 2016 at 4:44 AM, Rob Clark wrote: >> > On Mon, Jun 27, 2016 at 7:13 AM, Alan Swanson >>

Re: [Mesa-dev] [PATCH] radeonsi: set PA_SU_SMALL_PRIM_FILTER_CNTL register on Polaris

On Mon, Jun 27, 2016 at 3:01 PM, Marek Olšák wrote: > From: Marek Olšák > > This was missing. > > Cc: 12.0 Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_state.c | 5 +

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

On Monday, June 27, 2016 11:43:28 AM PDT Matt Turner wrote: > On Mon, Jun 27, 2016 at 4:44 AM, Rob Clark wrote: > > On Mon, Jun 27, 2016 at 7:13 AM, Alan Swanson > > wrote: > >> On 2016-06-25 13:37, Rob Clark wrote: > >>> > >>> Some games are

[Mesa-dev] [PATCH] radeonsi: set PA_SU_SMALL_PRIM_FILTER_CNTL register on Polaris

From: Marek Olšák This was missing. Cc: 12.0 --- src/gallium/drivers/radeonsi/si_state.c | 5 + src/gallium/drivers/radeonsi/sid.h | 6 ++ 2 files changed, 11 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

On Mon, Jun 27, 2016 at 4:44 AM, Rob Clark wrote: > On Mon, Jun 27, 2016 at 7:13 AM, Alan Swanson > wrote: >> On 2016-06-25 13:37, Rob Clark wrote: >>> >>> Some games are sloppy.. perhaps because it is defined behavior for DX or >>> perhaps because

Re: [Mesa-dev] [PATCH v2 09/34] isl/state: Add support for handling color control surfaces

On Thu, Jun 23, 2016 at 02:00:08PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl.h | 7 +++ > src/intel/isl/isl_surface_state.c | 39 > --- > 2 files changed, 43 insertions(+), 3 deletions(-) Reviewed-by: Topi Pohjolainen

Re: [Mesa-dev] [PATCH 5/6] gallium/radeon: add a heuristic dynamically enabling DCC for scanout surfaces

On Mon, Jun 27, 2016 at 10:35 AM, Nicolai Hähnle wrote: > On 24.06.2016 20:48, Marek Olšák wrote: >> >> On Fri, Jun 24, 2016 at 1:09 PM, Nicolai Hähnle >> wrote: >>> >>> On 22.06.2016 20:29, Marek Olšák wrote: From: Marek Olšák

[Mesa-dev] [PATCH] miptree: Skip attempts to make unsupported images

This causes tests that attempt to create linear depth buffers on Gen7+ (unsupported), to be skipped. Signed-off-by: Nanley Chery --- src/tests/func/miptree/miptree.c | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) diff

[Mesa-dev] [PATCH] i965: Simplify foreach_inst_in_block_safe() macro.

We know what the end looks like without examining .tail: it's NULL. It's always NULL. --- src/mesa/drivers/dri/i965/brw_cfg.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_cfg.h b/src/mesa/drivers/dri/i965/brw_cfg.h index 5b770aa..1c90eab

Re: [Mesa-dev] [PATCH v2 10/34] i965/miptree: Add a helper for getting an isl_surf from a miptree

On Thu, Jun 23, 2016 at 02:00:09PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 171 > +- > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 6 + > 2 files changed, 175 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH v2 13/34] i965/blorp: Add a generic ISL-based surface state emit path

On Thu, Jun 23, 2016 at 02:00:12PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 148 > ++ > src/mesa/drivers/dri/i965/brw_blorp.h | 6 ++ > 2 files changed, 154 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

On 06/24/2016 09:30 AM, Emil Velikov wrote: > On 20 June 2016 at 19:14, Ian Romanick wrote: >> On 06/17/2016 11:15 AM, Emil Velikov wrote: >>> On 17 June 2016 at 18:20, Ian Romanick wrote: From: Ian Romanick

Re: [Mesa-dev] [Piglit] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

On Mon, Jun 27, 2016 at 6:36 AM, Alejandro Piñeiro wrote: > > > On 27/06/16 12:33, Alejandro Piñeiro wrote: >> On 27/06/16 03:08, Grazvydas Ignotas wrote: >>> On Sat, Jun 25, 2016 at 4:54 PM, Alejandro Piñeiro >>> wrote: In theory they don't

Re: [Mesa-dev] [PATCH v2 12/34] i965/miptree: Add a helper for getting the aux isl_surf from a miptree

On Mon, Jun 27, 2016 at 08:40:41AM -0700, Jason Ekstrand wrote: >On Mon, Jun 27, 2016 at 8:34 AM, Pohjolainen, Topi ><[1]topi.pohjolai...@intel.com> wrote: > >On Thu, Jun 23, 2016 at 02:00:11PM -0700, Jason Ekstrand wrote: >> --- >>

Re: [Mesa-dev] [PATCH v2 12/34] i965/miptree: Add a helper for getting the aux isl_surf from a miptree

On Mon, Jun 27, 2016 at 8:34 AM, Pohjolainen, Topi < topi.pohjolai...@intel.com> wrote: > On Thu, Jun 23, 2016 at 02:00:11PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 89 > +++ > >

Re: [Mesa-dev] [PATCH v2 12/34] i965/miptree: Add a helper for getting the aux isl_surf from a miptree

On Thu, Jun 23, 2016 at 02:00:11PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 89 > +++ > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5 ++ > 2 files changed, 94 insertions(+) > > diff --git

[Mesa-dev] [PATCH] glsl: atomic counters are different than their uniforms

The linker deals with atomic counters in terms of uniforms. This is OK but when we want to know the number of used atomic counters since a 2 elements atomic counters array will use 2 counters but only 1 uniform. Renamed the data structures used in the linker for disambiguation. Fixes

Re: [Mesa-dev] [PATCH 1/2] i965: Make emit_urb_writes() not produce an EOT message for GS.

On Monday, June 27, 2016 2:50:02 PM PDT Iago Toral wrote: > On Sun, 2016-06-26 at 01:53 -0700, Kenneth Graunke wrote: > > emit_urb_writes() contains code to emit an EOT write with no actual > > data when there are no output varyings. This makes sense for the VS > > and TES stages, where it's

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

This code fragment: + /* t = frac(i_vtex*size) ... + ureg_MUL(shader, t, i_vtex, ureg_imm1f(shader, size)); Probably doesn't do what you expect it to do when the pixel center is at 0.5 instead of 0.0. For the matrix and most other filters the difference doesn't matter because you get

Re: [Mesa-dev] [PATCH 1/4] gallium: add pipe_surface::alpha_one field

On 06/24/2016 08:45 AM, Roland Scheidegger wrote: For what formats is this really needed? I think that usually if you have a rgb surface, the corresponding rgbx format should be used instead of rgba (which implicitly has the alpha == 1 property for blending). But maybe some formats are

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

Hi Christian, I haven't taken that into account, but how will it any way affect my calculation. I have written the code taking inspiration from the way matrix_filter uses offsets. Regards, Nayan. On Mon, Jun 27, 2016 at 6:55 PM, Christian König wrote: > Hi guys, > >

Re: [Mesa-dev] [PATCH] docs: update MESA_DEBUG envvar documentation.

On 06/27/2016 02:10 AM, Alejandro Piñeiro wrote: silent, flush, incomplete_tex and incomplete_fbo flags were not documented (see src/mesa/main.debug.c for more info). FP is not checked anymore. --- Didn't know about the flush option for MESA_DEBUG until Grazvydas Ignotas mentioned it on a

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

Hi guys, Nayan have you taken into account that the pixel center is at 0.5 and not 0.0? Regards, Christian. Am 26.06.2016 um 22:30 schrieb Andy Furniss: Nayan Deshmukh wrote: Hi Andy, On Sun, Jun 26, 2016 at 12:25 AM, Andy Furniss wrote: Nayan Deshmukh wrote:

Re: [Mesa-dev] [PATCH 1/2] i965: Make emit_urb_writes() not produce an EOT message for GS.

On Sun, 2016-06-26 at 01:53 -0700, Kenneth Graunke wrote: > emit_urb_writes() contains code to emit an EOT write with no actual > data when there are no output varyings. This makes sense for the VS > and TES stages, where it's called once at the end of the program. > > However, in the geometry

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

On Mon, Jun 27, 2016 at 7:13 AM, Alan Swanson wrote: > On 2016-06-25 13:37, Rob Clark wrote: >> >> Some games are sloppy.. perhaps because it is defined behavior for DX or >> perhaps because nv blob driver defaults things to zero. >> >> So add driconf param to force

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

On 2016-06-25 13:37, Rob Clark wrote: Some games are sloppy.. perhaps because it is defined behavior for DX or perhaps because nv blob driver defaults things to zero. So add driconf param to force uninitialized variables to default to zero. This issue was observed with rust, from steam

Re: [Mesa-dev] [RFC] Coding style scripts (Was Re: [PATCH 1/2] gallium: replace [0-9]*.f with [0-9]*.0f)

On 22/06/16 13:25, Emil Velikov wrote: Hi All, Seems like we have a few people are keen on the idea of having some form of at least semi-automated way to handle coding style issues. Some options/ideas: - Combine the emacs .dir-local.el + emacs -batch to do the checking: Pros: rules aren't

Re: [Mesa-dev] [Piglit] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

On 27/06/16 03:08, Grazvydas Ignotas wrote: > On Sat, Jun 25, 2016 at 4:54 PM, Alejandro Piñeiro > wrote: >> In theory they don't overdrawn. The test has a square formed by N >> non-overlapping triangles. With just one call to glDrawRangeElements, >> this always works. But

Re: [Mesa-dev] [Piglit] [RFC PATCH] arb_texture_barrier: call glTextureBarrier after each glDrawRangeElements

On 27/06/16 12:33, Alejandro Piñeiro wrote: > On 27/06/16 03:08, Grazvydas Ignotas wrote: >> On Sat, Jun 25, 2016 at 4:54 PM, Alejandro Piñeiro >> wrote: >>> In theory they don't overdrawn. The test has a square formed by N >>> non-overlapping triangles. With just one

Re: [Mesa-dev] [PATCH 0/3] st/omx: add initial support for nouveau

Reviewed-by: Christian König for the whole series. Regards, Christian. Am 27.06.2016 um 10:16 schrieb Julien Isorce: 3 patches I made in last january to allow running st/omx with the nouveau video driver. But currently the video is full of blockiness because nouveau

Re: [Mesa-dev] [PATCH] radeonsi: use optimal WD settings for primitive restart on Polaris

Reviewed-by: Nicolai Hähnle On 24.06.2016 18:20, Marek Olšák wrote: From: Marek Olšák ported from Vulkan --- src/gallium/drivers/radeonsi/si_state_draw.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 5/6] gallium/radeon: add a heuristic dynamically enabling DCC for scanout surfaces

On 24.06.2016 20:48, Marek Olšák wrote: On Fri, Jun 24, 2016 at 1:09 PM, Nicolai Hähnle wrote: On 22.06.2016 20:29, Marek Olšák wrote: From: Marek Olšák DCC for displayable surfaces is allocated in a separate buffer and is enabled or disabled based

  1   2   >