[Mesa-dev] Question about OSMesaCreateContextAttribs?

2016-06-30 Thread Mathias Fröhlich
Hi, Is OSMesaCreateContextAttribs supposed to be an extension function that should not be linked against and queried for using OSMesaGetProcAddress or is that a public api function? If I look into the source I could think its public since it's listed in the public header and marked as GLAPI. But

Re: [Mesa-dev] [PATCH 09/36] i965/blorp: Make sample count asserts a bit more lazy

2016-06-30 Thread Pohjolainen, Topi
On Thu, Jun 30, 2016 at 06:57:39AM -0700, Jason Ekstrand wrote: >On Jun 29, 2016 11:07 PM, "Pohjolainen, Topi" ><[1]topi.pohjolai...@intel.com> wrote: >> >> On Wed, Jun 29, 2016 at 05:37:28PM -0700, Jason Ekstrand wrote: >> > --- >> >

[Mesa-dev] [PATCH 3/4] i965: Make room in the batch epilogue for three more pipe controls.

2016-06-30 Thread Francisco Jerez
Review carefully, it sucks to have to keep track of the number of command packet dwords emitted in the batch epilogue manually. The MI_REPORT_PERF_COUNT_BATCH_DWORDS calculation was obviously wrong. --- src/mesa/drivers/dri/i965/brw_performance_monitor.c | 10 +-

[Mesa-dev] [PATCH 1/4] i965: Emit SNB write cache flush W/A from brw_emit_pipe_control_flush.

2016-06-30 Thread Francisco Jerez
Shouldn't cause any functional changes at this point, but we have forgotten to apply this workaround several times in the past, make sure it doesn't happen again. --- src/mesa/drivers/dri/i965/brw_misc_state.c | 9 - src/mesa/drivers/dri/i965/brw_pipe_control.c | 21

[Mesa-dev] [PATCH 2/4] i965: Emit SKL VF cache invalidation W/A from brw_emit_pipe_control_flush.

2016-06-30 Thread Francisco Jerez
There were two places in the driver doing a pipe control VF cache flush, one of them was missing this workaround, move it down into brw_emit_pipe_control_flush to make sure we don't miss it again. --- src/mesa/drivers/dri/i965/brw_pipe_control.c | 19 ++- 1 file changed, 10

[Mesa-dev] [PATCH 4/4] i965: Fix remaining flush vs invalidate race conditions in brw_emit_pipe_control_flush.

2016-06-30 Thread Francisco Jerez
This hardware race condition has caused problems several times already (see "i965: Fix cache pollution race during L3 partitioning set-up.", "i965: Fix brw_render_cache_set_check_flush's PIPE_CONTROLs." and "i965: intel_texture_barrier reimplemented"). The problem is that whenever we attempt to

Re: [Mesa-dev] i965/blorp: Use flat vertex inputs instead of uniforms

2016-06-30 Thread Jason Ekstrand
I keep saying I'm going to review this "tomorrow" but I really mean it this time! I would have today but I spent the whole day arguing the finer points of surface layout, HiZ, fast clears, and color compression with Chad. It was a fun day! :-) --Jason On Jun 23, 2016 12:17 PM, "Topi

Re: [Mesa-dev] [PATCH v3] i965: intel_texture_barrier reimplemented

2016-06-30 Thread Francisco Jerez
Jason Ekstrand writes: > On Jun 30, 2016 9:25 PM, "Francisco Jerez" wrote: >> >> Jason Ekstrand writes: >> >> > Fwiw, I very much like the way I did this in the Vulkan driver where it >> > splits it into two pipe controls

Re: [Mesa-dev] [PATCH v3] i965: intel_texture_barrier reimplemented

2016-06-30 Thread Jason Ekstrand
On Jun 30, 2016 9:25 PM, "Francisco Jerez" wrote: > > Jason Ekstrand writes: > > > Fwiw, I very much like the way I did this in the Vulkan driver where it > > splits it into two pipe controls automatically based on the input bits. > > (Look at

Re: [Mesa-dev] [PATCH v3] i965: intel_texture_barrier reimplemented

2016-06-30 Thread Francisco Jerez
Jason Ekstrand writes: > Fwiw, I very much like the way I did this in the Vulkan driver where it > splits it into two pipe controls automatically based on the input bits. > (Look at genX_cmd_buffer.c cmd_buffer_apply_pipe_flushes.) I very much > doubt that this is the only

Re: [Mesa-dev] [PATCH 6/8] nv50/ir: optimize ADD3(d, 0x0, b, c) to ADD(d, b, c)

2016-06-30 Thread Ilia Mirkin
On Thu, Jun 30, 2016 at 6:54 PM, Samuel Pitoiset wrote: > > > On 07/01/2016 12:44 AM, Ilia Mirkin wrote: >> >> If moveSources doesn't move modifiers, we have a serious problem. >> However it looks like it does: >> >> void >> Instruction::setSrc(int s, const ValueRef&

Re: [Mesa-dev] V3 On disk shader cache for i965 (Now with real world results!)

2016-06-30 Thread Timothy Arceri
On Thu, 2016-06-30 at 00:59 +0300, Grazvydas Ignotas wrote: > On Wed, Jun 29, 2016 at 3:11 PM, Timothy Arceri > wrote: > > On Wed, 2016-06-29 at 03:47 +0300, Grazvydas Ignotas wrote: > > > On Tue, Jun 28, 2016 at 10:53 AM, Timothy Arceri > > >

Re: [Mesa-dev] [PATCH 1/8] nv50/ir: add preliminary support for OP_ADD3

2016-06-30 Thread Ilia Mirkin
On Thu, Jun 30, 2016 at 6:26 PM, Samuel Pitoiset wrote: > This instruction is new since SM50 (Maxwell) and allows to perform > an add with three sources. Unfortunately, it only supports integers. > > Signed-off-by: Samuel Pitoiset > --- >

[Mesa-dev] [PATCH] mesa: make attribute binding message more useful

2016-06-30 Thread Timothy Arceri
--- src/mesa/main/shader_query.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp index b5e1a44..a2a93b1 100644 --- a/src/mesa/main/shader_query.cpp +++ b/src/mesa/main/shader_query.cpp @@ -84,7 +84,8 @@

[Mesa-dev] [PATCH v2] nvc0: fix up image support for allowing multiple samples

2016-06-30 Thread Ilia Mirkin
Basically we just have to scale up the coordinates and then add the relevant sample offset. The code to handle this was already largely present from Christoph's earlier attempts to pipe images through back in the dark ages, this just hooks it all up. Signed-off-by: Ilia Mirkin

[Mesa-dev] [Bug 95346] Stellaris - Black/super dark planets

2016-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95346 --- Comment #13 from Luchesar V. ILIEV --- Sorry for the spam, but I just realised that earlier game versions can be tested. Going back as far as 1.0.0, the situation is the same: textures work in-game, but are broken

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

2016-06-30 Thread Vedran Miletić
On 07/01/2016 02:52 AM, Vedran Miletić wrote: Had something similar in the works, Bas did as well, but this approach is cleaner. With these changes, in si_pipe.c and r600_pipe.c, you should not return max_const_buffer_size anymore, since it can exceed int limits, but instead something like

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

2016-06-30 Thread Vedran Miletić
On 07/01/2016 01:29 AM, Marek Olšák wrote: From: Marek Olšák also fix max_global_size to take a maximum of {vram_size, gart_size} --- src/gallium/drivers/r600/r600_pipe.c | 2 +- src/gallium/drivers/radeon/r600_pipe_common.c | 9 +++--

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

2016-06-30 Thread Jason Ekstrand
On Thu, Jun 30, 2016 at 11:42 AM, Kenneth Graunke wrote: > On Saturday, June 25, 2016 8:37:47 AM PDT Rob Clark wrote: > > From: Rob Clark > > > > Some games are sloppy.. perhaps because it is defined behavior for DX or > > perhaps because nv blob

[Mesa-dev] [Bug 95346] Stellaris - Black/super dark planets

2016-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95346 --- Comment #12 from Luchesar V. ILIEV --- Slight correction: the textures load correctly in-game; however the planets are still broken as before (i.e. showing only the night texture) in the "New game" screen, where the

Re: [Mesa-dev] [PATCH] gallium/util: check for window cliprects in util_can_blit_via_copy_region()

2016-06-30 Thread Roland Scheidegger
Am 01.07.2016 um 02:16 schrieb Brian Paul: > We can't blit with resource_copy_region() if there are window clip rects. > --- > src/gallium/auxiliary/util/u_surface.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/gallium/auxiliary/util/u_surface.c >

[Mesa-dev] [PATCH] gallium/util: check for window cliprects in util_can_blit_via_copy_region()

2016-06-30 Thread Brian Paul
We can't blit with resource_copy_region() if there are window clip rects. --- src/gallium/auxiliary/util/u_surface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/util/u_surface.c b/src/gallium/auxiliary/util/u_surface.c index e0234f8..a9ed006 100644 ---

Re: [Mesa-dev] [PATCH 1/2] mesa: Drop -fno-builtin-memcmp.

2016-06-30 Thread Timothy Arceri
On Fri, 2016-07-01 at 01:26 +0200, Roland Scheidegger wrote: > Am 01.07.2016 um 00:59 schrieb Matt Turner: > > According to the referenced bug report, gcc-4.5 and newer do not > > inline > > memcmp(). I see no difference in performance of ipers with llvmpipe > > on a > > Sandybridge (which does

Re: [Mesa-dev] [PATCH 16/24] i965: Use LZD to implement nir_op_ifind_msb on Gen < 7

2016-06-30 Thread Francisco Jerez
Ian Romanick writes: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 50 ++-- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 52 >

Re: [Mesa-dev] [PATCH 15/24] i965: Use LZD to implement nir_op_ufind_msb

2016-06-30 Thread Francisco Jerez
Ian Romanick writes: > On 06/30/2016 03:33 PM, Francisco Jerez wrote: >> Matt Turner writes: >> >>> On Wed, Jun 29, 2016 at 2:04 PM, Ian Romanick wrote: From: Ian Romanick This uses one

Re: [Mesa-dev] [PATCH 15/24] i965: Use LZD to implement nir_op_ufind_msb

2016-06-30 Thread Ian Romanick
On 06/30/2016 03:33 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Wed, Jun 29, 2016 at 2:04 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> This uses one less instruction. >> >> Add FBH to the list of stupid

[Mesa-dev] [PATCH 7/8] radeonsi: keep using v_rcp_f32 for division in future LLVM (v2)

2016-06-30 Thread Marek Olšák
From: Marek Olšák This will be needed after some LLVM changes that haven't landed yet. v2: - use LLVMIsConstant to fix an LLVM assertion failure. LLVMSetMetadata doesn't work with constants. - don't set float metadata as string ---

[Mesa-dev] [PATCH 1/2] gallium/radeon: add radeon_info::max_alloc_size into the winsys interface

2016-06-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 2 ++ src/gallium/drivers/radeon/radeon_winsys.h| 1 + src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 2 ++ src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 1 + 4 files changed, 6

[Mesa-dev] [PATCH 8/8] gallium/radeon: remove unused code - radeon_llvm_util.*

2016-06-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/evergreen_compute.c | 3 - src/gallium/drivers/radeon/Makefile.sources | 2 - src/gallium/drivers/radeon/radeon_llvm_util.c | 124 -- src/gallium/drivers/radeon/radeon_llvm_util.h | 39

[Mesa-dev] [PATCH 2/2] gallium/radeon: use max_alloc_size

2016-06-30 Thread Marek Olšák
From: Marek Olšák also fix max_global_size to take a maximum of {vram_size, gart_size} --- src/gallium/drivers/r600/r600_pipe.c | 2 +- src/gallium/drivers/radeon/r600_pipe_common.c | 9 +++-- src/gallium/drivers/radeonsi/si_pipe.c| 2 +- 3 files

[Mesa-dev] [PATCH 1/8] radeonsi: don't dump the shader key for non-monolithic shaders early

2016-06-30 Thread Marek Olšák
From: Marek Olšák It's always zero. --- src/gallium/drivers/radeonsi/si_shader.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index e2aae85..f2cdd6e 100644 ---

[Mesa-dev] [PATCH 5/8] radeonsi: don't interpolate colors if flatshading is enabled

2016-06-30 Thread Marek Olšák
From: Marek Olšák use v_interp_mov for those --- src/gallium/drivers/radeonsi/si_shader.c| 13 - src/gallium/drivers/radeonsi/si_shader.h| 2 +- src/gallium/drivers/radeonsi/si_state_shaders.c | 1 + 3 files changed, 14 insertions(+), 2

[Mesa-dev] [PATCH 4/8] radeonsi: enable the barycentric optimization in all cases

2016-06-30 Thread Marek Olšák
From: Marek Olšák Handle the bc_optimize SGPR bit if both CENTER and CENTROID are enabled. This should increase the PS launch rate for big primitives with MSAA. Based on discussion with SPI guys. --- src/gallium/drivers/radeonsi/si_shader.c| 118

[Mesa-dev] [PATCH 2/8] radeonsi: split ps.prolog.force_persample_interp into persp and linear bits

2016-06-30 Thread Marek Olšák
From: Marek Olšák This reduces the number of v_mov's in the prolog. --- src/gallium/drivers/radeonsi/si_shader.c| 85 +++-- src/gallium/drivers/radeonsi/si_shader.h| 3 +- src/gallium/drivers/radeonsi/si_state_shaders.c | 21 +++--- 3

[Mesa-dev] [PATCH 3/8] radeonsi: compute only one set of interpolation (i, j) when MSAA is disabled

2016-06-30 Thread Marek Olšák
From: Marek Olšák This should increase the PS launch rate for shaders using at least 2 pairs of perspective (i,j) and same for linear. --- src/gallium/drivers/radeonsi/si_shader.c| 74 - src/gallium/drivers/radeonsi/si_shader.h| 4 +-

[Mesa-dev] [PATCH 6/8] radeonsi: remove an obsolete comment

2016-06-30 Thread Marek Olšák
From: Marek Olšák It's not true. --- src/gallium/drivers/radeonsi/si_shader.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index a408dee..77d1a8b 100644 ---

[Mesa-dev] [PATCH 0/8] RadeonSI: Interpolation optimizations and more

2016-06-30 Thread Marek Olšák
Hi, These mainly reduce the number of (i,j) that the hardware has to compute for each pixel shader, which should increase the PS launch rate in those cases. There are also some codegen improvements for interpolation and a few interp-unrelated but shader-related changes. Please review. Marek

Re: [Mesa-dev] [PATCH 1/2] mesa: Drop -fno-builtin-memcmp.

2016-06-30 Thread Roland Scheidegger
Am 01.07.2016 um 00:59 schrieb Matt Turner: > According to the referenced bug report, gcc-4.5 and newer do not inline > memcmp(). I see no difference in performance of ipers with llvmpipe on a > Sandybridge (which does not have "Enhanced REP MOVSB/STOSB") by removing > this flag. > > I attempted

[Mesa-dev] [PATCH 5/6] radeonsi: enable string markers and record apitrace call numbers

2016-06-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 4 src/gallium/drivers/radeonsi/si_pipe.c | 20 +++- src/gallium/drivers/radeonsi/si_pipe.h | 1 + 3 files changed, 24 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/6] ddebug: record and dump apitrace call numbers

2016-06-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/ddebug/dd_context.c | 4 +++- src/gallium/drivers/ddebug/dd_draw.c| 4 src/gallium/drivers/ddebug/dd_pipe.h| 1 + src/gallium/drivers/ddebug/dd_util.h| 23 +++ 4 files changed, 31

[Mesa-dev] [PATCH 6/6] radeonsi: print LLVM IRs to ddebug logs

2016-06-30 Thread Marek Olšák
From: Marek Olšák Getting LLVM IRs of hanging shaders have never been easier. --- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeonsi/si_pipe.c | 3 +++

[Mesa-dev] [PATCH 0/6] RadeonSI & ddebug: Apitrace interactions and better debugging

2016-06-30 Thread Marek Olšák
Hi, This series adds apitrace call tracking into ddebug and radeonsi and other improvements. It will improve our debugging and profiling possibilities. Just set GALLIUM_DDEBUG="apitrace [draw call number]" and you will get a complete ddebug log with TGSI, LLVM IR (new!), and asm. Both radeonsi

[Mesa-dev] [PATCH 3/6] ddebug: implement pipe_context::generate_mipmap

2016-06-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/ddebug/dd_draw.c | 53 +++- 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/ddebug/dd_draw.c b/src/gallium/drivers/ddebug/dd_draw.c index 22337e0..f0f6fb6 100644 ---

[Mesa-dev] [PATCH 4/6] ddebug: add an option to dump info about a specific apitrace call

2016-06-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/ddebug/dd_draw.c | 8 src/gallium/drivers/ddebug/dd_pipe.h | 4 +++- src/gallium/drivers/ddebug/dd_screen.c | 20 ++-- 3 files changed, 29 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 1/6] ddebug: implement emit_string_marker

2016-06-30 Thread Marek Olšák
From: Marek Olšák and remove some obsolete comments --- src/gallium/drivers/ddebug/dd_context.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/ddebug/dd_context.c b/src/gallium/drivers/ddebug/dd_context.c index

Re: [Mesa-dev] [PATCH 1/2] mesa: Drop -fno-builtin-memcmp.

2016-06-30 Thread Ian Romanick
On 06/30/2016 03:59 PM, Matt Turner wrote: > According to the referenced bug report, gcc-4.5 and newer do not inline > memcmp(). I see no difference in performance of ipers with llvmpipe on a > Sandybridge (which does not have "Enhanced REP MOVSB/STOSB") by removing > this flag. > > I attempted

Re: [Mesa-dev] [PATCH v2 04/11] glsl: Pack integer and double varyings as flat even if interpolation mode is none

2016-06-30 Thread Kenneth Graunke
On Thursday, June 16, 2016 12:07:36 PM PDT Ian Romanick wrote: > From: Ian Romanick > > v2: Also update varying_matches::compute_packing_class(). Suggested by > Timothy Arceri. > > Signed-off-by: Ian Romanick > Bugzilla:

Re: [Mesa-dev] [PATCH v2 03/11] mesa: Strip arrayness from interface block names in some IO validation

2016-06-30 Thread Kenneth Graunke
On Thursday, June 16, 2016 12:06:56 PM PDT Ian Romanick wrote: > From: Ian Romanick > > Outputs from the vertex shader need to be able to match > per-vertex-arrayed inputs of later stages. Acomplish this by stripping > one level of arrayness from the names and types of

[Mesa-dev] [PATCH 2/2] mesa: Add -fno-math-errno -fno-trapping-math to CXXFLAGS.

2016-06-30 Thread Matt Turner
Not sure why I forgot to add them to CXXFLAGS in commit f55c408067 or commit 875458b778. Cuts about 1k of .text. text data bss dec hex filename 5806354 28781629384 6123554 5d7022 i965_dri.so before 5805497 28774429384 6122625 5d6c81 i965_dri.so after ---

Re: [Mesa-dev] [PATCH 18/24] i965: Update assertion to account for Gen < 7

2016-06-30 Thread Ian Romanick
On 06/30/2016 03:37 PM, Francisco Jerez wrote: > Ian Romanick writes: > >> From: Ian Romanick >> >> Previously SHADER_OPCODE_MULH could only exist on Gen7+, so the >> assertion assumed the Gen7+ accumulator rules. A future patch will >> allow

[Mesa-dev] [PATCH 1/2] mesa: Drop -fno-builtin-memcmp.

2016-06-30 Thread Matt Turner
According to the referenced bug report, gcc-4.5 and newer do not inline memcmp(). I see no difference in performance of ipers with llvmpipe on a Sandybridge (which does not have "Enhanced REP MOVSB/STOSB") by removing this flag. I attempted to confirm the problem with gcc-4.4, but it fails to

Re: [Mesa-dev] [PATCH 15/24] i965: Use LZD to implement nir_op_ufind_msb

2016-06-30 Thread Ian Romanick
On 06/30/2016 03:33 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Wed, Jun 29, 2016 at 2:04 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> This uses one less instruction. >> >> Add FBH to the list of stupid

Re: [Mesa-dev] [PATCH 16/24] i965: Use LZD to implement nir_op_ifind_msb on Gen < 7

2016-06-30 Thread Ian Romanick
On 06/30/2016 03:20 PM, Matt Turner wrote: > On Wed, Jun 29, 2016 at 2:04 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Signed-off-by: Ian Romanick >> --- >> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 50

Re: [Mesa-dev] [PATCH 15/24] i965: Use LZD to implement nir_op_ufind_msb

2016-06-30 Thread Matt Turner
On Thu, Jun 30, 2016 at 3:33 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Wed, Jun 29, 2016 at 2:04 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> This uses one less instruction. >>

Re: [Mesa-dev] [PATCH 6/8] nv50/ir: optimize ADD3(d, 0x0, b, c) to ADD(d, b, c)

2016-06-30 Thread Samuel Pitoiset
On 07/01/2016 12:44 AM, Ilia Mirkin wrote: If moveSources doesn't move modifiers, we have a serious problem. However it looks like it does: void Instruction::setSrc(int s, const ValueRef& ref) { setSrc(s, ref.get()); srcs[s].mod = ref.mod; } which is what moveSources calls. I was not

Re: [Mesa-dev] [PATCH 3/8] nv50/ir: optimize ADD(ADD(a, b), c) to ADD3(a, b, c)

2016-06-30 Thread Ilia Mirkin
On Thu, Jun 30, 2016 at 6:47 PM, Samuel Pitoiset wrote: > > > On 07/01/2016 12:40 AM, Ilia Mirkin wrote: >> >> Doesn't ADD3 only work for integers? I don't see anything here >> preventing float adds from being merged here... > > > isOpSupported() should do the job

Re: [Mesa-dev] [PATCH 3/8] nv50/ir: optimize ADD(ADD(a, b), c) to ADD3(a, b, c)

2016-06-30 Thread Samuel Pitoiset
On 07/01/2016 12:40 AM, Ilia Mirkin wrote: Doesn't ADD3 only work for integers? I don't see anything here preventing float adds from being merged here... isOpSupported() should do the job because I check if dtype is float. On Thu, Jun 30, 2016 at 6:26 PM, Samuel Pitoiset

Re: [Mesa-dev] [PATCH 6/8] nv50/ir: optimize ADD3(d, 0x0, b, c) to ADD(d, b, c)

2016-06-30 Thread Ilia Mirkin
If moveSources doesn't move modifiers, we have a serious problem. However it looks like it does: void Instruction::setSrc(int s, const ValueRef& ref) { setSrc(s, ref.get()); srcs[s].mod = ref.mod; } which is what moveSources calls. On Thu, Jun 30, 2016 at 6:26 PM, Samuel Pitoiset

Re: [Mesa-dev] [PATCH 3/8] nv50/ir: optimize ADD(ADD(a, b), c) to ADD3(a, b, c)

2016-06-30 Thread Ilia Mirkin
Doesn't ADD3 only work for integers? I don't see anything here preventing float adds from being merged here... On Thu, Jun 30, 2016 at 6:26 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH 18/24] i965: Update assertion to account for Gen < 7

2016-06-30 Thread Francisco Jerez
Ian Romanick writes: > From: Ian Romanick > > Previously SHADER_OPCODE_MULH could only exist on Gen7+, so the > assertion assumed the Gen7+ accumulator rules. A future patch will > allow this instruction on at least Gen6, so update the assertion.

Re: [Mesa-dev] [PATCH 15/24] i965: Use LZD to implement nir_op_ufind_msb

2016-06-30 Thread Francisco Jerez
Matt Turner writes: > On Wed, Jun 29, 2016 at 2:04 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> This uses one less instruction. > > Add FBH to the list of stupid instructions. > >> Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 6/8] nv50/ir: optimize ADD3(d, 0x0, b, c) to ADD(d, b, c)

2016-06-30 Thread Samuel Pitoiset
And ADD3(d, a, 0x0, c) to ADD(d, a, c) as well. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 7/8] nv50/ir: optimize ADD3(d, a, b, c) to ADD(d, c, a + b)

2016-06-30 Thread Samuel Pitoiset
This is similar to what we already do for MAD/FMA. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 8/8] nv50/ir: optimize ADD3(d, a, b, c) to ADD(d, a, b + c)

2016-06-30 Thread Samuel Pitoiset
And ADD3(d, a, b, c) to ADD(d, b, a + c) as well. This doesn't change the world but it can reduce the number of instructions in some situations: total instructions in shared programs :97191 -> 97175 (-0.02%) total gprs used in shared programs:29196 -> 29196 (0.00%) total local used in shared

[Mesa-dev] [PATCH 5/8] nv50/ir: optimize ADD3(d, a, b, 0x0) to ADD(d, a, b)

2016-06-30 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp

[Mesa-dev] [PATCH 3/8] nv50/ir: optimize ADD(ADD(a, b), c) to ADD3(a, b, c)

2016-06-30 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 55 ++ 1 file changed, 55 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp

[Mesa-dev] [PATCH 1/8] nv50/ir: add preliminary support for OP_ADD3

2016-06-30 Thread Samuel Pitoiset
This instruction is new since SM50 (Maxwell) and allows to perform an add with three sources. Unfortunately, it only supports integers. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir.h| 1 +

[Mesa-dev] [PATCH 4/8] nv50/ir: optimize ADD3(d, a, b, c) to MOV(d, a + b + c)

2016-06-30 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp

[Mesa-dev] [PATCH 2/8] gm107/ir: add emission for OP_ADD3

2016-06-30 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp

Re: [Mesa-dev] [PATCH 00/24] Add MESA_shader_integer_functions

2016-06-30 Thread Matt Turner
On Thu, Jun 30, 2016 at 12:00 PM, Matt Turner wrote: > On Thu, Jun 30, 2016 at 11:37 AM, Matt Turner wrote: >> Patches 1-5 are >> >> Reviewed-by: Matt Turner > > As are 6-14. 18-22 as well. There's weirdness about LZD of signed

Re: [Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

2016-06-30 Thread Stéphane Marchesin
On Thu, Jun 30, 2016 at 3:20 PM, Gurchetan Singh wrote: > There are a few places in the code where clearing and reading are done on > incorrect buffers for GLES contexts. See comments for details. This > fixes 75 GLES3 dEQP tests on the surfaceless platform with no

Re: [Mesa-dev] [PATCH 16/24] i965: Use LZD to implement nir_op_ifind_msb on Gen < 7

2016-06-30 Thread Matt Turner
On Wed, Jun 29, 2016 at 2:04 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 50 ++-- >

[Mesa-dev] [PATCH] Make single-buffered GLES representation internally consistent

2016-06-30 Thread Gurchetan Singh
There are a few places in the code where clearing and reading are done on incorrect buffers for GLES contexts. See comments for details. This fixes 75 GLES3 dEQP tests on the surfaceless platform with no regressions. v2: Corrected unclear comment v3: Make the change in context.c instead of

Re: [Mesa-dev] [PATCH 15/24] i965: Use LZD to implement nir_op_ufind_msb

2016-06-30 Thread Matt Turner
On Wed, Jun 29, 2016 at 2:04 PM, Ian Romanick wrote: > From: Ian Romanick > > This uses one less instruction. Add FBH to the list of stupid instructions. > Signed-off-by: Ian Romanick > --- >

[Mesa-dev] [AppVeyor] mesa master #1718 completed

2016-06-30 Thread AppVeyor
Build mesa 1718 completed Commit eb79b2b331 by Brian Paul on 5/11/2016 3:20 PM: st/wgl: make own_mutex() non-static\n\nReviewed-by: Jose Fonseca Configure your notification preferences

Re: [Mesa-dev] [PATCH v3] i965: intel_texture_barrier reimplemented

2016-06-30 Thread Francisco Jerez
Alejandro Piñeiro writes: > Fixes: > GL44-CTS.texture_barrier_ARB.same-texel-rw-multipass > > On Haswell, Broadwell and Skylake (note that in order to execute that > test, it is needed to override GL and GLSL versions). > > On gen6 this test was already working without this

Re: [Mesa-dev] Add gperf as a build dependency?

2016-06-30 Thread Kenneth Graunke
On Thursday, June 30, 2016 10:13:47 AM PDT Ian Romanick wrote: > I think I might want to use gperf for something in Mesa, but I'm not > 100% sure yet. Before I proceed, is it even acceptable to add that as a > build dependency? Why not make it an optional dependency? signature.asc Description:

Re: [Mesa-dev] [PATCH shader-db 2/4] split-to-files.py: fix parsing compute shaders

2016-06-30 Thread Kenneth Graunke
On Thursday, June 30, 2016 5:03:24 PM PDT Marek Olšák wrote: > From: Marek Olšák > > --- > split-to-files.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/split-to-files.py b/split-to-files.py > index 7e14d89..0e1d729 100755 > --- a/split-to-files.py > +++

[Mesa-dev] [AppVeyor] mesa master #1716 failed

2016-06-30 Thread AppVeyor
Build mesa 1716 failed Commit c8ea85 by Brian Paul on 6/28/2016 11:15 PM: svga: use SVGA3D_vgpu10_BufferCopy() for buffer copies\n\nSo that we do copies host-side rather than in the guest with map/memcpy.\n\nTested with piglit arb_copy_buffer-subdata-sync

Re: [Mesa-dev] [PATCH v3] i965: intel_texture_barrier reimplemented

2016-06-30 Thread Alejandro Piñeiro
Ok, thanks for the pointers. Will take a look tomorrow (is 21:00 here). Btw, what do you prefer? To fix it first on the texture barrier with a patch like this, and then import Vulkan's? or forget about fixing with the current status and go directly to import Vulkan's approach? BR On 30/06/16

[Mesa-dev] [PATCH 03/12] st/va: add encode entrypoint

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/config.c | 61 +++--- src/gallium/state_trackers/va/context.c| 57 src/gallium/state_trackers/va/surface.c| 12 --

[Mesa-dev] [PATCH 07/12] st/va: get rate control method from configattrib

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/config.c | 11 +++ src/gallium/state_trackers/va/context.c| 3 ++- src/gallium/state_trackers/va/va_private.h | 1 + 3 files changed, 14 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 10/12] radeon/omx: assign previous values to new structure

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/omx/vid_enc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/state_trackers/omx/vid_enc.c b/src/gallium/state_trackers/omx/vid_enc.c index d70439a..bbc7941 100644 ---

[Mesa-dev] [PATCH 06/12] st/va: colorspace conversion when image is yv12 and surface is nv12

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/image.c | 48 +-- 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/va/image.c b/src/gallium/state_trackers/va/image.c index

[Mesa-dev] [PATCH 02/12] vl: add entry point

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/include/pipe/p_video_state.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/include/pipe/p_video_state.h b/src/gallium/include/pipe/p_video_state.h index 9cd489b..040d2f1 100644 ---

[Mesa-dev] [PATCH 04/12] st/va: use correct pitch value for deriveimage call

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/image.c | 55 --- 1 file changed, 51 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/va/image.c b/src/gallium/state_trackers/va/image.c index

[Mesa-dev] [Bug 95346] Stellaris - Black/super dark planets

2016-06-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95346 --- Comment #11 from Luchesar V. ILIEV --- This seems to have been fixed with the latest Mesa from git. Either this, or the 1.2 upgrade to Stellaris itself did the trick. The only problem left now is the ugly cursor

Re: [Mesa-dev] [PATCH 00/24] Add MESA_shader_integer_functions

2016-06-30 Thread Matt Turner
On Thu, Jun 30, 2016 at 11:37 AM, Matt Turner wrote: > Patches 1-5 are > > Reviewed-by: Matt Turner As are 6-14. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] Add gperf as a build dependency?

2016-06-30 Thread Jose Fonseca
On 30/06/16 18:13, Ian Romanick wrote: I think I might want to use gperf for something in Mesa, but I'm not 100% sure yet. Before I proceed, is it even acceptable to add that as a build dependency? I presume C code generated by gperf is freely usable and it's not subject to GPL, right? (I

[Mesa-dev] [PATCH 11/12] radeon/vce: handle newly added parameters

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vce_52.c | 33 ++ 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_vce_52.c b/src/gallium/drivers/radeon/radeon_vce_52.c index

[Mesa-dev] [PATCH 08/12] st/va: add functions for VAAPI encode

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/buffer.c | 6 + src/gallium/state_trackers/va/picture.c| 170 - src/gallium/state_trackers/va/va_private.h | 3 + 3 files changed, 177 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 09/12] st/va: add preset values for VAAPI encode

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/picture.c | 36 + 1 file changed, 36 insertions(+) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index 26205b1..2d22e8b 100644

[Mesa-dev] [PATCH 05/12] st/va: add nv12 i420 yv12 format to deriveimage call

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/image.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/state_trackers/va/image.c b/src/gallium/state_trackers/va/image.c index c82b554..3c8cc9c 100644 ---

[Mesa-dev] [PATCH 12/12] st/va: enable h264 VAAPI encode

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/config.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/src/gallium/state_trackers/va/config.c b/src/gallium/state_trackers/va/config.c index

Re: [Mesa-dev] [PATCH 06/24] glsl: Add lowering pass for ir_unop_bit_count

2016-06-30 Thread Matt Turner
On Wed, Jun 29, 2016 at 2:04 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/compiler/glsl/ir_optimization.h | 1 + > src/compiler/glsl/lower_instructions.cpp | 53 >

[Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

2016-06-30 Thread Boyuan Zhang
Signed-off-by: Boyuan Zhang --- src/gallium/include/pipe/p_video_state.h | 36 1 file changed, 36 insertions(+) diff --git a/src/gallium/include/pipe/p_video_state.h b/src/gallium/include/pipe/p_video_state.h index d353be6..9cd489b 100644

Re: [Mesa-dev] [PATCH 1/2] glsl: add driconf to zero-init unintialized vars

2016-06-30 Thread Kenneth Graunke
On Saturday, June 25, 2016 8:37:47 AM PDT Rob Clark wrote: > From: Rob Clark > > Some games are sloppy.. perhaps because it is defined behavior for DX or > perhaps because nv blob driver defaults things to zero. > > So add driconf param to force uninitialized variables

Re: [Mesa-dev] [PATCH 00/24] Add MESA_shader_integer_functions

2016-06-30 Thread Matt Turner
Patches 1-5 are Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/3] freedreno/a3xx: Fix sign compare warnings

2016-06-30 Thread Francesco Ansanelli
--- src/gallium/drivers/freedreno/a3xx/fd3_screen.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/freedreno/a3xx/fd3_screen.c b/src/gallium/drivers/freedreno/a3xx/fd3_screen.c index 4aea2fe..013b0ca 100644 ---

[Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

2016-06-30 Thread Francesco Ansanelli
--- src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_screen.c b/src/gallium/drivers/freedreno/a2xx/fd2_screen.c index c2baa6f..fe4849b 100644 ---

  1   2   >