Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

Before my patch, gcc warned about: src/gallium/drivers/freedreno/a2xx/fd2_screen.c:64:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] The change suggested: (fd2_pipe2surface(format) != (enum a2xx_sq_surfaceformat)~0)) { makes both compiler

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

I did a test with: static struct ir3_shader_key key; memset(, 0, sizeof(key)); both gcc and clang seems happy with it. Let me know if you want me to send a patch. 2016-07-29 1:53 GMT+02:00 Rob Clark : > On Thu, Jul 28, 2016 at 6:44 PM, Rob Herring wrote:

Re: [Mesa-dev] [PATCH 03/11] mesa: Implement _mesa_all_varyings_in_vbos.

Hi, On Thursday, July 28, 2016 02:05:08 Fredrik Höglund wrote: > On Wednesday 27 July 2016, Mathias Fröhlich wrote: > > Hi, > > > > On Thursday, June 23, 2016 16:53:59 Fredrik Höglund wrote: > > > On Friday 17 June 2016, mathias.froehl...@gmx.net wrote: > > > > From: Mathias Fröhlich

Re: [Mesa-dev] [GSoC] Update about floating point library

(Re-adding the list) On Mon, Jul 25, 2016 at 4:46 AM, tournier.elie wrote: > Hi. > > Thanks for your email. > It seems that you don't work for nvidia. :P. > > 1. > In my *.shader_test files, I have: > [require] > GLSL >= 1.30 > > Should I still add "#version 130" at the

Re: [Mesa-dev] [PATCH 03/11] mesa: Implement _mesa_all_varyings_in_vbos.

On Wednesday, July 27, 2016 12:36:32 Eric Anholt wrote: > mathias.froehl...@gmx.net writes: > > > From: Mathias Fröhlich > > > > Implement the equivalent of vbo_all_varyings_in_vbos for > > vertex array objects. > > One comment on patch 1, but other than that, 2-11

Re: [Mesa-dev] [PATCH 01/11] mesa: Add flush_vertices argument to _mesa_bind_vertex_buffer.

Good Morning, On Wednesday, July 27, 2016 12:02:52 Eric Anholt wrote: > mathias.froehl...@gmx.net writes: > > > From: Mathias Fröhlich > > > > Similar to _mesa_update_array_format add an argument to > > avoid calling FLUSH_VERTICES in certain cases. > > This will be

Re: [Mesa-dev] [PATCH 2/7] gallium/auxiliary: Add u_bitcast.h header.

On Thu, Jul 28, 2016 at 7:58 PM, Roland Scheidegger wrote: > Am 29.07.2016 um 00:35 schrieb Matt Turner: >> --- >> src/gallium/auxiliary/Makefile.sources | 1 + >> src/gallium/auxiliary/util/u_bitcast.h | 57 >> ++ >> 2 files changed, 58

Re: [Mesa-dev] [PATCH v2] egl: android: query native window default width and height

On Fri, Jul 29, 2016 at 2:51 AM, Haixia Shi wrote: > On android platform, the width and height of a native window surface may > be updated after initialization. It is therefore necessary to query android > framework for the current width and height. > > v2: remove Android

Re: [Mesa-dev] [PATCH 1/7] glsl_to_tgsi: Avoid aliasing violations.

Reviewed-by: Dave Airlie On 29 July 2016 at 08:35, Matt Turner wrote: > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp >

Re: [Mesa-dev] [PATCH v2 25/35] i965/blorp: Map 1-D render targets with DIM_LAYOUT_GEN4_2D as 2D on gen9

On Jul 28, 2016 2:41 AM, "Pohjolainen, Topi" wrote: > > On Tue, Jul 26, 2016 at 03:02:16PM -0700, Jason Ekstrand wrote: > > The sampling hardware can handle them ok. It just looks at the tiling to > > determine whether it's the new gen9 1-D layout or the old one. The

Re: [Mesa-dev] [PATCH] anv/device: Add limits for InterpolationOffset

On Jul 28, 2016 7:37 PM, "Anuj Phogat" wrote: > > Fixes the vulkan cts regression in test dEQP-VK.api.info.device.properties > > Cc: Mark Janes > Cc: Jason Ekstrand > Signed-off-by: Anuj Phogat > --- >

Re: [Mesa-dev] [PATCH 12/17] glsl/ast: Allow redeclaration of gl_LastFragData with different precision qualifier.

Kenneth Graunke writes: > On Wednesday, July 20, 2016 9:49:42 PM PDT Francisco Jerez wrote: >> --- >> src/compiler/glsl/ast_to_hir.cpp | 13 + >> 1 file changed, 13 insertions(+) >> >> diff --git a/src/compiler/glsl/ast_to_hir.cpp >>

Re: [Mesa-dev] [PATCH v2 0/7] Add DCC Support.

___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] anv/device: Add limits for InterpolationOffset

Fixes the vulkan cts regression in test dEQP-VK.api.info.device.properties Cc: Mark Janes Cc: Jason Ekstrand Signed-off-by: Anuj Phogat --- src/intel/vulkan/anv_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

On Thu, Jul 28, 2016 at 6:55 PM, Rob Clark wrote: > On Thu, Jul 28, 2016 at 6:36 PM, Rob Herring wrote: >> On Thu, Jun 30, 2016 at 12:16 PM, Francesco Ansanelli >> wrote: >>> --- >>> src/gallium/drivers/freedreno/a2xx/fd2_screen.c |

Re: [Mesa-dev] [PATCH 2/7] gallium/auxiliary: Add u_bitcast.h header.

Am 29.07.2016 um 00:35 schrieb Matt Turner: > --- > src/gallium/auxiliary/Makefile.sources | 1 + > src/gallium/auxiliary/util/u_bitcast.h | 57 > ++ > 2 files changed, 58 insertions(+) > create mode 100644 src/gallium/auxiliary/util/u_bitcast.h > > diff --git

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

On Thu, Jul 28, 2016 at 6:36 PM, Rob Herring wrote: > On Thu, Jun 30, 2016 at 12:16 PM, Francesco Ansanelli > wrote: >> --- >> src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On Thu, Jul 28, 2016 at 6:44 PM, Rob Herring wrote: > On Thu, Jul 28, 2016 at 1:07 PM, Rob Clark wrote: >> tbh, I haven't used anything as ancient as 4.6 in a while.. these days >> I'm using 6.1 and even with 5.x I don't remember seeing that warning. > >

[Mesa-dev] [PATCH] vl/util: Fix YV12/I420 convert to NV12 U/V reversal.

Fix VAAPI YV12/I420 convert to NV12 U/V reversal. Input order is YVU when this is called. Signed-off-by: Andy Furniss --- src/gallium/auxiliary/util/u_video.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_video.h

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On Thu, Jul 28, 2016 at 1:07 PM, Rob Clark wrote: > tbh, I haven't used anything as ancient as 4.6 in a while.. these days > I'm using 6.1 and even with 5.x I don't remember seeing that warning. FWIW, clang 3.8 throws the warning too. Rob

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: Fix sign compare warnings

On Thu, Jun 30, 2016 at 12:16 PM, Francesco Ansanelli wrote: > --- > src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_screen.c >

[Mesa-dev] [PATCH 4/7] r600g: Avoid aliasing violations.

--- src/gallium/drivers/r600/r600_asm.c| 3 ++- src/gallium/drivers/r600/r600_shader.c | 19 +++ 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/drivers/r600/r600_asm.c index e2f54cb..f85993d 100644 ---

[Mesa-dev] [PATCH 6/7] i915: Avoid aliasing violation.

--- src/mesa/drivers/dri/i915/intel_clear.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i915/intel_clear.c b/src/mesa/drivers/dri/i915/intel_clear.c index 8cf7c142..4306826 100644 --- a/src/mesa/drivers/dri/i915/intel_clear.c +++

[Mesa-dev] [PATCH 1/7] glsl_to_tgsi: Avoid aliasing violations.

--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 38e2c4a..362559f 100644 --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp +++

[Mesa-dev] [PATCH 5/7] draw: Avoid aliasing violations.

--- src/gallium/auxiliary/draw/draw_cliptest_tmp.h | 6 -- src/gallium/auxiliary/draw/draw_pipe_clip.c| 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_cliptest_tmp.h b/src/gallium/auxiliary/draw/draw_cliptest_tmp.h index

[Mesa-dev] [PATCH 7/7] mesa: Drop -fno-strict-aliasing.

Improves performance of OglBatch7 by 4.06851% +/- 1.17925% (n=169) on Haswell, and cuts ~18k of .text: text data bss dec hex filename 5824627 28781629384 6141827 5db783 before/i965_dri.so 5806354 28781629384 6123554 5d7022 after/i965_dri.so Reviewed-by:

[Mesa-dev] [PATCH 2/7] gallium/auxiliary: Add u_bitcast.h header.

--- src/gallium/auxiliary/Makefile.sources | 1 + src/gallium/auxiliary/util/u_bitcast.h | 57 ++ 2 files changed, 58 insertions(+) create mode 100644 src/gallium/auxiliary/util/u_bitcast.h diff --git a/src/gallium/auxiliary/Makefile.sources

[Mesa-dev] [PATCH 3/7] r300g: Avoid aliasing violation.

--- src/gallium/drivers/r300/compiler/radeon_inline_literals.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r300/compiler/radeon_inline_literals.c b/src/gallium/drivers/r300/compiler/radeon_inline_literals.c index 492f00e..c40a380 100644 ---

[Mesa-dev] [PATCH 1/9] i965/eu: Take into account the target cache argument in brw_set_dp_read_message.

brw_set_dp_read_message() was setting the data cache as send message SFID on Gen7+ hardware, ignoring the target cache specified by the caller. Some of the callers were passing a bogus target cache value as argument relying on brw_set_dp_read_message not to take it into account. Fix them too.

[Mesa-dev] [PATCH 0/9] i965: Implement coherent framebuffer fetch on Gen9+.

This series gets coherent render target reads working with the i965 driver and exposes the EXT_shader_framebuffer_fetch extension on Gen9+ platforms. It's dependent on the series I sent last week to make the driver-independent changes to enable framebuffer fetch [1], and the series to enable

[Mesa-dev] [PATCH 5/9] i965/fs: Define logical framebuffer read opcode and lower it to physical reads.

--- src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/brw_fs.cpp | 24 src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 1 + src/mesa/drivers/dri/i965/brw_shader.cpp | 2 ++ 4 files changed, 28 insertions(+) diff --git

[Mesa-dev] [PATCH 3/9] i965/disasm: Fix RC message type strings on Gen7+.

--- src/mesa/drivers/dri/i965/brw_disasm.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_disasm.c b/src/mesa/drivers/dri/i965/brw_disasm.c index d74d5d5..cca4c8b 100644 --- a/src/mesa/drivers/dri/i965/brw_disasm.c

[Mesa-dev] [PATCH 7/9] i965/fs: Remove special casing of framebuffer writes in scheduler code.

The reason why it was safe for the scheduler to ignore the side effects of framebuffer write instructions was that its side effects couldn't have had any influence on any other instruction in the program, because we weren't doing framebuffer reads, and framebuffer writes were always

[Mesa-dev] [PATCH 8/9] i965/fs: Hook up coherent framebuffer reads to the NIR front-end.

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index e3215da..85e111d 100644 ---

[Mesa-dev] [PATCH 2/9] i965/eu: Add codegen support for the Gen9+ render target read message.

--- src/mesa/drivers/dri/i965/brw_defines.h | 4 src/mesa/drivers/dri/i965/brw_eu.h | 8 src/mesa/drivers/dri/i965/brw_eu_emit.c | 28 3 files changed, 40 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h

[Mesa-dev] [PATCH 4/9] i965/fs: Define framebuffer read virtual opcode.

--- src/mesa/drivers/dri/i965/brw_defines.h| 3 +++ src/mesa/drivers/dri/i965/brw_fs.cpp | 2 ++ src/mesa/drivers/dri/i965/brw_fs.h | 2 ++ src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 20 src/mesa/drivers/dri/i965/brw_shader.cpp |

[Mesa-dev] [PATCH 6/9] i965/fs: Don't CSE render target messages with different target index.

We weren't checking the fs_inst::target field when comparing whether two instructions are equal. For FB writes it doesn't matter because they aren't CSE-able anyway, but this would have become a problem with FB reads which are expression-like instructions. ---

[Mesa-dev] [PATCH 9/9] i965: Expose shader framebuffer fetch extensions on Gen9+.

--- src/mesa/drivers/dri/i965/intel_extensions.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/dri/i965/intel_extensions.c index 12bf454..33114db 100644 --- a/src/mesa/drivers/dri/i965/intel_extensions.c +++

[Mesa-dev] [PATCH] egl/dri2: Do not need to check return value from mtx_lock

This removes unnecessary error checks on return result of mtx_lock calls as in all other places in MESA source since there is no chance that mtx_lock returns any of error codes in current implementation. Signed-off-by: Dongwon Kim --- src/egl/drivers/dri2/egl_dri2.c | 21

Re: [Mesa-dev] [PATCH 1/2] anv/pipeline: Fix setting per sample shading in pixel shader

On Jul 28, 2016 2:11 PM, "Anuj Phogat" wrote: > > > > On Thu, Jul 28, 2016 at 11:58 AM, Jason Ekstrand wrote: >> >> Please fix gen7 while you're at it. It probably needs the exact same change. With that, > > ​gen7 needs multisample support before we

Re: [Mesa-dev] [PATCH 1/2] anv/pipeline: Fix setting per sample shading in pixel shader

On Thu, Jul 28, 2016 at 11:58 AM, Jason Ekstrand wrote: > Please fix gen7 while you're at it. It probably needs the exact same > change. With that, > ​gen7 needs multisample support before we can test sample shading. I talked to Nanley about it and now working on fixing

Re: [Mesa-dev] [PATCH 1/2] anv/pipeline: Fix setting per sample shading in pixel shader

Please fix gen7 while you're at it. It probably needs the exact same change. With that, Reviewed-by: Jason Ekstrand On Jul 28, 2016 1:31 PM, "Anuj Phogat" wrote: > We should use the persample_dispatch variable in prog_data. > > Fixes all (~60) the

Re: [Mesa-dev] [PATCH 2/2] anv: Enable per sample shading on gen8+

Rb On Jul 28, 2016 1:31 PM, "Anuj Phogat" wrote: > Vulkan CTS test results on gen9: > ./deqp-vk --deqp-case=dEQP-VK.pipeline.multisample.min_sample_shading* > Test run totals: > Passed:60/90 (66.7%) > Failed:0/90 (0.0%) > Not supported: 30/90 (33.3%)

Re: [Mesa-dev] [PATCH v2 08/27] i965/blorp: Stop using the miptree in state setup for tex/rt surfaces

On Jul 28, 2016 12:05 PM, "Pohjolainen, Topi" wrote: > > On Tue, Jul 26, 2016 at 03:11:12PM -0700, Jason Ekstrand wrote: > > Instead, we add a bo and offset field to brw_blorp_surface_info and use > > those in the backend. > > --- > >

Re: [Mesa-dev] [PATCH v2 09/27] i964/blorp: Set up most aux surfaces up-front

On Jul 28, 2016 12:56 PM, "Pohjolainen, Topi" wrote: > > On Tue, Jul 26, 2016 at 03:11:13PM -0700, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_blorp.c | 43 --- > > src/mesa/drivers/dri/i965/brw_blorp.h | 4 > >

Re: [Mesa-dev] [PATCH v2 08/27] i965/blorp: Stop using the miptree in state setup for tex/rt surfaces

On Jul 28, 2016 12:34 PM, "Pohjolainen, Topi" wrote: > > On Tue, Jul 26, 2016 at 03:11:12PM -0700, Jason Ekstrand wrote: > > Instead, we add a bo and offset field to brw_blorp_surface_info and use > > those in the backend. > > --- > >

[Mesa-dev] [PATCH 1/2] anv/pipeline: Fix setting per sample shading in pixel shader

We should use the persample_dispatch variable in prog_data. Fixes all (~60) the DEQP sample shading tests. Many tests exited with VK_ERROR_OUT_OF_DEVICE_MEMORY without this patch. V2: Use the shader key bits set in brw_compile_fs (Jason) Cc: Jason Ekstrand Signed-off-by:

[Mesa-dev] [PATCH 2/2] anv: Enable per sample shading on gen8+

Vulkan CTS test results on gen9: ./deqp-vk --deqp-case=dEQP-VK.pipeline.multisample.min_sample_shading* Test run totals: Passed:60/90 (66.7%) Failed:0/90 (0.0%) Not supported: 30/90 (33.3%) Warnings: 0/90 (0.0%) Cc: Jason Ekstrand Signed-off-by:

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

tbh, I haven't used anything as ancient as 4.6 in a while.. these days I'm using 6.1 and even with 5.x I don't remember seeing that warning. Maybe we can just drop -Wmissing-field-initializers?? BR, -R On Thu, Jul 28, 2016 at 1:16 PM, Francesco Ansanelli wrote: > Hi, > >

Re: [Mesa-dev] [PATCH v2 30/35] isl: Add asserts for gen8+ X/YOffset rules

On Thu, Jul 28, 2016 at 09:33:37AM -0700, Jason Ekstrand wrote: >On Jul 28, 2016 8:02 AM, "Pohjolainen, Topi" ><[1]topi.pohjolai...@intel.com> wrote: >> >> On Tue, Jul 26, 2016 at 03:02:21PM -0700, Jason Ekstrand wrote: >> > --- >> > src/intel/isl/isl_surface_state.c | 10

Re: [Mesa-dev] [PATCH v2 09/27] i964/blorp: Set up most aux surfaces up-front

On Tue, Jul 26, 2016 at 03:11:13PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 43 > --- > src/mesa/drivers/dri/i965/brw_blorp.h | 4 > 2 files changed, 29 insertions(+), 18 deletions(-) > > diff --git

[Mesa-dev] [PATCH v2] egl: android: query native window default width and height

On android platform, the width and height of a native window surface may be updated after initialization. It is therefore necessary to query android framework for the current width and height. v2: remove Android specific #ifdef's and just implement the fallback directly if the platform

Re: [Mesa-dev] [PATCH v2 08/27] i965/blorp: Stop using the miptree in state setup for tex/rt surfaces

On Tue, Jul 26, 2016 at 03:11:12PM -0700, Jason Ekstrand wrote: > Instead, we add a bo and offset field to brw_blorp_surface_info and use > those in the backend. > --- > src/mesa/drivers/dri/i965/brw_blorp.c| 10 +--- > src/mesa/drivers/dri/i965/brw_blorp.h| 3 ++- >

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

Hi, with my version of the compiler: gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3 and original code ({0}) I get: src/gallium/drivers/freedreno/ir3/ir3_shader.c:312:17: warning: missing braces around initializer [-Wmissing-braces] src/gallium/drivers/freedreno/ir3/ir3_shader.c:312:17: warning:

Re: [Mesa-dev] [PATCH v2 08/27] i965/blorp: Stop using the miptree in state setup for tex/rt surfaces

On Tue, Jul 26, 2016 at 03:11:12PM -0700, Jason Ekstrand wrote: > Instead, we add a bo and offset field to brw_blorp_surface_info and use > those in the backend. > --- > src/mesa/drivers/dri/i965/brw_blorp.c| 10 +--- > src/mesa/drivers/dri/i965/brw_blorp.h| 3 ++- >

Re: [Mesa-dev] [PATCH v2 2/2] st/mesa: provide GL_OES_copy_image support by caching the original ETC data

On Thu, Jul 28, 2016 at 5:35 PM, Ilia Mirkin wrote: > Praise from Caesar is praise indeed :) Is that a R-b, or just saying > it for posterity? Acked-by: Marek Olšák Marek ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] egl: android: query native window default width and height

On Wed, Jul 27, 2016 at 5:57 PM, Haixia Shi wrote: > On android platform, the width and height of a native window surface may > be updated after initialization. It is therefore necessary to query android > framework for the current width and height. > >

Re: [Mesa-dev] [PATCH v2 30/35] isl: Add asserts for gen8+ X/YOffset rules

On Jul 28, 2016 8:02 AM, "Pohjolainen, Topi" wrote: > > On Tue, Jul 26, 2016 at 03:02:21PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl_surface_state.c | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git

Re: [Mesa-dev] [PATCH] st_glsl_to_tgsi: only skip over slots of an input array that are present

Le 25/07/2016 à 18:08, Nicolai Hähnle a écrit : > From: Nicolai Hähnle > > When an application declares varying arrays but does not actually do any > indirect indexing, some array indices may end up unused in the consuming > shader, so the number of input slots that

Re: [Mesa-dev] [PATCH v2 2/2] st/mesa: provide GL_OES_copy_image support by caching the original ETC data

Praise from Caesar is praise indeed :) Is that a R-b, or just saying it for posterity? On Thu, Jul 28, 2016 at 7:25 AM, Marek Olšák wrote: > Well, I couldn't find anything wrong with this. > > Marek > > On Sat, Jul 16, 2016 at 6:21 PM, Ilia Mirkin wrote:

Re: [Mesa-dev] [PATCH 06/95] i965/vec4/nir: fix nir_intrinsic_load_uniform for doubles

On Thu, Jul 28, 2016 at 2:25 AM, Iago Toral wrote: > On Thu, 2016-07-28 at 15:49 +1000, Timothy Arceri wrote: >> On Tue, 2016-07-19 at 12:40 +0200, Iago Toral Quiroga wrote: >> > >> > From: Connor Abbott >> > >> > --- >> >

Re: [Mesa-dev] [PATCH v2 07/27] i965/blorp/blit: Move format work-arounds before surface_info_init

On Tue, Jul 26, 2016 at 03:11:11PM -0700, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 30 > +--- > 1 file changed, 14 insertions(+), 16 deletions(-) Looks cleaner: Reviewed-by: Topi Pohjolainen > > diff

Re: [Mesa-dev] [PATCH v2 29/35] i965/blorp: Only do offset hacks for fake W-tiling and IMS

On Thu, Jul 28, 2016 at 05:29:44PM +0300, Pohjolainen, Topi wrote: > On Thu, Jul 28, 2016 at 07:04:08AM -0700, Jason Ekstrand wrote: > >On Jul 28, 2016 7:59 AM, "Pohjolainen, Topi" > ><[1]topi.pohjolai...@intel.com> wrote: > >> > >> On Tue, Jul 26, 2016 at 03:02:20PM -0700, Jason

Re: [Mesa-dev] [PATCH v2 29/35] i965/blorp: Only do offset hacks for fake W-tiling and IMS

On Thu, Jul 28, 2016 at 07:04:08AM -0700, Jason Ekstrand wrote: >On Jul 28, 2016 7:59 AM, "Pohjolainen, Topi" ><[1]topi.pohjolai...@intel.com> wrote: >> >> On Tue, Jul 26, 2016 at 03:02:20PM -0700, Jason Ekstrand wrote: >> > Since the dawn of time, blorp has used offsets

Re: [Mesa-dev] [PATCH v2 05/27] i965/miptree: Use the isl helpers for creating aux surfaces

On Jul 28, 2016 9:00 AM, "Pohjolainen, Topi" wrote: > > On Tue, Jul 26, 2016 at 03:11:09PM -0700, Jason Ekstrand wrote: > > In order for the calculations of things such as fast clear rectangles to > > work, we need more details of the auxiliary surface to be correct.

Re: [Mesa-dev] [PATCH v2 29/35] i965/blorp: Only do offset hacks for fake W-tiling and IMS

On Jul 28, 2016 7:59 AM, "Pohjolainen, Topi" wrote: > > On Tue, Jul 26, 2016 at 03:02:20PM -0700, Jason Ekstrand wrote: > > Since the dawn of time, blorp has used offsets directly to get at different > > mip levels and array slices of surfaces. This isn't really

Re: [Mesa-dev] [PATCH v2 05/27] i965/miptree: Use the isl helpers for creating aux surfaces

On Tue, Jul 26, 2016 at 03:11:09PM -0700, Jason Ekstrand wrote: > In order for the calculations of things such as fast clear rectangles to > work, we need more details of the auxiliary surface to be correct. In > particular, we need to be able to trust the width and height fields. > (These are

Re: [Mesa-dev] [PATCH glx/glxglvnd] Avoid overflow in 'last' variable of FindGLXFunction(...)

On Thu, Jul 14, 2016 at 05:20:55PM +0100, Emil Velikov wrote: > On 14 July 2016 at 15:23, Eric Engestrom wrote: > > On Thu, Jul 14, 2016 at 03:21:20PM +0200, Stefan Dirsch wrote: > >> This 'last' variable used in FindGLXFunction(...) may become negative, > >> but has

Re: [Mesa-dev] [PATCH v2 03/27] i965/miptree: Use mcs_mt->qpitch for aux surfaces

On Thu, Jul 28, 2016 at 04:50:10PM +0300, Pohjolainen, Topi wrote: > On Tue, Jul 26, 2016 at 03:11:07PM -0700, Jason Ekstrand wrote: > > At one point, we were doing this correctly. It must have gotten lost in > > one of the many rebases. > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c

Re: [Mesa-dev] [PATCH v2 03/27] i965/miptree: Use mcs_mt->qpitch for aux surfaces

On Tue, Jul 26, 2016 at 03:11:07PM -0700, Jason Ekstrand wrote: > At one point, we were doing this correctly. It must have gotten lost in > one of the many rebases. > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git

[Mesa-dev] [PATCHv2 6/6] isl: automake: use VISIBILITY_CFLAGS to restrict symbol visibility

From: Emil Velikov v2: Add VISIBILITY_CFLAGS to AM_CFLAGS (Ken) Cc: "12.0" Reviewed-by: Jason Ekstrand (v1) Signed-off-by: Emil Velikov --- src/intel/isl/Makefile.am | 18

Re: [Mesa-dev] [PATCH v2 04/27] isl: Add helpers for creating different types of aux surfaces

On Tue, Jul 26, 2016 at 03:11:08PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 121 > > src/intel/isl/isl.h | 15 +++ > 2 files changed, 136 insertions(+) > > diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > index

[Mesa-dev] [PATCHv2 2/6] anv: automake: use VISIBILITY_CFLAGS to restrict symbol visibility

From: Emil Velikov Hide the internal symbols and annotate the vk_icdGetInstanceProcAddr as public since the loader needs it (since v1 of the loader interface). v2: Add VISIBILITY_CFLAGS to AM_CFLAGS (Ken) Cc: "12.0" Reviewed-by:

[Mesa-dev] [PATCH 1/6] anv: remove internal 'validate' layer

From: Emil Velikov Presently the layer has only a single entry point. As mentioned by Jason the function does not validate anything that isn't checked elsewhere, thus we can drop the whole thing. Cc: "12.0" Cc: Jason Ekstrand

Re: [Mesa-dev] [PATCH v2 35/35] isl/state: Add an assertion for IVB multisample array textures

On Tue, Jul 26, 2016 at 03:02:26PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl_surface_state.c | 13 + > 1 file changed, 13 insertions(+) Patches 33-35 are: Reviewed-by: Topi Pohjolainen > > diff --git a/src/intel/isl/isl_surface_state.c >

Re: [Mesa-dev] [PATCH v2 32/35] i965/blorp: Simplify depth buffer state setup a bit

On Tue, Jul 26, 2016 at 03:02:23PM -0700, Jason Ekstrand wrote: > The data comes in via ISL in a format that's almost directly usable by the > hardware so we can avoid some of the conversion headache. > --- > src/mesa/drivers/dri/i965/gen6_blorp.c | 34 -- >

Re: [Mesa-dev] [PATCH v2] egl/dri2: Add reference count for dri2_egl_display

On 22 July 2016 at 04:27, Nicolas Boichat wrote: > android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls > eglTerminate, followed by eglReleaseThread. A similar case is > observed in this bug: https://bugs.freedesktop.org/show_bug.cgi?id=69622, > where the test

Re: [Mesa-dev] [PATCH v2 31/35] i965/blorp: Use the generic surface state path for gen8 textures

On Tue, Jul 26, 2016 at 03:02:22PM -0700, Jason Ekstrand wrote: > Now that the generic blorp path uses base level/layer, there's no need to > make gen8 special. Reviewed-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_state.h| 7 >

Re: [Mesa-dev] [PATCH v2 30/35] isl: Add asserts for gen8+ X/YOffset rules

On Tue, Jul 26, 2016 at 03:02:21PM -0700, Jason Ekstrand wrote: > --- > src/intel/isl/isl_surface_state.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/intel/isl/isl_surface_state.c > b/src/intel/isl/isl_surface_state.c > index 6febcbf..fb23414 100644 > ---

Re: [Mesa-dev] [PATCH v2 29/35] i965/blorp: Only do offset hacks for fake W-tiling and IMS

On Tue, Jul 26, 2016 at 03:02:20PM -0700, Jason Ekstrand wrote: > Since the dawn of time, blorp has used offsets directly to get at different > mip levels and array slices of surfaces. This isn't really necessary since > we can just use the base level/layer provided in the surface state. While >

Re: [Mesa-dev] [PATCH v4 03/11] gallium: add common pipe_screen reference counting functions

On Fri, Jul 22, 2016 at 6:22 PM, Rob Herring wrote: > In order to prevent multiple pipe_screens being created in the same > process, lookup of the DRM FD and reference counting of the pipe_screen > are needed. Several implementations of this exist in various gallium >

[Mesa-dev] [PATCH] anv: GetDeviceImageFormatProperties: fix TRANSFER formats

We let the user believe we support some transfer formats which we don't. This can lead to crashes when actually trying to use those formats. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_formats.c | 7 +-- 1 file changed, 5 insertions(+), 2

Re: [Mesa-dev] [PATCH v2 2/2] st/mesa: provide GL_OES_copy_image support by caching the original ETC data

Well, I couldn't find anything wrong with this. Marek On Sat, Jul 16, 2016 at 6:21 PM, Ilia Mirkin wrote: > The additional provision of GL_OES_copy_image is that it work for ETC. > However many desktop GPUs don't have native ETC support, so st/mesa does > the decoding by

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On Thu, Jul 28, 2016 at 6:31 AM, Emil Velikov wrote: > On 28 July 2016 at 09:21, Eric Engestrom wrote: >> On Wed, Jul 27, 2016 at 07:37:56PM +0200, Francesco Ansanelli wrote: >>> Hello, >>> >>> unluckily this didn't fix the warning... >>> I've

Re: [Mesa-dev] [PATCH 19/87] glsl: cache more uniform storage values

On 07/13/2016 05:47 AM, Timothy Arceri wrote: --- src/compiler/glsl/shader_cache.cpp | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 08f8e37..8aae1c8 100644 ---

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On 28 July 2016 at 09:21, Eric Engestrom wrote: > On Wed, Jul 27, 2016 at 07:37:56PM +0200, Francesco Ansanelli wrote: >> Hello, >> >> unluckily this didn't fix the warning... >> I've done some more compile testing and found this solution: >> >> - static struct

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 96762, which changed state. Bug 96762 Summary: [radeonsi,apitrace] Firewatch: nothing rendered in scrollable (text) areas https://bugs.freedesktop.org/show_bug.cgi?id=96762 What|Removed

Re: [Mesa-dev] [PATCH 1/3] loader/dri3: Destroy Present event context when destroying drawable

On Thu, Jul 28, 2016 at 06:34:44PM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > Without this, the X server may accumulate stale Present event contexts > if a client ends up creating and destroying DRI drawables for the same > window. > > Signed-off-by: Michel

[Mesa-dev] [PATCH 1/3] loader/dri3: Destroy Present event context when destroying drawable

From: Michel Dänzer Without this, the X server may accumulate stale Present event contexts if a client ends up creating and destroying DRI drawables for the same window. Signed-off-by: Michel Dänzer --- src/loader/loader_dri3_helper.c | 8

[Mesa-dev] [PATCH 3/3] anv/x11: Destroy Present event context when destroying swapchain

From: Michel Dänzer Without this, the X server may accumulate stale Present event contexts if a client creates and destroys multiple swapchains using the same window. Signed-off-by: Michel Dänzer --- NOTE: This patch is completely untested!

[Mesa-dev] [PATCH 2/3] vl/dri3: Destroy Present event context when destroying drawable

From: Michel Dänzer Without this, the X server may accumulate stale Present event contexts if a client performs several video decoding sessions using the same window. Signed-off-by: Michel Dänzer --- src/gallium/auxiliary/vl/vl_winsys_dri3.c |

[Mesa-dev] [PATCH 0/3] Destroy Present event contexts

Running XTS (the X test suite) on Xephyr using glamor running on Xorg, I stumbled upon an issue: * XTS causes Xephyr to keep resetting and starting new server generations * glamor creates a new GLX context for each server generation but re-uses the same window This caused Xorg to accumulate

Re: [Mesa-dev] [PATCH 5/6] anv: remove dummy VK_DEBUG_MARKER_EXT entry points

On Wed, Jul 27, 2016 at 02:02:54PM +0100, Emil Velikov wrote: > From: Emil Velikov > > The vkCmdDbgMarker{Begin,End} symbols are exported, yet the json does not +"advertise" > that the driver supports the extension. Furturmore the functions are empty > stubs.

Re: [Mesa-dev] [PATCH 3/4] freedreno/ir3: Add missing braces in initializer

On Wed, Jul 27, 2016 at 07:37:56PM +0200, Francesco Ansanelli wrote: > Hello, > > unluckily this didn't fix the warning... > I've done some more compile testing and found this solution: > > - static struct ir3_shader_key key = {{0}}; > +static struct ir3_shader_key key = {{{0, 0, 0, 0, 0, 0, 0,

Re: [Mesa-dev] [PATCH 6/6] isl: automake: use VISIBILITY_CFLAGS to restrict symbol visibility

On Wednesday, July 27, 2016 2:02:55 PM PDT Emil Velikov wrote: > From: Emil Velikov > > Cc: "12.0" > Cc: Jason Ekstrand > Signed-off-by: Emil Velikov > --- >

Re: [Mesa-dev] [PATCH 2/6] anv: automake: use VISIBILITY_CFLAGS to restrict symbol visibility

On Wednesday, July 27, 2016 2:02:51 PM PDT Emil Velikov wrote: > From: Emil Velikov > > Hide the internal symbols and annotate the vk_icdGetInstanceProcAddr as public > since the loader needs it (as of v1 of the loader interface). > > Cc: "12.0"

Re: [Mesa-dev] [Patch v2] clover: make GCC 4.8 happy

On Thu, Jul 28, 2016 at 12:20:25AM +0200, Dieter Nützel wrote: > Without this GCC 4.8.x throws below error: > > error: invalid initialization of non-const reference of type > 'clover::llvm::compat::raw_ostream_to_emit_file {aka > llvm::raw_svector_ostream&}' > from an rvalue of type '' > > v2:

Re: [Mesa-dev] [PATCH v2 27/35] i965/blorp: Pass the Z component into all texture operations

On Tue, Jul 26, 2016 at 03:02:18PM -0700, Jason Ekstrand wrote: > Multisample array surfaces on IVB don't support the minimum array element > surface attribute so it needs to come through the sampler message. We may > as well just pass it through everything. > --- >

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

https://bugs.freedesktop.org/show_bug.cgi?id=97102 --- Comment #1 from Jan Ziak <0xe2.0x9a.0...@gmail.com> --- Created attachment 125361 --> https://bugs.freedesktop.org/attachment.cgi?id=125361=edit gdb.log -- You are receiving this mail because: You are the assignee for the bug. You are the

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

https://bugs.freedesktop.org/show_bug.cgi?id=97102 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added CC|

  1   2   >