Re: [Mesa-dev] [PATCH] i965: Disable the unlit centroid workaround on Gen7.

2016-08-01 Thread Kenneth Graunke
On Monday, August 1, 2016 12:48:47 PM PDT Matt Turner wrote: > Once upon a time (commit 8313f44409) Paul added code for the unlit > centroid workaround (WaCopyUnlitCentroidBarys). His commit message > claims it fixed the EXT_framebuffer_multisample/interpolation {2,4} >

[Mesa-dev] [PATCH] i965: Rework the unlit centroid workaround.

2016-08-01 Thread Kenneth Graunke
Previously, for every input, we moved the dispatch mask to the flag register, then emitted two predicated PLN instructions, one with centroid barycentric coordinates (for normal pixels), and one with pixel barycentric coordinates (for unlit helper pixels). Instead, we can simply emit a set of

Re: [Mesa-dev] [PATCH 02/18] mesa: Add {OES, EXT}_tessellation_shader to the extensions table.

2016-08-01 Thread Kenneth Graunke
On Monday, August 1, 2016 7:06:14 PM PDT Ilia Mirkin wrote: > I'm looking at these on my phone, so perhaps I missed it - do you ever end > up turning them on, or is that left to later series? No...not yet. This series gets almost all of dEQP passing, except for a couple program interface query

Re: [Mesa-dev] [PATCH 2/2] glsl: struct constructors/initializers only allow implicit conversions

2016-08-01 Thread Timothy Arceri
On Mon, 2016-08-01 at 12:05 +0300, Andres Gomez wrote: > On Mon, 2016-08-01 at 10:01 +1000, Timothy Arceri wrote: > > On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote: > > [snip] > > > diff --git a/src/compiler/glsl/ast_function.cpp > > > b/src/compiler/glsl/ast_function.cpp > > > index

Re: [Mesa-dev] [PATCH 0/3] Destroy Present event contexts

2016-08-01 Thread Michel Dänzer
On 28.07.2016 18:34, Michel Dänzer wrote: > Running XTS (the X test suite) on Xephyr using glamor running on Xorg, > I stumbled upon an issue: > > * XTS causes Xephyr to keep resetting and starting new server generations > * glamor creates a new GLX context for each server generation but re-uses

Re: [Mesa-dev] [Mesa-stable] [PATCH 14/18] glsl: Don't include the array index.

2016-08-01 Thread Timothy Arceri
On Mon, 2016-08-01 at 18:40 -0400, Ilia Mirkin wrote: > Fwiw I remember having trouble finding justification for the comments > in that issue, and iirc the opposite seemed to be indicated by the > spec text. (E.g.that array indices should be maintained.) I suspect > there are also AoA

Re: [Mesa-dev] [PATCH 15/18] Revert "glsl/linker: Don't include interface name for built-in blocks"

2016-08-01 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 16/18] glsl: Fix the program resource names of gl_TessLevelOuter/Inner[].

2016-08-01 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 18/18] glsl: Combine GS and TES array resizing visitors.

2016-08-01 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 12/12] gallium/radeon/winsyses: decrease max_alloc_size to 1/3 of largest heap

2016-08-01 Thread Michel Dänzer
On 01.08.2016 16:35, Michel Dänzer wrote: > On 30.07.2016 06:42, Marek Olšák wrote: >> From: Marek Olšák >> >> This is controversial, but I don't see a better way out of this. >> >> Tonga has 2 GB of VRAM and 2 GB of GTT. amdgpu is not capable of submitting >> an IB

Re: [Mesa-dev] [PATCH 17/18] glsl: Fix location bias for patch variables.

2016-08-01 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 10/18] glsl: Delete bogus ir_set_program_inouts assert.

2016-08-01 Thread Timothy Arceri
On Mon, 2016-08-01 at 10:29 -0700, Kenneth Graunke wrote: > This assertion is bogus.  Varying structs, and arrays of structs, are > allowed by GLSL, and we can see them here.  While we currently don't > have any partial-variable support for those, simply returning false > and marking the entire

Re: [Mesa-dev] [PATCH 09/18] glsl: Handle patch qualifier on interface blocks.

2016-08-01 Thread Timothy Arceri
On Mon, 2016-08-01 at 10:29 -0700, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > --- >  src/compiler/glsl/ast_to_hir.cpp |  4 >  src/compiler/glsl/glsl_parser.yy | 11 +++ >  src/compiler/glsl/glsl_parser_extras.cpp |  3 +++ >  3

Re: [Mesa-dev] [PATCH 04/18] glsl: Add a has_tessellation_shader() helper.

2016-08-01 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 08/18] glsl: Simplify interface qualifier parsing.

2016-08-01 Thread Timothy Arceri
On Mon, 2016-08-01 at 10:29 -0700, Kenneth Graunke wrote: > This better matches the grammar in section 4.3.9 of the GLSL 4.5 > spec, > and also removes some redundant code. > > Signed-off-by: Kenneth Graunke Nice! Yes this is how I should have done it when I got ride of 

Re: [Mesa-dev] [PATCH 13/18] mesa: Fix add_index_to_name logic

2016-08-01 Thread Timothy Arceri
On Mon, 2016-08-01 at 10:29 -0700, Kenneth Graunke wrote: > From: Ian Romanick > > Our piglit tests for geometry and tessellation shader inputs were > incorrect.  Array shader inputs and output should have '[0]' on the > end > regardless of stage.  In addtion, transform

[Mesa-dev] [PATCH] gbm: Correct bo_import documentation (trivial)

2016-08-01 Thread Ben Widawsky
Missed here: commit a43d286ef7ff65087b1f051d071b829ca7b02073 Author: Kristian Høgsberg Date: Fri Mar 28 10:17:11 2014 -0700 gbm: Add import from fd Cc: Kristian Høgsberg Signed-off-by: Ben Widawsky --- src/gbm/main/gbm.c | 2 +-

Re: [Mesa-dev] [PATCH 02/18] mesa: Add {OES, EXT}_tessellation_shader to the extensions table.

2016-08-01 Thread Ilia Mirkin
I'm looking at these on my phone, so perhaps I missed it - do you ever end up turning them on, or is that left to later series? On Aug 1, 2016 12:30 PM, "Kenneth Graunke" wrote: > Also update _mesa_has_tessellation to know about the new extensions. > > For now, these are

Re: [Mesa-dev] [PATCH 14/18] glsl: Don't include the array index.

2016-08-01 Thread Ilia Mirkin
Fwiw I remember having trouble finding justification for the comments in that issue, and iirc the opposite seemed to be indicated by the spec text. (E.g.that array indices should be maintained.) I suspect there are also AoA interactions. I guess my point here is to double check this, as well as

[Mesa-dev] [PATCH] vbo: fix debug message format string in case of 32-bit machines

2016-08-01 Thread Jan Ziak
Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/mesa/vbo/vbo_exec_array.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index 90f1321..fe74c73 100644 ---

Re: [Mesa-dev] [PATCH 01/18] mapi: Add PatchParameteriOES and PatchParameteriEXT.

2016-08-01 Thread Ilia Mirkin
FYI, I've been putting these into sections in es_EXT.xml. Your call though. On Aug 1, 2016 12:30 PM, "Kenneth Graunke" wrote: > The OES_tessellation_shader and EXT_tessellation_shader specifications > have suffixed names. These are identical to the core function, so just

[Mesa-dev] [PATCH 2/2] radeonsi: print the command line to VM fault reports (v2)

2016-08-01 Thread Marek Olšák
From: Marek Olšák v2: rebase on top of Brian's commit --- src/gallium/drivers/radeonsi/si_debug.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index e030f48..ae11b2c 100644 ---

[Mesa-dev] [PATCH 1/2] ddebug: print the command line to all logs (v2)

2016-08-01 Thread Marek Olšák
From: Marek Olšák for piglit with the pipelined hang detection mode v2: rebase on top of Brian's commit --- src/gallium/drivers/ddebug/dd_draw.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/ddebug/dd_draw.c

Re: [Mesa-dev] [PATCH] ttn: Make FRAG_RESULT_DEPTH be a float variable to match gtn and ptn.

2016-08-01 Thread Rob Clark
On Mon, Aug 1, 2016 at 1:45 PM, Eric Anholt wrote: > This lets TTN-using drivers handle FRAG_RESULT_DEPTH the same between all > their source paths. lgtm.. and nice to lose an extra tgsi hack ;-) r-b > --- > src/gallium/auxiliary/nir/tgsi_to_nir.c | 19

[Mesa-dev] [PATCH] i965: Disable the unlit centroid workaround on Gen7.

2016-08-01 Thread Matt Turner
Once upon a time (commit 8313f44409) Paul added code for the unlit centroid workaround (WaCopyUnlitCentroidBarys). His commit message claims it fixed the EXT_framebuffer_multisample/interpolation {2,4} {centroid-deriv,centroid-deriv-disabled} piglit tests but does not say on which platform, though

Re: [Mesa-dev] [PATCH] i965: Replace BRW_SURFACEFORMAT_* with ISL_FORMAT_*.

2016-08-01 Thread Kenneth Graunke
Alright, I'll hold off until you've landed them. signature.asc Description: This is a digitally signed message part. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] virglrenderer regression in commit ad4f0f1941677c

2016-08-01 Thread Marc-André Lureau
Hi - Original Message - > On Fri, Jul 29, 2016 at 3:57 PM, Rob Herring wrote: > > Hi, > > > > This commit in virglrenderer causes a regression in Android for me. > > The parameters that get passed in are last_level = 8, width = 1. I'm > > not really sure if this is

Re: [Mesa-dev] [PATCH] nir: Allow opt_peephole_select to work on empty blocks.

2016-08-01 Thread Jason Ekstrand
On Aug 1, 2016 12:41 PM, "Eric Anholt" wrote: > > nir_opt_peephole_select has the job of removing IF statements with no side > effects. However, if the IF statement's successor didn't have any > instructions in it, we were skipping it, which occurred in mupen64 on > vc4 with

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-08-01 Thread Matt Turner
On Mon, Aug 1, 2016 at 6:02 AM, Eric Engestrom wrote: > On Sun, Jul 31, 2016 at 07:07:34PM +0300, Andres Gomez wrote: >> AST_NUM_OPERATORS stores the dimension of the ast_operators >> enumeration but was not updated after its last modification. >> >> This doesn't add

[Mesa-dev] [PATCH] ttn: Make FRAG_RESULT_DEPTH be a float variable to match gtn and ptn.

2016-08-01 Thread Eric Anholt
This lets TTN-using drivers handle FRAG_RESULT_DEPTH the same between all their source paths. --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 19 --- src/gallium/drivers/freedreno/ir3/ir3_compiler_nir.c | 6 -- src/gallium/drivers/freedreno/ir3/ir3_shader.c |

[Mesa-dev] [PATCH] nir: Allow opt_peephole_select to work on empty blocks.

2016-08-01 Thread Eric Anholt
nir_opt_peephole_select has the job of removing IF statements with no side effects. However, if the IF statement's successor didn't have any instructions in it, we were skipping it, which occurred in mupen64 on vc4 with glsl_to_nir enabled: instructions in affected programs: 6134 -> 4120

[Mesa-dev] [PATCH] i965: Replace BRW_SURFACEFORMAT_* with ISL_FORMAT_*.

2016-08-01 Thread Kenneth Graunke
One less set of enums. s/BRW_SURFACEFORMAT/ISL_FORMAT/g plus some captialization fixes for ASTC formats. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_binding_tables.c| 2 +- src/mesa/drivers/dri/i965/brw_blorp.c | 12 +-

[Mesa-dev] [PATCH 17/18] glsl: Fix location bias for patch variables.

2016-08-01 Thread Kenneth Graunke
We need to subtract VARYING_SLOT_PATCH0, not VARYING_SLOT_VAR0. Since "patch" only applies to inputs and outputs, we can just handle this once outside the switch statement, rather than replicating the check twice and complicating the earlier conditions. Cc: mesa-sta...@lists.freedesktop.org

[Mesa-dev] [PATCH 15/18] Revert "glsl/linker: Don't include interface name for built-in blocks"

2016-08-01 Thread Kenneth Graunke
This reverts commit 79bbff9defd98167bf14336a44985088e2fd3f37. Issue 16 of the ARB_program_interface_query spec clearly states: For tessellation control, tessellation evaluation, and geometry shaders, per-vertex built-in inputs like gl_Position are in a block with an instance name of

[Mesa-dev] [PATCH 14/18] glsl: Don't include the array index.

2016-08-01 Thread Kenneth Graunke
Issue 16 of the ARB_program_interface_query spec gives an example: For example, in the following code: uniform Block1 { int member1; }; uniform Block2 { int member2; } instance2; uniform Block3 { int member3; }

[Mesa-dev] [PATCH 02/18] mesa: Add {OES, EXT}_tessellation_shader to the extensions table.

2016-08-01 Thread Kenneth Graunke
Also update _mesa_has_tessellation to know about the new extensions. For now, these are dummy_false, to avoid turning on the extension until everything's in place. Eventually, we'll move them over to the "ARB_tessellation_shader" bit so that any drivers supporting both the desktop extension and

[Mesa-dev] [PATCH 07/18] glsl: Implicitly enable OES_shader_io_blocks if geom/tess are enabled.

2016-08-01 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/compiler/glsl/glsl_parser_extras.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/compiler/glsl/glsl_parser_extras.h b/src/compiler/glsl/glsl_parser_extras.h index 991cfc6..0294ef7 100644 ---

[Mesa-dev] [PATCH 06/18] glsl: Expose gl_PointSize if OES/EXT_tessellation_point_size is enabled.

2016-08-01 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/compiler/glsl/builtin_variables.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/builtin_variables.cpp b/src/compiler/glsl/builtin_variables.cpp index 20d1d75..c9d8b1c 100644 ---

[Mesa-dev] [PATCH 01/18] mapi: Add PatchParameteriOES and PatchParameteriEXT.

2016-08-01 Thread Kenneth Graunke
The OES_tessellation_shader and EXT_tessellation_shader specifications have suffixed names. These are identical to the core function, so just alias them. Signed-off-by: Kenneth Graunke --- src/mapi/glapi/gen/ARB_tessellation_shader.xml | 10 ++

[Mesa-dev] [PATCH 13/18] mesa: Fix add_index_to_name logic

2016-08-01 Thread Kenneth Graunke
From: Ian Romanick Our piglit tests for geometry and tessellation shader inputs were incorrect. Array shader inputs and output should have '[0]' on the end regardless of stage. In addtion, transform feedback varyings should not. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 11/18] mesa: Share code between _mesa_validate_DrawArrays[_Instanced].

2016-08-01 Thread Kenneth Graunke
Mostly, I want to share the GLES 3 transform feedback handling, though most of the rest of the code is identical as well. Signed-off-by: Kenneth Graunke --- src/mesa/main/api_validate.c | 89 +--- 1 file changed, 25 insertions(+),

[Mesa-dev] [PATCH 16/18] glsl: Fix the program resource names of gl_TessLevelOuter/Inner[].

2016-08-01 Thread Kenneth Graunke
These are lowered to gl_TessLevel{Outer,Inner}MESA. We need them to appear in the program resource list with their original names and types. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Kenneth Graunke --- src/compiler/glsl/linker.cpp | 12 1 file

[Mesa-dev] [PATCH 18/18] glsl: Combine GS and TES array resizing visitors.

2016-08-01 Thread Kenneth Graunke
These are largely identical, except that the GS version has a few extra error conditions. We can just pass in the stage and skip these. Signed-off-by: Kenneth Graunke --- src/compiler/glsl/linker.cpp | 107 ++- 1 file changed, 35

[Mesa-dev] [PATCH 05/18] glsl: Add extension plumbing for OES/EXT_tessellation_shader.

2016-08-01 Thread Kenneth Graunke
This adds the #extension directive support, built-in #defines, lexer keyword support, and updates has_tessellation_shader(). Signed-off-by: Kenneth Graunke --- src/compiler/glsl/glsl_lexer.ll | 2 +- src/compiler/glsl/glsl_parser.yy | 3 ++-

[Mesa-dev] [PATCH 10/18] glsl: Delete bogus ir_set_program_inouts assert.

2016-08-01 Thread Kenneth Graunke
This assertion is bogus. Varying structs, and arrays of structs, are allowed by GLSL, and we can see them here. While we currently don't have any partial-variable support for those, simply returning false and marking the entire thing as used is certainly legitimate. I believe this is often

[Mesa-dev] [PATCH 09/18] glsl: Handle patch qualifier on interface blocks.

2016-08-01 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/compiler/glsl/ast_to_hir.cpp | 4 src/compiler/glsl/glsl_parser.yy | 11 +++ src/compiler/glsl/glsl_parser_extras.cpp | 3 +++ 3 files changed, 18 insertions(+) diff --git

[Mesa-dev] [PATCH 12/18] mesa: Skip ES 3.0/3.1 transform feedback primitive counting error.

2016-08-01 Thread Kenneth Graunke
This error condition is not implementable when using tessellation or geometry shaders. The text was also removed from the ES 3.2 spec. I believe the intended behavior is to remove the error condition when either OES_geometry_shader or OES_tessellation_shader are exposed. Signed-off-by: Kenneth

[Mesa-dev] [PATCH 03/18] mesa: Move tessellation shader gets to GL_CORE, GLES31 section.

2016-08-01 Thread Kenneth Graunke
This makes them available in the GLES 3.1 API. Signed-off-by: Kenneth Graunke --- src/mesa/main/get_hash_params.py | 69 +--- 1 file changed, 36 insertions(+), 33 deletions(-) diff --git a/src/mesa/main/get_hash_params.py

[Mesa-dev] [PATCH 08/18] glsl: Simplify interface qualifier parsing.

2016-08-01 Thread Kenneth Graunke
This better matches the grammar in section 4.3.9 of the GLSL 4.5 spec, and also removes some redundant code. Signed-off-by: Kenneth Graunke --- src/compiler/glsl/glsl_parser.yy | 41 +++- 1 file changed, 7 insertions(+), 34 deletions(-)

[Mesa-dev] [PATCH 04/18] glsl: Add a has_tessellation_shader() helper.

2016-08-01 Thread Kenneth Graunke
Similar to has_geometry_shader(), has_compute_shader(), and so on. This will make it easier to add more conditions here later. Signed-off-by: Kenneth Graunke --- src/compiler/glsl/builtin_variables.cpp | 6 ++ src/compiler/glsl/glsl_parser.yy| 19

[Mesa-dev] [Bug 95346] Stellaris - Black/super dark planets

2016-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95346 --- Comment #14 from Marek Olšák --- (In reply to Luchesar V. ILIEV from comment #13) > Sorry for the spam, but I just realised that earlier game versions can be > tested. Going back as far as 1.0.0, the situation is the same:

Re: [Mesa-dev] [PATCH] st/mesa: silence missing braces warning in st_program.c

2016-08-01 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Aug 1, 2016 at 5:57 PM, Brian Paul wrote: > Silence a gcc warning: > state_tracker/st_program.c: In function 'st_create_fp_variant': > state_tracker/st_program.c:957:10: warning: missing braces around initializer >

[Mesa-dev] [PATCH] st/mesa: silence missing braces warning in st_program.c

2016-08-01 Thread Brian Paul
Silence a gcc warning: state_tracker/st_program.c: In function 'st_create_fp_variant': state_tracker/st_program.c:957:10: warning: missing braces around initializer [-Wmissing-braces] nir_lower_drawpixels_options options = {0}; ^ state_tracker/st_program.c:957:10: warning:

Re: [Mesa-dev] [PATCH] auxiliary/os: add new os_get_command_line() function

2016-08-01 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Aug 1, 2016 at 4:40 PM, Brian Paul wrote: > This can be used by the driver to get the command line which started > the process. Will be used by the VMware driver for extra logging. > > For now, this is only

[Mesa-dev] [PATCH] auxiliary/os: add new os_get_command_line() function

2016-08-01 Thread Brian Paul
This can be used by the driver to get the command line which started the process. Will be used by the VMware driver for extra logging. For now, this is only implemented for Linux via /proc/self/cmdline and Windows via GetCommandLine(). Reviewed-by: Charmaine Lee ---

Re: [Mesa-dev] [PATCH 1/3] gallium/os: add os_get_process_cmd_line

2016-08-01 Thread Brian Paul
Coincidentally, I wrote a very similar function a couple months ago (in our in-house tree). My version uses open("/proc/self/cmdline", O_RDONLY) and has a Windows implementation too. I'll post it shortly... -Brian On 07/30/2016 09:22 AM, Marek Olšák wrote: From: Marek Olšák

Re: [Mesa-dev] [PATCH] nir: remove remaining global register support

2016-08-01 Thread Jason Ekstrand
On Aug 1, 2016 12:37 AM, "Timothy Arceri" wrote: > > These don't seem to have been used since d1d12efb36074. I'm a bit torn... On the one hand, I do think we will probably want to bring them back at some point in the future. On the other hand, dead code is broken

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

2016-08-01 Thread Rob Clark
On Mon, Aug 1, 2016 at 8:10 AM, Eric Engestrom wrote: > On Sat, Jul 30, 2016 at 09:49:57AM +0200, Francesco Ansanelli wrote: >> Signed-off-by: Francesco Ansanelli >> --- >> src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 >> 1 file

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-01 Thread
On Mon, Aug 1, 2016 at 2:46 PM, Eric Engestrom wrote: > On Sun, Jul 31, 2016 at 05:49:02PM +0200, Jan Ziak wrote: >> Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > > This is a good change, and with a couple things to fix below, it is: >

[Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-01 Thread Jan Ziak
Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/egl/drivers/dri2/egl_dri2.h | 19 ++- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 3 ++- src/glx/dri3_priv.h | 5 +++-- src/loader/loader.c |

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-08-01 Thread Eric Engestrom
On Sun, Jul 31, 2016 at 07:07:34PM +0300, Andres Gomez wrote: > AST_NUM_OPERATORS stores the dimension of the ast_operators > enumeration but was not updated after its last modification. > > This doesn't add any real modification for any code paths but it makes > sense for coherence. > >

Re: [Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

2016-08-01 Thread Jose Fonseca
On 30/07/16 19:39, Jan Ziak wrote: Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/gallium/auxiliary/util/u_format_s3tc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_s3tc.c

Re: [Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

2016-08-01 Thread Eric Engestrom
On Sat, Jul 30, 2016 at 07:44:02PM +0200, Marek Olšák wrote: > On Sat, Jul 30, 2016 at 6:16 PM, Roland Scheidegger > wrote: > > This looks very bogus to me. > > How is this supposed to work if you immediately close the library again? > > The functions are still going to get

Re: [Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

2016-08-01 Thread Eric Engestrom
On Sat, Jul 30, 2016 at 09:49:57AM +0200, Francesco Ansanelli wrote: > Signed-off-by: Francesco Ansanelli > --- > src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] nir: remove remaining global register support

2016-08-01 Thread Timothy Arceri
On Mon, 2016-08-01 at 15:36 +1000, Timothy Arceri wrote: > These don't seem to have been used since d1d12efb36074. > --- >  src/compiler/Makefile.sources   |   1 - >  src/compiler/nir/nir.c  |  23 --- >  src/compiler/nir/nir.h  |  14 >  

[Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-01 Thread Nayan Deshmukh
v2: avoid dividing by zero when calculating lanczos Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/vl/vl_lanczos_filter.c | 445 +++ src/gallium/auxiliary/vl/vl_lanczos_filter.h |

[Mesa-dev] [PATCH 2/2] st/vdapu: use lanczos filter for scaling v3

2016-08-01 Thread Nayan Deshmukh
HIGH_QUALITY_SCALING_L2 to HIGH_QUALTIY_SCALING_L7 uses lanczos filter with number representing the size of the sinc window. v3: avoid L8 and L9 to allow for other scaling algrithms Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c |

Re: [Mesa-dev] virglrenderer regression in commit ad4f0f1941677c

2016-08-01 Thread Rob Clark
On Mon, Aug 1, 2016 at 1:30 AM, Marc-André Lureau wrote: > > Hi > > - Original Message - >> On Fri, Jul 29, 2016 at 3:57 PM, Rob Herring wrote: >> > Hi, >> > >> > This commit in virglrenderer causes a regression in Android for me. >> > The parameters

Re: [Mesa-dev] [PATCH 10/95] i965/vec4: handle 32 and 64 bit channels in liveness analysis

2016-08-01 Thread Juan A. Suarez Romero
On Fri, 2016-07-29 at 12:59 -0700, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > > > From: "Juan A. Suarez Romero" > > > > Our current data flow analysis does not take into account that > > channels > > on 64-bit operands are 64-bit. This is

Re: [Mesa-dev] [PATCH] gallium/sw/kms: Fix multiple imports from PRIME FDs

2016-08-01 Thread Tomasz Figa
Hi Emil, On Sat, Jul 16, 2016 at 6:38 AM, Emil Velikov wrote: > On 15 July 2016 at 08:27, Tomasz Figa wrote: >> When a buffer with a GEM handle already existing in our context is >> (re-)imported from a PRIME FD, the resulting GEM handle is exactly

Re: [Mesa-dev] [PATCH 2/2] glsl: struct constructors/initializers only allow implicit conversions

2016-08-01 Thread Andres Gomez
On Mon, 2016-08-01 at 12:05 +0300, Andres Gomez wrote: [snip] > it allows conversions from a vector or a bigger dimension to a vector of ---^^ > or a smaller dimension. That was making the CTS test fail. of^^ (Wake up, Andrés!!!) --  Br, Andres

Re: [Mesa-dev] [PATCH 2/2] glsl: struct constructors/initializers only allow implicit conversions

2016-08-01 Thread Andres Gomez
On Mon, 2016-08-01 at 10:01 +1000, Timothy Arceri wrote: > On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote: [snip] > diff --git a/src/compiler/glsl/ast_function.cpp > > b/src/compiler/glsl/ast_function.cpp > > index 9dcec50..9b09cb6 100644 > > --- a/src/compiler/glsl/ast_function.cpp > >

Re: [Mesa-dev] [PATCH 1/2] glsl/types: disallow implicit conversions before GLSL 1.20

2016-08-01 Thread Andres Gomez
On Mon, 2016-08-01 at 09:35 +1000, Timothy Arceri wrote: > On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote: > > Implicit conversions were added in the GLSL 1.20 spec version. > > Does this help fix the CTS test or are you just adding it because you > noticed it? It helps preventing a

Re: [Mesa-dev] [PATCH 12/12] gallium/radeon/winsyses: decrease max_alloc_size to 1/3 of largest heap

2016-08-01 Thread Michel Dänzer
On 30.07.2016 06:42, Marek Olšák wrote: > From: Marek Olšák > > This is controversial, but I don't see a better way out of this. > > Tonga has 2 GB of VRAM and 2 GB of GTT. amdgpu is not capable of submitting > an IB referencing 1 GB of VRAM and 1 GB of GTT. The CS ioctl