Re: [Mesa-dev] [PATCH] nir/tests: Update the CF tests to not assume fake edges

2016-09-03 Thread Aaron Watry
On Sat, Sep 3, 2016 at 1:59 PM, Jason Ekstrand wrote: > In aad4f1550, we removed the concept of "fake" edges from NIR. Now, if you > have a block at the end of an infinite loop it really has no predecessors. > This updates the unit tests to match. > > Fixes `make check` for me. --Aaron > Sign

[Mesa-dev] [PATCH] main: GL_RGB10_A2UI does not come with GL 3.0/EXT_texture_integer

2016-09-03 Thread Ilia Mirkin
Add a separate extension check for that format. Prevents glTexImage from trying to find a matching format, which fails on drivers without support for this format. Fixes: sized-texture-format-channels (on a3xx) Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- Technically we sh

Re: [Mesa-dev] [PATCH 1/8] intel: Add a new "common" library for more code sharing

2016-09-03 Thread Jason Ekstrand
On Sep 3, 2016 5:00 PM, "Mauro Rossi" wrote: > > Hi, > minor changes are required to Android.common.mk include paths. I double-checked all the files and I didn't think we included anything more interesting than stdint.h. Oh, well, I guess I was wrong. Reviewed-by: Jason Ekstrand I'll push thi

Re: [Mesa-dev] [PATCH] glsl: Fix locations of variables in patch qualified interface blocks.

2016-09-03 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sat, Sep 3, 2016 at 7:53 PM, Kenneth Graunke wrote: > As of commit d82f8d9772813949d0f5455cd0edad9003be0fb0, we actually > parse and attempt to handle the 'patch' qualifier on interface blocks. > > This patch fixes explicit locations for variables in such blocks. > Wi

Re: [Mesa-dev] [PATCH 1/8] intel: Add a new "common" library for more code sharing

2016-09-03 Thread Mauro Rossi
Hi, minor changes are required to Android.common.mk include paths. Build tested with android 7.0 Cheers M. >From e783a73d15e0e49bb323b2e47bc2de0b51ceffa2 Mon Sep 17 00:00:00 2001 From: Mauro Rossi Date: Sun, 4 Sep 2016 00:50:48 +0200 Subject: [PATCH] android: intel: fix include paths in new "comm

[Mesa-dev] [PATCH] glsl: Fix locations of variables in patch qualified interface blocks.

2016-09-03 Thread Kenneth Graunke
As of commit d82f8d9772813949d0f5455cd0edad9003be0fb0, we actually parse and attempt to handle the 'patch' qualifier on interface blocks. This patch fixes explicit locations for variables in such blocks. Without it, many program interface query dEQP/CTS tests hit this assertion in ir_set_program_i

[Mesa-dev] [PATCH] intel/blorp: Work in terms of logical array layers

2016-09-03 Thread Jason Ekstrand
When Ivy Bridge introduced array multisampling, someone made the decision to do lots of stuff throughout the driver in terms of physical array layers rather than logical array layers. In ISL, we use logical array layers most of the time and it really makes no sense to use physical array layers in

Re: [Mesa-dev] [PATCH] mesa: Fix types in _mesa_get_color_read_format().

2016-09-03 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sat, Sep 3, 2016 at 6:07 PM, Kenneth Graunke wrote: > This is a mesa_format, not a GLenum. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/main/framebuffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/framebuffer.c b/s

[Mesa-dev] [PATCH] mesa: Fix types in _mesa_get_color_read_format().

2016-09-03 Thread Kenneth Graunke
This is a mesa_format, not a GLenum. Signed-off-by: Kenneth Graunke --- src/mesa/main/framebuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/framebuffer.c b/src/mesa/main/framebuffer.c index f024f5e..46a6f64 100644 --- a/src/mesa/main/framebuffer.c +++ b/

Re: [Mesa-dev] [PATCH] intel/blorp: Increase the presision of coordinate transform calculations

2016-09-03 Thread Jason Ekstrand
On Sat, Sep 3, 2016 at 12:46 PM, Matt Turner wrote: > On Sat, Sep 3, 2016 at 10:42 AM, Jason Ekstrand > wrote: > > The result of this calculation goes into an fma() in the shader and we > > would like it to be as precise as possible. The division in particular, > > was a source of inprecision w

Re: [Mesa-dev] [PATCH] intel/blorp: Increase the presision of coordinate transform calculations

2016-09-03 Thread Jason Ekstrand
On Sat, Sep 3, 2016 at 11:44 AM, Kenneth Graunke wrote: > On Saturday, September 3, 2016 10:42:01 AM PDT Jason Ekstrand wrote: > > The result of this calculation goes into an fma() in the shader and we > > would like it to be as precise as possible. The division in particular, > > was a source o

[Mesa-dev] [Bug 97587] make check nir/tests/control_flow_tests regression

2016-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97587 --- Comment #1 from Jason Ekstrand --- Thanks for the bug report. I sent a patch to the list to fix it. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

Re: [Mesa-dev] [PATCH] mesa/formatquery: limit ES target support, fix core context support

2016-09-03 Thread Matteo Bruni
2016-09-03 21:11 GMT+02:00 Ilia Mirkin : > First off, as late as ES 3.2, GetInternalformat only supports > RENDERBUFFER and 2DMS(_ARRAY) targets. > > Secondly, the _mesa_has_ext helpers are very accurate... a little too > accurate, some might say. If we only show an extension in compat > profiles b

Re: [Mesa-dev] [PATCH] intel/blorp: Increase the presision of coordinate transform calculations

2016-09-03 Thread Matt Turner
On Sat, Sep 3, 2016 at 10:42 AM, Jason Ekstrand wrote: > The result of this calculation goes into an fma() in the shader and we > would like it to be as precise as possible. The division in particular, > was a source of inprecision whenever dst1 - dst0 was not a power of two. > This fixes a bunch

Re: [Mesa-dev] Issue with using _mesa_has_* helpers that are only for GLL and not GLC

2016-09-03 Thread Ilia Mirkin
Actually I ended up fixing this up: https://patchwork.freedesktop.org/patch/108725/ On Fri, Sep 2, 2016 at 2:53 PM, Ilia Mirkin wrote: > Matteo pointed out on IRC that we fail to report some format query > stuff for GL_TEXTURE_CUBE_MAP because we check for > _mesa_has_ARB_texture_cube_map(). How

[Mesa-dev] [PATCH] mesa/formatquery: limit ES target support, fix core context support

2016-09-03 Thread Ilia Mirkin
First off, as late as ES 3.2, GetInternalformat only supports RENDERBUFFER and 2DMS(_ARRAY) targets. Secondly, the _mesa_has_ext helpers are very accurate... a little too accurate, some might say. If we only show an extension in compat profiles because core profiles have the functionality guarante

[Mesa-dev] [PATCH] nir/tests: Update the CF tests to not assume fake edges

2016-09-03 Thread Jason Ekstrand
In aad4f1550, we removed the concept of "fake" edges from NIR. Now, if you have a block at the end of an infinite loop it really has no predecessors. This updates the unit tests to match. Signed-off-by: Jason Ekstrand Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97587 --- src/compiler

Re: [Mesa-dev] [PATCH] intel/blorp: Increase the presision of coordinate transform calculations

2016-09-03 Thread Kenneth Graunke
On Saturday, September 3, 2016 10:42:01 AM PDT Jason Ekstrand wrote: > The result of this calculation goes into an fma() in the shader and we > would like it to be as precise as possible. The division in particular, > was a source of inprecision whenever dst1 - dst0 was not a power of two. > This

[Mesa-dev] [Bug 97587] make check nir/tests/control_flow_tests regression

2016-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97587 Aaron Watry changed: What|Removed |Added CC||awa...@gmail.com -- You are receiving thi

[Mesa-dev] [Bug 97587] make check nir/tests/control_flow_tests regression

2016-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97587 Vinson Lee changed: What|Removed |Added CC||cwabbo...@gmail.com, |

[Mesa-dev] [Bug 97587] make check nir/tests/control_flow_tests regression

2016-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97587 Bug ID: 97587 Summary: make check nir/tests/control_flow_tests regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW Severity

Re: [Mesa-dev] [PATCH 24/33] anv: Add initial blorp support

2016-09-03 Thread Pohjolainen, Topi
On Wed, Aug 31, 2016 at 02:22:43PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/Makefile.am | 1 + > src/intel/vulkan/Makefile.sources | 5 + > src/intel/vulkan/anv_blorp.c | 120 + > src/intel/vulkan/anv_device.c | 4 + > src/intel/vulkan/anv_genX.

[Mesa-dev] [PATCH] intel/blorp: Increase the presision of coordinate transform calculations

2016-09-03 Thread Jason Ekstrand
The result of this calculation goes into an fma() in the shader and we would like it to be as precise as possible. The division in particular, was a source of inprecision whenever dst1 - dst0 was not a power of two. This fixes a bunch of the new Vulkan CTS tests for blitting using a filtering of N

Re: [Mesa-dev] [PATCH 15/33] intel/blorp: Add support for RGB destinations in copies

2016-09-03 Thread Pohjolainen, Topi
On Sat, Sep 03, 2016 at 10:32:55AM -0700, Jason Ekstrand wrote: >On Sat, Sep 3, 2016 at 10:19 AM, Pohjolainen, Topi ><[1]topi.pohjolai...@gmail.com> wrote: > >On Wed, Aug 31, 2016 at 02:22:34PM -0700, Jason Ekstrand wrote: >> --- >> src/intel/blorp/blorp_blit.c | 61 ++

Re: [Mesa-dev] [PATCH 15/33] intel/blorp: Add support for RGB destinations in copies

2016-09-03 Thread Jason Ekstrand
On Sat, Sep 3, 2016 at 10:19 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Aug 31, 2016 at 02:22:34PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/blorp/blorp_blit.c | 61 ++ > ++ > > src/intel/blorp/blorp_priv.h | 6 + > >

Re: [Mesa-dev] [PATCH 15/33] intel/blorp: Add support for RGB destinations in copies

2016-09-03 Thread Pohjolainen, Topi
On Wed, Aug 31, 2016 at 02:22:34PM -0700, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp_blit.c | 61 > > src/intel/blorp/blorp_priv.h | 6 + > 2 files changed, 67 insertions(+) > > diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp

Re: [Mesa-dev] [PATCH 12/33] intel/blorp: Stop using the X/YOffset field of RENDER_SURFACE_STATE

2016-09-03 Thread Pohjolainen, Topi
On Thu, Sep 01, 2016 at 08:28:38AM -0700, Jason Ekstrand wrote: >On Sep 1, 2016 1:31 AM, "Pohjolainen, Topi" ><[1]topi.pohjolai...@gmail.com> wrote: >> >> On Wed, Aug 31, 2016 at 02:22:31PM -0700, Jason Ekstrand wrote: >> > While it can be useful, the field has substantial limta

Re: [Mesa-dev] [PATCH 11/33] intel/blorp: Use fake_interleaved_msaa in retile_w_to_y

2016-09-03 Thread Pohjolainen, Topi
On Sat, Sep 03, 2016 at 09:07:03AM -0700, Jason Ekstrand wrote: >On Sat, Sep 3, 2016 at 9:04 AM, Pohjolainen, Topi ><[1]topi.pohjolai...@gmail.com> wrote: > > On Thu, Sep 01, 2016 at 12:02:17PM -0700, Jason Ekstrand wrote: > >On Thu, Sep 1, 2016 at 12:09 AM, Pohjolainen, Topi

Re: [Mesa-dev] [PATCH 11/33] intel/blorp: Use fake_interleaved_msaa in retile_w_to_y

2016-09-03 Thread Jason Ekstrand
On Sat, Sep 3, 2016 at 9:04 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Thu, Sep 01, 2016 at 12:02:17PM -0700, Jason Ekstrand wrote: > >On Thu, Sep 1, 2016 at 12:09 AM, Pohjolainen, Topi > ><[1]topi.pohjolai...@gmail.com> wrote: > > > > On Wed, Aug 31, 2016 at 02:2

Re: [Mesa-dev] [PATCH 11/33] intel/blorp: Use fake_interleaved_msaa in retile_w_to_y

2016-09-03 Thread Pohjolainen, Topi
On Thu, Sep 01, 2016 at 12:02:17PM -0700, Jason Ekstrand wrote: >On Thu, Sep 1, 2016 at 12:09 AM, Pohjolainen, Topi ><[1]topi.pohjolai...@gmail.com> wrote: > > On Wed, Aug 31, 2016 at 02:22:30PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/blorp/blorp_blit.c | 4 +---

Re: [Mesa-dev] [PATCH 14/33] intel/blorp: Add an entrypoint for doing bit-for-bit copies

2016-09-03 Thread Pohjolainen, Topi
On Sat, Sep 03, 2016 at 08:32:04AM -0700, Jason Ekstrand wrote: >On Sat, Sep 3, 2016 at 12:14 AM, Pohjolainen, Topi ><[1]topi.pohjolai...@gmail.com> wrote: > > On Wed, Aug 31, 2016 at 02:22:33PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/blorp/blorp.h | 10 +++

Re: [Mesa-dev] [PATCH 30/33] anv: Use blorp for CopyBuffer and UpdateBuffer

2016-09-03 Thread Jason Ekstrand
On Fri, Sep 2, 2016 at 12:05 PM, Anuj Phogat wrote: > On Wed, Aug 31, 2016 at 2:22 PM, Jason Ekstrand > wrote: > > --- > > src/intel/vulkan/Makefile.sources | 1 - > > src/intel/vulkan/anv_blorp.c | 184 ++ > > > src/intel/vulkan/anv_meta_copy.c | 18

Re: [Mesa-dev] [PATCH 21/33] anv/pipeline: Roll compute_urb_partition into emit_urb_setup

2016-09-03 Thread Jason Ekstrand
On Sat, Sep 3, 2016 at 12:50 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Aug 31, 2016 at 02:22:40PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_pipeline.c | 142 > - > > src/intel/vulkan/anv_private.h| 3 -

Re: [Mesa-dev] [PATCH 14/33] intel/blorp: Add an entrypoint for doing bit-for-bit copies

2016-09-03 Thread Jason Ekstrand
On Sat, Sep 3, 2016 at 12:14 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Aug 31, 2016 at 02:22:33PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/blorp/blorp.h | 10 > > src/intel/blorp/blorp_blit.c | 133 ++ > + > >

Re: [Mesa-dev] [PATCH] android: fix build issues with genxml, isl

2016-09-03 Thread Jason Ekstrand
On Sat, Sep 3, 2016 at 2:04 AM, Mauro Rossi wrote: > 2016-09-03 10:42 GMT+02:00 Mauro Rossi : > > 2016-09-03 10:41 GMT+02:00 Mauro Rossi : > >> Hi Jason, > >> > >> I've just seen there was little typo in Android.blorp.mk file in the > >> last patch I sent you. > >> > >> At line 34 of Android.blor

[Mesa-dev] [PATCH] gbm: add missing R8 and GR88 formats

2016-09-03 Thread Rob Clark
Signed-off-by: Rob Clark --- I would have added RG88 except we seem to have no corresponding __DRI_IMAGE_FORMAT_RG88 src/gbm/backends/dri/gbm_dri.c | 6 ++ src/gbm/main/gbm.h | 6 ++ 2 files changed, 12 insertions(+) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/back

[Mesa-dev] (no subject)

2016-09-03 Thread Andras Schwartz
id=13832670320, lacika.pacus, viktorio.balogh. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Android: glsl: add rules to generate ir_expression*.h header files

2016-09-03 Thread Mauro Rossi
2016-09-02 11:50 GMT+02:00 Emil Velikov : > On 2 September 2016 at 05:35, Tapani Pälli wrote: >> Hi; >> >> Thanks, I was trying to work on the same issue but did not quite get it >> working .. will test this one with N build. >> >> FYI this patch contains both of these (which I believe were issues

Re: [Mesa-dev] [PATCH] st/omx/dec: set dst rect to match src size

2016-09-03 Thread Christian König
Am 02.09.2016 um 20:11 schrieb Leo Liu: When creating interlaced video buffer, hegith set to "template.height = align(tmpl->height/ array_size, VL_MACROBLOCK_HEIGHT);", and we use "template.height *= array_size;" for the buffer height, so it actually aligned with 32. With progressive video buffer

Re: [Mesa-dev] [PATCH 33/33] anv: Use blorp for doing MSAA resolves

2016-09-03 Thread Pohjolainen, Topi
> > I've one minor comment on patch 30/33. With that fixed: > patches 25-33 are: > Reviewed-by: Anuj Phogat In addition to 1-10, patches 13 and 16 - 23 are also: Reviewed-by: Topi Pohjolainen Others I need to study some more... ___ mesa-dev maili

Re: [Mesa-dev] [PATCH 21/33] anv/pipeline: Roll compute_urb_partition into emit_urb_setup

2016-09-03 Thread Pohjolainen, Topi
On Wed, Aug 31, 2016 at 02:22:40PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_pipeline.c | 142 - > src/intel/vulkan/anv_private.h| 3 - > src/intel/vulkan/genX_pipeline_util.h | 146 > -- > 3 files cha

Re: [Mesa-dev] [PATCH 14/33] intel/blorp: Add an entrypoint for doing bit-for-bit copies

2016-09-03 Thread Pohjolainen, Topi
On Wed, Aug 31, 2016 at 02:22:33PM -0700, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp.h | 10 > src/intel/blorp/blorp_blit.c | 133 > +++ So the idea is to copy a compression block as a pixel (by choosing large enough format), right? And