Re: [Mesa-dev] [PATCH v2 7/8] i965: Drop _NEW_TRANSFORM from 3DSTATE_VS atom on Gen7.

2016-10-03 Thread Jason Ekstrand
rb On Mon, Oct 3, 2016 at 9:41 PM, Kenneth Graunke wrote: > The atom that uploads push constants listens to _NEW_TRANSFORM for > legacy clip plane handling. On Sandybridge, the gen6_vs_state atom > emits 3DSTATE_CONSTANT_VS as well as 3DSTATE_VS, so it needs to listen > to the same set of condi

[Mesa-dev] [PATCH v2 7/8] i965: Drop _NEW_TRANSFORM from 3DSTATE_VS atom on Gen7.

2016-10-03 Thread Kenneth Graunke
The atom that uploads push constants listens to _NEW_TRANSFORM for legacy clip plane handling. On Sandybridge, the gen6_vs_state atom emits 3DSTATE_CONSTANT_VS as well as 3DSTATE_VS, so it needs to listen to the same set of conditions. However, it looks like Gen7 doesn't need this. The push cons

Re: [Mesa-dev] [PATCH 6/8] i965: Add missing BRW_CS_PROG_DATA to CS work group surface atom.

2016-10-03 Thread Jason Ekstrand
1-6 are Reviewed-by: Jason Ekstrand I think Nanley had a typo fix on 1 that you should probably take care of. On Wed, Sep 21, 2016 at 10:31 PM, Kenneth Graunke wrote: > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_wm_surface_st

Re: [Mesa-dev] [PATCH 7/8] i965: Drop _NEW_TRANSFORM from 3DSTATE_VS atom on Gen6-7.

2016-10-03 Thread Jason Ekstrand
On Wed, Sep 21, 2016 at 10:31 PM, Kenneth Graunke wrote: > commit e07457d0aec96970a39a2dd1cb4e46da6107eb77 removed the last use > of ctx->Transform on Gen6. It looks like Gen7 never needed this, but > Not so much... The mentioned commit actually contains a very nice comment specifying why NEW_T

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-10-03 Thread Albert Freeman
Yeah I think the value of having a date based system is to quickly check when the release was made, dayoutofdaysthatyear isn't really providing any extra benefit since its hard to read and that extra info is probably rather pointless for quick fix releases since the mesa-dev branch and a quick fix

Re: [Mesa-dev] [PATCH] spirv: replace assert() with unreachable()

2016-10-03 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Oct 3, 2016 at 5:25 PM, Timothy Arceri wrote: > This fixes an uninitialized warning for is_vertex_input. > --- > src/compiler/spirv/vtn_variables.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/compiler/spirv/vtn_variables.c b/

Re: [Mesa-dev] [PATCH 4/4] radv: toplevel configure/make changes required to build

2016-10-03 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 10/04/2016 12:48 PM, Dave Airlie wrote: > From: Dave Airlie > > This moves some of the llvm checks around to allow them > to be used for non-gallium drivers as well. > > radv requires llvm 3.9.0 as vulkan requires compute shaders. > > Authors: Bas Nieuwenhui

Re: [Mesa-dev] [PATCH 2/4] radv/winsys: import the amdgpu winsys for the radv vulkan driver.

2016-10-03 Thread Edward O'Callaghan
First, I just wanted to say congrats and thanks for all the hard work put into this! The implementation is very readable and written to a pretty high standard already. I just did a rather 'soft' review on this patch, there is a few trivial style comments but one thing I noticed is a miss-aligned d

[Mesa-dev] [PATCH 2/4] radv/winsys: import the amdgpu winsys for the radv vulkan driver.

2016-10-03 Thread Dave Airlie
From: Dave Airlie This just brings these files into the tree, it doesn't integrate them with the build system. The radv winsys is based on the gallium one with some changes, due to how command buffers are built and lack of flushing behaviour. Authors: Bas Nieuwenhuizen and Dave Airlie Signed-of

[Mesa-dev] [PATCH 4/4] radv: toplevel configure/make changes required to build

2016-10-03 Thread Dave Airlie
From: Dave Airlie This moves some of the llvm checks around to allow them to be used for non-gallium drivers as well. radv requires llvm 3.9.0 as vulkan requires compute shaders. Authors: Bas Nieuwenhuizen and Dave Airlie Signed-off-by: Dave Airlie --- configure.ac| 33 +++

[Mesa-dev] radv initial submission

2016-10-03 Thread Dave Airlie
Hi all, I fully expect this won't make it to the list in one piece due to size. I've pushed the same patchset to https://github.com/airlied/mesa/tree/radv-submit This is an initial submission of the open source radv vulkan driver for AMD GPUs supported by the amdgpu driver. It is a project Bas an

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Roland Scheidegger
Am 04.10.2016 um 03:16 schrieb Michel Dänzer: > On 04/10/16 01:53 AM, Roland Scheidegger wrote: >> In an ideal world everybody would zero-intialize the template I suppose >> - then it would easily survive such interface changes. > > As long as there are no fields where 0 isn't a safe value... That

Re: [Mesa-dev] [PATCH 2/2] radv: Add new flag for LLVM dependecies with vulkan

2016-10-03 Thread Tobias Droste
I was looking at a per driver check for vulkan, but then this can't reuse the existing functions to check llvm version. The LLVM version checks are also the reason this is done is such a weird way for gallium. It doesn't make sense there too and should be per driver too. This patch was just the

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-03 Thread Jason Ekstrand
On Mon, Oct 3, 2016 at 6:11 PM, Jason Ekstrand wrote: > On Tue, Sep 27, 2016 at 3:23 PM, Nanley Chery > wrote: > >> On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote: >> > On Tue 27 Sep 2016, Nanley Chery wrote: >> > > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: >> >

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Michel Dänzer
On 04/10/16 01:53 AM, Roland Scheidegger wrote: > In an ideal world everybody would zero-intialize the template I suppose > - then it would easily survive such interface changes. As long as there are no fields where 0 isn't a safe value... What's needed is an explicit definition of whether it's t

Re: [Mesa-dev] [PATCH V2 00/11] anv: Implement HiZ for basic cases

2016-10-03 Thread Jason Ekstrand
The whole thing is Reviewed-by: Jason Ekstrand I'm still a little concerned about CLEAR_PARAMS in patch 10, but once chad's happy, I'll be happy. On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery wrote: > This series is the second revision of the series found here: > https://lists.freedesktop.org

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

2016-10-03 Thread Jason Ekstrand
On Tue, Sep 27, 2016 at 3:23 PM, Nanley Chery wrote: > On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote: > > On Tue 27 Sep 2016, Nanley Chery wrote: > > > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > > > > > As a consequence of that reasoning, we should set > 3DST

Re: [Mesa-dev] Mesa 12.1.0 release plan (Was Re: Next Mesa release, anyone?)

2016-10-03 Thread Rob Clark
On Thu, Sep 29, 2016 at 10:56 AM, Emil Velikov wrote: > On 28 September 2016 at 19:53, Marek Olšák wrote: >> Hi, >> >> It's been almost 4 months since the 12.0 branch was created, and soon >> it will have been 3 months since Mesa 12.0 was released. >> >> Is there any reason we haven't created the

Re: [Mesa-dev] [PATCH] i965: Only emit 1 viewport when possible.

2016-10-03 Thread Ian Romanick
Reviewed-by: Ian Romanick On 09/26/2016 11:23 AM, Kenneth Graunke wrote: > In core profile, we support up to 16 viewports. However, in the > majority of cases, only 1 of them is actually used - we only need > the others if the last shader stage prior to the rasterizer writes > gl_ViewportIndex.

[Mesa-dev] [PATCH] intel: use the correct format specifier for printing uint64_t

2016-10-03 Thread Timothy Arceri
Fixes a bunch of warnings in 32-bit builds. --- src/intel/tools/aubinator.c | 17 + src/intel/tools/decoder.c | 7 --- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index a31dcb2..9b32e5b 100644 ---

Re: [Mesa-dev] [PATCH V2 09/11] genX/cmd_buffer: Enable rendering to HiZ

2016-10-03 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery wrote: > From: Chad Versace > > Nanley Chery: > (rebase) > - Resolve conflicts with new anv_batch_emit macro > (amend) > - Handle a QPitch TODO > - Emit 3DSTATE_HIER_DEPTH_BUFFER on pre-BDW systems > - Only use HiZ f

[Mesa-dev] [PATCH] aubinator: Use less -RS instead of -r for the implicit pager.

2016-10-03 Thread Kenneth Graunke
From the less man page: "Warning: when the -r option is used, less cannot keep track of the actual appearance of the screen (since this depends on how the screen responds to each type of control character). Thus, various display problems may result, such as long lines being spl

Re: [Mesa-dev] [PATCH 2/2] radv: Add new flag for LLVM dependecies with vulkan

2016-10-03 Thread Dave Airlie
On 3 October 2016 at 05:45, Tobias Droste wrote: > This reuse the same logic gallium uses to determine if LLVM is needed or > not: > --enable-vulkan-llvm is set to yes if at least one vulkan driver is > active and the host is i3*6 or x86_64. > To build vulkan drivers without LLVM (e.g. intel) one

[Mesa-dev] [PATCH] spirv: replace assert() with unreachable()

2016-10-03 Thread Timothy Arceri
This fixes an uninitialized warning for is_vertex_input. --- src/compiler/spirv/vtn_variables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index 43bb3bc..f431c6f 100644 --- a/src/compiler/spirv/vtn_va

Re: [Mesa-dev] [PATCH V2 08/11] anv/cmd_buffer: Add code for performing HZ operations

2016-10-03 Thread Jason Ekstrand
On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery wrote: > Create a function that performs one of three HiZ operations - > depth/stencil clears, HiZ resolve, and depth resolves. > > Signed-off-by: Nanley Chery > > --- > > v2. Add documentation > Fix the alignment check > Don't minify clear r

[Mesa-dev] [PATCH 3/5] i965: wrap unused function in #ifndef NDEBUG

2016-10-03 Thread Timothy Arceri
This function is only ever used by an assert() this fixes an unused function warning in release builds. --- src/mesa/drivers/dri/i965/gen8_draw_upload.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/gen8_draw_upload.c b/src/mesa/drivers/dri/i965/gen8_draw_upload.

[Mesa-dev] [PATCH 4/5] i965: wrap unused variable in #ifndef NDEBUG

2016-10-03 Thread Timothy Arceri
Fixes unused variable warning in release build. --- src/mesa/drivers/dri/i965/brw_tcs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_tcs.c b/src/mesa/drivers/dri/i965/brw_tcs.c index 1f1b1a5..01500e0 100644 --- a/src/mesa/drivers/dri/i965/brw_tcs.c +++ b/src

[Mesa-dev] [PATCH 2/5] i965: fix unused variable warning in gen7_block_read_scratch()

2016-10-03 Thread Timothy Arceri
--- src/mesa/drivers/dri/i965/brw_eu_emit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_emit.c b/src/mesa/drivers/dri/i965/brw_eu_emit.c index c98867a..cfb3fa0 100644 --- a/src/mesa/drivers/dri/i965/brw_eu_emit.c +++ b/src/mesa/drivers/dr

[Mesa-dev] [PATCH 1/5] i965: wrap assert param in #ifndef NDEBUG

2016-10-03 Thread Timothy Arceri
This fixes an unused variable warning on release builds. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index dc000d9..ccf311d 100644 --- a/src/mesa/drivers/dri/i965/brw_f

[Mesa-dev] [PATCH 5/5] i965: fix unused variable warning in brw_emit_gpgpu_walker()

2016-10-03 Thread Timothy Arceri
--- src/mesa/drivers/dri/i965/brw_compute.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_compute.c b/src/mesa/drivers/dri/i965/brw_compute.c index cde3bad..d1d39d3 100644 --- a/src/mesa/drivers/dri/i965/brw_compute.c +++ b/src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Roland Scheidegger
The reason I don't like this isn't really the number of callers, rather that the driver is going actively against what the state tracker told it to do. But I'm not strongly opposed to this, since effectively restricting the next field to be only valid if the resource is created externally might be

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Rob Clark
I know we do at least have an etnaviv gallium driver hanging out there waiting to be merged, and don't want to cause them unnecessary rebase pain.. so if $num_of_callsites_to_fix < $num_of_gallium_drivers, I don't mind fixing it at the call sites.. but I'll have to audit a whole bunch of call-sites

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Marek Olšák
BTW, I think fixing this in drivers is better, because the number of resource_create implementations is limited and they are easy to find. Marek On Tue, Oct 4, 2016 at 1:45 AM, Roland Scheidegger wrote: > Sounds reasonable to me. > > Roland > > Am 04.10.2016 um 01:44 schrieb Rob Clark: >> There

Re: [Mesa-dev] [PATCH 2/2] mesa: Raise INVALID_ENUM in FramebufferTexture*D for unknown textargets.

2016-10-03 Thread Timothy Arceri
Both are: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Roland Scheidegger
Sounds reasonable to me. Roland Am 04.10.2016 um 01:44 schrieb Rob Clark: > There are a lot of callers for ->resource_create() and friends.. > although I suspect it is a small subset that don't zero-init. But > I'll have to go through all the call sites and check, but I didn't yet > find time ye

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Rob Clark
There are a lot of callers for ->resource_create() and friends.. although I suspect it is a small subset that don't zero-init. But I'll have to go through all the call sites and check, but I didn't yet find time yet to do that today.. I don't want to annoy too many folks w/ broken piglits, so if

[Mesa-dev] [PATCH 1/2] mesa: Reorganize check_textarget().

2016-10-03 Thread Kenneth Graunke
Having one top-level switch statement covering all known texture targets will make the next change easier to implement. Signed-off-by: Kenneth Graunke --- src/mesa/main/fbobject.c | 80 ++-- 1 file changed, 37 insertions(+), 43 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] mesa: Raise INVALID_ENUM in FramebufferTexture*D for unknown textargets.

2016-10-03 Thread Kenneth Graunke
ES3-CTS.functional.negative_api.buffer.framebuffer_texture2d expects glFramebufferTexture[123]D to raise GL_INVALID_ENUM when supplied a completely bogus textarget parameter (i.e. 0x). This is at odds with the spec. GLES 3.1 says: "An INVALID_OPERATION error is generated if texture is

Re: [Mesa-dev] [PATCH V2 07/11] anv/image: Memset hiz surfaces to 0 when binding memory

2016-10-03 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Sep 27, 2016 at 10:59 AM, Chad Versace wrote: > On Mon 26 Sep 2016, Nanley Chery wrote: > > From: Jason Ekstrand > > > > Nanley Chery (amend): > > - Change memset value from 0xff to 0 (a defined value for HiZ). > > > > Signed-off-by: Nanley Chery > > > > -

Re: [Mesa-dev] [PATCH V2 05/11] anv: Allocate hiz surface

2016-10-03 Thread Jason Ekstrand
On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery wrote: > From: Chad Versace > > Nanley Chery: > (rebase) > - Use isl_surf_get_hiz_surf() > (amend) > - Only add a HiZ surface onto a depth/stencil attachment > - Add comment above HiZ surface addition > - Hide HiZ behind INTEL_VK_HIZ prior to BDW

Re: [Mesa-dev] [PATCH 1/2] nir: Add a nop intrinsic

2016-10-03 Thread Kenneth Graunke
On Thursday, September 15, 2016 9:16:04 PM PDT Jason Ekstrand wrote: > This intrinsic has no destination, no sources, no variables, and can be > eliminated. In other words, it does nothing and will always get deleted by > dead code elimination. However, it does provide a quick-and-easy way to > t

[Mesa-dev] [PATCH] Revert "mesa_glinterop: remove inclusion of GLX header"

2016-10-03 Thread Vinson Lee
This reverts commit 8472045b16b3e4621553fe451a20a9ba9f0d44b6. Conflicts: include/GL/mesa_glinterop.h This patch fixes this build error with GCC 4.4. Compiling src/glx/dri_common_interop.c ... In file included from src/glx/dri_common_interop.c:33: include/GL/mesa_glinterop.h:62: error:

Re: [Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

2016-10-03 Thread Andy Furniss
Zhang, Boyuan wrote: Hi Andy, Thanks for the testings. Regarding to the inconsistencies, the current Vaapi dual instances encoding behaviour is random. Whether or not the dual instances is being used depends on how early the player calls sync_surface function according to the current gstreamer-

Re: [Mesa-dev] [PATCH] anv/gen7_pipeline: Fix typo in semicolon

2016-10-03 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Oct 3, 2016 at 10:44 AM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/vulkan/gen7_pipeline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_ > pipeline.c

[Mesa-dev] [PATCH v2 01/13] anv: Use blorp for VkCmdFillBuffer

2016-10-03 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/intel/vulkan/anv_blorp.c | 106 + src/intel/vulkan/anv_meta_clear.c | 120 -- 2 files changed, 96 insertions(+), 130 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/v

Re: [Mesa-dev] [PATCH V2 8/9] anv/gen7_pipeline: Set sample mask field in 3DSTATE_PS

2016-10-03 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Oct 3, 2016 at 10:13 AM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/vulkan/gen7_pipeline.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_ > pipeline.c > index 9411

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

2016-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97542 Clément Guérin changed: What|Removed |Added CC||geecko@free.fr -- You are receivin

Re: [Mesa-dev] [Request for Testing] i965: import prime buffers in the current context, not screen

2016-10-03 Thread Kristian Høgsberg
On Thu, Sep 29, 2016 at 7:33 AM Martin Peres wrote: > On 02/09/16 10:08, Martin Peres wrote: > > > > > > On 25/08/16 21:49, Kristian Høgsberg wrote: > >> On Thu, Aug 25, 2016 at 11:38 AM, Chad Versace > >> wrote: > >>> On Thu 25 Aug 2016, Martin Peres wrote: > This mirrors the codepath take

[Mesa-dev] [Bug 97542] mesa-12.0.1 with llvm-3.9.0_rc3 - src/gallium/state_trackers/clover/llvm/invocation.cpp:212:75: error: no matching function for call to clang::CompilerInvocation::setLangDefault

2016-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97542 --- Comment #11 from Clément Guérin --- Hello, I built mesa 12.0.3 against llvm 3.9.0 on arch linux. Rocket League and Portal were working properly, however Tomb Raider was crashing right before the Feral logo. -- You are receiving this mail be

[Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

2016-10-03 Thread Emil Velikov
From: Emil Velikov Fold duplicate conditional blocks and add a few extra comments ;-) v2: Bring back the explicit "unbind" logic (Eric), remove NULL derefs. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/egl_dri2.c | 72 - 1 file changed, 36 inser

Re: [Mesa-dev] [PATCH 10/30] egl/dri2: rework dri2_make_current code flow

2016-10-03 Thread Emil Velikov
On 25 September 2016 at 04:24, Eric Engestrom wrote: > On Thu, Aug 25, 2016 at 05:18:32PM +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Duplicate a few lines at the expense of making the code-flow clearer >> while adding a few extra comments ;-) >> >> Signed-off-by: Emil Velikov >> ---

[Mesa-dev] [PATCH] anv/gen7_pipeline: Fix typo in semicolon

2016-10-03 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/vulkan/gen7_pipeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index bafee28..c9d1f64 100644 --- a/src/intel/vulkan/gen7_pipeline.c +++ b/src/intel/vulkan/gen7_

Re: [Mesa-dev] [PATCH 0/2] clover: clEnqueueMigrateMemObjects

2016-10-03 Thread Serge Martin
Ping On Saturday 12 September 2015 21:08:20 Serge Martin wrote: > Now that mem object can be move back to the host, I think we should latter > come with a way to optimize read mapping for such objets. For the moment if > they are mapped for reading after been moved to the host, they will be send >

Re: [Mesa-dev] [PATCH 8/9] anv/gen7_pipeline: Set few missing fields in 3DSTATE_PS

2016-10-03 Thread Anuj Phogat
On Fri, Sep 30, 2016 at 5:02 PM, Jason Ekstrand wrote: > On Sep 30, 2016 3:34 PM, "Anuj Phogat" wrote: >> >> Signed-off-by: Anuj Phogat >> --- >> src/intel/vulkan/gen7_pipeline.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/src/intel/vulkan/gen7_pipeline.c >> b/src/intel/vulk

Re: [Mesa-dev] [PATCH 9/9] anv/gen7_pipeline: Check for ksp0 when setting BarycentricInterpolationMode in 3DSTATE_WM

2016-10-03 Thread Anuj Phogat
On Fri, Sep 30, 2016 at 5:03 PM, Jason Ekstrand wrote: > On Sep 30, 2016 3:34 PM, "Anuj Phogat" wrote: >> >> Signed-off-by: Anuj Phogat >> --- >> src/intel/vulkan/gen7_pipeline.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/src/intel/vulkan/gen7_pipeline.c >> b/

[Mesa-dev] [PATCH V2 8/9] anv/gen7_pipeline: Set sample mask field in 3DSTATE_PS

2016-10-03 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/intel/vulkan/gen7_pipeline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/vulkan/gen7_pipeline.c b/src/intel/vulkan/gen7_pipeline.c index 9411631..bafee28 100644 --- a/src/intel/vulkan/gen7_pipeline.c +++ b/src/intel/vulkan/gen7_pipeline.c @@

Re: [Mesa-dev] [PATCH] nv50/ra: let simplify return an error and handle that

2016-10-03 Thread Samuel Pitoiset
On 10/03/2016 06:55 PM, Karol Herbst wrote: fixes a crash in the case simplify reports an error Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/nouveau/code

Re: [Mesa-dev] [PATCH] autoconf: Make header install distinct for various APIs

2016-10-03 Thread Emil Velikov
On 30 September 2016 at 19:37, Chuck Atkins wrote: > This fixes a problem where GL headers would only get installed if > glx was enabled. So if osmesa was enabled but not glx, then the > GL headers required by osmesa would be missing from the install. > > Signed-off-by: Chuck Atkins > --- > con

Re: [Mesa-dev] [PATCH] nv50/ra: let simplify return an error and handle that

2016-10-03 Thread Ilia Mirkin
Of course this only helps shader-db, right? Pretty sure you'll hit an assert if you try to draw... Either way, that can be fixed later. This is Reviewed-by: Ilia Mirkin On Mon, Oct 3, 2016 at 12:55 PM, Karol Herbst wrote: > fixes a crash in the case simplify reports an error > > Signed-off-by:

[Mesa-dev] [PATCH] nv50/ra: let simplify return an error and handle that

2016-10-03 Thread Karol Herbst
fixes a crash in the case simplify reports an error Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_ra.cpp b/src/gallium/drivers/nouvea

Re: [Mesa-dev] [PATCH] vl/dri3: fix warning about incompatible pointer type

2016-10-03 Thread Leo Liu
Reviewed and Pushed. On 10/01/2016 01:22 AM, Nayan Deshmukh wrote: Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_d

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Roland Scheidegger
In an ideal world everybody would zero-intialize the template I suppose - then it would easily survive such interface changes. I thought though there shouldn't be many callers but I might have been wrong about this... Roland Am 03.10.2016 um 18:48 schrieb Rob Clark: > the interface is a bit hand

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Rob Clark
the interface is a bit hand-wavey, ie. w/ things like prsc->screen overwriten by driver.. I guess I can try to track down the screen->resource_create() callers that aren't zero-init'ing the templ, although the # of callers seemed much higher than # of drivers BR, -R On Mon, Oct 3, 2016 at 12:27

Re: [Mesa-dev] [PATCH 4/9] anv/gen8_pipeline: Use Alternate floating point mode when use_alt_mode is set in prog_data

2016-10-03 Thread Anuj Phogat
On Sun, Oct 2, 2016 at 1:59 PM, Kenneth Graunke wrote: > On Friday, September 30, 2016 3:33:12 PM PDT Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> --- >> src/intel/vulkan/gen8_pipeline.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/src/intel/vulkan/gen8_pi

Re: [Mesa-dev] [PATCH] autoconf: Make header install distinct for various APIs

2016-10-03 Thread Chuck Atkins
Ping? On Sep 30, 2016 2:37 PM, "Chuck Atkins" wrote: > This fixes a problem where GL headers would only get installed if > glx was enabled. So if osmesa was enabled but not glx, then the > GL headers required by osmesa would be missing from the install. > > Signed-off-by: Chuck Atkins > --- >

Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Roland Scheidegger
I don't think that's really a good idea. Zero-initializing things is one thing, but explicitly overwrite things which were given to the driver by the st is something else. (I'm not even sure how it works if the driver always overwrites this to zero no matter what. Well I suppose those are the conse

[Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-03 Thread Rob Clark
Fix potential issues if state-tracker passes in garbage in templ->next ptr. See: https://lists.freedesktop.org/archives/mesa-dev/2016-September/129867.html Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_resource.c | 2 ++ src/gallium/drivers/i915/i915_resource_buffer.c

Re: [Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

2016-10-03 Thread Zhang, Boyuan
Hi Andy, Thanks for the testings. Regarding to the inconsistencies, the current Vaapi dual instances encoding behaviour is random. Whether or not the dual instances is being used depends on how early the player calls sync_surface function according to the current gstreamer-vaapi's mechanism. e

Re: [Mesa-dev] [PATCH 5/5] st/mesa: move all sampler view code into new st_sampler_view.[ch] files

2016-10-03 Thread Brian Paul
Actually, I just need to bracket some of the assertions with the test for GL_TEXTURE_BUFFER. I'll make that change and re-test before pushing. I suspect I did my piglit run w/ a release build on Windows. Thanks for reviewing. -Brian On 10/02/2016 02:53 PM, Marek Olšák wrote: One more fix f

Re: [Mesa-dev] [PATCH] anv/formats: Fix build on gcc-4 and earlier

2016-10-03 Thread Ville Syrjälä
On Fri, Sep 30, 2016 at 04:11:51PM -0700, Jason Ekstrand wrote: > I remember the first tone you fixed this but when I was going the > ISL_SWIZZLE stuff, Wasn't me, or at least I can't recall doing anything of the sort :) > I couldn't find it in the git log so I went ahead and > pushed the change.

Re: [Mesa-dev] [PATCH v3] glsl: optimize copy_propagation_elements pass

2016-10-03 Thread Tapani Pälli
Ah now I get what you meant and these changes make sense to me, this is easier to read. I did not spot regressions in CI run. On 09/30/2016 06:12 PM, Ian Romanick wrote: From: Tapani Pälli Changes make copy_propagation_elements pass faster, reducing link time spent in test case of bug 94477.

Re: [Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

2016-10-03 Thread Andy Furniss
Boyuan Zhang wrote: This patch improves the performance of Vaapi Encode by enabling dual instances encoding. flush function is not called after each end_frame call. radeon/vce will do flush whenever 2 frames are submitted for encoding. Implement sync surface function to flush only if the frame ha

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-10-03 Thread Jason Ekstrand
On Oct 3, 2016 12:19 AM, "Albert Freeman" wrote: > > year.month or year.dayoutofdaysthatyear Why are we adding more options to an already confused discussion? > dayoutoofdaysthatyear skips lots of integers quickly: reducing > confusion of where is release x.(y - something) and better handles > q

[Mesa-dev] [Bug 97230] MATLAB hangs if DRI3 enabled with intel driver

2016-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97230 --- Comment #7 from Eero Tamminen --- (In reply to sergio.callegari from comment #6) > Number of threads is very very large... anything that can be grepped? It's better to see the whole output. If the output is long, just add it as attachment i

[Mesa-dev] [Bug 97230] MATLAB hangs if DRI3 enabled with intel driver

2016-10-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97230 --- Comment #6 from sergio.calleg...@gmail.com --- Number of threads is very very large... anything that can be grepped? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

Re: [Mesa-dev] [PATCH] intel: fix compilation warning on gen_get_device_info

2016-10-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/10/16 07:32, Tapani Pälli wrote: (warning: 'const' type qualifier on return type has no effect) Signed-off-by: Tapani Pälli --- src/intel/common/gen_device_info.c | 2 +- src/intel/common/gen_device_info.h | 2 +- 2 files changed, 2 insertions(+), 2 de

Re: [Mesa-dev] Proposal of date-based Mesa versioning for 2017

2016-10-03 Thread Albert Freeman
year.month or year.dayoutofdaysthatyear dayoutoofdaysthatyear skips lots of integers quickly: reducing confusion of where is release x.(y - something) and better handles quick fix releases but makes it harder to determine how far into the year the release is although with some effort can be conver