Re: [Mesa-dev] merging radv

You can put my, Acked-by: Edward O'Callaghan on the entire series Dave. Kind Regards, Edward. On 10/06/2016 12:27 PM, Dave Airlie wrote: > If nobody has any remaining major objections I'd rather not spend too > much time rebasing this stuff, so I'd like to propose merging it > approx now + 24h

Re: [Mesa-dev] [PATCH 1/8] i965: get uses texture gather from nir info

On Oct 5, 2016 19:15, "Kenneth Graunke" wrote: > > On Wednesday, October 5, 2016 5:32:27 PM PDT Timothy Arceri wrote: > > This is a step towards dropping the GLSL IR version of > > do_set_program_inouts() in i965 and moving towards native nir support. > > > > This is important because we want to e

Re: [Mesa-dev] [PATCH 1/3] nir: Add asserts to the casting functions

On Oct 5, 2016 21:42, "Connor Abbott" wrote: > > Thanks for doing this! This has always bugged me. For the series, Yeah, nir_loop_last_cf_node and friends in particular have been bugging me for a lng time. > Reviewed-by: Connor Abbott Thanks! > On Wed, Oct 5, 2016 at 11:37 PM, Jason Ekstr

Re: [Mesa-dev] [PATCH 1/3] nir: Add asserts to the casting functions

Thanks for doing this! This has always bugged me. For the series, Reviewed-by: Connor Abbott On Wed, Oct 5, 2016 at 11:37 PM, Jason Ekstrand wrote: > This makes calling nir_foo_as_bar a bit safer because we're no longer 100% > trusting in the caller to ensure that it's safe. The caller still n

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

On Wed, Oct 5, 2016 at 7:05 PM, Xu, Randy wrote: > Hi, Jason > > > > Do you want to add this assert in the patch? I did some test, no issue > found, but I don’t see the case that we need override the texture target in > brw_emit_surface_state, i.e. surf.dim_layout != dim_layout > > How can we cre

[Mesa-dev] [PATCH 3/3] nir: Remove some no longer needed asserts

Now that the NIR casting functions have type assertions, we have a bunch of assertions that aren't needed anymore. Signed-off-by: Jason Ekstrand --- src/compiler/nir/nir.h | 1 - src/compiler/nir/nir_control_flow.c | 6 -- src/compiler/nir/nir_lower_atomics.c

[Mesa-dev] [PATCH 2/3] nir: Make nir_foo_first/last_cf_node return a block instead

One of NIR's invariants is that control flow lists always start and end with blocks. There's no good reason why we should return a cf_node from these functions since we know that it's always a block. Making it a block lets us remove a bunch of code. Signed-off-by: Jason Ekstrand --- src/compil

[Mesa-dev] [PATCH 1/3] nir: Add asserts to the casting functions

This makes calling nir_foo_as_bar a bit safer because we're no longer 100% trusting in the caller to ensure that it's safe. The caller still needs to do the right thing but this ensures that we catch invalid casts with an assert rather than by reading garbage data. The one downside is that we do

Re: [Mesa-dev] [PATCH 08/10] nir: add a loop unrolling pass

On Thu, 2016-10-06 at 13:25 +1100, Timothy Arceri wrote: > > > + > > > +static void > > > +update_remap_tables(bool is_first_iteration, struct hash_table > > > *remap_table, > > > +                    struct hash_table *phi_remap, > > > +                    struct hash_table *src_before_loop, >

Re: [Mesa-dev] [PATCH] glsl: Drop the ES requirement that VS outputs must be flat qualified.

The code looks correct. Assuming this is meant to be removed from all versions (I couldn't tell from a quick skim over the bug). Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman

Re: [Mesa-dev] [PATCH 08/10] nir: add a loop unrolling pass

Just  On Wed, 2016-10-05 at 16:23 -0700, Jason Ekstrand wrote: > > > On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri abora.com> wrote: > > V2: > > - tidy ups suggested by Connor. > > - tidy up cloning logic and handle copy propagation > >  based of suggestion by Connor. > > - use nir_ssa_def_r

Re: [Mesa-dev] [PATCH 1/8] i965: get uses texture gather from nir info

On Wednesday, October 5, 2016 5:32:27 PM PDT Timothy Arceri wrote: > This is a step towards dropping the GLSL IR version of > do_set_program_inouts() in i965 and moving towards native nir support. > > This is important because we want to eventually convert to nir and > use its optimisations passes

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

Hi, Jason Do you want to add this assert in the patch? I did some test, no issue found, but I don’t see the case that we need override the texture target in brw_emit_surface_state, i.e. surf.dim_layout != dim_layout How can we create this case? And we may need another patch to solve the issue

[Mesa-dev] [PATCH] glsl: Drop the ES requirement that VS outputs must be flat qualified.

Several conformance tests violate this requirement: ES31-CTS.core.tessellation_shader.max_patch_vertices ES31-CTS.core.tessellation_shader.tessellation_control_to_tessellation_evaluation.data_pass_through I submitted a merge request to fix the conformance tests, but Khronos opted to drop this GLS

[Mesa-dev] merging radv

If nobody has any remaining major objections I'd rather not spend too much time rebasing this stuff, so I'd like to propose merging it approx now + 24hr, if anyone wants to explicitly ack or r-b anything let me know, but I'm most likely going to squash merge down the contents of this branch https:

Re: [Mesa-dev] [PATCH 4/4] radv: toplevel configure/make changes required to build (v1.1)

On 6 October 2016 at 07:07, Gustaw Smolarczyk wrote: > Additional problems when configuring radv without the rest of mesa > (might be also applicable to anv): > 1. For radv to advertise VK_KHR_xcb_surface, HAVE_PLATFORM_X11 has to > be defined. This variable is set from the list of EGL platforms,

Re: [Mesa-dev] [PATCH 2/4] radv/winsys: import the amdgpu winsys for the radv vulkan driver. (v1.1)

Please snip out stuff if you have just one question. That code comes from the radeonsi driver, no point wondering here about why the default is there, if you never wondered why it's in the radeonsi code :) Dave. ___ mesa-dev mailing list mesa-dev@lists.

[Mesa-dev] [PATCH 2/6] st/mesa: add some const qualifiers in st_atom_texture.c

And minor code reformatting. Reviewed-by: Edward O'Callaghan --- src/mesa/state_tracker/st_atom_texture.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_texture.c b/src/mesa/state_tracker/st_atom_texture.c index 113c0ed..86f1c62 100644

[Mesa-dev] [PATCH 4/6] mesa: call ctx->Driver.TexParameter() in texture_buffer_range()

To inform drivers of texture buffer offset/size changes, as we do for other texture object parameters. --- src/mesa/main/teximage.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index df8f0bc..411ec49 100644 --- a/src/mesa/ma

[Mesa-dev] [PATCH 3/6] st/mesa: consolidate view format setup code

Before, we had code to compute the sampler view's format spread across two different functions: in update_single_texture() and st_get_texture_sampler_view_from_stobj(). Now it's all in one new function. Also, use _mesa_texture_base_format() to simplify the code. Reviewed-by: Edward O'Callaghan

[Mesa-dev] [PATCH 6/6] st/mesa: move all sampler view code into new st_sampler_view.[ch] files

Previously, the sampler view code was scattered across several different files. Note, the previous REALLOC(), FREE() for st_texture_object::sampler_views are replaced by realloc(), free() to avoid conflicting macros in Mesa vs. Gallium. Reviewed-by: Edward O'Callaghan --- src/mesa/Makefile.sour

[Mesa-dev] [PATCH 5/6] st/mesa: optimize pipe_sampler_view validation

Before, st_get_texture_sampler_view_from_stobj() did a lot of work to check if the texture parameters matched the sampler view (format, swizzle, min/max lod, first/last layer, etc). We did this every time we validated the texture state. Now, we use a ctx->Driver.TexParameter() callback and a coup

[Mesa-dev] [PATCH 1/6] st/mesa: simplify some code in get_texture_format_swizzle()

There's no need to cast to st_texture_image. Just use gl_texture_image. Reviewed-by: Edward O'Callaghan --- src/mesa/state_tracker/st_atom_texture.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_texture.c b/src/mesa/state_tracker/

Re: [Mesa-dev] [PATCH 5/5] st/mesa: move all sampler view code into new st_sampler_view.[ch] files

I found a problem with texture buffers that I missed before. We need to discard the texture's sampler view if the texture buffer offset/size params change. The cleanest way to tell the state tracker about this is to use the ctx->Driver.TexParameter() callback. I've made that change, retest

[Mesa-dev] [PATCH 2/2] anv/cmd_buffer: Move the clear_subpasses calls to set_subpass

Signed-off-by: Jason Ekstrand --- src/intel/vulkan/genX_cmd_buffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 1dff6a1..9466601 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/in

[Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't call set_subpass in a secondary

Initially, we had intended set_subpass to be an interesting function that did whatever (presumably a lot) setup we needed for a subpass. In reality, it just sets a pointer and a dirty bit and then emits depth and stencil state. When we call BeginCommandBuffer on a secondary, all of the dirty bits

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

On Wed, Oct 05, 2016 at 04:30:51PM -0700, Nanley Chery wrote: > On Tue, Sep 27, 2016 at 02:47:22PM -0700, Nanley Chery wrote: > > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > > On Mon 26 Sep 2016, Nanley Chery wrote: > > > > From: Nanley Chery > > > > > > > > Provides an FPS

Re: [Mesa-dev] [PATCH 0/4] i965: Fixes and cleanups for intel_syncobj.c

On Tuesday, October 4, 2016 3:37:52 PM PDT Chad Versace wrote: > I'm preparing to implement EGL_ANDROID_native_fence_sync, and I wanted > to land these fixes and cleanups before doing the real work. > > Patch 1 is a bugfix. The other patches are cleanups. > > This series lives at > http://git.ki

[Mesa-dev] [PATCH] anv: fix GetPhysicalDeviceProperties to return timestampPeriod in ns

According to chapters 16.5. (Timestamp Queries) and 30.2 (Limits) of the Vulkan Specification 1.0.29, the .limits.timestampPeriod field returned by vkGetPhysicalDeviceProperties is measured in nanoseconds, not in seconds. Signed-off-by: Philipp Zabel --- src/intel/vulkan/anv_device.c | 2 +- 1 f

Re: [Mesa-dev] [PATCH V2 10/11] genX/cmd_buffer: Enable fast depth clears

On Tue, Sep 27, 2016 at 02:47:22PM -0700, Nanley Chery wrote: > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote: > > On Mon 26 Sep 2016, Nanley Chery wrote: > > > From: Nanley Chery > > > > > > Provides an FPS increase of ~30% on the Sascha triangle and multisampling > > > demos. > >

Re: [Mesa-dev] [PATCH 08/10] nir: add a loop unrolling pass

On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > V2: > - tidy ups suggested by Connor. > - tidy up cloning logic and handle copy propagation > based of suggestion by Connor. > - use nir_ssa_def_rewrite_uses to fix up lcssa phis > suggested by Connor. > -

Re: [Mesa-dev] [PATCH] nir: Delete open coded type printing.

Seems reasonable. Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument.

It's supposed to be how much at least we want to grow the cs, not the minimum size of the cs after growth. --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/

[Mesa-dev] [PATCH 1/2] radv: Skip already signalled fences.

If the user created a fence with VK_FENCE_CREATE_SIGNALED_BIT set, we shouldn't fail to wait for a fence if it was not submitted since that is not necessary. --- src/amd/vulkan/radv_device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/sr

Re: [Mesa-dev] [PATCH 05/11] nir: Add a LCSAA-pass

On Wed, 2016-10-05 at 09:59 -0700, Jason Ekstrand wrote: > On Tue, Oct 4, 2016 at 6:46 PM, Timothy Arceri ora.com> wrote: > > On Tue, 2016-10-04 at 16:47 -0700, Jason Ekstrand wrote: > > > On Fri, Sep 16, 2016 at 6:24 AM, Timothy Arceri > olla > > > bora.com> wrote: > > > > From: Thomas Helland

[Mesa-dev] [PATCH 0/2] Quick radv fixes.

Hello, I understand that radv has not been merged yet, but I wanted to publish my 2 patches that make the LunarG's Hologram sample work on SI. If you decide to merge my patches, please push them yourself as I don't possess appropriate access. Regards, Gustaw Gustaw Smolarczyk (2): radv: Skip

[Mesa-dev] [PATCH v4] intel: aubinator: generate a standalone binary

Embed the xml files into the binary, so aubinator can be used from any location. v2: Split generation packing into another patch (Jason) Check for xxd (Jason) v3: Fix out of tree builds (Jason) Generate custom variable name rather than names generated by xxd (Lionel) v4: Move generat

Re: [Mesa-dev] [PATCH] nv50/ir: optimize sub(a, 0) to a

To be clear, this also rewrites sub(0, a) to neg(a). Either way, this is Reviewed-by: Ilia Mirkin On Wed, Oct 5, 2016 at 6:36 PM, Karol Herbst wrote: > helped some ue4 demos and divinity OS shaders > > total instructions in shared programs : 2818674 -> 2818606 (-0.00%) > total gprs used in shar

[Mesa-dev] [PATCH] nv50/ir: optimize sub(a, 0) to a

helped some ue4 demos and divinity OS shaders total instructions in shared programs : 2818674 -> 2818606 (-0.00%) total gprs used in shared programs: 379273 -> 379273 (0.00%) total local used in shared programs : 9505 -> 9505 (0.00%) total bytes used in shared programs : 25837792 -> 258371

Re: [Mesa-dev] [PATCH] glsl: Let cache_test build when the shader cache is not enabled

Thanks for fixing this, I wasn't aware it was broken. Reviewed-by: Timothy Arceri On Wed, 2016-10-05 at 13:22 -0700, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick > Cc: Timothy Arceri > --- >  src/compiler/glsl/tests/cache_test.c | 4 >  1 file changed, 4 inser

Re: [Mesa-dev] radv vs vulkan loader

2016-10-06 0:05 GMT+02:00 Emil Velikov : > On 5 October 2016 at 21:45, Gustaw Smolarczyk wrote: >> Hello, >> >> I have encountered a following problem while trying to use radv >> through LunarG's vulkan loader. >> >> It seems that the loader dlopens() the ICD library twice. First, it >> looks up "

Re: [Mesa-dev] radv vs vulkan loader

On 5 October 2016 at 21:45, Gustaw Smolarczyk wrote: > Hello, > > I have encountered a following problem while trying to use radv > through LunarG's vulkan loader. > > It seems that the loader dlopens() the ICD library twice. First, it > looks up "vk_icdNegotiateLoaderICDInterfaceVersion" symbol,

Re: [Mesa-dev] [PATCH] docs: Mark GL_OES_viewport_array done on i965

Quoting Anuj Phogat (2016-10-05 14:07:50) > Signed-off-by: Anuj Phogat > --- > docs/features.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/features.txt b/docs/features.txt > index 85ad1a1..4c744c6 100644 > --- a/docs/features.txt > +++ b/docs/features.txt > @@

Re: [Mesa-dev] [PATCH 2/2] radv: Add new flag for LLVM dependecies with vulkan

Hi Emil, the approach Dave used is ok and makes this obsolete. I talked about this to him in IRC. I actually _don't_ want a gallium like approach and didn't like this patch too much. This was just he least amount of changes without touching anything else and still make it work. Having said th

Re: [Mesa-dev] [PATCH 08/11] nir: add helper for cloning loops

On Wed, Oct 5, 2016 at 11:49 AM, Jason Ekstrand wrote: > > > On Fri, Sep 16, 2016 at 6:24 AM, Timothy Arceri < > timothy.arc...@collabora.com> wrote: > >> --- >> src/compiler/nir/nir.h | 2 ++ >> src/compiler/nir/nir_clone.c | 41 ++ >> --- >> 2 files c

[Mesa-dev] [PATCH] docs: Mark GL_OES_viewport_array done on i965

Signed-off-by: Anuj Phogat --- docs/features.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index 85ad1a1..4c744c6 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -319,7 +319,7 @@ Khronos, ARB, and OES extensions that are no

Re: [Mesa-dev] [PATCH 4/4] radv: toplevel configure/make changes required to build (v1.1)

Additional problems when configuring radv without the rest of mesa (might be also applicable to anv): 1. For radv to advertise VK_KHR_xcb_surface, HAVE_PLATFORM_X11 has to be defined. This variable is set from the list of EGL platforms, so EGL has to be enabled for it to be built. 2. radv uses XCB_

Re: [Mesa-dev] [PATCH 01/75] llvmpipe: Fix overflow for 32 bits available memory computation

Am 05.10.2016 um 22:08 schrieb Axel Davy: > And cap to 2 GB on 32 bits. > > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94561 > > Signed-off-by: Axel Davy > Signed-off-by: Patrick Rudolph > --- > src/gallium/auxiliary/os/os_misc.c | 2 +- > src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [Bug 98012] [anv] Segfault when running Dolphin twice on Ivy Bridge

https://bugs.freedesktop.org/show_bug.cgi?id=98012 --- Comment #1 from Link Mauve --- Created attachment 127038 --> https://bugs.freedesktop.org/attachment.cgi?id=127038&action=edit End of a Valgrind trace of a Dolphin process, stopped with ^C -- You are receiving this mail because: You are t

[Mesa-dev] radv vs vulkan loader

Hello, I have encountered a following problem while trying to use radv through LunarG's vulkan loader. It seems that the loader dlopens() the ICD library twice. First, it looks up "vk_icdNegotiateLoaderICDInterfaceVersion" symbol, which seems to be the new mechanism used to determine the version

[Mesa-dev] [PATCH] anv/wsi: Advertise UNORM formats as well as sRGB

Because WSI images are created with VkImageCreateInfo::flags explicitly set to 0, they don't ever have the VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT set. This means that you can't create an image view of it with a different format so applications can't render directly in sRGB (without automatic encoding)

[Mesa-dev] [PATCH] glsl: Let cache_test build when the shader cache is not enabled

From: Ian Romanick Signed-off-by: Ian Romanick Cc: Timothy Arceri --- src/compiler/glsl/tests/cache_test.c | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl/tests/cache_test.c b/src/compiler/glsl/tests/cache_test.c index 1b0403c..724dfcd 100644 --- a/src/compiler/glsl/

[Mesa-dev] [PATCH 27/75] st/nine: Compact ff vs constants a bit

There are several holes. This patch reduces the holes a bit, which reduces the size of the constant buffer uploaded. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/gallium/state_tra

[Mesa-dev] [PATCH 39/75] st/nine: Fix ff computation for inverse

Thanks to wine tests. Apparently 4x4 inverse is to be used, and if the inverse can't be calculated, the input matrix is to be used. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 26 ++ src/gallium/state_trackers/nine/nine_ff.h | 3 --- 2 files

[Mesa-dev] [PATCH 65/75] st/nine: Add additional error handling in CheckDeviceMultiSampleType

From: Patrick Rudolph Return one supported quality level in error cases. Return error on invalid multisample count. Fixes failing wine tests. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/adapter9.c | 6 ++ 1 file changed, 6 insertions(+) diff

[Mesa-dev] [PATCH 42/75] st/nine: Do not pollute rTmp in ff ps

Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/nine_ff.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index 680b967..1fc96fb 100644 ---

[Mesa-dev] [PATCH 41/75] st/nine: Allocate temporaries on demand for ps ff

Same change than for vs ff. This makes it easier to not introduce mistakes reusing temporaries whose result shouldn't be erased. Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/nine_ff.c | 24 ++-- 1 file changed, 10 insertions(+),

[Mesa-dev] [PATCH 30/75] st/nine: Undefined specular should be full of zeros

Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/nine_ff.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index 391654f..d3772a6 100

[Mesa-dev] [PATCH 69/75] st/nine: Use NineDevice9_CreateDepthStencilSurface in swapchain9

From: Patrick Rudolph Replace custom code with NineDevice9_CreateDepthStencilSurface. All functionality is given now. --- src/gallium/state_trackers/nine/swapchain9.c | 30 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/src/gallium/state_trackers/nin

[Mesa-dev] [PATCH 56/75] st/nine: Add debugging output

From: Patrick Rudolph Add DBG calls to NineTexture9_GetLevelDesc and NineTexture9_GetSurfaceLevel to ease debugging. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/texture9.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_t

[Mesa-dev] [PATCH 31/75] st/nine: Fix ff SPECULARENABLE

We were (wrongly) adding specular to diffuse in vertex shaders when SPECULARENABLE was set. However the spec says specular has to be added after texture processing (which is in ps). Besides SPECULARENABLE is flagged as a pixel state. There was unused support for SPECULARENABLE in the ps ff code.

[Mesa-dev] [PATCH 66/75] st/nine: Prepare update_framebuffer for MS quality levels

From: Patrick Rudolph Compare resource's nr_samples instead of D3D multisample level. Required for multisample quality levels to work correct. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/nine_state.c | 8 1 file changed, 4 insertions(+),

[Mesa-dev] [PATCH 52/75] st/nine: Print interface id in NineUnknown_QueryInterface

From: Patrick Rudolph To ease debugging print interface id. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/iunknown.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/iunknown.c b/src/gallium/sta

[Mesa-dev] [PATCH 46/75] st/nine: Disable parts of lighting calculation if no normal provided

Behaviour found in Wine sources, and checked with some test apps. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 61 ++- 1 file changed, 35 insertions(+), 26 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/

[Mesa-dev] [PATCH 40/75] st/nine: Fix texbem

Error found with wine tests. nine_shader was expecting another order than the one device9 was using. Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/device9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_tr

[Mesa-dev] [PATCH 10/75] st/nine: Add missing break

From: Patrick Rudolph Add missing break instruction. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/nine_pipe.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/nine/nine_pipe.h b/src/gallium/state_trackers/nine/nine_pi

[Mesa-dev] [PATCH 75/75] st/nine: More checks for GetRenderTargetData

Fixes a wine test crash Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/device9.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c index 0c9e78b..b8d82be 10064

[Mesa-dev] [PATCH 70/75] st/nine: Assert on buffer creation failure

From: Patrick Rudolph Add an assert to make sure buffer creation doesn't fail. Add error handling in calling functions. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/swapchain9.c | 26 ++ 1 file changed, 18 insertions(+), 8 d

[Mesa-dev] [PATCH 34/75] st/nine: Fix tweening factor computation

The computation was reversed. Deduced by tests on windows. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index 1

[Mesa-dev] [PATCH 55/75] st/nine: Fix assert in NineUnknown_QueryInterface

From: Patrick Rudolph Tests showed that is allowed to call this method on object that have a zero refcount. Required for issue #230. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/iunknown.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 19/75] st/nine: Partial software vertex processing support

Software Vertex Processing allows: . Less limitations for shaders (more loops, etc) . Less limitations for ff (more enabled lights, 255 matrices for VertexBlend) In particular shaders can get more constants. This patch implements support for this (not using software rendering, but hardware renderi

[Mesa-dev] [PATCH 63/75] st/nine: Remove resource9 {Set/Get/Free}PrivateData functions

From: Patrick Rudolph Remove {Set/Get/Free}PrivateData in resource9. Functionality has been implement in IUnknown interface. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/resource9.c | 115 +--- src/gallium/state_trackers/nin

[Mesa-dev] [PATCH 60/75] st/nine: Implement {Set/Get/Free}PrivateData in iunknown

From: Patrick Rudolph Implement {Set/Get/Free}PrivateData in iunknown to get rid of duplicated code in resource9 and volume9. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/iunknown.c | 114 + src/gallium/state_trackers/ni

[Mesa-dev] [PATCH 47/75] st/nine: Fix specular w coordinate

Found looking at Wine formulas. Fixes a few visual issues. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index

[Mesa-dev] [PATCH 45/75] st/nine: Fix condition for specular lightning

Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index 374e92f..1db312c 100644 --- a/src/galli

[Mesa-dev] [PATCH 62/75] st/nine: Remove volume9 {Set/Get/Free}PrivateData functions

From: Patrick Rudolph Remove {Set/Get/Free}PrivateData in volume9. Functionality has been implement in IUnknown interface. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/nine_lock.c | 38 --- src/gallium/state_trackers/nine/volume9.c | 101

[Mesa-dev] [PATCH 68/75] st/nine: Fix check and remove useless code in swapchain9

The removed code was there for two reasons: 1) Allow DF16, DF24, INTZ to be used as depth buffer for swapchain, if the driver doesn't support PIPE_BIND_SAMPLER_VIEW for the underlying format 2) Set PIPE_BIND_SAMPLER_VIEW if possible, such that if StretchRect is called on the depth texture, it is ha

[Mesa-dev] [PATCH 59/75] st/nine: Return device in NineSurface9_GetContainer

From: Patrick Rudolph According to MSDN the device is returned for surfaces that do not have a regular container. Such surfaces are: OffscreenPlainSurface, DepthStencilSurface and RenderTarget Tested and verified on Windows. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gall

[Mesa-dev] [PATCH 28/75] st/nine: Increase MaxVertexBlendMatrixIndex

Modern cards do advertise 8. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/adapter9.c | 2 +- src/gallium/state_trackers/nine/nine_ff.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/nine/adapter9.c b/src/gallium/state_tra

[Mesa-dev] [PATCH 22/75] st/nine: No need for the local flag for temporaries in ff

Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/nine_ff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index 18d00a7..56876f0 100644 --- a

[Mesa-dev] [PATCH 36/75] st/nine: Enable passthrough only if positiont is used

Wine tests for the passthrough feature are for positiont. Nothing seems to indicate passthrough happens when positiont it not used. However having passthrough with positiont makes sense (to be used with ProcessVertices outputs). Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_

[Mesa-dev] [PATCH 29/75] st/nine: Implement normal transformation with vertex blending

The formula is different from the one of the spec, but otherwise nothing particular. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b

[Mesa-dev] [PATCH 71/75] st/nine: handle possible failure of D3DWindowBuffer_create

From: Patrick Rudolph Check for errors and pass them to the callers. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/swapchain9.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/state_trackers/nine/swapchain9.c b/src/gallium/s

[Mesa-dev] [PATCH 43/75] st/nine: Initialize ps ff registers

Found with wine tests for the rTmp register. Not sure for the other ones. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index 1

[Mesa-dev] [PATCH 67/75] st/nine: Implement MSAA quality levels

From: Patrick Rudolph Advertise quality levels: Each supported multisample count matches to one quality level. The application doesn't know how much samples each quality level has. For that reason it's not possible to set the multisample mask. Return errors on quality level missmatch. Fixes sev

[Mesa-dev] [PATCH 12/75] st/nine: Implement D3DUSAGE_SOFTWAREPROCESSING

Buffers with this flag must be usable with both software and hardware vertex processing. Use Staging for fast cpu access. Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/buffer9.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 26/75] st/nine: Fix vertex blending aVtx computation

There was an multiplication by the world matrix 0 which had nothing to do there. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/s

[Mesa-dev] [PATCH 37/75] st/nine: Implement SPHEREMAP

Behaviour checked with a test app. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/adapter9.c | 2 +- src/gallium/state_trackers/nine/nine_ff.c | 32 +++--- 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/nine/adap

[Mesa-dev] [PATCH 64/75] st/nine: Fix compiler warning

From: Patrick Rudolph Use strict aliasing in SetPrivateData and struct pheader. Casting char[1] to IUnknown** isn't allowed in strict aliasing. Compute pointer to body by adding size of header to header pointer. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_track

[Mesa-dev] [PATCH 01/75] llvmpipe: Fix overflow for 32 bits available memory computation

And cap to 2 GB on 32 bits. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94561 Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/auxiliary/os/os_misc.c | 2 +- src/gallium/drivers/llvmpipe/lp_screen.c | 5 + 2 files changed, 6 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 57/75] st/nine: Fix D3DFMT_NULL size

D3DFMT_NULL is mapped to PIPE_FORMAT_NONE. Instead of relying on PIPE_FORMAT_NONE to return a size, pick one. The one picked is the same than Wine. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_pipe.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/state_tra

[Mesa-dev] [PATCH 74/75] st/nine: Add debug output for lost devices

From: Patrick Rudolph Add debug output to ease debugging. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/swapchain9.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/state_trackers/nine/swapchain9.c b/src/gallium/state_trackers/nin

[Mesa-dev] [PATCH 35/75] st/nine: Fix wrong mask in ff vs

Signed-off-by: Axel Davy Signed-off-by: Patrick Rudolph --- src/gallium/state_trackers/nine/nine_ff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index 12d422b..ce19b9b 100644 --- a/src

[Mesa-dev] [PATCH 58/75] st/nine: Allocate surface resources in surface ctor

From: Patrick Rudolph Allocate resources in surface ctor. Allows to use statetracker internal memory accounting. Fix for issue #231. Signed-off-by: Patrick Rudolph Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c | 53 --- src/gallium/state_trac

[Mesa-dev] [PATCH 54/75] st/nine: Print interface id in NineVolume9_GetContainer

From: Patrick Rudolph To ease debugging print interface id. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/volume9.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/state_trackers/nine/volume9.c b/src/gallium/state_trackers/nine

[Mesa-dev] [PATCH 48/75] st/nine: Fix the calculation of the number of vs inputs

Fixes hangs on radeonsi, and assert on llvmpipe. Signed-off-by: Axel Davy Cc: "12.0" --- src/gallium/state_trackers/nine/nine_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_shader.c b/src/gallium/state_trackers/nine/nine_shade

[Mesa-dev] [PATCH 51/75] st/nine: Move assert in NineSurface9_ctor

From: Patrick Rudolph Move assert to function entry. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/surface9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/surface9.c b/src/gallium/state_tra

[Mesa-dev] [PATCH 49/75] st/nine: Handle user clipping planes properly for ff

Found reading msdn and checking Wine. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index 4bb

[Mesa-dev] [PATCH 38/75] st/nine: Used normed Vtx for reflectionvector

Fix deduced from the spec. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_ff.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/nine/nine_ff.c b/src/gallium/state_trackers/nine/nine_ff.c index c2ce352..2c237f4 100644 --- a/

[Mesa-dev] [PATCH 61/75] st/nine: Switch {Set/Get/Free}PrivateData functions

From: Patrick Rudolph Switch {Set/Get/Free}PrivateData function to introduced IUnknown functions. Signed-off-by: Patrick Rudolph Reviewed-by: Axel Davy --- src/gallium/state_trackers/nine/cubetexture9.c | 6 +- src/gallium/state_trackers/nine/indexbuffer9.c | 6 +- src/gallium/state_tra

  1   2   >