On 10 October 2016 at 13:24, Dave Airlie wrote:
> This is a bit of a workaround to how llvm does spilling, and
> we should fix llvm, I'm just not good enough yet, and this will
> get us further with CTS tests for now.
>
> Details in patch 2.
I've implemented LLVM side for this to do it properly.
Patch changes function to use _mesa_lookup_shader_program_err both
in TransformFeedbackVaryings and GetTransformFeedbackVarying that
handles errors correctly for invalid values of shader program.
Fixes following dEQP test:
dEQP-GLES31.functional.debug.negative_coverage.get_error.shader.transfo
https://bugs.freedesktop.org/show_bug.cgi?id=98135
--- Comment #2 from Tapani Pälli ---
Found the 'common errors' section referred by comment #1 ... it's 'Shader
Objects' that has following clause (already specified in GL 3.0 spec!):
"Commands that accept shader or program object names will gene
https://bugs.freedesktop.org/show_bug.cgi?id=98135
--- Comment #1 from Tapani Pälli ---
OpenGL 3.0 spec says:
"The error INVALID VALUE is generated if program is not the name of a program
object."
However in 4.0 spec this statement has been removed (and error case is likely
described in some 'c
On Fri, Oct 07, 2016 at 09:41:12PM -0700, Jason Ekstrand wrote:
> Signed-off-by: Jason Ekstrand
Patches 13 and 14 make sense to me and I can't see anything amiss:
Reviewed-by: Topi Pohjolainen
> ---
> src/intel/vulkan/anv_blorp.c | 4 ++--
> src/intel/vulkan/anv_dump.c| 3 ++-
On Fri, Oct 07, 2016 at 09:41:10PM -0700, Jason Ekstrand wrote:
> When I initially brought up Vulkan blorp, I completely missed that this
> was already factored out. There's no good reason for us to hand-roll it.
>
> Signed-off-by: Jason Ekstrand
Reviewed-by: Topi Pohjolainen
> ---
> src/int
Reviewed-by: Iago Toral Quiroga
On Fri, 2016-10-07 at 17:12 -0700, Ian Romanick wrote:
> From: Ian Romanick
>
> This was found partially by inspection and partially by hitting a
> problem while working on nir_op_pack_int64_2x32_split. The code
> previously would 'continue' if (instr->src[i].s
On Sun, Oct 09, 2016 at 10:52:52PM -0700, Jason Ekstrand wrote:
>On Oct 9, 2016 10:48 PM, "Pohjolainen, Topi"
><[1]topi.pohjolai...@gmail.com> wrote:
>>
>> On Fri, Oct 07, 2016 at 09:41:08PM -0700, Jason Ekstrand wrote:
>> > Signed-off-by: Jason Ekstrand <[2]ja...@jlekstrand.net
On 10/08/2016 06:58 PM, Jason Ekstrand wrote:
FYI, we use ralloc for a lot more than just the glsl compiler so the
first few changes make me a bit nervous. There was someone working on
making our driver more I undefined-memory-friendly but I don't know what
happened to those patches.
There's
On Oct 9, 2016 10:48 PM, "Pohjolainen, Topi"
wrote:
>
> On Fri, Oct 07, 2016 at 09:41:08PM -0700, Jason Ekstrand wrote:
> > Signed-off-by: Jason Ekstrand
> > ---
> > src/intel/blorp/blorp.h | 10
> > src/intel/blorp/blorp_clear.c | 58
+++
>
On Fri, Oct 07, 2016 at 09:41:09PM -0700, Jason Ekstrand wrote:
> In Vulkan, we want to be able to use blorp to perform clears inside of a
> render pass. If blorp stomps the depth/stencil buffers packets then we'll
> have to re-emit them. This gets tricky when secondary command buffers get
> invo
On Fri, Oct 07, 2016 at 09:41:08PM -0700, Jason Ekstrand wrote:
> Signed-off-by: Jason Ekstrand
> ---
> src/intel/blorp/blorp.h | 10
> src/intel/blorp/blorp_clear.c | 58
> +++
> 2 files changed, 68 insertions(+)
>
> diff --git a/src/intel
https://bugs.freedesktop.org/show_bug.cgi?id=98135
Tapani Pälli changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |lem...@gmail.com
|org
On Fri, Oct 07, 2016 at 09:41:05PM -0700, Jason Ekstrand wrote:
> This should now set the pipeline up properly for doing depth and/or stencil
> clears by plumbing through depth/stencil test values.
If you like you could also say that color calculator state is now emitted
also for blorp operations
https://bugs.freedesktop.org/show_bug.cgi?id=98133
Tapani Pälli changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution|---
On Fri, Oct 07, 2016 at 09:40:59PM -0700, Jason Ekstrand wrote:
> We want to be able to start slow depth clears. This allows us to adjust
I think you are missing a word or two here, s/start/start using/? Otherwise
Reviewed-by: Topi Pohjolainen
> the depth we're clearing to.
>
> Signed-off-by:
The specification says that if the depth AND stencil formats
do not match, not or. This fixes bug #97921.
---
src/mesa/main/blit.c | 46 +++---
1 file changed, 19 insertions(+), 27 deletions(-)
diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c
index
On 10 October 2016 at 13:25, Dave Airlie wrote:
> From: Dave Airlie
>
> This is a bit of a hack due to how llvm currently handles
> spilling in it's shader ABI. Currently llvm amdgpu backend
> uses relocations to patch the shader with the address of
> the tmpring. The driver loads the shader and
On Sun, Oct 9, 2016 at 3:13 AM, Mauro Rossi wrote:
> Hi Jason,
>
> I'm sending a patch to add rules for Android,
> even if those headers are not yet used there
> they are inducing a minor building error on Android.
>
These XML includes shouldn't be used for anything in the Anrdoid build as
Aubin
From: Dave Airlie
This is a bit of a hack due to how llvm currently handles
spilling in it's shader ABI. Currently llvm amdgpu backend
uses relocations to patch the shader with the address of
the tmpring. The driver loads the shader and patches the
relocations.
However for vulkan this doesn't wo
From: Dave Airlie
This adds some comments and adds defines for the user sgprs,
so that we can move them around easier later and not have
to change/revalidate every one of these.
Signed-off-by: Dave Airlie
---
src/amd/common/ac_nir_to_llvm.c | 7 +--
src/amd/common/ac_nir_to_llvm.h | 17
This is a bit of a workaround to how llvm does spilling, and
we should fix llvm, I'm just not good enough yet, and this will
get us further with CTS tests for now.
Details in patch 2.
Dave.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https
Reviewed-by: Edward O'Callaghan
On 10/09/2016 10:48 PM, Samuel Pitoiset wrote:
> All ARB_enhanced_layouts piglit tests pass without any changes
> in our compiler.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +-
> 1 file changed, 1 insertion(+),
Acked-by: Edward O'Callaghan
On 10/09/2016 11:26 PM, Axel Davy wrote:
> Fixes regression introduced by
> ecd6fce2611e88ff8468a354cff8eda39f260a31
> and is more future proof than just clearing the next
> field.
>
> Other nine usages did already zero out the templates.
>
> Signed-off-by: Axel Dav
When offset != 0, the valid range was wrong because the second
argument of util_range_add() is end, not size.
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/nouveau/nvc0/nvc0_compute.c| 1 +
src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c | 1 +
src/gallium/drivers/nouveau
On 09.10.2016 21:19, Samuel Pitoiset wrote:
This fixes a crash while replaying a trace from F1 2015.
I think clear_texture should be handled in dd_draw.c with the draw and
other clear functions.
Nicolai
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/ddebug/dd_context.c | 11
2016-10-09 21:34 GMT+02:00 Ilia Mirkin :
> On Sun, Oct 9, 2016 at 3:28 PM, Karol Herbst wrote:
>> 2016-10-09 13:58 GMT+02:00 Samuel Pitoiset :
>>>
>>>
>>> On 10/08/2016 10:04 PM, Karol Herbst wrote:
looks great, a few comments below
>>>
>>>
>>> Thanks!
>>>
2016-10-08 21:55 GMT+
On Sun, Oct 9, 2016 at 3:28 PM, Karol Herbst wrote:
> 2016-10-09 13:58 GMT+02:00 Samuel Pitoiset :
>>
>>
>> On 10/08/2016 10:04 PM, Karol Herbst wrote:
>>>
>>> looks great, a few comments below
>>
>>
>> Thanks!
>>
>>>
>>> 2016-10-08 21:55 GMT+02:00 Samuel Pitoiset :
total instructions in
On 10/09/2016 09:28 PM, Karol Herbst wrote:
2016-10-09 13:58 GMT+02:00 Samuel Pitoiset :
On 10/08/2016 10:04 PM, Karol Herbst wrote:
looks great, a few comments below
Thanks!
2016-10-08 21:55 GMT+02:00 Samuel Pitoiset :
total instructions in shared programs :2286901 -> 2284473 (-0.
2016-10-09 13:58 GMT+02:00 Samuel Pitoiset :
>
>
> On 10/08/2016 10:04 PM, Karol Herbst wrote:
>>
>> looks great, a few comments below
>
>
> Thanks!
>
>>
>> 2016-10-08 21:55 GMT+02:00 Samuel Pitoiset :
>>>
>>> total instructions in shared programs :2286901 -> 2284473 (-0.11%)
>>> total gprs used in
This fixes a crash while replaying a trace from F1 2015.
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/ddebug/dd_context.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/gallium/drivers/ddebug/dd_context.c
b/src/gallium/drivers/ddebug/dd_context.c
index edcbf2c..5
https://bugs.freedesktop.org/show_bug.cgi?id=98172
shinji.suz...@gmail.com changed:
What|Removed |Added
Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
On Sun, Oct 9, 2016 at 7:53 AM, Samuel Pitoiset
wrote:
>
>
> On 10/09/2016 06:12 AM, Ilia Mirkin wrote:
>>
>> A function with multiple returns would have had multiple preret settings
>> at the top of the function. While this is unlikely to have caused issues
>> since we don't use funcitons in earn
> Comment # 1 on bug 98169 from Christoph Haag
>
> I also noticed that the cpufrequency graphs (cpufreq-cur-cpu0) always show 0
> in
> unigine heaven.
>
> They work correctly in glxgears, so perhaps it's caused by the same thing
> unigine heaven does.
I'll open a bugzilla account tomorrow (monday)
https://bugs.freedesktop.org/show_bug.cgi?id=98169
--- Comment #1 from Christoph Haag ---
I also noticed that the cpufrequency graphs (cpufreq-cur-cpu0) always show 0 in
unigine heaven.
They work correctly in glxgears, so perhaps it's caused by the same thing
unigine heaven does.
--
You are re
Fixes regression introduced by
ecd6fce2611e88ff8468a354cff8eda39f260a31
and is more future proof than just clearing the next
field.
Other nine usages did already zero out the templates.
Signed-off-by: Axel Davy
---
src/gallium/state_trackers/nine/device9.c| 6 ++
src/gallium/state_track
https://bugs.freedesktop.org/show_bug.cgi?id=98169
Bug ID: 98169
Summary: lm_sensors hud option crashes unigine heaven
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: normal
On 10/08/2016 10:09 PM, Ilia Mirkin wrote:
On Sat, Oct 8, 2016 at 3:55 PM, Samuel Pitoiset
wrote:
total instructions in shared programs :2286901 -> 2284473 (-0.11%)
total gprs used in shared programs:335256 -> 335273 (0.01%)
total local used in shared programs :31968 -> 31968 (0.00%)
On 10/08/2016 10:04 PM, Karol Herbst wrote:
looks great, a few comments below
Thanks!
2016-10-08 21:55 GMT+02:00 Samuel Pitoiset :
total instructions in shared programs :2286901 -> 2284473 (-0.11%)
total gprs used in shared programs:335256 -> 335273 (0.01%)
total local used in shared
On 10/09/2016 06:12 AM, Ilia Mirkin wrote:
A function with multiple returns would have had multiple preret settings
at the top of the function. While this is unlikely to have caused issues
since we don't use funcitons in earnest, it could have in some cases
s/funcitons/functions/ :)
This loo
This exposes OpenGL 4.5 on Fermi and Kepler GPUs. Maxwell still
only exposes OpenGL 4.1 because I need to finish my instructions
scheduler calculator.
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
All ARB_enhanced_layouts piglit tests pass without any changes
in our compiler.
Signed-off-by: Samuel Pitoiset
---
src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
b/src/gallium/driv
Hi Jason,
I'm sending a patch to add rules for Android,
even if those headers are not yet used there
they are inducing a minor building error on Android.
Cheers and congratulations for your nice presentation on vulkan at XDC2016
Mauro
>From 52c9b2d9a7d7fc962d7a8c30fc412387a74bf554 Mon Sep 17 00:
we might want to add more folding passes here, so make it a bit more generic
v2: leave the comment and reword commit message
Signed-off-by: Karol Herbst
---
.../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 120 +++--
1 file changed, 62 insertions(+), 58 deletions(-)
diff --
improves the post ra mad folding pass:
total instructions in shared programs : 2811662 -> 2808429 (-0.11%)
total gprs used in shared programs: 379273 -> 379236 (-0.01%)
total local used in shared programs : 9505 -> 9505 (0.00%)
total bytes used in shared programs : 25773432 -> 25743616 (-0.
changes for GpuTest /test=pixmark_piano /benchmark /no_scorebox /msaa=0
/benchmark_duration_ms=6 /width=1024 /height=640:
score: 1026 -> 1044
changes for shader-db:
total instructions in shared programs : 2818606 -> 2811662 (-0.25%)
total gprs used in shared programs: 379273 -> 379273 (0
v2: renamed commit
reordered modifiers
add assert(dst == src2)
Signed-off-by: Karol Herbst
---
.../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 35 --
1 file changed, 26 insertions(+), 9 deletions(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_g
v2: renamed commit
reordered modifiers
add assert(dst == src2)
Signed-off-by: Karol Herbst
---
.../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 50 ++
1 file changed, 33 insertions(+), 17 deletions(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_
Signed-off-by: Karol Herbst
---
src/gallium/drivers/nouveau/codegen/nv50_ir.h| 2 +-
.../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 20 +++-
2 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.h
b/src/galliu
This series reworks the structure of the pass to make it easier to add
more optimisations to it.
Still have to run a full piglit on my gk106 with this, but g80, gk110 and gm107
should be tested as well, but I can't.
v2: swaped the last two commits
changes for shader-db:
total instructions in sha
2016-10-08 18:39 GMT+02:00 Samuel Pitoiset :
>
>
> On 10/08/2016 05:43 PM, Karol Herbst wrote:
>>
>> Signed-off-by: Karol Herbst
>> ---
>> src/gallium/drivers/nouveau/codegen/nv50_ir.h| 2 +-
>> .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 20
>> +++-
>> 2 files
2016-10-08 18:12 GMT+02:00 Samuel Pitoiset :
> Usually we prefix with gm107/ir, gk110/ir, etc...
>
> More comments below.
>
> On 10/08/2016 05:43 PM, Karol Herbst wrote:
>>
>> Signed-off-by: Karol Herbst
>> ---
>> .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 32
>> --
>
52 matches
Mail list logo
