[Mesa-dev] [Bug 98223] dEQP GLES3.1 program_interface_query failures w/ error "could not find target resource"

https://bugs.freedesktop.org/show_bug.cgi?id=98223 Kenneth Graunke changed: What|Removed |Added Blocks||94448 ---

Re: [Mesa-dev] [PATCH 26/26] i965: Enable fast clears for multi-lod

On Wed, Oct 12, 2016 at 10:14:44PM -0700, Ben Widawsky wrote: > On 16-10-12 14:21:08, Matt Turner wrote: > > On Tue, Oct 11, 2016 at 12:26 PM, Topi Pohjolainen > > wrote: > > > From: Ben Widawsky > > > > > > Signed-off-by: Ben Widawsky

[Mesa-dev] [Bug 98223] dEQP GLES3.1 program_interface_query failures w/ error "could not find target resource"

https://bugs.freedesktop.org/show_bug.cgi?id=98223 Bug ID: 98223 Summary: dEQP GLES3.1 program_interface_query failures w/ error "could not find target resource" Product: Mesa Version: git Hardware: All OS:

Re: [Mesa-dev] [PATCH 26/26] i965: Enable fast clears for multi-lod

On 16-10-12 14:21:08, Matt Turner wrote: On Tue, Oct 11, 2016 at 12:26 PM, Topi Pohjolainen wrote: From: Ben Widawsky Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +++--- 1 file

[Mesa-dev] [Bug 98222] [radv] LLVM ERROR: Cannot select: intrinsic %llvm.amdgcn.image.store

https://bugs.freedesktop.org/show_bug.cgi?id=98222 Mathieu Belanger changed: What|Removed |Added Summary|[ravd] LLVM ERROR: Cannot |[radv] LLVM ERROR:

[Mesa-dev] [Bug 98222] [ravd] LLVM ERROR: Cannot select: intrinsic %llvm.amdgcn.image.store

https://bugs.freedesktop.org/show_bug.cgi?id=98222 Mathieu Belanger changed: What|Removed |Added Summary|LLVM ERROR: Cannot select: |[ravd] LLVM ERROR:

[Mesa-dev] [Bug 98222] LLVM ERROR: Cannot select: intrinsic %llvm.amdgcn.image.store

https://bugs.freedesktop.org/show_bug.cgi?id=98222 Bug ID: 98222 Summary: LLVM ERROR: Cannot select: intrinsic %llvm.amdgcn.image.store Product: Mesa Version: git Hardware: Other OS: All Status:

Re: [Mesa-dev] [PATCH 1/2] st/mesa: Take local references for sync object fences

On 12/10/16 08:52 PM, Nicolai Hähnle wrote: > On 12.10.2016 11:31, Michel Dänzer wrote: >> >> diff --git a/src/mesa/state_tracker/st_cb_syncobj.c >> b/src/mesa/state_tracker/st_cb_syncobj.c >> index 123925a..de01880 100644 >> --- a/src/mesa/state_tracker/st_cb_syncobj.c >> +++

Re: [Mesa-dev] [PATCH 4/5] radv: move AMDGPU_LIBS later in the link chain

Reviewed-by: Edward O'Callaghan On 10/13/2016 05:05 AM, Emil Velikov wrote: > From: Emil Velikov > > At the moment (albeit unlikely) one could get link-time issues, since > libdrm_amdgpu.so is before it's users in the link chain. > >

Re: [Mesa-dev] [PATCH 4/5] radv: move AMDGPU_LIBS later in the link chain

> > At the moment (albeit unlikely) one could get link-time issues, since > libdrm_amdgpu.so is before it's users in the link chain. > > Signed-off-by: Emil Velikov Reviewed-by: Dave Airlie > --- > As a nice bonus the diff vs the anv Makefile is

Re: [Mesa-dev] [PATCH 3/5] radv: correct variable name VISIBILITY_{, C}FLAGS

Oops, Reviewed-by: Dave Airlie On 13 October 2016 at 04:05, Emil Velikov wrote: > From: Emil Velikov > > The letter C was missing, thus in turn all the internal symbols were > exported. > > As a result we hide ~150

Re: [Mesa-dev] [PATCH v3 25/25] configure.ac: Add required LLVM versions to the top

On 13/10/16 03:37 AM, Tobias Droste wrote: > Am Mittwoch, 12. Oktober 2016, 11:53:50 CEST schrieb Emil Velikov: >>> >>> +LLVM_VERSION_REQUIRED_OPENCL=3.6.0 >>> +LLVM_VERSION_REQUIRED_R600=3.6.0 >>> +LLVM_VERSION_REQUIRED_RADEONSI=3.6.0 >> >> There's a small related gotcha: as-is at build time we

Re: [Mesa-dev] [PATCH 1/2] radv/wsi: fix app that acquire multiple images up front

Both patches are, Acked-by: Edward O'Callaghan On 10/13/2016 01:44 PM, Dave Airlie wrote: > From: Dave Airlie > > dota2 does multiple acquires followed by multiple queues, > this bug manifested itself as a hang in the xshmfence code > randomly

[Mesa-dev] [PATCH 1/2] radv/wsi: fix app that acquire multiple images up front

From: Dave Airlie dota2 does multiple acquires followed by multiple queues, this bug manifested itself as a hang in the xshmfence code randomly when dota2 was doing it's menus. It also occured when running dota2 under phoronix-test-suite. The fix is once the image is

[Mesa-dev] [PATCH 2/2] anv/wsi: fix apps that acquire multiple images up front

From: Dave Airlie This fix was found in the radv codebase when running dota2, no idea if anyone has reported it on anv, but the same problem occurs. Once an image is acquired we need to mark it busy. Signed-off-by: Dave Airlie ---

Re: [Mesa-dev] [PATCH 1/2] radeonsi: disable ReZ

Why not just squash these two patches together? Either way this series is, Acked-by: Edward O'Callaghan On 10/13/2016 10:22 AM, Andy Furniss wrote: > Marek Olšák wrote: >> From: Marek Olšák >> >> This is a serious performance fix. Discovered by

Re: [Mesa-dev] [PATCH] draw: initialize shader inputs

Am 12.10.2016 um 18:12 schrieb Marek Olšák: > On Wed, Oct 12, 2016 at 12:04 AM, wrote: >> From: Roland Scheidegger >> >> This should make the code more robust if a shader tries to use inputs which >> aren't defined by the vertex element layout (which

Re: [Mesa-dev] [PATCH] gallium: add PIPE_RESOURCE_FLAG_TEXTURING_MORE_LIKELY

Am 12.10.2016 um 15:29 schrieb Marek Olšák: > From: Marek Olšák > > For performance tuning in drivers. It filters out window system > framebuffers and OpenGL renderbuffers. > > radeonsi will use this to guess whether a depth buffer will be read > by a shader. There is no

Re: [Mesa-dev] [PATCH 1/2] radeonsi: disable ReZ

Marek Olšák wrote: From: Marek Olšák This is a serious performance fix. Discovered by luck. Hmm, maybe I should bump my bugs more aggressively :-) https://bugs.freedesktop.org/show_bug.cgi?id=94354 Cc: 12.0 ---

[Mesa-dev] [PATCH 4/5] st/va: Baseline profile is not supported

Constrained baseline profile is supported, so use that instead. This matches what the encoder already does (constraint_set1_flag is always set in the output bitstream). --- src/gallium/state_trackers/va/va_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/5] st/va: Save surface chroma format in config

Both YUV420 and RGB32 configurations are supported, so we need to be able to distinguish which is being used. --- src/gallium/state_trackers/va/config.c | 20 +++- src/gallium/state_trackers/va/va_private.h | 1 + 2 files changed, 20 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/5] st/va: Return more useful config attributes

The encoder attributes are needed for a user of the encoder to be able to configure it sensibly without internal knowledge. --- src/gallium/state_trackers/va/config.c | 47 +++--- 1 file changed, 38 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 5/5] st/va: Fix H.264 PicOrderCnt value

TopFieldPicOrderCnt is exactly the PicOrderCnt value for a frame - see H.264 section 8.2.1. --- src/gallium/state_trackers/va/picture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index

[Mesa-dev] [PATCH 3/5] st/va: Return surface formats depending on config chroma format

This makes the supported format actually match the configuration, and allows the user to observe that NV12 is supported for video processing where previously they couldn't (though it did always work if they blindly tried to use it anyway). --- src/gallium/state_trackers/va/surface.c | 12

[Mesa-dev] [PATCH 1/6] intel: genxml: add SO_WRITE_OFFSET register

One of the register we happen to program but don't have a description for yet. Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 5 + src/intel/genxml/gen7.xml | 5 + src/intel/genxml/gen75.xml | 5 + src/intel/genxml/gen8.xml | 5

[Mesa-dev] [PATCH 2/6] intel: aubinator: use different colors to signal batch start/end

This makes the stream of commands a bit easier to read. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c

[Mesa-dev] [PATCH 5/6] anv: replace , with ; in anv_batch_emit()

Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/genX_cmd_buffer.c| 20 ++-- src/intel/vulkan/genX_pipeline_util.h | 4 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c

[Mesa-dev] [PATCH 0/6] Anv/Aubinator: unrelated commits

Hi, Here are some commits that do not relate to a particular issue, just cleanups accumulated over the past week. Feel free to nack them if this isn't useful. Thanks, Lionel Landwerlin (6): intel: genxml: add SO_WRITE_OFFSET register intel: aubinator: use different colors to signal batch

[Mesa-dev] [PATCH 4/6] anv: print finishme messages only once

Some of the new Hiz finishme messages generate a lot of noise, maybe displaying the warning once is a better approach. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_private.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 3/6] intel: aubinator: add support for memory register load decoding

Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 0313d5a..b6820f4 100644 ---

[Mesa-dev] [PATCH 6/6] anv: add dispatch macro to find right function for given generation

Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_cmd_buffer.c | 33 ++--- src/intel/vulkan/anv_device.c | 19 +-- src/intel/vulkan/anv_pipeline.c | 30 --

[Mesa-dev] [Bug 96770] include/GL/mesa_glinterop.h:62: error: redefinition of typedef ‘GLXContext’

https://bugs.freedesktop.org/show_bug.cgi?id=96770 --- Comment #5 from Mauro Rossi --- Hi, I need to report that Android build has been broken by Vinson's commit mentioned at Comment #3. Mauro In file included from

Re: [Mesa-dev] [PATCH 26/26] i965: Enable fast clears for multi-lod

On Tue, Oct 11, 2016 at 12:26 PM, Topi Pohjolainen wrote: > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +++--- > 1 file changed, 3 insertions(+), 3

[Mesa-dev] [PATCH 2/2] radeonsi: adjust and clean up Z_ORDER and EXEC_ON_x settings

From: Marek Olšák The table was copied from the Vulkan driver. The comment lines are as long as the table for cosmetic reasons. --- src/gallium/drivers/radeonsi/si_shader.h| 1 - src/gallium/drivers/radeonsi/si_state_shaders.c | 53 +++-- 2

Re: [Mesa-dev] [PATCH] mesa_glinterop: allow building without X and related headers

On Wed, Oct 12, 2016 at 10:49 AM, Emil Velikov wrote: > This commit effectively reverts c10dcb2ce837922c6ee4e191e6d6202098a5ee10 > and fixes the typedef redefinition which inspired it. > > In order to prevent requiring X packages at build time earlier commit > forward

[Mesa-dev] [PATCH 1/2] radeonsi: disable ReZ

From: Marek Olšák This is a serious performance fix. Discovered by luck. Cc: 12.0 --- src/gallium/drivers/radeonsi/si_state_shaders.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[Mesa-dev] [PATCH mesa] swr: [rasterizer common] fix assert index

Fixes: b3bd8bb611bb465d2e5e ("swr: [rasterizer core] add support for "RAW" surface format") CovID: 1373647 Signed-off-by: Eric Engestrom --- src/gallium/drivers/swr/rasterizer/common/formats.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 3/4] st/glsl_to_tgsi: remove unnecessary ir_instruction argument from get_opcode

For 1-3: Reviewed-by: Marek Olšák Marek On Wed, Oct 12, 2016 at 7:50 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3

Re: [Mesa-dev] General safety of building with O3 instead of O2

On Wed, Oct 12, 2016 at 12:40 PM, Chuck Atkins wrote: > I'm using Mesa in a "superbuild" scenario where CFLAGS and CXXFLAGS are set > by a top level project that builds many subprojects. They typical settings > for release builds with this is adding O3 to CFLAGS and

Re: [Mesa-dev] [PATCH] radeonsi: fix the coordinate overloading of llvm.amdgcn.image.atomic.cmpswap.*

Reviewed-by: Marek Olšák Marek On Wed, Oct 12, 2016 at 7:42 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes GL45-CTS.shader_image_load_store.basic-allTargets-atomic* > --- > src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH 2/5] amd/addrlib: hide private symbols via VISIBILITY_CXXFLAGS

Reviewed-by: Marek Olšák Marek On Wed, Oct 12, 2016 at 8:05 PM, Emil Velikov wrote: > From: Emil Velikov > > Private/internal symbols should never not be exported. Using the > CXXFLAGS cuts ~300 exported symbols and

Re: [Mesa-dev] [PATCH] st/mesa: only flip stipple pattern for winsys fbo's

On Wed, Oct 12, 2016 at 8:52 PM, Ilia Mirkin wrote: > On Wed, Oct 12, 2016 at 2:46 PM, Brian Paul wrote: >> On 10/12/2016 12:06 PM, Ilia Mirkin wrote: >>> >>> Gallium is completely oblivious to whether the fbo is flipped or not. >>> Only flip the stipple

Re: [Mesa-dev] [PATCH 0/4] st/mesa: fix various corner cases and related cleanups

On 13 October 2016 at 03:50, Nicolai Hähnle wrote: > Hi all, > > this is admittedly a pretty random series, but that's what tends to happen > when you go through test suite failures. Please review! All look good to me, though it would be good to make sure llvmpipe doesn't

Re: [Mesa-dev] [PATCH] radeonsi: implement TC-compatible HTILE

Hi Marek This and the patch before are Tested-by: Edmondo Tommasina Tested with: * The Witcher 2 * Two Worlds * The Talos Principle No regressions. Performance seems similar. I'm quite CPU limited (Phenom II X3 720) so I don't expect a measurable performance

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

On Mon, Oct 10, 2016 at 9:19 PM, Gustaw Smolarczyk wrote: > 2016-10-10 22:04 GMT+02:00 Bas Nieuwenhuizen : >> Hi Gustaw, >> >> The patch is >> reviewed-by: Bas Nieuwenhuizen > > Thanks, please push it since I don't have

Re: [Mesa-dev] [PATCH] radeonsi: fix the coordinate overloading of llvm.amdgcn.image.atomic.cmpswap.*

On 13 October 2016 at 03:42, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes GL45-CTS.shader_image_load_store.basic-allTargets-atomic* Reviewed-by: Dave Airlie > --- > src/gallium/drivers/radeonsi/si_shader.c | 9

[Mesa-dev] General safety of building with O3 instead of O2

I'm using Mesa in a "superbuild" scenario where CFLAGS and CXXFLAGS are set by a top level project that builds many subprojects. They typical settings for release builds with this is adding O3 to CFLAGS and CXXFLAGS, which in turn cause Mesa to build with O3. I haven't noticed any runtime issues

Re: [Mesa-dev] [PATCH 2/5] amd/addrlib: hide private symbols via VISIBILITY_CXXFLAGS

On 12 October 2016 at 20:28, Bas Nieuwenhuizen wrote: > On Wed, Oct 12, 2016 at 7:05 PM, Emil Velikov > wrote: >> From: Emil Velikov >> >> Private/internal symbols should never not be exported. Using the >>

Re: [Mesa-dev] [PATCH] mesa_glinterop: allow building without X and related headers

On 12 October 2016 at 19:15, Chih-Wei Huang wrote: > 2016-10-13 1:49 GMT+08:00 Emil Velikov : >> This commit effectively reverts c10dcb2ce837922c6ee4e191e6d6202098a5ee10 >> and fixes the typedef redefinition which inspired it. >> >> In order to

Re: [Mesa-dev] [PATCH v3 04/25] configure.ac: Move oCL checks out of LLVM version check

Am Mittwoch, 12. Oktober 2016, 20:28:03 CEST schrieb Emil Velikov: > On 12 October 2016 at 19:58, Tobias Droste wrote: > > Am Mittwoch, 12. Oktober 2016, 19:51:21 CEST schrieb Emil Velikov: > >> On 12 October 2016 at 19:04, Tobias Droste wrote: > >> > Am Mittwoch,

Re: [Mesa-dev] [PATCH 2/5] amd/addrlib: hide private symbols via VISIBILITY_CXXFLAGS

On Wed, Oct 12, 2016 at 7:05 PM, Emil Velikov wrote: > From: Emil Velikov > > Private/internal symbols should never not be exported. Using the > CXXFLAGS cuts ~300 exported symbols and ~23K from libvulkan_radeon.so. Double negative? I think

Re: [Mesa-dev] [PATCH v3 04/25] configure.ac: Move oCL checks out of LLVM version check

On 12 October 2016 at 19:58, Tobias Droste wrote: > Am Mittwoch, 12. Oktober 2016, 19:51:21 CEST schrieb Emil Velikov: >> On 12 October 2016 at 19:04, Tobias Droste wrote: >> > Am Mittwoch, 12. Oktober 2016, 09:56:39 CEST schrieb Emil Velikov: >> >> > fi >> >> >

Re: [Mesa-dev] [PATCH v3 02/25] configure.ac: Add helper function for targets/components

Am Mittwoch, 12. Oktober 2016, 20:21:29 CEST schrieb Emil Velikov: > >> > >> If things error out here, that means that one should finish the other > >> refactoring before using these helpers ? > >> If that's getting too hairy, just add keep the function a simple > >> wrapper around

Re: [Mesa-dev] [PATCH v3 02/25] configure.ac: Add helper function for targets/components

On 12 October 2016 at 19:44, Tobias Droste wrote: > Am Mittwoch, 12. Oktober 2016, 19:38:56 CEST schrieb Emil Velikov: >> On 12 October 2016 at 19:01, Tobias Droste wrote: >> > Am Mittwoch, 12. Oktober 2016, 09:52:51 CEST schrieb Emil Velikov: >> >> On 12 October

Re: [Mesa-dev] [PATCH v3 25/25] configure.ac: Add required LLVM versions to the top

On 12 October 2016 at 19:37, Tobias Droste wrote: > Am Mittwoch, 12. Oktober 2016, 11:53:50 CEST schrieb Emil Velikov: >> > >> > +dnl LLVM versions >> > +LLVM_VERSION_REQUIRED_GALLIUM=3.3.0 >> > +LLVM_VERSION_REQUIRED_LLVMPIPE=3.6.0 >> >> Not exactly sure why/how llvmpipe got 3.6

Re: [Mesa-dev] [PATCH v3 08/25] configure.ac: Move LLVM version check to the top

Am Mittwoch, 12. Oktober 2016, 20:02:24 CEST schrieb Emil Velikov: > >> With the above > >> Reviewed-by: Emil Velikov > >> > >> > +if test -z "${LLVM_CONFIG}"; then > >> > +if test -n "$llvm_prefix"; then > >> > +AC_PATH_TOOL([LLVM_CONFIG],

Re: [Mesa-dev] [PATCH v3 08/25] configure.ac: Move LLVM version check to the top

On 12 October 2016 at 19:11, Tobias Droste wrote: > Am Mittwoch, 12. Oktober 2016, 10:11:50 CEST schrieb Emil Velikov: >> On 12 October 2016 at 00:02, Tobias Droste wrote: >> > A function with the LLVM version checked is moved to the top. >> > The function is

Re: [Mesa-dev] [PATCH v3 04/25] configure.ac: Move oCL checks out of LLVM version check

Am Mittwoch, 12. Oktober 2016, 19:51:21 CEST schrieb Emil Velikov: > On 12 October 2016 at 19:04, Tobias Droste wrote: > > Am Mittwoch, 12. Oktober 2016, 09:56:39 CEST schrieb Emil Velikov: > >> > fi > >> > > >> > +if test "x$enable_opencl" = xyes; then > >> > +

Re: [Mesa-dev] [PATCH] st/mesa: only flip stipple pattern for winsys fbo's

On Wed, Oct 12, 2016 at 2:46 PM, Brian Paul wrote: > On 10/12/2016 12:06 PM, Ilia Mirkin wrote: >> >> Gallium is completely oblivious to whether the fbo is flipped or not. >> Only flip the stipple pattern when the fbo is flipped as well. Otherwise >> the driver has no idea when

Re: [Mesa-dev] [PATCH v3 04/25] configure.ac: Move oCL checks out of LLVM version check

On 12 October 2016 at 19:04, Tobias Droste wrote: > Am Mittwoch, 12. Oktober 2016, 09:56:39 CEST schrieb Emil Velikov: >> > fi >> > >> > +if test "x$enable_opencl" = xyes; then >> > +llvm_check_version_for "3" "6" "0" "opencl" >> > + >> > +

Re: [Mesa-dev] [PATCH v3 12/25] configure.ac: Move gallium LLVM checks

Am Mittwoch, 12. Oktober 2016, 19:39:47 CEST schrieb Jose Fonseca: > >> > >> Right now --enable-gallium-llvm will be set to no if it is "auto" on non > >> x86. > >> > >> gallivm/llvm use the x86 target > > > > I haven't look too closely at the llvm code but there's nothing in > > scons/automake

Re: [Mesa-dev] [PATCH] st/mesa: only flip stipple pattern for winsys fbo's

On 10/12/2016 12:06 PM, Ilia Mirkin wrote: Gallium is completely oblivious to whether the fbo is flipped or not. Only flip the stipple pattern when the fbo is flipped as well. Otherwise the driver has no idea when to unflip the pattern. Fixes bin/gl-2.1-polygon-stipple-fs -fbo on nv50 and nvc0.

Re: [Mesa-dev] [PATCH v3 02/25] configure.ac: Add helper function for targets/components

Am Mittwoch, 12. Oktober 2016, 19:38:56 CEST schrieb Emil Velikov: > On 12 October 2016 at 19:01, Tobias Droste wrote: > > Am Mittwoch, 12. Oktober 2016, 09:52:51 CEST schrieb Emil Velikov: > >> On 12 October 2016 at 00:02, Tobias Droste wrote: > >> > Add

[Mesa-dev] [PATCH v2] nvc0/ir: be more careful about preserving modifiers in SHLADD creation

src2 was being given the wrong modifier, and we were not properly managing the modifier on the SHL source either. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-)

Re: [Mesa-dev] [PATCH v3 12/25] configure.ac: Move gallium LLVM checks

On 12/10/16 19:30, Emil Velikov wrote: On 12 October 2016 at 19:14, Tobias Droste wrote: Am Mittwoch, 12. Oktober 2016, 10:42:19 CEST schrieb Emil Velikov: On 12 October 2016 at 00:02, Tobias Droste wrote: gallium_require_llvm() { -if test

Re: [Mesa-dev] [PATCH v3 12/25] configure.ac: Move gallium LLVM checks

Am Mittwoch, 12. Oktober 2016, 19:30:51 CEST schrieb Emil Velikov: > >> > >> The function it quite "ugly" as-is and this patch changes things in a fun > >> way. > >> > >> Namely: before you'll get the minimum required version check > >> regardless of host_cpu for everyone, while now you get the

Re: [Mesa-dev] [PATCH v3 02/25] configure.ac: Add helper function for targets/components

On 12 October 2016 at 19:01, Tobias Droste wrote: > Am Mittwoch, 12. Oktober 2016, 09:52:51 CEST schrieb Emil Velikov: >> On 12 October 2016 at 00:02, Tobias Droste wrote: >> > Add functions to add and check targets/components. >> > Not used in this patch. >> > >>

Re: [Mesa-dev] [PATCH v3 25/25] configure.ac: Add required LLVM versions to the top

Am Mittwoch, 12. Oktober 2016, 11:53:50 CEST schrieb Emil Velikov: > > > > +dnl LLVM versions > > +LLVM_VERSION_REQUIRED_GALLIUM=3.3.0 > > +LLVM_VERSION_REQUIRED_LLVMPIPE=3.6.0 > > Not exactly sure why/how llvmpipe got 3.6 since the driver reuses the > "gallium" one. Yes you're right. I'm going

Re: [Mesa-dev] [PATCH v3 12/25] configure.ac: Move gallium LLVM checks

On 12 October 2016 at 19:14, Tobias Droste wrote: > Am Mittwoch, 12. Oktober 2016, 10:42:19 CEST schrieb Emil Velikov: >> On 12 October 2016 at 00:02, Tobias Droste wrote: >> > >> > gallium_require_llvm() { >> > >> > -if test "x$MESA_LLVM" = x0; then >> > -

Re: [Mesa-dev] [PATCH v3 24/25] configure.ac: Only add default LLVM components if needed

Am Mittwoch, 12. Oktober 2016, 12:03:38 CEST schrieb Emil Velikov: > > Does this mean that the "default" components are required only by the > > gallivm module ? Please rename the function to reflect that. > > > > Don't recall if swr driver is/was using any of it, but the nv30 path > > of nouveau

Re: [Mesa-dev] [PATCH v3 24/25] configure.ac: Only add default LLVM components if needed

Am Mittwoch, 12. Oktober 2016, 10:57:14 CEST schrieb Emil Velikov: > On 12 October 2016 at 00:02, Tobias Droste wrote: > > Each driver has to expllicitly call llvm_add_default_components to > > add the shared components. > > This way we can fail the build if a component is not

Re: [Mesa-dev] [PATCH 1/4] st/glsl_to_tgsi: simplify translate_tex_offset

On 12.10.2016 20:12, Ilia Mirkin wrote: Patches 1-3 are Reviewed-by: Ilia Mirkin Thanks. Not comfortable enough with the vertex arrays code to review the last one. I remember Dave had semi-good reasons for the if (!array) stuff though. As far as I understood the

Re: [Mesa-dev] [PATCH] mesa_glinterop: allow building without X and related headers

2016-10-13 1:49 GMT+08:00 Emil Velikov : > This commit effectively reverts c10dcb2ce837922c6ee4e191e6d6202098a5ee10 > and fixes the typedef redefinition which inspired it. > > In order to prevent requiring X packages at build time earlier commit > forward declared the

[Mesa-dev] [PATCH 5/5] automake: add radv to the `make distcheck' hooks

From: Emil Velikov Will allow us to catch issues (as fixed with previous patches) rather than release a broken tarball. Signed-off-by: Emil Velikov --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/5] intel: automake: replace direct basename $@ invokation with $(@F)

From: Emil Velikov Use the shorthand make variable(s) as elsewhere in the build. Signed-off-by: Emil Velikov --- src/intel/Makefile.genxml.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 4/5] radv: move AMDGPU_LIBS later in the link chain

From: Emil Velikov At the moment (albeit unlikely) one could get link-time issues, since libdrm_amdgpu.so is before it's users in the link chain. Signed-off-by: Emil Velikov --- As a nice bonus the diff vs the anv Makefile is quite small

[Mesa-dev] [PATCH 2/5] amd/addrlib: hide private symbols via VISIBILITY_CXXFLAGS

From: Emil Velikov Private/internal symbols should never not be exported. Using the CXXFLAGS cuts ~300 exported symbols and ~23K from libvulkan_radeon.so. Signed-off-by: Emil Velikov --- src/amd/Makefile.addrlib.am | 3 +++ 1 file

[Mesa-dev] [PATCH 3/5] radv: correct variable name VISIBILITY_{, C}FLAGS

From: Emil Velikov The letter C was missing, thus in turn all the internal symbols were exported. As a result we hide ~150 symbols and cut ~36K from libvulkan_radeon.so. Signed-off-by: Emil Velikov --- My current testing involves static

Re: [Mesa-dev] [PATCH v3 12/25] configure.ac: Move gallium LLVM checks

Am Mittwoch, 12. Oktober 2016, 10:42:19 CEST schrieb Emil Velikov: > On 12 October 2016 at 00:02, Tobias Droste wrote: > > > > gallium_require_llvm() { > > > > -if test "x$MESA_LLVM" = x0; then > > -case "$host" in *gnux32) return;; esac > > -case

Re: [Mesa-dev] [PATCH 1/4] st/glsl_to_tgsi: simplify translate_tex_offset

Patches 1-3 are Reviewed-by: Ilia Mirkin Not comfortable enough with the vertex arrays code to review the last one. I remember Dave had semi-good reasons for the if (!array) stuff though. On Wed, Oct 12, 2016 at 1:50 PM, Nicolai Hähnle wrote: > From:

Re: [Mesa-dev] [PATCH v3 08/25] configure.ac: Move LLVM version check to the top

Am Mittwoch, 12. Oktober 2016, 10:11:50 CEST schrieb Emil Velikov: > On 12 October 2016 at 00:02, Tobias Droste wrote: > > A function with the LLVM version checked is moved to the top. > > The function is called where the old code was. > > Replace the second line with "... in

Re: [Mesa-dev] [PATCH v3 07/25] configure.ac: Move gallium checks out of LLVM version check

Am Mittwoch, 12. Oktober 2016, 10:01:01 CEST schrieb Emil Velikov: > > > > +gallium_llvm_check() { > > +LLVM_REQUIRED_VERSION_MAJOR="3" > > +LLVM_REQUIRED_VERSION_MINOR="3" > > +if test "$LLVM_VERSION_INT" -lt > > "${LLVM_REQUIRED_VERSION_MAJOR}0${LLVM_REQUIRED_VERSION_MINOR}"; then +

[Mesa-dev] [PATCH] st/mesa: only flip stipple pattern for winsys fbo's

Gallium is completely oblivious to whether the fbo is flipped or not. Only flip the stipple pattern when the fbo is flipped as well. Otherwise the driver has no idea when to unflip the pattern. Fixes bin/gl-2.1-polygon-stipple-fs -fbo on nv50 and nvc0. Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH v3 04/25] configure.ac: Move oCL checks out of LLVM version check

Am Mittwoch, 12. Oktober 2016, 09:56:39 CEST schrieb Emil Velikov: > > fi > > > > +if test "x$enable_opencl" = xyes; then > > +llvm_check_version_for "3" "6" "0" "opencl" > > + > > +LLVM_COMPONENTS="${LLVM_COMPONENTS} all-targets ipo linker > > instrumentation" +

Re: [Mesa-dev] [PATCH v3 02/25] configure.ac: Add helper function for targets/components

Am Mittwoch, 12. Oktober 2016, 09:52:51 CEST schrieb Emil Velikov: > On 12 October 2016 at 00:02, Tobias Droste wrote: > > Add functions to add and check targets/components. > > Not used in this patch. > > > > The error message in llvm_add_component is disabled until it doesn't

Re: [Mesa-dev] [PATCH 05/16] loader: reimplement loader_get_user_preferred_fd via libdrm

On 12/10/2016 19:15, Emil Velikov wrote: On 11 October 2016 at 19:54, Axel Davy wrote: On 11/10/2016 20:31, Emil Velikov wrote: - udev = udev_new(); - if (!udev) - goto prime_clean; + if (drmGetDevice(default_fd, ) != 0) + goto err; -

[Mesa-dev] [PATCH] mesa_glinterop: allow building without X and related headers

This commit effectively reverts c10dcb2ce837922c6ee4e191e6d6202098a5ee10 and fixes the typedef redefinition which inspired it. In order to prevent requiring X packages at build time earlier commit forward declared the required X/GLX typedefs. Since that approach introduced typedef redefinition (a

Re: [Mesa-dev] [PATCH] Revert "mesa_glinterop: remove inclusion of GLX header"

On 12 October 2016 at 18:47, Chih-Wei Huang wrote: > 2016-10-04 7:03 GMT+08:00 Vinson Lee : >> This reverts commit 8472045b16b3e4621553fe451a20a9ba9f0d44b6. >> >> Conflicts: >> >> include/GL/mesa_glinterop.h >> >> This patch fixes this build

[Mesa-dev] [PATCH 4/4] st/mesa: fix vertex elements setup for doubles

From: Nicolai Hähnle Whether one or two slots are taken up by one API array depends on the vertex shader, not on how the array is configured. When an array is set up with fewer components than the shader expects, the high components are undefined. Fixes

[Mesa-dev] [PATCH 1/4] st/glsl_to_tgsi: simplify translate_tex_offset

From: Nicolai Hähnle This fixes a bug with offsets from uniforms which seems to have only been noticed as a crash in piglit's arb_gpu_shader5/compiler/builtin-functions/fs-gatherOffset-uniform-offset.frag on radeonsi. Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 2/4] st/glsl_to_tgsi: fix textureGatherOffset with indirectly loaded offsets

From: Nicolai Hähnle Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 0/4] st/mesa: fix various corner cases and related cleanups

Hi all, this is admittedly a pretty random series, but that's what tends to happen when you go through test suite failures. Please review! Cheers, Nicolai ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 3/4] st/glsl_to_tgsi: remove unnecessary ir_instruction argument from get_opcode

From: Nicolai Hähnle --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index be0aa2e..fd2485d 100644 ---

Re: [Mesa-dev] [PATCH] Revert "mesa_glinterop: remove inclusion of GLX header"

2016-10-04 7:03 GMT+08:00 Vinson Lee : > This reverts commit 8472045b16b3e4621553fe451a20a9ba9f0d44b6. > > Conflicts: > > include/GL/mesa_glinterop.h > > This patch fixes this build error with GCC 4.4. > > Compiling src/glx/dri_common_interop.c ... > In file

[Mesa-dev] [PATCH] radeonsi: fix the coordinate overloading of llvm.amdgcn.image.atomic.cmpswap.*

From: Nicolai Hähnle Fixes GL45-CTS.shader_image_load_store.basic-allTargets-atomic* --- src/gallium/drivers/radeonsi/si_shader.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH] nvc0/ir: be more careful about preserving modifiers in SHLADD creation

I think we could also use those copy modifiers in some other places. Reviewed-by: Samuel Pitoiset On 10/12/2016 07:32 PM, Ilia Mirkin wrote: First off, src2 was being given the wrong modifier, and secondly we were forgetting to clear src0's modifier. Instead let's

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Perform check for valid fbconfig against proper X-Screen.

On 11 October 2016 at 19:42, Mario Kleiner wrote: > Commit cf804b4455fac9e585b3600a8318caaced9c23de > ('glx: fix crash with bad fbconfig') introduced a check > in glXCreateNewContext() if the given config is a valid > fbconfig. > > Unfortunately the check always checks

[Mesa-dev] [PATCH] nvc0/ir: be more careful about preserving modifiers in SHLADD creation

First off, src2 was being given the wrong modifier, and secondly we were forgetting to clear src0's modifier. Instead let's use the ValueRef-based setter, which can also copy modifiers properly. Signed-off-by: Ilia Mirkin ---

[Mesa-dev] [PATCH 2/2] st/nine: Fix possible segfault in surface ctor

Regression introduced by ba0274c7d6c3b77a36bbe1b444f427b0c873e2f3 Check the resource exists before assigning it a flag (and use This->base.resource instead of pResource, since the former may have a newly allocate resource, while the latter would be NULL). This should reintroduce the behaviour of

Re: [Mesa-dev] [PATCH 12/12] aubinator: replace pragma once with ifndef guard

On 12 October 2016 at 18:08, Chad Versace wrote: > On Tue 11 Oct 2016, Emil Velikov wrote: >> From: Emil Velikov >> >> Signed-off-by: Emil Velikov >> --- >> src/intel/tools/decoder.h | 5 - >> 1 file changed,

  1   2   >