On Thu, 2016-11-03 at 11:02 +0100, Juan A. Suarez Romero wrote:
> The GL 4.5 spec says:
> "If any enabled array’s buffer binding is zero when DrawArrays
> or one of the other drawing commands defined in section 10.4 is
> called, the result is undefined."
>
> This commits avoids crashin
On Thu, 2016-11-24 at 13:36 +0100, Juan A. Suarez Romero wrote:
> pbuff is defined but not used.
> ---
> src/gallium/state_trackers/va/surface.c | 1 -
> 1 file changed, 1 deletion(-)
>
>
Gently ping someone to review it.
J.A.
___
mesa-dev
On 03/12/16 05:38 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> This fixes random radeonsi GPU hangs in Batman Arkham: Origins (Wine) and
> probably many other games too.
>
> cso_cache deletes sampler states when the cache size is too big and doesn't
> check which sampler states are bound, caus
https://bugs.freedesktop.org/show_bug.cgi?id=98974
--- Comment #6 from Eero Tamminen ---
(In reply to Dylan Baker from comment #1)
> I can verify this bug on Archlinux using the i965 driver on both HSW and
> SKL, thus moving to mesa core.
>
> On i965 I'm using low settings but see no borders for
Reviewed-by: Edward O'Callaghan
On 12/05/2016 04:45 AM, Nayan Deshmukh wrote:
> CovID: 1396387
>
> Signed-off-by: Nayan Deshmukh
> ---
> src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
> b/sr
On 03/12/16 01:31 AM, Emil Velikov wrote:
> From: Emil Velikov
>
> Analogous to previous commit
>
> Cc: Michel Dänzer
> Signed-off-by: Emil Velikov
> ---
> src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/w
Am 05.12.2016 um 06:25 schrieb Nayan Deshmukh:
Signed-off-by: Nayan Deshmukh
Reviewed-by: Christian König .
---
src/gallium/state_trackers/vdpau/mixer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/vdpau/mixer.c
b/src/gallium/state_tracke
On Thu, 2016-12-01 at 22:22 -0800, Jason Ekstrand wrote:
> +Ken
>
> On Thu, Dec 1, 2016 at 10:17 PM, Jason Ekstrand > wrote:
> > I'm not sure how I feel about this one. It seems like it would
> > almost be easier to just pick one convention or the other for NIR
> > and adjust one of the drivers
Thanks for the review. Can you push the patch for me.
Regards,
Nayan
On Mon, Dec 5, 2016 at 2:46 PM, Edward O'Callaghan
wrote:
> Reviewed-by: Edward O'Callaghan
>
> On 12/05/2016 04:45 AM, Nayan Deshmukh wrote:
>> CovID: 1396387
>>
>> Signed-off-by: Nayan Deshmukh
>> ---
>> src/amd/vulkan/win
Christian, Thanks for the review. Can you push the patch for me?
Regards,
Nayan
On Mon, Dec 5, 2016 at 1:17 PM, Christian König
wrote:
> Am 05.12.2016 um 06:25 schrieb Nayan Deshmukh:
>>
>> Signed-off-by: Nayan Deshmukh
>
>
> Reviewed-by: Christian König .
>
>
>> ---
>> src/gallium/state_trac
Hi Marek,
Am Freitag, den 02.12.2016, 23:10 +0100 schrieb Marek Olšák:
> Shouldn't this be in pipe_context if it does a copy? It's basically
> the opposite of flush_resource, right?
I tried this at first (actually, at first I misunderstood the meaning of
invalidate_resource and reused that, for G
Am Montag, den 05.12.2016, 11:19 +0100 schrieb Philipp Zabel:
> Hi Marek,
>
> Am Freitag, den 02.12.2016, 23:10 +0100 schrieb Marek Olšák:
> > Shouldn't this be in pipe_context if it does a copy?
Actually, resource_changed is not supposed to create a copy immediately.
Maybe instead of "trigger re
According to the bug, this was a mistake in ARB_stencil_texturing, which
was fixed in GL 4.5. Albeit since the extension itself wasn't updated,
I'm not entirely sure it really is supposed to work without gl 4.5 but
this extension.
In any case, with 4.5 this clearly is a bug and it should work. Seem
From: Roland Scheidegger
As per GL 4.5 rules, which fixed a spec mistake in GL_ARB_stencil_texturing.
The extension spec wasn't updated, but just allow it with older GL versions
as well, hoping there aren't any crazy tests which want to see an error
there... (Compile tested only.)
Reported by Jó
On Mon, Dec 5, 2016 at 1:40 PM, wrote:
> From: Roland Scheidegger
>
> As per GL 4.5 rules, which fixed a spec mistake in GL_ARB_stencil_texturing.
> The extension spec wasn't updated, but just allow it with older GL versions
> as well, hoping there aren't any crazy tests which want to see an err
This seems like the compiler being silly since it fails to match if
(vmixer->bicubic.filter || ...) with the else of if
(!vmixer->noise_reduction.filter && ...)
As usual, some wild idea(s) come to mind. Please don't read too much into them.
- move current_picture_structure validation further up
Hi Nicolai,
2016-12-01 13:00 GMT+01:00 Nicolai Hähnle :
> Congratulations on a huge amount of work! Obviously I can't say much about
> the driver itself. Some things that I noticed for the renderonly library.
>
> On 30.11.2016 14:44, Christian Gmeiner wrote:
>>
>> This a very lightweight library
Hi Emil,
2016-12-01 15:42 GMT+01:00 Emil Velikov :
> On 1 December 2016 at 12:00, Nicolai Hähnle wrote:
>> Congratulations on a huge amount of work! Obviously I can't say much about
>> the driver itself. Some things that I noticed for the renderonly library.
>>
>> On 30.11.2016 14:44, Christian
Hi Tomasz,
Thanks for the review. I will change these logs and code styles errors in v2
version.
> > + } else if (dri2_surf->base.Type == EGL_PBUFFER_BIT) {
>
> We won't be called with anything else than window or pbuffer bit here,
> because we don't advertise pixmap support and createPixm
On Mon, Dec 5, 2016 at 10:20 PM, Liu, Zhiquan wrote:
> Hi Tomasz,
>
> Thanks for the review. I will change these logs and code styles errors in v2
> version.
>
>> > + } else if (dri2_surf->base.Type == EGL_PBUFFER_BIT) {
>>
>> We won't be called with anything else than window or pbuffer bit he
On 4 December 2016 at 20:21, Jan Vesely wrote:
> On Sat, 2016-12-03 at 14:33 -0800, Vinson Lee wrote:
>> Hi, Tobias.
>>
>> /bin/llvm-config --includedir returns /include. I am
>> not setting the "--with-llvm-prefix" configure option.
>
> Have you completed mesa build with only the configure.ac fix
On Dec 5, 2016 11:43 AM, "Philipp Zabel" wrote:
Am Montag, den 05.12.2016, 11:19 +0100 schrieb Philipp Zabel:
> Hi Marek,
>
> Am Freitag, den 02.12.2016, 23:10 +0100 schrieb Marek Olšák:
> > Shouldn't this be in pipe_context if it does a copy?
Actually, resource_changed is not supposed to create
On Mon, Dec 5, 2016 at 6:28 PM, Emil Velikov wrote:
> This seems like the compiler being silly since it fails to match if
> (vmixer->bicubic.filter || ...) with the else of if
> (!vmixer->noise_reduction.filter && ...)
>
> As usual, some wild idea(s) come to mind. Please don't read too much into
From: Emil Velikov
Extension is already implemented in the main code.
Signed-off-by: Emil Velikov
---
src/egl/main/eglapi.c | 6 ++
src/egl/main/egldisplay.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index 9950a72..46e3358 10064
From: Emil Velikov
Already set by the core code - dri2_create_screen/dri2_setup_screen
Cc: Chad Versace
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_surfaceless.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_surfaceless.c
b/src/egl/drive
On 21 November 2016 at 17:33, Emil Velikov wrote:
> On 19 November 2016 at 01:38, Tobias Droste wrote:
>> Patches 1-11 and 13-16 are only rebased, no change in functionality and have
>> a reviewed by.
>>
>> Patch 12 is changed based on review of Emil (I used "HAVE_GALLIUM_LLVM"
>> instead of "U
Some nice catches in there! For the series:
Reviewed-by: Nicolai Hähnle
On 02.12.2016 21:39, Marek Olšák wrote:
From: Marek Olšák
Cc: 13.0 12.0
---
src/gallium/drivers/radeonsi/si_shader.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/gallium/dr
On 05.12.2016 10:05, Michel Dänzer wrote:
On 03/12/16 05:38 AM, Marek Olšák wrote:
From: Marek Olšák
This fixes random radeonsi GPU hangs in Batman Arkham: Origins (Wine) and
probably many other games too.
cso_cache deletes sampler states when the cache size is too big and doesn't
check which
On 2 December 2016 at 21:49, Marek Olšák wrote:
> Hi Emil,
>
> 7 additional nominations for 12.0 are attached:
> - the CSO fix is very important
> - the 4th patch fixes dual-source blending on Stoney
> - the last one silences printf messages with LLVM 3.9.
>
> Patches 1, 5, 6 are on mesa-dev, not
Hi,
to get weston / wayland_egl working on etnaviv, we need to update the texture
resources derived from imported buffers every time they are re-imported.
This patchset is based on the github-etnaviv/for_mainline_v1 branch and adds
a new pipe_screen::resource_changed callback that is called insid
Imported resources already have contents that we want to be copied to
texture resources derived from them. Set initial seqno of imported
resources to 1, just as if it had already been rendered to.
Signed-off-by: Philipp Zabel
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 2 ++
1 file chan
Use the resource_changed callback to invalidate internal resources
derived from external textures when they are (re-)bound. This is needed
to comply with the requirement from the GL_OES_EGL_image_external
extension that a call to glBindTexture guarantees that all further
sampling will return values
For imported buffers that can't be used directly as a source to the
texture samplers, the pipe driver might need to create an internal
copy, for example in a different tiling layout. When buffers are
reimported they may contain new image data, so the driver internal
copies need to be recreated.
Si
To comply with the requirement from the GL_OES_EGL_image_external
extension that a call to glBindTexture guarantees that all further
sampling will return values that correspond to the values in the
external texture at or after the time that glBindTexture was called,
do not bail out early from mesa_
Implement the resource_changed pipe callback to invalidate internal
resources derived from imported buffers. This is needed to update the
texture for re-imported renderables.
Signed-off-by: Philipp Zabel
---
src/gallium/drivers/etnaviv/etnaviv_resource.c | 13 +
1 file changed, 13 in
Add a hook to tell drivers that an imported resource may have changed
and they need to update their internal derived resources.
Signed-off-by: Philipp Zabel
---
Changes since v1:
- Clarified intended of pipe_screen::resource_changed
---
src/gallium/include/pipe/p_screen.h | 8
1 file c
Hi,
On 10 June 2014 at 15:46, Rob Clark wrote:
> On Mon, Jun 9, 2014 at 5:53 AM, Pekka Paalanen wrote:
>> On Thu, 16 Aug 2012 17:28:19 -0500 Rob Clark wrote:
>>> From: Rob Clark
>>
>> it looks like this patch never made it into Mesa. Also the
>> implementation apparently didn't make it into Me
From: Emil Velikov
Document what has been the unofficial way to self-reject stable patches.
Namely: drop the mesa-stable tag and push the commit.
Cc: Nanley Chery
Signed-off-by: Emil Velikov
---
Nanley, I fear that adding this note to the criteria section will get
lost.
Please let me know if
On Sun, Nov 27, 2016 at 7:23 PM, Ilia Mirkin wrote:
> The strategy is to just keep n anv_query_pool_slot entries per query
> instead of one. The available bit is only valid in the last one.
>
> Signed-off-by: Ilia Mirkin
> ---
>
> I think this is in a pretty good state now. I've tested both the
On Mon, Dec 5, 2016 at 11:11 AM, Robert Bragg wrote:
>
>
> On Sun, Nov 27, 2016 at 7:23 PM, Ilia Mirkin wrote:
>>
>> The strategy is to just keep n anv_query_pool_slot entries per query
>> instead of one. The available bit is only valid in the last one.
>>
>> Signed-off-by: Ilia Mirkin
>> ---
>>
Mesa 12.0.5 is now available.
Note: this is the final anticipated release in the 12.0 series. Users are
encouraged to migrate to the 13.0 series in order to obtain future fixes.
In this release we have:
The SWR driver builds correctly with LLVM 3.7 up-to 3.9. The i965 and radeon
(r600, radeonsi)
On Monday, December 5, 2016 1:40:06 PM PST srol...@vmware.com wrote:
> From: Roland Scheidegger
>
> As per GL 4.5 rules, which fixed a spec mistake in GL_ARB_stencil_texturing.
> The extension spec wasn't updated, but just allow it with older GL versions
> as well, hoping there aren't any crazy t
Uses llvmpipe's string formating.
---
src/gallium/drivers/swr/swr_screen.cpp | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/swr/swr_screen.cpp
b/src/gallium/drivers/swr/swr_screen.cpp
index 75a9d02..539acf1 100644
--- a/src/gallium/drivers/swr
Use llvm provided API based on cpuid rather than our own
manually mantained list of mattr enabling/disabling.
---
src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
b/src/gallium/auxiliar
---
src/gallium/drivers/swr/swr_screen.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/swr/swr_screen.cpp
b/src/gallium/drivers/swr/swr_screen.cpp
index 539acf1..b5c2cd3 100644
--- a/src/gallium/drivers/swr/swr_screen.cpp
+++ b/src/gallium/drivers/swr/swr_screen.cpp
@@
Reviewed-by: Bruce Cherniak
> On Dec 5, 2016, at 11:40 AM, Tim Rowley wrote:
>
> ---
> src/gallium/drivers/swr/swr_screen.cpp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/drivers/swr/swr_screen.cpp
> b/src/gallium/drivers/swr/swr_screen.cpp
> index 539acf1..b5c2cd3 100
On Mon, Dec 05, 2016 at 04:11:21PM +, Emil Velikov wrote:
> From: Emil Velikov
>
> Document what has been the unofficial way to self-reject stable patches.
>
> Namely: drop the mesa-stable tag and push the commit.
>
> Cc: Nanley Chery
> Signed-off-by: Emil Velikov
> ---
> Nanley, I fear t
Reviewed-by: Bruce Cherniak
> On Dec 5, 2016, at 11:39 AM, Rowley, Timothy O
> wrote:
>
> Uses llvmpipe's string formating.
> ---
> src/gallium/drivers/swr/swr_screen.cpp | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/swr/swr_screen.cp
Enable the use of a transform feedback overflow query with
glBeginConditionalRender. The render commands will only execute if the
query is true (i.e. if there was an overflow).
Use ARB_conditional_render_inverted to change this behavior.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri
Predication needs cmd parser only on gen7. For newer platforms, it
should be available without it.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/driver
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
src/mesa/main/extensions_table.h | 1 +
src/mesa/main/get.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/
This patch series is an initial version that implements support for
ARB_transform_feedback_overflow_query on i965. It does that by storing
the initial values of generated and written primitives on glBeginQuery,
and final values on glEndQuery, and then comparing those values.
I still need to write
Add some basic types and storage for the queries of this extension.
Signed-off-by: Rafael Antognolli
---
src/mesa/main/mtypes.h | 5 +
src/mesa/main/queryobj.c| 21 +
src/mesa/state_tracker/st_cb_queryobj.c | 6 ++
3 files changed, 3
Enable getting the results of a transform feedback overflow query with a
buffer object.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/hsw_queryobj.c | 108 +++
1 file changed, 108 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/hsw_queryobj.c
b
When querying for transform feedback overflow on one or all of the
streams, store information about number of generated and written
primitives. Then check whether generated == written.
Signed-off-by: Rafael Antognolli
---
src/mesa/drivers/dri/i965/brw_queryobj.c | 2 ++
src/mesa/drivers/dri/i
On Wed, Nov 30, 2016 at 1:11 PM, Matt Turner wrote:
> On 11/28, Ian Romanick wrote:
>>
>> From: Ian Romanick
>>
>> I believe that I have addressed all of the review feedback from the
>> previous iteration. Many of the patches have been reviewed, and they
>> should be ready to go.
>>
>> Patches m
Am 05.12.2016 um 16:49 schrieb Philipp Zabel:
> Add a hook to tell drivers that an imported resource may have changed
> and they need to update their internal derived resources.
>
> Signed-off-by: Philipp Zabel
> ---
> Changes since v1:
> - Clarified intended of pipe_screen::resource_changed
> -
Am 05.12.2016 um 18:39 schrieb Tim Rowley:
> Use llvm provided API based on cpuid rather than our own
> manually mantained list of mattr enabling/disabling.
> ---
> src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/src/gallium/
On 12/02/2016 05:04 PM, Matt Turner wrote:
> On Fri, Dec 2, 2016 at 12:22 PM, Emil Velikov
> wrote:
>> On 2 December 2016 at 19:49, Matt Turner wrote:
>>> A user reporting an unrelated bug (98964) said that he has to set
>>> MESA_GL_VERSION_OVERRIDE=1.4 when running Chromium otherwise it's too
>
On 12/05/2016 10:16 AM, Rafael Antognolli wrote:
> Signed-off-by: Rafael Antognolli
> ---
> src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
> src/mesa/main/extensions_table.h | 1 +
> src/mesa/main/get.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff
Aside from my comments on patch 5, you're missing some changes to
_mesa_BeginConditionalRender. See
https://cgit.freedesktop.org/~idr/mesa/commit/?h=ARB_transform_feedback_overflow_query&id=c17cf16caa18e44f9d53e05a7279066f8cc2f33c.
On 12/05/2016 10:16 AM, Rafael Antognolli wrote:
> Add some basic
From: Emil Velikov
Mesa requires ax_pthread_ok = yes, thus we can fold/rewrite the
conditional to follow the more common "if test" pattern.
No functional change intended.
Signed-off-by: Emil Velikov
---
configure.ac | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/conf
From: Emil Velikov
In the (not too) distant future we'd want to remove this option and
effectively drop the other codepath(s) we have in our dispatch.
Linux distributions have been using --enable-glx-tls for a number of
years. Some/most BSD platforms still don't support this, yet this should
ser
On Mon, Dec 05, 2016 at 10:57:16AM -0800, Ian Romanick wrote:
> On 12/05/2016 10:16 AM, Rafael Antognolli wrote:
> > Signed-off-by: Rafael Antognolli
> > ---
> > src/mesa/drivers/dri/i965/intel_extensions.c | 1 +
> > src/mesa/main/extensions_table.h | 1 +
> > src/mesa/main/get.c
On Mon, Dec 05, 2016 at 11:01:54AM -0800, Ian Romanick wrote:
> Aside from my comments on patch 5, you're missing some changes to
> _mesa_BeginConditionalRender. See
> https://cgit.freedesktop.org/~idr/mesa/commit/?h=ARB_transform_feedback_overflow_query&id=c17cf16caa18e44f9d53e05a7279066f8cc2f33c
On 11/28, Ian Romanick wrote:
From: Ian Romanick
Patches 42 through 50 enable the extension on BDW+.
42-48 are
Reviewed-by: Matt Turner
I don't understand the 64-bit CMP issue, so I'm booting a SKL to see how
fp64 works.
signature.asc
Description: Digital signature
Minor nit: i965 in the subject. :)
On 12/05/2016 10:16 AM, Rafael Antognolli wrote:
> Enable getting the results of a transform feedback overflow query with a
> buffer object.
>
> Signed-off-by: Rafael Antognolli
> ---
> src/mesa/drivers/dri/i965/hsw_queryobj.c | 108
>
From: Emil Velikov
Currently we have two macros - HAVE_ALIAS and GLX_ALIAS_UNSUPPORTED.
To make it even better former of which is explicitly cleared in some
cases while not in others.
Clear all that up by using a single macro properly set during configure.
Signed-off-by: Emil Velikov
---
conf
From: Emil Velikov
Analogoust to the previous commit were we did so for autotools
Cc: Jose Fonseca
Signed-off-by: Emil Velikov
---
Jose, I'm not 100% sure if that holds true the compiler(s) that you
gents use. Can you please double-check ?
Thanks
Emil
---
include/c99_compat.h | 1 +
1 file c
From: Emil Velikov
We must make sure that xserver has an equivalent one-line
change to its configure.ac as the glx/glapi headers get copied over.
Then again, xserver does _not_ seem to set HAVE_ALIAS to begin with so
one might want to look into that first.
Cc: Adam Jackson
Signed-off-by: Emil
From: Emil Velikov
No point in having an identical code in two places.
Not to mention that the Apple one incorrectly uses GLXDrawable as pbuf
type. This change is both API and ABI safe since the header uses the
correct GLXPbufferSGIX and both types are a typedef of the same
primitive XID.
Cc: J
From: Emil Velikov
Quick search through git history (of both mesa and xserver) hows no
instances where this was ever set.
Signed-off-by: Emil Velikov
---
src/glx/glxextensions.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/glx/glxextensions.h b/src/glx/glxextensions.h
index 743e
From: Emil Velikov
Use the macro, rather than open-coding it.
Signed-off-by: Emil Velikov
---
src/glx/glxcmds.c | 17 -
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c
index 7266b58..6c7bbfd 100644
--- a/src/glx/glxcmds.c
+++
From: Emil Velikov
Analogous to previous two commits.
Strictly speaking it's not be applicable for Android since we don't
build GLX and related code.
Regardless keep things consistent with the other build systems.
Cc: Rob Herring
Signed-off-by: Emil Velikov
---
Android.common.mk | 1 +
1 fi
On 12/05/2016 11:52 AM, Emil Velikov wrote:
> From: Emil Velikov
>
> Use the macro, rather than open-coding it.
>
> Signed-off-by: Emil Velikov
> ---
> src/glx/glxcmds.c | 17 -
> 1 file changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/src/glx/glxcmds.c b/src/glx/glx
This little series implements lowering of indirectly accessed local
variables larger than some threshold (8 floats?) to scratch space. This
improves the performance of the CSDof synmark test by about 45% because it
uses a large temporary array which we lower to if-ladders and then to piles
of scra
---
src/compiler/nir/nir_intrinsics.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/compiler/nir/nir_intrinsics.h
b/src/compiler/nir/nir_intrinsics.h
index f45bfe2..d269805 100644
--- a/src/compiler/nir/nir_intrinsics.h
+++ b/src/compiler/nir/nir_intrinsics.h
@@ -41
This uses either the normal scratch read/write messages that we use for
spilling or the DWORD scattered read/write messages for when we have
indirects.
---
src/mesa/drivers/dri/i965/brw_defines.h | 2 +
src/mesa/drivers/dri/i965/brw_fs.cpp | 111 ++
src
---
src/compiler/Makefile.sources| 1 +
src/compiler/nir/nir.h | 8 +-
src/compiler/nir/nir_clone.c | 1 +
src/compiler/nir/nir_lower_scratch.c | 258 +++
4 files changed, 267 insertions(+), 1 deletion(-)
create mode 100644 src/c
From: Timothy Arceri
This moves the nir_lower_indirect_derefs() call into
brw_preprocess_nir() so thats is called by both OpenGL and Vulkan
and removes that call to the old GLSL IR pass
lower_variable_index_to_cond_assign()
We want to do this pass in nir to be able to move loop unrolling
to nir.
---
src/mesa/drivers/dri/i965/brw_nir.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_nir.c
b/src/mesa/drivers/dri/i965/brw_nir.c
index 8768cee..f75db4d 100644
--- a/src/mesa/drivers/dri/i965/brw_nir.c
+++ b/src/mesa/drivers/dri/i965/brw_nir.c
@@ -485,6 +485
---
src/mesa/drivers/dri/i965/brw_defines.h| 2 +
src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +
src/mesa/drivers/dri/i965/brw_fs.h | 3 +
src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 142 +
src/mesa/drivers/dri/i965/brw_shader.cpp
---
src/mesa/drivers/dri/i965/brw_defines.h| 6 ++
src/mesa/drivers/dri/i965/brw_fs.h | 3 +++
src/mesa/drivers/dri/i965/brw_fs_cse.cpp | 1 +
src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 28 ++
src/mesa/drivers/dri/i965/brw_fs_nir.cpp
Can you apply this please.
Christian König wrote:
Am 25.10.2016 um 00:46 schrieb Andy Furniss:
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91281
Signed-off-by: Andy Furniss
Reviewed-by: Christian König .
---
src/gallium/state_trackers/omx/vid_enc.c | 2 +-
1 file changed, 1 ins
Hi, I did a v2, can it be applied?
https://patchwork.freedesktop.org/patch/118006/
Christian König wrote:
Am 25.10.2016 um 00:39 schrieb Andy Furniss:
For gstreamer
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=91281
Signed-off-by: Andy Furniss
---
src/gallium/drivers/radeon/radeon_v
I'm a little worried about this since it seems like the
load/store_scratch intrinsics are basically doing the same thing as
registers were originally intended to do. Either we should use the
existing register lowering, and make it conditional on the size like
you've done here, or we should just gut
On 12/05, Matt Turner wrote:
On 11/28, Ian Romanick wrote:
From: Ian Romanick
Patches 42 through 50 enable the extension on BDW+.
42-48 are
Reviewed-by: Matt Turner
I don't understand the 64-bit CMP issue, so I'm booting a SKL to see how
fp64 works.
Ah, I think I see. Because 16x dou
The PRMs for HSW and newer say that other than the opcode and DebugCtrl
bits of the instruction word, the rest must be zero.
By zeroing the instruction word manually, we avoid using any of the
state inherited through brw_codegen.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=96959
---
src/me
On Dec 5, 2016 12:14 PM, "Connor Abbott" wrote:
I'm a little worried about this since it seems like the
load/store_scratch intrinsics are basically doing the same thing as
registers were originally intended to do. Either we should use the
existing register lowering, and make it conditional on the
On 12/05/2016 12:24 PM, Matt Turner wrote:
> The PRMs for HSW and newer say that other than the opcode and DebugCtrl
> bits of the instruction word, the rest must be zero.
>
> By zeroing the instruction word manually, we avoid using any of the
> state inherited through brw_codegen.
>
> Bug: https
Hi Andy,
Please rebase all your reviewed patches, and add RB, and send them to me
I will commit them for you.
Cheers,
Leo
On 12/05/2016 03:14 PM, Andy Furniss wrote:
Hi, I did a v2, can it be applied?
https://patchwork.freedesktop.org/patch/118006/
Christian König wrote:
Am 25.10.2016
Matt Turner writes:
> On Wed, Nov 30, 2016 at 1:11 PM, Matt Turner wrote:
>> On 11/28, Ian Romanick wrote:
>>>
>>> From: Ian Romanick
>>>
>>> I believe that I have addressed all of the review feedback from the
>>> previous iteration. Many of the patches have been reviewed, and they
>>> should
Emil Velikov writes:
> From: Emil Velikov
>
> In the (not too) distant future we'd want to remove this option and
> effectively drop the other codepath(s) we have in our dispatch.
>
> Linux distributions have been using --enable-glx-tls for a number of
> years. Some/most BSD platforms still don'
Allocating zero URB space is a really bad idea. The hardware has to
give threads a handle to their URB space, and threads have to use that
to terminate the thread. Having it be an empty region just breaks a
lot of assumptions. Hence, why we asserted that it isn't possible.
Unfortunately, it /is
---
Hi everyone,
I'm about to start working on this task.
src/intel/vulkan/TODO | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO
index abfe4b6..915f423 100644
--- a/src/intel/vulkan/TODO
+++ b/src/intel/vulkan/TODO
@@ -16,6 +16,7 @@ Code sharing
Ack
On Mon, Dec 5, 2016 at 1:47 PM, Nanley Chery wrote:
> ---
>
> Hi everyone,
>
> I'm about to start working on this task.
>
> src/intel/vulkan/TODO | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO
> index abfe4b6..915f423 100644
> --- a/sr
On Mon, Dec 5, 2016 at 3:22 PM, Matt Turner wrote:
> On 12/05, Matt Turner wrote:
>>
>> On 11/28, Ian Romanick wrote:
>>>
>>> From: Ian Romanick
>>>Patches 42 through 50 enable the extension on BDW+.
>>
>>
>> 42-48 are
>>
>> Reviewed-by: Matt Turner
>>
>> I don't understand the 64-bit CMP is
On Mon, Dec 5, 2016 at 5:09 PM, Connor Abbott wrote:
> On Mon, Dec 5, 2016 at 3:22 PM, Matt Turner wrote:
>> On 12/05, Matt Turner wrote:
>>>
>>> On 11/28, Ian Romanick wrote:
From: Ian Romanick
Patches 42 through 50 enable the extension on BDW+.
>>>
>>>
>>> 42-48 are
>>>
>>> R
On Mon, Dec 5, 2016 at 1:39 PM, Kenneth Graunke wrote:
> Allocating zero URB space is a really bad idea. The hardware has to
> give threads a handle to their URB space, and threads have to use that
> to terminate the thread. Having it be an empty region just breaks a
> lot of assumptions. Hence
On 05/12/16 19:52, Emil Velikov wrote:
From: Emil Velikov
Analogoust to the previous commit were we did so for autotools
Cc: Jose Fonseca
Signed-off-by: Emil Velikov
---
Jose, I'm not 100% sure if that holds true the compiler(s) that you
gents use. Can you please double-check ?
Thanks
Emil
1 - 100 of 135 matches
Mail list logo
