Re: [Mesa-dev] [PATCH 1/2] glsl: Don't rehash the values when copying to new table

On Fri, Dec 30, 2016 at 10:04 AM, Vladislav Egorov wrote: > Oh, thanks! A very nice torture case. However, it seems to be related to > another problem. The test case has no IF or LOOP blocks, so it can't be > possibly improved with speeding up the cloning of the table (the

Re: [Mesa-dev] [RFC 2/2] i965: switch fmul to increase chance of optimising it away

On Dec 30, 2016 9:57 PM, "Timothy Arceri" wrote: On Fri, 2016-12-30 at 19:23 -0800, Jason Ekstrand wrote: > On Dec 30, 2016 3:50 AM, "Timothy Arceri" om> wrote: > If one of the inputs to the multiplcation in ffma is the result of > an

Re: [Mesa-dev] [RFC 2/2] i965: switch fmul to increase chance of optimising it away

On Fri, 2016-12-30 at 19:23 -0800, Jason Ekstrand wrote: > On Dec 30, 2016 3:50 AM, "Timothy Arceri" om> wrote: > If one of the inputs to the multiplcation in ffma is the result of > an fmul there is a chance that we can reuse the result of that > fmul in other ffma

Re: [Mesa-dev] [RFC 2/2] i965: switch fmul to increase chance of optimising it away

On Dec 30, 2016 3:50 AM, "Timothy Arceri" wrote: If one of the inputs to the multiplcation in ffma is the result of an fmul there is a chance that we can reuse the result of that fmul in other ffma calls if we do the multiplication in the right order. For example

Re: [Mesa-dev] [PATCH 5/5] st/mesa/glsl: change xfb_program field to last_vert_prog

On Fri, 2016-12-30 at 16:48 -0800, Eric Anholt wrote: > Timothy Arceri writes: > > > By making it more generic and we can short circuit a bunch of code > > paths. > > > > The new field will also be used in coming changes for more clean- > > ups. > > > > This

Re: [Mesa-dev] [PATCH 5/5] st/mesa/glsl: change xfb_program field to last_vert_prog

Timothy Arceri writes: > By making it more generic and we can short circuit a bunch of code > paths. > > The new field will also be used in coming changes for more clean-ups. > > This change also fixes a regression caused by 700bc94dcebf425 > > Bugzilla:

Re: [Mesa-dev] [PATCH 4/5] i965: stop passing gl_shader_program to brw_compile_gs() and gen6_gs_visitor()

Timothy Arceri writes: > Instead we caan just use gl_program. "can" Other than that, 1-4 are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] i965: Avoid NULL pointer dereference when transform feedback is off.

On Friday, December 30, 2016 3:39:36 PM PST Kenneth Graunke wrote: > upload_3dstate_streamout can be called when there's no currently bound > transform feedback object. In this case, we get the default object, > which has a NULL shader (previously gl_shader_program, now gl_program). > > The old

[Mesa-dev] [PATCH] i965: Avoid NULL pointer dereference when transform feedback is off.

upload_3dstate_streamout can be called when there's no currently bound transform feedback object. In this case, we get the default object, which has a NULL shader (previously gl_shader_program, now gl_program). The old code did something sketchy, but which worked: const struct

[Mesa-dev] [PATCH 3/5] i965: get InfoLog and LinkStatus via the shader program data pointer in gl_program

This removes another dependency on gl_shader_program in the codegen functions. --- src/mesa/drivers/dri/i965/brw_gs.c | 2 +- src/mesa/drivers/dri/i965/brw_tcs.c | 6 +++--- src/mesa/drivers/dri/i965/brw_tes.c | 6 ++ src/mesa/drivers/dri/i965/brw_vs.c | 4 ++--

[Mesa-dev] [PATCH 2/5] i965: eliminate gen6_xfb_enabled field in brw_gs_prog_data

We can just get this information from shader_info instead. Note that passing gen6_gs_visitor() gl_program via _LinkedShaders will go away in a later patch. --- src/mesa/drivers/dri/i965/brw_compiler.h | 5 - src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 7 +--

[Mesa-dev] [PATCH 5/5] st/mesa/glsl: change xfb_program field to last_vert_prog

By making it more generic and we can short circuit a bunch of code paths. The new field will also be used in coming changes for more clean-ups. This change also fixes a regression caused by 700bc94dcebf425 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99231 ---

[Mesa-dev] [PATCH 4/5] i965: stop passing gl_shader_program to brw_compile_gs() and gen6_gs_visitor()

Instead we caan just use gl_program. --- src/mesa/drivers/dri/i965/brw_compiler.h | 2 +- src/mesa/drivers/dri/i965/brw_gs.c| 2 +- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 7 +++ src/mesa/drivers/dri/i965/gen6_gs_visitor.cpp | 2 +-

[Mesa-dev] [PATCH 1/5] i965: update brw_get_shader_time_index() not to take gl_shader_program

This removes another dependency on gl_shader_program in the codegen functions which will help allow us to use gl_program in the CurrentProgram array rather than gl_shader_program. --- src/mesa/drivers/dri/i965/brw_context.h | 4 ++-- src/mesa/drivers/dri/i965/brw_cs.c | 2 +-

Re: [Mesa-dev] [PATCH] mesa: make union in gl_program a struct and add FIXME

On Saturday, December 31, 2016 7:45:35 AM PST Timothy Arceri wrote: > i915 is mixing the use of these fields, for now change this to a > struct and add a FIXME. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99229 > --- > src/mesa/main/mtypes.h | 6 +- > 1 file changed, 5

[Mesa-dev] [PATCH] mesa: make union in gl_program a struct and add FIXME

i915 is mixing the use of these fields, for now change this to a struct and add a FIXME. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99229 --- src/mesa/main/mtypes.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h

Re: [Mesa-dev] [PATCH] anv, radv: disable StorageImageWriteWithoutFormat for now

ack On Thu, Dec 29, 2016 at 10:01 PM, Dave Airlie wrote: > On 30 December 2016 at 15:52, Ilia Mirkin wrote: > > The SPIR-V capability isn't even marked as enabled, and there are no > > tests in Vulkan-CTS. Per Jason Ekstrand, this won't work in anv as

[Mesa-dev] Patch for freedreno features

Hi! There's a patch by Rob Clark that sits in bugzilla for while now: https://bugs.freedesktop.org/show_bug.cgi?id=95460 I've just updated it to HEAD. It would be nice to merge it, especially since there hasn't been much changes in features.txt for a while. Cheers! -- Romain "Creak" Failliot

[Mesa-dev] [Bug 95460] Please add more drivers (freedreno, virgl) to features.txt status document

https://bugs.freedesktop.org/show_bug.cgi?id=95460 Creak changed: What|Removed |Added Attachment #123841|0 |1 is

Re: [Mesa-dev] [PATCH 1/2] glsl: Don't rehash the values when copying to new table

Oh, thanks! A very nice torture case. However, it seems to be related to another problem. The test case has no IF or LOOP blocks, so it can't be possibly improved with speeding up the cloning of the table (the torture case can be modified with a few ifs and fors on top though...). Anyway, on

[Mesa-dev] [RFC 1/2] nir/algebraic: Add support for declaring that a given expression is unique

From: Jason Ekstrand Some algebraic transformations are only useful if you know for certain that they won't generate more instructions by accident. One fairly limited way of ensuring this is to ensure that some subexpression is only used in the particular tree being

[Mesa-dev] [RFC 2/2] i965: switch fmul to increase chance of optimising it away

If one of the inputs to the multiplcation in ffma is the result of an fmul there is a chance that we can reuse the result of that fmul in other ffma calls if we do the multiplication in the right order. For example it is a fairly common pattern for shaders to do something similar to this: