[Mesa-dev] [PATCH] gallium: add Tegra renderonly support

2017-01-12 Thread Alexandre Courbot
From: Christian Gmeiner Based on the same model as the IMX driver, opens a Nouveau render device in order to transparently provide acceleration on Tegra. Signed-off-by: Christian Gmeiner [acour...@nvidia.com: port to latest branch,

Re: [Mesa-dev] [PATCH v2] radv: remove some unused macros and functions

2017-01-12 Thread Bas Nieuwenhuizen
Pushed, thanks. On Wed, Jan 11, 2017 at 2:31 AM, Grazvydas Ignotas wrote: > These seem unlikely to be used. > Also remove irrelevant comment about SKL. > > v2: forgot to rebase on master > > Signed-off-by: Grazvydas Ignotas > --- > no commit access > >

Re: [Mesa-dev] [PATCH 12/22] i965/vec4: split DF instructions and later duplicate its execsize in IVB/VLV

2017-01-12 Thread Samuel Iglesias Gonsálvez
On Thu, 2017-01-12 at 15:39 -0800, Matt Turner wrote: > On Thu, Jan 5, 2017 at 5:07 AM, Samuel Iglesias Gonsálvez > wrote: > > We need to split DF instructions in two on IVB/VLV as it needs an > > execsize 8 to process 4 DF values (one GRF in total). > > > > Signed-off-by:

Re: [Mesa-dev] [PATCH] travis: Add the new drivers etnaviv and imx

2017-01-12 Thread Christian Gmeiner
2017-01-13 5:06 GMT+01:00 Rhys Kidd : > Signed-off-by: Rhys Kidd > --- > .travis.yml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 3d107aa..dfbc052 100644 > --- a/.travis.yml > +++

Re: [Mesa-dev] [PATCH 02/22] i965/fs: add helper to retrieve instruction data size

2017-01-12 Thread Samuel Iglesias Gonsálvez
On Thu, 2017-01-12 at 15:14 -0800, Matt Turner wrote: > On Thu, Jan 5, 2017 at 5:07 AM, Samuel Iglesias Gonsálvez > wrote: > > From: "Juan A. Suarez Romero" > > > > The execution data size is the biggest type size of any instruction > > operand. > > >

Re: [Mesa-dev] [PATCH] anv/pipeline: Replace get_fs_input_map with get_last_vue_prog_data

2017-01-12 Thread Lionel Landwerlin
On 13/01/17 06:45, Lionel Landwerlin wrote: On 13/01/17 01:08, Jason Ekstrand wrote: This lets us delete a helper from genX_pipeline.c --- src/intel/vulkan/anv_pipeline.c | 2 +- src/intel/vulkan/anv_private.h | 10 +- src/intel/vulkan/genX_pipeline.c | 20

Re: [Mesa-dev] [PATCH] anv/pipeline: Replace get_fs_input_map with get_last_vue_prog_data

2017-01-12 Thread Lionel Landwerlin
On 13/01/17 01:08, Jason Ekstrand wrote: This lets us delete a helper from genX_pipeline.c --- src/intel/vulkan/anv_pipeline.c | 2 +- src/intel/vulkan/anv_private.h | 10 +- src/intel/vulkan/genX_pipeline.c | 20 3 files changed, 10 insertions(+), 22

Re: [Mesa-dev] [ANNOUNCE] mesa 12.0.5

2017-01-12 Thread Timo Aaltonen
On 13.01.2017 07:40, Emil Velikov wrote: > On 12 January 2017 at 10:29, Timo Aaltonen wrote: >> On 11.01.2017 15:01, Emil Velikov wrote: >>> On 6 December 2016 at 14:55, Marek Olšák wrote: Hi, I'd like to announce that this release doesn't

[Mesa-dev] [Bug 97067] WebGL: conformance/glsl/misc/shaders-with-invariance.html Fail

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97067 --- Comment #4 from Tapani Pälli --- This test is passing on i965 with following versions: Google Chrome 55.0.2883.87 Mesa 17.0.0-devel (git-0252ba2) -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [PATCH] nv50/ir: optimize shl + and

2017-01-12 Thread Ilia Mirkin
Address loading can often end up as shl + shr + shl combinations. The latter two are equal shifts, which get converted into an and mask. However if the previous shl is more than the mask is trying to remove (in terms of low bits), we can just remove the and entirely. This reduces some large

Re: [Mesa-dev] [ANNOUNCE] mesa 12.0.5

2017-01-12 Thread Emil Velikov
On 12 January 2017 at 10:29, Timo Aaltonen wrote: > On 11.01.2017 15:01, Emil Velikov wrote: >> On 6 December 2016 at 14:55, Marek Olšák wrote: >>> Hi, >>> >>> I'd like to announce that this release doesn't fix the worst GPU >>> hangs/freezes it has. I'm

Re: [Mesa-dev] [PATCH v2 21/21] anv: Avoid some resolves for samplable HiZ buffers

2017-01-12 Thread Nanley Chery
On Thu, Jan 12, 2017 at 06:26:44PM -0800, Jason Ekstrand wrote: > Good work! Series is > > Reviewed-by: Jason Ekstrand > Thanks! -Nanley > On Thu, Jan 12, 2017 at 5:34 PM, Nanley Chery wrote: > > > v2: Simplify nested ifs (Jason Ekstrand) > > >

[Mesa-dev] [Bug 98604] [VDPAU, DRI3] Fullscreen flash video fails when hardware acceleration is enabled.

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98604 --- Comment #12 from Dieter Nützel --- (In reply to Michel Dänzer from comment #11) > Can you get a backtrace of a crash with gdb? Hello Michel, no backtrace of a crash, but I could attach gdb on running konqueror

Re: [Mesa-dev] [PATCH v2 03/21] anv: Replace anv_image_has_hiz() with ISL_AUX_USAGE_HIZ

2017-01-12 Thread Nanley Chery
On Thu, Jan 12, 2017 at 06:17:58PM -0800, Jason Ekstrand wrote: > On Thu, Jan 12, 2017 at 5:33 PM, Nanley Chery wrote: > > > The helper doesn't provide additional functionality over the current > > infrastructure. > > > > v2: Add comment to anv_image::aux_usage (Jason

[Mesa-dev] [PATCH] travis: Add the new drivers etnaviv and imx

2017-01-12 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- .travis.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 3d107aa..dfbc052 100644 --- a/.travis.yml +++ b/.travis.yml @@ -32,7 +32,7 @@ env: - DRI3PROTO_VERSION=dri3proto-1.0 -

Re: [Mesa-dev] [PATCH 2/2] egl: correct surface_type when add config

2017-01-12 Thread Tomasz Figa
On Fri, Jan 13, 2017 at 1:18 AM, Emil Velikov wrote: > [Adding Tomasz] > > On 12 January 2017 at 07:14, Liu Zhiquan wrote: >> When add config, dri_config is double or single. Should only add >> EGL_WINDOW_BIT to surface_type for double dri_config,

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Ilia Mirkin
On Thu, Jan 12, 2017 at 9:13 PM, Jason Ekstrand wrote: > Unless, of course, it's controlled by the same hardware bit... Clearly, we > can can give you abs on rsq without denorm flushing (easy shader hacks) but > not the other way around. OK, so somehow I missed that

Re: [Mesa-dev] [PATCH v2 21/21] anv: Avoid some resolves for samplable HiZ buffers

2017-01-12 Thread Jason Ekstrand
Good work! Series is Reviewed-by: Jason Ekstrand On Thu, Jan 12, 2017 at 5:34 PM, Nanley Chery wrote: > v2: Simplify nested ifs (Jason Ekstrand) > > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/genX_cmd_buffer.c

Re: [Mesa-dev] [PATCH v2 03/21] anv: Replace anv_image_has_hiz() with ISL_AUX_USAGE_HIZ

2017-01-12 Thread Jason Ekstrand
On Thu, Jan 12, 2017 at 5:33 PM, Nanley Chery wrote: > The helper doesn't provide additional functionality over the current > infrastructure. > > v2: Add comment to anv_image::aux_usage (Jason Ekstrand) > > Signed-off-by: Nanley Chery > --- >

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Jason Ekstrand
On Jan 12, 2017 4:56 PM, "Ilia Mirkin" wrote: On Thu, Jan 12, 2017 at 7:46 PM, Matt Turner wrote: > On Thu, Jan 12, 2017 at 3:20 PM, Ilia Mirkin wrote: >> On Thu, Jan 12, 2017 at 6:04 PM, Nicolai Hähnle wrote:

Re: [Mesa-dev] [PATCH 21/22] anv: Enable sampling from HiZ

2017-01-12 Thread Chery, Nanley G
Thanks for noticing this. I actually had a patch to handle this that must have gotten lost in my rebasing efforts. I'll send it in the v2. My email isn't working properly, so sorry for any formatting errors. From: Jason Ekstrand [ja...@jlekstrand.net] Sent:

[Mesa-dev] [PATCH 10/10] drm/i915: Add engine reset count in get-reset-stats ioctl

2017-01-12 Thread Michel Thierry
Users/tests relying on the total reset count will start seeing a smaller number since most of the hangs can be handled by engine reset. Note that if reset engine x, context a running on engine y will be unaware and unaffected. To start the discussion, include just a total engine reset count. If

[Mesa-dev] [PATCH v2 21/21] anv: Avoid some resolves for samplable HiZ buffers

2017-01-12 Thread Nanley Chery
v2: Simplify nested ifs (Jason Ekstrand) Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 67 -- 1 file changed, 49 insertions(+), 18 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c

[Mesa-dev] [PATCH v2 18/21] anv: Add a helper to determine sampling with HiZ

2017-01-12 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_private.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index b669d186ef..56aa6ef6e3 100644 --- a/src/intel/vulkan/anv_private.h +++

[Mesa-dev] [PATCH v2 19/21] anv/blorp: Don't fast depth clear samplable HiZ buffers on BDW

2017-01-12 Thread Nanley Chery
Avoid the resolves that would be required if fast depth clears were allowed for such buffers. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/intel/vulkan/anv_blorp.c

[Mesa-dev] [PATCH v2 17/21] isl/surface_state: Handle ISL_AUX_USAGE_HIZ

2017-01-12 Thread Nanley Chery
v2: Remove redundant x/y offset asserts (Jason Ekstrand) Signed-off-by: Nanley Chery --- src/intel/isl/isl_surface_state.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/intel/isl/isl_surface_state.c

[Mesa-dev] [PATCH v2 20/21] anv: Enable sampling from HiZ

2017-01-12 Thread Nanley Chery
v2: Restrict ISL_AUX_USAGE_HIZ to depth aspects Signed-off-by: Nanley Chery --- src/intel/vulkan/TODO| 1 - src/intel/vulkan/anv_image.c | 20 +--- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/TODO

[Mesa-dev] [PATCH v2 05/21] anv: Enable HiZ support for multiple subpasses

2017-01-12 Thread Nanley Chery
We'll be using layout transitions later on in the series which can occur within and between subpasses. Turn this on now to simplify the change later. Signed-off-by: Nanley Chery --- src/intel/vulkan/TODO | 2 +- src/intel/vulkan/gen8_cmd_buffer.c | 11

[Mesa-dev] [PATCH v2 15/21] anv: Disable HiZ for input attachments

2017-01-12 Thread Nanley Chery
v2 (Jason Ekstrand): - Add spec citation - Drop conditional Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_image.c | 23 +++ src/intel/vulkan/genX_cmd_buffer.c | 17 + 2 files changed, 24 insertions(+), 16 deletions(-)

[Mesa-dev] [PATCH v2 09/21] anv: Use the gen8 BLORP HiZ resolving function

2017-01-12 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 63f6be12a8..74369f6ba1

[Mesa-dev] [PATCH v2 11/21] anv: Add helpers to handle depth buffer layout transitions

2017-01-12 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 74369f6ba1..fff9bd37c0 100644

[Mesa-dev] [PATCH v2 16/21] anv: Perform HiZ resolves only on layout transitions

2017-01-12 Thread Nanley Chery
This is a better mapping to the Vulkan API and improves performance in all tested workloads. v2: Remove unnecessary image view aspect checks (Jason Ekstrand) Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 48 ++--

[Mesa-dev] [PATCH v2 12/21] anv: Store depth stencil layouts

2017-01-12 Thread Nanley Chery
Store the current and requested depth stencil layouts so that we can perform the appropriate HiZ resolves for a given transition while recording a render pass. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 5 + src/intel/vulkan/anv_private.h

[Mesa-dev] [PATCH v2 08/21] anv/blorp: Add a gen8 HiZ op resolve function

2017-01-12 Thread Nanley Chery
Add an entry point for resolving using BLORP's gen8 HiZ op function. v2: Manually add the aux info Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 83 ++ src/intel/vulkan/anv_private.h | 5 +++ 2 files changed,

[Mesa-dev] [PATCH v2 10/21] anv: Delete anv's HiZ op emit function

2017-01-12 Thread Nanley Chery
This is no longer used. Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_genX.h| 3 - src/intel/vulkan/gen7_cmd_buffer.c | 7 -- src/intel/vulkan/gen8_cmd_buffer.c | 223 - 3 files changed, 233 deletions(-) diff

[Mesa-dev] [PATCH v2 13/21] anv: Prepare for transitioning to the requested final layout

2017-01-12 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_pass.c| 3 +++ src/intel/vulkan/anv_private.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index ea86fa9ff2..5df6330c6a 100644 ---

[Mesa-dev] [PATCH v2 14/21] anv: Avoid resolves incurred by fast depth clears

2017-01-12 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 9 +++-- src/intel/vulkan/anv_private.h | 15 +++ src/intel/vulkan/genX_cmd_buffer.c | 5 + 3 files changed, 23 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH v2 04/21] anv: Use ::anv_attachment_state for toggling HiZ per subpass

2017-01-12 Thread Nanley Chery
We're about to enable HiZ support for multiple subpasses. Use this field to keep track of whether or not subpass operations should treat the depth buffer as having an auxiliary HiZ buffer. Signed-off-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 6 -- 1

[Mesa-dev] [PATCH v2 01/21] intel/blorp: Add the BDW+ optimized HZ_OP sequence to BLORP

2017-01-12 Thread Nanley Chery
We'll be switching to layout-transition based resolves which can occur outside of a render pass. Add this sequence to BLORP, as using BLORP will enable emitting depth stencil state outside of a render pass (among other benefits). The depth buffer extent is ignored to enable eventual usage in

[Mesa-dev] [PATCH v2 02/21] anv/blorp: Handle ISL_AUX_USAGE_HIZ

2017-01-12 Thread Nanley Chery
Prevent assert failures that would occur in the next patch. v2: Don't remove asserts from blorp/blit (Jason Ekstrand) Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2 03/21] anv: Replace anv_image_has_hiz() with ISL_AUX_USAGE_HIZ

2017-01-12 Thread Nanley Chery
The helper doesn't provide additional functionality over the current infrastructure. v2: Add comment to anv_image::aux_usage (Jason Ekstrand) Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 2 +- src/intel/vulkan/anv_image.c | 10 --

[Mesa-dev] [PATCH v2 07/21] anv: Use gen8 BLORP HiZ clearing functions

2017-01-12 Thread Nanley Chery
Signed-off-by: Nanley Chery --- src/intel/vulkan/anv_blorp.c | 54 +++--- src/intel/vulkan/genX_cmd_buffer.c | 1 - 2 files changed, 50 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c

[Mesa-dev] [PATCH v2 06/21] intel/blorp_clear: Add gen8 HiZ clearing functions

2017-01-12 Thread Nanley Chery
Add an entry point for the optimized gen8 BLORP HiZ sequence. commit c9eaf12de20ac4143fe79d42018bdbb5a391356f fixed a bug that was unknowingly worked around by forcing additional clear rectangle alignment restrictions not specified in the PRMs. Now that the bug is no longer present, omit the

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Matt Turner
On Thu, Jan 12, 2017 at 4:56 PM, Ilia Mirkin wrote: > On Thu, Jan 12, 2017 at 7:46 PM, Matt Turner wrote: >> On Thu, Jan 12, 2017 at 3:20 PM, Ilia Mirkin wrote: >>> On Thu, Jan 12, 2017 at 6:04 PM, Nicolai Hähnle

[Mesa-dev] [PATCH] anv/pipeline: Replace get_fs_input_map with get_last_vue_prog_data

2017-01-12 Thread Jason Ekstrand
This lets us delete a helper from genX_pipeline.c --- src/intel/vulkan/anv_pipeline.c | 2 +- src/intel/vulkan/anv_private.h | 10 +- src/intel/vulkan/genX_pipeline.c | 20 3 files changed, 10 insertions(+), 22 deletions(-) diff --git

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Ilia Mirkin
On Thu, Jan 12, 2017 at 7:46 PM, Matt Turner wrote: > On Thu, Jan 12, 2017 at 3:20 PM, Ilia Mirkin wrote: >> On Thu, Jan 12, 2017 at 6:04 PM, Nicolai Hähnle wrote: >>> On 12.01.2017 23:46, Ilia Mirkin wrote: On Thu, Jan 12,

Re: [Mesa-dev] [PATCH 08/22] i965/fs: fix lower SIMD width for IVB/VLV's MOVE_INDIRECT

2017-01-12 Thread Francisco Jerez
Samuel Iglesias Gonsálvez writes: > From: "Juan A. Suarez Romero" > > Previous to Broadwell, we have 8 registers for MOV_INDIRECT. But if > IVB/VLV deal with DFs, we will duplicate the exec_size from 8 to 16. > > This patch limits the SIMD width to 4

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Matt Turner
On Thu, Jan 12, 2017 at 3:20 PM, Ilia Mirkin wrote: > On Thu, Jan 12, 2017 at 6:04 PM, Nicolai Hähnle wrote: >> On 12.01.2017 23:46, Ilia Mirkin wrote: >>> >>> On Thu, Jan 12, 2017 at 4:03 PM, Matteo Bruni >>> wrote:

[Mesa-dev] [Bug 94512] X segfaults with glx-tls enabled in a x32 environment

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94512 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Marek Olšák
On Fri, Jan 13, 2017 at 12:43 AM, Nicolai Hähnle wrote: > On 13.01.2017 00:20, Ilia Mirkin wrote: >> >> On Thu, Jan 12, 2017 at 6:04 PM, Nicolai Hähnle >> wrote: >>> >>> On 12.01.2017 23:46, Ilia Mirkin wrote: On Thu, Jan 12, 2017 at 4:03

Re: [Mesa-dev] [PATCH] mapi: update the asm code to support x32

2017-01-12 Thread Nicolai Hähnle
On 13.01.2017 00:47, Grazvydas Ignotas wrote: As the branchpoint is near, can someone push it, please? Done, thanks! (This time for real ;-)) Gražvydas On Sun, Jan 8, 2017 at 11:22 PM, Matt Turner wrote: On Sun, Jan 8, 2017 at 9:38 AM, Grazvydas Ignotas

Re: [Mesa-dev] [PATCH] ac/debug: move .gitignore for sid_tables.h too

2017-01-12 Thread Nicolai Hähnle
On 13.01.2017 00:49, Grazvydas Ignotas wrote: On Thu, Jan 12, 2017 at 12:26 PM, Nicolai Hähnle wrote: On 12.01.2017 00:58, Grazvydas Ignotas wrote: b838f642 "ac/debug: Move sid_tables.h generation to common code." moved sid_tables.h but forgot the corresponding

Re: [Mesa-dev] [PATCH 22/22] anv: Avoid some resolves for samplable HiZ buffers

2017-01-12 Thread Jason Ekstrand
On Wed, Jan 11, 2017 at 5:55 PM, Nanley Chery wrote: > Signed-off-by: Nanley Chery > --- > src/intel/vulkan/genX_cmd_buffer.c | 54 +- > > 1 file changed, 41 insertions(+), 13 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] ac/debug: move .gitignore for sid_tables.h too

2017-01-12 Thread Grazvydas Ignotas
On Thu, Jan 12, 2017 at 12:26 PM, Nicolai Hähnle wrote: > On 12.01.2017 00:58, Grazvydas Ignotas wrote: >> >> b838f642 "ac/debug: Move sid_tables.h generation to common code." moved >> sid_tables.h but forgot the corresponding .gitignore. >> >> Signed-off-by: Grazvydas Ignotas

Re: [Mesa-dev] [PATCH] mapi: update the asm code to support x32

2017-01-12 Thread Grazvydas Ignotas
As the branchpoint is near, can someone push it, please? Gražvydas On Sun, Jan 8, 2017 at 11:22 PM, Matt Turner wrote: > On Sun, Jan 8, 2017 at 9:38 AM, Grazvydas Ignotas wrote: >> Fixes crashes when both glx-tls and asm are enabled on x32. >> >> Cc:

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Nicolai Hähnle
On 13.01.2017 00:20, Ilia Mirkin wrote: On Thu, Jan 12, 2017 at 6:04 PM, Nicolai Hähnle wrote: On 12.01.2017 23:46, Ilia Mirkin wrote: On Thu, Jan 12, 2017 at 4:03 PM, Matteo Bruni wrote: So, what would be really nice to have is a GLSL

Re: [Mesa-dev] [PATCH v2 6/9] radeonsi: remove unused si_prepare_cube_coords

2017-01-12 Thread Nicolai Hähnle
On 12.01.2017 21:42, Marek Olšák wrote: I commented on patches 1 & 2. Other than that, patches 1-6 are: Reviewed-by: Marek Olšák Thanks. I'm especially curious in hindsight how the 1.5 got dropped again. Anyway, I used git rebase -x to double-check that each step

Re: [Mesa-dev] [PATCH 12/22] i965/vec4: split DF instructions and later duplicate its execsize in IVB/VLV

2017-01-12 Thread Matt Turner
On Thu, Jan 5, 2017 at 5:07 AM, Samuel Iglesias Gonsálvez wrote: > We need to split DF instructions in two on IVB/VLV as it needs an > execsize 8 to process 4 DF values (one GRF in total). > > Signed-off-by: Samuel Iglesias Gonsálvez > --- >

Re: [Mesa-dev] [PATCH 08/22] i965/fs: fix lower SIMD width for IVB/VLV's MOVE_INDIRECT

2017-01-12 Thread Matt Turner
On Thu, Jan 5, 2017 at 5:07 AM, Samuel Iglesias Gonsálvez wrote: > From: "Juan A. Suarez Romero" > s/MOVE_INDIRECT/MOV_INDIRECT/ in the subject > Previous to Broadwell, we have 8 registers for MOV_INDIRECT. But if > IVB/VLV deal with DFs, we will

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Ilia Mirkin
On Thu, Jan 12, 2017 at 6:04 PM, Nicolai Hähnle wrote: > On 12.01.2017 23:46, Ilia Mirkin wrote: >> >> On Thu, Jan 12, 2017 at 4:03 PM, Matteo Bruni >> wrote: >>> >>> So, what would be really nice to have is a GLSL extension for some >>> kind of

Re: [Mesa-dev] [PATCH 07/22] i965/fs: fix dst stride in IVB/VLV type conversions

2017-01-12 Thread Matt Turner
On Thu, Jan 5, 2017 at 5:07 AM, Samuel Iglesias Gonsálvez wrote: > From: "Juan A. Suarez Romero" > > When converting a DF to F, we set dst stride to 2, to fulfil alignment > restrictions. > > But in IVB/VLV, this is not necessary, as each DF conversion

Re: [Mesa-dev] [PATCH 3/4] anv: generate entry points from vk.xml

2017-01-12 Thread Jason Ekstrand
I made a quick comment below. With that, this patch is Reviewed-by: Jason Ekstrand Assuming you pulled 1 and 2 from master of the public github repo for Khronos, they are Acked-by: Jason Ekstrand On Thu, Jan 12, 2017 at 1:43 PM, Lionel Landwerlin

Re: [Mesa-dev] [PATCH 02/22] i965/fs: add helper to retrieve instruction data size

2017-01-12 Thread Matt Turner
On Thu, Jan 5, 2017 at 5:07 AM, Samuel Iglesias Gonsálvez wrote: > From: "Juan A. Suarez Romero" > > The execution data size is the biggest type size of any instruction > operand. > > We will use it to know if the instruction deals with DF, because in

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Nicolai Hähnle
On 12.01.2017 23:46, Ilia Mirkin wrote: On Thu, Jan 12, 2017 at 4:03 PM, Matteo Bruni wrote: So, what would be really nice to have is a GLSL extension for some kind of switch to select the requested behavior WRT NaN. For example a three-way option with "don't generate

[Mesa-dev] [Bug 97067] WebGL: conformance/glsl/misc/shaders-with-invariance.html Fail

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97067 --- Comment #3 from Luke --- Tests still failing on 13.0 with Arch $ uname -a Linux arch 4.8.13-1-ARCH #1 SMP PREEMPT Fri Dec 9 07:24:34 CET 2016 x86_64 GNU/Linux $ glxinfo |grep -i opengl OpenGL vendor string: nouveau

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Matteo Bruni
2017-01-12 23:41 GMT+01:00 Axel Davy : >> Do you refer to the d3d9 MAD or the hardware instruction? If the >> former, just generating MUL and ADD separately should do the trick. In >> the latter case, I guess that means the "NaN switch" should also >> affect code generation

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Ilia Mirkin
On Thu, Jan 12, 2017 at 4:03 PM, Matteo Bruni wrote: > So, what would be really nice to have is a GLSL extension for some > kind of switch to select the requested behavior WRT NaN. For example a > three-way option with "don't generate NaN in arithmetic operations", > "do

Re: [Mesa-dev] [PATCH 05/32] [v2] gbm: Export a getter for per plane handles

2017-01-12 Thread Ben Widawsky
On 17-01-12 14:22:09, Jason Ekstrand wrote: On Thu, Jan 12, 2017 at 10:57 AM, Daniel Stone wrote: Hi, On 5 January 2017 at 04:43, Ben Widawsky wrote: > diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_ dri.c > index

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Axel Davy
On 12/01/2017 23:09, Matteo Bruni wrote: 2017-01-12 22:54 GMT+01:00 Axel Davy : Preventing NaN from being generated is not sufficient to fix the 0*inf = 0 issue. For example radeonsi does convert all NaN to zeros via a hardware setting. But 0*inf = 0 behaviour should be also

Re: [Mesa-dev] [PATCH] nir: add flt comparision simplification

2017-01-12 Thread Timothy Arceri
On Fri, 2017-01-13 at 08:49 +1100, Timothy Arceri wrote: > Actually I might just try moving this to the late block as the reason > for 'is_not_used_by_conditional' is to stop getting in the way of > ffmas. Ignore this that just results in the opts doing nothing. The whole point is to avoid ffmas

[Mesa-dev] [PATCH 1/2] main/fboject: return if it is color_attachment on get_attachment

2017-01-12 Thread Alejandro Piñeiro
Some callers would need that info to know if they should raise INVALID_ENUM or INVALID_OPERATION. An alternative would be the caller to check if the attachment is a GL_COLOR_ATTACHMENTm, but that seems redundant as get_attachment is already doing that. --- src/mesa/main/fbobject.c | 30

[Mesa-dev] [PATCH 2/2] main/fbobject: throw invalid operation when get_attachment fails if needed

2017-01-12 Thread Alejandro Piñeiro
In most cases, if a call to get_attachment fails is because attachment is a INVALID_ENUM. But for some specific cases, if COLOR_ATTACHMENTm (where m >= MAX_COLOR_ATTACHMENTS) is used, it should raise an INVALID_OPERATION exception instead. Fixes:

Re: [Mesa-dev] [PATCH 05/32] [v2] gbm: Export a getter for per plane handles

2017-01-12 Thread Jason Ekstrand
On Thu, Jan 12, 2017 at 10:57 AM, Daniel Stone wrote: > Hi, > > On 5 January 2017 at 04:43, Ben Widawsky wrote: > > diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_ > dri.c > > index c61d56b44a..f9c1afd8cb 100644 > > ---

Re: [Mesa-dev] [PATCH] i965: Fix textureGather with RG32I/UI on Gen7.

2017-01-12 Thread Jordan Justen
On 2017-01-05 02:51:38, Kenneth Graunke wrote: > According to the "Gather4 R32G32_FLOAT Bug" internal documentation > page, the R32G32_UINT and R32G32_SINT formats are affected by the > same bug as R32G32_FLOAT. Applying the same workarounds should be > viable - apparently the R32G32_FLOAT_LD

Re: [Mesa-dev] [PATCH] nir/gcm: Rework the schedule late loop

2017-01-12 Thread Jason Ekstrand
On Thu, Jan 12, 2017 at 12:38 PM, Matt Turner wrote: > On Thu, Dec 1, 2016 at 1:51 PM, Jason Ekstrand > wrote: > > This fixes a bug in code motion that occurred when the best block is the > > same as the schedule early block. In this case, because

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Matteo Bruni
2017-01-12 22:54 GMT+01:00 Axel Davy : > > Preventing NaN from being generated is not sufficient to fix the 0*inf = 0 > issue. > > For example radeonsi does convert all NaN to zeros via a hardware setting. > > But 0*inf = 0 behaviour should be also in mad, and with the NaN to

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Matteo Bruni
2017-01-12 22:25 GMT+01:00 Roland Scheidegger : > Is there actually a formal requirement that d3d9 hw never generates > NaNs? I think d3d9 is very lacking in spec there - if that is specified > somewhere I've never seen it... Maybe just everybody is expecting no > NaNs there

Re: [Mesa-dev] [PATCH 00/32] [v2] Renderbuffer Decompression (and GBM modifiers)

2017-01-12 Thread Ben Widawsky
On 17-01-12 14:44:33, Daniel Stone wrote: Hi Ben, On 3 January 2017 at 02:36, Ben Widawsky wrote: Same as v1 with the requested fixes and tags added. v1 is here: https://lists.freedesktop.org/archives/intel-gfx/2016-December/113639.html I haven't yet updated kmscube to use

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Axel Davy
On 12/01/2017 22:03, Matteo Bruni wrote: 2017-01-11 19:09 GMT+01:00 Jason Ekstrand : Another reason why I'm not a huge fan is that there is some momentum in the industry to make GLSL better defined with respect to NaN. I don't know that anything will ever come of it

Re: [Mesa-dev] [PATCH] nir: add flt comparision simplification

2017-01-12 Thread Timothy Arceri
Actually I might just try moving this to the late block as the reason for 'is_not_used_by_conditional' is to stop getting in the way of ffmas. On Fri, 2017-01-13 at 08:29 +1100, Timothy Arceri wrote: > Didn't turn out as useful as I'd hoped, but it will help alot more on > i965 by reducing

[Mesa-dev] [PATCH 3/4] anv: generate entry points from vk.xml

2017-01-12 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/Makefile.am| 15 ++-- src/intel/vulkan/anv_entrypoints_gen.py | 125 +--- 2 files changed, 71 insertions(+), 69 deletions(-) diff --git a/src/intel/vulkan/Makefile.am

[Mesa-dev] [PATCH 4/4] radv: generate entrypoints from vk.xml

2017-01-12 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/amd/vulkan/Makefile.am | 14 ++--- src/amd/vulkan/radv_entrypoints_gen.py | 105 - 2 files changed, 56 insertions(+), 63 deletions(-) diff --git a/src/amd/vulkan/Makefile.am

[Mesa-dev] [PATCH 1/4] include: update Vulkan headers

2017-01-12 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- include/vulkan/vk_platform.h | 2 +- include/vulkan/vulkan.h | 247 ++- 2 files changed, 244 insertions(+), 5 deletions(-) diff --git a/include/vulkan/vk_platform.h

[Mesa-dev] [PATCH 0/4] Vulkan: generate entry points from vk.xml

2017-01-12 Thread Lionel Landwerlin
Hi, We're currently generating a few vulkan entry point files by parsing the API files using regular expressions. This is limited for a couple of reasons : - function pointer types might not always be declared on a single line - if function pointers are declared under conditional

[Mesa-dev] [PATCH] nir: add flt comparision simplification

2017-01-12 Thread Timothy Arceri
Didn't turn out as useful as I'd hoped, but it will help alot more on i965 by reducing regressions when we drop brw_do_channel_expressions() and brw_do_vector_splitting(). I'm not sure how much sense 'is_not_used_by_conditional' makes on platforms other than i965 but since this is a new opt it at

Re: [Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Roland Scheidegger
Am 12.01.2017 um 22:03 schrieb Matteo Bruni: > 2017-01-11 19:09 GMT+01:00 Jason Ekstrand : >> Another reason why I'm not a huge fan is that there is some momentum in the >> industry to make GLSL better defined with respect to NaN. I don't know that >> anything will ever come

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97102 --- Comment #11 from Bruce Cherniak --- As Tim suggests, pruning empty nodes is probably the best solution for the crash. For performance, however, I'm not sure how many cores to expose in your case. cpuinfo shows

Re: [Mesa-dev] [PATCH 11/32] gbm: Introduce modifiers into surface/bo creation

2017-01-12 Thread Ben Widawsky
On 17-01-09 17:03:48, Jason Ekstrand wrote: On Mon, Jan 2, 2017 at 6:37 PM, Ben Widawsky wrote: The idea behind modifiers like this is that the user of GBM will have some mechanism to query what properties the hardware supports for its BO or surface. This information is

[Mesa-dev] NaN behavior in GLSL (was Re: [PATCH] glsl: always do sqrt(abs()) and inversesqrt(abs()))

2017-01-12 Thread Matteo Bruni
2017-01-11 19:09 GMT+01:00 Jason Ekstrand : > Another reason why I'm not a huge fan is that there is some momentum in the > industry to make GLSL better defined with respect to NaN. I don't know that > anything will ever come of it (because it may break apps) but if

[Mesa-dev] [PATCH] util: Implement a hash table cloning function

2017-01-12 Thread Thomas Helland
V2: Don't rzalloc; we are about to rewrite the whole thing (Vladislav) --- src/util/hash_table.c | 22 ++ src/util/hash_table.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/src/util/hash_table.c b/src/util/hash_table.c index 9e643af8b2..603f694ccb 100644 ---

[Mesa-dev] [PATCH] glsl: Use hash table cloning in copy propagation

2017-01-12 Thread Thomas Helland
Walking the whole hash table, inserting entries by hashing them first is just a really really bad idea. We can simply memcpy the whole thing. --- src/compiler/glsl/opt_copy_propagation.cpp | 17 - .../glsl/opt_copy_propagation_elements.cpp | 29 --

Re: [Mesa-dev] [PATCH v2 6/9] radeonsi: remove unused si_prepare_cube_coords

2017-01-12 Thread Marek Olšák
I commented on patches 1 & 2. Other than that, patches 1-6 are: Reviewed-by: Marek Olšák Marek On Thu, Jan 12, 2017 at 4:39 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Reviewed-by: Bas Nieuwenhuizen

Re: [Mesa-dev] [PATCH v2 2/9] radeonsi: restrict cube map derivative computations to the correct plane

2017-01-12 Thread Marek Olšák
On Thu, Jan 12, 2017 at 4:39 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > As remarked by the comment in the original code, the old algorithm fails when > (tc + deriv) points at a different cube face. Instead, simply project the > derivative

Re: [Mesa-dev] [PATCH] nir/gcm: Rework the schedule late loop

2017-01-12 Thread Matt Turner
On Thu, Dec 1, 2016 at 1:51 PM, Jason Ekstrand wrote: > This fixes a bug in code motion that occurred when the best block is the > same as the schedule early block. In this case, because we're checking > (lca != def->parent_instr->block) at the top of the loop, we never get

Re: [Mesa-dev] [PATCH 3/3] radeonsi: replace si_shader_context::soa by bld_base

2017-01-12 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Jan 12, 2017 at 2:07 PM, Samuel Pitoiset wrote: > We no longer need to use lp_build_tgsi_soa_context. > > No regressions founds with full piglit run. > > Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH v2 1/9] radeonsi: communicate cube map coordinates more explicitly

2017-01-12 Thread Marek Olšák
On Thu, Jan 12, 2017 at 4:39 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Reviewed-by: Bas Nieuwenhuizen > --- > src/gallium/drivers/radeonsi/si_shader_tgsi_alu.c | 74 > +-- > 1 file changed,

Re: [Mesa-dev] [PATCH 3/4] util: Implement a hash table cloning function

2017-01-12 Thread Vladislav Egorov
12.01.2017 22:23, Thomas Helland пишет: --- src/util/hash_table.c | 22 ++ src/util/hash_table.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/src/util/hash_table.c b/src/util/hash_table.c index 9e643af8b2..702f465382 100644 --- a/src/util/hash_table.c +++

Re: [Mesa-dev] [PATCH 07/32] gbm: Export a per plane getter for stride

2017-01-12 Thread Ben Widawsky
On 17-01-12 14:33:01, Daniel Stone wrote: On 12 January 2017 at 14:32, Daniel Stone wrote: If allocated, this image is just leaked, along with its reference on the BO. Same problem in gbm_dri_bo_get_handle_for_plane. ... and gbm_dri_bo_get_offset. Cheers, Daniel Does

[Mesa-dev] [Bug 99388] RHEL 7.3, Matlab 2016a Segmentation fault - glEnable

2017-01-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99388 Bug ID: 99388 Summary: RHEL 7.3, Matlab 2016a Segmentation fault - glEnable Product: Mesa Version: 11.2 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH 05/32] [v2] gbm: Export a getter for per plane handles

2017-01-12 Thread Daniel Stone
Hi, On 5 January 2017 at 04:43, Ben Widawsky wrote: > diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c > index c61d56b44a..f9c1afd8cb 100644 > --- a/src/gbm/backends/dri/gbm_dri.c > +++ b/src/gbm/backends/dri/gbm_dri.c > @@ -622,6 +622,33 @@

  1   2   >