Re: [Mesa-dev] Time to update GSoC/EVoC ideas page

2017-01-23 Thread Daniel Vetter
On Fri, Jan 20, 2017 at 08:44:19AM -0800, Jason Ekstrand wrote: > On Fri, Jan 20, 2017 at 2:15 AM, Nicolai Hähnle wrote: > > > Hi Rob, > > > > On 19.01.2017 23:32, Rob Clark wrote: > > > >> Just a friendly reminder that now would be a good time to update the > >> wiki page for GSoC/EVoC ideas: >

[Mesa-dev] [Bug 99496] Dolphin emulator: Launching Mario Kart Wii results in a blank window/black screen and freeze.

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99496 Christian Lanig changed: What|Removed |Added Summary|Dolphin emulator displays |Dolphin emulator: Launching

Re: [Mesa-dev] [PATCH v2] nir/spirv/glsl450: rewrite atan2 to deal with infinities

2017-01-23 Thread Juan A. Suarez Romero
On Sun, 2017-01-22 at 00:20 -0800, Francisco Jerez wrote: > "Juan A. Suarez Romero" writes: > > > Rewrite atan2(y,x) to cover (+/-)INF values. > > > > This fixes several test cases in Vulkan CTS > > (dEQP-VK.glsl.builtin.precision.atan2.*) > > > > v2: do not flush denorms to 0 (jasuarez) > > --

Re: [Mesa-dev] [PATCH 0/3] i965: IVB/BYT fp64 fixes

2017-01-23 Thread Samuel Iglesias Gonsálvez
On Fri, 2017-01-20 at 13:35 -0800, Matt Turner wrote: > I committed my EU validator earlier today. It's caught three bugs in > the IVB > fp64 series. Patches 2 and 3 fix two of them. I'll respond directly > to the > patch in Igalia's series that introduces the other bug. > OK, while waiting for C

Re: [Mesa-dev] [PATCH 3/3] i965: Use correct VertStride on align16 instructions.

2017-01-23 Thread Samuel Iglesias Gonsálvez
On Fri, 2017-01-20 at 14:25 -0800, Francisco Jerez wrote: > Matt Turner writes: > > > In commit c35fa7a, we changed the "width" of DF source registers to > > 2, > > which is conceptually fine. Unfortunately a VertStride of 2 is not > > allowed by align16 instructions on IVB/BYT, and the regular >

[Mesa-dev] [Bug 98833] [REGRESSION, bisected] Wayland revert commit breaks non-Vsync fullscreen frame updates

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98833 Eero Tamminen changed: What|Removed |Added Summary|[REGRESSION, bisected] |[REGRESSION, bisected]

[Mesa-dev] [Bug 98471] [TRACKER] Mesa 13.0 release tracker

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98471 Eero Tamminen changed: What|Removed |Added Depends on||98833 Referenced Bugs: https://bugs.fr

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-23 Thread Jose Fonseca
On 20/01/17 02:48, Emil Velikov wrote: On 19 January 2017 at 19:26, Tobias Droste wrote: Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov: On 18 January 2017 at 18:12, Jose Fonseca wrote: In order to untangle things we want to have a distinction between the gallium (gallivm af

Re: [Mesa-dev] [PATCH] gbm-dri: Duplicate image after checking its format.

2017-01-23 Thread Eric Engestrom
On Wednesday, 2016-12-21 10:55:28 +0100, mateuszx.potr...@intel.com wrote: > From: Mateusz Polrola > > If image will be duplicated before checking if its format is supported > it may leak memory, as duplicated image for non supported formats is > not being destroyed. > > Signed-off-by: Mateusz P

[Mesa-dev] [PATCH mesa] gbm/dri: fix memory leaks in error path

2017-01-23 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- src/gbm/backends/dri/gbm_dri.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 45cb42a862..ef96185848 100644 --- a/src/gbm/backends/dri/gbm_dri.c +++ b/src/gbm/backends

[Mesa-dev] [Bug 97967] glsl/tests/cache-test regression

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97967 --- Comment #8 from Tapani Pälli --- (In reply to Timothy Arceri from comment #7) > The real issue is these MAX_SIZE limits are far too small. Arguably we > should handle it anyway or maybe apply a minimum size. hmm let me share my theory .. MAX

Re: [Mesa-dev] [PATCH 1/4] i965: Combine the Gen6 SF and Clip viewport atoms.

2017-01-23 Thread Pohjolainen, Topi
On Sun, Jan 22, 2017 at 10:42:16PM -0800, Kenneth Graunke wrote: > The next patch will make the guardband calculation dependent on the > transformation matrix. Instead of computing it in both atoms, just > combine them into a single atom. > > Signed-off-by: Kenneth Graunke Reviewed-by: Topi Poh

[Mesa-dev] [Bug 99496] Dolphin emulator: Launching Mario Kart Wii results in a blank window/black screen and freeze.

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99496 --- Comment #3 from Grazvydas Ignotas --- Same issue here on RX 470, seems to not depend on the game (or happens on most). There was some basic debugging done which showed that the command stream doesn't even start to be executed (or the debug c

Re: [Mesa-dev] [PATCH 2/4] i965: Use a better guardband calculation.

2017-01-23 Thread Ilia Mirkin
On Mon, Jan 23, 2017 at 1:42 AM, Kenneth Graunke wrote: > + *ymin = MIN2(ndc_gb_ymin, ndc_gb_ymax); Should this be limited on the negative end of the range? > + *ymax = MIN2(MAX2(ndc_gb_ymin, ndc_gb_ymax), 16383); And should this be a different value for gen6? Perhaps based on gb_size

Re: [Mesa-dev] [PATCH mesa] drirc: remove spurious tabs

2017-01-23 Thread Eric Engestrom
On Friday, 2017-01-06 19:08:39 +1100, Edward O'Callaghan wrote: > Reviewed-by: Edward O'Callaghan Thanks; can you push this for me please? Cheers, Eric > > On 01/06/2017 08:06 AM, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > src/mesa/drivers/dri/common/drirc | 16 +++

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-23 Thread Christian König
Ah, yes of course. If we delay creating the decoder we need to call begin_frame() again as well. Please review and/or test the attached patch. Andy I did understand you right that this is already a Tested-by from your side, isn't it? I am wondering if calling decode_bitstream one at a time f

Re: [Mesa-dev] [PATCH] mesa: Enable EXT_compressed_ETC1_RGB8_sub_texture

2017-01-23 Thread Manolova, Plamena
Thank you for reviewing guys! AFAIK this extension is a driver-side feature and can be enabled for all drivers that support ETC1. I'll go ahead and update my patch. On Fri, Jan 20, 2017 at 6:25 PM, Jason Ekstrand wrote: > On Fri, Jan 20, 2017 at 10:16 AM, Ilia Mirkin > wrote: > >> What level of

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-23 Thread Nayan Deshmukh
The patch is Reviewed-by: Nayan Deshmukh On Mon, Jan 23, 2017 at 7:01 PM, Christian König wrote: > Ah, yes of course. If we delay creating the decoder we need to call > begin_frame() again as well. > > Please review and/or test the attached patch. Andy I did understand you > right that this is

Re: [Mesa-dev] [PATCH] mesa: Enable EXT_compressed_ETC1_RGB8_sub_texture

2017-01-23 Thread Ilia Mirkin
Yeah, sounds like you can reuse the OES_compressed_ETC1_RGB8_texture enable bit. On Mon, Jan 23, 2017 at 9:31 AM, Manolova, Plamena wrote: > Thank you for reviewing guys! AFAIK this extension is a driver-side feature > and can be enabled for all drivers that support ETC1. I'll go ahead and > upda

Re: [Mesa-dev] [PATCH v2 09/20] i965/fs: indirect addressing with doubles is not supported in IVB/BYT

2017-01-23 Thread Samuel Iglesias Gonsálvez
On Fri, 2017-01-20 at 13:41 -0800, Matt Turner wrote: > On Tue, Jan 17, 2017 at 1:49 AM, Samuel Iglesias Gonsálvez > wrote: > > It is tested empirically that IVB/BYT don't support indirect > > addressing > > with doubles but it is not documented in the PRM. > > > > This patch applies the same sol

Re: [Mesa-dev] [PATCH] st/mesa: destroy pipe_context before destroying st_context

2017-01-23 Thread Nicolai Hähnle
Looks like there's a problem with the error path at the end of st_create_context_priv (line ~506): it calls st_destroy_context_priv which will now destroy the pipe, which then leads to a double-destroy by the caller. Just setting st->pipe = NULL; would be enough. Nicolai On 20.01.2017 20:00,

Re: [Mesa-dev] [PATCH 6/7] radeonsi: always set the TCL1_ACTION_ENA when invalidating L2

2017-01-23 Thread Nicolai Hähnle
On 20.01.2017 20:07, Marek Olšák wrote: From: Marek Olšák Some CIK-VI docs say this is the default behavior on SI. That doesn't answer whether it's also the default behavior on CIK-VI. Have you actually seen this fix anything? Seems reasonable to me anyway, so patches 1-6: Reviewed-by: Nic

Re: [Mesa-dev] [PATCH 7/7] radeonsi: handle first_non_void correctly in si_create_vertex_elements

2017-01-23 Thread Nicolai Hähnle
When does it happen that first_non_void < 0? Doesn't this require PIPE_FORMAT_NONE, and why would that occur? Nicolai On 20.01.2017 20:07, Marek Olšák wrote: From: Marek Olšák Cc: 17.0 --- src/gallium/drivers/radeonsi/si_state.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [Mesa-dev] [PATCH mesa] drirc: remove spurious tabs

2017-01-23 Thread Nicolai Hähnle
Pushed, thanks. On 23.01.2017 14:29, Eric Engestrom wrote: On Friday, 2017-01-06 19:08:39 +1100, Edward O'Callaghan wrote: Reviewed-by: Edward O'Callaghan Thanks; can you push this for me please? Cheers, Eric On 01/06/2017 08:06 AM, Eric Engestrom wrote: Signed-off-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] i965/blorp: Add also depth buffer to render cache

2017-01-23 Thread Pohjolainen, Topi
On Fri, Jan 20, 2017 at 08:40:50AM -0800, Jason Ekstrand wrote: >On Thu, Jan 19, 2017 at 11:48 PM, Pohjolainen, Topi ><[1]topi.pohjolai...@gmail.com> wrote: > > On Thu, Jan 19, 2017 at 01:39:49PM -0800, Jason Ekstrand wrote: > >On Thu, Jan 19, 2017 at 12:40 PM, Francisco Jere

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-23 Thread Andy Furniss
Christian König wrote: Ah, yes of course. If we delay creating the decoder we need to call begin_frame() again as well. Please review and/or test the attached patch. Andy I did understand you right that this is already a Tested-by from your side, isn't it? Yes, this patch seems OK. __

Re: [Mesa-dev] [PATCH] i965/blorp: Add also depth buffer to render cache

2017-01-23 Thread Jason Ekstrand
On Mon, Jan 23, 2017 at 7:47 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Fri, Jan 20, 2017 at 08:40:50AM -0800, Jason Ekstrand wrote: > >On Thu, Jan 19, 2017 at 11:48 PM, Pohjolainen, Topi > ><[1]topi.pohjolai...@gmail.com> wrote: > > > > On Thu, Jan 19, 2017 at 01

Re: [Mesa-dev] [PATCH 2/4] i965: Use a better guardband calculation.

2017-01-23 Thread Jason Ekstrand
On Mon, Jan 23, 2017 at 4:59 AM, Ilia Mirkin wrote: > On Mon, Jan 23, 2017 at 1:42 AM, Kenneth Graunke > wrote: > > + *ymin = MIN2(ndc_gb_ymin, ndc_gb_ymax); > > Should this be limited on the negative end of the range? > > > + *ymax = MIN2(MAX2(ndc_gb_ymin, ndc_gb_ymax), 16383); > > An

[Mesa-dev] [PATCH] st/mesa: destroy pipe_context before destroying st_context (v2)

2017-01-23 Thread Marek Olšák
From: Marek Olšák If radeonsi starts compiling an optimized shader variant asynchronously with a GL debug callback set and the application destroys the GL context, radeonsi crashes when trying to write shader stats into the debug output of a non-existent context after compilation, because st/mesa

Re: [Mesa-dev] [PATCH 6/7] radeonsi: always set the TCL1_ACTION_ENA when invalidating L2

2017-01-23 Thread Marek Olšák
On Mon, Jan 23, 2017 at 4:09 PM, Nicolai Hähnle wrote: > On 20.01.2017 20:07, Marek Olšák wrote: >> >> From: Marek Olšák >> >> Some CIK-VI docs say this is the default behavior on SI. That doesn't >> answer whether it's also the default behavior on CIK-VI. > > > Have you actually seen this fix an

Re: [Mesa-dev] [PATCH 7/7] radeonsi: handle first_non_void correctly in si_create_vertex_elements

2017-01-23 Thread Marek Olšák
On Mon, Jan 23, 2017 at 4:10 PM, Nicolai Hähnle wrote: > When does it happen that first_non_void < 0? Doesn't this require > PIPE_FORMAT_NONE, and why would that occur? R11G11B10_FLOAT, because it's in the category of "OTHER", meaning that it doesn't have any channel description. Marek _

Re: [Mesa-dev] [AMD] Screen flickering with 4K and RX 480, would be glad to help debugging

2017-01-23 Thread Romain Failliot
2017-01-23 0:06 GMT-05:00 Timothy Arceri : > I can confirm a similar problem. I have the same card and also got a 4K > monitor recently. For me I was running a game in windowed mode (F1 2015 > I think) for a very short amount of time and had some flickering, after > I closed the game gnome continu

Re: [Mesa-dev] [AMD] Screen flickering with 4K and RX 480, would be glad to help debugging

2017-01-23 Thread Romain Failliot
2017-01-23 12:43 GMT-05:00 Romain Failliot : > What is your workaround? For me it is to get back to 2516x1440, it seems > to solve the problem, or at least I've never seen a glitch when in this > resolution. > s/2516/2560/ -- Romain "Creak" Failliot _

[Mesa-dev] [PATCH 1/3] gallivm: (trivial) fix ddiv cpu implementation

2017-01-23 Thread sroland
From: Roland Scheidegger we can't use the cpu implementation of fdiv, as this one uses different lp_build_context, which causes assertion failure. Just use default fdiv action (there is no fast rcp for doubles which we could potentially use anyway). --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_

[Mesa-dev] [PATCH 3/3] tgsi: implement ddiv opcode

2017-01-23 Thread sroland
From: Roland Scheidegger softpipe (along with llvmpipe) claims to support arb_gpu_shader_fp64, so we really need to support that opcode. --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/ga

[Mesa-dev] [PATCH 2/3] gallivm: don't try to use fast rcp for fdiv

2017-01-23 Thread sroland
From: Roland Scheidegger The use of fast rcp instruction is disabled, and will always fall back to use a division instead (1 / x). Hence, if we get a division opcode, it doesn't make much sense trying to split that into rcp/mul. --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 4 +++- 1 file ch

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: refactor the GRBM counters path

2017-01-23 Thread Marek Olšák
On Fri, Jan 20, 2017 at 8:19 PM, Samuel Pitoiset wrote: > This will allow to expose more queries in order to know which > blocks are busy/idle. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeon/r600_gpu_load.c| 55 > ++- > src/gallium/drivers/rade

Re: [Mesa-dev] [PATCH 2/3] gallivm: don't try to use fast rcp for fdiv

2017-01-23 Thread Jose Fonseca
On 23/01/17 17:47, srol...@vmware.com wrote: From: Roland Scheidegger The use of fast rcp instruction is disabled, and will always fall back to use a division instead (1 / x). Hence, if we get a division opcode, it doesn't make much sense trying to split that into rcp/mul. --- src/gallium/auxi

Re: [Mesa-dev] [PATCH 2/2] gallium/radeon: add HUD queries for monitoring some hw blocks

2017-01-23 Thread Marek Olšák
On Fri, Jan 20, 2017 at 8:19 PM, Samuel Pitoiset wrote: > It's also possible to monitor them via performance counters but > the hardware can only use two counters simultaneously. It seems > easier to re-use the existing code which reads from MMIO instead > of writing a multi-pass approach. > > Sig

Re: [Mesa-dev] [PATCH v2] nir/spirv/glsl450: rewrite atan2 to deal with infinities

2017-01-23 Thread Francisco Jerez
"Juan A. Suarez Romero" writes: > On Sun, 2017-01-22 at 00:20 -0800, Francisco Jerez wrote: >> "Juan A. Suarez Romero" writes: >> >> > Rewrite atan2(y,x) to cover (+/-)INF values. >> > >> > This fixes several test cases in Vulkan CTS >> > (dEQP-VK.glsl.builtin.precision.atan2.*) >> > >> > v2:

[Mesa-dev] [PATCH] glsl: fix compile errors with mingw due to missing PRIx64 definitions

2017-01-23 Thread sroland
From: Roland Scheidegger define __STDC_FORMAT_MACROS and include (same as ir_builder_print_visitor.cpp already does). Otherwise, some mingw build errors out (since 8e7e1ae0365ddc7edb0d4d98250ab46728e6c14a and bbce1c538dc0cb8bf3769510283d11847dc07540 presumably) with: src/compiler/glsl/ir_print_

[Mesa-dev] [PATCH] mesa: Don't advertise GL_OES_read_format in core profile

2017-01-23 Thread Ian Romanick
From: Ian Romanick OpenGL ES implementations are not allowed to ship ARB extensions, and OpenGL implementations are not allowed to ship OES extensions. The functionality is also included in GL_ARB_ES2_compatibility. Ever OpenGL core-profile driver currently exposes both extensions. I don't kno

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-23 Thread Tobias Droste
Am Montag, 23. Januar 2017, 11:53:18 CET schrieb Jose Fonseca: > On 20/01/17 02:48, Emil Velikov wrote: > > On 19 January 2017 at 19:26, Tobias Droste wrote: > >> Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov: > >>> On 18 January 2017 at 18:12, Jose Fonseca wrote: > >> In or

[Mesa-dev] [PATCH] i965/blorp: Use the correct ISL format for combined depth/stencil

2017-01-23 Thread Jason Ekstrand
In brw_blorp_copyteximage, we use the format from the render buffer. This could be a combined depth/stencil format. In this case, we handle stencil properly but we give blorp the wrong ISL format. Specifically, we would give blorp ISL_FORMAT_R32G32B32A32_FLOAT which is the wrong size was causing

Re: [Mesa-dev] [PATCH] i965/blorp: Use the correct ISL format for combined depth/stencil

2017-01-23 Thread Ilia Mirkin
On Mon, Jan 23, 2017 at 2:42 PM, Jason Ekstrand wrote: > In brw_blorp_copyteximage, we use the format from the render buffer. > This could be a combined depth/stencil format. In this case, we handle > stencil properly but we give blorp the wrong ISL format. Specifically, > we would give blorp IS

Re: [Mesa-dev] [PATCH] i965/blorp: Use the correct ISL format for combined depth/stencil

2017-01-23 Thread Jason Ekstrand
On Mon, Jan 23, 2017 at 11:48 AM, Ilia Mirkin wrote: > On Mon, Jan 23, 2017 at 2:42 PM, Jason Ekstrand > wrote: > > In brw_blorp_copyteximage, we use the format from the render buffer. > > This could be a combined depth/stencil format. In this case, we handle > > stencil properly but we give bl

Re: [Mesa-dev] [PATCH] i965/blorp: Use the correct ISL format for combined depth/stencil

2017-01-23 Thread Ilia Mirkin
On Mon, Jan 23, 2017 at 2:58 PM, Jason Ekstrand wrote: > On Mon, Jan 23, 2017 at 11:48 AM, Ilia Mirkin wrote: >> >> On Mon, Jan 23, 2017 at 2:42 PM, Jason Ekstrand >> wrote: >> > In brw_blorp_copyteximage, we use the format from the render buffer. >> > This could be a combined depth/stencil form

[Mesa-dev] [PATCH] gallium/radeon: add a new HUD query for the number of mapped buffers

2017-01-23 Thread Samuel Pitoiset
Useful when debugging applications which map too much VRAM. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeon/r600_query.c | 4 src/gallium/drivers/radeon/r600_query.h | 1 + src/gallium/drivers/radeon/radeon_winsys.h| 1 + src/gallium/winsys/amdgpu/d

[Mesa-dev] [PATCH] radv: don't resubmit the same cs over and over while tracing

2017-01-23 Thread Grazvydas Ignotas
Fixes: 97dfff54 ("radv: Dump command buffer on hang.") Signed-off-by: Grazvydas Ignotas --- no commit access src/amd/vulkan/radv_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index d27a66c..337c733 10064

Re: [Mesa-dev] [PATCH] radv: don't resubmit the same cs over and over while tracing

2017-01-23 Thread Bas Nieuwenhuizen
Pushed, thanks. On Mon, Jan 23, 2017 at 10:16 PM, Grazvydas Ignotas wrote: > Fixes: 97dfff54 ("radv: Dump command buffer on hang.") > Signed-off-by: Grazvydas Ignotas > --- > no commit access > > src/amd/vulkan/radv_device.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --g

[Mesa-dev] [PATCH] vulkan: bump vulkan.h to 1.0.39 version

2017-01-23 Thread Dave Airlie
From: Dave Airlie This introduces a bunch of new extension defines. Signed-off-by: Dave Airlie --- include/vulkan/vulkan.h | 367 +++- 1 file changed, 365 insertions(+), 2 deletions(-) diff --git a/include/vulkan/vulkan.h b/include/vulkan/vulkan.h i

[Mesa-dev] [PATCH 2/2] radv: implement VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2

2017-01-23 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 38 +- src/amd/vulkan/radv_formats.c | 36 2 files changed, 73 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/

[Mesa-dev] [PATCH 1/2] vulkan: import latest registry for 1.0.39 extensions.

2017-01-23 Thread Dave Airlie
From: Dave Airlie Signed-off-by: Dave Airlie --- src/vulkan/registry/vk.xml | 450 - 1 file changed, 408 insertions(+), 42 deletions(-) diff --git a/src/vulkan/registry/vk.xml b/src/vulkan/registry/vk.xml index 4f358c2..779875b 100644 --- a/src/vulka

[Mesa-dev] [PATCH 2/6] anv: Add trivial support for TrimCommandPoolKHR

2017-01-23 Thread Jason Ekstrand
Our command buffers already efficiently use a global pool so trimming doesn't really need to do anything. --- src/intel/vulkan/anv_cmd_buffer.c | 8 1 file changed, 8 insertions(+) diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c index d882c18..3a23048

[Mesa-dev] [PATCH 5/6] anv: Return better errors from AllocateDescriptorSets

2017-01-23 Thread Jason Ekstrand
--- src/intel/vulkan/anv_descriptor_set.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index a5e65af..2d9734d 100644 --- a/src/intel/vulkan/anv_descriptor_set.c +++ b/src/intel/vulkan/anv_

[Mesa-dev] [PATCH 4/6] anv: Allow selecting the slice of a 3D image

2017-01-23 Thread Jason Ekstrand
As per VK_KHR_maintenance1, clients can render to a slice of a 3D image by creating a VK_IMAGE_VIEW_TYPE_2D view of it. --- src/intel/vulkan/anv_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 12cca67..1c

[Mesa-dev] [PATCH 3/6] anv: Report FORMAT_FEATURE_TRANSFER_SRC/DST_BIT_KHR

2017-01-23 Thread Jason Ekstrand
As of VK_KHR_maintenance1, these are supposed to be reported for any formats on which we support transfer operations. For us, this is anything that we can texture from. --- src/intel/vulkan/anv_formats.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/

[Mesa-dev] [PATCH 1/6] anv: Set viewport extents correctly when height is negative

2017-01-23 Thread Jason Ekstrand
As per VK_KHR_maintenance1, setting a negative height in the viewport can be used to get flipped coordinates. This is, aparently, very useful when porting D3D apps to Vulkan. All we need to do to support this is to make sure we actually set the min and max correctly. --- src/intel/vulkan/gen8_cm

[Mesa-dev] [PATCH 6/6] anv: Expose VK_KHR_maintenance1

2017-01-23 Thread Jason Ekstrand
--- src/intel/vulkan/anv_device.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index f80a36a..b24949c 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel/vulkan/anv_device.c @@ -263,7 +263,11 @@ static

[Mesa-dev] [PATCH 0/6] anv: Implement VK_KHR_maintenance1

2017-01-23 Thread Jason Ekstrand
This little series implements the new VK_KHR_maintenance1 extension. Most of the patches are pretty trivial by themselves but they all do different things so I split them out. I'm happy to squash the whole series if someone really wants me to. Jason Ekstrand (6): anv: Set viewport extents corr

Re: [Mesa-dev] [PATCH 1/2] vulkan: import latest registry for 1.0.39 extensions.

2017-01-23 Thread Jason Ekstrand
Acked-by: Jason Ekstrand I was just about to send this out... ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/6] anv: Return better errors from AllocateDescriptorSets

2017-01-23 Thread Ilia Mirkin
On Mon, Jan 23, 2017 at 5:12 PM, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_descriptor_set.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/src/intel/vulkan/anv_descriptor_set.c > b/src/intel/vulkan/anv_descriptor_set.c > index a5e65af..2d9734d 100644 >

[Mesa-dev] [PATCH] anv: Implement VK_KHR_get_physical_device_properties2

2017-01-23 Thread Chad Versace
Implement each vkFoo2KHR() by trivially passing it through to the original vkFoo(). --- I tested this patch with a little demo app, but I haven't ran any CTS tests with it. If CTS tests do exit (I'm searching for them now), I'll run them against this patch before pushing. src/intel/vulkan/anv_d

[Mesa-dev] [PATCH 5/6] anv: Return better errors from AllocateDescriptorSets

2017-01-23 Thread Jason Ekstrand
v2: I need to learn to compile-test my patches --- src/intel/vulkan/anv_descriptor_set.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index a5e65af..a4b7638 100644 --- a/src/intel/vulkan

Re: [Mesa-dev] [PATCH] anv: Implement VK_KHR_get_physical_device_properties2

2017-01-23 Thread Jason Ekstrand
On Mon, Jan 23, 2017 at 2:28 PM, Chad Versace wrote: > Implement each vkFoo2KHR() by trivially passing it through to the > original vkFoo(). > As I mentioned to Lionel when he wrote basically this exact same patch, I think that may be backwards. I can see two ways of doing this long-term: 1) I

[Mesa-dev] [Bug 97102] [dri][swr] stack overflow / infinite loop with GALLIUM_DRIVER=swr

2017-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97102 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added Resolution|--- |FIXED S

Re: [Mesa-dev] [PATCH 0/3] i965: IVB/BYT fp64 fixes

2017-01-23 Thread Matt Turner
Thanks Sam! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] i965: Use correct VertStride on align16 instructions.

2017-01-23 Thread Matt Turner
On Mon, Jan 23, 2017 at 2:59 AM, Samuel Iglesias Gonsálvez wrote: > On Fri, 2017-01-20 at 14:25 -0800, Francisco Jerez wrote: >> Matt Turner writes: >> >> > In commit c35fa7a, we changed the "width" of DF source registers to >> > 2, >> > which is conceptually fine. Unfortunately a VertStride of 2

[Mesa-dev] [PATCH 02/37] glsl: Switch to disable-by-default for the GLSL shader cache

2017-01-23 Thread Timothy Arceri
From: Carl Worth The shader cache is expected to be developed incrementally over a fairly long series of commits. For that period of instability, we require users to opt into the shader cache by setting: MESA_GLSL_CACHE_ENABLE=1 In the future, when the shader cache is complete, we can r

[Mesa-dev] [PATCH 04/37] glsl: add cache to ctx and add sha1 string fields

2017-01-23 Thread Timothy Arceri
From: Carl Worth We also add a flag for detecting shaders written to shader cache. V2: dont leak cache Signed-off-by: Timothy Arceri --- src/mesa/main/context.c | 6 ++ src/mesa/main/mtypes.h | 9 + 2 files changed, 15 insertions(+) diff --git a/src/mesa/main/context.c b/src/mes

[Mesa-dev] [PATCH 03/37] glsl: add new uniform fields to be used to restore state from cache

2017-01-23 Thread Timothy Arceri
From: Carl Worth Signed-off-by: Timothy Arceri --- src/compiler/glsl/link_uniforms.cpp | 4 src/mesa/main/mtypes.h | 4 2 files changed, 8 insertions(+) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index a450aa0..8930d26 100644

[Mesa-dev] Hardware agnostic on-disk shader cache patches

2017-01-23 Thread Timothy Arceri
The refactoring series is now pushed so here is the hardware agnostic shader cache patches. In future I want to change the way we track Mesa versions in patch 24 by creating a new cache directory for each Mesa version. This will help avoid unnecessary fallback recompiles and also allow 3rd parties

[Mesa-dev] [PATCH 06/37] util: add a disk_cache_remove() function

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This will be used to remove cache items created with old versions of Mesa or other invalid cache items from the cache. --- src/util/disk_cache.c | 22 ++ src/util/disk_cache.h | 12 2 files changed, 34 insertions(+) diff --git a/src/util/dis

[Mesa-dev] [PATCH 08/37] glsl: add initial implementation of shader cache

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This uses disk_cache.c to write out a serialization of various state that's required in order to successfully load and use a binary written out by a drivers backend, this state is referred to as "metadata" throughout the implementation. This initial version is intended to wo

[Mesa-dev] [PATCH 01/37] docs: add shader cache environment variables

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri Reviewed-by: Eric Anholt --- docs/envvars.html | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/envvars.html b/docs/envvars.html index 276cea3..2269f18 100644 --- a/docs/envvars.html +++ b/docs/envvars.html @@ -114,6 +114,17 @@ glGetString(GL_VERSION) f

[Mesa-dev] [PATCH 10/37] glsl: make use of on disk shader cache

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri The hash key for glsl metadata is a hash of the hashes of each GLSL source string. This commit uses the put_key/get_key support in the cache put the SHA-1 hash of the source string for each successfully compiled shader into the cache. This allows for early, optimistic return

[Mesa-dev] [PATCH 12/37] glsl: fix uniform remap table cache when explicit locations used

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index a6f8238..ff35f69 100644 --- a/src/compiler/glsl/shader_

[Mesa-dev] [PATCH 14/37] glsl: add shader cache support for samplers

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 4a144ea..1093726 100644 --- a/src/compiler/glsl/shader_cache.cpp +++ b/src/compiler/g

[Mesa-dev] [PATCH 07/37] glsl: add param to force shader recompile

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This will be used to skip checking the cache and force a recompile. --- src/compiler/glsl/glsl_parser_extras.cpp | 2 +- src/compiler/glsl/program.h | 2 +- src/compiler/glsl/standalone.cpp | 3 ++- src/mesa/main/shaderapi.c| 2 +- 4 file

[Mesa-dev] [PATCH 09/37] glsl: add helper to convert pointers to uint64_t

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This will be used to store all pointers in the cache as 64bit ints allowing us to avoid issues when a 32bit program reads a cached shader that was created by a 64bit application. --- src/compiler/glsl/shader_cache.h | 10 ++ 1 file changed, 10 insertions(+) diff --g

[Mesa-dev] [PATCH 11/37] glsl: Serialize three additional hash tables with program metadata

2017-01-23 Thread Timothy Arceri
From: Carl Worth The three additional tables are AttributeBindings, FragDataBindings, and FragDataIndexBindings. The first table (AttributeBindings) was identified as missing by trying to test the shader cache with a program that called glGetAttribLocation. Many thanks to Tapani Pälli , as it w

[Mesa-dev] [PATCH 16/37] glsl: add support for caching shaders with xfb qualifiers

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri For now this disables the shader cache when transform feedback is enabled via the GL API as we don't currently allow for it when generating the sha for the shader. --- src/compiler/glsl/linker.cpp | 14 - src/compiler/glsl/shader_cache.cpp | 108 ++

[Mesa-dev] [PATCH 13/37] glsl: add basic support for resource list to shader cache

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This initially adds support for simple uniforms and varyings. --- src/compiler/glsl/shader_cache.cpp | 121 + 1 file changed, 121 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index ff

[Mesa-dev] [PATCH 05/37] mesa: add new MESA_GLSL flag for printing shader cache debug info

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- docs/shading.html | 1 + src/mesa/main/mtypes.h| 1 + src/mesa/main/shaderapi.c | 2 ++ 3 files changed, 4 insertions(+) diff --git a/docs/shading.html b/docs/shading.html index b0ed249..e44035a 100644 --- a/docs/shading.html +++ b/docs/shading.html @@ -49,6

[Mesa-dev] [PATCH 19/37] glsl: add shader cache support for buffer blocks

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 163 + 1 file changed, 163 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 9ed1c4e..29fc70a 100644 --- a/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 17/37] glsl: add support for caching subroutines

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 107 + 1 file changed, 107 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 9bbbf1f..b5468a9 100644 --- a/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 18/37] glsl: store subroutine remap table in shader cache

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 57 ++ 1 file changed, 51 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index b5468a9..9ed1c4e 100644 --- a/src/compiler/glsl/s

[Mesa-dev] [PATCH 15/37] glsl: skip linking when current program has been retrieved from cache

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri The scenario is a program has been linked for the first time and we cache the program metadata, then glLinkProgram() is called for a second time. Since we will now retrieve the program metadata from cache we need to skip linking. --- src/compiler/glsl/shader_cache.cpp | 1 +

[Mesa-dev] [PATCH 20/37] glsl: add support for caching atomic buffers

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 89 ++ 1 file changed, 89 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 29fc70a..9db4f25 100644 --- a/src/compiler/glsl/shader_cache.cpp

[Mesa-dev] [PATCH 21/37] glsl: cache some more image metadata

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/shader_cache.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 9db4f25..358eb4f 100644 --- a/src/compiler/glsl/shader_cache.cpp +++ b/src/compiler/glsl/shad

[Mesa-dev] [PATCH 22/37] glsl: make uniform values helper available for use elsewhere

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/link_uniforms.cpp | 2 +- src/compiler/glsl/linker.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index 8930d26..41fd79a 100644 --- a/src/compi

[Mesa-dev] [PATCH 27/37] glsl: don't reference shader prog data during cache fallback

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri We already have a reference. --- src/compiler/glsl/linker.cpp | 3 ++- src/mesa/main/shaderobj.c| 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index fa9e154..d34ec97 100644 --- a/src/com

[Mesa-dev] [PATCH 26/37] glsl: make a copy of the shader source for use with cache fallback

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri A number of things can happen that change the shader source after it is compiled or linked. For example: - Source changed after it is first compiled - Source changed after linking - Shader detached after linking In order to be able to fallback to a full rebuild on a cache m

[Mesa-dev] [PATCH 28/37] glsl: don't lose uniform values when falling back to full compile

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri Here we skip the recreation of uniform storage if we are relinking after a cache miss. This is improtant because uniform values may have already been set by the application and we don't want to reset them. --- src/compiler/glsl/link_uniforms.cpp | 31 +++-

[Mesa-dev] [PATCH 24/37] glsl: track mesa version shader cache items were created with

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri Also remove cache item and fallback to full recompile if current Mesa version differs. V2: don't leak buffer --- src/compiler/glsl/shader_cache.cpp | 13 + 1 file changed, 13 insertions(+) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/sha

[Mesa-dev] [PATCH 23/37] glsl: cache uniform values

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri These may be lowered constant arrays or uniform values that we set before linking so we need to cache the actual uniform values. --- src/compiler/glsl/shader_cache.cpp | 33 + 1 file changed, 33 insertions(+) diff --git a/src/compiler/glsl/s

[Mesa-dev] [PATCH 25/37] mesa/glsl: add cache_fallback flag to gl_shader_program_data

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri This will allow us to skip certain things when falling back to a full recompile on a cache miss such as avoiding reinitialising uniforms. In this chage we use it to avoid reading the program metadata from the cache and skipping linking during a fallback. --- src/compiler/gl

[Mesa-dev] [PATCH 29/37] glsl: skip more uniform initialisation when doing fallback linking

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri We already pull these values from the metadata cache so no need to recreate them. --- src/compiler/glsl/linker.cpp | 20 src/mesa/main/shaderobj.c| 8 +--- 2 files changed, 17 insertions(+), 11 deletions(-) diff --git a/src/compiler/glsl/linker

[Mesa-dev] [PATCH 30/37] glsl: don't reprocess or clear UBOs on cache fallback

2017-01-23 Thread Timothy Arceri
From: Timothy Arceri --- src/compiler/glsl/linker.cpp | 62 +++- src/mesa/main/shaderobj.c| 16 +++- 2 files changed, 42 insertions(+), 36 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index 3271a19..705

Re: [Mesa-dev] [PATCH 4/6] configure.ac: Set and use HAVE_GALLIUM_LLVM define

2017-01-23 Thread Roland Scheidegger
Am 23.01.2017 um 20:39 schrieb Tobias Droste: > Am Montag, 23. Januar 2017, 11:53:18 CET schrieb Jose Fonseca: >> On 20/01/17 02:48, Emil Velikov wrote: >>> On 19 January 2017 at 19:26, Tobias Droste wrote: Am Mittwoch, 18. Januar 2017, 18:45:04 CET schrieb Emil Velikov: > On 18 January 2

  1   2   >