2017-02-09 1:57 GMT+01:00 Timothy Arceri :
> On Wed, 2017-02-08 at 21:35 +0100, Thomas Helland wrote:
>> I was cleaning up my local git repo, and came across this series.
>> Last time it was discussed was all the way back in April 2015.
>> Things looked pretty good back then, but we where seeing a
Hi Eric
2017-02-09 1:11 GMT+01:00 Eric Engestrom :
> CID: 1400128
> Signed-off-by: Eric Engestrom
> ---
> src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c
> b/src/gallium/drivers/et
Hi Eric
2017-02-09 1:11 GMT+01:00 Eric Engestrom :
> CID: 1400129
> Signed-off-by: Eric Engestrom
> ---
> src/gallium/drivers/etnaviv/etnaviv_context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_context.c
> b/src/gallium/drivers/
In case ctx->stream == NULL the fail label gets executed where
pctx gets dereferenced - too bad pctx is NULL in that case.
Caught by Coverity, reported to me by imirkin.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_context.c | 8
1 file changed, 4 insertions
This validation was added before the etnaviv drm driver landed in
the linux kernel. Due some pre-merge API changes we had to fix-up
this value but with a mainline kernel this is not a problem anymore.
Lets remove that validation which also gets rid of problem caught
by Coverity, reported to me by
Caught by Coverity, reported to me by imirkin.
Signed-off-by: Christian Gmeiner
---
src/gallium/drivers/etnaviv/etnaviv_texture.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_texture.c
b/src/gallium/drivers/etnaviv/etnaviv_texture.c
index c020fb2..1d32
On Wed, Feb 8, 2017 at 8:11 PM, Jason Ekstrand wrote:
> On Wed, Feb 8, 2017 at 6:27 PM, Jason Ekstrand
> wrote:
>
>> On Wed, Feb 8, 2017 at 5:34 PM, Nanley Chery
>> wrote:
>>
>>> On Thu, Feb 02, 2017 at 01:26:05PM -0800, Jason Ekstrand wrote:
>>> > In order to get good performance numbers for t
I don't know much about http vs. https here, but looks OK to me.
For the 3,
Reviewed-by: Brian Paul
On Wed, Feb 8, 2017 at 7:10 PM, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom
> ---
> docs/thanks.html | 11 +++
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --g
On Wed, Feb 8, 2017 at 6:27 PM, Jason Ekstrand wrote:
> On Wed, Feb 8, 2017 at 5:34 PM, Nanley Chery
> wrote:
>
>> On Thu, Feb 02, 2017 at 01:26:05PM -0800, Jason Ekstrand wrote:
>> > In order to get good performance numbers for this, I had to hack up the
>> > driver to whack wm_prog_data::uses_
From: Dave Airlie
It's legal to submit just semaphores with no command streams,
this patch fixes this case by emitting the empty cs, it also
handles the fence emission for this case better.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_device.c | 22 --
1 file changed,
On Wed, Feb 8, 2017 at 2:06 PM, Timothy Arceri wrote:
> ---
> src/util/disk_cache.c | 25 -
> 1 file changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c
> index 7691621..edfff73 100644
> --- a/src/util/disk_cache.c
> ++
On Wed, 8 Feb 2017 15:54:46 -0800
Jason Ekstrand wrote:
> On Wed, Feb 8, 2017 at 2:20 PM, Elie Tournier
> wrote:
>
> > Signed-off-by: Elie Tournier
> > ---
> > src/compiler/nir/nir_opt_loop_unroll.c | 10 +-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/c
On Wed, 8 Feb 2017 15:59:55 -0800
Jason Ekstrand wrote:
> On Wed, Feb 8, 2017 at 3:01 PM, Marek Olšák wrote:
>
> > I think this is good stuff. I'd gladly take it just for the
> > shader-db improvement.
> >
>
> Agreed. If it really did hurt minecraft before, we should try that
> again just t
On Wed, 8 Feb 2017 21:35:36 +0100
Thomas Helland wrote:
> I was cleaning up my local git repo, and came across this series.
> Last time it was discussed was all the way back in April 2015.
> Things looked pretty good back then, but we where seeing a smaller
> regression in CPU-bound scenarios as
I've have a number of emails go missing this morning just checking if
this email address is working with mesa-dev.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wed, Feb 8, 2017 at 5:34 PM, Nanley Chery wrote:
> On Thu, Feb 02, 2017 at 01:26:05PM -0800, Jason Ekstrand wrote:
> > In order to get good performance numbers for this, I had to hack up the
> > driver to whack wm_prog_data::uses_kill to true to emulate a discard and
> > used the Sascha "shado
Most of them already redirected to https anyway, so we might as well
avoid the redirection and the security implications by linking directly
to the right protocol.
Signed-off-by: Eric Engestrom
---
docs/README.WIN32 | 2 +-
docs/application-issues.html | 2 +-
docs/bugs.
Signed-off-by: Eric Engestrom
---
docs/relnotes/7.5.1.html | 2 +-
docs/relnotes/7.5.2.html | 2 +-
docs/relnotes/7.5.html | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/relnotes/7.5.1.html b/docs/relnotes/7.5.1.html
index cf5a5691de..5afd5c0abc 100644
--- a/docs/re
Signed-off-by: Eric Engestrom
---
docs/thanks.html | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/docs/thanks.html b/docs/thanks.html
index 685cb31e64..bca4b3424f 100644
--- a/docs/thanks.html
+++ b/docs/thanks.html
@@ -40,14 +40,9 @@
The
-http://www.mesa3d.o
On Thu, Feb 02, 2017 at 01:26:05PM -0800, Jason Ekstrand wrote:
> In order to get good performance numbers for this, I had to hack up the
> driver to whack wm_prog_data::uses_kill to true to emulate a discard and
> used the Sascha "shadowmapping" demo. Setting uses_kill to true dropped
> the frame
CID: 1400128
Signed-off-by: Eric Engestrom
---
src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c
b/src/gallium/drivers/etnaviv/etnaviv_screen.c
index 8f2882f573..e398629a42 100644
--- a/sr
From: Marek Olšák
---
src/gallium/auxiliary/util/u_upload_mgr.c | 32 ---
src/gallium/auxiliary/util/u_upload_mgr.h | 19 --
2 files changed, 51 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_upload_mgr.c
b/src/gallium/auxiliary/util/u_upload
From: Marek Olšák
v2: use const_uploader
Reviewed-by: Nicolai Hähnle (v1)
Tested-by: Edmondo Tommasina (v1)
---
src/mesa/state_tracker/st_atom_constbuf.c | 6 +++---
src/mesa/state_tracker/st_cb_bitmap.c | 4 ++--
src/mesa/state_tracker/st_cb_drawtex.c| 4 ++--
src/mesa/state_track
From: Marek Olšák
Reviewed-by: Christian König
Reviewed-by: Nicolai Hähnle
Tested-by: Edmondo Tommasina
---
src/gallium/auxiliary/vl/vl_compositor.c | 14 ++
src/gallium/auxiliary/vl/vl_compositor.h | 1 -
src/gallium/state_trackers/va/context.c | 4
3 files changed, 2 ins
CID: 1400129
Signed-off-by: Eric Engestrom
---
src/gallium/drivers/etnaviv/etnaviv_context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/etnaviv/etnaviv_context.c
b/src/gallium/drivers/etnaviv/etnaviv_context.c
index d767cd1f38..f5fa5c53ae 100644
--- a
From: Marek Olšák
also remove the BIND flags
Reviewed-by: Nicolai Hähnle
Tested-by: Edmondo Tommasina
---
src/gallium/drivers/r600/r600_state_common.c| 14 +-
src/gallium/drivers/radeon/r600_buffer_common.c | 6 --
src/gallium/drivers/radeon/r600_pipe_common.c | 17
From: Marek Olšák
Reviewed-by: Nicolai Hähnle
Tested-by: Edmondo Tommasina
---
src/gallium/auxiliary/util/u_vbuf.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_vbuf.c
b/src/gallium/auxiliary/util/u_vbuf.c
index 532e7c0..c26a9
Hi,
Since the last version, I added pipe_context::const_uploader and
documentation.
Changed patches: 1, 3, 9.
New patch: 11.
Please review.
Thanks,
Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/l
From: Marek Olšák
Reviewed-by: Nicolai Hähnle
Tested-by: Edmondo Tommasina
---
src/gallium/auxiliary/hud/hud_context.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/src/gallium/auxiliary/hud/hud_context.c
b/src/gallium/auxiliary/hud/hud_context.c
index a63579
From: Marek Olšák
Notes:
- make sure the default size is large enough to handle all state trackers
- pipe wrappers don't receive transfer calls from stream_uploader, because
pipe_context::stream_uploader points directly to the underlying driver's
stream_uploader (to keep it simple for now)
v
From: Marek Olšák
For lower memory usage and more efficient updates of the buffer residency
list. (e.g. if drivers keep seeing the same buffer for many consecutive
"add" calls, the calls can be turned into no-ops trivially)
v2: add const_uploader, add documentation
Reviewed-by: Nicolai Hähnle
From: Marek Olšák
Reviewed-by: Nicolai Hähnle
Tested-by: Edmondo Tommasina
---
src/gallium/auxiliary/util/u_blitter.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/src/gallium/auxiliary/util/u_blitter.c
b/src/gallium/auxiliary/util/u_blitter.c
index 45dc033.
From: Marek Olšák
Reviewed-by: Nicolai Hähnle
Tested-by: Edmondo Tommasina
---
src/gallium/auxiliary/indices/u_primconvert.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/src/gallium/auxiliary/indices/u_primconvert.c
b/src/gallium/auxiliary/indices/u_primco
From: Marek Olšák
Reviewed-by: Nicolai Hähnle
Tested-by: Edmondo Tommasina
---
src/gallium/auxiliary/util/u_upload_mgr.c | 9 +
src/gallium/auxiliary/util/u_upload_mgr.h | 7 +++
2 files changed, 16 insertions(+)
diff --git a/src/gallium/auxiliary/util/u_upload_mgr.c
b/src/galliu
Thanks Brian!
I would've used https for the links, but I'll just fix that later.
Series is:
Reviewed-by: Eric Engestrom
And pushed :)
On Wednesday, 2017-02-08 12:31:44 -0700, Brian Paul wrote:
> ---
> docs/intro.html | 42 +++---
> 1 file changed, 31 insert
On Wed, Feb 8, 2017 at 3:01 PM, Marek Olšák wrote:
> I think this is good stuff. I'd gladly take it just for the shader-db
> improvement.
>
Agreed. If it really did hurt minecraft before, we should try that again
just to be sure, but I like faster shader compilation.
> Marek
>
> On Wed, Feb 8
On Wed, Feb 8, 2017 at 2:20 PM, Elie Tournier
wrote:
> Signed-off-by: Elie Tournier
> ---
> src/compiler/nir/nir_opt_loop_unroll.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/src/compiler/nir/nir_opt_loop_unroll.c
> b/src/compiler/nir/nir_opt_loop_unroll.c
Am 07.02.2017 22:30, schrieb Heiko Przybyl:
When fixing the stalls on evergreen I introduced leaking of the useinfo
structure(s). Sorry. Instead of allocating a new object to hold 3
values
where only one is actually used, rework the list to just store the node
pointer. Thus no allocating and de
On Mon, Feb 6, 2017 at 7:42 PM, Timothy Arceri wrote:
> For the on-disk shader cache we want to be able to differentiate
> between a program that was linked and one that was loaded from cache.
> ---
> src/compiler/glsl/linker.cpp | 6 +++---
> src/compiler/glsl/standalone.cpp
On Mon, Feb 6, 2017 at 7:42 PM, Timothy Arceri wrote:
> From: Timothy Arceri
>
> This uses disk_cache.c to write out a serialization of various
> state that's required in order to successfully load and use a
> binary written out by a drivers backend, this state is referred to as
> "metadata" thro
I think this is good stuff. I'd gladly take it just for the shader-db
improvement.
Marek
On Wed, Feb 8, 2017 at 11:35 PM, Thomas Helland
wrote:
> 2017-02-08 22:07 GMT+01:00 Thomas Helland :
>> 2017-02-08 21:35 GMT+01:00 Thomas Helland :
>>> I was cleaning up my local git repo, and came across th
On Wed, Feb 8, 2017 at 8:37 PM, Nicolai Hähnle wrote:
> On 08.02.2017 20:17, Marek Olšák wrote:
>>
>> The no_sanitize attribute seems to be the most acceptable approach.
>
>
> I disagree. gcc produces the same code even with just -O, and the ?: version
> very clearly avoids undefined behavior. If
On Mon, Feb 6, 2017 at 7:42 PM, Timothy Arceri wrote:
> From: Timothy Arceri
>
> This initially adds support for simple uniforms and varyings.
> ---
> src/compiler/glsl/shader_cache.cpp | 121
> +
> 1 file changed, 121 insertions(+)
>
> diff --git a/src/compi
On Wed, Feb 8, 2017, at 23:33, Andres Rodriguez wrote:
>
>
> On 2017-02-08 12:19 PM, Bas Nieuwenhuizen wrote:
> > For allowing fast color clears in the main render targets of dota2.
> >
> > Signed-off-by: Bas Nieuwenhuizen
> > ---
> > src/amd/vulkan/radv_formats.c | 7 +--
> > 1 file chan
2017-02-08 22:07 GMT+01:00 Thomas Helland :
> 2017-02-08 21:35 GMT+01:00 Thomas Helland :
>> I was cleaning up my local git repo, and came across this series.
>> Last time it was discussed was all the way back in April 2015.
>> Things looked pretty good back then, but we where seeing a smaller
>> r
On 2017-02-08 12:19 PM, Bas Nieuwenhuizen wrote:
For allowing fast color clears in the main render targets of dota2.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_formats.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/radv_formats.c b/s
Bas Nieuwenhuizen writes:
> On Wed, Feb 8, 2017, at 11:25, Matt Turner wrote:
>> On Wed, Feb 8, 2017 at 12:31 AM, Timothy Arceri
>> wrote:
>> > On Tue, 2017-02-07 at 23:58 +0100, Matt Turner wrote:
>> >> On Tue, Feb 7, 2017 at 4:42 AM, Timothy Arceri > >> > wrote:
>> >> > This series adds suppor
Signed-off-by: Elie Tournier
---
src/compiler/nir/nir_opt_loop_unroll.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/compiler/nir/nir_opt_loop_unroll.c
b/src/compiler/nir/nir_opt_loop_unroll.c
index 37cbced43d..035a030239 100644
--- a/src/compiler/nir/nir_opt
---
src/util/disk_cache.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c
index 7691621..edfff73 100644
--- a/src/util/disk_cache.c
+++ b/src/util/disk_cache.c
@@ -400,11 +400,12 @@ static char *
get_cac
This fixes the following Vulkan CTS tests on Haswell:
- dEQP-VK.api.image_clearing.clear_color_image.1d_b4g4r4a4_unorm_pack16
- dEQP-VK.api.image_clearing.clear_color_image.2d_b4g4r4a4_unorm_pack16
- dEQP-VK.api.image_clearing.clear_color_image.3d_b4g4r4a4_unorm_pack16
---
src/intel/blorp/blorp_c
2017-02-08 21:35 GMT+01:00 Thomas Helland :
> I was cleaning up my local git repo, and came across this series.
> Last time it was discussed was all the way back in April 2015.
> Things looked pretty good back then, but we where seeing a smaller
> regression in CPU-bound scenarios as Eric found wit
The same rationale applies here as for the hash table.
Power of two size should give better performance,
and using the algorithm hash = sh + i/2 + i*i/2
should result in only distinct hash values when hitting collisions.
V4: Feedback from Jason Ekstrand
- Split cleanup of set_rehash into separa
This will allow us to remove the large static table and use a
power of two hash table size that we can compute on the fly.
We can use bitmasking instead of modulo to fit our hash in the table,
and it's less code.
By using the algorithm hash = sh + i/2 + i*i/2
we are guaranteed that all retries fro
This follows the same pattern as in the hash_table.
Reviewed-by: Jason Ekstrand
---
src/util/set.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/src/util/set.c b/src/util/set.c
index 99c04369c5..110f182244 100644
--- a/src/util/set.c
+++ b/src/util/set.c
@@ -196,12
I was cleaning up my local git repo, and came across this series.
Last time it was discussed was all the way back in April 2015.
Things looked pretty good back then, but we where seeing a smaller
regression in CPU-bound scenarios as Eric found with forcing software
rendering while running Minecraf
Add a test to exercise a worst case collision scenario
that may cause us to not be able to find an empty
slot in the table even though it is not full.
V2: Feedback from Emil Velikov
-Don't include code in the assert
---
src/util/tests/hash_table/collision.c | 14 ++
1 file changed
On Tue, Feb 07, 2017 at 04:53:51PM -0800, Jason Ekstrand wrote:
> On Tue, Feb 7, 2017 at 3:14 PM, Jason Ekstrand wrote:
>
> > Here's the new commit message:
> >
> > Vulkan doesn't have a stencilWriteEnable bit like it does for depth.
> > Instead, you have a stencil mask. Since the stenci
On 08.02.2017 21:07, Matthew Eggers wrote:
Hi Mesa Dev
I just browsed the Help Wanted section of your site:
https://www.mesa3d.org/helpwanted.html
I see that I could provide value here. Section 6: "set up an automated
system for grabbing the latest Mesa code and run tests (such as piglit)
then
Hi Mesa Dev
I just browsed the Help Wanted section of your site:
https://www.mesa3d.org/helpwanted.html
I see that I could provide value here. Section 6: "set up an automated
system for grabbing the latest Mesa code and run tests (such as piglit)
then report issues to the mailing list. " would be
Hi Lucas,
2017-02-08 12:36 GMT+01:00 Lucas Stach :
> Am Mittwoch, den 08.02.2017, 12:10 +0100 schrieb Christian Gmeiner:
>> Signed-off-by: Christian Gmeiner
>> ---
>> src/gallium/drivers/etnaviv/etnaviv_compiler.h | 2 ++
>> src/gallium/drivers/etnaviv/etnaviv_debug.h| 1 +
>> src/gallium/
On 08.02.2017 20:17, Marek Olšák wrote:
The no_sanitize attribute seems to be the most acceptable approach.
I disagree. gcc produces the same code even with just -O, and the ?:
version very clearly avoids undefined behavior. If we could get into the
habit of regularly running tests with the v
---
docs/contents.html | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/docs/contents.html b/docs/contents.html
index c2fe391..f56501f 100644
--- a/docs/contents.html
+++ b/docs/contents.html
@@ -98,8 +98,7 @@
Hosted by:
-http://sourceforge.net";
-target="_parent">sourcef
---
docs/intro.html | 42 +++---
1 file changed, 31 insertions(+), 11 deletions(-)
diff --git a/docs/intro.html b/docs/intro.html
index 6c91e3f..f7e3728 100644
--- a/docs/intro.html
+++ b/docs/intro.html
@@ -17,22 +17,31 @@
Introduction
-Mesa is an open-so
> Regresses performance:
> * Shadow of Mordor (with multiple game gfx settings & driver/HW?)
> * PCSX2 emulator
As Marek said the code still miss some optimization opportunities. FWIW, PCSX2
uses persistant PBO for texture transfer so it can be done without any sync. I
removed the sync (with a h
The no_sanitize attribute seems to be the most acceptable approach.
Marek
On Wed, Feb 8, 2017 at 8:14 PM, Roland Scheidegger wrote:
> So, I'd be happy with either changing the code to check for null
> pointers or using no_sanitize attribute. But it looks like others might
> not agree...
>
> Rola
On 08.02.2017 18:16, Roland Scheidegger wrote:
Am 08.02.2017 um 13:42 schrieb Nicolai Hähnle:
From: Nicolai Hähnle
TODO fill out caps in all drivers
---
src/gallium/docs/source/context.rst | 9 +
src/gallium/docs/source/screen.rst | 3 +++
src/gallium/include/pipe/p_context.h | 1
On Mon, Feb 6, 2017 at 7:42 PM, Timothy Arceri wrote:
> From: Carl Worth
>
> The three additional tables are AttributeBindings, FragDataBindings,
> and FragDataIndexBindings.
>
> The first table (AttributeBindings) was identified as missing by
> trying to test the shader cache with a program that
So, I'd be happy with either changing the code to check for null
pointers or using no_sanitize attribute. But it looks like others might
not agree...
Roland
Am 08.02.2017 um 19:21 schrieb Bartosz Tomczyk:
> I find ASAN and UBSAN extremely useful while debugging, but currently
> there is hundreds
https://bugs.freedesktop.org/show_bug.cgi?id=99010
Tobias Droste changed:
What|Removed |Added
Attachment #129410|0 |1
is obsolete|
From: Marek Olšák
not used separately
---
src/gallium/drivers/radeonsi/si_cp_dma.c | 3 +--
src/gallium/drivers/radeonsi/si_pipe.h | 7 ++-
src/gallium/drivers/radeonsi/si_state_draw.c | 15 +--
3 files changed, 8 insertions(+), 17 deletions(-)
diff --git a/src/galli
From: Marek Olšák
Before:
image_load v3, v[0:3] ...
After:
image_load v3, v[0:1] ...
---
src/gallium/drivers/radeonsi/si_shader.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shader.c
b/src/gallium/drivers/radeonsi/si_shader.
From: Marek Olšák
not necessary
---
src/gallium/drivers/radeonsi/si_pipe.h | 3 ---
src/gallium/drivers/radeonsi/si_state.c | 6 --
src/gallium/drivers/radeonsi/si_state_draw.c | 3 ++-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_
https://bugs.freedesktop.org/show_bug.cgi?id=99010
--- Comment #25 from Tobias Droste ---
(In reply to Emil Velikov from comment #23)
> (In reply to Tobias Droste from comment #21)
> > Created attachment 129410 [details] [review] [review]
> > Patch on top of Emils series
> >
> > Does the attache
Reviewed-by: Tobias Droste
Am Dienstag, 7. Februar 2017, 22:44:58 CET schrieb Emil Velikov:
> From: Emil Velikov
>
> Currently we have extra (somewhat questionable) modularity, such that
> one could build some parts with LLVM while others w/o.
>
> That is extremely fragile, error prone and req
On 02/08/2017 04:27 AM, Eric Engestrom wrote:
This page was severely out of date... essentially everything was wrong
by now :P
Eric Engestrom (4):
docs: add a note about the new version scheme
docs: remove dead 'beta' link
docs: fix unpacking instructions
docs: update package content
Am Mittwoch, 8. Februar 2017, 10:39:56 CET schrieb Emil Velikov:
> On 8 February 2017 at 01:03, Tobias Droste wrote:
> > Small comment below. Either way:
> >
> > Reviewed-by: Tobias Droste
> >
> > Am Dienstag, 7. Februar 2017, 22:44:47 CET schrieb Emil Velikov:
> >> From: Emil Velikov
> >>
>
Am Mittwoch, 8. Februar 2017, 10:49:47 CET schrieb Emil Velikov:
> On 8 February 2017 at 01:08, Tobias Droste wrote:
> > Does this cause problems if someone builds just intel classic drivers
> > without LLVM installed?
>
> The classic (with_dri_drivers) drivers are completely unrelated to
> anyth
On Wed, Feb 08, 2017 at 06:42:44PM +0100, Juan A. Suarez Romero wrote:
> On Wed, 2017-02-08 at 09:27 -0800, Nanley Chery wrote:
> > On Wed, Feb 08, 2017 at 01:31:54PM +0100, Juan A. Suarez Romero wrote:
> > > In pre-Broadwell devices, as B4G4R4A4 is not supported natively, we
> > > workaround it by
I find ASAN and UBSAN extremely useful while debugging, but currently there
is hundreds issues reported while running simple test. That make it very
hard to use it.
As Brian mention, first argument is never NULL. It can simplify changes
while still make UBSAN happy.
Roland, yes compiler will opt
From: Eric Anholt
We want to support glthread on GLES contexts with reasonable apps, and on
desktop for apps that use VBOs but haven't completely moved to core GL.
To do so, we have to deal with the "the user may or may not pass user
pointers to draw calls" problem.
---
src/mapi/glapi/gen/ARB_ba
From: Eric Anholt
This will let us support things like glBufferData() that should be
asynchronous.
---
src/mapi/glapi/gen/gl_marshal.py | 38 ++
src/mapi/glapi/gen/marshal_XML.py | 5 -
2 files changed, 34 insertions(+), 9 deletions(-)
diff --git a/src/
From: Eric Anholt
This avoids an extra pointer dereference in the marshalling functions,
which, with the instruction count doing in the low 30s, could actually
matter for main-thread performance.
---
src/mesa/main/glthread.c | 5 ++---
src/mesa/main/glthread.h | 8
2 files changed, 6 in
From: Marek Olšák
---
src/gallium/state_trackers/dri/dri_drawable.c | 11 +++
src/gallium/state_trackers/dri/dri_screen.c | 8 +---
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/src/gallium/state_trackers/dri/dri_drawable.c
b/src/gallium/state_trackers/dri/dri_d
From: Marek Olšák
---
src/gallium/include/state_tracker/st_api.h | 19 +++
src/gallium/state_trackers/dri/dri_context.c| 10 ++
src/gallium/state_trackers/dri/dri_drawable.c | 6 ++
src/gallium/state_trackers/dri/dri_screen.c | 21 +
From: Eric Anholt
I think I've fixed the last issue preventing trying glthread from being a
reasonable thing to do on compat contexts.
---
src/mesa/main/glthread.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/src/mesa/main/glthread.c b/src/mesa/main/glthread.c
index 3a7c753..27f01
From: Eric Anholt
---
src/mapi/glapi/gen/gl_marshal.py | 4
src/mapi/glapi/gen/marshal_XML.py | 9 ++---
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_marshal.py b/src/mapi/glapi/gen/gl_marshal.py
index 3b9868f..1a63343 100644
--- a/src/mapi/glapi
From: Eric Anholt
These don't actually read data out of the pointers, they set the
pointers (or offsets in a VBO) to be used in a later draw call.
v2: Don't forget glVertexAttribIPointer, and don't bother with annotations
on aliases.
---
src/mapi/glapi/gen/GL3x.xml | 2 +-
src/mapi/glapi
From: Eric Anholt
glBegin() swaps dispatch tables, and we don't have any code in place for
handling that in glthread (which also messes with dispatch tables), and I
don't particularly care to at this point.
---
src/mapi/glapi/gen/gl_API.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Paul Berry
This patch splits the context's CurrentDispatch pointer into two
pointers, CurrentClientDispatch, and CurrentServerDispatch, so that
when doing multithread marshalling, we can distinguish between the
dispatch table that's being used by the client (to serialize GL calls
into the m
From: Eric Anholt
The threading for GL core is in place, but there are so few applications
actually using a core GL context that it would be nice to extend support
back. However, some of the features of compat GL (particularly user
vertex arrays) would be so expensive to track state for that we
From: Paul Berry
---
src/mapi/glapi/gen/gl_API.xml | 3 +--
src/mesa/main/marshal.c | 33 +
src/mesa/main/marshal.h | 8
3 files changed, 42 insertions(+), 2 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_AP
From: Paul Berry
---
src/mapi/glapi/gen/gl_API.xml | 2 +-
src/mesa/Makefile.sources | 1 +
src/mesa/main/marshal.c | 123 ++
src/mesa/main/marshal.h | 10
4 files changed, 135 insertions(+), 1 deletion(-)
create mode 100644 src/
From: Marek Olšák
This reverts commit 4009d22b61e76850b1b725f4e491da05c2406fa4.
glthread needs it.
---
src/mesa/main/api_exec.h | 4
src/mesa/main/context.c | 10 +-
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/src/mesa/main/api_exec.h b/src/mesa/main/api_exec.h
From: Eric Anholt
v2: Rebase on the Begin/End changes, and just disable this feature on
non-GL-core.
---
src/mapi/glapi/gen/gl_marshal.py | 10 ++
src/mesa/Makefile.sources| 2 ++
src/mesa/main/glthread.c | 25 +
3 files changed, 37 insertions
From: Paul Berry
Several API functions require special treatment in order to be marshalled
to a background thread. Others can't be safely executed in a background
thread and need to be executed synchronously (e.g. since they return data
through a pointer argument).
This annotation will be used
From: Eric Anholt
Without doing some additional tracking, we won't know whether the data
will be immediate user data, or will be loaded from a PBO. The normal
teximage functions will be sync by default because they don't know up
front what the size of their image data is. But for compressed tex
From: Eric Anholt
Otherwise, for example, glDeleteBuffers(-1, &bo) gets you a segfault
instead of GL_INVALID_VALUE.
---
src/mapi/glapi/gen/gl_marshal.py | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/mapi/glapi/gen/gl_marshal.py b/src/mapi/glapi/gen/gl_marshal.py
index
From: Eric Anholt
---
src/egl/drivers/dri2/egl_dri2.c | 14 ++
src/egl/drivers/dri2/egl_dri2.h | 1 +
src/egl/drivers/dri2/platform_x11.c | 2 ++
src/egl/main/eglcontext.c | 2 +-
src/egl/main/eglcontext.h | 3 +++
5 files changed, 21 insertions(+), 1
From: Eric Anholt
v2: Keep an allocated buffer around instead of checking for one at the
start of every GL command. Inline the now-small space allocation
function.
v3: Remove duplicate !glthread->shutdown check, process remaining work
before shutdown.
v4: Fix leaks on destroy.
---
s
From: Paul Berry
---
src/mesa/drivers/common/driverfuncs.c | 3 +++
src/mesa/main/dd.h| 18 ++
2 files changed, 21 insertions(+)
diff --git a/src/mesa/drivers/common/driverfuncs.c
b/src/mesa/drivers/common/driverfuncs.c
index 6069138..642cd91 100644
--- a/s
1 - 100 of 208 matches
Mail list logo