[Mesa-dev] [PATCH 0/5] anv: Add support for VK_KHR_incremental_present

I've had these patches lying around for a while now waiting for the extension to go public. It went public, so here they are. This series adds all of the core window system bits for doing a trivial implementation on X11 and a real implementation on Wayland. I believe I've kept radv building with

[Mesa-dev] [PATCH 1/5] vulkan/wsi: Fix some line wrapping

--- src/vulkan/wsi/wsi_common.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/vulkan/wsi/wsi_common.h b/src/vulkan/wsi/wsi_common.h index 2482876..8227c1e 100644 --- a/src/vulkan/wsi/wsi_common.h +++ b/src/vulkan/wsi/wsi_common.h @@ -70,7 +70,10 @@ struct wsi_swapchai

[Mesa-dev] [PATCH 4/5] vulkan/wsi/wayland: Pass damage through to the compositor

--- src/vulkan/wsi/wsi_common_wayland.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulkan/wsi/wsi_common_wayland.c index 26a137c..78ddea2 100644 --- a/src/vulkan/wsi/wsi_common_wayland.c +++ b/src/vulkan/wsi/wsi_c

[Mesa-dev] [PATCH 3/5] vulkan/wsi: Plumb present regions through the common code

--- src/amd/vulkan/radv_wsi.c | 3 ++- src/intel/vulkan/anv_wsi.c | 3 ++- src/vulkan/wsi/wsi_common.h | 3 ++- src/vulkan/wsi/wsi_common_wayland.c | 3 ++- src/vulkan/wsi/wsi_common_x11.c | 3 ++- 5 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/a

[Mesa-dev] [PATCH 5/5] anv: Implement VK_KHR_incremental_present

--- src/intel/vulkan/anv_device.c | 6 +- src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vulkan/anv_wsi.c | 10 +- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 4e4f

Re: [Mesa-dev] [PATCH v2 6/6] nvc0: Add support for NV_fill_rectangle for the GM200+

I've pushed the amended series which fixed these trivial comments. Thanks for your contribution! On Thu, Mar 30, 2017 at 7:23 PM, Ilia Mirkin wrote: > On Thu, Mar 30, 2017 at 5:40 PM, Lyude wrote: >> This enables support for the GL_NV_fill_rectangle extension on the >> GM200+ for Desktop OpenGL.

Re: [Mesa-dev] [PATCH v2] intel: genxml: fix out of tree builds

On Fri, Mar 31, 2017 at 04:53:21PM +0100, Emil Velikov wrote: > On 31 March 2017 at 16:33, Lionel Landwerlin > wrote: > > On 31/03/17 16:21, Emil Velikov wrote: > >> > >> On 31 March 2017 at 14:40, Lionel Landwerlin > >> wrote: > >>> > >>> v2: use Emil's recommendation > >>> change rule to c

Re: [Mesa-dev] [PATCH v3 07/18] anv/allocator: Add a BO cache

On Wed 15 Mar 2017, Jason Ekstrand wrote: > This cache allows us to easily ensure that we have a unique anv_bo for > each gem handle. We'll need this in order to support multiple-import of > memory objects and semaphores. > > v2 (Jason Ekstrand): > - Reject BO imports if the size doesn't match t

[Mesa-dev] [Bug 97270] [softpipe] piglit ext_framebuffer_multisample-fast-clear GL_ARB_texture_rg single-sample regression

https://bugs.freedesktop.org/show_bug.cgi?id=97270 --- Comment #1 from Vinson Lee --- mesa: 150736b5c34fc07de296454b973ae72ede215ae2 (master 17.1.0-devel) Regression is still present. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

[Mesa-dev] [Bug 96254] [softpipe] piglit unsized-array-not-in-last-position regression

https://bugs.freedesktop.org/show_bug.cgi?id=96254 Vinson Lee changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 91100] [softpipe] piglit egl-create-pbuffer-surface regression

https://bugs.freedesktop.org/show_bug.cgi?id=91100 --- Comment #3 from Vinson Lee --- mesa: 150736b5c34fc07de296454b973ae72ede215ae2 (master 17.1.0-devel) Regression is still present. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

[Mesa-dev] [Bug 78318] [swrast] piglit glsl-kwin-blur-1 regression

https://bugs.freedesktop.org/show_bug.cgi?id=78318 --- Comment #7 from Vinson Lee --- mesa: 150736b5c34fc07de296454b973ae72ede215ae2 (master 17.1.0-devel) piglit glsl-kwin-blur-1 regression is still present. -- You are receiving this mail because: You are the assignee for the bug._

[Mesa-dev] [Bug 77288] [swrast] piglit glean glsl1 regression

https://bugs.freedesktop.org/show_bug.cgi?id=77288 --- Comment #8 from Vinson Lee --- mesa: 150736b5c34fc07de296454b973ae72ede215ae2 (master 17.1.0-devel) Regression is still present. -- You are receiving this mail because: You are the assignee for the bug._

[Mesa-dev] [Bug 97569] [swrast] piglit getteximage-formats regression

https://bugs.freedesktop.org/show_bug.cgi?id=97569 --- Comment #1 from Vinson Lee --- mesa: 150736b5c34fc07de296454b973ae72ede215ae2 (master 17.1.0-devel) Regression is still present. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

[Mesa-dev] [PATCH] st/mesa: Fix missing-braces warning.

CXX state_tracker/st_glsl_to_nir.lo state_tracker/st_glsl_to_nir.cpp:250:57: warning: suggest braces around initialization of subobject [-Wmissing-braces] nir_lower_wpos_ytransform_options wpos_options = {0}; ^

[Mesa-dev] [PATCH 1/4] anv/blorp: Align vertex buffers to 64B

This fixes issues seen when adding support for full 48-bit addresses. The 48-bit addresses themselves have nothing to do with it other than that it caused the kernel to place buffers slightly differently so they interacted differently with the caches. Cc: "13.0 17.0" --- src/intel/vulkan/genX_bl

[Mesa-dev] [PATCH 2/4] i916/blorp: Align vertex buffers to 64B

Cc: "13.0 17.0" --- src/mesa/drivers/dri/i965/genX_blorp_exec.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/genX_blorp_exec.c b/src/mesa/drivers/dri/i965/genX_blorp_exec.c index f9334ee..b6122a3 100644 --- a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 3/4] anv/cmd_buffer: Flush the VF cache at the top of all primaries

Cc: "13.0 17.0" --- src/intel/vulkan/genX_cmd_buffer.c | 12 1 file changed, 12 insertions(+) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 1ce549a..b5297f4 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_

[Mesa-dev] [PATCH 4/4] anv/blorp: Flush the texture cache in UpdateBuffer

Cc: "13.0 17.0" --- src/intel/vulkan/anv_blorp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c index 72a468a..f26f5e5 100644 --- a/src/intel/vulkan/anv_blorp.c +++ b/src/intel/vulkan/anv_blorp.c @@ -690,6 +690,11 @@ void anv_C

Re: [Mesa-dev] [PATCH] gallium: remove support for predicates from TGSI (v2)

Am 30.03.2017 um 14:42 schrieb Marek Olšák: > From: Marek Olšák > > Neved used. > > v2: gallivm: rename "pred" -> "exec_mask" > etnaviv: remove the cap > gallium: fix tgsi_instruction::Padding > --- Reviewed-by: Roland Scheidegger ___ mesa-

[Mesa-dev] [PATCH] amd/addrlib: second update for Vega10 + bug fixes

Hi, The patch is too big for the mailing list. It's here: https://cgit.freedesktop.org/~mareko/mesa/commit/?id=f32ab540216be1db54723f46a0838c04978b1479 If there are no comments, I'll push it on Tuesday. Marek ___ mesa-dev mailing list mesa-dev@lists.f

Re: [Mesa-dev] [PATCH] radv: fixup geometry clip emission since using the geom pass

Reviewed-by: Bas Nieuwenhuizen On Fri, Mar 31, 2017 at 10:58 PM, Dave Airlie wrote: > From: Dave Airlie > > Fixes: 2b35b60d: radv: move to using nir clip/cull merge pass. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_nir_to_llvm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 delet

[Mesa-dev] [PATCH] radv: fixup geometry clip emission since using the geom pass

From: Dave Airlie Fixes: 2b35b60d: radv: move to using nir clip/cull merge pass. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index d188ea6.

Re: [Mesa-dev] [PATCH 2/2] radeonsi: add load_image_desc()

For the series: Reviewed-by: Marek Olšák Marek On Thu, Mar 30, 2017 at 7:58 PM, Samuel Pitoiset wrote: > Similar to load_sampler_desc(). Same deal for bindless. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeonsi/si_shader.c | 45 > +--- > 1 f

Re: [Mesa-dev] [PATCH] radv: always do tess ring size calculations.

) On Fri, Mar 31, 2017 at 3:33 AM, Dave Airlie wrote: > From: Dave Airlie > > We could store these in the device, but it's probably > not that much overhead to recalculate them, this is needed > because we will emit the rings if the queue has them created > so we need to emit the register values

Re: [Mesa-dev] [PATCH 1/2] radv: add ia_multi_vgt_param tessellation support.

On Fri, Mar 31, 2017 at 2:44 AM, Dave Airlie wrote: > From: Dave Airlie > > This just ports the relevant radeonsi pieces. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/si_cmd_buffer.c | 31 ++- > 1 file changed, 30 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 04/10] radeonsi/gfx9: fix linear mipmap CPU access

On 31.03.2017 10:18, Marek Olšák wrote: On Fri, Mar 31, 2017 at 8:17 AM, Nicolai Hähnle wrote: On 30.03.2017 19:16, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 8 +++- src/gallium/drivers/radeon/radeon_winsys.h | 4 ++-- src/gallium/win

Re: [Mesa-dev] Fwd: [PATCH 1/1] glsl/blob: handle copy of NULL ptr in blob_write_string

On Fri, 31 Mar 2017 12:53:47 -0400 Ilia Mirkin wrote: > On Fri, Mar 31, 2017 at 6:12 AM, Gregory Hainaut > wrote: > >> Others have reported this crashing on Nouveau. I haven't seen the problem > >> on radeonsi or i965. > > > > Hello Timothy (sorry for the double mail, email is a complex tool:)

Re: [Mesa-dev] [PATCH v2 06/18] anv: Implement VK_KHX_external_memory

On Thu 30 Mar 2017, Jason Ekstrand wrote: > On Thu, Mar 30, 2017 at 11:27 AM, Chad Versace > wrote: > > > On Mon 13 Mar 2017, Jason Ekstrand wrote: > > > There's really nothing for us to do here. So long as the user doesn't > > > set any crazy environment variables such as INTEL_VK_HIZ=false, al

Re: [Mesa-dev] [PATCH] glsl: add null pointer check in print_without_declaration()

On 03/31/2017 12:01 AM, Nicolai Hähnle wrote: On 31.03.2017 05:21, Brian Paul wrote: To avoid/fix a segmentation fault when running the stand-alone GLSL compiler utility for cases such as the Mesa demos toyball test: glsl_compiler --dump-builder --version 120 CH11-toyball.vert CH11-toyball.frag

[Mesa-dev] [PATCH 15/19] radeonsi: emit TGSI_OPCODE_BALLOT

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 12eca9f..37346c6 100644 --- a/src/gallium/drivers/radeonsi/si_shade

[Mesa-dev] [PATCH 17/19] radeonsi: strengthen emit_optimization_barrier

From: Nicolai Hähnle LLVM will lift inline assembly out of if-else-blocks if both paths have the same inline assembly. Prevent this by adding an irrelevant unique text to the assembly. This requires the LLVM assembly parser to be initialized. Furthermore, allow forcing subsequent computations t

[Mesa-dev] [PATCH 05/19] glsl: add gl_SubGroup*ARB builtins

From: Nicolai Hähnle --- src/compiler/glsl/builtin_variables.cpp | 22 src/compiler/shader_enums.c | 7 src/compiler/shader_enums.h | 59 + 3 files changed, 88 insertions(+) diff --git a/src/compiler/glsl/builtin_variabl

[Mesa-dev] [PATCH 18/19] radeonsi: optimization barriers to work around LLVM deficiencies

From: Nicolai Hähnle Notably, llvm.amdgcn.readfirstlane and llvm.amdgcn.icmp may be hoisted out of loops or if/else branches in cases like if (cond) { v = readFirstInvocationARB(x); ... use v ... } else { v = readFirstInvocationARB(x); ... use v ... } ===> v = readFirstIn

[Mesa-dev] [PATCH 16/19] radeonsi: emit TGSI_OPCODE_READ_*

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 38 1 file changed, 38 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 37346c6..da1db4e 100644 --- a/src/gallium/drivers/rad

[Mesa-dev] [PATCH 04/19] glsl: add ARB_shader_ballot builtin functions

From: Nicolai Hähnle --- src/compiler/glsl/builtin_functions.cpp | 77 + 1 file changed, 77 insertions(+) diff --git a/src/compiler/glsl/builtin_functions.cpp b/src/compiler/glsl/builtin_functions.cpp index 683217d..5351b98 100644 --- a/src/compiler/glsl/builtin

[Mesa-dev] [PATCH 02/19] glsl: add ARB_shader_ballot enable

From: Nicolai Hähnle --- src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/compiler/glsl/glsl_parser_extras.cpp b/src/compiler/glsl/glsl_parser_extras.cpp index 8b5df3b..4629e78 100644 --- a/src/co

[Mesa-dev] [PATCH 19/19] radeonsi: enable ARB_shader_ballot

From: Nicolai Hähnle Require LLVM 5.0 or later because LLVM 4.0 is easily fooled into putting the lane select of llvm.amdgcn.readlane into a VGPR and then fails to continue to compile. --- docs/features.txt | 2 +- docs/relnotes/17.1.0.html | 1 + src/gallium/dr

[Mesa-dev] [PATCH 03/19] glsl: add ARB_shader_ballot operations

From: Nicolai Hähnle --- src/compiler/glsl/ir.cpp | 12 src/compiler/glsl/ir_expression_operation.py | 7 +++ src/compiler/glsl/ir_validate.cpp| 16 src/mesa/program/ir_to_mesa.cpp | 3 +++ 4 files changed, 38 inser

[Mesa-dev] [PATCH 11/19] st/mesa: enable ARB_shader_ballot

From: Nicolai Hähnle --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index a48c22e..5a97c31 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tra

[Mesa-dev] [PATCH 14/19] radeonsi: implement TGSI_SEMANTIC_SUBGROUP_*

From: Nicolai Hähnle 64-bit system values are stored as v2i32 to simplify the fetch logic. --- src/gallium/drivers/radeonsi/si_shader.c | 40 1 file changed, 40 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/s

[Mesa-dev] [PATCH 09/19] st/glsl_to_tgsi: implement ARB_shader_ballot builtin functions

From: Nicolai Hähnle --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 7da08da..e84c61a 100644 --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 13/19] radeonsi: support 64-bit system values

From: Nicolai Hähnle For simplicitly, always store system values as 32-bit values or arrays of 32-bit values. 64-bit values are unpacked and packed accordingly. --- .../drivers/radeonsi/si_shader_tgsi_setup.c| 24 ++ 1 file changed, 20 insertions(+), 4 deletions(-) d

[Mesa-dev] [PATCH 10/19] st/glsl_to_tgsi: implement ARB_shader_ballot system variables

From: Nicolai Hähnle --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index e84c61a..8c94f05 100644 --- a/src/mesa/state_tracker/st_glsl_to

[Mesa-dev] [PATCH 07/19] tgsi: add BALLOT/READ_* opcodes

From: Ilia Mirkin v2 (Nicolai): - BALLOT isn't per-channel - expand the documentation (also for VOTE_*) Signed-off-by: Ilia Mirkin Signed-off-by: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_info.c | 6 +-- src/gallium/docs/source/tgsi.rst | 67 +--

[Mesa-dev] [PATCH 12/19] radeonsi: bump RADEON_LLVM_MAX_SYSTEM_VALUES

From: Nicolai Hähnle ARB_shader_ballot introduces 7 new system values that can be used in all shader stages. --- src/gallium/drivers/radeonsi/si_shader.c | 2 ++ src/gallium/drivers/radeonsi/si_shader_internal.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/g

[Mesa-dev] [PATCH 01/19] mesa: add GL_ARB_shader_ballot boilerplate

From: Nicolai Hähnle --- src/mapi/glapi/registry/gl.xml | 2 +- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/registry/gl.xml b/src/mapi/glapi/registry/gl.xml index 3fc8863..9e2ff98 1

[Mesa-dev] [PATCH 08/19] tgsi: add SUBGROUP_* semantics

From: Ilia Mirkin v2: add documentation (Nicolai) Signed-off-by: Ilia Mirkin Signed-off-by: Nicolai Hähnle --- src/gallium/auxiliary/tgsi/tgsi_strings.c | 7 src/gallium/docs/source/tgsi.rst | 51 ++ src/gallium/include/pipe/p_shader_tokens.h | 7

[Mesa-dev] [PATCH 06/19] gallium: add PIPE_CAP_TGSI_BALLOT

From: Nicolai Hähnle --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH 00/19] ARB_shader_ballot implementation for radeonsi

Hi all, this series implements ARB_shader_ballot for radeonsi, tested against a bunch of piglit tests I just sent out as well as an upcoming test in the GLCTS. There are a bunch of gotchas in LLVM, and I'll probably be sending out those patches next week. The basic functionality is working even w

Re: [Mesa-dev] Fwd: [PATCH 1/1] glsl/blob: handle copy of NULL ptr in blob_write_string

On Fri, Mar 31, 2017 at 6:12 AM, Gregory Hainaut wrote: >> Others have reported this crashing on Nouveau. I haven't seen the problem on >> radeonsi or i965. > > Hello Timothy (sorry for the double mail, email is a complex tool:) ) > > Hum, tbh. I was quite surprised to hit this bug. I guess you s

Re: [Mesa-dev] [PATCH 1/1] glsl/blob: handle copy of NULL ptr in blob_write_string

On Fri, 31 Mar 2017 19:16:10 +1100 Timothy Arceri wrote: > > > On 31/03/17 18:00, gregory hainaut wrote: > > On Fri, 31 Mar 2017 08:24:36 +0200 > > Nicolai Hähnle wrote: > > > > Hello Nicolai > > > >> On 30.03.2017 21:55, Gregory Hainaut wrote: > >>> Typically happen when we want to copy an un

Re: [Mesa-dev] [PATCH v2] intel: genxml: fix out of tree builds

On 31 March 2017 at 16:33, Lionel Landwerlin wrote: > On 31/03/17 16:21, Emil Velikov wrote: >> >> On 31 March 2017 at 14:40, Lionel Landwerlin >> wrote: >>> >>> v2: use Emil's recommendation >>> change rule to closer to genxml/genX_bits.h >>> >>> Signed-off-by: Lionel Landwerlin >>> --- >>

Re: [Mesa-dev] [PATCH v2] intel: genxml: fix out of tree builds

On 31/03/17 16:21, Emil Velikov wrote: On 31 March 2017 at 14:40, Lionel Landwerlin wrote: v2: use Emil's recommendation change rule to closer to genxml/genX_bits.h Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.genxml.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [Mesa-dev] [PATCH v2] intel: genxml: fix out of tree builds

On 31 March 2017 at 14:40, Lionel Landwerlin wrote: > v2: use Emil's recommendation > change rule to closer to genxml/genX_bits.h > > Signed-off-by: Lionel Landwerlin > --- > src/intel/Makefile.genxml.am | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/intel/M

Re: [Mesa-dev] [PATCH 3/3] glsl: ir_explog_to_explog2 is no more

On Friday, March 31, 2017 3:58:58 AM PDT Erik Faye-Lund wrote: > Since 63684a9a ("glsl: Combine many instruction lowering passes > into one.", Thu Nov 18 2010), we no longer have anything called > ir_explog_to_explog2. So it's only confusing to have those > references there. > > Update with the ap

Re: [Mesa-dev] [PATCH 0/3] misc cleanups

Series is Reviewed-by: Nicolai Hähnle On 31.03.2017 12:57, Erik Faye-Lund wrote: Here's a few cleanup-patches I've had in my tree for a while, that I thought I should send upstream soon. Erik Faye-Lund (3): st/mesa: avoid aliasing violation in st_cb_perfmon.c gallium/docs: remove document

Re: [Mesa-dev] [PATCH] glsl: use -O0 optimization for builtin_functions.cpp with MinGW

On 31/03/17 04:23, Brian Paul wrote: Some versions of MinGW-w64 such as 5.3.1 and 6.2.0 produce bad code with -O2 or -O3 causing a random driver crash when running programs that use GLSL. Most Mesa demos in the glsl/ directory trigger the bug, but not the fragcoord.c test. Use a #pragma to forc

[Mesa-dev] [PATCH] radeonsi: add si_init_descriptor_list() helper

This will be used by bindless to initialize the descriptor for both samplers and images. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/s

Re: [Mesa-dev] [PATCH] intel: genxml: fix out of tree builds

On 31/03/17 14:23, Emil Velikov wrote: On 31 March 2017 at 11:42, Lionel Landwerlin wrote: The GENXML_XML_FILES variable was missing the "srcdir" prefix, thus the files won't be found on OOT builds. Side note: If you want to spare yourself such fun experiences, CC me on build related patches. O

[Mesa-dev] [PATCH v2] intel: genxml: fix out of tree builds

v2: use Emil's recommendation change rule to closer to genxml/genX_bits.h Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.genxml.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am index 05a12f8f77..e3

Re: [Mesa-dev] [PATCH] intel: genxml: fix out of tree builds

On 31 March 2017 at 11:42, Lionel Landwerlin wrote: The GENXML_XML_FILES variable was missing the "srcdir" prefix, thus the files won't be found on OOT builds. Side note: If you want to spare yourself such fun experiences, CC me on build related patches. Or poke me on IRC of course. > Signed-off

Re: [Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

On Fri, Mar 31, 2017 at 2:06 AM, Tapani Pälli wrote: > > > On 03/31/2017 08:24 AM, Rob Clark wrote: >> >> On Fri, Mar 31, 2017 at 12:22 AM, Tapani Pälli >> wrote: >>> >>> >>> >>> On 03/30/2017 05:57 PM, Emil Velikov wrote: On 30 March 2017 at 15:30, Tomasz Figa wrote: > >

Re: [Mesa-dev] [PATCH] i965: Fix GLX_MESA_query_renderer video memory on 32-bit.

Hi Ken, On 31 March 2017 at 00:28, Kenneth Graunke wrote: > On modern systems with 4GB apertures, the size in bytes is 4294967296, > or (1ull << 32). The kernel gives us the aperture size as a __u64, > which works out great. > > Unfortunately, libdrm "helpfully" returns the data as a size_t, whi

Re: [Mesa-dev] [PATCH] i965: Fix GLX_MESA_query_renderer video memory on 32-bit.

On Thu, Mar 30, 2017 at 06:48:38PM -0700, Kenneth Graunke wrote: > Looking again...libdrm_intel sets bufmgr_gem->gtt_size to > drm_i915_gem_get_aperture::aper_available_size - and uses that field > to -ENOSPC your execbuffers. drm_intel_get_aperture_sizes, and this > query, use drm_i915_gem_get_ap

Re: [Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

On 03/31/2017 10:12 AM, Tapani Pälli wrote: On 03/31/2017 09:06 AM, Tapani Pälli wrote: On 03/31/2017 08:24 AM, Rob Clark wrote: On Fri, Mar 31, 2017 at 12:22 AM, Tapani Pälli wrote: On 03/30/2017 05:57 PM, Emil Velikov wrote: On 30 March 2017 at 15:30, Tomasz Figa wrote: On Thu,

[Mesa-dev] [PATCH 3/3] glsl: ir_explog_to_explog2 is no more

Since 63684a9a ("glsl: Combine many instruction lowering passes into one.", Thu Nov 18 2010), we no longer have anything called ir_explog_to_explog2. So it's only confusing to have those references there. Update with the appropriate method, so people can grep for it the current tree if they encoun

[Mesa-dev] [PATCH 2/3] gallium/docs: remove documentation of removed arg

geom was removed in e968975 ("gallium: remove the geom_flags param from is_format_supported", Tue Mar 8 00:01:58 2011 +0100), but the documentation of it was left over. Let's bring the documentation up to date. Signed-off-by: Erik Faye-Lund --- src/gallium/docs/source/screen.rst | 2 -- 1 file c

[Mesa-dev] [PATCH 0/3] misc cleanups

Here's a few cleanup-patches I've had in my tree for a while, that I thought I should send upstream soon. Erik Faye-Lund (3): st/mesa: avoid aliasing violation in st_cb_perfmon.c gallium/docs: remove documentation of removed arg glsl: ir_explog_to_explog2 is no more src/gallium/docs/source

[Mesa-dev] [PATCH 1/3] st/mesa: avoid aliasing violation in st_cb_perfmon.c

Signed-off-by: Erik Faye-Lund --- src/mesa/state_tracker/st_cb_perfmon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_perfmon.c b/src/mesa/state_tracker/st_cb_perfmon.c index cd7fdc0..23d32dc 100644 --- a/src/mesa/state_tracker/st_cb_perf

Re: [Mesa-dev] [PATCH 1/2] st/mesa: add st_convert_image()

On 03/31/2017 08:11 AM, Nicolai Hähnle wrote: On 30.03.2017 18:55, Samuel Pitoiset wrote: Should be used by the state tracker when glGetImageHandleARB() is called in order to create a pipe_image_view template. v2: - make 'st' const - describe the function Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH v3 1/2] st/mesa: add st_convert_image()

Should be used by the state tracker when glGetImageHandleARB() is called in order to create a pipe_image_view template. v3: - move the comment to *.c v2: - make 'st' const - describe the function Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_atom_image.c | 106 +++

[Mesa-dev] [PATCH] intel: genxml: fix out of tree builds

Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.genxml.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am index 05a12f8f77..d780ca8470 100644 --- a/src/intel/Makefile.genxml.am +++ b/src/intel/Makefile.genxml.

Re: [Mesa-dev] [PATCH] i965/fs: Gracefully handle TXS on multisampled textures with no LOD

On 29/03/17 23:22, Jason Ekstrand wrote: This can happen for multisampled textures since they are never mipmapped and textureSize(gsampler2DMS*) does not take an LOD parameter. This fixes a shader validation error in the new Sascha deferredmultisampling demo. Bugzilla: https://bugs.freedesktop.

[Mesa-dev] Fwd: [PATCH 1/1] glsl/blob: handle copy of NULL ptr in blob_write_string

> Others have reported this crashing on Nouveau. I haven't seen the problem on > radeonsi or i965. Hello Timothy (sorry for the double mail, email is a complex tool:) ) Hum, tbh. I was quite surprised to hit this bug. I guess you save a pre-optimized shader in the cache. So it could depends on o

Re: [Mesa-dev] [PATCH 1/2] intel: genxml: compress all gen files into one

Hi, Sorry I broke the out of tree build. I have a fix coming up. Thanks, - Lionel On 31/03/17 02:06, Mike Lothian wrote: This prevents me building master PYTHONPATH=/var/tmp/portage/media-libs/mesa-/work/mesa-/src/compiler/nir /usr/bin/python2.7 /var/tmp/portage/media-libs/mesa-99

Re: [Mesa-dev] [PATCH v2 2/2] st/glsl_to_tgsi: fix 64-bit integer bit shifts

For the series: Reviewed-by: Marek Olšák Marek On Fri, Mar 31, 2017 at 10:03 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fix a bug that was caused by a type mismatch in the shfit count between > GLSL and TGSI. I briefly considered adjusting the TGSI semantics, but > since both LLVM a

[Mesa-dev] [PATCH V3] mesa: disable glthread when DEBUG_OUTPUT_SYNCHRONOUS is enabled

We could re-enable it also but I haven't tested that yet, and I'm not sure we care much anyway. V2: don't disable it from with the call itself. We need a custom marshalling function or we get stuck waiting for thread to finish. V3: tidy up redundant code copied from generated verion. ---

Re: [Mesa-dev] [PATCH 04/10] radeonsi/gfx9: fix linear mipmap CPU access

On Fri, Mar 31, 2017 at 8:17 AM, Nicolai Hähnle wrote: > On 30.03.2017 19:16, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeon/r600_texture.c | 8 +++- >> src/gallium/drivers/radeon/radeon_winsys.h | 4 ++-- >> src/gallium/winsys/amdgpu/drm/amdgpu_s

Re: [Mesa-dev] [PATCH 1/1] glsl/blob: handle copy of NULL ptr in blob_write_string

On 31/03/17 18:00, gregory hainaut wrote: On Fri, 31 Mar 2017 08:24:36 +0200 Nicolai Hähnle wrote: Hello Nicolai On 30.03.2017 21:55, Gregory Hainaut wrote: Typically happen when we want to copy an unnamed shader parameter in the shader cache. So this happens only when blob_write_string

[Mesa-dev] [PATCH v2 2/2] st/glsl_to_tgsi: fix 64-bit integer bit shifts

From: Nicolai Hähnle Fix a bug that was caused by a type mismatch in the shfit count between GLSL and TGSI. I briefly considered adjusting the TGSI semantics, but since both LLVM and AMD GCN require both arguments to be of the same type, it makes more sense to keep TGSI as-is -- it reflects the u

Re: [Mesa-dev] [PATCH 08/25] radv: add tessellation ring allocation support.

On 31 March 2017 at 16:59, Bas Nieuwenhuizen wrote: > On Thu, Mar 30, 2017 at 10:00 AM, Dave Airlie wrote: >> From: Dave Airlie >> >> This patch adds support for the offchip rings for storing >> tessellation factors and attribute data. >> >> It includes the register setup for the TF ring >> >> S

Re: [Mesa-dev] [RFC PATCH] egl/android: Dequeue buffers inside EGL calls

On 03/31/2017 09:06 AM, Tapani Pälli wrote: On 03/31/2017 08:24 AM, Rob Clark wrote: On Fri, Mar 31, 2017 at 12:22 AM, Tapani Pälli wrote: On 03/30/2017 05:57 PM, Emil Velikov wrote: On 30 March 2017 at 15:30, Tomasz Figa wrote: On Thu, Mar 30, 2017 at 11:17 PM, Emil Velikov wrote:

Re: [Mesa-dev] [PATCH 1/1] glsl/blob: handle copy of NULL ptr in blob_write_string

On Fri, 31 Mar 2017 08:24:36 +0200 Nicolai Hähnle wrote: Hello Nicolai > On 30.03.2017 21:55, Gregory Hainaut wrote: > > Typically happen when we want to copy an unnamed shader parameter > > in the shader cache. > > So this happens only when blob_write_string is called from nouveau? Sorry, I p

Re: [Mesa-dev] [PATCH 08/25] radv: add tessellation ring allocation support.

On Thu, Mar 30, 2017 at 10:00 AM, Dave Airlie wrote: > From: Dave Airlie > > This patch adds support for the offchip rings for storing > tessellation factors and attribute data. > > It includes the register setup for the TF ring > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_cmd_buf