[Mesa-dev] [PATCH v2 1/4] intel/isl: Add support for emitting depth/stencil/hiz

Reviewed-by: Topi Pohjolainen --- src/intel/Makefile.sources | 7 ++ src/intel/isl/isl.c| 93 +++ src/intel/isl/isl.h| 74 src/intel/isl/isl_emit_depth_stencil.c | 199

[Mesa-dev] [PATCH v2 0/4] intel/isl: Add support for emitting depth/stencil

This is mostly a re-send of previous patches. The two things that have changed over the last version is that the first patch is now actually correct for gen6. Prior to sending the original version, I tested it only with Vulkan which doesn't run on gen6 so a few fields were missed. This version

[Mesa-dev] [PATCH v2 3/4] intel/blorp: Emit 3DSTATE_STENCIL_BUFFER before HIER_DEPTH

We're about to replace blorp's emit code with ISL and it emits them in the other order. This makes diffing the aubs easier. --- src/intel/blorp/blorp_genX_exec.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/intel/blorp/blorp_genX_exec.h

[Mesa-dev] [PATCH v2 2/4] anv: Use ISL for emitting depth/stencil/hiz

Reviewed-by: Topi Pohjolainen --- src/intel/isl/isl.h| 2 +- src/intel/isl/isl_emit_depth_stencil.c | 2 +- src/intel/vulkan/genX_cmd_buffer.c | 218 ++--- 3 files changed, 41 insertions(+), 181 deletions(-)

[Mesa-dev] [PATCH v2 4/4] intel/blorp: Use ISL for emitting depth/stencil/hiz

Reviewed-by: Topi Pohjolainen --- src/intel/blorp/blorp_genX_exec.h | 119 +++--- 1 file changed, 33 insertions(+), 86 deletions(-) diff --git a/src/intel/blorp/blorp_genX_exec.h b/src/intel/blorp/blorp_genX_exec.h index

[Mesa-dev] [PATCH] intel/aubinator_error_decode: Stop decoding after MI_BATCH_BUFFER_END

--- src/intel/tools/aubinator_error_decode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_decode.c index 2e62369..244bef8 100644 --- a/src/intel/tools/aubinator_error_decode.c +++

[Mesa-dev] [Bug 100438] glsl/ir.cpp:1376: ir_dereference_variable::ir_dereference_variable(ir_variable*): Assertion `var != NULL' failed.

https://bugs.freedesktop.org/show_bug.cgi?id=100438 --- Comment #2 from Vinson Lee --- (In reply to Timothy Arceri from comment #1) > (In reply to Vinson Lee from comment #0) > > mesa: 7ee91af30074a4381e4353122319e3b4b3fe7cbd (master 17.1.0-devel) > > > > This GLSL shader

Re: [Mesa-dev] [PATCH] st/glx: Add awareness for multisample pixel formats to st/glx-xlib.

Thanks for the review. You’re correct, even though FBOs work, there are still a number of apps that rely on msaa in the winsys buffers and we don’t want to artificially exclude them. > On Apr 7, 2017, at 12:54 PM, Roland Scheidegger wrote: > > I'm not an expert on glx,

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

On 08/04/17 12:25, Timothy Arceri wrote: Actually please ignore that series for now. There are some issue with it I need to fix up. Sorry for the noise. V3 of the first patch should fix things up. On 08/04/17 11:13, Timothy Arceri wrote: On 08/04/17 02:25, Bartosz Tomczyk wrote: Patch

[Mesa-dev] [PATCH V3 1/9] mesa: create _mesa_attach_renderbuffer_without_ref() helper

This will be used to take ownership of freashly created renderbuffers, avoiding the need to call the reference function which requires locking. V2: dereference any existing fb attachments and actually attach the new rb. v3: split out validation and attachment type/complete setting into a

[Mesa-dev] [PATCH V2 1/9] mesa: create _mesa_attach_renderbuffer_without_ref() helper

This will be used to take ownership of freashly created renderbuffers, avoiding the need to call the reference function which requires locking. V2: dereference any existing fb attachments and actually attach the new rb. --- src/mesa/main/renderbuffer.c | 23 +--

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

Actually please ignore that series for now. There are some issue with it I need to fix up. On 08/04/17 11:13, Timothy Arceri wrote: On 08/04/17 02:25, Bartosz Tomczyk wrote: Patch didn't fix all leaks. There's one more still reported by ASAN: Direct leak of 2112 byte(s) in 12 object(s)

Re: [Mesa-dev] [PATCH 1/9] mesa: create _mesa_attach_renderbuffer_without_ref() helper

On 08/04/17 11:04, Timothy Arceri wrote: This will be used to take ownership of freashly created renderbuffers, avoiding the need to call the reference function which requires locking. --- src/mesa/main/renderbuffer.c | 19 +-- src/mesa/main/renderbuffer.h | 5 + 2 files

Re: [Mesa-dev] [PATCH 2/9] i915: take ownership rather than adding reference for new renderbuffers

Sorry the below change was meant to be squashed into the previous patch. Fixed locally. --- a/src/mesa/main/renderbuffer.c +++ b/src/mesa/main/renderbuffer.c @@ -106,23 +106,23 @@ _mesa_delete_renderbuffer(struct gl_context *ctx, struct gl_renderbuffer *rb) /** * Attach a renderbuffer

[Mesa-dev] [Bug 100303] Adding a single, meaningless if-else to a shader source leads to different image

https://bugs.freedesktop.org/show_bug.cgi?id=100303 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

On 08/04/17 02:25, Bartosz Tomczyk wrote: Patch didn't fix all leaks. There's one more still reported by ASAN: Direct leak of 2112 byte(s) in 12 object(s) allocated from: #0 0x7fe18d168800 in calloc (/usr/lib/clang/3.9.1/lib/linux/libclang_rt.asan-x86_64.so

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

On 08/04/17 02:03, Brian Paul wrote: On 04/06/2017 03:55 PM, Timothy Arceri wrote: We don't need to call _mesa_reference_renderbuffer() for the first assignment as refCount starts at 1. For swrast we work around the fact we will indirectly call _mesa_reference_renderbuffer() by resetting

[Mesa-dev] [PATCH 4/9] nouveau: take ownership rather than adding reference for new renderbuffers

This avoids locking in the reference calls and fixes a leak after the RefCount initialisation was change from 0 to 1. Fixes: 32141e53d1520 (mesa: tidy up renderbuffer RefCount initialisation) --- src/mesa/drivers/dri/nouveau/nouveau_screen.c | 10 +- 1 file changed, 5 insertions(+), 5

[Mesa-dev] [PATCH 7/9] osmesa: tidy up renderbuffer refCount initialisation

32141e53d1520 changed _mesa_init_renderbuffer() to set it to 1 for us. --- src/mesa/drivers/osmesa/osmesa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/osmesa/osmesa.c b/src/mesa/drivers/osmesa/osmesa.c index 356ba71..68fca3e 100644 --- a/src/mesa/drivers/osmesa/osmesa.c

[Mesa-dev] [PATCH 9/9] mesa/st: take ownership rather than adding reference for new renderbuffers

This avoids locking in the reference calls and fixes a leak after the RefCount initialisation was change from 0 to 1. Fixes: 32141e53d1520 (mesa: tidy up renderbuffer RefCount initialisation) --- src/mesa/state_tracker/st_manager.c | 21 - 1 file changed, 16 insertions(+), 5

[Mesa-dev] [PATCH 8/9] x11: take ownership rather than adding reference for new renderbuffers

This avoids locking in the reference calls and fixes a leak after the RefCount initialisation was change from 0 to 1. Fixes: 32141e53d1520 (mesa: tidy up renderbuffer RefCount initialisation) --- src/mesa/drivers/x11/xm_api.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 1/9] mesa: create _mesa_attach_renderbuffer_without_ref() helper

This will be used to take ownership of freashly created renderbuffers, avoiding the need to call the reference function which requires locking. --- src/mesa/main/renderbuffer.c | 19 +-- src/mesa/main/renderbuffer.h | 5 + 2 files changed, 22 insertions(+), 2 deletions(-)

[Mesa-dev] [PATCH 5/9] radeon: take ownership rather than adding reference for new renderbuffers

This avoids locking in the reference calls and fixes a leak after the RefCount initialisation was change from 0 to 1. Fixes: 32141e53d1520 (mesa: tidy up renderbuffer RefCount initialisation) --- src/mesa/drivers/dri/radeon/radeon_screen.c | 10 +- 1 file changed, 5 insertions(+), 5

[Mesa-dev] [PATCH 6/9] swrast: take ownership rather than adding reference for new renderbuffers

This avoids locking in the reference calls and fixes a leak after the RefCount initialisation was change from 0 to 1. Fixes: 32141e53d1520 (mesa: tidy up renderbuffer RefCount initialisation) --- src/mesa/drivers/dri/swrast/swrast.c | 6 -- src/mesa/swrast/s_renderbuffer.c | 17

[Mesa-dev] [PATCH 2/9] i915: take ownership rather than adding reference for new renderbuffers

This avoids locking in the reference calls and fixes a leak after the RefCount initialisation was change from 0 to 1. Fixes: 32141e53d1520 (mesa: tidy up renderbuffer RefCount initialisation) --- src/mesa/drivers/dri/i915/intel_screen.c | 9 + src/mesa/main/renderbuffer.c | 6

[Mesa-dev] [PATCH 3/9] i965: take ownership rather than adding reference for new renderbuffers

This avoids locking in the reference calls and fixes a leak after the RefCount initialisation was change from 0 to 1. Fixes: 32141e53d1520 (mesa: tidy up renderbuffer RefCount initialisation) --- src/mesa/drivers/dri/i965/intel_screen.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[Mesa-dev] Mesa master: 'current' 'git fsck' version catching content which was always bad but not reported before

Hello all, 'current' git version here: git version 2.12.2 https://github.com/collectd/collectd/issues/2115 Comment from: philpennock commented on 27 Dec 2016 [-] This is a git fsck change dating from around git 2.5ish, catching content which was always bad but not reported before. Anyone not

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

On Fri, Apr 7, 2017 at 5:01 PM, Nanley Chery wrote: > On Fri, Apr 07, 2017 at 12:55:53PM -0700, Jason Ekstrand wrote: > > We tend to try to reduce the number of allocation calls the Vulkan > > driver uses by doing a single allocation whenever possible for a data > >

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

On Fri, Apr 07, 2017 at 12:55:53PM -0700, Jason Ekstrand wrote: > We tend to try to reduce the number of allocation calls the Vulkan > driver uses by doing a single allocation whenever possible for a data > structure. While this has certain downsides (usually code complexity), > it does mean

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

On Fri, Apr 07, 2017 at 04:30:49PM -0700, Jason Ekstrand wrote: >On Fri, Apr 7, 2017 at 3:19 PM, Chris Wilson <[1]ch...@chris-wilson.co.uk> >wrote: > > On Fri, Apr 07, 2017 at 02:41:13PM -0700, Jason Ekstrand wrote: > >    On Fri, Apr 7, 2017 at 1:26 PM, Chris Wilson >

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

On Fri, Apr 7, 2017 at 3:19 PM, Chris Wilson wrote: > On Fri, Apr 07, 2017 at 02:41:13PM -0700, Jason Ekstrand wrote: > >On Fri, Apr 7, 2017 at 1:26 PM, Chris Wilson <[1] > ch...@chris-wilson.co.uk> > >wrote: > > > > On Fri, Apr 07, 2017 at 12:55:53PM

Re: [Mesa-dev] Meson mesademos (Was: [RFC libdrm 0/2] Replace the build system with meson)

Quoting Jose Fonseca (2017-03-30 15:19:31) > > Cool. BTW, another alternative (for things like LLVM) would be to > chain build systems (ie, have a wrap that builds LLVM invoking CMake) > > Jose > I have no idea whether chaining would work or not, that would be an interesting thing to try.

Re: [Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-04-07 23:56 GMT+02:00 Marek Olšák : > On Fri, Apr 7, 2017 at 6:54 PM, Gustaw Smolarczyk > wrote: >> 2017-04-07 16:31 GMT+02:00 Marek Olšák : >>> On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk >>> wrote:

[Mesa-dev] [PATCH] radeonsi: fix gl_BaseVertex value in non-indexed draws

From: Nicolai Hähnle gl_BaseVertex is supposed to be 0 in non-indexed draws. Unfortunately, the way they're implemented, the VGT always generates indices starting at 0, and the VS prolog adds the start index. There's a VGT_INDX_OFFSET register which causes the VGT to

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

On Fri, Apr 07, 2017 at 02:41:13PM -0700, Jason Ekstrand wrote: >On Fri, Apr 7, 2017 at 1:26 PM, Chris Wilson <[1]ch...@chris-wilson.co.uk> >wrote: > > On Fri, Apr 07, 2017 at 12:55:53PM -0700, Jason Ekstrand wrote: > > +#define _ANV_MULTIALLOC_UPDATE_POINTER(_i) \ > > +   

Re: [Mesa-dev] [PATCH 11/14] mesa/main: Maintain compressed TexEnv Combine state.

On Fri, Apr 7, 2017 at 7:04 PM, Gustaw Smolarczyk wrote: > 2017-04-07 16:40 GMT+02:00 Marek Olšák : >> On Fri, Apr 7, 2017 at 4:35 PM, Marek Olšák wrote: >>> On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk >>>

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

On Fri, Apr 7, 2017 at 1:26 PM, Chris Wilson wrote: > On Fri, Apr 07, 2017 at 12:55:53PM -0700, Jason Ekstrand wrote: > > We tend to try to reduce the number of allocation calls the Vulkan > > driver uses by doing a single allocation whenever possible for a data > >

[Mesa-dev] [Mesa-dev,kmscube 07/10] gst-decoder.c: minor cleanup

Signed-off-by: Carlos Rafael Giani --- gst-decoder.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/gst-decoder.c b/gst-decoder.c index d1cb18c..768aa1b 100644 --- a/gst-decoder.c +++ b/gst-decoder.c @@ -42,6 +42,8 @@

[Mesa-dev] [Mesa-dev,kmscube 06/10] gst-decoder.c: add bus watch

The bus watch is useful for logging state changes, printing out info/warning/error messages and handling common GStreamer activities like latency redistribution and state change requests (that are sent by elements since they are not allowed to directly change the state). State changes and error

[Mesa-dev] [Mesa-dev, kmscube 10/10] gst-decoder.c: improve buffer_to_image() function

* Make EGL image attribute specification code more generic, and not specific to certain pixel formats, implicitely gaining support for YUY2 * Better handling of gstbuffers with multiple memory blocks * Print out more information about the stream * Use the GST_VIDEO_INFO_* macros instead of

[Mesa-dev] [Mesa-dev, kmscube 04/10] gst-decoder.c: look at the caps event instead of the allocation query

Signed-off-by: Carlos Rafael Giani --- gst-decoder.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/gst-decoder.c b/gst-decoder.c index fd28201..51304a2 100644 --- a/gst-decoder.c +++ b/gst-decoder.c @@ -63,24 +63,23 @@ static

[Mesa-dev] [Mesa-dev, kmscube 09/10] gst-decoder.c: Improve synchronicity of video output

sync=false causes a sink to output data as fast as it can. This explains why without max-buffers=2 the pipeline used to use up 100's of MB of buffers. Instead, set sync to true, and enable frame dropping, to make sure the video playback speed remains intact. Signed-off-by: Carlos Rafael Giani

[Mesa-dev] [Mesa-dev, kmscube 02/10] add "kmscube" GStreamer debug category

Without this, the various GST_* log macros won't output anything. To enable, add "kmscube:" to the GST_DEBUG environment variable. Example: GST_DEBUG=kmscube:5 Signed-off-by: Carlos Rafael Giani --- gst-decoder.c | 3 +++ kmscube.c | 4 +++- 2 files changed, 6

[Mesa-dev] [Mesa-dev, kmscube 05/10] gst-decoder.c: Use element factory name to detect V4L2 video decoder

Signed-off-by: Carlos Rafael Giani --- gst-decoder.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/gst-decoder.c b/gst-decoder.c index 51304a2..05d73b7 100644 --- a/gst-decoder.c +++ b/gst-decoder.c @@ -115,15 +115,24 @@

[Mesa-dev] [Mesa-dev, kmscube 03/10] gst-decoder.c: add support for YUY2 pixel format

This format is used for example by the i.MX6 CODA hardware video codec Signed-off-by: Carlos Rafael Giani --- gst-decoder.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gst-decoder.c b/gst-decoder.c index 22dc068..fd28201 100644 --- a/gst-decoder.c +++

[Mesa-dev] [Mesa-dev, kmscube 01/10] output more and improved information about EGL and OpenGL ES 2.x

Signed-off-by: Carlos Rafael Giani --- common.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/common.c b/common.c index 4bf3c5a..4d29eef 100644 --- a/common.c +++ b/common.c @@ -97,9 +97,12 @@ int init_egl(struct egl *egl, const

[Mesa-dev] [Mesa-dev, kmscube 08/10] gst-decoder.c: use a custom appsink subclass to make sure videometa exists

Signed-off-by: Carlos Rafael Giani --- Makefile.am | 2 +- gst-decoder.c | 20 - gst-video-appsink.c | 126 gst-video-appsink.h | 31 + kmscube.c | 2 + 5 files

Re: [Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

On Fri, Apr 07, 2017 at 12:55:53PM -0700, Jason Ekstrand wrote: > We tend to try to reduce the number of allocation calls the Vulkan > driver uses by doing a single allocation whenever possible for a data > structure. While this has certain downsides (usually code complexity), > it does mean

[Mesa-dev] [PATCH v3 5/6] anv/pass: Record required pipe flushes

--- src/intel/vulkan/anv_pass.c| 88 ++ src/intel/vulkan/anv_private.h | 2 + 2 files changed, 90 insertions(+) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 15c4275..dcd9aaf 100644 --- a/src/intel/vulkan/anv_pass.c +++

[Mesa-dev] [PATCH v3 6/6] anv: Use subpass dependencies for flushes

Instead of figuring it all out ourselves, just use the information given to us by the client. --- src/intel/vulkan/anv_blorp.c | 88 -- src/intel/vulkan/genX_cmd_buffer.c | 10 + 2 files changed, 18 insertions(+), 80 deletions(-) diff --git

[Mesa-dev] [PATCH v3 2/6] anv: Add a helper for doing mass allocations

We tend to try to reduce the number of allocation calls the Vulkan driver uses by doing a single allocation whenever possible for a data structure. While this has certain downsides (usually code complexity), it does mean error handling and cleanup is much easier. This commit adds a nice little

[Mesa-dev] [PATCH v3 3/6] anv/descriptor_set: Use anv_multialloc for descriptor set layouts

--- src/intel/vulkan/anv_descriptor_set.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index 56a08ce..4797c1e 100644 --- a/src/intel/vulkan/anv_descriptor_set.c +++

[Mesa-dev] [PATCH v3 4/6] anv/pass: Use anv_multialloc for allocating the anv_pass

--- src/intel/vulkan/anv_pass.c| 106 + src/intel/vulkan/anv_private.h | 1 - 2 files changed, 44 insertions(+), 63 deletions(-) diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c index 4a1a340..15c4275 100644 ---

[Mesa-dev] [PATCH v3 1/6] anv: Add helpers for converting access flags to pipe bits

--- src/intel/vulkan/anv_private.h | 59 ++ src/intel/vulkan/genX_cmd_buffer.c | 48 ++- 2 files changed, 62 insertions(+), 45 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index

[Mesa-dev] [Bug 98502] Delay when starting firefox, thunderbird or chromium and dmesg spam

https://bugs.freedesktop.org/show_bug.cgi?id=98502 --- Comment #26 from Eugene Shalygin --- (In reply to Eugene Shalygin from comment #25) > Just found that dGPU wakes up when I connect an Android phone via USB. No, any USB device makes that. kernel

Re: [Mesa-dev] [PATCH v3] glsl/blob: avoid NULL ptr in blob_write_string/blob_read_string

On Thu, 6 Apr 2017 00:21:19 +0200 gregory hainaut wrote: > On Wed, 5 Apr 2017 14:22:00 -0400 > Ilia Mirkin wrote: > > > On Wed, Apr 5, 2017 at 1:12 PM, Gregory Hainaut > > wrote: > > > Context: > > > Nouveau uses NULL

Re: [Mesa-dev] [PATCH 03/13] travis: add the possibility of using the txc-dxtn library

On Fri, 2017-04-07 at 20:05 +0100, Emil Velikov wrote: > From: Andres Gomez > > The txc-dxtn library implements the patented S3 Texture Compression > algorithm. > > By default it won't be used but we add the possibility of setting the > USE_TXC_DXTN variable to yes in the

[Mesa-dev] [Bug 98502] Delay when starting firefox, thunderbird or chromium and dmesg spam

https://bugs.freedesktop.org/show_bug.cgi?id=98502 Eugene Shalygin changed: What|Removed |Added Resolution|FIXED

Re: [Mesa-dev] [PATCH] swr: fix unused variable warnings

Reviewed-by: Bruce Cherniak > On Apr 6, 2017, at 7:10 PM, Tim Rowley wrote: > > --- > src/gallium/drivers/swr/swr_screen.cpp | 1 - > src/gallium/drivers/swr/swr_shader.cpp | 1 - > 2 files changed, 2 deletions(-) > > diff --git

[Mesa-dev] [PATCH 13/13] travis: add Gallium state-tracker targets

From: Emil Velikov Split into OpenCL and others, since the former is quite time consuming. Signed-off-by: Emil Velikov --- .travis.yml | 65 + 1 file changed, 65 insertions(+)

[Mesa-dev] [PATCH 11/13] travis: add "make swr" to the build matrix

From: Emil Velikov Signed-off-by: Emil Velikov --- .travis.yml | 39 --- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 36d614c21a8..b5d9df5 100644

[Mesa-dev] [PATCH 08/13] travis: split out matrix from env

From: Emil Velikov With next commits we'll add a couple of more options. Signed-off-by: Emil Velikov --- .travis.yml | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index

[Mesa-dev] [PATCH 12/13] travis: split the make target to three separate ones

Split the target to allow faster builds for each run. The overall build time will be more, yet Travis runs multiple builds in parallel so we're limited by the slowest one. Things are split roughly as: - DRI loaders, classic DRI drivers, classic OSMesa - All Gallium drivers (minus the SWR)

[Mesa-dev] [PATCH 09/13] travis: add separate "scons" and "scons llvm" targets

From: Emil Velikov The former does not require any LLVM, while the latter uses LLVM 3.3. This way we'll quickly catch any LLVM 3.3+ functionality that gets introduced where it shouldn't. Add the full list of addons for each build permutation. Signed-off-by: Emil

[Mesa-dev] [PATCH 02/13] travis: replace Trusty-based LLVM toolchain apt-get with apt addon

From: Andres Gomez Trusty's LLVM toochain repository was whitelisted some time ago. See: https://github.com/travis-ci/apt-source-whitelist/commit/479067c5e74cb0c1e2419209179b1afe2edce274 Signed-off-by: Andres Gomez [Emil Velikov] - set sudo to false -

[Mesa-dev] [PATCH 10/13] travis: add "scons swr" to the build matrix

From: Emil Velikov Requires GCC 5.0 (due to the C++14 requirement) and LLVM 3.9. Signed-off-by: Emil Velikov --- .travis.yml | 26 ++ 1 file changed, 26 insertions(+) diff --git a/.travis.yml b/.travis.yml index

[Mesa-dev] [PATCH 07/13] travis: rework if test blocks in the script section

From: Emil Velikov Split the "if test" blocks so that we get more sensible output in case of a failure. Signed-off-by: Emil Velikov --- .travis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.travis.yml

[Mesa-dev] [PATCH 06/13] travis: remove unused -dev packages

From: Emil Velikov We effectively override libdrm-dev and libxcb-dri2-0-dev since we build and install the package locally. Signed-off-by: Emil Velikov --- .travis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.travis.yml

[Mesa-dev] [PATCH 05/13] travis: automatically manage ccache caching

From: Emil Velikov According to the manual "If you are using ccache, use: language: c # or other C/C++ variants cache: ccache to cache $HOME/.ccache and automatically add /usr/lib/ccache to your $PATH." Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH 00/13] Better Travis-CI integration

Hi all, Inspired by the work from Andres, I've went ahead and made our integration a bit better. Highlights include: - run in container - faster startup times, always 2 cores - removed unneeded packages - "build everything" - st/vdpau and ANV cannot be build at this stage, with the

[Mesa-dev] [PATCH 01/13] travis: explicitly LD_LIBRARY_PATH the local libraries

From: Emil Velikov Some of the libraries may be dlopened, which may not always work due to the non-standard prefix that we're using. Signed-off-by: Emil Velikov --- Adding this is a good idea imho, regardless if we opt for or against

[Mesa-dev] [PATCH 03/13] travis: add the possibility of using the txc-dxtn library

From: Andres Gomez The txc-dxtn library implements the patented S3 Texture Compression algorithm. By default it won't be used but we add the possibility of setting the USE_TXC_DXTN variable to yes in the travis web UI so it will be installed and used for the scons tests. Cc:

[Mesa-dev] [PATCH 04/13] travis: enable apt cache

From: Emil Velikov Signed-off-by: Emil Velikov --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index b426c0b6184..9c8234ac88e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,6 +4,7 @@ sudo:

[Mesa-dev] [Bug 100600] anv_device.c:1337: undefined reference to `anv_gem_busy'

https://bugs.freedesktop.org/show_bug.cgi?id=100600 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 3/3] travis: add the possibility of using the txc-dxtn library

On 7 April 2017 at 13:16, Andres Gomez wrote: > The txc-dxtn library implements the patented S3 Texture Compression > algorithm. > > By default it won't be used but we add the possibility of setting the > USE_TXC_DXTN variable to yes in the travis web UI so it will be >

Re: [Mesa-dev] [PATCH v2 2/2] bin/get-{extra, fixes}-pick-list.sh: improve output

On 7 April 2017 at 12:48, Juan A. Suarez Romero wrote: > Show the commit hash and the title in a way that it is easier to copy > and paste in the bin/.cherry-ignore-extra file if we want to ignore > those commits for the future. > > v2: > - Use printf instead echo (Eric

Re: [Mesa-dev] [PATCH v2 1/2] bin/get-{extra, fixes}-pick-list.sh: add support for ignore list

On 7 April 2017 at 12:30, Juan A. Suarez Romero wrote: > Both scripts does not use a file with the commits to ignore. So if we > have handled one of the suggested commits and decided we won't pick it, > the scripts will continue suggesting them. > > This commits adds support

Re: [Mesa-dev] [PATCH] configure.ac: add --enable-sanitize option

On 7 April 2017 at 11:00, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Enable code sanitizers by adding -fsanitize=$foo flags for the compiler > and linker. > > In addition, this also disables checking for undefined symbols: running > the address

Re: [Mesa-dev] [PATCH v2 2/5] anv/descriptor_set: Use anv_multialloc for descriptor set layouts

On Fri, Apr 07, 2017 at 10:40:49AM -0700, Jason Ekstrand wrote: > On Fri, Apr 7, 2017 at 1:14 AM, Chris Wilson > wrote: > > > On Thu, Apr 06, 2017 at 10:53:07PM -0700, Jason Ekstrand wrote: > > > --- > > > src/intel/vulkan/anv_descriptor_set.c | 22

Re: [Mesa-dev] [PATCH] glsl: fix lower jumps for nested non-void returns

Looks alright to me though I still don't really understand this code :-) Reviewed-by: Roland Scheidegger Am 07.04.2017 um 03:24 schrieb Timothy Arceri: > Fixes the case were a loop contains a return and the loop is > nested inside an if. > >

Re: [Mesa-dev] [PATCH] st/glx: Add awareness for multisample pixel formats to st/glx-xlib.

I'm not an expert on glx, but looks alright to me. Albeit strictly speaking, you don't really need this for MSAA with software renderers, since you can still you use fbos with msaa. But of course you probably want to support it with winsys buffers. Reviewed-by: Roland Scheidegger

Re: [Mesa-dev] [PATCH v2 2/5] anv/descriptor_set: Use anv_multialloc for descriptor set layouts

On Fri, Apr 7, 2017 at 1:14 AM, Chris Wilson wrote: > On Thu, Apr 06, 2017 at 10:53:07PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_descriptor_set.c | 22 +++--- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > diff --git

Re: [Mesa-dev] [PATCH 1/2] genxml: Fix python crash when no dwords are found.

Quoting Rafael Antognolli (2017-04-07 09:52:16) > If the 'dwords' dict is empty, max(dwords.keys()) throws an exception. > This case could happen when we have an instruction that is only an array > of other structs, with variable length. > > Signed-off-by: Rafael Antognolli

Re: [Mesa-dev] [PATCH 11/14] mesa/main: Maintain compressed TexEnv Combine state.

2017-04-07 16:40 GMT+02:00 Marek Olšák : > On Fri, Apr 7, 2017 at 4:35 PM, Marek Olšák wrote: >> On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk >> wrote: >>> Signed-off-by: Gustaw Smolarczyk >>> --- >>>

Re: [Mesa-dev] [PATCH 1/2] mesa: move glMultiDrawArray to vbo and fix error handling

On 04/07/2017 10:30 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle When any count[i] is negative, we must skip all draws. Moving to vbo makes the subsequent change easier. --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/api_validate.c | 38

[Mesa-dev] [PATCH 1/2] genxml: Fix python crash when no dwords are found.

If the 'dwords' dict is empty, max(dwords.keys()) throws an exception. This case could happen when we have an instruction that is only an array of other structs, with variable length. Signed-off-by: Rafael Antognolli --- src/intel/genxml/gen_pack_header.py | 2 +- 1

[Mesa-dev] [PATCH 2/2] genxml: Make BLEND_STATE command support variable length array.

We need to emit BLEND_STATE, which size is 1 + 2 * nr_draw_buffers dwords (on gen8+), but the BLEND_STATE struct length is always 17. By marking it size 1, which is actually the size of the struct minus the BLEND_STATE_ENTRY's, we can emit a BLEND_STATE of variable number of entries. For gen6 and

Re: [Mesa-dev] [PATCH 10/14] mesa/main: Maintain compressed fog mode.

2017-04-07 16:31 GMT+02:00 Marek Olšák : > On Thu, Mar 30, 2017 at 8:09 PM, Gustaw Smolarczyk > wrote: >> Signed-off-by: Gustaw Smolarczyk >> --- >> src/mesa/main/enable.c | 1 + >> src/mesa/main/fog.c| 9 + >>

[Mesa-dev] [PATCH] ac: add unreachable() in ac_build_image_opcode()

To silent the following compiler warning: common/ac_llvm_build.c: In function ‘ac_build_image_opcode’: common/ac_llvm_build.c:1080:3: warning: ‘name’ may be used uninitialized in this function [-Wmaybe-uninitialized] snprintf(intr_name, sizeof(intr_name), "%s%s%s%s.v4f32.%s.v8i32",

[Mesa-dev] RFH: Android support in Apitrace

Hi, Another area of Apitrace I'm struggling with is Android support, because: - I don't have a feeling if / how much it actually matters to users - I have no idea if it even works or not I'm afraid the status quo is unbearable, whereby Android support is officially advertised, but users keep

[Mesa-dev] [PATCH] st/glx: Add awareness for multisample pixel formats to st/glx-xlib.

In preparation for enabling MSAA in OpenSWR, the state trackers need to be aware of multisample pixel formats for software renderers. This patch allows glx-xlib to query the renderer for support of pixel formats with multisample, and create multisample resources. This change is benign to

Re: [Mesa-dev] [PATCH 1/2] mesa: move glMultiDrawArray to vbo and fix error handling

On Fri, Apr 7, 2017 at 12:30 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > When any count[i] is negative, we must skip all draws. > > Moving to vbo makes the subsequent change easier. > --- > src/mapi/glapi/gen/gl_API.xml | 2 +- >

[Mesa-dev] [PATCH 1/2] mesa: move glMultiDrawArray to vbo and fix error handling

From: Nicolai Hähnle When any count[i] is negative, we must skip all draws. Moving to vbo makes the subsequent change easier. --- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/api_validate.c | 38 ++

[Mesa-dev] [PATCH 2/2] vbo: fix gl_DrawID handling in glMultiDrawArrays

From: Nicolai Hähnle Fixes a bug in KHR-GL45.shader_draw_parameters_tests.ShaderMultiDrawArraysParameters. --- src/mesa/vbo/vbo_exec_array.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

Patch didn't fix all leaks. There's one more still reported by ASAN: Direct leak of 2112 byte(s) in 12 object(s) allocated from: #0 0x7fe18d168800 in calloc (/usr/lib/clang/3.9.1/lib/linux/ libclang_rt.asan-x86_64.so+0xf6800) #1 0x7fe181c141f6 in st_new_renderbuffer_fb

Re: [Mesa-dev] [PATCH] configure.ac: add --enable-sanitize option

On Friday, 2017-04-07 12:00:04 +0200, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Enable code sanitizers by adding -fsanitize=$foo flags for the compiler > and linker. > > In addition, this also disables checking for undefined symbols: running > the address

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 Stefan Dirsch changed: What|Removed |Added CC||msta...@suse.de --

Re: [Mesa-dev] [PATCH] mesa: fix renderbuffer leak

On 04/06/2017 03:55 PM, Timothy Arceri wrote: We don't need to call _mesa_reference_renderbuffer() for the first assignment as refCount starts at 1. For swrast we work around the fact we will indirectly call _mesa_reference_renderbuffer() by resetting refCount to 0. Fixes: 32141e53d1520 (mesa:

[Mesa-dev] [Bug 99618] AVX Intrinsics Run in GUI thread only

https://bugs.freedesktop.org/show_bug.cgi?id=99618 --- Comment #4 from ch...@circlecvi.com --- (In reply to Bruce Cherniak from comment #3) > Any chance you've been able to try the suggestion I made > (KNOB_MAX_WORKER_THREADS) to resolve this issue? Hi Bruce, my apologies for the late reply.

[Mesa-dev] [Bug 100613] Regression in Mesa 17 on s390x (zSystems)

https://bugs.freedesktop.org/show_bug.cgi?id=100613 --- Comment #1 from Roland Scheidegger --- I can't say I'm terribly surprised this commit broke it. That it might not work on BE certainly came to my mind when I did this, despite my efforts... I suspect the affected format

  1   2   >