Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] st/mesa: remove redundant stfb->iface checks

On Apr 25, 2017 11:23 AM, "Nicolai Hähnle" wrote: From: Nicolai Hähnle stfb->iface is always non-NULL for an st_framebuffer. These checks were incorrect, relying on out-of-bounds memory access in the surface-less case of EGL_KHR_surfaceless_context.

[Mesa-dev] [PATCH 4/4] r600g: avoid redundant CB updates

It finishes the work started by 0c2eed0edec, quoting: > The main idea is to avoid setting CB_COLORi_INFO = 0 for i>0 repeatedly > when those colorbuffers aren't used. This is mainly for glamor. After 0c2eed0edec the r600g was passing null as the dirty_cbufs pointer, and the current patch makes

[Mesa-dev] [PATCH 3/4] r600g: remove unused sbcl env. variable

sb-based optimization was only used for older LLVM, whose support was removed in 100796c15c3a1467d03abc424e6f1494da02f376 "gallium/radeon: drop support for LLVM 3.5". As of now sbcl variable doesn't do anything. Signed-off-by: Constantine Kharlamov Tested-by: Dieter Nützel

[Mesa-dev] [PATCH 2/4] r600g/radeonsi: trivial cleanups

constified some variables, moved two variable declarations into the cycle where they're used, and removed trailing whitespace. Signed-off-by: Constantine Kharlamov Tested-by: Dieter Nützel --- src/gallium/drivers/r600/evergreen_state.c | 4 +--

[Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB register updates

Split out of "avoid redundant CB register updates" for easier review. Signed-off-by: Constantine Kharlamov Tested-by: Dieter Nützel --- src/gallium/drivers/r600/evergreen_state.c | 76 +++- src/gallium/drivers/r600/r600_blit.c

[Mesa-dev] [PATCH 0/4 v2] small r600g improvements

No regressions with piglit. 1,2, and 3 patches without changes, tested by Dieter, 4 is the new one. Constantine Kharlamov (4): r600g: avoid redundant DB register updates r600g/radeonsi: trivial cleanups r600g: remove unused sbcl env. variable r600g: avoid redundant CB updates

Re: [Mesa-dev] [PATCH] gallium: remove u_caps.c/h interface

On 25/04/17 12:15, Emil Velikov wrote: On 25 April 2017 at 00:10, Samuel Pitoiset wrote: No longer used. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/Makefile.sources | 2 - src/gallium/auxiliary/util/u_caps.c| 267

Re: [Mesa-dev] [PATCH] gallium: remove u_caps.c/h interface

On 25 April 2017 at 00:10, Samuel Pitoiset wrote: > No longer used. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/auxiliary/Makefile.sources | 2 - > src/gallium/auxiliary/util/u_caps.c| 267 >

Re: [Mesa-dev] [PATCH] autogen.sh: set default sendemail.to

On 24 April 2017 at 20:29, Jason Ekstrand wrote: > This seems like something that would be more appropriate to put on a > "getting started" page than autogen.sh. The very last thing I (as a user of > it) would expect autogen.sh to do is monkey with my git config; local or >

[Mesa-dev] [Bug 100782] [GLVND] X fails to start AMDGPU DDX when GLVND compiled into Mesa

https://bugs.freedesktop.org/show_bug.cgi?id=100782 --- Comment #1 from Emil Velikov --- Attaching a debugger to X would be a good start. At the moment the log produced shows nothing of interest. -- You are receiving this mail because: You are the QA Contact for the

Re: [Mesa-dev] [PATCH] docs: add release calendar page and references to it

On 24 April 2017 at 23:40, Eric Engestrom wrote: > On Monday, 2017-04-24 17:22:19 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Add a page that has information which release is expected when and >> associated information. >> >> Reference to

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/vec4: Use reads_accumulator_implicitly(), not MACH checks.

On Sat, 2017-04-22 at 16:28 -0700, Kenneth Graunke wrote: > Curro pointed out that I should not just check for MACH, but use > the reads_accumulator_implicitly() helper, which would also prevent > the same bug with MAC and SADA2 (if we ever decide to use them). > This seems to rely on commit

Re: [Mesa-dev] [PATCH 3/4] radeonsi: disable the TGSI merge registers pass

On 04/25/2017 08:47 AM, Nicolai Hähnle wrote: Interesting find. Is this in shaders with control flow? Perhaps with this change, there are now more undefs in places that previously had a phi with an unrelated use of the same TGSI temporary. Anyway, patches 1-3: Yes. Looks like some shaders

Re: [Mesa-dev] [PATCH 5/5] st/mesa: clean up min/max_index handling in st_draw_vbo

On Tue, Apr 25, 2017 at 8:41 AM, Nicolai Hähnle wrote: > On 24.04.2017 15:31, Marek Olšák wrote: >> >> On Mon, Apr 24, 2017 at 12:01 PM, Nicolai Hähnle >> wrote: >>> >>> On 23.04.2017 01:10, Marek Olšák wrote: From: Marek Olšák

Re: [Mesa-dev] [PATCH 2/2] radeonsi: disable primitive restart for non-strip prims based on app list

> Thanks. Do you plan to update the games not to enable primitive > restart for non-strip primitives? I won't be able to give a decent time frame yet, but yes I'll make sure it's on our schedule. - Marc Di Luzio Linux Group Lead @ Feral Interactive Ltd. On 25 April 2017 at 10:15, Marek

[Mesa-dev] [PATCH 1/2] st/mesa: don't cast the incomplete framebufer to st_framebuffer

From: Nicolai Hähnle The incomplete framebuffer is set for a surfaceless context. This leads to the following error in piglit spec@egl_khr_surfaceless_context@viewport: ==26703==ERROR: AddressSanitizer: global-buffer-overflow on address 0x7f6886e43240 at pc

[Mesa-dev] [PATCH 2/2] st/mesa: remove redundant stfb->iface checks

From: Nicolai Hähnle stfb->iface is always non-NULL for an st_framebuffer. These checks were incorrect, relying on out-of-bounds memory access in the surface-less case of EGL_KHR_surfaceless_context. --- src/mesa/state_tracker/st_cb_viewport.c | 4 ++--

[Mesa-dev] [Bug 100690] [Regression, bisected] TotalWar: Warhammer corrupted graphics

https://bugs.freedesktop.org/show_bug.cgi?id=100690 Marc Di Luzio changed: What|Removed |Added CC|

[Mesa-dev] [Bug 100690] [Regression, bisected] TotalWar: Warhammer corrupted graphics

https://bugs.freedesktop.org/show_bug.cgi?id=100690 --- Comment #6 from Marc Di Luzio --- Cheers for the report Gregor. Kenneth: if the verdict from Khronos suggests we're out of spec then we'll be happy to patch and fix. I'll keep an eye on this thread. -- You

Re: [Mesa-dev] [PATCH 2/2] radeonsi: disable primitive restart for non-strip prims based on app list

On Tue, Apr 25, 2017 at 11:09 AM, Marc Di Luzio wrote: > Hi Marek, > > I agree with Ken here. > > For what it's worth, the list of our titles that use primitive restart here > is likely the full list. DXMD was the first as far as I know - see >

Re: [Mesa-dev] [PATCH v5 0/3] asynchronous pbo transfer with glthread

Hello, I did more tests on my side. DRI3 + recent stack is fine. Older (Debian Jessie, ~2y old) XCB hangs/deadlock. So all DRI3 drivers should be fine (typically AMD). And all applications that called XInitThread soon enough. So yeah I think we can merge it. Note: I don't have commit access.

Re: [Mesa-dev] [PATCH 2/2] radeonsi: disable primitive restart for non-strip prims based on app list

Hi Marek, I agree with Ken here. For what it's worth, the list of our titles that use primitive restart here is likely the full list. DXMD was the first as far as I know - see https://cgit.freedesktop.org/mesa/mesa/commit/?id= e33f31d61f5e9019f8b0bac0378dfb8fd1147421. It also appears to be an

Re: [Mesa-dev] [PATCH 1/2] i965/vec4: set swizzle when loading an uniform

On Mon, 2017-04-24 at 11:22 -0700, Francisco Jerez wrote: > Samuel Iglesias Gonsálvez writes: > > > On Fri, 2017-04-21 at 10:23 -0700, Francisco Jerez wrote: > > > Samuel Iglesias Gonsálvez writes: > > > > > > > On Thu, 2017-04-20 at 10:26 -0700,

[Mesa-dev] [Bug 100782] [GLVND] X fails to start AMDGPU DDX when GLVND compiled into Mesa

https://bugs.freedesktop.org/show_bug.cgi?id=100782 Bug ID: 100782 Summary: [GLVND] X fails to start AMDGPU DDX when GLVND compiled into Mesa Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH 0/7] Move shader_group_vote and shader_ballot to using intrinsics

Ping On 19.04.2017 10:56, Nicolai Hähnle wrote: Hi all, As Matt Turner pointed out on IRC, the builtin functions from those extensions have an unusual interaction with control-flow, which is not captured by the usual semantics of expressions. For this reason, they should really be implemented

[Mesa-dev] [Bug 100690] [Regression, bisected] TotalWar: Warhammer corrupted graphics

https://bugs.freedesktop.org/show_bug.cgi?id=100690 --- Comment #5 from Gregor Münch --- Thanks for the patch. I cant test it before Friday. Will let you know, in the meantime maybe someone else can test? Im quite confident that Feral is willing to fix their games if its a

Re: [Mesa-dev] [PATCH] gallium: remove u_caps.c/h interface

On 25.04.2017 01:10, Samuel Pitoiset wrote: No longer used. Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle --- src/gallium/auxiliary/Makefile.sources | 2 - src/gallium/auxiliary/util/u_caps.c| 267

Re: [Mesa-dev] [PATCH 3/4] radeonsi: disable the TGSI merge registers pass

Interesting find. Is this in shaders with control flow? Perhaps with this change, there are now more undefs in places that previously had a phi with an unrelated use of the same TGSI temporary. Anyway, patches 1-3: Reviewed-by: Nicolai Hähnle On 25.04.2017 00:31,

Re: [Mesa-dev] [PATCH 5/5] st/mesa: clean up min/max_index handling in st_draw_vbo

On 24.04.2017 15:31, Marek Olšák wrote: On Mon, Apr 24, 2017 at 12:01 PM, Nicolai Hähnle wrote: On 23.04.2017 01:10, Marek Olšák wrote: From: Marek Olšák There is no reason to check for ~0. Also remove the incorrect comment. ---

Re: [Mesa-dev] [PATCH 2/2] radeonsi: don't load unused compute shader input SGPRs and VGPRs

On 24.04.2017 18:22, Marek Olšák wrote: From: Marek Olšák Basically, don't load GRID_SIZE or BLOCK_SIZE if they are unused, determine whether to load BLOCK_ID for each component separately, and set the number of THREAD_ID VGPRs to load. Now we should get the maximum CS

Re: [Mesa-dev] [PATCH 1/2] tgsi/scan: record compute shader system value usage

On 24.04.2017 18:22, Marek Olšák wrote: From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 47 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 4 +++ 2 files changed, 51 insertions(+) diff --git

<    1   2