[Mesa-dev] [PATCH] glsl: set mask via initialization list rather than in constructor body

Potentially more efficient as is may avoid the struct being initialised twice. --- src/compiler/glsl/ir.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/compiler/glsl/ir.cpp b/src/compiler/glsl/ir.cpp index 123de99..e55635b 100644 --- a/src/compiler/glsl/ir.cpp +++

[Mesa-dev] [PATCH 1/2] util/disk_cache: add new driver_flags param to cache keys

This will be used for things such as adding driver specific environment variables to the key. Allowing us to set environment vars that change the shader and not have the driver ignore them if it finds existing shaders in the cache. --- src/compiler/glsl/tests/cache_test.c | 20

[Mesa-dev] [PATCH 2/2] radeon: pass flags that can change shaders to disk_cache_create()

I wasn't sure if I should filter the flags so that we only use flags that actually change the shader output. To avoid manual updates we just pass in everything for now. --- src/gallium/drivers/radeon/r600_pipe_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] etnaviv: Don't try to use the index buffer if size is zero

If info->index_size is zero, info->index will point to uninitialized memory. Fatal signal 11 (SIGSEGV), code 2, fault addr 0xab5d07a3 in tid 20456 (surfaceflinger) Signed-off-by: Tomeu Vizoso Cc: etna...@lists.freedesktop.org Cc: Marek Olšák

Re: [Mesa-dev] [PATCH 04/16] anv: Handle transitioning depth from UNDEFINED to other layouts

On Fri, May 19, 2017 at 05:18:12PM -0700, Jason Ekstrand wrote: > On Fri, May 19, 2017 at 4:51 PM, Nanley Chery wrote: > > > On Thu, May 18, 2017 at 02:00:51PM -0700, Jason Ekstrand wrote: > > > --- > > > src/intel/vulkan/anv_image.c | 12 ++-- > > >

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 05:32:07PM -0700, Ian Romanick wrote: > On 05/19/2017 05:07 PM, Ilia Mirkin wrote: > > On Fri, May 19, 2017 at 7:29 PM, Ian Romanick wrote: > >> I missed that glsl_parser_extras.cpp has its own implementation of the > >> has_XXX_foo() functions that

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On 05/19/2017 05:07 PM, Ilia Mirkin wrote: > On Fri, May 19, 2017 at 7:29 PM, Ian Romanick wrote: >> I missed that glsl_parser_extras.cpp has its own implementation of the >> has_XXX_foo() functions that take the API and version as explicit >> parameters. Your patch

[Mesa-dev] [Bug 101110] Build failure in GNOME Continuous

https://bugs.freedesktop.org/show_bug.cgi?id=101110 --- Comment #4 from Emil Velikov --- Correction - needs the following brown paper bag commit 48cd1919ff1 ("configure.ac: s/xcb-fixes/xcb-xfixes/") -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 101110] Build failure in GNOME Continuous

https://bugs.freedesktop.org/show_bug.cgi?id=101110 --- Comment #3 from Dieter Nützel --- Hello Emil, shouldn't this look like this: diff --git a/configure.ac b/configure.ac index b788137d51..06883a9667 100644 --- a/configure.ac +++ b/configure.ac @@ -1723,7 +1723,7 @@ fi

Re: [Mesa-dev] [PATCH 04/16] anv: Handle transitioning depth from UNDEFINED to other layouts

On Fri, May 19, 2017 at 4:51 PM, Nanley Chery wrote: > On Thu, May 18, 2017 at 02:00:51PM -0700, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_image.c | 12 ++-- > > src/intel/vulkan/genX_cmd_buffer.c | 9 + > > 2 files changed, 11

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

On Fri, May 19, 2017 at 12:57 PM, Emil Velikov wrote: > On 18 May 2017 at 23:01, Rob Herring wrote: >> On Thu, May 18, 2017 at 5:25 AM, Emil Velikov >> wrote: >>> On 18 May 2017 at 05:10, Chih-Wei Huang

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 7:29 PM, Ian Romanick wrote: > I missed that glsl_parser_extras.cpp has its own implementation of the > has_XXX_foo() functions that take the API and version as explicit > parameters. Your patch predates that change. There's room for some > modest

Re: [Mesa-dev] [PATCH 04/16] anv: Handle transitioning depth from UNDEFINED to other layouts

On Thu, May 18, 2017 at 02:00:51PM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_image.c | 12 ++-- > src/intel/vulkan/genX_cmd_buffer.c | 9 + > 2 files changed, 11 insertions(+), 10 deletions(-) > > diff --git a/src/intel/vulkan/anv_image.c

Re: [Mesa-dev] [PATCH 03/16] anv: Handle color layout transitions from the UNINITIALIZED layout

On Thu, May 18, 2017 at 02:00:50PM -0700, Jason Ekstrand wrote: > This causes dEQP-VK.api.copy_and_blit.resolve_image.partial.* to start > failing due to test bugs. See CL 1031 for a test fix. > --- > src/intel/vulkan/anv_blorp.c | 40 > ++ >

[Mesa-dev] [PATCH] docs: Document ASTC extension support for SKL and BXT

Cc: Anuj Phogat Signed-off-by: Nanley Chery --- docs/features.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index e18bf54a48..05d776be08 100644 --- a/docs/features.txt +++

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On 05/19/2017 10:28 AM, Nanley Chery wrote: > On Fri, May 19, 2017 at 06:38:03AM -0700, Ian Romanick wrote: >> From: Ian Romanick >> >> The previous code handled everything with the general case. I noticed >> that every time I converted an open-coded check to use a >>

Re: [Mesa-dev] [Mesa-stable] [PATCH] automake: add SWR LLVM gen_builder.hpp workaround

On 19 May 2017 at 20:50, Rowley, Timothy O wrote: > Thanks for doing this; I would have been hunting for the dist-hook: magic > for a while. > > Tested “make dist” on llvm-3.9.0 (works) and llvm-4.0/llvm-svn (fails, > expected desired behavior). > > Built result of

[Mesa-dev] [Bug 101110] Build failure in GNOME Continuous

https://bugs.freedesktop.org/show_bug.cgi?id=101110 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 14/16] anv: Advertise both 32-bit and 48-bit heaps when we have enough memory

On Fri, May 19, 2017 at 2:53 PM, Gustaw Smolarczyk wrote: > 2017-05-18 23:01 GMT+02:00 Jason Ekstrand : > > --- > > src/intel/vulkan/anv_device.c | 42 ++ > ++-- > > 1 file changed, 36 insertions(+), 6 deletions(-)

Re: [Mesa-dev] [PATCH v13 27/36] i965: Change resolve flags to enum

So, I think I'm going to end up doing a fairly significant rework of resolves over the course of the next couple of weeks. Carry on with the branch as is and I'll figure out how to rebase it on top of whatever changes I do later. But it'll probably be significant. Just a heads up. --Jason On

[Mesa-dev] [Bug 101110] Build failure in GNOME Continuous

https://bugs.freedesktop.org/show_bug.cgi?id=101110 --- Comment #1 from Emil Velikov --- Seems like I've missed some corner case - I'm looking into it. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH 2/2] gallium: Add renderonly-based support for pl111+vc4.

On 19 May 2017 at 23:41, Emil Velikov wrote: > On 19 May 2017 at 23:21, Eric Anholt wrote: >> Emil Velikov writes: >> >>> On 17 May 2017 at 20:13, Emil Velikov wrote: On 17 May 2017 at 18:53,

Re: [Mesa-dev] [PATCH 2/2] gallium: Add renderonly-based support for pl111+vc4.

On 19 May 2017 at 23:21, Eric Anholt wrote: > Emil Velikov writes: > >> On 17 May 2017 at 20:13, Emil Velikov wrote: >>> On 17 May 2017 at 18:53, Eric Anholt wrote: Emil Velikov

[Mesa-dev] [Bug 101110] Build failure in GNOME Continuous

https://bugs.freedesktop.org/show_bug.cgi?id=101110 Bug ID: 101110 Summary: Build failure in GNOME Continuous Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 2/2] gallium: Add renderonly-based support for pl111+vc4.

Emil Velikov writes: > On 17 May 2017 at 20:13, Emil Velikov wrote: >> On 17 May 2017 at 18:53, Eric Anholt wrote: >>> Emil Velikov writes: >>> Hi Eric, On 11 May 2017 at 00:06, Eric

[Mesa-dev] [PATCH] vulkan/wsi/wayland: Fix proxy wrappers for swapchain recreation

Before the swapchain event queue is destroyed, all proxy objects that reference it must be dropped. Otherwise we risk a use-after-free if a frame callback event or buffer release events are received afterwards. This happens when an application destroys and recreates a swapchain in FIFO mode

Re: [Mesa-dev] [PATCH 14/16] anv: Advertise both 32-bit and 48-bit heaps when we have enough memory

2017-05-18 23:01 GMT+02:00 Jason Ekstrand : > --- > src/intel/vulkan/anv_device.c | 42 -- > 1 file changed, 36 insertions(+), 6 deletions(-) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index

Re: [Mesa-dev] [PATCH 9/9] nouveau: s/nv04_surface_/nouveau_surface_/

Ilia Mirkin writes: > I kinda see it both ways - yeah, the functions are the same and it's > all shared, so your patch makes sense. OTOH, all of these functions > (which do anything) have a nv04/nv10/nv20 prefix, which makes it > easier to separate stuff out by generation

Re: [Mesa-dev] [PATCH v13 24/36] i965/miptree: Add a return for updating of winsys

It's a bit annoying, but I think this would all make more sense if we moved 23 and 24 to before 19. Then we could drop no_aux from 21. Then again, I'm sure Ben has some good reason why that's not practical and I'm fine with leaving the order as-is. It's hard to review but there's a lot of

Re: [Mesa-dev] [PATCH 2/2] i965: Enable ASTC HDR for Broxton

On Fri, May 19, 2017 at 10:41:22AM -0700, Anuj Phogat wrote: > On Thu, May 18, 2017 at 3:53 PM, Nanley Chery wrote: > > This platform passes the following GLES3 tests: > > ES3-CTS.functional.texture.compressed.astc.endpoint_value_hdr_cem_* > > > We've hdr tests in piglit as

Re: [Mesa-dev] [PATCH v13 21/36] i965: Restructure CCS disabling

On Fri, May 19, 2017 at 2:38 AM, Daniel Stone wrote: > From: Ben Widawsky > > Make the code only disable CCS when it has to, unlike before where it > disabled CCS and enabled it when it could. This is much more inline with > how it should work in a few

Re: [Mesa-dev] [Mesa-stable] [PATCH] automake: add SWR LLVM gen_builder.hpp workaround

Thanks for doing this; I would have been hunting for the dist-hook: magic for a while. Tested “make dist” on llvm-3.9.0 (works) and llvm-4.0/llvm-svn (fails, expected desired behavior). Built result of llvm-3.9.0 “make dist” with llvm-4.0 and llvm-svn and it compiles/works. Reviewed-by: Tim

Re: [Mesa-dev] [PATCH v13 16/36] i965: Remove same-FD restriction for imports

On Fri, May 19, 2017 at 2:37 AM, Daniel Stone wrote: > Intel hardware requires that all planes of an image come from the same > buffer, which is currently implemented by testing that all FDs are > numerically the same. > > However, when going through a winsys (e.g.) or

Re: [Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

Just FYI: I'm not checking that you implement the EGL API correctly. I'm mostly checking for whether or not it's using DRI correctly. On Fri, May 19, 2017 at 2:37 AM, Daniel Stone wrote: > From: Varad Gautam > > query and return supported dmabuf

Re: [Mesa-dev] [PATCH v13 06/36] egl: implement eglQueryDmaBufFormatsEXT

On Fri, May 19, 2017 at 2:37 AM, Daniel Stone wrote: > From: Varad Gautam > > allow egl clients to query the dmabuf formats supported on this platform. > > v2: return EGLBoolean. > v3: Check DRIimageExtension version before querying (Daniel

Re: [Mesa-dev] [PATCH v13 05/36] dri: add queryDmaBufFormats and queryDmaBufModifiers to DRIimage

On Fri, May 19, 2017 at 2:37 AM, Daniel Stone wrote: > From: Varad Gautam > > these allow querying the driver for supported dmabuf formats and > modifiers. > > v2: move to __DRIimageExtension version 16. > v3: return GLBoolean for error

Re: [Mesa-dev] [PATCH] Android: r600: fix build when LLVM is disabled

Jfyi: feel free to add Fixes tag as you see fit. We parse though and automatically nominate patches for -stable :-) On 19 May 2017 at 13:04, Rob Herring wrote: > On Fri, May 12, 2017 at 11:55 AM, Rob Herring wrote: >> There's still an error after my recent

Re: [Mesa-dev] [PATCH v13 04/36] egl/dri2: Create EGLImages with dmabuf modifiers

On Fri, May 19, 2017 at 2:37 AM, Daniel Stone wrote: > From: Varad Gautam > > Allow creating EGLImages with dmabuf format modifiers when target is > EGL_LINUX_DMA_BUF_EXT for EGL_EXT_image_dma_buf_import_modifiers. > > v2: > - clear modifier

Re: [Mesa-dev] [PATCH v13 03/36] dri: support DRIimage creation from dmabufs with modifiers

On Fri, May 19, 2017 at 2:37 AM, Daniel Stone wrote: > From: Pekka Paalanen > > add createImageFromDmaBufs2 function which accepts per-plane dmabuf > format modifiers. > > Signed-off-by: Pekka Paalanen >

Re: [Mesa-dev] [PATCH] i965: Add RGBX8888 and RGBA8888 to EGL configure and reorder the list

On 18 May 2017 at 23:01, Rob Herring wrote: > On Thu, May 18, 2017 at 5:25 AM, Emil Velikov > wrote: >> On 18 May 2017 at 05:10, Chih-Wei Huang wrote: >>> 2017-05-18 12:01 GMT+08:00 Xu, Randy : >

Re: [Mesa-dev] [PATCH 14/16] anv: Advertise both 32-bit and 48-bit heaps when we have enough memory

On Thu, May 18, 2017 at 2:01 PM, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 42 ++ > ++-- > 1 file changed, 36 insertions(+), 6 deletions(-) > > diff --git a/src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH 1/2] anv: automake: list shared libraries after the static ones

From: Emil Velikov The compiler can discard the shared ones from the link chain, since there is no user (the static libraries) before it on the command line. Cc: mesa-sta...@lists.freedesktop.org Reported-by: Laurent Carlier Signed-off-by: Emil

[Mesa-dev] [PATCH 2/2] radv: automake: list shared libraries after the static ones

From: Emil Velikov Analogous to previous commit - the compiler can discard xcb + wayland libs, since there is no user (the static libraries) before it on the command line. Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 2/2] i965: Enable ASTC HDR for Broxton

On Thu, May 18, 2017 at 3:53 PM, Nanley Chery wrote: > This platform passes the following GLES3 tests: > ES3-CTS.functional.texture.compressed.astc.endpoint_value_hdr_cem_* > We've hdr tests in piglit as well. With those passing, both patches are: Reviewed-by: Anuj Phogat

Re: [Mesa-dev] Bug in 17.1.0-rc4 source packaging for swr?

On 19 May 2017 at 17:46, Rowley, Timothy O wrote: > > > On May 19, 2017, at 10:26 AM, Emil Velikov wrote: > > The original idea by Tim sounds OK imho and I'm actually giving it a try. > Are you referring to using a llvm-3.9 generated

[Mesa-dev] [PATCH] automake: add SWR LLVM gen_builder.hpp workaround

From: Emil Velikov As gen_builder.hpp file is generated, it contains information that is specific to the LLVM version it originates from. As suggested by Tim, the file seems to be forwards compatible. So in order to produce ship a file which will work everywhere we

Re: [Mesa-dev] [PATCH] android: add -Wl, --build-id=sha1 to LDFLAGS for libvulkan_intel

Reviewed-by: Jason Ekstrand On Fri, May 19, 2017 at 4:25 AM, Tapani Pälli wrote: > Just like is done on desktop and what is expected by the build-id code. > > Signed-off-by: Tapani Pälli > --- > > Jason, I commented before

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 1:28 PM, Nanley Chery wrote: > The only thing I think may need > addressing is endianness. FYI, I'm happy to provide BE support, both reviewing code and testing. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 1/9] mesa: Handle common extension checks with more compact code

On Fri, May 19, 2017 at 06:38:03AM -0700, Ian Romanick wrote: > From: Ian Romanick > > The previous code handled everything with the general case. I noticed > that every time I converted an open-coded check to use a > _mesa_has_EXT_foo() function, the text size of the

Re: [Mesa-dev] [RFC PATCH 00/65] ARB_bindless_texture for RadeonSI

On 05/19/2017 07:05 PM, Ilia Mirkin wrote: Great work, Samuel! Is this available in a branch somewhere? Thanks Ilia! Here's the branch: https://cgit.freedesktop.org/~hakzsam/mesa/log/?h=arb_bindless_texture On Fri, May 19, 2017 at 12:52 PM, Samuel Pitoiset

Re: [Mesa-dev] [RFC PATCH 00/65] ARB_bindless_texture for RadeonSI

Great work, Samuel! Is this available in a branch somewhere? On Fri, May 19, 2017 at 12:52 PM, Samuel Pitoiset wrote: > Hi, > > This series implements ARB_bindless_texture for RadeonSI. > > Reminder: the GLSL compiler part is already upstream. > > This series has been

[Mesa-dev] [RFC PATCH 44/65] st/mesa: make bindless samplers/images bound to units resident

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_atom_constbuf.c | 6 ++ src/mesa/state_tracker/st_texture.c | 94 +++ src/mesa/state_tracker/st_texture.h | 8 +++ 3 files changed, 108 insertions(+) diff --git

[Mesa-dev] [RFC PATCH 18/65] mesa: add update_single_program_texture_state() helper

This will also be used for looping over bindless samplers bound to texture units. Signed-off-by: Samuel Pitoiset --- src/mesa/main/texstate.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [RFC PATCH 50/65] radeonsi: add si_set_sampler_view_desc() helper

To share some common code between bound and bindless textures. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 95 +++ 1 file changed, 52 insertions(+), 43 deletions(-) diff --git

[Mesa-dev] [RFC PATCH 60/65] radeonsi: only decompress resident textures/images when used

When current bound shaders don't use any bindless textures or images, we shouldn't try to decompress the resident resources. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_blit.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)

[Mesa-dev] [RFC PATCH 25/65] gallium: add ARB_bindless_texture interface

Signed-off-by: Samuel Pitoiset --- src/gallium/include/pipe/p_context.h | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/include/pipe/p_context.h b/src/gallium/include/pipe/p_context.h index 4b75386a65..83eb1c9b08 100644 ---

[Mesa-dev] [RFC PATCH 61/65] radeonsi: upload new descriptors when resident buffers are invalidated

When texture buffers are invalidated the addr in the resident descriptor has to be updated but we can't create a new descriptor because the resident handle has to be the same. Instead, use the WRITE_DATA packet which allows to update memory directly but graphics/compute have to be idle in case

[Mesa-dev] [RFC PATCH 39/65] st/mesa: make update_single_texture() non-static

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_atom_texture.c | 15 +-- src/mesa/state_tracker/st_texture.h | 5 + 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_texture.c

[Mesa-dev] [RFC PATCH 37/65] tgsi/scan: record bindless samplers/images usage

Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 37 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 2 ++ 2 files changed, 39 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c

[Mesa-dev] [RFC PATCH 65/65] radeonsi: enable ARB_bindless_texture

This has only been tested on RX480. Signed-off-by: Samuel Pitoiset --- docs/features.txt | 2 +- docs/relnotes/17.2.0.html | 1 + src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- 3 files changed, 5 insertions(+), 2 deletions(-) diff

[Mesa-dev] [RFC PATCH 36/65] st/glsl_to_tgsi: teach rename_temp_registers() about bindless samplers

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index ee1afdcd08..c69eefe013 100644 ---

[Mesa-dev] [RFC PATCH 57/65] radeonsi: decompress resident textures/images before graphics/compute

Similar to the existing decompression code path except that it loops over the list of resident textures/images. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_blit.c| 67 +--

[Mesa-dev] [RFC PATCH 53/65] radeonsi: add all resident buffers to the current CS

Resident buffers have to be added to every new command stream. Though, this could be slightly improved when current shaders don't use any bindless textures/images but usually applications tend to use bindless for almost every draw call, and the winsys thread might help when buffers are added

[Mesa-dev] [RFC PATCH 54/65] radeonsi: only add descriptors in presence of resident handles

This won't help much except for applications that use a ton of resident handles. Though, this will reduce the winsys overhead a little bit. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 5 + 1 file changed, 5 insertions(+)

[Mesa-dev] [RFC PATCH 62/65] radeonsi: invalidate buffers which are made resident if needed

When a buffer becomes resident, check if it has been invalidated, if so update the descriptor and the dirty flag. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 34 +++ 1 file changed, 34 insertions(+) diff

[Mesa-dev] [RFC PATCH 59/65] radeonsi: track use of bindless samplers/images from tgsi_shader_info

This adds some new helper functions to know if the current draw call (or dispatch compute) is using bindless samplers/images, based on TGSI analysis. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_compute.c | 2 ++

[Mesa-dev] [RFC PATCH 45/65] st/mesa: do not release sampler views for resident textures

When a texture is referenced by one or more texture handles, it might be resident and we shouldn't release the sampler views. Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_sampler_view.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Mesa-dev] [RFC PATCH 51/65] radeonsi: add si_set_shader_image_desc() helper

To share some common code between bound and bindless images. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 78 --- 1 file changed, 46 insertions(+), 32 deletions(-) diff --git

[Mesa-dev] [RFC PATCH 64/65] radeonsi: add support for loading bindless images

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 31 ++- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c

[Mesa-dev] [RFC PATCH 46/65] st/mesa: disable per-context seamless cubemap when using texture handles

The ARB_bindless_texture spec say: "If ARB_seamless_cubemap (or OpenGL 4.0, which includes it) is supported, the per-context seamless cubemap enable is ignored and treated as disabled when using texture handles." "If AMD_seamless_cubemap_per_texture is supported, the seamless

[Mesa-dev] [RFC PATCH 63/65] radeonsi: add support for loading bindless samplers

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c

[Mesa-dev] [RFC PATCH 48/65] radeonsi: add a slab allocator for resident descriptors

For each texture/image handles, we need to allocate a new buffer for the resident descriptor. But when the number of buffers added to the current CS becomes high, the overhead in the winsys (and in the kernel) is important. To reduce this bottleneck, the idea is to suballocate the resident

[Mesa-dev] [RFC PATCH 34/65] st/glsl_to_tgsi: add support for bindless pack/unpack operations

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index

[Mesa-dev] [RFC PATCH 42/65] st/mesa: add st_create_{texture, image}_handle_from_unit() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_texture.c | 42 + 1 file changed, 42 insertions(+) diff --git a/src/mesa/state_tracker/st_texture.c b/src/mesa/state_tracker/st_texture.c index 2e9856dcdf..65f86f2b4f

[Mesa-dev] [RFC PATCH 41/65] st/mesa: add st_convert_image_from_unit() helper

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_atom_image.c | 33 ++--- src/mesa/state_tracker/st_texture.h| 5 + 2 files changed, 27 insertions(+), 11 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_image.c

[Mesa-dev] [RFC PATCH 27/65] trace: add ARB_bindless_texture support

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/trace/tr_context.c | 114 + 1 file changed, 114 insertions(+) diff --git a/src/gallium/drivers/trace/tr_context.c b/src/gallium/drivers/trace/tr_context.c index

[Mesa-dev] [RFC PATCH 40/65] st/mesa: make convert_sampler_from_unit() non-static

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_atom_sampler.c | 14 -- src/mesa/state_tracker/st_texture.h | 5 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_sampler.c

[Mesa-dev] [RFC PATCH 38/65] st/mesa: implement ARB_bindless_texture

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_cb_texture.c | 84 ++ 1 file changed, 84 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index

[Mesa-dev] [RFC PATCH 47/65] st/mesa: enable ARB_bindless_texture

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 2fa7ba7797..80695580cb 100644 ---

[Mesa-dev] [RFC PATCH 43/65] st/mesa: add infrastructure for storing bound texture/image handles

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_context.c | 2 + src/mesa/state_tracker/st_context.h | 11 ++ src/mesa/state_tracker/st_texture.c | 77 + src/mesa/state_tracker/st_texture.h | 5 +++ 4 files

[Mesa-dev] [RFC PATCH 56/65] radeonsi: decompress DCC for resident textures/images

Analogous to bound textures/images. We should also update the resident descriptors and disable COMPRESSION_EN for avoiding useless DCC fetches, but I postpone this optimization for a separate series. Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [RFC PATCH 55/65] radeonsi: add si_update_check_render_feedback() helper

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index

[Mesa-dev] [RFC PATCH 58/65] radeonsi: isolate real framebuffer changes from the decompression passes

When a stencil buffer is part of the framebuffer state, it is decompressed but because it's bindles, all draw calls set stencil_dirty_level_mask to 1. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_blit.c | 8

[Mesa-dev] [RFC PATCH 29/65] tgsi: add new Bindless flag to tgsi_instruction_texture

Old-style images are identified using TGSI_FILE_SAMPLER, but bindless samplers can be TGSI_FILE_CONSTANT or TGSI_FILE_TEMPORARY. To avoid backend compilers to be confused, this adds a new flag that will only be set for bindless samplers. Signed-off-by: Samuel Pitoiset

[Mesa-dev] [RFC PATCH 52/65] radeonsi: implement ARB_bindless_texture

This implements the Gallium interface. Decompression of resident textures/images will follow in the next patches. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 340 ++ src/gallium/drivers/radeonsi/si_pipe.c

[Mesa-dev] [RFC PATCH 49/65] radeonsi: add si_init_descriptor_list() helper

This will be used in order to initialize resident descriptors for bindless textures/images. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/radeonsi/si_descriptors.c | 15 +++ 1 file changed, 15 insertions(+) diff --git

[Mesa-dev] [RFC PATCH 24/65] gallium: add PIPE_CAP_BINDLESS_TEXTURE

Whether bindless texture operations are supported by the underlying driver. Signed-off-by: Samuel Pitoiset --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 +

[Mesa-dev] [RFC PATCH 28/65] tc: add ARB_bindless_texture support

Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/util/u_threaded_context.c| 147 + .../auxiliary/util/u_threaded_context_calls.h | 4 + 2 files changed, 151 insertions(+) diff --git

[Mesa-dev] [RFC PATCH 10/65] mesa: store bindless samplers as PROGRAM_UNIFORM

Old-style samplers (ie. bound samplers) are stored as PROGRAM_SAMPLER, while bindless ones are PROGRAM_UNIFORM. Signed-off-by: Samuel Pitoiset --- src/mesa/program/ir_to_mesa.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [RFC PATCH 20/65] mesa: pass gl_program to _mesa_associate_uniform_storage()

Signed-off-by: Samuel Pitoiset --- src/mesa/program/ir_to_mesa.cpp| 7 --- src/mesa/program/ir_to_mesa.h | 4 ++-- src/mesa/state_tracker/st_glsl_to_nir.cpp | 3 +-- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 +--

[Mesa-dev] [RFC PATCH 26/65] ddebug: add ARB_bindless_texture support

Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/ddebug/dd_context.c | 61 + 1 file changed, 61 insertions(+) diff --git a/src/gallium/drivers/ddebug/dd_context.c b/src/gallium/drivers/ddebug/dd_context.c index

[Mesa-dev] [RFC PATCH 22/65] mesa: handle bindless uniforms bound to texture/image units

Signed-off-by: Samuel Pitoiset --- src/mesa/main/uniform_query.cpp | 122 ++-- 1 file changed, 116 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index

[Mesa-dev] [RFC PATCH 33/65] st/glsl_to_tgsi: add support for bindless images

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 78 -- 1 file changed, 63 insertions(+), 15 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [RFC PATCH 32/65] st/glsl_to_tgsi: add support for bindless samplers

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index

[Mesa-dev] [RFC PATCH 17/65] mesa: add update_single_shader_texture_used() helper

This will also be used for looping over bindless samplers bound to texture units. Signed-off-by: Samuel Pitoiset --- src/mesa/main/uniforms.c | 67 +++- 1 file changed, 38 insertions(+), 29 deletions(-) diff --git

[Mesa-dev] [RFC PATCH 21/65] mesa: associate uniform storage to bindless samplers/images

When a bindless sampler/image is bound to a texture/image unit, we have to overwrite the constant value by the resident handle directly in the constant buffer before the next draw. One solution is to keep track of a pointer to the data. Signed-off-by: Samuel Pitoiset

[Mesa-dev] [RFC PATCH 23/65] mesa: get rid of a workaround for bindless in _mesa_get_uniform()

The ARB_bindless_texture spec says: "When a sampler or image uniform's value is queried via any of the GetUniform* commands, the returned value will reflect the most recently set value through either UniformHandle* or Uniform1i*, converted to the requested type." Signed-off-by:

[Mesa-dev] [RFC PATCH 31/65] tgsi/ureg: accept TGSI_FILE_{CONSTANT, INPUT} for dst registers

For example, TGSI_OPCODE_STORE for bindless images might use a constant buffer or a shader input. Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c

[Mesa-dev] [RFC PATCH 30/65] tgsi: add new Bindless flag to tgsi_instruction_memory

Old-style images are identified using TGSI_FILE_IMAGE, but bindless images can be TGSI_FILE_CONSTANT or TGSI_FILE_TEMPORARY. To avoid backend compilers to be confused, this adds a new flag that will only be set for bindless images. Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [RFC PATCH 35/65] st/glsl_to_tgsi: teach the DCE pass about bindless samplers/images

When a texture (or an image) instruction uses a bindless sampler (respectively a bindless image), make sure the DCE pass won't remove code when the resource is a temporary variable. Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 15

  1   2   3   >