[Mesa-dev] [PATCH] i965: Store fast clear colors in an isl_color_value

2017-05-20 Thread Jason Ekstrand
This commit, out of necessity, makes a number of changes at once: 1) Changes intel_mipmap_tree to store the clear color for both color and depth as an isl_color_value. 2) Changes the depth/stencil emit code to do the format conversion of the depth clear value on Haswell and earlier inst

[Mesa-dev] [PATCH] i965: Store fast clear colors in an isl_color_value

2017-05-20 Thread Jason Ekstrand
--- src/intel/blorp/blorp_genX_exec.h| 2 +- src/intel/isl/isl_emit_depth_stencil.c | 19 src/mesa/drivers/dri/i965/brw_blorp.c| 18 +++- src/mesa/drivers/dri/i965/brw_clear.c| 15 ++- src/mesa/drivers/dri/i965/brw_meta_util.c

[Mesa-dev] [Bug 99116] Wine program showing only a blackscreen when using mesa

2017-05-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99116 --- Comment #11 from jr --- (In reply to Boyan Ding from comment #9) > JFYI, https://patchwork.freedesktop.org/patch/134178/ is the most recent > version, but somehow got stuck in review. Thanks, testing that version I can confirm that it also f

Re: [Mesa-dev] [PATCH v2 0/6] Various fixes to integer GetUniform*()

2017-05-20 Thread Matt Turner
On Thu, May 18, 2017 at 2:43 AM, Iago Toral Quiroga wrote: > The main change is that we now use round*() instead of IROUND*() which only > worked for signed integer cases. I have also made it so we write > converted unsigned values the unsigned field in the destination union and to > cast the resu

Re: [Mesa-dev] [PATCH v2 6/6] mesa/main: replace remaining uses of IROUND() in GetUniform*() by round()

2017-05-20 Thread Matt Turner
On Thu, May 18, 2017 at 2:43 AM, Iago Toral Quiroga wrote: > These were correct since they were used only in conversions to signed > integers, > however this makes the implementation a bit more is more consistent and > reduces > chances of propagating use of these macros to unsigned cases in the

Re: [Mesa-dev] [PATCH v2 5/6] mesa/main: conversion from float in GetUniformi64v requires rounding to nearest

2017-05-20 Thread Matt Turner
On Thu, May 18, 2017 at 2:43 AM, Iago Toral Quiroga wrote: > As we do for all other cases of float/double conversions to integers. > > v2: use round() instead of IROUND() macros > --- > src/mesa/main/uniform_query.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/me

Re: [Mesa-dev] [PATCH v2 4/6] mesa/main: Add conversion from double to uint64/int64 in GetUniform*i64v()

2017-05-20 Thread Matt Turner
On Thu, May 18, 2017 at 2:43 AM, Iago Toral Quiroga wrote: > v2: > - need unsigned rounding for double->uint64 conversion (Nicolai) > - use round() instead of IROUND() macros > --- > src/mesa/main/uniform_query.cpp | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/src/m

Re: [Mesa-dev] [PATCH v2 3/6] mesa/main: Clamp GetUniformui64v values to be >= 0

2017-05-20 Thread Matt Turner
On Thu, May 18, 2017 at 2:43 AM, Iago Toral Quiroga wrote: > Like we do for the 32-bit case. > > v2: > - need unsigned rounding for float->uint64 conversion (Nicolai) > - use roundf() instead of IROUND() macros > --- > src/mesa/main/uniform_query.cpp | 46 > ++

Re: [Mesa-dev] [PATCH v2 2/6] mesa/main: Clamp GetUniformuiv values to be >= 0

2017-05-20 Thread Matt Turner
On Thu, May 18, 2017 at 2:43 AM, Iago Toral Quiroga wrote: > From: Kenneth Graunke > > Section 2.2.2 (Data Conversions For State Query Commands) of the > OpenGL 4.5 October 24th 2016 specification says: > > "If a command returning unsigned integer data is called, such as > GetSamplerParameterIui

Re: [Mesa-dev] [PATCH v2 3/3] drirc: Add allow_glsl_builtin_variable_redeclaration for Dying Light and Dead Island Definitive Edition

2017-05-20 Thread John Brooks
On Sat, May 20, 2017 at 10:46:00PM +0200, Kai Wasserbäch wrote: > Hey, > John Brooks wrote on 15.05.2017 07:47: > > This fixes the long-standing problem with Dying Light where the game would > > produce a black screen when running under Mesa. This happened because the > > game's vertex shaders rede

Re: [Mesa-dev] [PATCH v2 3/3] drirc: Add allow_glsl_builtin_variable_redeclaration for Dying Light and Dead Island Definitive Edition

2017-05-20 Thread Kai Wasserbäch
Hey, John Brooks wrote on 15.05.2017 07:47: > This fixes the long-standing problem with Dying Light where the game would > produce a black screen when running under Mesa. This happened because the > game's vertex shaders redeclare gl_VertexID, which is a GLSL builtin. > Mesa's GLSL compiler is a li

Re: [Mesa-dev] [PATCH 2/6] i965/gen4: Remove redundant check for depth when rebasing stencil

2017-05-20 Thread Pohjolainen, Topi
On Sat, May 20, 2017 at 10:29:53PM +0300, Topi Pohjolainen wrote: > In case of gen < 6 stencil (if present) is always combined with > depth. Both stencil and depth attachments point to the same > physical surface. > Alignment workaround starts by considering depth and updates > stencil accordingly.

[Mesa-dev] [PATCH 3/6] i965/gen4: Simplify depth/stencil invalidate check

2017-05-20 Thread Topi Pohjolainen
There is no separate stencil on gen < 6. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_misc_state.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c i

[Mesa-dev] [PATCH 2/6] i965/gen4: Remove redundant check for depth when rebasing stencil

2017-05-20 Thread Topi Pohjolainen
In case of gen < 6 stencil (if present) is always combined with depth. Both stencil and depth attachments point to the same physical surface. Alignment workaround starts by considering depth and updates stencil accordingly. Current logic continues with stencil and in vain considers the case where d

[Mesa-dev] [PATCH 5/6] i965/gen4: Refactor depth/stencil rebase

2017-05-20 Thread Topi Pohjolainen
Effectively there is the same code twice, once for depth and again for stencil. Only the current version fails to set depthstencil.depth_offset when there is only stencil attachment (it does set the intra tile offsets though). Hence this fixes piglits: g45,g965,ilk: depthstencil-render-miplevel

[Mesa-dev] [PATCH 6/6] i965/gen4: Tell briefly how workaround depth gets reconciled

2017-05-20 Thread Topi Pohjolainen
CC: Kenneth Graunke Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_misc_state.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c index 85050ce..fe021b0 100644 --- a/src/mesa/driv

[Mesa-dev] i965/gen4: Depth buffer setup cleanup

2017-05-20 Thread Topi Pohjolainen
First this series removes logic considering separate stencil gen < 6 only code paths (where we always use combined depth-stencil). Then patch 5 simplifies the workaround we need for aligning depth buffer. On gen < 6 there is no support for telling which mip-level to draw and hence the driver need

[Mesa-dev] [PATCH 4/6] i965: Drop depth/stencil miptree pointers in alignment workaround

2017-05-20 Thread Topi Pohjolainen
In brw_workaround_depthstencil_alignment() corresponding renderbuffers are always set to refer to the same temp miptrees. There is no need to carry them in context. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.h| 3 --- src/mesa/drivers/dri/i965/brw_misc_state.c

[Mesa-dev] [PATCH 1/6] i965/gen4: Remove non-existing stencil and hiz buffer setup

2017-05-20 Thread Topi Pohjolainen
Separate stencil and hiz are only enabled for gen6+. Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_context.h| 6 +- src/mesa/drivers/dri/i965/brw_misc_state.c | 119 +++-- 2 files changed, 13 insertions(+), 112 deletions(-) diff --git a/src/mesa

Re: [Mesa-dev] [RFC PATCH 00/65] ARB_bindless_texture for RadeonSI

2017-05-20 Thread Nicolai Hähnle
On 19.05.2017 18:52, Samuel Pitoiset wrote: Hi, This series implements ARB_bindless_texture for RadeonSI. Reminder: the GLSL compiler part is already upstream. This series has been mainly tested with Feral games, here's the list of existing games that use ARB_bindless_texture (though not by de

Re: [Mesa-dev] [PATCH] vulkan/wsi/wayland: Fix proxy wrappers for swapchain recreation

2017-05-20 Thread Daniel Stone
Hi Philipp, On 19 May 2017 at 23:07, Philipp Zabel wrote: > Before the swapchain event queue is destroyed, all proxy objects that > reference > it must be dropped. Otherwise we risk a use-after-free if a frame callback > event > or buffer release events are received afterwards. > This happens w

[Mesa-dev] [PATCH] android: radeon(s): fix libdrm_amdgpu shared dependencies

2017-05-20 Thread Mauro Rossi
Fixes building errors in radeon drivers and winsys: target C: libmesa_amd_common <= external/mesa/src/amd/common/ac_gpu_info.c ... target C: libmesa_amd_common <= external/mesa/src/amd/common/ac_surface.c ... target C: libmesa_pipe_r300 <= external/mesa/src/gallium/drivers/r300/r300_blit.c ...

Re: [Mesa-dev] [PATCH] glsl: set mask via initialization list rather than in constructor body

2017-05-20 Thread Samuel Pitoiset
On 05/20/2017 07:05 AM, Timothy Arceri wrote: Potentially more efficient as is may avoid the struct being initialised twice. --- src/compiler/glsl/ir.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/compiler/glsl/ir.cpp b/src/compiler/glsl/ir.cpp index 123de99..e

Re: [Mesa-dev] [PATCH 5/5] genxml: Make 3DSTATE_CONSTANT_BODY on Gen7+ use arrays.

2017-05-20 Thread Jason Ekstrand
On May 20, 2017 12:24:53 AM Kenneth Graunke wrote: This will let us initialize the constant buffers with loops. --- src/intel/genxml/gen7.xml | 14 ++ src/intel/genxml/gen75.xml| 14 ++ src/intel/genxml/gen8.xml

[Mesa-dev] osmesa: link with libunwind if enabled

2017-05-20 Thread Alexandre Demers
Fixes linking error in libOSmesa when using libunwind. Signed-off-by: Alexandre Demers --- src/gallium/targets/osmesa/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/targets/osmesa/Makefile.am b/src/gallium/targets/osmesa/Makefile.am index 6d340f1d9

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

2017-05-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99467 Pavel Bordukov changed: What|Removed |Added CC||pa5h...@inbox.ru -- You are receiving

[Mesa-dev] [Bug 99467] [radv] DOOM 2016 + wine. Green screen everywhere (but can be started)

2017-05-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99467 --- Comment #23 from Pavel Bordukov --- Does this branch work still? I've tried to use it and got green screen. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

Re: [Mesa-dev] [PATCH] mesa: avoid pthread_mutexes when adjusting object refcounts

2017-05-20 Thread Timothy Arceri
On 20/05/17 19:21, Timothy Arceri wrote: On 26/10/16 02:53, Daniel Vetter wrote: On Wed, Oct 19, 2016 at 03:34:12PM -0700, Ian Romanick wrote: On 10/19/2016 12:58 PM, Matt Turner wrote: On Wed, Oct 19, 2016 at 12:06 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: This patch removes locks aro

Re: [Mesa-dev] [PATCH] mesa: avoid pthread_mutexes when adjusting object refcounts

2017-05-20 Thread Timothy Arceri
On 26/10/16 02:53, Daniel Vetter wrote: On Wed, Oct 19, 2016 at 03:34:12PM -0700, Ian Romanick wrote: On 10/19/2016 12:58 PM, Matt Turner wrote: On Wed, Oct 19, 2016 at 12:06 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: This patch removes locks around reference counts in favor of atomic in

[Mesa-dev] [PATCH 2/5] genxml: Fix decoder for groups with multiple fields.

2017-05-20 Thread Kenneth Graunke
If you have something like: We would reset ctx->group_count to 0 after processing the first field, so the second would not have a group count. This is largely untested, as the only groups with multiple fields are packets we don't emit in Mesa. Found by inspection. --- s

[Mesa-dev] [PATCH 4/5] genxml: Fix decoder to print the array element on field members.

2017-05-20 Thread Kenneth Graunke
Previously we'd print things like: 0xfffbb568: 0x0001 : Dword 1 ReadLength: 0 ReadLength: 1 0xfffbb568: 0x0001 : Dword 1 ReadLength: 1 ReadLength: 0 instead of the more obvious: 0xfffbb568: 0x0001 : Dword 1 ReadLength[0]: 0 ReadLe

[Mesa-dev] [PATCH 5/5] genxml: Make 3DSTATE_CONSTANT_BODY on Gen7+ use arrays.

2017-05-20 Thread Kenneth Graunke
This will let us initialize the constant buffers with loops. --- src/intel/genxml/gen7.xml | 14 ++ src/intel/genxml/gen75.xml| 14 ++ src/intel/genxml/gen8.xml | 14 ++ src/intel/genxml/gen9.xml

[Mesa-dev] [PATCH 3/5] genxml: Fix decoding of array groups.

2017-05-20 Thread Kenneth Graunke
If you had a group as the first element of a struct, i.e. ... we would get a group_offset of 0, causing create_field() to think the field wasn't in a group, and fail to offset forward for successive array elements. So we'd mark all the array elements as offset 0. Usin

[Mesa-dev] [PATCH 1/5] genxml: Fix parsing of address fields in groups.

2017-05-20 Thread Kenneth Graunke
For example, used to generate: const uint64_t v2_address = __gen_combine_address(data, &dw[2], values->Pointer, 0); ... const uint64_t v4_address = __gen_combine_address(data, &dw[4], values->Pointer, 0); ... but now generates code with proper subscripts