[Mesa-dev] i965: disable_throttling

2017-06-08 Thread Marathe, Yogesh
Hi, I'm looking forward to set this brw->disable_throttling to true, I'm actually observing adverse effect on performance benchmarks after I force set that to true. What's the expectation from disable_throttling here? BTW, this is on android. Regards, Yogesh. _

Re: [Mesa-dev] [RFC 00/22] DRI3 v1.1, ANV dmabuf

2017-06-08 Thread Jason Ekstrand
On Thu, Jun 8, 2017 at 11:43 AM, Daniel Stone wrote: > Hi, > With full support for modifiers in DRIimage, this patch series adds > support for fully plumbing them through X11. A patchset proposing > an extension to DRI3 to support multiple planes and modifiers can > be found here: > https://lists

Re: [Mesa-dev] [PATCH] egl: fix _eglQuerySurface in EGL_BUFFER_AGE_EXT case

2017-06-08 Thread Tapani Pälli
On 06/08/2017 06:01 PM, Emil Velikov wrote: On 8 June 2017 at 11:10, Tapani Pälli wrote: Specification states that in case of error, value should not be written, patch changes buffer age queries to return -1 in case of error so that we can skip changing the value. In addition, small change t

[Mesa-dev] [PATCH] radv: set fmask state to all 0s when no fmask. (v2)

2017-06-08 Thread Dave Airlie
From: Dave Airlie The shader reads the descriptor to decide if it should take the fmask value, however we weren't initing it always, which meant random crap, esp with MSAA depth textures. Fixes random hangs with: dEQP-VK.glsl.builtin_var.fragdepth.* v2: check fmask_state is not NULL Fixes: f4e

[Mesa-dev] [PATCH] radv: set fmask state to all 0s when no fmask.

2017-06-08 Thread Dave Airlie
From: Dave Airlie The shader reads the descriptor to decide if it should take the fmask value, however we weren't initing it always, which meant random crap, esp with MSAA depth textures. Fixes random hangs with: dEQP-VK.glsl.builtin_var.fragdepth.* Signed-off-by: Dave Airlie --- src/amd/vulk

[Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

2017-06-08 Thread gurchetansi...@chromium.org
From: Gurchetan Singh Otherwise, this extension is not visible to the EGL user --- src/egl/drivers/dri2/egl_dri2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 7175e827c9..9e845e99e3 100644 --- a/src/egl/drivers/dri2/

Re: [Mesa-dev] [PATCH 3/4] configure.ac: remove unused Android specifics

2017-06-08 Thread Nicolas Boichat
On Wed, Jun 7, 2017 at 8:34 AM, Chad Versace wrote: > On Mon 05 Jun 2017, Emil Velikov wrote: >> From: Emil Velikov >> >> The HAVE_ANDROID conditional has been unused as of commit 51accecce77 >> ("mesa/dri: always link against shared glapi") and with that one gone we >> no longer need the host de

[Mesa-dev] [PATCH 2/4] st/dri: consolidate image extension logic

2017-06-08 Thread gurchetansi...@chromium.org
From: Gurchetan Singh We can stop exposing functions needed to initialize the image extension by creating a helper function. --- src/gallium/state_trackers/dri/dri2.c | 33 ++--- src/gallium/state_trackers/dri/dri_extensions.c | 33 +++-- src/gal

[Mesa-dev] [PATCH 3/4] st/dri: use image extension in drisw.c

2017-06-08 Thread gurchetansi...@chromium.org
From: Gurchetan Singh This adds the image extension to the software GL implementation. --- src/gallium/state_trackers/dri/drisw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/state_trackers/dri/drisw.c b/src/gallium/state_trackers/dri/drisw.c index 8fbfa9ecea..45772532f3 1

[Mesa-dev] [PATCH 1/4] st/dri: move image extension into the common file

2017-06-08 Thread gurchetansi...@chromium.org
From: Gurchetan Singh This image extension is is needed by the Android studio emulator when using the host's GLES implementation. This patch moves the extension code from dri2.c to dri_extensions.c. Since some functions in this extension are initialized at runtime by dri2.c, we need to expose th

Re: [Mesa-dev] [PATCH V2 00/24] Add Cannonlake support

2017-06-08 Thread Jason Ekstrand
I think I've now reviewed everything except 2 patches. For the "Update a few assertions" patch, you said you would run a test but never reported back the results. The other is the patch for re-enabling sRGB fast-clears. That one isn't needed for enabling and I'm not yet convinced that it's remov

Re: [Mesa-dev] [PATCH 24.5/24] i965/cnl: Add a preliminary device for Cannonlake

2017-06-08 Thread Jason Ekstrand
I sent out a Vulkan patch (and CCd you) that needs to land before this one so that we don't accidentally start advertising Vulkan support once the PCI IDs land. This seems to match the docs. Reviewed-by: Jason Ekstrand On Fri, Jun 2, 2017 at 6:21 PM, Anuj Phogat wrote: > From: Ben Widawsky >

[Mesa-dev] [PATCH] anv: Don't advertise support on anything above gen9

2017-06-08 Thread Jason Ekstrand
This will prevent the driver from even trying to work on Cannon Lake until we get actual support added. Cc: Anuj Phogat --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 72a96b

Re: [Mesa-dev] [PATCH 13/24] i965/cnl: Update few assertions

2017-06-08 Thread Jason Ekstrand
On Mon, May 15, 2017 at 10:05 AM, Anuj Phogat wrote: > ​​ > > > On Sat, May 13, 2017 at 9:43 AM, Jason Ekstrand > wrote: > >> On May 12, 2017 4:41:36 PM Anuj Phogat wrote: >> >> Signed-off-by: Anuj Phogat >>> --- >>> src/intel/compiler/brw_compiler.h | 2 +- >>> src/mesa/drivers/dri/i96

Re: [Mesa-dev] [PATCH 18/24] i965/cnl: Implement depth count workaround

2017-06-08 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat wrote: > From: Ben Widawsky > > Signed-off-by: Ben Widawsky > --- > src/mesa/drivers/dri/i965/brw_queryobj.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_queryobj.c > b/

Re: [Mesa-dev] [PATCH 23/24] i965/cnl: Enable CCS_E and RT support for few formats

2017-06-08 Thread Jason Ekstrand
Assuming that I know how to read the docs (which may be a very bad assumption), this looks correct to me. Reviewed-by: Jason Ekstrand On Fri, May 12, 2017 at 4:38 PM, Anuj Phogat wrote: > Suggested-by: Jason Ekstrand > Signed-off-by: Anuj Phogat > --- > src/intel/isl/isl_format.c | 18 +

Re: [Mesa-dev] [PATCH 22/24] i965/cnl: Reformat surface_format_info table to accomodate gen10+

2017-06-08 Thread Jason Ekstrand
Acked-by: Jason Ekstrand That's not a "review" because I didn't actually verify every line is correct. I assumed you just used block edit in you text editor to insert a bunch of columns of spaces. Please push this one ASAP to limit further rebasing. Some rebasing will already have to be done s

Re: [Mesa-dev] [PATCH] Reduce zlib requirement from 1.2.8 to 1.2.3.

2017-06-08 Thread Timothy Arceri
On 09/06/17 03:11, Chuck Atkins wrote: Testing with zlib versions 1.2.{3,4,5,6,7,8} showed no difference in functionality, correctness, or zlib API usage and 1.2.3 is the oldest version available in still actively deployed production Linux distributions (RHEL/CentOS 6 and SuSE 11). Reviewed-by:

Re: [Mesa-dev] [PATCH 3.2/24] intel/genxml: Make 3DSTATE_CONSTANT_BODY on Gen10 use arrays

2017-06-08 Thread Jason Ekstrand
These two are Reviewed-by: Jason Ekstrand Feel free to squash them into the gen10.xml patch if you wish. On Thu, Jun 8, 2017 at 11:40 AM, Anuj Phogat wrote: > From: Ander Conselvan de Oliveira > > This patch will be squashed with "[PATCH 03/24] i965/cnl: Add gen10.xml" > before upstreaming.

[Mesa-dev] [Bug 101334] Any vulkan app seems to freeze the system

2017-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #2 from John --- Hello Eric, Good point! I am currently on mesa ce53e8e61b (commit number 92807), and llvm 304967. Would anything else help? Thank you! John -- You are receiving this mail because: You are the QA Contact for the

Re: [Mesa-dev] [PATCH] swr: relax c++ requirement from c++14 to c++11

2017-06-08 Thread Cherniak, Bruce
Reviewed-by: Bruce Cherniak > On Jun 8, 2017, at 5:42 PM, Tim Rowley wrote: > > Remove c++14 generic lambda to keep compiler requirement at c++11. > > No regressions on piglit or vtk test suites. > > Tested-by: Chuck Atkins > > CC: mesa-sta...@lists.freedesktop.org > --- > configure.ac

[Mesa-dev] [Bug 101338] Mesa software rendering draws incompletely on Raspberry Pi

2017-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101338 Lloyd Wood changed: What|Removed |Added CC||lloyd.w...@yahoo.co.uk --- Comment #2 from

[Mesa-dev] [PATCH] swr: relax c++ requirement from c++14 to c++11

2017-06-08 Thread Tim Rowley
Remove c++14 generic lambda to keep compiler requirement at c++11. No regressions on piglit or vtk test suites. Tested-by: Chuck Atkins CC: mesa-sta...@lists.freedesktop.org --- configure.ac| 8 src/gallium/drivers/swr/Makefile.am | 4

Re: [Mesa-dev] [PATCH 1/8] r200/radeon: stop calling _ae_invalidate_state() directly

2017-06-08 Thread Timothy Arceri
On 09/06/17 08:28, Ian Romanick wrote: I'm going to tagging changes in src/mesa/drivers/dri/radeon with r100: to prevent confusion with the Gallium radeon: tags. No problem, I will do this in future also. I tested this patch on RV250 (1002:4c66), and there were no piglit changes. Tested-by:

Re: [Mesa-dev] [PATCH 1/8] r200/radeon: stop calling _ae_invalidate_state() directly

2017-06-08 Thread Ian Romanick
I'm going to tagging changes in src/mesa/drivers/dri/radeon with r100: to prevent confusion with the Gallium radeon: tags. I tested this patch on RV250 (1002:4c66), and there were no piglit changes. Tested-by: Ian Romanick On 06/06/2017 11:01 PM, Timothy Arceri wrote: > It is already called via

Re: [Mesa-dev] [PATCH 1/3] spirv: fix OpBitcast when the src and dst bitsize are different

2017-06-08 Thread Connor Abbott
(forgot to Cc Jason) On Thu, Jun 8, 2017 at 3:05 PM, Connor Abbott wrote: > From: Connor Abbott > > Before, we were just implementing it with a move, which is incorrect > when the source and destination have different bitsizes. To implement > it properly, we need to use the 64-bit pack/unpack op

[Mesa-dev] [PATCH crucible 3/4] util: add a simple_pipeline helper function

2017-06-08 Thread Connor Abbott
From: Connor Abbott This helper creates and submits a pipeline with a very simple vertex shader and two triangles that cover the viewport. The user gives a fragment shader and optionally some push constants. The idea is to avoid boilerplate for tests that specifically test shader-only functionali

[Mesa-dev] [PATCH crucible 4/4] add new tests for (un)pack(Uint|Double)2x32()

2017-06-08 Thread Connor Abbott
From: Connor Abbott (un)packUint2x32() was broken on anv, and all four functions were broken on radv. Signed-off-by: Connor Abbott --- Makefile.am | 2 + src/tests/func/shader/pack_unpack.c | 172 2 files changed, 174 insertions(+)

[Mesa-dev] [PATCH crucible 2/4] glsl_scraper: add the ability to specify preprocessor directives

2017-06-08 Thread Connor Abbott
From: Connor Abbott Right now, if you try to put something like: in a shader, the C preprocessor will try to interpret that line and barf. Now glsl_scraper.py will strip out ///, so you can do something like: ///#extension GL_foo : enable and it'll be ignored when compiling the file itself. Ye

[Mesa-dev] [PATCH crucible 1/4] glsl_scraper: make shaders use version 4.50

2017-06-08 Thread Connor Abbott
From: Connor Abbott For whatever reason, glslang requires GLSL 4.50 for enabling GL_ARB_shader_ballot, even though it doesn't have any version requirement. And GL_ARB_gpu_shader_int64 does officially require GLSL 4.00, which means that int64 tests will need to use at least that version. Bumping t

[Mesa-dev] [PATCH crucible 0/4] Add tests for 64-bit pack/unpack operations

2017-06-08 Thread Connor Abbott
From: Connor Abbott This series adds tests for the bugs fixed in "Fixes for 64-bit support on radv and anv". It also adds some stuff that will be useful for testing the shader ballot and shader group vote extensions. Apparently the Vulkan CTS will be getting better int64 support soon, which will

[Mesa-dev] [PATCH 0/3] Fixes for 64-bit support on radv and anv

2017-06-08 Thread Connor Abbott
From: Connor Abbott This series fixes a few things I noticed while adding support for the shader ballot extension to radv. In order to convert from the GLSL semantics to the SPIR-V semantics for ballotARB(), glslang inserts a call to unpackUint2x32, which maps to OpBitcast in SPIR-V which we were

[Mesa-dev] [PATCH 1/3] spirv: fix OpBitcast when the src and dst bitsize are different

2017-06-08 Thread Connor Abbott
From: Connor Abbott Before, we were just implementing it with a move, which is incorrect when the source and destination have different bitsizes. To implement it properly, we need to use the 64-bit pack/unpack opcodes. Since glslang uses OpBitcast to implement packInt2x32 and unpackInt2x32, this

[Mesa-dev] [PATCH 2/3] ac/nir: implement 64-bit packing and unpacking

2017-06-08 Thread Connor Abbott
From: Connor Abbott We implement the split opcodes, and tell NIR to lower the original ones. The lowering to LLVM is a little more complicated, but NIR can optimize the split ones a little better, and some NIR lowering passes that we might want to use (particularly for doubles) emit the split one

[Mesa-dev] [PATCH 3/3] radv: enable Int64 capability (v2)

2017-06-08 Thread Connor Abbott
From: Dave Airlie I'm not 100% sure this is all wired up but it looks like it is. v2: actually enable extension. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 2 +- src/amd/vulkan/radv_pipeline.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vu

Re: [Mesa-dev] [PATCH] gallium: fixed modulo zero crashes in tgsi interpreter

2017-06-08 Thread Roland Scheidegger
The behavior is probably undefined for most of the opcodes (signed 32bit div, all 64bit div/mod), the docs don't state anything. But in general, this is all undefined in all apis (opencl, glsl, spir-v), with the only exception being d3d10 - which only has udiv and umod, hence these stating in the g

Re: [Mesa-dev] [PATCH 1/3] mesa: add gl_driver_flags::NewScissor{Rect, Test}

2017-06-08 Thread Ian Romanick
Is there any particular application that these series should help? Was a performance improvement measured? On 06/06/2017 12:59 PM, Samuel Pitoiset wrote: > _NEW_SCISSOR mesa flag is set when a scissor test is enabled/disabled > or when a new rectangle is defined. However, it triggers too much > c

[Mesa-dev] [Bug 101326] gallium/wgl: Allow context creation without prior SetPixelFormat()

2017-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101326 --- Comment #2 from frank.rich...@gmail.com --- I'm trying to coerce a Chromium-based browser component to render WebGL using an llvmpipe Mesa. At one point during initialization, it creates a short-lived context just to obtain some function add

Re: [Mesa-dev] [PATCH] radeonsi: call LLVMAddEarlyCSEMemSSAPass only for LLVM >= 4.0

2017-06-08 Thread Marek Olšák
Pushed, thanks! Marek On Thu, Jun 8, 2017 at 9:22 PM, Juan A. Suarez Romero wrote: > LLVMAddEarlyCSEMemSSAPass() is defined in LLVM 4.0. > > Fixes: 257b538 ("radeonsi: do EarlyCSEMemSSA LLVM pass) > --- > src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 2 ++ > 1 file changed, 2 insertions

Re: [Mesa-dev] [PATCH 3/3] mesa: make use of NewScissorTest driver flags

2017-06-08 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Tue, Jun 6, 2017 at 9:59 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/mesa/main/enable.c | 2 ++ > src/mesa/state_tracker/st_context.c | 4 +--- > 2 files changed, 3 insertions(+), 3 deletions(-) > > di

Re: [Mesa-dev] [PATCH v2 27/64] gallium/util: add new util_dynarray_{shrink, delete} helpers

2017-06-08 Thread Samuel Pitoiset
On 06/08/2017 07:39 PM, Marek Olšák wrote: On Thu, Jun 8, 2017 at 12:26 PM, Samuel Pitoiset wrote: On 06/07/2017 06:21 PM, Nicolai Hähnle wrote: On 30.05.2017 22:35, Samuel Pitoiset wrote: These helpers will be used for handling dynamic arrays of resident texture/image handles. Signed-

Re: [Mesa-dev] [PATCH 8/8] mesa: rework _ae_invalidate_state() so that it just sets a dirty flag

2017-06-08 Thread Marek Olšák
If you address Brian's comments, patches 1, 4-8 are: Reviewed-by: Marek Olšák Marek On Wed, Jun 7, 2017 at 8:02 AM, Timothy Arceri wrote: > --- > src/mesa/main/api_arrayelt.c | 26 +- > src/mesa/main/api_arrayelt.h | 2 +- > src/mesa/vbo/vbo_context.h | 9 +

Re: [Mesa-dev] [PATCH] radv: introduce perf test env var and allow to enable chaining

2017-06-08 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Jun 8, 2017 at 9:04 PM, Dave Airlie wrote: > From: Dave Airlie > > We have some features that seem to slow things down or cause other > possible undesireable side effects, but it would be nice to test > games etc with them easily. > > I forsee multisample

Re: [Mesa-dev] [PATCH 2/2] gbm: implement FD import with modifier

2017-06-08 Thread Robert Foss
This patch has been tested on Android on the iMX6. Tested-by: Robert Foss On Thu, 2017-06-08 at 20:56 +0200, Lucas Stach wrote: > This implements a way to import FDs with modifiers on plain GBM > devices, > without the need to go through EGL. This is mostly to the benefit of > gbm_gralloc, which

Re: [Mesa-dev] [PATCH 1/2] gbm: add API to to import FD with modifier

2017-06-08 Thread Robert Foss
This patch has been tested on Android on the iMX6. Tested-by: Robert Foss On Thu, 2017-06-08 at 20:56 +0200, Lucas Stach wrote: > This allows to import an FD with an explicit modifier passed through > userspace protocols. > > Signed-off-by: Lucas Stach > --- >  src/gbm/main/gbm.h | 12 +++

[Mesa-dev] [Bug 101326] gallium/wgl: Allow context creation without prior SetPixelFormat()

2017-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101326 --- Comment #1 from Brian Paul --- I may not have time to look at this for a few days. But one question: did you find this because a particular app is working differently with Mesa than NVIDIA/AMD/Intel? I guess I'd like to hear more backgroun

[Mesa-dev] [Bug 101338] Mesa software rendering draws incompletely on Raspberry Pi

2017-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101338 --- Comment #1 from Brian Paul --- Can you attach the output of glxinfo? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mail

Re: [Mesa-dev] [PATCH] gallium: fixed modulo zero crashes in tgsi interpreter

2017-06-08 Thread Brian Paul
Marius, As long as you're working on this, would you review src/gallium/docs/source/tgsi.rst to check if all the div/mod instructions document div/mod by zero behavior? Thanks. -Brian On 06/08/2017 11:10 AM, Roland Scheidegger wrote: I don't really know if it makes sense to have different

Re: [Mesa-dev] [PATCH 7/7] i965: Add format/modifier advertising

2017-06-08 Thread Jason Ekstrand
On Tue, Jun 6, 2017 at 10:18 AM, Daniel Stone wrote: > From: Varad Gautam > > v2: Rebase and reuse tiling/modifier map. (Daniel Stone) > v3: bump DRIimageExtension to version 15, fill external_only array. > > Signed-off-by: Varad Gautam > Signed-off-by: Daniel Stone > --- > src/mesa/drivers/d

[Mesa-dev] [PATCH] radeonsi: call LLVMAddEarlyCSEMemSSAPass only for LLVM >= 4.0

2017-06-08 Thread Juan A. Suarez Romero
LLVMAddEarlyCSEMemSSAPass() is defined in LLVM 4.0. Fixes: 257b538 ("radeonsi: do EarlyCSEMemSSA LLVM pass) --- src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_setup.c b/src/gallium/drivers/rade

[Mesa-dev] [PATCH] radv: introduce perf test env var and allow to enable chaining

2017-06-08 Thread Dave Airlie
From: Dave Airlie We have some features that seem to slow things down or cause other possible undesireable side effects, but it would be nice to test games etc with them easily. I forsee multisample DCC and maybe some shader opt changes using this. For now use it for batch chaining. Signed-off

[Mesa-dev] [PATCH 1/2] gbm: add API to to import FD with modifier

2017-06-08 Thread Lucas Stach
This allows to import an FD with an explicit modifier passed through userspace protocols. Signed-off-by: Lucas Stach --- src/gbm/main/gbm.h | 12 1 file changed, 12 insertions(+) diff --git a/src/gbm/main/gbm.h b/src/gbm/main/gbm.h index b52137ed01d4..6a9bf1fc2a80 100644 --- a/src/

[Mesa-dev] [PATCH 2/2] gbm: implement FD import with modifier

2017-06-08 Thread Lucas Stach
This implements a way to import FDs with modifiers on plain GBM devices, without the need to go through EGL. This is mostly to the benefit of gbm_gralloc, which can keep its dependencies low. Signed-off-by: Lucas Stach --- src/gbm/backends/dri/gbm_dri.c | 54 +

[Mesa-dev] [RFC 12/22] anv: Set anv_surface::offset earlier

2017-06-08 Thread Daniel Stone
From: Chad Versace Set anv_surface::offset *before* calling add_surface(). No intended change in behavior. This patch prepares for supporting user-provided surface offsets, a feature required for VK_MESAX_external_image_dma_buf. Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_image.c | 1

[Mesa-dev] [RFC 06/22] anv: Annotate anv_get_*format() as pure

2017-06-08 Thread Daniel Stone
From: Chad Versace Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index c4a897d061..f121b55d91 100644 --- a/src/intel/vulkan/anv_private.h +++

[Mesa-dev] [RFC 19/22] RFC: anv: Drop unused anv_image_create()

2017-06-08 Thread Daniel Stone
From: Chad Versace Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_image.c | 26 ++ src/intel/vulkan/anv_private.h | 5 - 2 files changed, 6 insertions(+), 25 deletions(-) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index a1cc514

[Mesa-dev] [RFC 09/22] anv/image: Fix return type of make_surface()

2017-06-08 Thread Daniel Stone
From: Chad Versace make_surface() always returns VK_SUCCESS, so change its return type to 'void'. This simplifies the return-code handling in anv_image_create_info() and removes a goto. Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_image.c | 15 ++- 1 file changed, 2 inserti

[Mesa-dev] [RFC 13/22] RFC: vulkan: Update registry for MESAX dma_buf extensions

2017-06-08 Thread Daniel Stone
From: Chad Versace Update vulkan.h and vk.xml from [1]: git://github.com/chadversary/vulkan-spec refs/tags/chadv/test/2017-03-06-VK_MESAX_external This pulls in the following extensions: - VK_EXT_get_image_properties - VK_MESAX_external_memory_dma_buf - VK_MESAX_external_image_dma_buf

[Mesa-dev] [RFC 21/22] RFC: vulkan/wsi: Add modifiers to WSI image creation

2017-06-08 Thread Daniel Stone
Allow the WSI to provide a set of modifiers to be used along with the format. For now, no winsys provides any modifier support. Add a fallback to the previous default (X-tiling) inside ANV. RADV remains somewhat broken in the presence of a winsys which will suggest modifiers, but with a Vulkan dr

[Mesa-dev] [RFC 10/22] anv/image: Refactor creation of aux surfaces

2017-06-08 Thread Daniel Stone
From: Chad Versace Creation of hiz, ccs, and mcs surfaces was encoded by a giant 'if' tree at the tail of make_surface(). This patch extracts that 'if' tree into the new functions: make_hiz_surface_maybe() make_ccs_surface_maybe() make_mcs_surface_maybe() For clarity, also rename ma

[Mesa-dev] [RFC 14/22] RFC: anv: Implement VK_EXT_get_image_properties

2017-06-08 Thread Daniel Stone
From: Chad Versace Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vulkan/anv_image.c| 13 + 2 files changed, 14 insertions(+) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index

[Mesa-dev] [RFC 15/22] RFC: anv: Implement VK_MESAX_external_memory_dma_buf

2017-06-08 Thread Daniel Stone
From: Chad Versace For now, we support dma_bufs only for VkBuffers. The VK_MESAX_external_memory_dma_buf spec allows us to support dma_buf VkImages, but we choose to defer that support until VK_MESAX_external_image_dma_buf. Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_device.c

[Mesa-dev] [RFC 20/22] RFC: anv: Drop unneeded struct anv_image_create_info

2017-06-08 Thread Daniel Stone
From: Chad Versace Now that anv_image_create() is gone, there is no need for struct anv_image_create_info. The struct just adds an unused layer of indirection. Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_image.c | 38 +++--- src/intel/vulkan/anv_priva

[Mesa-dev] [RFC 17/22] RFC: anv: Drop vkCreateDmaBufImageINTEL()

2017-06-08 Thread Daniel Stone
From: Chad Versace This "extension" function predates Vulkan 1.0 and Vulkan WSI. We created it during the early days of bringing up the Vulkan driver. We used it for testing the early driver because, in those early days, there was no other way to import/export a tiled VkImage and examine it. No V

[Mesa-dev] [RFC 07/22] anv/image: Better var names in vkCreateImage

2017-06-08 Thread Daniel Stone
From: Chad Versace - Rename the anv_image_create_info vars from 'create_info' to 'anv_info'. - Rename the VkImageCreateInfo vars from 'pCreateInfo' and 'vk_info' to 'base_info'. This reduces the diff and eliminates ambiguity in follow-up patches for upcoming extensions, because the extensions

[Mesa-dev] [RFC 08/22] anv/image: Refactor how tiling is chosen

2017-06-08 Thread Daniel Stone
From: Chad Versace The code that chooses the image's tiling flags, extract it into a new function, choose_isl_tiling_flags(). This reduces the diff in future patches for the upcoming dma_buf-import extension, in which the the tiling code will become more complex. Signed-off-by: Daniel Stone --

[Mesa-dev] [RFC 18/22] RFC: anv/wsi: Use VK_MESAX_external_image_dma_buf

2017-06-08 Thread Daniel Stone
From: Chad Versace When creating a VkSurface for X11, we created the underlying VkImage by calling anv_image_create() and passing driver-private info to it. We can now accomplish the same thing without driver-private info, using VK_MESAX_external_image_dma_buf. In anv_wsi.c, replace the combo o

[Mesa-dev] [RFC 16/22] RFC: anv: Implement VK_MESAX_external_image_dma_buf

2017-06-08 Thread Daniel Stone
From: Chad Versace For now, we support dma_buf images for only a single format, VK_FORMAT_R8G8B8A8_UNORM. And the image must be a "simple" image: 2D, single-sample, non-mipmappped, non-array, non-cube. Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_device.c | 4 + src/intel/

[Mesa-dev] [RFC 22/22] RFC: vulkan/wsi: Add support for DRI3 v1.1

2017-06-08 Thread Daniel Stone
Adds support for multiple planes and buffer modifiers. Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_wsi.c | 7 +- src/vulkan/wsi/wsi_common_x11.c | 137 2 files changed, 131 insertions(+), 13 deletions(-) diff --git a/src/intel/vulkan/anv_

[Mesa-dev] [RFC 11/22] anv: Handle failure in make_hiz_surface_maybe()

2017-06-08 Thread Daniel Stone
From: Chad Versace make_ccs_surface_maybe() correctly handles failure isl_surf_get_ccs_surf(). When it fails, the resultant VkImage is still valid, just without a ccs surface. Same of make_mcs_surface_maybe() and isl_surf_get_mcs_surf(). Fix make_hiz_surface_maybe() to do the same. Signed-off-

[Mesa-dev] [RFC 01/22] RFC: egl/x11: Support DRI3 v1.1

2017-06-08 Thread Daniel Stone
From: Louis-Francis Ratté-Boulianne Add support for DRI3 v1.1, which allows pixmaps to be backed by multi-planar buffers, or those with format modifiers. This is both for allocating render buffers, as well as EGLImage imports from a native pixmap (EGL_NATIVE_PIXMAP_KHR). Signed-off-by: Daniel St

[Mesa-dev] [RFC 02/22] intel/isl: Add ISL <-> DRM modifier conversion

2017-06-08 Thread Daniel Stone
From: Chad Versace It converts a DRM format modifier to and from enum isl_tiling and aux_usage. That's all. Signed-off-by: Daniel Stone --- src/intel/Makefile.isl.am | 1 + src/intel/isl/isl.c | 59 +++ src/intel/isl/isl.h | 16 +

[Mesa-dev] [RFC 05/22] anv: Add func anv_get_raw_format()

2017-06-08 Thread Daniel Stone
From: Chad Versace Like anv_get_format(), but the returned format is not adjusted, not even for the aspect. Add anv_get_raw_isl_format() too, to match anv_get_isl_format(). Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_formats.c | 7 +++ src/intel/vulkan/anv_private.h | 8

[Mesa-dev] [RFC 04/22] isl: Add isl_surf_get_drm_format_mod()

2017-06-08 Thread Daniel Stone
From: Chad Versace Signed-off-by: Daniel Stone --- src/intel/isl/isl.c | 35 +++ src/intel/isl/isl.h | 15 +++ 2 files changed, 50 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 330c3d6c87..b78a22df8c 100644 --- a/src/inte

[Mesa-dev] [RFC 03/22] intel/isl: Add ISL <-> GEM tiling conversion

2017-06-08 Thread Daniel Stone
Add a simple conversion from ISL tiling to GEM BO tiling flags, and use that instead of hardcoding I915_TILING_X in the ANV WSI. Signed-off-by: Daniel Stone --- src/intel/isl/isl.c| 28 src/intel/isl/isl.h| 8 src/intel/vulkan/anv_wsi.c | 6

[Mesa-dev] [RFC 00/22] DRI3 v1.1, ANV dmabuf

2017-06-08 Thread Daniel Stone
Hi, With full support for modifiers in DRIimage, this patch series adds support for fully plumbing them through X11. A patchset proposing an extension to DRI3 to support multiple planes and modifiers can be found here: https://lists.x.org/archives/xorg-devel/2017-June/053854.html The Git trees, al

[Mesa-dev] [PATCH 3.2/24] intel/genxml: Make 3DSTATE_CONSTANT_BODY on Gen10 use arrays

2017-06-08 Thread Anuj Phogat
From: Ander Conselvan de Oliveira This patch will be squashed with "[PATCH 03/24] i965/cnl: Add gen10.xml" before upstreaming. Signed-off-by: Ander Conselvan de Oliveira Signed-off-by: Anuj Phogat Cc: Jason Ekstrand --- src/intel/genxml/gen10.xml | 14 ++ 1 file changed, 6 inser

[Mesa-dev] [PATCH 3.1/24] intel/genxml: Add gen10 alias for MOCS

2017-06-08 Thread Anuj Phogat
From: Ander Conselvan de Oliveira This patch will be squashed with PATCH 3/24 before upstreaming. Signed-off-by: Ander Conselvan de Oliveira Cc: Jason Ekstrand --- src/intel/genxml/gen10.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/genxml/gen10.xml b/src/intel/genxml/gen

Re: [Mesa-dev] [PATCH 3/8] st/mesa: add st_invalidate_buffers() helper

2017-06-08 Thread Marek Olšák
It would be better if the function wasn't inline and was placed before st_invalidate_state to keep those two together. Marek On Wed, Jun 7, 2017 at 8:02 AM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_cb_fbo.c | 5 +++-- > src/mesa/state_tracker/st_context.c | 15 +++ >

Re: [Mesa-dev] [PATCH] egl: fix _eglQuerySurface in EGL_BUFFER_AGE_EXT case

2017-06-08 Thread Chad Versace
On Thu 08 Jun 2017, Tapani Pälli wrote: > Specification states that in case of error, value should not be > written, patch changes buffer age queries to return -1 in case of > error so that we can skip changing the value. > > In addition, small change to droid_query_buffer_age to return 0 > in cas

Re: [Mesa-dev] [PATCH v14 14/36] st/dri: support format modifier queries

2017-06-08 Thread Lucas Stach
Am Dienstag, den 30.05.2017, 17:23 +0530 schrieb Varad Gautam: > From: Varad Gautam > > ask the driver for supported modifiers for a given format. > > v2: move to __DRIimageExtension v16. > v3: fail if the supplied format is not supported by driver. > v4: purge PIPE_CAP_QUERY_DMABUF_ATTRIBS. > v

Re: [Mesa-dev] [PATCH v14 13/36] gallium: introduce format modifier querying

2017-06-08 Thread Lucas Stach
Am Dienstag, den 30.05.2017, 17:23 +0530 schrieb Varad Gautam: > From: Varad Gautam > > format modifiers tokens are driver specific, and hence, need to come > in from the driver. this allows drivers to be queried for supported > format modifiers for EGL_EXT_image_dma_buf_import_modifiers. > > v2

Re: [Mesa-dev] [PATCH 0/6] i965: Add RGBX, RGBA configs, even on gen9

2017-06-08 Thread Chad Versace
On Thu 08 Jun 2017, Tomasz Figa wrote: > On Thu, Jun 8, 2017 at 4:08 PM, Tapani Pälli wrote: > > > > On 06/08/2017 09:36 AM, Tapani Pälli wrote: > >> > >> > >> > >> On 06/08/2017 06:05 AM, Tomasz Figa wrote: > >>> > >>> On Wed, Jun 7, 2017 at 5:36 AM, Chad Versace > >>> wrote: > > More

Re: [Mesa-dev] [PATCH] i915g: Add blitter_context argument.

2017-06-08 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jun 8, 2017 at 9:21 AM, Vinson Lee wrote: > Fix build error. > > CC i915_surface.lo > i915_surface.c:108:63: error: too few arguments to function call, expected 4, > have 3 >util_blitter_default_src_texture(&src_templ, src, src_level); >~~

Re: [Mesa-dev] [PATCH v14 10/36] st/dri: implement createImageWithModifiers in DRIimage

2017-06-08 Thread Lucas Stach
Am Dienstag, den 30.05.2017, 17:23 +0530 schrieb Varad Gautam: > From: Varad Gautam > > adds a pscreen->resource_create_with_modifiers() to create textures > with modifier. > > v2: > - stylefixes (Emil Velikov) > - don't return selected modifier from resource_create_with_modifiers. we can > us

Re: [Mesa-dev] [PATCH v14 09/36] st/dri: enable DRIimage modifier queries

2017-06-08 Thread Lucas Stach
Am Dienstag, den 30.05.2017, 17:23 +0530 schrieb Varad Gautam: > From: Varad Gautam > > return the modifier selected by the driver when creating this image. > > v2: since we can use winsys_handle->modifier to serve these, remove > DRIimage->modifier from v1. > use DRM_API_HANDLE_TYPE_KMS

Re: [Mesa-dev] [PATCH v14 08/36] gallium/winsys/drm: introduce modifier field to winsys_handle

2017-06-08 Thread Lucas Stach
Am Dienstag, den 30.05.2017, 17:23 +0530 schrieb Varad Gautam: > From: Varad Gautam > > we use this to import resources with format modifiers, and to support > per-resource modifier queries. > > Signed-off-by: Varad Gautam > Cc: Lucas Stach Reviewed-by: Lucas Stach > --- > src/gallium/incl

Re: [Mesa-dev] [PATCH] i915g: Add blitter_context argument.

2017-06-08 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez Romero On Thu, 2017-06-08 at 07:21 +, Vinson Lee wrote: > Fix build error. > > CC i915_surface.lo > i915_surface.c:108:63: error: too few arguments to function call, expected 4, > have 3 >util_blitter_default_src_texture(&src_templ, src, src_level);

Re: [Mesa-dev] [PATCH 6/6] i965/dri: Support R8G8B8A8 and R8G8B8X8 configs

2017-06-08 Thread Chad Versace
On Thu 08 Jun 2017, Rob Herring wrote: > On Tue, Jun 6, 2017 at 3:37 PM, Chad Versace wrote: > > The Android framework requires support for EGLConfigs with > > HAL_PIXEL_FORMAT_RGBX_ and HAL_PIXEL_FORMAT_RGBA_. > > > > Even though all RGBX formats are disabled on gen9 by > > brw_surface_fo

Re: [Mesa-dev] [PATCH 00/11] i965: Use BLORP for depth/stencil clears

2017-06-08 Thread Jason Ekstrand
On Tue, Jun 6, 2017 at 9:59 PM, Jason Ekstrand wrote: > This little series switches the GL driver to use BLORP for depth and > stencil clears. BLORP has had depth/stencil clear support ever since we > started using it in the Vulkan driver but we didn't hook it up in GL > because of a few very ha

[Mesa-dev] [PATCH] intel/blorp: Work around Sandy Bridge occlusion query issue

2017-06-08 Thread Jason Ekstrand
--- src/intel/blorp/blorp_clear.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c index 3d5c41c..efacadf 100644 --- a/src/intel/blorp/blorp_clear.c +++ b/src/intel/blorp/blorp_clear.c @@ -479,6 +479,16 @@ blorp_clear_dep

[Mesa-dev] [Bug 100402] [d3d9 bisected] Diablo III fails to start after commit 0630d3600bfb770cf3b23761c45b3add3b277c6b

2017-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100402 Nick Tenney changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v2 27/64] gallium/util: add new util_dynarray_{shrink, delete} helpers

2017-06-08 Thread Marek Olšák
On Thu, Jun 8, 2017 at 12:26 PM, Samuel Pitoiset wrote: > > > On 06/07/2017 06:21 PM, Nicolai Hähnle wrote: >> >> On 30.05.2017 22:35, Samuel Pitoiset wrote: >>> >>> These helpers will be used for handling dynamic arrays of resident >>> texture/image handles. >>> >>> Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH] Reduce zlib requirement from 1.2.8 to 1.2.3.

2017-06-08 Thread Chuck Atkins
Testing with zlib versions 1.2.{3,4,5,6,7,8} showed no difference in functionality, correctness, or zlib API usage and 1.2.3 is the oldest version available in still actively deployed production Linux distributions (RHEL/CentOS 6 and SuSE 11). Signed-off-by: Chuck Atkins Cc: 17.1 Cc: Timothy Arc

Re: [Mesa-dev] [PATCH] gallium: fixed modulo zero crashes in tgsi interpreter

2017-06-08 Thread Roland Scheidegger
I don't really know if it makes sense to have different "error values" for signed vs. unsigned modulo 0 - maybe the "all bits set" approach would do too (the gallivm code does this, because it is actually easier). But since it's undefined in any case pretty much everywhere, I suppose any value will

Re: [Mesa-dev] [PATCH 01/10] i965/blorp: Take a layer range in intel_hiz_exec

2017-06-08 Thread Anuj Phogat
Patches 1-6, 8 are: Reviewed-by: Anuj Phogat On Mon, Jun 5, 2017 at 5:55 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 13 - > src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++- > src/mesa/drivers/dri/i965/brw_clear.c | 10 --

[Mesa-dev] [PATCH] gallium: fixed modulo zero crashes in tgsi interpreter

2017-06-08 Thread Marius Gräfe
softpipe throws integer division by zero exceptions on windows when using % with integers in a geometry shader. --- src/gallium/auxiliary/tgsi/tgsi_exec.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/ga

Re: [Mesa-dev] [PATCH 6/6] etnaviv: upgrade DISCARD_RANGE to DISCARD_WHOLE_RESOURCE if possible

2017-06-08 Thread Lucas Stach
Am Donnerstag, den 08.06.2017, 15:08 +0200 schrieb Wladimir J. van der Laan: > Hello Lucas, > > On Thu, Jun 08, 2017 at 10:26:04AM +0200, Lucas Stach wrote: > > Hi Wladimir, > > > > did you also review this patch? It's the last one of this series missing > > review. > > Sorry, no, I missed it so

[Mesa-dev] [PATCH 2/2] etnaviv: remove flat shading workaround

2017-06-08 Thread Lucas Stach
It turned out not to be a hardware bug, but the shader compiler emitting wrong varying component use information. With that fixed we can turn flat shading back on. Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_rasterizer.c | 6 +- 1 file changed, 1 insertion(+), 5 deleti

[Mesa-dev] [PATCH 1/2] etnaviv: fix varying interpolation

2017-06-08 Thread Lucas Stach
It seems that newer cores don't use the PA_ATTRIBUTES to decide if the varying should bypass the flat shading, but derive this from the component use. This fixes flat shading on GC880+. VARYING_COMPONENT_USE_POINTCOORD is a bit of a misnomer now, as it isn't only used for pointcoords, but missing

  1   2   >