Re: [Mesa-dev] [PATCH v4 1/3] dri: Add UYVY as available format

@Kristian -Original Message- From: Lin, Johnson Sent: Thursday, June 22, 2017 11:28 AM To: mesa-dev@lists.freedesktop.org Cc: Lin, Johnson Subject: [PATCH v4 1/3] dri: Add UYVY as available format UYVY is diffrent with YUYV in byte order. YUYV is already declared

[Mesa-dev] [PATCH v4 2/3] nir: Add a lowering pass for UYVY textures

Similar with support for YUYV but with byte order difference in sampler --- src/compiler/nir/nir.h | 1 + src/compiler/nir/nir_lower_tex.c | 18 ++ 2 files changed, 19 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index

[Mesa-dev] [PATCH v4 1/3] dri: Add UYVY as available format

UYVY is diffrent with YUYV in byte order. YUYV is already declared in dri_interface.h, this CL add the difinitions for UYVY. Drivers can add UYVY as supported format --- include/GL/internal/dri_interface.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v4 3/3] i965/i915: Add UYVY as the supported format

Trigger the correct sampler options for it. Similar with YUYV --- src/intel/compiler/brw_compiler.h| 1 + src/intel/compiler/brw_nir.c | 1 + src/mesa/drivers/dri/i915/intel_screen.c | 21 - src/mesa/drivers/dri/i965/brw_wm.c | 7 +++

[Mesa-dev] [Bug 101552] Make GALLIUM_HUD lower the grid max value if metric stays much lower all the time

https://bugs.freedesktop.org/show_bug.cgi?id=101552 --- Comment #2 from Shmerl --- Thanks for the pointer! That helps indeed. I think for something like FPS metric, it can be a useful default. But then I guess you might want to have a negative modifier (counterpart to d).

Re: [Mesa-dev] radeonsi: ppc64 glamor backtrace

On 22/06/17 02:56 AM, Grazvydas Ignotas wrote: > Looks like nobody tested radeonsi on BE for 5 months at least. You can > try the attached patch, but I suspect there will be other places like > this... Yeah, this is just the tip of the iceberg. There are many reasons why radeonsi currently can't

[Mesa-dev] [Bug 101552] Make GALLIUM_HUD lower the grid max value if metric stays much lower all the time

https://bugs.freedesktop.org/show_bug.cgi?id=101552 Michel Dänzer changed: What|Removed |Added Resolution|--- |INVALID

[Mesa-dev] [Bug 101552] Make GALLIUM_HUD lower the grid max value if metric stays much lower all the time

https://bugs.freedesktop.org/show_bug.cgi?id=101552 Bug ID: 101552 Summary: Make GALLIUM_HUD lower the grid max value if metric stays much lower all the time Product: Mesa Version: git Hardware: All OS:

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

On Wed, Jun 21, 2017 at 8:15 PM, Marek Olšák wrote: > On Wed, Jun 21, 2017 at 10:37 PM, Rob Clark wrote: >> On Tue, Jun 20, 2017 at 6:54 PM, Marek Olšák wrote: >>> Hi, >>> >>> This series updates pipe loaders so that flags such as drirc

[Mesa-dev] [PATCH] i965: perf: minimize the chances to spread queries across batchbuffers

Counter related to timings will be sensitive to any delay introduced by the software. In particular if our begin & end of performance queries end up in different batches, time related counters will exhibit biffer values caused by the time it takes for the kernel driver to load new requests into

Re: [Mesa-dev] [PATCH] i965/gen6: Use isl-based miptree also for stencil rbs

On Wed, Jun 21, 2017 at 2:48 PM, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > On Wed, Jun 21, 2017 at 12:35 PM, Topi Pohjolainen < > topi.pohjolai...@gmail.com> wrote: > >> Fixes dEQP-EGL.functional.image.render_multiple_contexts. >>

Re: [Mesa-dev] [PATCH v2 13/13] anv/gpu_memcpy: Rename the gpu_memcpy function

I never liked the gpu_memcpy name anyway because I knew something like this would come up. I left you one trivial comment on patch 1. Other than that, the series is Reviewied-by: Jason Ekstrand Given that you're changing core blorp, please make sure you run this through

Re: [Mesa-dev] [PATCH v2 12/13] anv/blorp: Provide surface states for CCS resolves

On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery wrote: > In the future, we plan on using this method to resolve images whose > surface state fast-clear value is dynamically updated during command > buffer execution. Start using it now for testing and to reduce churn > later

Re: [Mesa-dev] [PATCH v2 01/13] intel/blorp: Assert levels and layers are in range

On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery wrote: > v2 (Jason Ekstrand): > - Update commit title > - Check aux level and layer as well > > Signed-off-by: Nanley Chery > Reviewed-by: Iago Toral Quiroga (v1) > --- >

[Mesa-dev] [PATCH 09/11] gallium/hud: add glthread counters

From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 9 src/gallium/auxiliary/hud/hud_cpu.c | 74 + src/gallium/auxiliary/hud/hud_private.h | 8 3 files changed, 91 insertions(+) diff --git

[Mesa-dev] [PATCH 10/11] mesa/glthread: decrease the batch size for better perf scaling

From: Marek Olšák This is the key to better performance. --- src/mesa/main/glthread.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/glthread.h b/src/mesa/main/glthread.h index 36692fe..dd65931 100644 ---

[Mesa-dev] [PATCH 07/11] gallium/hud: add hud_pane::hud pointer

From: Marek Olšák for later use --- src/gallium/auxiliary/hud/hud_context.c | 8 +--- src/gallium/auxiliary/hud/hud_private.h | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c

[Mesa-dev] [PATCH 11/11] drirc: whitelist glthread for a few games

From: Marek Olšák Performance deltas: Alien Isolation: +17% (it varies depending on the location) Borderlands 2: +50% (it varies depending on the location) BioShock Infinite: +76% (benchmark) Civilization 6: +20% (benchmark) ---

[Mesa-dev] [PATCH 06/11] mesa/glthread: add glthread "perf" counters and pass them to gallium HUD

From: Marek Olšák for HUD integration in following commits. This valuable profiling data will allow us to see on the HUD how well glthread is able to utilize parallelism. This is better than benchmarking, because you can see exactly what's happening and you don't have to be

[Mesa-dev] [PATCH 08/11] gallium/hud: add API-thread-busy for monitoring the thread load

From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 5 - src/gallium/auxiliary/hud/hud_cpu.c | 19 +-- src/gallium/auxiliary/hud/hud_private.h | 2 +- 3 files changed, 22 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 05/11] gallium/hud: move struct hud_context to hud_private.h

From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 46 --- src/gallium/auxiliary/hud/hud_private.h | 48 + 2 files changed, 48 insertions(+), 46 deletions(-) diff --git

[Mesa-dev] [PATCH 01/11] util: move pipe_thread_is_self from gallium to src/util

From: Marek Olšák --- src/gallium/auxiliary/os/os_thread.h | 11 --- src/gallium/state_trackers/nine/nine_state.c | 2 +- src/util/u_thread.h | 12 3 files changed, 13 insertions(+), 12 deletions(-) diff --git

[Mesa-dev] [PATCH 03/11] mesa/glthread: switch to u_queue and redesign the batch management

From: Marek Olšák This mirrors exactly how u_threaded_context works. If you understand this, you also understand u_threaded_context. --- src/mesa/main/glthread.c | 191 ++- src/mesa/main/glthread.h | 88 --

[Mesa-dev] [PATCH 00/11] glthread cleanup, 4 whitelisted games!

Hi, This series: - cleans up glthread, mainly switches the implementation to u_queue and rearranges it so that it looks like gallium/u_threaded_context - adds "performance" counters for monitoring glthread behavior and display them on the gallium HUD - decreases the batch size for much better

[Mesa-dev] [PATCH 04/11] gallium/hud: rename API-thread-busy to main-thread-busy

From: Marek Olšák --- src/gallium/auxiliary/hud/hud_context.c | 4 ++-- src/gallium/auxiliary/hud/hud_cpu.c | 4 ++-- src/gallium/auxiliary/hud/hud_private.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/hud/hud_context.c

[Mesa-dev] [PATCH 02/11] mesa/glthread: remove HAVE_PTHREAD guards

From: Marek Olšák we are switching to util_queue. --- src/mapi/glapi/gen/gl_marshal.py | 5 + src/mesa/main/glthread.c | 4 src/mesa/main/glthread.h | 30 -- src/mesa/main/marshal.c | 4

Re: [Mesa-dev] [PATCH 00/30] i965: Add support for I915_FORMAT_MOD_Y_TILED_CCS

On Fri, Jun 16, 2017 at 3:41 PM, Jason Ekstrand wrote: > This series is a rework of Ben's series to enable the CCS format modifier. > It started as an attempt to rebase his original patches on top of my > resolve reworks inside the miptree code. However, as I started to

Re: [Mesa-dev] [PATCH 3/5] st/dri: add a drirc workaround for Rocket League

On Wed, Jun 21, 2017 at 4:32 PM, Roland Scheidegger wrote: > Am 21.06.2017 um 00:54 schrieb Marek Olšák: >> From: Marek Olšák >> >> This needs to be passed to gallium drivers. >> --- >> src/gallium/include/pipe/p_defines.h| 6 ++ >>

Re: [Mesa-dev] [PATCH] drirc: Add glsl_correct_derivatives_after_discard for The Witcher 2

Thanks. Applied locally to my branch. If I get an OK to push my series, I'll push your patch too. Marek On Wed, Jun 21, 2017 at 10:40 PM, Edmondo Tommasina wrote: > This fixes the long-standing problem with black transitions in The Wicher 2. > > Bugzilla:

[Mesa-dev] [PATCH v2 08/13] anv/blorp: Remove 3D subresource transition workaround

For 3D image subresources undergoing a layout transition via PipelineBarrier, we increase the number of fast-cleared layers to match the intended behaviour of KHR_maintenance1. When such subresources undergo layout transitions between subpasses, we don't do this to avoid failing incorrect CTS

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

On Wed, Jun 21, 2017 at 10:37 PM, Rob Clark wrote: > On Tue, Jun 20, 2017 at 6:54 PM, Marek Olšák wrote: >> Hi, >> >> This series updates pipe loaders so that flags such as drirc options >> can be passed to create_screen(). I have compile-tested everything

[Mesa-dev] [PATCH v2 11/13] anv/blorp: Add a surface-state-based CCS resolve function

This will be used in the next patch. v2: - Omit BLORP_BATCH_NO_EMIT_DEPTH_STENCIL (Jason Ekstrand) - Update commit message. Signed-off-by: Nanley Chery Reviewed-by: Iago Toral Quiroga --- src/intel/vulkan/anv_blorp.c | 38

[Mesa-dev] [PATCH v2 09/13] anv: Adjust params of color buffer transitioning functions

Splitting out these fields will make the color buffer transitioning function simpler when it gains more features. v2: Remove unintended blank line (Iago Toral) Signed-off-by: Nanley Chery Reviewed-by: Iago Toral Quiroga ---

[Mesa-dev] [PATCH v2 07/13] anv/cmd_buffer: Adjust the image view reloc function

Make the function take in an image instead of an image view. This enables us to record relocations for surfaces states created outside of the anv_CreateImageView path. v2 (Jason Ekstrand): - Use image->offset instead of surf_offset in aux_offset calculation. Signed-off-by: Nanley Chery

[Mesa-dev] [PATCH v2 12/13] anv/blorp: Provide surface states for CCS resolves

In the future, we plan on using this method to resolve images whose surface state fast-clear value is dynamically updated during command buffer execution. Start using it now for testing and to reduce churn later on. Signed-off-by: Nanley Chery Reviewed-by: Iago Toral

[Mesa-dev] [PATCH v2 10/13] blorp/clear: Add a binding-table-based CCS resolve function

v2: - Do layered resolves. (Jason Ekstrand): - Replace "bt" suffix with "attachment". - Rename helper function to prepare_ccs_resolve. - Move blorp_params_init() into helper function. Signed-off-by: Nanley Chery Reviewed-by: Iago Toral Quiroga ---

[Mesa-dev] [PATCH v2 05/13] anv: Add and use color auxiliary buffer helpers

v2: - Check for aux levels in layer helper (Jason Ekstrand) - Don't assert aux is present, return 0 if it isn't. - Use the helpers. v3: - Make the helpers aspect-agnostic (Jason Ekstrand) - Drop anv_image_has_color_aux() Signed-off-by: Nanley Chery Reviewed-by: Iago

[Mesa-dev] [PATCH v2 13/13] anv/gpu_memcpy: Rename the gpu_memcpy function

A GPU memcpy function could alternatively be implemented using MI_* commands. Provide more detail into how this one operates in case another memcpy function is created. v2: - Update the commit message. v3: - Use 'memcpy' instead of 'cpy' (Jason Ekstrand) - Shorten 'streamout' to 'so'

[Mesa-dev] [PATCH v2 04/13] intel/isl: Only create a CCS buffer if the image supports rendering

v2: Omit the commit message. Signed-off-by: Nanley Chery Reviewed-by: Jason Ekstrand (v1) Reviewed-by: Iago Toral Quiroga --- src/intel/isl/isl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2 02/13] intel/blorp: Check for layer fast-clear restriction

v2: Update commit title (Jason Ekstrand) Signed-off-by: Nanley Chery Reviewed-by: Iago Toral Quiroga (v1) --- src/intel/blorp/blorp_clear.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/intel/blorp/blorp_clear.c

Re: [Mesa-dev] [PATCH 01/11] intel/genxml: Add better support for MI_MATH in gen10

Reviewed-by: Rafael Antognolli On Tue, Jun 13, 2017 at 11:28:20AM -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/genxml/gen10.xml | 69 > +++--- > 1 file changed, 65

Re: [Mesa-dev] [PATCH 07/13] anv/blorp: Remove 3D subresource transition workaround

On Wed, Jun 21, 2017 at 09:04:01AM +0200, Iago Toral wrote: > On Tue, 2017-06-20 at 12:21 -0700, Nanley Chery wrote: > > On Mon, Jun 19, 2017 at 04:19:36PM -0700, Jason Ekstrand wrote: > > > On Wed, Jun 14, 2017 at 3:06 PM, Nanley Chery > > m> wrote: > > > > > > > On Wed,

Re: [Mesa-dev] [PATCH] radeonsi: use the correct LLVMTargetMachineRef in si_build_shader_variant

On Tue, Jun 20, 2017 at 10:56 PM, Samuel Pitoiset wrote: > > > On 06/20/2017 10:53 PM, Samuel Pitoiset wrote: >> >> I have just tested this patch with Hero Siege, it still crashes. >> >> As you said, it's definitely a multithreading issue because it crashes >>

Re: [Mesa-dev] [PATCH] i965/CFL: Add PCI Ids for Coffee Lake.

>-Original Message- >From: Anuj Phogat [mailto:anuj.pho...@gmail.com] >Sent: Wednesday, June 21, 2017 12:32 PM >To: Srivatsa, Anusha >Cc: mesa-dev@lists.freedesktop.org; Vivi, Rodrigo ; >Phogat, Anuj ; Widawsky,

Re: [Mesa-dev] [PATCH] i965/miptree: Move isl_surf_get_(hiz|mcs)_surf out of the assert

On Thu, 22 Jun 2017 at 00:12 Matt Turner wrote: > On Wed, Jun 21, 2017 at 3:50 PM, Mike Lothian wrote: > > Do intel run mesa through any of their test boxes like they do with > kernel > > patches? > > Don't top quote. > > Yes, we have a CI system that we

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

Emil, If I understand you correctly, you're proposing to add the ability to use the kms_swrast driver in platform_x11.c (the host is a standard Ubuntu box for the emulator use case, not CrOS) alongside swrast. In that case, we would need to: 1) Have a dri2_initialize_x11_kms_swrast function

[Mesa-dev] [RFC mesa] travis: add couple missing proto+lib

> configure: error: Package requirements (x11 xext xdamage >= 1.1 xfixes > x11-xcb xcb xcb-glx >= 1.8.1 xcb-dri2 >= 1.8) were not met: > No package 'xdamage' found > No package 'xfixes' found They each depend on their own *proto. Signed-off-by: Eric Engestrom --- .travis.yml

Re: [Mesa-dev] [PATCH] glsl: do not reset prog->TransformFeedback.BufferStride

On 22/06/17 02:41, Juan A. Suarez Romero wrote: On Wed, 2017-06-21 at 20:24 +1000, Timothy Arceri wrote: On 21/06/17 18:13, Juan A. Suarez Romero wrote: link_xfb_stride_layout_qualifiers() can be called multiple times, and each time we call prog->TransformFeedback.BufferStride is reset to 0.

Re: [Mesa-dev] [PATCH v2] glsl: reset BufferStride with explicit xfb_stride

On 22/06/17 02:41, Juan A. Suarez Romero wrote: link_xfb_stride_layout_qualifiers() can be called multiple times, and each time we call prog->TransformFeedback.BufferStride is reset to 0. But we should only reset it if the shaders provide an explicit stride. Fixes:

Re: [Mesa-dev] [PATCH] i965/miptree: Move isl_surf_get_(hiz|mcs)_surf out of the assert

On Wed, Jun 21, 2017 at 3:50 PM, Mike Lothian wrote: > Do intel run mesa through any of their test boxes like they do with kernel > patches? Don't top quote. Yes, we have a CI system that we use extensively and has massively reduced the number of regressions we have.

Re: [Mesa-dev] [PATCH 0/5] GL_OES_required_internalformat

Tapani Pälli writes: > On 06/14/2017 01:12 AM, Eric Anholt wrote: >> Tapani Pälli writes: >> >>> On 06/12/2017 09:52 AM, Tapani Pälli wrote: On 05/18/2017 09:39 PM, Eric Anholt wrote: > Eric Anholt writes: >

Re: [Mesa-dev] [PATCH] i965/miptree: Move isl_surf_get_(hiz|mcs)_surf out of the assert

Do intel run mesa through any of their test boxes like they do with kernel patches? On Wed, 21 Jun 2017 at 19:23 Jason Ekstrand wrote: > On Wed, Jun 21, 2017 at 11:20 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > >> On Wed, Jun 21, 2017 at 11:16:39AM

Re: [Mesa-dev] [PATCH 3/3] radv: Rename winsys enums.

Oops missed these, Reviewed-by: Dave Airlie On 11 June 2017 at 08:02, Bas Nieuwenhuizen wrote: > Don't rename the enums and constants used for metadata. > > Signed-off-by: Bas Nieuwenhuizen > --- >

Re: [Mesa-dev] [PATCH] i915: Fix gl_Fragcoord interpolation

On 06/21/2017 10:38 AM, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > gl_FragCoord contains the window coordinates so it seems to me that > we should not use perspective correct interpolation for it. At least > now I get similar output as

Re: [Mesa-dev] [PATCH 3/3] glsl: relax loop unrolling restrictions

On 22/06/17 01:42, Eero Tamminen wrote: Hi, On 21.06.2017 13:12, Timothy Arceri wrote: The main reason these restriction exist is because glsl the loop unrolling pass is super slow with large loops. be5f27a84d0d fixed things so that expression trees were counted against the limit, however it

Re: [Mesa-dev] [PATCH] i965/gen6: Use isl-based miptree also for stencil rbs

Reviewed-by: Jason Ekstrand On Wed, Jun 21, 2017 at 12:35 PM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Fixes dEQP-EGL.functional.image.render_multiple_contexts. > gles2_renderbuffer_stencil_stencil_buffer > > CC: Mark Janes > CC:

Re: [Mesa-dev] [PATCH 3/5] egl/android: Rename var in droid_add_configs_for_visuals()

On Friday, 2017-06-16 19:37:48 -0700, Chad Versace wrote: > Rename 'config' to 'config_count'. I didn't understand what the variable I think you mean "Rename 'count' to 'config_count'" :) Agreed with Emil about making the same change across all platforms (one of these days I'll dedup those,

Re: [Mesa-dev] [PATCH 5/5] egl/android: Change order of EGLConfig generation

On Friday, 2017-06-16 19:37:50 -0700, Chad Versace wrote: > Many Android apps (such as Google's official NDK GLES2 example app), and > even portions the core framework code (such as SystemServiceManager in > Nougat), incorrectly choose their EGLConfig. They neglect to match the > EGLConfig's

Re: [Mesa-dev] [PATCH 05/30] i965/miptree: Rework aux enabling

On Wed 21 Jun 2017, Jason Ekstrand wrote: > On Wed, Jun 21, 2017 at 12:33 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Fri 16 Jun 2017, Jason Ekstrand wrote: > > This commit replaces the complex and confusing set of disable flags with > > two fairly straightforward

[Mesa-dev] [PATCH mesa v2] egl: properly count configs

dri2_conf represents another config (which shouldn't be counted) if it doesn't have the requested ID. Reported-by: Liu Zhiquan Signed-off-by: Eric Engestrom --- v2: use original `count+1` comparison. --- src/egl/drivers/dri2/platform_android.c | 3

[Mesa-dev] [PATCH] drirc: Add glsl_correct_derivatives_after_discard for The Witcher 2

This fixes the long-standing problem with black transitions in The Wicher 2. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98238 --- This patch depends on Marek's series: https://patchwork.freedesktop.org/series/26089/

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

On Tue, Jun 20, 2017 at 6:54 PM, Marek Olšák wrote: > Hi, > > This series updates pipe loaders so that flags such as drirc options > can be passed to create_screen(). I have compile-tested everything > except clover. > > The first pipe_screen flag is a drirc option to fix

[Mesa-dev] [PATCH 3/4] etnaviv: add R8G8 texture support

Passes texwrap GL_ARB_texture_rg piglit (with faked full texture rg support). Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/4] etnaviv: add support for extended texture formats

Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 2 +- src/gallium/drivers/etnaviv/etnaviv_format.h | 1 + src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 +++ src/gallium/drivers/etnaviv/etnaviv_texture.c | 8 +--- 4 files

[Mesa-dev] [PATCH 2/4] etnaviv: add support for swizzled texture formats

Passes all ext_texture_swizzle piglits. Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 91 ++- src/gallium/drivers/etnaviv/etnaviv_format.h | 4 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +-

[Mesa-dev] [PATCH 4/4] etnaviv: add support for snorm textures

Based on a patch from Wladimir J. van der Laan and untested due to lack of hardware. Binary blob emits those formats if GPU supports HALTI1 (faked with ibvivhook). Signed-off-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_format.c | 7 ---

Re: [Mesa-dev] [PATCH 2/6] i965: Add a RGBX->RGBA fallback for glEGLImageTextureTarget2D()

On Tue 20 Jun 2017, Jason Ekstrand wrote: > On Wed, Jun 7, 2017 at 4:45 PM, Chad Versace <[1]chadvers...@chromium.org> > wrote: > > On Tue 06 Jun 2017, Daniel Stone wrote: > > Hi Chad, > > > > On 6 June 2017 at 21:36, Chad Versace <[2]chadvers...@chromium.org> > wrote: > >

Re: [Mesa-dev] [PATCH 05/30] i965/miptree: Rework aux enabling

On Wed, Jun 21, 2017 at 12:33 PM, Chad Versace wrote: > On Fri 16 Jun 2017, Jason Ekstrand wrote: > > This commit replaces the complex and confusing set of disable flags with > > two fairly straightforward fields which describe the intended auxiliary > > surface usage

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

Hi Marek In patch 5 you say the words KILL and WQM and I automatically think at Witcher 2. This series with a the drirc option set for Witcher 2 fixes the longstanding black transition bug. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98238 It's quite probable that VP will not update

Re: [Mesa-dev] [PATCH 05/30] i965/miptree: Rework aux enabling

On Fri 16 Jun 2017, Jason Ekstrand wrote: > This commit replaces the complex and confusing set of disable flags with > two fairly straightforward fields which describe the intended auxiliary > surface usage and whether or not the miptree supports fast clears. > Right now, supports_fast_clear can

[Mesa-dev] [PATCH] i965/gen6: Use isl-based miptree also for stencil rbs

Fixes dEQP-EGL.functional.image.render_multiple_contexts. gles2_renderbuffer_stencil_stencil_buffer CC: Mark Janes CC: Jason Ekstrand CC: Kenneth Graunke Signed-off-by: Topi Pohjolainen ---

Re: [Mesa-dev] [PATCH 05/30] i965/miptree: Rework aux enabling

On Fri 16 Jun 2017, Jason Ekstrand wrote: > This commit replaces the complex and confusing set of disable flags with > two fairly straightforward fields which describe the intended auxiliary > surface usage and whether or not the miptree supports fast clears. > Right now, supports_fast_clear can

Re: [Mesa-dev] [PATCH] i965/CFL: Add PCI Ids for Coffee Lake.

On Wed, Jun 21, 2017 at 11:19 AM, Anusha Srivatsa wrote: > Coffee Lake has a gen9 graphics following KBL. > From 3D perspective, CFL is a clone of KBL/SKL features. > > v2: Change commit message, correct alignment > v3: Update IDs. > > Cc: Benjamin Widawsky

Re: [Mesa-dev] [PATCH v3 3/3] i965/i915: Add UYVY as the supported format

Johnson Lin writes: > Trigger the correct sampler options for it. Similar with YUYV > --- > src/intel/compiler/brw_compiler.h| 1 + > src/intel/compiler/brw_nir.c | 1 + > src/mesa/drivers/dri/i915/intel_screen.c | 9 ++--- >

Re: [Mesa-dev] [PATCH v3 1/3] dri: Add UYVY as available format

Johnson Lin writes: > UYVY is diffrent with YUYV in byte order. > YUYV is already declared in dri_interface.h, > this CL add the difinitions for UYVY. > Drivers can add UYVY as supported format This series looks good now. There are a few stylistic nits in the comment

Re: [Mesa-dev] [PATCH 06/30] i965: Move the DRIimage -> miptree code to intel_mipmap_tree.c

On Fri, Jun 16, 2017 at 03:41:28PM -0700, Jason Ekstrand wrote: > This is mostly a direct port. The only bit of refactoring that was done > was to make creating a planar miptree be an early return from the > non-planar case. Alternatively, we could have three functions: two > helpers and a main

Re: [Mesa-dev] [PATCH] i965: Remove spurious mutex frobbing around call to intel_miptree_blit

Ian Romanick writes: > On 06/20/2017 01:33 PM, Kristian Høgsberg wrote: >> On Mon, Jun 19, 2017 at 2:33 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> These locks were added in 2f28a0dc, but I don't see anything in

Re: [Mesa-dev] [PATCH] nv50/ir: Properly fold constants in SPLIT operation

Wait, this is actively buggy! How did this ever work :( I guess we don't split immediates too frequently, and I was testing it with zero's or something. Can you figure out the commit where I added this idiotic code and add a Fixes: tag? Reviewed-by: Ilia Mirkin Cc:

Re: [Mesa-dev] [PATCH] i965/miptree: Move isl_surf_get_(hiz|mcs)_surf out of the assert

On Wed, Jun 21, 2017 at 11:20 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Jun 21, 2017 at 11:16:39AM -0700, Jason Ekstrand wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101538 > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101539 > > I

Re: [Mesa-dev] [PATCH] i965/miptree: Move isl_surf_get_(hiz|mcs)_surf out of the assert

On Wed, Jun 21, 2017 at 11:16:39AM -0700, Jason Ekstrand wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101538 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101539 I guess also: https://bugs.freedesktop.org/show_bug.cgi?id=101535 Thanks for the quick fix!!

[Mesa-dev] [PATCH] i965/CFL: Add PCI Ids for Coffee Lake.

Coffee Lake has a gen9 graphics following KBL. From 3D perspective, CFL is a clone of KBL/SKL features. v2: Change commit message, correct alignment v3: Update IDs. Cc: Benjamin Widawsky Cc: Anuj Phogat Cc: Rodrigo Vivi

[Mesa-dev] [PATCH libdrm 3/3] intel: PCI Ids for U SKU in CFL

Add the PCI IDs for U SKU IN CFL by following the spec. v2: Update IDs Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- intel/intel_chipset.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH libdrm 2/3] intel: PCI Ids for H SKU in CFL

Add the PCI IDs for H SKU IN CFL by following the spec. v2: Update IDs Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- intel/intel_chipset.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/intel/intel_chipset.h

[Mesa-dev] [PATCH libdrm 1/3] intel: PCI Ids for S SKU in CFL

Add the PCI IDs for S SKU IN CFL by following the spec. v2: Update IDs. Cc: Rodrigo Vivi Signed-off-by: Anusha Srivatsa --- intel/intel_chipset.h | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] i965/miptree: Move isl_surf_get_(hiz|mcs)_surf out of the assert

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101538 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101539 Cc: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH v2 05/12] i965: Convert CC state on gen4-5 to genxml.

Use set_blend_entry_bits and set_depth_stencil_bits to fill most of the color calc struct, and then manually update the rest. v2: - Always check for depth_irb (Ken) - Always set Backface Stencil Ref (Ken) - Always set alpha reference value (Ken) Signed-off-by: Rafael Antognolli

[Mesa-dev] [PATCH v2 10/12] i965: Convert CLIP_STATE to genxml.

The code doesn't get exactly a lot simpler but at least it is in a single place, and we delete more than we add. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/Makefile.sources| 1 - src/mesa/drivers/dri/i965/brw_clip_state.c| 147

[Mesa-dev] [PATCH v2 11/12] i965: Convert WM_STATE to genxml on gen4-5.

The code doesn't get exactly a lot simpler but at least it is in a single place, and we delete more than we add. Another good point is that you get rid of struct brw_wm_unit_state which was a third mechanism for encoding GEN state. We used to have GENXML, manual packing and these bitfield

[Mesa-dev] [PATCH v2 07/12] i965: Remove upload_gs_state_for_tf.

This function only emits a particular case of 3DSTATE_GS. Instead, we can do that inside genX(upload_gs_state), and later reuse part of that code for emitting gen4-5 state. There's the additional benefit of allowing us to remove gen6_gs_state.c, which was only left because of this function.

[Mesa-dev] [PATCH v2 01/12] i965: Make a helper function for depth/stencil related state.

From: Kenneth Graunke Gen4-5 basically glue DEPTH_STENCIL_STATE, COLOR_CALC_STATE, and BLEND_STATE together into a single COLOR_CALC_STATE structure. By making a helper function, we'll be able to reuse it when filling out Gen4-5 COLOR_CALC_STATE without replicating any

[Mesa-dev] [PATCH v2 02/12] i965: Make a helper function for blend entry related state.

Add a helper function to reuse code that fills blend entry related state, and make genX(upload_blend_state) use it. This function can later be used by gen4-5 color calc state to set the blend related bits. Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke

[Mesa-dev] [PATCH v2 12/12] i965: Remove a lot of constants from brw_defines.h.

These were originally used to submit state changes using manual packing of instructions, but we are now using genxml for that. So it should be safe to just remove them. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_defines.h | 729

[Mesa-dev] [PATCH v2 03/12] i965: Check for alpha channel just like in gen6+.

gen6+ uses _mesa_base_format_has_channel() to check for the alpha channel, while gen4-5 use ctx->DrawBuffer->Visual.alphaBits. By using _mesa_base_format_has_channel() here we keep the same behavior accross all gen. While initially both ways of checking the alpha channel seemed correct to me,

[Mesa-dev] [PATCH v2 08/12] i965: Prepare gs_state emitting code to include gen4-5.

Since we always call brw_batch_emit anyways, we can hopefully make things simpler by calling it only once, and then branching inside its body. This can be helpful when bringing the gen4-5 code into this function. Additionally, check for GEN_GEN == 6 instead of < 7 in cases that won't apply to

[Mesa-dev] [PATCH v2 09/12] i965: Convert GS_STATE to genxml.

Merge the code with gen6+ 3DSTATE_GS, and delete brw_gs_state.c, together with brw_gs_unit_state. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/Makefile.sources| 1 - src/mesa/drivers/dri/i965/brw_gs_state.c | 101

[Mesa-dev] [PATCH v2 06/12] i965: Convert BLEND_CONSTANT_COLOR state to genxml.

It's a very simple conversion, and it allows us to delete brw_cc.c. Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/Makefile.sources| 1 - src/mesa/drivers/dri/i965/brw_cc.c| 62

[Mesa-dev] [PATCH v2 04/12] i965: Move color calc code around a bit.

This makes the code more consistent accross generations. Signed-off-by: Rafael Antognolli Reviewed-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_cc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] i965: Remove spurious mutex frobbing around call to intel_miptree_blit

On 06/20/2017 01:33 PM, Kristian Høgsberg wrote: > On Mon, Jun 19, 2017 at 2:33 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> These locks were added in 2f28a0dc, but I don't see anything in the >> intel_miptree_blit path that should make this

Re: [Mesa-dev] [PATCH 2/2] ac/nir: Make intrinsic_name buffer long enough

On Wed, Jun 21, 2017 at 6:59 PM, James Legg wrote: > When using cmpswap on an image, it was being trunctated to > lvm.amdgcn.image.atomic.cmpswa, with the coords type missing entirely. You could add an assert to catch this easier in future, like MAYBE_UNUSED int ret;

Re: [Mesa-dev] [PATCH] anv: FORMAT_FEATURE_TRANSFER_SRC/DST_BIT_KHR not used with VkFormatProperties.bufferFeatures

Reviewed-by: Jason Ekstrand On Wed, Jun 14, 2017 at 9:55 AM, Andres Gomez wrote: > VK_FORMAT_FEATURE_TRANSFER_[SRC|DST]_BIT_KHR is a flag value of the > VkFormatFeatureFlagBits enum that can only be hold and checked against > the linearTilingFeatures or

  1   2   >