[Mesa-dev] [PATCH] svga: adjust line subpixel position for HWv8

2017-07-05 Thread Brian Paul
This fixes two regressions on HWv8: Piglit gl-1.0-ortho-pos Piglit/glean fbo This was caused by commit c2b92dada076a "svga: clamp device line width to at least 1 to fix HWv8 line stippling" This also fixes two conform tests: Vertex Order and Polygon Face No Piglit/conform changes with HWv9

[Mesa-dev] [PATCH 2/4] ac/llvm: create features list using snprintf.

2017-07-05 Thread Dave Airlie
From: Dave Airlie Just more moving code around before adding things to it. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_util.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_llvm_util.c

[Mesa-dev] [PATCH 1/4] ac/radv: change api to create target machine

2017-07-05 Thread Dave Airlie
From: Dave Airlie This just modifies the API to make it easier to add other flags to target machine creation. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_util.c | 4 ++-- src/amd/common/ac_llvm_util.h | 5 -

[Mesa-dev] [Bug 101560] SPIR-V OpSwitch with int64 not supported even though shaderInt64 is true

2017-07-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101560 --- Comment #3 from programmerj...@gmail.com --- you could implement an initial type-deduction pass; you shouldn't need to know the cfg for that to work, because the OpPhi instructions state their type. -- You are receiving this mail because:

[Mesa-dev] [PATCH 3/4] ac/llvm: set xnack like radeonsi does.

2017-07-05 Thread Dave Airlie
From: Dave Airlie Use family, but only set xnack+ for gfx9. Signed-off-by: Dave Airlie --- src/amd/common/ac_llvm_util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_util.c b/src/amd/common/ac_llvm_util.c

Re: [Mesa-dev] [PATCH 1/3] intel/drm: Pull in the i916 fence array API

2017-07-05 Thread Jason Ekstrand
On Wed, Jul 5, 2017 at 1:25 PM, Matt Turner wrote: > s/i916/i965/ in title. > i915 but yes. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] gallium: auxiliary: Fix standalone Android build of u_cpu_detect

2017-07-05 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 2:49 AM, Emil Velikov wrote: > Hi Tomasz, > > On 5 July 2017 at 15:58, Tomasz Figa wrote: >> Commit 463b7d0332c5("gallium: Enable ARM NEON CPU detection.") >> introduced CPU feature detection based Android cpufeatures library.

[Mesa-dev] [PATCH 2/2] radv: predicate cmask eliminate when using DCC.

2017-07-05 Thread Dave Airlie
From: Dave Airlie When using DCC some clear values don't require a cmask eliminate step. This patch adds support for black and black with alpha 1, there are other values, but I don't have access to a comprehensive list. This works by setting the cmask eliminate predicate

[Mesa-dev] [PATCH 1/2] radv/clear: add r32g32b32a32 fast clear support (v2)

2017-07-05 Thread Dave Airlie
From: Dave Airlie We can only fast clear 128-bit images if the r/g/b channels are the same, and we are using DCC. For DCC we'll bail out on translate if this isn't true, and we catch cmask clears explicitly. v2: remove 64-bit block (Bas), add uint32 as well. Signed-off-by:

[Mesa-dev] [Bug 101666] bitfieldExtract is marked as a built-in function on OpenGL ES 3.0, but was added in OpenGL ES 3.1

2017-07-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101666 Ilia Mirkin changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 15/19] mesa: hook up UUID queries for driver and device

2017-07-05 Thread Jason Ekstrand
On Wed, Jul 5, 2017 at 4:50 PM, Dave Airlie wrote: > > > > > > This is something I've been on the fence about for a while, mostly > > because the vulkan and gl driver for mesa come out of the same source > > base. > > In addition to the issues raised by Jason, radv isn't the

Re: [Mesa-dev] [PATCH 15/19] mesa: hook up UUID queries for driver and device

2017-07-05 Thread Dave Airlie
> > This is something I've been on the fence about for a while, mostly > because the vulkan and gl driver for mesa come out of the same source > base. In addition to the issues raised by Jason, radv isn't the only Vulkan driver for AMD GPUs. I don't think Andres patch should be made jump

[Mesa-dev] [Bug 101560] SPIR-V OpSwitch with int64 not supported even though shaderInt64 is true

2017-07-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101560 --- Comment #2 from Jason Ekstrand --- Ugh... I guess I didn't read the language on OpSwitch all that carefully the first time around. This is going to be exceedingly painful to do correctly. In order to know the number

Re: [Mesa-dev] [PATCH 17.5/18] nir/spirv: Stop trying to convert pointers to SSA in glsl450

2017-07-05 Thread Jason Ekstrand
On Mon, Jul 3, 2017 at 3:10 PM, Connor Abbott wrote: > This, and patch 18 updated to delete the case in vtn_ssa_value() are: > > Reviewed-by: Connor Abbott > Thanks! Pushed. The one tiny change I made was to add a vtn_pointer_for_variable helper to

Re: [Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

2017-07-05 Thread Chad Versace
On Sat 01 Jul 2017, Marek Olšák wrote: > Hi Rob, > > It would be better to have a flag passed from libEGL to st/dri saying > that it's OK to expose those formats. I wouldn't like to have GLX > visuals that are unusable in practice because X doesn't support that > component ordering. At least on

Re: [Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

2017-07-05 Thread Chad Versace
On Fri 30 Jun 2017, Rob Herring wrote: > Add support for 32-bit RGBX/RGBA formats which are required for Android. > > The original patch (commit ccdcf91104a5) was reverted (commit > c0c6ca40a25e) in mesa as it broke GLX resulting in swapped colors. Based > on further investigation by Chad

Re: [Mesa-dev] [PATCH v2 00/73] Experimental NIR backend for radeonsi

2017-07-05 Thread Connor Abbott
Hi, On Wed, Jul 5, 2017 at 3:47 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Hi all, > > Here's an updated version of the NIR backend series. Most of the comments > have been integrated, and where they haven't been fully integrated, I think >

[Mesa-dev] [PATCH] scons: Check for xlocale.h before defining HAVE_XLOCALE_H.

2017-07-05 Thread Vinson Lee
glibc 2.26 removed xlocale.h. https://sourceware.org/glibc/wiki/Release/2.26#Removal_of_.27xlocale.h.27 Fix this build error with glibc 2.26. Compiling src/util/strtod.c ... src/util/strtod.c:32:10: fatal error: xlocale.h: No such file or directory #include ^~~ Bugzilla:

Re: [Mesa-dev] [PATCH 7/7] i965: Fix asynchronous mappings on !LLC platforms.

2017-07-05 Thread Chris Wilson
Quoting Kenneth Graunke (2017-07-05 21:56:54) > --- > src/mesa/drivers/dri/i965/brw_bufmgr.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c > b/src/mesa/drivers/dri/i965/brw_bufmgr.c > index

[Mesa-dev] [PATCH 1/3] st/mesa: find proper mipmap level in st_ClearTexSubImage()

2017-07-05 Thread Brian Paul
The Piglit arb_clear_texture-error test creates a texture with only a 1x1 image at level=1, then tries to clear level 0 (non-existant) and level 1 (exists). The test only checks that the former generates an error but the later doesn't. The test passes, but when we try to clear the level=1 image

[Mesa-dev] [PATCH 2/3] mesa: new comments, assertion related to glClearTexSubImage

2017-07-05 Thread Brian Paul
--- src/mesa/main/teximage.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 36747a7..7b5df54 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -4361,6 +4361,15 @@ get_tex_obj_for_clear(struct

[Mesa-dev] [PATCH 3/3] mesa: simplify get_tex_images_for_clear()

2017-07-05 Thread Brian Paul
Get rid of redundant code. --- src/mesa/main/teximage.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 7b5df54..5e13025 100644 --- a/src/mesa/main/teximage.c +++

[Mesa-dev] [Bug 101656] Invalid signal timestamps with EGL_SYNC_NATIVE_FENCE_ANDROID on android

2017-07-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101656 Rafael Antognolli changed: What|Removed |Added QA Contact|mesa-dev@lists.freedesktop. |

[Mesa-dev] [PATCH 6/7] i965: Don't use PREAD for glGetBufferSubData().

2017-07-05 Thread Kenneth Graunke
Just map the buffer and memcpy. This will do a CPU mmap, which should be reasonably efficient, and doing this gives us full control over the domains and caching instead of leaving it to the kernel. This prevents regressions on Braswell in the next commit. Specifically

[Mesa-dev] [PATCH 4/7] i965: Disable access to CPU mmap for async access on non-LLC machines

2017-07-05 Thread Kenneth Graunke
From: Chris Wilson If the user triggers an implicit batch flush while holding access to a CPU mapped buffer, that mmapping will be invalidated by the kernel for non-LLC devices. (The kernel when executing a batch will change the cache domain of the buffers in that

[Mesa-dev] [PATCH 5/7] i965: Assert that we don't use CPU write maps to non-coherent buffers.

2017-07-05 Thread Kenneth Graunke
Using CPU maps of non-coherent buffers can get us in a lot of trouble, and WC maps are a reasonable alternative anyway. Guard against shooting ourselves in the foot by adding an assert, and comment. --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 6 ++ 1 file changed, 6 insertions(+) diff

[Mesa-dev] [PATCH 1/7] intel: Move clflush helpers from anv to common/gen_clflush.h.

2017-07-05 Thread Kenneth Graunke
I want to use these in the OpenGL driver as well. Cc: Jason Ekstrand --- src/intel/common/gen_clflush.h | 56 ++ src/intel/vulkan/anv_batch_chain.c | 2 +- src/intel/vulkan/anv_device.c | 2 +- src/intel/vulkan/anv_private.h

[Mesa-dev] [PATCH 2/7] intel: Fix clflushing on modern (Baytrail+) Atom CPUs.

2017-07-05 Thread Kenneth Graunke
Thanks to Chris Wilson for pointing this out. Cc: Jason Ekstrand --- src/intel/common/gen_clflush.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/intel/common/gen_clflush.h b/src/intel/common/gen_clflush.h index 9b971cac37e..84cc2f2f132 100644 ---

[Mesa-dev] [PATCH 3/7] i965: Track when a bo is shared with an external client

2017-07-05 Thread Kenneth Graunke
From: Chris Wilson If the buffer is being shared with an external client, our own state tracking may be stale and in some cases we may wish to double check with the kernel/hw state. At the moment, this is synonymous with not being reusable, but the semantics between

[Mesa-dev] [PATCH 7/7] i965: Fix asynchronous mappings on !LLC platforms.

2017-07-05 Thread Kenneth Graunke
When using a read-only CPU mapping, we may encounter stale buffer contents. For example, the Piglit primitive-restart test offers the following scenario: 1. Read data via a CPU map. 2. Destroy that buffer. 3. Create a new buffer - obtaining the same one via the BO cache. 4. Call

[Mesa-dev] [Bug 68296] Using old viewport value after a window resize (content is clipped)

2017-07-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=68296 Rafael Antognolli changed: What|Removed |Added Status|REOPENED

Re: [Mesa-dev] [PATCH 1/3] intel/drm: Pull in the i916 fence array API

2017-07-05 Thread Matt Turner
s/i916/i965/ in title. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: check if any of the named builtins are available first

2017-07-05 Thread Kenneth Graunke
On Monday, July 3, 2017 2:08:12 PM PDT Ilia Mirkin wrote: > _mesa_glsl_has_builtin_function is used to determine whether any variant > of a builtin are available, for the purpose of enforcing the GLSL ES > 3.00+ rule that overloads or overrides of builtins are disallowed. > > However the

Re: [Mesa-dev] [PATCH v2 02/73] nir: fix nir_lower_wpos_ytransform when gl_FragCoord is a system value

2017-07-05 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Jul 5, 2017 at 3:47 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/compiler/nir/nir_lower_wpos_ytransform.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > >

Re: [Mesa-dev] [PATCH v2 03/73] nir: add load_frag_coord system value intrinsic

2017-07-05 Thread Jason Ekstrand
We've been talking about switching frag_coord to an intrinsic in i965 for a while. It'll take a bit of work, but it's probably good to have the intrinsic anyway. Reviewed-by: Jason Ekstrand On Wed, Jul 5, 2017 at 3:47 AM, Nicolai Hähnle wrote: >

Re: [Mesa-dev] [PATCH v2 01/73] nir: add nir_instr_rewrite_deref

2017-07-05 Thread Jason Ekstrand
I like it Reviewed-by: Jason Ekstrand On Wed, Jul 5, 2017 at 3:47 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Allows modifying a texture instruction's texture and sampler derefs. > --- > src/compiler/nir/nir.c | 13

Re: [Mesa-dev] [PATCH v2] mesa: Avoid set comprehension.

2017-07-05 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Vinson Lee (2017-07-05 11:38:36) > Fix build error on CentOS 6.9 with Python 2.6. > > GENmain/format_fallback.c > File "./main/format_fallback.py", line 42 > names = {fmt.name for fmt in formats} > ^ >

[Mesa-dev] [PATCH v2] mesa: Avoid set comprehension.

2017-07-05 Thread Vinson Lee
Fix build error on CentOS 6.9 with Python 2.6. GENmain/format_fallback.c File "./main/format_fallback.py", line 42 names = {fmt.name for fmt in formats} ^ SyntaxError: invalid syntax Fixes: a1983223d883 ("mesa: Add _mesa_format_fallback_rgbx_to_rgba() [v2]")

Re: [Mesa-dev] [PATCH 3/3] anv: Use DRM sync objects for external semaphores when available

2017-07-05 Thread Jason Ekstrand
On Wed, Jul 5, 2017 at 10:53 AM, Chris Wilson wrote: > Quoting Jason Ekstrand (2017-07-05 18:21:08) > > static void > > anv_cmd_buffer_process_relocs(struct anv_cmd_buffer *cmd_buffer, > >struct anv_reloc_list *list) > > @@ -1450,6

Re: [Mesa-dev] [RFC] travis: lower SWR requirement to GCC 4.8, aka std=c++11

2017-07-05 Thread Rowley, Timothy O
> On Jul 4, 2017, at 12:01 PM, Emil Velikov wrote: > > From: Emil Velikov > > With ealier commit we relaxed the requirement from C++14 to C++11. > Update the build script so that it > > Cc: Tim Rowley Fixes:

[Mesa-dev] [PATCH] Android: Fix vc4 build since XML changes.

2017-07-05 Thread Eric Anholt
For the automake build, -Isrc/ is implied from the gallium cflags, while Android gallium driver builds don't get that by default. I think it'll be better for vc4 to have broadcom includes appear as "#include " to make it more clear where to look in the tree than "#include " does. --- Rob: The

Re: [Mesa-dev] [PATCH 3/3] anv: Use DRM sync objects for external semaphores when available

2017-07-05 Thread Chris Wilson
Quoting Jason Ekstrand (2017-07-05 18:21:08) > static void > anv_cmd_buffer_process_relocs(struct anv_cmd_buffer *cmd_buffer, >struct anv_reloc_list *list) > @@ -1450,6 +1484,14 @@ anv_cmd_buffer_execbuf(struct anv_device *device, > impl->fd = -1; >

Re: [Mesa-dev] [PATCH] egl: android: Fix potential use of unitialized variable

2017-07-05 Thread Emil Velikov
On 5 July 2017 at 16:08, Eric Engestrom wrote: > On 5 July 2017 15:57:10 BST, Tomasz Figa wrote: >> If dri2_setup_extensions() fails, the "err" variable would not be >> assigned >> causing the error path to access an unitialized variable. Fix it by >>

Re: [Mesa-dev] [PATCH] gallium: auxiliary: Fix standalone Android build of u_cpu_detect

2017-07-05 Thread Emil Velikov
Hi Tomasz, On 5 July 2017 at 15:58, Tomasz Figa wrote: > Commit 463b7d0332c5("gallium: Enable ARM NEON CPU detection.") > introduced CPU feature detection based Android cpufeatures library. > Unfortunately it also added an assumption that if PIPE_OS_ANDROID is > defined, the

[Mesa-dev] [PATCH 3/3] anv: Use DRM sync objects for external semaphores when available

2017-07-05 Thread Jason Ekstrand
--- src/intel/vulkan/anv_batch_chain.c | 56 +++ src/intel/vulkan/anv_device.c | 2 + src/intel/vulkan/anv_private.h | 8 src/intel/vulkan/anv_queue.c | 93 -- 4 files changed, 135 insertions(+), 24 deletions(-) diff

[Mesa-dev] [PATCH 2/3] anv/gem: Add a drm syncobj support

2017-07-05 Thread Jason Ekstrand
--- src/intel/vulkan/anv_gem.c | 52 src/intel/vulkan/anv_gem_stubs.c | 24 +++ src/intel/vulkan/anv_private.h | 4 3 files changed, 80 insertions(+) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index

[Mesa-dev] [PATCH 1/3] intel/drm: Pull in the i916 fence array API

2017-07-05 Thread Jason Ekstrand
--- src/intel/drm/i915_drm.h | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/src/intel/drm/i915_drm.h b/src/intel/drm/i915_drm.h index c26bf7c..338c8c2 100644 --- a/src/intel/drm/i915_drm.h +++ b/src/intel/drm/i915_drm.h @@ -431,6 +431,11 @@

[Mesa-dev] [PATCH 0/3] anv: Use DRM sync objects for external semaphores when available

2017-07-05 Thread Jason Ekstrand
This tiny series makes us start using the new DRM syncobj API for external semaphores instead of the dma-buf hack. I'm hoping we can get this reviewed quickly because I'd like to land the kernel bits as soon as possible. Mesa branch:

Re: [Mesa-dev] [PATCH] Android: generate symlinks for all enabled gallium drivers

2017-07-05 Thread Emil Velikov
On 1 July 2017 at 16:52, Mauro Rossi wrote: > Current post install command relies on GALLIUM_TARGET_DRIVERS variable, > however variable needs to be initialized in src/gallium/Android.mk > in order that all enabled gallium drivers symlinks are correctly generated. > > At

Re: [Mesa-dev] [PATCH] st/mesa: find proper mipmap level in st_ClearTexSubImage()

2017-07-05 Thread Brian Paul
Please ignore for now. I need to take a closer look at interaction with GL_ARB_texture_view... -Brian On 07/05/2017 10:31 AM, Brian Paul wrote: The Piglit arb_clear_texture-error test creates a texture with only a 1x1 image at level=1, then tries to clear level 0 (non-existant) and level 1

[Mesa-dev] [PATCH] st/mesa: find proper mipmap level in st_ClearTexSubImage()

2017-07-05 Thread Brian Paul
The Piglit arb_clear_texture-error test creates a texture with only a 1x1 image at level=1, then tries to clear level 0 (non-existant) and level 1 (exists). The test only checks that the former generates an error but the later doesn't. The test passes, but when we try to clear the level=1 image

Re: [Mesa-dev] gallium: Reduce trace_dump_box_bytes size by box->x.

2017-07-05 Thread Cherniak, Bruce
On Jul 4, 2017, at 9:40 AM, Jose Fonseca > wrote: On 29/06/17 11:02, Michel Dänzer wrote: On 29/06/17 01:54 AM, Cherniak, Bruce wrote: On Jun 26, 2017, at 2:10 PM, Marek Olšák > wrote: In my opinion,

Re: [Mesa-dev] [PATCH] egl: android: Fix potential use of unitialized variable

2017-07-05 Thread Eric Engestrom
On 5 July 2017 15:57:10 BST, Tomasz Figa wrote: > If dri2_setup_extensions() fails, the "err" variable would not be > assigned > causing the error path to access an unitialized variable. Fix it by > assigning an error message. > > Signed-off-by: Tomasz Figa

[Mesa-dev] [PATCH] gallium: auxiliary: Fix standalone Android build of u_cpu_detect

2017-07-05 Thread Tomasz Figa
Commit 463b7d0332c5("gallium: Enable ARM NEON CPU detection.") introduced CPU feature detection based Android cpufeatures library. Unfortunately it also added an assumption that if PIPE_OS_ANDROID is defined, the library is also available, which is not true for the standalone build without using

[Mesa-dev] [PATCH] egl: android: Fix potential use of unitialized variable

2017-07-05 Thread Tomasz Figa
If dri2_setup_extensions() fails, the "err" variable would not be assigned causing the error path to access an unitialized variable. Fix it by assigning an error message. Signed-off-by: Tomasz Figa --- src/egl/drivers/dri2/platform_android.c | 4 +++- 1 file changed, 3

[Mesa-dev] [PATCH] intel: common: Fix link failure with standalone Android build

2017-07-05 Thread Tomasz Figa
Some reshuffle in the Makefiles under src/intel resulted in Android libraries being no longer linked with code using src/intel/common/gen_debug.h that contains references to functions exported by those libraries (namely ALOGW macro, which is currently resolved into a call to __android_log_print()

Re: [Mesa-dev] [PATCH v6 1/3] util: Add util_strlcpy

2017-07-05 Thread Brian Paul
On 07/05/2017 12:57 AM, Robert Foss wrote: Add local strlcpy implementation. Signed-off-by: Robert Foss --- Changes since v5: Actually include changes from v5 in patch Changes since v4: Gustaw Smolarczyk - Make util_strlcpy have the

Re: [Mesa-dev] Mesa (master): st/mesa: use pipe_shader_type_from_mesa

2017-07-05 Thread Brian Paul
On 07/05/2017 04:32 AM, Nicolai Hähnle wrote: Module: Mesa Branch: master Commit: 8a4cd79d0049f98d1c0aff7a77aca73647e3f647 URL:

Re: [Mesa-dev] [PATCH 03/16] xmlconfig: remove GL type dependencies

2017-07-05 Thread Emil Velikov
On 5 July 2017 at 14:35, Emil Velikov wrote: > I think it matters too much here, I meant to say "I don't think it matters..." -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

2017-07-05 Thread Emil Velikov
On 5 July 2017 at 13:53, Emil Velikov wrote: > On 5 July 2017 at 13:38, Nicolai Hähnle wrote: >> On 05.07.2017 14:16, Emil Velikov wrote: >>> >>> On 5 July 2017 at 12:58, Nicolai Hähnle wrote: Thanks for doing the test.

Re: [Mesa-dev] [PATCH 03/16] xmlconfig: remove GL type dependencies

2017-07-05 Thread Emil Velikov
Hi Nicolai, On 30 June 2017 at 13:45, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/mesa/drivers/dri/common/xmlconfig.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

2017-07-05 Thread Emil Velikov
On 5 July 2017 at 13:38, Nicolai Hähnle wrote: > On 05.07.2017 14:16, Emil Velikov wrote: >> >> On 5 July 2017 at 12:58, Nicolai Hähnle wrote: >>> >>> Thanks for doing the test. I did get the automated email. >>> >>> This stuff is mostly guess work and

Re: [Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

2017-07-05 Thread Nicolai Hähnle
On 05.07.2017 14:16, Emil Velikov wrote: On 5 July 2017 at 12:58, Nicolai Hähnle wrote: Thanks for doing the test. I did get the automated email. This stuff is mostly guess work and cargo-culting for me since I don't actually have an Android build setup. Is there any way

Re: [Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

2017-07-05 Thread Emil Velikov
On 5 July 2017 at 12:58, Nicolai Hähnle wrote: > Thanks for doing the test. I did get the automated email. > > This stuff is mostly guess work and cargo-culting for me since I don't > actually have an Android build setup. Is there any way for me to test this > easily? > > How

Re: [Mesa-dev] [PATCH 04/16] xmlconfig: move into src/util

2017-07-05 Thread Nicolai Hähnle
Thanks for doing the test. I did get the automated email. This stuff is mostly guess work and cargo-culting for me since I don't actually have an Android build setup. Is there any way for me to test this easily? How about the fixup at https://cgit.freedesktop.org/~nh/mesa/commit/?h=driconf?

Re: [Mesa-dev] [PATCH 5/6] radeonsi: use slot indexes for bindless handles

2017-07-05 Thread Nicolai Hähnle
On 04.07.2017 15:05, Samuel Pitoiset wrote: Using VRAM address as bindless handles is not a good idea because we have to use LLVMIntToPTr and the LLVM CSE pass can't optimize because it has no information about the pointer. Instead, use slots indexes like the existing descriptors. This

[Mesa-dev] [PATCH v2 73/73] radeonsi: enable R600_DEBUG=nir for vertex and fragment shaders

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle Also, disable geometry and tessellation shaders. Mixing and matching NIR and TGSI shaders should work (and I've tested it for the VS/PS interface), but geometry and tessellation requires VS-as-ES/LS, which isn't implemented yet for NIR. ---

[Mesa-dev] [PATCH v2 71/73] radeonsi/nir: lower uniforms to UBO loads

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_nir.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 10b3630..7de8b10 100644 ---

[Mesa-dev] [PATCH v2 72/73] radeonsi: VS as ES/LS are not yet supported with R600_DEBUG=nir

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 7fa76cd..83db876 100644 ---

[Mesa-dev] [PATCH v2 70/73] ac/nir: implement load_frag_coord intrinsic

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 9bb1904..5a972b7 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH v2 64/73] radeonsi: tweak next-shader assumptions when streamout is used

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle VS with streamout is always a HW VS. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c

[Mesa-dev] [PATCH v2 69/73] radeonsi/nir: lower txp instructions

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_nir.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 83c7ab1..10b3630 100644 ---

[Mesa-dev] [PATCH v2 67/73] ac/nir, radeonsi: add and use ac_shader_abi::frag_pos

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: update for LLVMValueRefs in ac_shader_abi --- src/amd/common/ac_nir_to_llvm.c | 30 +- src/amd/common/ac_shader_abi.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 12 3 files

[Mesa-dev] [PATCH v2 68/73] ac/nir: pass ac_llvm_context to unpack_param

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index f8eb0c9..9bb1904 100644 ---

[Mesa-dev] [PATCH v2 65/73] ac/nir, radv: move force_persample to ac_shader_info::force_persample

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle Avoid accessing radv-specific structures during the meat of NIR-to-LLVM translation. --- src/amd/common/ac_nir_to_llvm.c | 4 +--- src/amd/common/ac_nir_to_llvm.h | 1 - src/amd/common/ac_shader_info.c | 6 ++ src/amd/common/ac_shader_info.h

[Mesa-dev] [PATCH v2 66/73] ac/nir, radeonsi: add and use ac_shader_abi::{ancillary, sample_coverage}

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: update for LLVMValueRefs in ac_shader_abi --- src/amd/common/ac_nir_to_llvm.c | 10 -- src/amd/common/ac_shader_abi.h | 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 6 -- 3 files changed, 10 insertions(+), 8

[Mesa-dev] [PATCH v2 63/73] radeonsi: use new function ac_build_umin for edgeflag clamping

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_llvm_build.c | 7 +++ src/amd/common/ac_llvm_build.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c

[Mesa-dev] [PATCH v2 62/73] ac/nir: clamp shadow texture comparison value on VI

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle Needed for TC-compatible HTILE in radeonsi for test cases like piglit spec/arb_texture_rg/execution/fs-shadow2d-red-01.shader_test --- src/amd/common/ac_nir_to_llvm.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2 61/73] ac/nir: add always_vector argument to ac_build_gather_values_extended

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle This simplifies a bunch of places that no longer need special treatment of value_count == 1. We rely on LLVM to optimize away the 1-element vector types. This fixes a bunch of bugs where 1-element arrays are indexed indirectly. ---

[Mesa-dev] [PATCH v2 56/73] radeonsi: make get_indirect_index globally visible

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 20 ++-- src/gallium/drivers/radeonsi/si_shader_internal.h | 3 +++ 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH v2 60/73] ac/nir, radeonsi: add ac_shader_abi::front_face

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle v2: update for LLVMValueRefs in ac_shader_abi --- src/amd/common/ac_nir_to_llvm.c | 5 ++--- src/amd/common/ac_shader_abi.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 16 3 files changed, 15

[Mesa-dev] [PATCH v2 57/73] radeonsi: implement and use ac_shader_abi::load_ssbo

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 16 src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 15 --- 2 files changed, 20 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH v2 59/73] ac/nir: pass ac_nir_context to emit_ddxy

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle Allocating the ddxy_lds is considered to be part of the API shader translation and not part of the ABI. --- src/amd/common/ac_nir_to_llvm.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git

[Mesa-dev] [PATCH v2 58/73] ac/nir: pass ac_nir_context to SSBO intrinsic handlers

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 114 +--- 1 file changed, 59 insertions(+), 55 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 78de557..ef1eeac 100644 ---

[Mesa-dev] [PATCH v2 53/73] ac/nir: extract shader_info->fs.can_discard from NIR shader info

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 16729a8..d20b0fa 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH v2 49/73] ac/nir: whitespace fixes

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index e5f28f2..158d183 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++

[Mesa-dev] [PATCH v2 55/73] ac/nir: load buffer descriptors via ac_shader_abi::load_ssbo

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 28 src/amd/common/ac_shader_abi.h | 10 ++ 2 files changed, 30 insertions(+), 8 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH v2 52/73] radeonsi/nir: perform radeonsi-specific lowering and optimization passes

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_nir.c | 41 1 file changed, 41 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index dc2ef8b..83c7ab1

[Mesa-dev] [PATCH v2 50/73] ac/nir: handle old-style shadow tex instructions correctly

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle The first element is only extracted for new-style shadow tex. --- src/amd/common/ac_nir_to_llvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index

[Mesa-dev] [PATCH v2 48/73] ac/nir: use shader_info pass to determine whether instance_id is used

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle This improves the separation of ABI and NIR translation. --- src/amd/common/ac_nir_to_llvm.c | 7 +-- src/amd/common/ac_shader_info.c | 3 +++ src/amd/common/ac_shader_info.h | 1 + 3 files changed, 9 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v2 54/73] ac/nir: pass ac_nir_context to emit_discard_if

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index d20b0fa..bb314cb 100644 ---

[Mesa-dev] [PATCH v2 51/73] radeonsi/nir: perform lowering of input/output driver locations

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.h| 1 + src/gallium/drivers/radeonsi/si_shader_nir.c| 26 + src/gallium/drivers/radeonsi/si_state_shaders.c | 2 ++ 3 files changed, 29 insertions(+) diff --git

[Mesa-dev] [PATCH v2 40/73] ac/nir: add and use ac_shader_abi::load_sampler_desc

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 108 ++-- src/amd/common/ac_shader_abi.h | 24 + 2 files changed, 84 insertions(+), 48 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH v2 47/73] ac/nir: move setting shader_info->fs.writes_memory to radv-specific code

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 5d7f53e..301cb83 100644 --- a/src/amd/common/ac_nir_to_llvm.c

[Mesa-dev] [PATCH v2 41/73] ac/nir: pass ac_nir_context to tex_fetch_ptrs and related functions

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 155 +--- 1 file changed, 81 insertions(+), 74 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index b8d9296..823b18f 100644 ---

[Mesa-dev] [PATCH v2 42/73] radeonsi/nir: implement ac_shader_abi::load_sampler_desc

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_internal.h | 4 +++ src/gallium/drivers/radeonsi/si_shader_nir.c | 32 +++ src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 26 +- 3 files changed, 49

[Mesa-dev] [PATCH v2 46/73] radeonsi/nir: add image descriptor loading

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_internal.h | 3 +++ src/gallium/drivers/radeonsi/si_shader_nir.c | 15 +++ src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 22 ++ 3 files changed, 32 insertions(+),

[Mesa-dev] [PATCH v2 44/73] ac/nir: add support for arrays-of-arrays to get_sampler_desc

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index 823b18f..62131ca 100644 ---

[Mesa-dev] [PATCH v2 45/73] ac/nir: add image and write parameter to ac_shader_abi::load_sampler_desc

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_nir_to_llvm.c | 43 src/amd/common/ac_shader_abi.h | 4 ++- src/gallium/drivers/radeonsi/si_shader_nir.c | 3 +- 3 files changed, 30 insertions(+), 20 deletions(-) diff

[Mesa-dev] [PATCH v2 43/73] radeonsi/nir: set si_shader_context::num_{sampler, images}

2017-07-05 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader_nir.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index 91796a8..a278ef2 100644 ---

  1   2   >