Re: [Mesa-dev] [PATCH] glsl: xfb_stride applies to buffers, not block members

2017-07-09 Thread Timothy Arceri
On 8 July 2017 12:19:48 am GMT+08:00, "Juan A. Suarez Romero" wrote: >When we have an interface block like: > >layout (xfb_buffer = 0, xfb_offset = 0) out Block { > vec4 var1; >layout (xfb_stride = 48) vec4 var2; > vec4 var3; >}; > >Ac

[Mesa-dev] [PATCH] radv: set cb base tile swizzles for MRT speedups (v3)

2017-07-09 Thread Dave Airlie
From: Dave Airlie This patch uses addrlib to workout the tile swizzles according to the surface index. It seems to produce the same values as amdgpu-pro for the deferred test. v2: don't apply swizzle to CMASK. the eg docs don't mention it, and we clearly don't align cmask for that. v3: disable s

Re: [Mesa-dev] [PATCH] radv: set cb base tile swizzles for MRT speedups (v2)

2017-07-09 Thread Dave Airlie
On 10 July 2017 at 12:20, Dave Airlie wrote: > From: Dave Airlie > > This patch uses addrlib to workout the tile swizzles according > to the surface index. It seems to produce the same values as > amdgpu-pro for the deferred test. > > v2: don't apply swizzle to CMASK. the eg docs don't mention >

[Mesa-dev] [PATCH] radv: set cb base tile swizzles for MRT speedups (v2)

2017-07-09 Thread Dave Airlie
From: Dave Airlie This patch uses addrlib to workout the tile swizzles according to the surface index. It seems to produce the same values as amdgpu-pro for the deferred test. v2: don't apply swizzle to CMASK. the eg docs don't mention it, and we clearly don't align cmask for that. This gets th

[Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-09 Thread Zhongmin Wu
Before we queued the buffer with a invalid fence (-1), it will make some benchmarks failed to test such as flatland. Now we get the out fence during the flushing buffer and then pass it to SurfaceFlinger in eglSwapbuffer function. Change-Id: Ic0773c19788d612a98d1402f5b5619dab64c1bc2 Tracked-On: h

Re: [Mesa-dev] [PATCH] mesa/marshal: add custom marshallingforglNamedBuffer(Sub)Data

2017-07-09 Thread Grigori Goronzy
On 2017-06-26 15:51, Marc Dietrich wrote: Am Montag, 26. Juni 2017, 15:35:15 CEST schrieb Grigori Goronzy: On 2017-06-26 15:11, Marc Dietrich wrote: > unfortunately, this change broke vmware/vmplayer here (bisected). > Windows > guest on linux host. Sig 11 in SVGA driver. All good if > mesa_glth

Re: [Mesa-dev] [PATCH 1/2] mesa/marshal: extract ClearBuffer helpers

2017-07-09 Thread Grigori Goronzy
On 2017-07-09 18:52, Matt Turner wrote: +static inline size_t buffer_to_size(GLenum buffer) +{ + switch (buffer) { + case GL_COLOR: + return 4; + case GL_DEPTH_STENCIL: + return 2; + case GL_STENCIL: + case GL_DEPTH: + return 1; + default: + return 0; + } +} + +s

[Mesa-dev] [PATCH] a5xx: fix condition for updating *_FS_OUTPUT_CNTL

2017-07-09 Thread Ilia Mirkin
The register values depend on the currently set program, so make sure to revalidate when the program changes. Fixes glsl-1.10-fragdepth as well as dEQP-GLES3.functional.shaders.fragdepth.compare.* Signed-off-by: Ilia Mirkin --- src/gallium/drivers/freedreno/a5xx/fd5_emit.c | 2 +- 1 file change

Re: [Mesa-dev] [PATCH] amd/addrlib: fix typo in api name.

2017-07-09 Thread Eduardo Lima Mitev
On 07/09/2017 09:31 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes the misspelling of ALIGNMENTS in addrlib. > > Signed-off-by: Dave Airlie > --- > src/amd/addrlib/addrinterface.cpp| 2 +- > src/amd/addrlib/addrinterface.h | 6 +++--- > src/amd/addrlib/core/addrlib.cpp

Re: [Mesa-dev] [PATCH 1/2] st/mesa: check for incomplete texture in st_finalize_texture()

2017-07-09 Thread Brian Paul
I think we can skip this one since it's pretty obscure and only the VMware driver seemed to be effected. -Brian On 07/08/2017 08:06 AM, Andres Gomez wrote: Brian, it looks like we could want this series into -stable (?) On Wed, 2017-06-28 at 16:12 -0600, Brian Paul wrote: Return early from s

Re: [Mesa-dev] [PATCH] radv: add support for using addrlib max alignment.

2017-07-09 Thread Bas Nieuwenhuizen
On Sun, Jul 9, 2017 at 9:41 PM, Dave Airlie wrote: > From: Dave Airlie > > Rather than using 64k, use what addrlib returns as the base > alignment for vulkan allocations. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_gpu_info.h | 1 + > src/amd/common/ac_surface

Re: [Mesa-dev] [PATCH 1/2] vbo: fix glPrimitiveRestartNV crash inside a display list

2017-07-09 Thread Brian Paul
The fact that nobody noticed this until recently tells me it's not terribly important. But if the patches apply cleanly, sure. -Brian On 07/08/2017 04:01 PM, Andres Gomez wrote: It looks like we could want this series into -stable (?) On Fri, 2017-07-07 at 08:10 -0600, Brian Paul wrote: Fro

Re: [Mesa-dev] [PATCH] gallium: improve selection of pixel format

2017-07-09 Thread Brian Paul
Fine by me. -Brian On 07/08/2017 02:07 PM, Andres Gomez wrote: Olivier, Brian, do we want this into -stable? On Thu, 2017-07-06 at 17:08 +0200, Olivier Lauffenburger wrote: Current selection of pixel format does not enforce the request of stencil or depth buffer if the color depth is not the

[Mesa-dev] [PATCH] svga: fix breakage in create_backed_surface_view()

2017-07-09 Thread Brian Paul
This fixes a regression in some piglit tests since commit 5e5d5f1a2eb. I think I mis-resolved the merge conflict when cherry-picking that commit to master. --- src/gallium/drivers/svga/svga_surface.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/svg

[Mesa-dev] [PATCH] drirc: whitelist glthread for Civilization 5

2017-07-09 Thread Edmondo Tommasina
Performance delta on AMD Phenom II X3 720 Civilization 5: +28% --- src/mesa/drivers/dri/common/drirc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index 69b735ce70..418e159e81 100644 --- a/src/mesa/drivers/dri/com

Re: [Mesa-dev] [PATCH] radv: add support for using addrlib max alignment.

2017-07-09 Thread Connor Abbott
On Sun, Jul 9, 2017 at 12:41 PM, Dave Airlie wrote: > From: Dave Airlie > > Rather than using 64k, use what addrlib returns as the base > alignment for vulkan allocations. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_gpu_info.h | 1 + > src/amd/common/ac_surfac

[Mesa-dev] [PATCH] radv: add support for using addrlib max alignment.

2017-07-09 Thread Dave Airlie
From: Dave Airlie Rather than using 64k, use what addrlib returns as the base alignment for vulkan allocations. Signed-off-by: Dave Airlie --- src/amd/common/ac_gpu_info.h | 1 + src/amd/common/ac_surface.c | 11 ++- src/amd/common/ac_surface

[Mesa-dev] [PATCH] amd/addrlib: fix typo in api name.

2017-07-09 Thread Dave Airlie
From: Dave Airlie This fixes the misspelling of ALIGNMENTS in addrlib. Signed-off-by: Dave Airlie --- src/amd/addrlib/addrinterface.cpp| 2 +- src/amd/addrlib/addrinterface.h | 6 +++--- src/amd/addrlib/core/addrlib.cpp | 4 ++-- src/amd/addrlib/core/addrlib.h | 4 ++-- src/

Re: [Mesa-dev] [PATCH 1/2] mesa/marshal: extract ClearBuffer helpers

2017-07-09 Thread Matt Turner
On Sun, Jul 9, 2017 at 9:21 AM, Grigori Goronzy wrote: > Extract clear buffer helper functions in preparation for adding > marshal/unmarshal functions for the various glClearBuffer variants. > --- > src/mesa/main/marshal.c | 74 > +++-- > src/mesa/main

[Mesa-dev] [PATCH 2/2] mesa/marshal: add marshalling for glClearBuffer*

2017-07-09 Thread Grigori Goronzy
Add async marshalling/unmarshalling for all glClearBuffer variants. These entry points are commonly used in general and Alien Isolation specifically uses glClearBufferiv. Slightly reduces the number of thread synchronizations with glthread in that game. --- src/mapi/glapi/gen/GL3x.xml | 6 +- sr

[Mesa-dev] [PATCH 1/2] mesa/marshal: extract ClearBuffer helpers

2017-07-09 Thread Grigori Goronzy
Extract clear buffer helper functions in preparation for adding marshal/unmarshal functions for the various glClearBuffer variants. --- src/mesa/main/marshal.c | 74 +++-- src/mesa/main/marshal.h | 5 ++-- 2 files changed, 50 insertions(+), 29 deletions

[Mesa-dev] Call for community testing: OpenGL multithreading is ready

2017-07-09 Thread Marek Olšák
[To Mesa, Bcc Michael] Hi, About two weeks ago, I enabled glthread (the OpenGL multithreading wrapper for Mesa) for a few games with these improvements on a mid-range CPU: Alien Isolation: +60% (it varies depending on the location, increased since Grigori's commits) Borderlands 2: +50% (it varie

Re: [Mesa-dev] [PATCH v2 07/10] etnaviv: fold etna_screen_bo_get_handle into etna_resource_get_handle

2017-07-09 Thread Christian Gmeiner
2017-07-04 17:45 GMT+02:00 Lucas Stach : > There is no point in keeping this indirection. Makes the code easier to > follow. > > Signed-off-by: Lucas Stach > Reviewed-by: Wladimir J. van der Laan (v1) Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 21 +

Re: [Mesa-dev] [PATCH v2 06/10] etnaviv: implement resource import with modifier

2017-07-09 Thread Christian Gmeiner
2017-07-04 17:45 GMT+02:00 Lucas Stach : > This implements resource import with modifier, deriving the correct > internal layout from the modifier and constructing a render compatible > base resource if needed. > > This removes the special cases for DDX and renderonly scanout allocated > buffers, a

Re: [Mesa-dev] [PATCH v2 05/10] etnaviv: also update textures from external resources

2017-07-09 Thread Christian Gmeiner
2017-07-04 17:45 GMT+02:00 Lucas Stach : > This reworks the logic in etna_update_sampler_source to select the > newest resource view for updating the texture view. This should make > the logic easier to follow and fixes texture updates from imported > dma-bufs. > > Signed-off-by: Lucas Stach > Rev

Re: [Mesa-dev] [PATCH v2 04/10] etnaviv: increment correct seqno for external resources

2017-07-09 Thread Christian Gmeiner
2017-07-04 17:45 GMT+02:00 Lucas Stach : > If we import a dma-buf with a sampler/pixel pipe incompatible modifier, > the imported buffer will end up in an external resource view. As > resource_changed signals the change of the imported resource, we need > to update the external view seqno, instead

Re: [Mesa-dev] [PATCH v2 02/10] etnaviv: add helper to work out RS alignment

2017-07-09 Thread Christian Gmeiner
2017-07-04 17:45 GMT+02:00 Lucas Stach : > The minimum RS alignment calculation is needed in various places. > Extract a helper to avoid open-coding the calcuation at every site. > > Signed-off-by: Lucas Stach Reviewed-by: Christian Gmeiner > --- > src/gallium/drivers/etnaviv/etnaviv_resource.

Re: [Mesa-dev] [Mesa-stable] [PATCH 03/14] gallium/radeon: fix a possible crash for buffer exports

2017-07-09 Thread Andres Gomez
On Sun, 2017-07-09 at 14:29 +0200, Marek Olšák wrote: > On Sat, Jul 8, 2017 at 4:07 PM, Andres Gomez wrote: > > Marek, do we want this into -stable? > > Yes, this one can go to stable if it applies cleanly. It does. Thanks for the feedback! ☺ -- Br, Andres

Re: [Mesa-dev] [PATCH 03/14] gallium/radeon: fix a possible crash for buffer exports

2017-07-09 Thread Marek Olšák
On Sat, Jul 8, 2017 at 4:07 PM, Andres Gomez wrote: > Marek, do we want this into -stable? Yes, this one can go to stable if it applies cleanly. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listin

Re: [Mesa-dev] [PATCH] drirc: Add glsl_correct_derivatives_after_discard for The Witcher 2

2017-07-09 Thread Andres Gomez
On Sun, 2017-07-09 at 14:23 +0200, Marek Olšák wrote: > On Sat, Jul 8, 2017 at 3:58 PM, Andres Gomez wrote: > > Related to my previous mail, do we try to pick this for -stable? > > This one actually fixes a very visible incorrect rendering in Witcher > 2. Still, I think the 5-piece series is too

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

2017-07-09 Thread Andres Gomez
On Sun, 2017-07-09 at 14:21 +0200, Marek Olšák wrote: > On Sat, Jul 8, 2017 at 3:56 PM, Andres Gomez wrote: > > Marek, is it worth the effort of trying to bring this series into > > -stable? > > Probably not. The incorrect rendering in Rocket League isn't > noticeable if you don't know what to lo

Re: [Mesa-dev] [PATCH] drirc: Add glsl_correct_derivatives_after_discard for The Witcher 2

2017-07-09 Thread Marek Olšák
On Sat, Jul 8, 2017 at 3:58 PM, Andres Gomez wrote: > Related to my previous mail, do we try to pick this for -stable? This one actually fixes a very visible incorrect rendering in Witcher 2. Still, I think the 5-piece series is too large for stable. Marek ___

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

2017-07-09 Thread Marek Olšák
On Sat, Jul 8, 2017 at 3:56 PM, Andres Gomez wrote: > Marek, is it worth the effort of trying to bring this series into > -stable? Probably not. The incorrect rendering in Rocket League isn't noticeable if you don't know what to look for. Marek ___ mes

[Mesa-dev] [Bug 91889] Planetary Anihilation: Titans display content of other processes buffers

2017-07-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91889 --- Comment #29 from Rokas Kupstys --- I noticed this as well. It started happening after i upgraded my gpu to AMD rx580 and started using amdgpu driver. Could this be amdgpu issue? -- You are receiving this mail because: You are the assignee f