[Mesa-dev] [Bug 101766] Assertion `!"invalid type"' failed when constant expression involves literal of different type

2017-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101766 Bug ID: 101766 Summary: Assertion `!"invalid type"' failed when constant expression involves literal of different type Product: Mesa Version: unspecified Hardware: Other

Re: [Mesa-dev] [PATCH] amd/addrlib: fix typo in api name.

2017-07-12 Thread Alex Deucher
On Wed, Jul 12, 2017 at 9:18 AM, Nicolai Hähnle wrote: > On 09.07.2017 21:31, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This fixes the misspelling of ALIGNMENTS in addrlib. >> >> Signed-off-by: Dave Airlie > > > Yay, divergence from the internal copy. But it's the right thing to do, > so.

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi/gfx9: fix crash building monolithic merged ES-GS shader

2017-07-12 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jul 12, 2017 at 3:54 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Forwarding from the ES prolog to the ES just barely exceeds the current > maximum array size when 16 vertex attributes are used. Give it a decent > bump to account for merged shader

Re: [Mesa-dev] [PATCH v2 01/10] renderonly/etnaviv: stop importing resource from renderonly

2017-07-12 Thread Lucas Stach
Hi Christian, if possible I would really like to get some feedback/review on this patch, as it is changing quite some bits of renderonly, but is probably the last patch blocking this series from going into mainline. Regards, Lucas Am Dienstag, den 04.07.2017, 17:45 +0200 schrieb Lucas Stach: > T

Re: [Mesa-dev] [PATCH 10/11] egl/wayland: Remove duplicate wl_buffer creation code

2017-07-12 Thread Lucas Stach
Am Freitag, den 07.07.2017, 16:34 +0100 schrieb Daniel Stone: > Hi, > > On 28 June 2017 at 16:35, Lucas Stach wrote: > > Am Freitag, den 16.06.2017, 18:14 +0100 schrieb Daniel Stone: > >> if (dri2_dpy->capabilities & WL_DRM_CAPABILITY_PRIME) { > >> + struct wl_drm *wl_drm = > >> +

Re: [Mesa-dev] Mesa 17.2.0 release plan

2017-07-12 Thread Lucas Stach
Hi Emil, Am Freitag, den 07.07.2017, 19:07 +0100 schrieb Emil Velikov: > Hi all, > > As you may have noticed, for a little while now we've had the release > plan on the mesa3d.org website [1]. > > Here is the current tentative schedule. > > Jul 21 2017 - Feature freeze/Release candidate 1 > J

[Mesa-dev] [PATCH] radeonsi/gfx9: fix crash building monolithic merged ES-GS shader

2017-07-12 Thread Nicolai Hähnle
From: Nicolai Hähnle Forwarding from the ES prolog to the ES just barely exceeds the current maximum array size when 16 vertex attributes are used. Give it a decent bump to account for merged shaders having up to 32 user SGPRs. Fixes a crash in GL45-CTS.multi_bind.draw_bind_vertex_buffers. Cc:

Re: [Mesa-dev] KHR_no_error improvements

2017-07-12 Thread Grigori Goronzy
On 2017-07-12 15:16, Emil Velikov wrote: On 11 July 2017 at 23:26, Grigori Goronzy wrote: Hi, this series implements support for the EGL_KHR_context_create_no error extension and the associated plumbing through the different layers of Mesa - EGL, DRI, Gallium state tracker, Mesa frontend. It t

Re: [Mesa-dev] [PATCH] amd/addrlib: fix typo in api name.

2017-07-12 Thread Nicolai Hähnle
On 09.07.2017 21:31, Dave Airlie wrote: From: Dave Airlie This fixes the misspelling of ALIGNMENTS in addrlib. Signed-off-by: Dave Airlie Yay, divergence from the internal copy. But it's the right thing to do, so... Reviewed-by: Nicolai Hähnle --- src/amd/addrlib/addrinterface.cpp

Re: [Mesa-dev] KHR_no_error improvements

2017-07-12 Thread Emil Velikov
On 11 July 2017 at 23:26, Grigori Goronzy wrote: > Hi, > > this series implements support for the EGL_KHR_context_create_no > error extension and the associated plumbing through the different > layers of Mesa - EGL, DRI, Gallium state tracker, Mesa frontend. It > took me a while to figure out how

Re: [Mesa-dev] [PATCH 4/4] dri: Add KHR_no_error toggle to driconf

2017-07-12 Thread Emil Velikov
On 11 July 2017 at 23:26, Grigori Goronzy wrote: > Allows applications to be whitelisted. > --- > src/gallium/state_trackers/dri/dri_context.c| 3 +++ > src/gallium/state_trackers/dri/dri_screen.c | 1 + > src/mesa/drivers/dri/common/dri_util.c | 3 +++ > src/mesa/drivers/dri/com

Re: [Mesa-dev] [PATCH 3/4] st/mesa: add support for KHR_no_error flag

2017-07-12 Thread Emil Velikov
On 11 July 2017 at 23:26, Grigori Goronzy wrote: > Add a new context flag and plumb it through the various layers of the > context creation code to set up dispatch tables for the no-error mode. > --- > src/gallium/include/state_tracker/st_api.h | 1 + > src/gallium/state_trackers/dri/dri_conte

Re: [Mesa-dev] [PATCH 2/4] dri: Add KHR_no_error DRI extension

2017-07-12 Thread Emil Velikov
On 11 July 2017 at 23:26, Grigori Goronzy wrote: > This basic extension allows usage of the __DRI_CTX_FLAG_NO_ERROR flag. > This includes support code for classic Mesa drivers to switch on the > no-error mode if the flag is set. > --- > include/GL/internal/dri_interface.h | 19 ++

Re: [Mesa-dev] [PATCH 1/4] egl: Add EGL_KHR_create_context_no_error support

2017-07-12 Thread Emil Velikov
Hi Grigori, Thanks for cracking this down. On 11 July 2017 at 23:26, Grigori Goronzy wrote: > @@ -312,6 +312,36 @@ _eglParseContextAttribList(_EGLContext *ctx, _EGLDisplay > *dpy, > ctx->Flags |= EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR; > break; > > + case EGL

Re: [Mesa-dev] [PATCH 1/4] egl: Add EGL_KHR_create_context_no_error support

2017-07-12 Thread Grigori Goronzy
On 2017-07-12 12:33, Eric Engestrom wrote: + case EGL_CONTEXT_OPENGL_NO_ERROR_KHR: + if (dpy->Version < 14) { +err = EGL_BAD_ATTRIBUTE; +break; + } + + /* The KHR_no_error spec only applies against OpenGL 2.0+ and + * OpenGL ES 2.0+

Re: [Mesa-dev] [PATCH 4/4] i965: Drop non-LLC lunacy in the program cache code.

2017-07-12 Thread Chris Wilson
Quoting Chris Wilson (2017-07-12 10:40:43) > Quoting Kenneth Graunke (2017-07-12 08:22:25) > > The non-LLC story was a horror show. We uploaded data via pwrite > > (drm_intel_bo_subdata), which would stall if the cache BO was in > > use (being read) by the GPU. Obviously, we wanted to avoid that.

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS

2017-07-12 Thread Tomasz Figa
Hi Zhongmin, On Wed, Jul 12, 2017 at 9:55 AM, Wu, Zhongmin wrote: > Thanks very much for Emil and Tomasz's suggestions. > > We can see that the out fence needed in queue buffer is get from batch buffer > flushing. > > Now we may flush bath buffer at below places: > > 1. Create sync ===> f

Re: [Mesa-dev] [PATCH 1/4] egl: Add EGL_KHR_create_context_no_error support

2017-07-12 Thread Eric Engestrom
On Wednesday, 2017-07-12 00:26:12 +0200, Grigori Goronzy wrote: > This only adds the EGL side, needs to be plumbed into Mesa frontend. > --- > src/egl/drivers/dri2/egl_dri2.c | 20 ++-- > src/egl/drivers/dri2/egl_dri2.h | 1 + > src/egl/main/eglapi.c | 1 + > src/egl/ma

[Mesa-dev] [PATCH v2 1/6] vulkan/util: Move vk_format from amd/vulkan to vulkan/util

2017-07-12 Thread alexandros . frantzis
From: Alexandros Frantzis Move vk_format utilities to a more accessible location, to allow other vulkan code to use it. --- src/amd/vulkan/Makefile.am | 10 +- src/amd/vulkan/Makefile.sources | 2 -- src/vulkan/Makefile.am

[Mesa-dev] [PATCH v2 2/6] vulkan/util: Add missing header in vk_format.h

2017-07-12 Thread alexandros . frantzis
From: Alexandros Frantzis --- src/vulkan/util/vk_format.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vulkan/util/vk_format.h b/src/vulkan/util/vk_format.h index c2c7ca4ce2..96dac8cfad 100644 --- a/src/vulkan/util/vk_format.h +++ b/src/vulkan/util/vk_format.h @@ -30,6 +30,7 @@ #incl

[Mesa-dev] [PATCH v2 0/6] vulkan/wsi/wayland: Improve surface format support

2017-07-12 Thread alexandros . frantzis
From: Alexandros Frantzis Improve the surface format support in the Wayland Vulkan WSI, by automating the matching between wl_drm and Vulkan formats. The patchset is conceptually split into three parts: * PATCH 1-4: Move the vk_format utilities/scripts to a more accessible location (vulkan/

[Mesa-dev] [PATCH v2 3/6] vulkan/util: Make all the vk_format descriptions available in a table

2017-07-12 Thread alexandros . frantzis
From: Alexandros Frantzis The table allows iterating over all available format descriptions. --- src/vulkan/util/vk_format.h| 3 ++- src/vulkan/util/vk_format_table.py | 6 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/vulkan/util/vk_format.h b/src/vulkan/util/

[Mesa-dev] [PATCH v2 6/6] vulkan/wsi/wayland: Use vk and wl_drm format descriptions to automate format matching

2017-07-12 Thread alexandros . frantzis
From: Alexandros Frantzis Use the descriptions of Vulkan and wl_drm formats, as provided by the related utilities, to automate finding Vulkan formats compatible with wl_drm formats and vice versa. --- src/vulkan/wsi/wsi_common_wayland.c | 188 +++- 1 file changed,

[Mesa-dev] [PATCH v2 4/6] vulkan/util: Make the vk_format table creation scripts more reusable

2017-07-12 Thread alexandros . frantzis
From: Alexandros Frantzis Refactor the vk_format table creation scripts to allow other scripts to easily reuse some of the provided functionality. --- src/vulkan/util/vk_format_parse.py | 4 +-- src/vulkan/util/vk_format_table.py | 68 +- 2 files changed, 39

[Mesa-dev] [PATCH v2 5/6] vulkan/wsi: Introduce wl_drm_format table creation utilities

2017-07-12 Thread alexandros . frantzis
From: Alexandros Frantzis Reuse functionality from the vk_format table creation utilities to write a similar utility for wl_drm formats. The description of the wl_drm formats is compatible with that of vk_format. --- src/vulkan/Makefile.am | 11 - src/vulkan/Makefile.sources

[Mesa-dev] [PATCH] radv: Fix possible invalid free of dynamic descriptors

2017-07-12 Thread Alex Smith
This free was left in after dynamic descriptors were changed to not be allocated separately from the descriptor set, and can cause a crash. Fixes: 39644fa40a3 ("radv: Don't allocate dynamic descriptors separately") Signed-off-by: Alex Smith --- src/amd/vulkan/radv_descriptor_set.c | 1 - 1 file

Re: [Mesa-dev] [PATCH 4/4] i965: Drop non-LLC lunacy in the program cache code.

2017-07-12 Thread Chris Wilson
Quoting Kenneth Graunke (2017-07-12 08:22:25) > The non-LLC story was a horror show. We uploaded data via pwrite > (drm_intel_bo_subdata), which would stall if the cache BO was in > use (being read) by the GPU. Obviously, we wanted to avoid that. > So, we tried to detect whether the buffer was bu

Re: [Mesa-dev] [PATCH 3/4] i965: Use write-combine mappings where available

2017-07-12 Thread Chris Wilson
Quoting Kenneth Graunke (2017-07-12 08:22:24) > From: Matt Turner > > Write-combine mappings give much better performance on writes than > uncached access through the GTT. > > Improves performance of GFXBench 4's gl_driver2 benchmark at 1024x768 > on Apollolake by 3.6086% +/- 0.674193% (n=15). >

[Mesa-dev] [PATCH v2] radv: Fix descriptors for cube images with VK_IMAGE_USAGE_STORAGE_BIT

2017-07-12 Thread Alex Smith
If a cube image has VK_IMAGE_USAGE_STORAGE_BIT set, the type in an image view's descriptor was set to a 2D array (and a few other fields adjusted accordingly). This is correct when the image view is actually bound as a storage image, but not when bound as a sampled image. In that case the type shou

Re: [Mesa-dev] [PATCH 1/4] i965: Drop bogus pthread_mutex_unlock in map_gtt error path.

2017-07-12 Thread Chris Wilson
Quoting Kenneth Graunke (2017-07-12 08:22:22) > The locking was supposed to go away in commit 314647c4c206917ec01b7 > (i965: Drop global bufmgr lock from brw_bo_map_* functions.), but > this lone unlock remains. > > I'm guessing I messed this up when splitting up Chris's patch. My apologies for n

Re: [Mesa-dev] [PATCH] loader/dri3: Use dri3_find_back in loader_dri3_swap_buffers_msc

2017-07-12 Thread Michel Dänzer
On 07/07/17 12:29 PM, Michel Dänzer wrote: > From: Thomas Hellstrom > > If the application hasn't done any drawing since the last call, we > would reuse the same back buffer which was used for the previous swap, > which may not have completed yet. This could result in various issues > such as tea

[Mesa-dev] [PATCH 1/4] i965: Drop bogus pthread_mutex_unlock in map_gtt error path.

2017-07-12 Thread Kenneth Graunke
The locking was supposed to go away in commit 314647c4c206917ec01b7 (i965: Drop global bufmgr lock from brw_bo_map_* functions.), but this lone unlock remains. I'm guessing I messed this up when splitting up Chris's patch. --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 1 - 1 file changed, 1 deleti

[Mesa-dev] [PATCH 4/4] i965: Drop non-LLC lunacy in the program cache code.

2017-07-12 Thread Kenneth Graunke
The non-LLC story was a horror show. We uploaded data via pwrite (drm_intel_bo_subdata), which would stall if the cache BO was in use (being read) by the GPU. Obviously, we wanted to avoid that. So, we tried to detect whether the buffer was busy, and if so, we'd allocate a new BO, map the old one

[Mesa-dev] [PATCH 3/4] i965: Use write-combine mappings where available

2017-07-12 Thread Kenneth Graunke
From: Matt Turner Write-combine mappings give much better performance on writes than uncached access through the GTT. Improves performance of GFXBench 4's gl_driver2 benchmark at 1024x768 on Apollolake by 3.6086% +/- 0.674193% (n=15). v2: (by Ken) Rebase on lockless mappings, map_count deletion

[Mesa-dev] [PATCH 2/4] i965: Fix up a failed CPU/WC mmaping with a GTT mapping

2017-07-12 Thread Kenneth Graunke
From: Chris Wilson Not all objects will be mappable for direct access by the CPU (either using WC/CPU or WC paths), for example, a dmabuf wrapping an object on a foreign device or an object wrapping access to stolen memory. Since either the physical pages are not known or even do not exist, we ne

<    1   2