Re: [Mesa-dev] [PATCH 0/8] anv, spirv: Implement VK_KHR_variable_pointers

On Fri, 2017-07-14 at 10:34 -0700, Jason Ekstrand wrote: > On Fri, Jul 14, 2017 at 3:09 AM, Iago Toral > wrote: > > Patches 1-5 and 7-8 are: > > > > Reviewed-by: Iago Toral Quiroga > > > > > > > > I dropped minor comments to patches 4-5, feel free to

Re: [Mesa-dev] [PATCH v2 2/2] anv: ensure device name contains terminating character

Reviewed-by: Samuel Iglesias Gonsálvez On Mon, 2017-07-17 at 00:29 +0100, Lionel Landwerlin wrote: > v2: Use sizeof() (Chris) > > CID: 1415113 > Reported-by: Grazvydas Ignotas > Signed-off-by: Lionel Landwerlin > --- >  

Re: [Mesa-dev] [PATCH 1/2] i965: miptree: silence coverity warning

Reviewed-by: Samuel Iglesias Gonsálvez On Sun, 2017-07-16 at 15:31 +0100, Lionel Landwerlin wrote: > This probably can't happen, but we're better off with initialized > variables. > > CID: 1415114 > Signed-off-by: Lionel Landwerlin > --- >  

Re: [Mesa-dev] [PATCH v2 2/2] anv: ensure device name contains terminating character

On Sunday, July 16, 2017 4:29:52 PM PDT Lionel Landwerlin wrote: > v2: Use sizeof() (Chris) > > CID: 1415113 > Reported-by: Grazvydas Ignotas > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/anv_device.c | 4 ++-- > 1 file changed, 2

Re: [Mesa-dev] [EGL android: accquire fence implementation] i965: Queue the buffer with a sync fence for Android OS (v2)

Hi Tomasz and Rafael: Thanks very much for your comments. And I am not familiar with the whole architecture of the mesa, but is the implementation of mesa with dri2 core interface something like below ? It is not a formal patch, but to show my idea according to my understanding on your

Re: [Mesa-dev] [PATCH] ac/nir: rewrite shared variable handling (v2)

On 14.07.2017 00:39, Connor Abbott wrote: From: Connor Abbott Translate the NIR variables directly to LLVM instead of lowering to a TGSI-style giant array of vec4's and then back to a variable. This should fix indirect dereferences, make shared variables more tightly

Re: [Mesa-dev] [PATCH v6 0/6] mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

Hi Gert, Thank you for the thorough update, and sorry for taking so long to finally review this. I still think there are some small parts that can be removed to simplify things, and I've pointed those out in a reply to the main patch. But mostly this looks much better now, and most of my

Re: [Mesa-dev] [PATCH v6 4/6] mesa/st: glsl_to_tgsi: add register rename mapping evaluator

On 04.07.2017 16:18, Gert Wollny wrote: The remapping evaluator first sorts the temporary registers ascending based on their first life time instruction, and then uses a binary search to find merge canidates. For the initial sorting it uses std::sort because qsort is quite slow in comparison. By

Re: [Mesa-dev] [PATCH v6 2/6] mesa/st: glsl_to_tgsi: implement new temporary register lifetime tracker

On 04.07.2017 16:18, Gert Wollny wrote: This patch adds a class for tracking the life times of temporary registers in the glsl to tgsi translation. The algorithm runs in three steps: First, in order to minimize the number of needed memory allocations the program is scanned to evaluate the number

[Mesa-dev] [PATCH 0/2] r600_asm.c trivial cleanups

It was a part of some other work I had to abandon. It really eases understanding the code. The 2 patches are only build-tested, but they're small code-level trivia, so it should be fine. Constantine Kharlamov (2): r600g: remove unused args, and one unneeded forward declaration r600g:

[Mesa-dev] [PATCH 1/2] r600g: remove unused "bc" args, and one unneeded forward declaration

To ease review just highlight "bc," string. Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_asm.c | 85 + 1 file changed, 40 insertions(+), 45 deletions(-) diff --git a/src/gallium/drivers/r600/r600_asm.c

[Mesa-dev] [PATCH 2/2] r600g: constify some args at r600_asm.c

Signed-off-by: Constantine Kharlamov --- src/gallium/drivers/r600/r600_asm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/drivers/r600/r600_asm.c index f333e7769a..f5c0e80919 100644 ---

[Mesa-dev] [PATCH 1/2] i965: Rework the modifier info map

This commit splits the mapping in half. The modifier_infos table now only contains the modifier and the since_gen field. The tiling bits have been moved into a table in modifier_to_tiling as that's the only place it was ever used. The modifier_is_supported function now takes a devinfo and does

[Mesa-dev] [PATCH 2/2] i965: Check if the modifier is supported in select_best_modifier

Otherwise, if a client gave us a list of modifiers that contained a modifier we understand but which is not supported on the hardware, we might return that one and then fail to create the image. --- src/mesa/drivers/dri/i965/intel_screen.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Mesa-dev] [PATCH v2 2/2] anv: ensure device name contains terminating character

v2: Use sizeof() (Chris) CID: 1415113 Reported-by: Grazvydas Ignotas Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_device.c

[Mesa-dev] [Bug 99591] Segmentation fault when running vulkaninfo with RADV Radeon Vulkan driver

https://bugs.freedesktop.org/show_bug.cgi?id=99591 --- Comment #9 from Avindra Goolcharan --- Also getting a segfault with amdgpu. I'm using a Southern Islands card (Radeon HD 7850), running Mesa 17.1.4-166.1 on openSUSE Tumbleweed. This is the error I get: $ vulkaninfo

[Mesa-dev] [Bug 101806] plasma 5: system settings crashes when I leave desktop effects kcm

https://bugs.freedesktop.org/show_bug.cgi?id=101806 --- Comment #2 from Strangiato --- gpu intel hd 4000 mesa 12.0.6 My bug report in kde tracker is about neon developer unstable edition, but this crash also happens on Arch running mesa 17.1.4 on the same hardware. On both

[Mesa-dev] [Bug 101806] plasma 5: system settings crashes when I leave desktop effects kcm

https://bugs.freedesktop.org/show_bug.cgi?id=101806 --- Comment #1 from Ilia Mirkin --- What GPU are you using, and what version of mesa? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 101806] plasma 5: system settings crashes when I leave desktop effects kcm

https://bugs.freedesktop.org/show_bug.cgi?id=101806 Bug ID: 101806 Summary: plasma 5: system settings crashes when I leave desktop effects kcm Product: Mesa Version: unspecified Hardware: Other OS: All

Re: [Mesa-dev] [PATCH 1/2] i965: miptree: silence coverity warning

On Sunday, July 16, 2017 7:31:37 AM PDT Lionel Landwerlin wrote: > This probably can't happen, but we're better off with initialized > variables. > > CID: 1415114 > Signed-off-by: Lionel Landwerlin > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- > 1

Re: [Mesa-dev] [PATCH 2/2] anv: ensure device name contains terminating character

Quoting Lionel Landwerlin (2017-07-16 15:31:38) > CID: 1415113 > Reported-by: Grazvydas Ignotas > Signed-off-by: Lionel Landwerlin > --- > src/intel/vulkan/anv_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[Mesa-dev] [PATCH 2/2] anv: ensure device name contains terminating character

CID: 1415113 Reported-by: Grazvydas Ignotas Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH 1/2] i965: miptree: silence coverity warning

This probably can't happen, but we're better off with initialized variables. CID: 1415114 Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 0/2] anv/i965: coverity fixes

Hi all, Here are another couple of trival coverity fixes. Thanks to Grazvydas for reporting the Anv one (before coverity). Cheers, Lionel Landwerlin (2): i965: miptree: silence coverity warning anv: ensure device name contains terminating character src/intel/vulkan/anv_device.c

Re: [Mesa-dev] [PATCH 10/10] radeonsi/gfx9: add VM fault dmesg parser support

Patches 2-10: Reviewed-by: Nicolai Hähnle On 10.07.2017 23:21, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] glsl: xfb_stride applies to buffers, not block members

On 07.07.2017 18:19, Juan A. Suarez Romero wrote: When we have an interface block like: layout (xfb_buffer = 0, xfb_offset = 0) out Block { vec4 var1; layout (xfb_stride = 48) vec4 var2; vec4 var3; }; According to

Re: [Mesa-dev] [PATCH 01/10] radeonsi: simplify computation of tessellation offchip buffers

On 10.07.2017 23:21, Marek Olšák wrote: From: Marek Olšák This is overly cautious, but better safe than sorry. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] gallium/u_blitter: don't use TXF for scaled blits

On 13.07.2017 22:38, Marek Olšák wrote: From: Marek Olšák There seems to be a rounding difference with F2I vs nearest filtering. The precise problem in the rounding is unknown. This fixes an incorrect output with OpenMAX encoding. Reviewed-by: Nicolai Hähnle

Re: [Mesa-dev] [PATCH 10/10] radeonsi/gfx9: add workarounds to avoid VGPR indexing completely

Patches 2 - 10: Reviewed-by: Nicolai Hähnle On 08.07.2017 02:42, Marek Olšák wrote: From: Marek Olšák For inputs and outputs, indirect indexing is lowered by the GLSL compiler. For temporaries, use alloca and disable the "promote-alloca" pass.

Re: [Mesa-dev] [PATCH 01/10] gallium/radeon: flush the context after in-place texture realloc before export

On 08.07.2017 02:42, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 2deb56a..f5f7d10

Re: [Mesa-dev] [PATCH] mesa: flag _NEW_TEXTURE_OBJECT for GL_TEXTURE_LOD_BIAS_EXT

On 08.07.2017 02:35, Marek Olšák wrote: From: Marek Olšák Only the compatibility profile can set it. It was done incorrectly when we split _NEW_TEXTURE. Reviewed-by: Nicolai Hähnle --- src/mesa/main/texenv.c | 2 +- 1 file changed, 1