Re: [Mesa-dev] [PATCH dri3proto v2] Add modifier/multi-plane requests, bump to v1.1

On 25/07/17 05:28 PM, Nicolai Hähnle wrote: > On 22.07.2017 14:00, Daniel Stone wrote: >> >> I don't have any great solution off the top of my head, but I'd be >> inclined to bundle stride in with placement. TTBOMK (from having >> looked at radv), buffers shared cross-GPU also need to be allocated

Re: [Mesa-dev] [PATCH 1/3] i965: Fix offset addition in get_isl_surf.

On Tue, Jul 25, 2017 at 11:04:12AM -0700, Kenneth Graunke wrote: > Increase the value, not the pointer to the stack variable. > > Caught by Coverity (CID 1415574). Not shipped in a real release. > > Cc: "17.2" I already had the same patch: Reviewed-by: Topi Pohjolainen I didn't see us actua

[Mesa-dev] [PATCH] radv: force compute flush at end of command stream.

From: Dave Airlie This seems like a workaround, but we don't see the bug on CIK/VI. On SI with the dEQP-VK.memory.pipeline_barrier.host_read_transfer_dst.* tests, when one tests complete, the first flush at the start of the next test causes a VM fault as we've destroyed the VM, but we end up flu

Re: [Mesa-dev] [PATCH] genxml: Remove a redundant identical code for different branches

Hi Jason, You are right, as you commented, compilers can eliminate these redundancies easy. However I think we don't need to generate redundant codes. Best regards, Gwan-gyeong 2017년 7월 26일 (수) 오전 12:34, Jason Ekstrand 님이 작성: > Does the redundancy ends up mattering in any way? A decent optimizi

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

2017-07-26 1:24 GMT+08:00 Rob Herring : > On Tue, Jul 25, 2017 at 10:15 AM, Emil Velikov > wrote: >> On 25 July 2017 at 03:46, Chih-Wei Huang wrote: >>> On Tue 11 Jul 2017, Rob Herring wrote: > From: Marek Olšák > > Add support for 32-bit RGBX/RGBA formats which are required for And

[Mesa-dev] [PATCH] radv: implement SI/CIK compute shader regalloc hang workaround.

From: Dave Airlie This ports the regalloc hang workaround from radeonsi, not 100% sure if this is only needed on the GFX queue as the workaround references async compute not requiring it. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 10 ++ src/amd/vulkan/radv_pipel

[Mesa-dev] [PATCH] radv/winsys: fix padding command stream for SI

From: Dave Airlie We were adding pad to size after creating the object, so we could submit a CS bigger than the bo created for it. Signed-off-by: Dave Airlie --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/amd

Re: [Mesa-dev] [PATCH 075/101] mesa: add KHR_no_error support to glVertexArrayElementBuffer()

67-75: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/3] i965: Fix = vs == in MCS aux usage assert.

Oops... R-B On July 25, 2017 11:04:22 AM Kenneth Graunke wrote: Caught by Coverity (CID 1415680). Cc: "17.2" --- src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH 3/3] i965: Shut up Coverity warning about HiZ buffers.

R-B On July 25, 2017 11:04:25 AM Kenneth Graunke wrote: Here the AUX_USAGE_* mode indicates that we have HiZ, so we will have a HiZ buffer. But Coverity doesn't know that, so it thinks it might be NULL because we checked hiz_buf != NULL earlier. --- src/mesa/drivers/dri/i965/brw_blorp.c | 1

Re: [Mesa-dev] [PATCH 066/101] mesa: add draw_buffers_error() helper

On 22/07/17 03:40, Samuel Pitoiset wrote: And make draw_buffers() always inline. Signed-off-by: Samuel Pitoiset --- src/mesa/main/buffers.c | 223 ++-- 1 file changed, 119 insertions(+), 104 deletions(-) diff --git a/src/mesa/main/buffers.c b/src/

[Mesa-dev] [PATCH] radv/ac: port SI TC L1 write corruption fix.

From: Dave Airlie This ports 72e46c988 to radv. radeonsi: apply a TC L1 write corruption workaround for SI Fixes: f4e499ec7 (radv: add initial non-conformant radv vulkan driver) Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 9 ++--- 1 file changed, 6 insertions(+), 3

[Mesa-dev] [PATCH] radv/ac: realign SI workaround with radeonsi.

From: Dave Airlie This ports: da7453666ae radeonsi: don't apply the Z export bug workaround to Hainan to radv. Just noticed in passing. Fixes: f4e499ec7 (radv: add initial non-conformant radv vulkan driver) Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 5 +++-- 1 file chang

[Mesa-dev] [PATCH 3/3] mesa: don't error check the default buffer object

An allocation check is already done when the buffer is created at context creation. --- src/mesa/main/bufferobj.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index cb666dc..b02d011 100644 --- a/s

[Mesa-dev] [PATCH 2/3] mesa: check default buffer object creation was successful

--- src/mesa/main/shared.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/main/shared.c b/src/mesa/main/shared.c index 4bc93a7..27e8094 100644 --- a/src/mesa/main/shared.c +++ b/src/mesa/main/shared.c @@ -44,6 +44,9 @@ #include "util/hash_table.h" #include "util/set.h" +

[Mesa-dev] [PATCH 1/3] mesa: add NULL checking to free_shared_state()

This will allow us to call this function from _mesa_alloc_shared_state() in the case that we run out of memory part way through allocating the state. --- src/mesa/main/shared.c | 88 +++-- src/mesa/main/texturebindless.c | 8 +++- 2 files changed, 65 i

[Mesa-dev] [PATCH 2/3] i965: Only do depth resolves prior to clearing when needed

From: Jason Ekstrand When changing the clear value, we need to resolve any fast cleared data. Previously, we were performing resolves on every slice with HiZ enabled. We only need to resolve slices that a) have fast clear data, and b) aren't about to be cleared to the new color. In the latter c

[Mesa-dev] [PATCH 1/3] i965: Expose get_num_logical_layers outside of intel_mipmap_tree.c.

I want to use it in brw_clear.c. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 10 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 3 +++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/inte

[Mesa-dev] [PATCH 3/3] i965/clear: Don't perform redundant depth clears

From: Jason Ekstrand We already have this little optimization for color clears. Now that we're actually tracking whether or not a slice has any fast-clear blocks, it's easy enough to add for depth clears too. Improves performance of GFXBench 4 TRex at 1920x1080 by: - Skylake GT4: 0.905932% +/-

Re: [Mesa-dev] [PATCH v2 17/73] radeonsi: add si_shader_selector::nir

For patches 9-17: Reviewed-by: Marek Olšák Marek On Wed, Jul 5, 2017 at 12:48 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/radeonsi/si_shader.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/drivers/radeonsi/si_shader.h > b/src/gall

Re: [Mesa-dev] [PATCH] st/va: change frame_idx from array to hash table

Christian König wrote: Leo and Boyuan can you take a quick look as well? On first glance looks totally sane to me. This reminds me . I don't know what's special about my setup, but I haven't been able to use gst + vce properly since March. As I said at the time - https://lists.freedes

Re: [Mesa-dev] [PATCH] st/mesa: always unconditionally revalidate main framebuffer after SwapBuffers

Tested-by: Edmondo Tommasina Thanks edmondo On Tue, Jul 25, 2017 at 6:32 PM, Marek Olšák wrote: > This will also go to stable. > > Marek > > On Tue, Jul 25, 2017 at 5:39 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> This fixes the black Feral launcher window. >> >> Bugzilla: https://bugs.

[Mesa-dev] [PATCH v8 3/3] mapi/glthread: generate asynchronous code for PBO transfer

Improve speed on PCSX2 v2: Add ppbo/ubpo status in XML file Disable variable parameter (as the pointer would be a fixed offset) v3: split buffer tracking into separate patches. use 'goto fallback_to_sync' when asynchronous transfer isn't supported v4: add Nicolai comment to explain why ppbo isn'

[Mesa-dev] [PATCH v8 2/3] mesa/glthread: add tracking of PBO binding

In gl core, buffer must be reserved first by CreateBuffers/GenBuffers to be valid. v4: update comments based on Nicolai review v7: s/GLint pixel_pack_buffer_bound/GLuint bound_pixel_pack_buffer/ Drop the ShadowBufferObjects hash. Synchronous creation/destruction gives us enough guarantee to looku

[Mesa-dev] [PATCH v8 1/3] mesa/glthread: track buffer destruction

It would be used in following commits to allow asynchronous PBO transfer. The tracking saves the buffer name into a hash. Saving pointer will be more complex as the buffer is created in BindBuffer due to IsBuffer insanity. Perf wise DeleteBuffers is now synchronous for robustness. v5: properly d

[Mesa-dev] [PATCH v8 0/3] asynchronous pbo transfer with glthread

Hello Mesa developers, > Please find a new version to handle invalid buffer handles. > > Allow to handle this kind of case: >genBuffer(&pbo); >BindBuffer(pbo) >DeleteBuffer(pbo); >BindBuffer(rand_pbo) >TexSubImage2D(user_memory_pointer); // Data transfer will be synchronous > >

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: fix mismatch when returning 64-bit bindless uniform handles

Reviewed-by: Marek Olšák Marek On Tue, Jul 25, 2017 at 9:39 PM, Samuel Pitoiset wrote: > The slower convert-and-copy process performs a bad conversion > because it converts the value to signed 64-bit integer, but > bindless uniform handles are considered unsigned 64-bit. > > This fixes "Check g

Re: [Mesa-dev] [PATCH v2 07/73] st/glsl_to_nir: fix the case where NIR clone testing is enabled

Reviewed-by: Marek Olšák Marek On Wed, Jul 5, 2017 at 12:47 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > In that case, prog->nir must be assigned at the end. > --- > src/mesa/state_tracker/st_glsl_to_nir.cpp | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sr

Re: [Mesa-dev] [PATCH] mesa: fix mismatch when returning 64-bit bindless uniform handles

On 07/25/2017 09:47 PM, Ilia Mirkin wrote: On Tue, Jul 25, 2017 at 3:39 PM, Samuel Pitoiset wrote: The slower convert-and-copy process performs a bad conversion because it converts the value to signed 64-bit integer, but bindless uniform handles are considered unsigned 64-bit. This fixes "Ch

Re: [Mesa-dev] [PATCH] mesa: fix mismatch when returning 64-bit bindless uniform handles

On Tue, Jul 25, 2017 at 3:39 PM, Samuel Pitoiset wrote: > The slower convert-and-copy process performs a bad conversion > because it converts the value to signed 64-bit integer, but > bindless uniform handles are considered unsigned 64-bit. > > This fixes "Check glUniform*() with mixed texture uni

[Mesa-dev] [PATCH] mesa: fix mismatch when returning 64-bit bindless uniform handles

The slower convert-and-copy process performs a bad conversion because it converts the value to signed 64-bit integer, but bindless uniform handles are considered unsigned 64-bit. This fixes "Check glUniform*() with mixed texture units/handles" from arb_bindless_texture-uniform piglit. Signed-off-

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 99136, which changed state. Bug 99136 Summary: Blood Effects corrupt graphics in Total War: Warhammer https://bugs.freedesktop.org/show_bug.cgi?id=99136 What|Removed |Added -

Re: [Mesa-dev] [PATCH] st/mesa: fix the unconditional return in st_framebuffer_iface_remove

Per https://www.mesa3d.org/submittingpatches.html, just a Fixes tag should be enough to get in all the stable branches that still get updated and contain the commit that is referenced. - Bas On Tue, Jul 25, 2017 at 8:55 PM, Marek Olšák wrote: > I've already sent a patch for this bug, but in the

Re: [Mesa-dev] threaded opengl

Hi, What is your CPU, GPU, and how much improvement did you get? Thanks, Marek On Tue, Jul 18, 2017 at 11:10 PM, siyia wrote: > sorry executable is "mb_warband_linux" start.sh or mb_warband.sh are local > scripts to start the game so: > > > > ___ > m

Re: [Mesa-dev] [PATCH] ac/surface: fix hybrid graphics where APU=GFX9, dGPU=older

On Tue, Jul 25, 2017 at 12:38 PM, Marek Olšák wrote: > From: Marek Olšák > > Cc: 17.2 Reviewed-by: Alex Deucher > --- > src/amd/common/ac_surface.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c > index cd3d7b7.

Re: [Mesa-dev] [PATCH] st/mesa: fix the unconditional return in st_framebuffer_iface_remove

I've already sent a patch for this bug, but in the future, please mark all patches that should be in stable by adding the proper Cc tag. Thanks, Marek On Tue, Jul 25, 2017 at 2:00 AM, Charmaine Lee wrote: > Fixes: bbc29393d3beaf6344c7188547b4ff61b63946ae > Tested-by: Christoph Haag > --- > src

Re: [Mesa-dev] [PATCH v2 1/2] st/dri: Check get-handle return value in queryImage

On 25 July 2017 at 19:08, Emil Velikov wrote: > On 24 July 2017 at 16:46, Daniel Stone wrote: >> In the DRIImage queryImage hook, check if resource_get_handle() failed >> and return FALSE if so. >> > Wanted to say huge thank you for sorting these out (sorry for being > slow to actually review it)

Re: [Mesa-dev] [PATCH 5/5] radeonsi: bail out instead of crashing if the main shader part failed to compile

Patches 1, 3-5: Reviewed: Marek Olšák Marek On Mon, Jul 17, 2017 at 12:57 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/radeonsi/si_shader.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/drivers/radeonsi/si_shader.c > b/src/gallium/

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/5] radeonsi/gfx9: always wrap GS and TCS in an if-block

On Mon, Jul 17, 2017 at 12:57 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > With merged ESGS shaders, the GS part of a wave may be empty, and the > hardware gets confused if any GS messages are sent from that wave. Since > S_SENDMSG is executed even when EXEC = 0, we have to wrap even > no

[Mesa-dev] [PATCH] st/mesa: fix the unconditional return in st_framebuffer_iface_remove

Fixes: bbc29393d3beaf6344c7188547b4ff61b63946ae Tested-by: Christoph Haag --- src/mesa/state_tracker/st_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index 834bcc9..6447403 100644 --- a/src/

Re: [Mesa-dev] [PATCH] st/va: change frame_idx from array to hash table

Am 25.07.2017 um 16:31 schrieb Julien Isorce: The picture_is was assumed to be a frame number so in 0-31. Typo in the commit message, that should read "picture_id", not "picture_is". But the vaapi client gstreamer-vaapi uses the surfaces handles as identifier which are unsigned int. This bug

Re: [Mesa-dev] [PATCH v2 1/2] st/dri: Check get-handle return value in queryImage

Hi Dan, On 24 July 2017 at 16:46, Daniel Stone wrote: > In the DRIImage queryImage hook, check if resource_get_handle() failed > and return FALSE if so. > Wanted to say huge thank you for sorting these out (sorry for being slow to actually review it). I think we'd want this patch in stable. Plea

Re: [Mesa-dev] [PATCH] st/mesa: create framebuffer iface hash table per st manager

>From: James Legg >Sent: Tuesday, July 25, 2017 6:24 AM >To: mesa-dev@lists.freedesktop.org; Charmaine Lee >Subject: Re: [Mesa-dev] [PATCH] st/mesa: create framebuffer iface hash table >per st manager >On Sun, 2017-07-23 at 16:37 -0700, Charmaine Lee wrote: >> With this patch, framebuffer inter

Re: [Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

> -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Tuesday, July 25, 2017 11:22 PM > To: Marathe, Yogesh > Cc: Wu, Zhongmin ; ML mesa-dev d...@lists.freedesktop.org>; Kondapally, Kalyan > ; Antognolli, Rafael > ; Gao, Shuo ; Tomasz Figa > ; Chris Wilson ;

[Mesa-dev] [PATCH 2/3] i965: Fix = vs == in MCS aux usage assert.

Caught by Coverity (CID 1415680). Cc: "17.2" --- src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 36f7ed2a39d..a0f37780ef5 100644 --- a/src/mesa/drivers/d

[Mesa-dev] [PATCH 1/3] i965: Fix offset addition in get_isl_surf.

Increase the value, not the pointer to the stack variable. Caught by Coverity (CID 1415574). Not shipped in a real release. Cc: "17.2" --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm

[Mesa-dev] [PATCH 3/3] i965: Shut up Coverity warning about HiZ buffers.

Here the AUX_USAGE_* mode indicates that we have HiZ, so we will have a HiZ buffer. But Coverity doesn't know that, so it thinks it might be NULL because we checked hiz_buf != NULL earlier. --- src/mesa/drivers/dri/i965/brw_blorp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/driv

Re: [Mesa-dev] [PATCH 11/27] radeonsi: add basic memory object support v3

On Tue, Jul 18, 2017 at 5:06 AM, Andres Rodriguez wrote: > From: Dave Airlie > > v2: also consider gfx9 metadata > v3: ref/unref memobj->buf > > Signed-off-by: Andres Rodriguez > --- > src/gallium/drivers/radeon/r600_pipe_common.h | 7 ++ > src/gallium/drivers/radeon/r600_texture.c | 111

Re: [Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

On 25 July 2017 at 15:30, Marathe, Yogesh wrote: > Emil, > >> -Original Message- >> From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >> Sent: Tuesday, July 25, 2017 7:46 PM >> To: Wu, Zhongmin >> Cc: ML mesa-dev ; Kondapally, Kalyan >> ; Marathe, Yogesh >> ; Antognolli, Rafael >> ; Ga

Re: [Mesa-dev] [PATCH v2 2/2] st/dri2: Return invalid modifier when no driver support

On 25 July 2017 at 17:43, Marek Olšák wrote: > For the series: > > Reviewed-by: Marek Olšák Thanks Marek! I've fixed the idiotic dropping of the 'return GL_FALSE' for the modifiers path in 1/2 (bad rebase) and pushed now. Cheers, Daniel ___ mesa-dev m

Re: [Mesa-dev] [PATCH] i965: perf: flush batchbuffers at the beginning of queries

On Tuesday, July 25, 2017 9:49:22 AM PDT Lionel Landwerlin wrote: > As Chris commented, it makes more sense to have batch buffer flushes > before the query. Usually applications like frame_retrace do a series > of queries and in that case, with flushes at the end of the queries, > we might still ha

Re: [Mesa-dev] [PATCH 4/6] st/dri: use correct __DRI2_CONFIG_QUERY extension

Reviewed-by: Marek Olšák Marek On Fri, Jul 7, 2017 at 8:47 PM, Emil Velikov wrote: > From: Emil Velikov > > If device supports robustness (AKA PIPE_CAP_DEVICE_RESET_STATUS_QUERY) > then we're using dri_robust_screen_extensions. > Hence for such cases the DRI loader was not able to query the dr

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

On Tue, Jul 25, 2017 at 10:15 AM, Emil Velikov wrote: > On 25 July 2017 at 03:46, Chih-Wei Huang wrote: >> On Tue 11 Jul 2017, Rob Herring wrote: From: Marek Olšák Add support for 32-bit RGBX/RGBA formats which are required for Android. The original patch (commit ccdcf91

Re: [Mesa-dev] [PATCH] r600: Add support for B5G5R5A1.

Pushed, thanks! Marek On Mon, Jul 17, 2017 at 9:34 AM, wrote: > From: Michal Srb > > Fixes rendercheck errors when using glamor acceleration in X server. > --- > > Fixes rendercheck errors on tests with r5g5b5 and b5g5r5. For example > `rendercheck -t blend -f r5g5b5,a8r8g8b8`. > > I am not co

Re: [Mesa-dev] [PATCH] amdgpu/addrlib: use initialization list in addrobject

Dully noted, thanks for the heads up. On July 25, 2017 12:50:22 PM EDT, "Marek Olšák" wrote: >Hi Jeremy, > >Note that addrlib is imported from our internal repository. Any >changes to addrlib in Mesa may make later updates from the internal >repository more difficult. It would be preferable to ap

Re: [Mesa-dev] [PATCH 3/3] mesa/st: fix unused variable warnings

For the series: Reviewed-by: Marek Olšák Marek On Thu, Jul 20, 2017 at 2:07 AM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_cb_bitmap.c | 5 +++-- > src/mesa/state_tracker/st_cb_drawpixels.c | 9 - > src/mesa/state_tracker/st_cb_texture.c| 2 +- > src/mesa/state_tr

Re: [Mesa-dev] [PATCH 1/4] ac/gpu: add code to detect if kernel supports sync objects.

Reviewed-by: Marek Olšák Marek On Thu, Jul 20, 2017 at 5:38 AM, Dave Airlie wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_gpu_info.c | 9 + > src/amd/common/ac_gpu_info.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/src/amd/common/

Re: [Mesa-dev] [PATCH] st/mesa: also clamp and quantize per-unit lod bias

This should probably go to stable too. Reviewed-by: Samuel Pitoiset On 07/25/2017 05:36 PM, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_atom_sampler.c | 7 --- src/mesa/state_tracker/st_cb_texture.c | 2 +- src/mesa/state_tracker/st_texture.h | 1 + 3 f

Re: [Mesa-dev] [PATCH] amdgpu/addrlib: use initialization list in addrobject

Hi Jeremy, Note that addrlib is imported from our internal repository. Any changes to addrlib in Mesa may make later updates from the internal repository more difficult. It would be preferable to apply changes to the internal addrlib first and Mesa would get them on the next addrlib update. I per

[Mesa-dev] [PATCH] i965: perf: flush batchbuffers at the beginning of queries

As Chris commented, it makes more sense to have batch buffer flushes before the query. Usually applications like frame_retrace do a series of queries and in that case, with flushes at the end of the queries, we might still have the first query contained in 2 different batchs. More generally it woul

Re: [Mesa-dev] [PATCH] st/mesa: fix unconditional return in st_framebuffer_iface_remove

Reviewed-by: Samuel Pitoiset On 07/25/2017 06:30 PM, Marek Olšák wrote: From: Marek Olšák Cc: 17.2 --- src/mesa/state_tracker/st_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index e

Re: [Mesa-dev] [PATCH v2 2/2] st/dri2: Return invalid modifier when no driver support

For the series: Reviewed-by: Marek Olšák Marek On Mon, Jul 24, 2017 at 5:46 PM, Daniel Stone wrote: > Always initialise whandle.modifier for DRIImage modifier queries, so if > the driver doesn't support it then we return false for the query. > > Signed-off-by: Daniel Stone > Cc: Varad Gautam

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: make S_FIXED function signed and move it to shared code

On Tuesday, July 25, 2017 8:36:36 AM PDT Marek Olšák wrote: > From: Marek Olšák > > This fixes a bug uncovered by: > 2412c4c81ea0488df865817a0de91ec46e359b72 > util: Make CLAMP turn NaN into MIN. > --- > src/gallium/drivers/r600/r600_pipe.h | 4 > src/gallium/drivers/radeon

[Mesa-dev] [PATCH] ac/surface: fix hybrid graphics where APU=GFX9, dGPU=older

From: Marek Olšák Cc: 17.2 --- src/amd/common/ac_surface.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index cd3d7b7..9e5390b 100644 --- a/src/amd/common/ac_surface.c +++ b/src/amd/common/ac_surface.c @@ -250,20 +250

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: make S_FIXED function signed and move it to shared code

Reviewed-by: Roland Scheidegger Am 25.07.2017 um 17:36 schrieb Marek Olšák: > From: Marek Olšák > > This fixes a bug uncovered by: > 2412c4c81ea0488df865817a0de91ec46e359b72 > util: Make CLAMP turn NaN into MIN. > --- > src/gallium/drivers/r600/r600_pipe.h | 4 > src/gall

Re: [Mesa-dev] [PATCH 2/2] radeonsi: decrease the number of compiler threads

This will also go to stable. Marek On Tue, Jul 25, 2017 at 5:36 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeonsi/si_pipe.c | 2 +- > src/gallium/drivers/radeonsi/si_pipe.h | 9 +++-- > 2 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/src/ga

Re: [Mesa-dev] [PATCH] st/mesa: always unconditionally revalidate main framebuffer after SwapBuffers

This will also go to stable. Marek On Tue, Jul 25, 2017 at 5:39 PM, Marek Olšák wrote: > From: Marek Olšák > > This fixes the black Feral launcher window. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101867 > --- > src/mesa/state_tracker/st_manager.c | 6 ++ > 1 file changed,

Re: [Mesa-dev] [PATCH 1/2] gallium/radeon: make S_FIXED function signed and move it to shared code

This will also go to stable. Marek On Tue, Jul 25, 2017 at 5:36 PM, Marek Olšák wrote: > From: Marek Olšák > > This fixes a bug uncovered by: > 2412c4c81ea0488df865817a0de91ec46e359b72 > util: Make CLAMP turn NaN into MIN. > --- > src/gallium/drivers/r600/r600_pipe.h | 4

Re: [Mesa-dev] [PATCH] radeonsi: fix detection of DRAW_INDIRECT_MULTI on SI

Reviewed-by: Marek Olšák Marek On Tue, Jul 25, 2017 at 4:51 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The firmware version numbers for SI were wrong. The new numbers are probably > too conservative (we don't have a definitive answer by the firmware team), > but DRAW_INDIRECT_MULTI h

[Mesa-dev] [PATCH] st/mesa: fix unconditional return in st_framebuffer_iface_remove

From: Marek Olšák Cc: 17.2 --- src/mesa/state_tracker/st_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index ede5439..78093ac 100644 --- a/src/mesa/state_tracker/st_manager.c +++ b/src/mes

Re: [Mesa-dev] [Mesa-stable] [PATCH] radeonsi/gfx9: reduce max threads per block to 1024 on gfx9+

Reviewed-by: Marek Olšák Marek On Tue, Jul 25, 2017 at 4:46 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The number of supported waves per thread group has been officially > reduced to 16 with gfx9 (and trying to use 32 waves causes hangs). > > Cc: mesa-sta...@lists.freedesktop.org > -

Re: [Mesa-dev] [PATCH] radeonsi: fix detection of DRAW_INDIRECT_MULTI on SI

On Tue, Jul 25, 2017 at 10:51 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The firmware version numbers for SI were wrong. The new numbers are probably > too conservative (we don't have a definitive answer by the firmware team), > but DRAW_INDIRECT_MULTI has been confirmed to work with th

Re: [Mesa-dev] [shader-db 0/3] Small README clean ups

On 25/07/17 13:58, Rhys Kidd wrote: > On 24 July 2017 at 23:42, Rhys Kidd > wrote: > > Update or fix a few small items that I noticed when running > through piglit > setup on a new development environment. > > > Ah, whoops. The subject prefix for this series

Re: [Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

On Tue, Jul 25, 2017 at 10:07:23AM +0800, Zhongmin Wu wrote: > Before we queued the buffer with a invalid fence (-1), it will > make some benchmarks failed to test such as flatland. > > Now we get the out fence during the flushing buffer and then pass > it to SurfaceFlinger in eglSwapbuffer functi

[Mesa-dev] [Bug 101867] Launch options window renders black in Feral Games in current Mesa trunk

https://bugs.freedesktop.org/show_bug.cgi?id=101867 --- Comment #10 from Marc Di Luzio --- (In reply to James Legg from comment #6) > traces from builds of recent Feral titles available on Steam will be > difficult as we've tried to avoid Steam injecting its overlay in the options > window when g

Re: [Mesa-dev] [RFC PATCH] radeonsi: flush DB caches when a Z/stencil buffer is attached

On 07/25/2017 05:51 PM, Nicolai Hähnle wrote: On 25.07.2017 15:29, Samuel Pitoiset wrote: This is a workaround which fixes a rendering issue with Dawn Of War III in full bindless mode because a depth texture most likely doesn't invoke the decompression pass when it should. So do I understand

Re: [Mesa-dev] [RFC PATCH] radeonsi: flush DB caches when a Z/stencil buffer is attached

On 25.07.2017 15:29, Samuel Pitoiset wrote: This is a workaround which fixes a rendering issue with Dawn Of War III in full bindless mode because a depth texture most likely doesn't invoke the decompression pass when it should. So do I understand correctly that the previous depth target is used

[Mesa-dev] [PATCH] st/mesa: always unconditionally revalidate main framebuffer after SwapBuffers

From: Marek Olšák This fixes the black Feral launcher window. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101867 --- src/mesa/state_tracker/st_manager.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.

Re: [Mesa-dev] [PATCH 2/2] util: Make CLAMP turn NaN into MIN.

On Tue, Jul 25, 2017 at 8:12 AM, Roland Scheidegger wrote: > Am 24.07.2017 um 11:44 schrieb Michel Dänzer: >> On 14/07/17 10:01 PM, Marek Olšák wrote: >>> Reviewed-by: Marek Olšák mailto:marek.ol...@amd.com>> >> >> This change broke piglit spec@ext_texture_lod_bias@lodbias for me with >> radeonsi

[Mesa-dev] [PATCH 1/2] gallium/radeon: make S_FIXED function signed and move it to shared code

From: Marek Olšák This fixes a bug uncovered by: 2412c4c81ea0488df865817a0de91ec46e359b72 util: Make CLAMP turn NaN into MIN. --- src/gallium/drivers/r600/r600_pipe.h | 4 src/gallium/drivers/radeon/r600_pipe_common.h | 5 + src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 2/2] radeonsi: decrease the number of compiler threads

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.h | 9 +++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 0bc3002..234469f 100644

[Mesa-dev] [PATCH] st/mesa: also clamp and quantize per-unit lod bias

From: Marek Olšák --- src/mesa/state_tracker/st_atom_sampler.c | 7 --- src/mesa/state_tracker/st_cb_texture.c | 2 +- src/mesa/state_tracker/st_texture.h | 1 + 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_sampler.c b/src/mesa/state_t

Re: [Mesa-dev] [PATCH] genxml: Remove a redundant identical code for different branches

Does the redundancy ends up mattering in any way? A decent optimizing compiler should easily be able to get rid of that for you. --Jason On July 25, 2017 2:51:31 AM Gwan-gyeong Mun wrote: Before, it generates functions like this, static inline uint32_t ATTRIBUTE_PURE RENDER_SURFACE_STATE_

Re: [Mesa-dev] [PATCH 1/2] mesa: add bind_program_pipeline() helper

On 07/25/2017 04:54 PM, Nicolai Hähnle wrote: On 25.07.2017 15:44, Ilia Mirkin wrote: On Tue, Jul 25, 2017 at 9:09 AM, Samuel Pitoiset wrote: On 07/25/2017 03:08 PM, Brian Paul wrote: On 07/25/2017 02:04 AM, Nicolai Hähnle wrote: On 21.07.2017 15:16, Samuel Pitoiset wrote: To reduce

Re: [Mesa-dev] [PATCH 1/3] mesa: don't try to re-generate the default buffer

We could also remove that useless assert in _mesa_handle_bind_buffer_gen() because NewBufferObj() is called when the shared state is allocated. I don't think it can be NULL here. :-) The same change can be applied to bind_buffer_range() though. With that fixed, series is: Reviewed-by: Samuel

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

On 25 July 2017 at 03:46, Chih-Wei Huang wrote: > On Tue 11 Jul 2017, Rob Herring wrote: >>> From: Marek Olšák >>> >>> Add support for 32-bit RGBX/RGBA formats which are required for Android. >>> >>> The original patch (commit ccdcf91104a5) was reverted (commit >>> c0c6ca40a25e) in mesa as it bro

Re: [Mesa-dev] [PATCH 1/2] mesa: add bind_program_pipeline() helper

On 25.07.2017 15:44, Ilia Mirkin wrote: On Tue, Jul 25, 2017 at 9:09 AM, Samuel Pitoiset wrote: On 07/25/2017 03:08 PM, Brian Paul wrote: On 07/25/2017 02:04 AM, Nicolai Hähnle wrote: On 21.07.2017 15:16, Samuel Pitoiset wrote: To reduce code duplication. Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH] radeonsi: fix detection of DRAW_INDIRECT_MULTI on SI

From: Nicolai Hähnle The firmware version numbers for SI were wrong. The new numbers are probably too conservative (we don't have a definitive answer by the firmware team), but DRAW_INDIRECT_MULTI has been confirmed to work with these versions on Tahiti (by Gustaw) and on Verde (by myself). Whil

Re: [Mesa-dev] [EGL android: accquire fence implementation 1/2] i965: Return the last fence if the batch buffer is empty and nothing to be flushed when _intel_batchbuffer_flush_fence.

Hi Zhongmin, Is the issue resolved by the EGL patch alone? Worth sticking with that for now? I think this patch will cause some noticeable overhead - see below for details. On 21 July 2017 at 04:08, Zhongmin Wu wrote: > Always save the last fence in the brw context when flushing > buffer. If t

[Mesa-dev] [PATCH] radeonsi/gfx9: reduce max threads per block to 1024 on gfx9+

From: Nicolai Hähnle The number of supported waves per thread group has been officially reduced to 16 with gfx9 (and trying to use 32 waves causes hangs). Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeon/r600_pipe_common.c | 39 --- 1 file changed, 24

[Mesa-dev] [PATCH] st/va: change frame_idx from array to hash table

The picture_is was assumed to be a frame number so in 0-31. But the vaapi client gstreamer-vaapi uses the surfaces handles as identifier which are unsigned int. This bug can happen when using a lot of vaapi surfaces within the same process. Indeed Mesa/st/va increments a counter for the surface ID

Re: [Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

Emil, > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Tuesday, July 25, 2017 7:46 PM > To: Wu, Zhongmin > Cc: ML mesa-dev ; Kondapally, Kalyan > ; Marathe, Yogesh > ; Antognolli, Rafael > ; Gao, Shuo ; Tomasz Figa > ; Chris Wilson ; Eric > Engestrom ;

Re: [Mesa-dev] [PATCH V3] i965 : Optimize atom state flag checks

Hi Matt, Sorry for late reply, please see below. > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > Of Matt Turner > Sent: Saturday, July 22, 2017 12:12 AM > To: Muthukumar, Aravindan > Cc: mesa-dev@lists.freedesktop.org; Marathe, Yogesh > >

Re: [Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

Hi Zhongmin, Thanks you for the update. There's a couple of important comments - dri2_make_current + droid_window_enqueue_buffer. The rest is just nitpiks. Tomasz, hats down for the immense help and guidance. On the potential performance hit (due to the extra fence), I think we could do some tes

Re: [Mesa-dev] [PATCH 065/101] mesa: add KHR_no_error support to glDeleteBuffers()

56-65: Reviewed-by: Timothy Arceri I've just sent a small series to remove some extra error paths from here that I noticed while reviewing this [1] [1] https://patchwork.freedesktop.org/series/27863/ On 22/07/17 03:40, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mapi/g

[Mesa-dev] [PATCH 2/3] mesa: move static binding functions above _mesa_DeleteBuffers()

--- src/mesa/main/bufferobj.c | 412 +++--- 1 file changed, 205 insertions(+), 207 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index e9bb492..6ed2800 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c

[Mesa-dev] [PATCH 1/3] mesa: don't try to re-generate the default buffer

It should have been created by this point. --- src/mesa/main/bufferobj.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 419972e..e9bb492 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@

[Mesa-dev] [PATCH 3/3] mesa: call binding functions directly from glDeleteBuffers

--- src/mesa/main/bufferobj.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 6ed2800..dc8df19 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1536,14 +1536,18 @@ _mesa_DeleteBuf

Re: [Mesa-dev] [PATCH v2] st/dri: add 32-bit RGBX/RGBA formats

On Mon, Jul 24, 2017 at 9:46 PM, Chih-Wei Huang wrote: > On Tue 11 Jul 2017, Rob Herring wrote: >>> From: Marek Olšák >>> >>> Add support for 32-bit RGBX/RGBA formats which are required for Android. >>> >>> The original patch (commit ccdcf91104a5) was reverted (commit >>> c0c6ca40a25e) in mesa as

Re: [Mesa-dev] [PATCH] radeon/vcn: move message buffer to vram for now

On 07/25/2017 05:19 AM, Christian König wrote: Am 25.07.2017 um 08:27 schrieb Michel Dänzer: On 25/07/17 02:54 AM, Leo Liu wrote: To workaround an unknown bug. Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_vcn_dec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

  1   2   >