Re: [Mesa-dev] [PATCH 3/3] radeonsi: rely on CLEAR_STATE for clearing UCP and blend color registers

For the series: Reviewed-by: Nicolai Hähnle On 28.07.2017 02:28, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_hw_context.c | 8 ++-- src/gallium/drivers/radeonsi/si_pipe.h | 2 ++

Re: [Mesa-dev] [PATCH 1/2] st/mesa: release sampler views when redefining a texture in st_context_teximage

On 28.07.2017 02:27, Marek Olšák wrote: From: Marek Olšák Noticed randomly. Cc: 17.2 Reviewed-by: Nicolai Hähnle --- src/mesa/state_tracker/st_manager.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [Mesa-dev] [PATCH 01/13] gallium: add PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE and corresponding cap

On 27.07.2017 23:17, Roland Scheidegger wrote: Am 27.07.2017 um 21:14 schrieb Nicolai Hähnle: From: Nicolai Hähnle --- src/gallium/auxiliary/util/u_dump_defines.c | 1 + src/gallium/auxiliary/util/u_inlines.h | 1 +

Re: [Mesa-dev] [PATCH v2 20/73] radeonsi: scan NIR shaders to obtain required info

On Wed, Jul 5, 2017 at 12:48 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/radeonsi/Makefile.sources | 1 + > src/gallium/drivers/radeonsi/si_shader.c| 1 + > src/gallium/drivers/radeonsi/si_shader.h

[Mesa-dev] [PATCH] radeonsi: expose MRT-draw-calls to HUD

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeon/r600_query.c | 7 +++ src/gallium/drivers/radeon/r600_query.h | 1 + src/gallium/drivers/radeonsi/si_state_draw.c | 2 ++ 4 files changed, 11 insertions(+)

[Mesa-dev] [Bug 101952] OpenCL enqueueReadBuffer returns trash

https://bugs.freedesktop.org/show_bug.cgi?id=101952 --- Comment #6 from Janpieter Sollie --- in external_funtion (where the while loop is executed): unsigned char count = 0, result = 0; uchar left = 32, plen; private unsigned char digest[80]; I

[Mesa-dev] [PATCH 4/6] st/dri: add drisw image extension

Since the revelant functions have been moved to dri_helpers, drisw.c can make use of the extension. Note we have version 6 of the extension, since we want to support createImageFromTexture. --- src/gallium/state_trackers/dri/drisw.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[Mesa-dev] [PATCH 2/6] st/dri: organize order of includers in dri_helpers

Although it doesn't seem like a strict requirement of the code base, we do it when possible and it looks nice. --- src/gallium/state_trackers/dri/dri_helpers.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri_helpers.c

[Mesa-dev] [PATCH 6/6] egl/x11: use dri2_create_image_khr for swrast

This will allow the swrast driver to use eglCreateImageKHR, provided the target is EGL_GL_TEXTURE_2D_KHR or EGL_GL_RENDERBUFFER_KHR. Note we still have to implement the create from render buffer path. --- src/egl/drivers/dri2/platform_x11.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 5/6] egl/dri2: add image extension such it's usable by swrast driver

Otherwise, this extension is not visible to the EGL users who use the swrast driver. v2: add it to optional_core_extensions instead of swrast_core_extensions, so it's not a requirement (Emil) --- src/egl/drivers/dri2/egl_dri2.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH 3/6] st/dri: move some image functions to dri_helpers.c

These functions will be used both by drisw.c and dri2.c. This patch also moves some headers that can be shared. --- src/gallium/state_trackers/dri/dri2.c| 105 +- src/gallium/state_trackers/dri/dri_helpers.c | 108 ++-

[Mesa-dev] [PATCH 1/6] st/dri: change dri_extensions to dri_helpers

These files provide helper structs and functions for dri2.c and drisw.c, and name change better conveys that. --- src/gallium/state_trackers/dri/Makefile.sources| 4 ++-- src/gallium/state_trackers/dri/dri2.c | 2 +-

[Mesa-dev] [PATCH 1/6] st/dri: change dri_extensions to dri_helpers

From: Gurchetan Singh These files provide helper structs and functions for dri2.c and drisw.c, and name change better conveys that. --- src/gallium/state_trackers/dri/Makefile.sources| 4 ++-- src/gallium/state_trackers/dri/dri2.c

Re: [Mesa-dev] Issue with 3008161d28: st_glsl_to_tgsi: rewrite rename registers to use array fully.

On 07/27/2017 05:52 PM, Dave Airlie wrote: On 28 July 2017 at 09:37, Brian Paul wrote: Hi Dave, We found an issue with this change: commit 3008161d28e38336ba39aba4769a2deaf9732f55 Author: Dave Airlie Date: Tue May 30 15:52:13 2017 +1000

[Mesa-dev] [PATCH] radv: handle 10-bit format clamping workaround.

From: Dave Airlie This fixes: dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.* for a2r10g10b10 formats as destination on SI/CIK hardware. This adds support to the meta program for emitting 10-bit outputs, and adds 10-bit support to the fragment shader key. It also

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix assertion failure in st_get_texture_sampler_view_from_stobj

On Fri, Jul 28, 2017 at 4:37 AM, Eric Anholt wrote: > Marek Olšák writes: > >> From: Marek Olšák >> >> Remove the assertion and replace it with a runtime check. >> The reason of the failure is unknown. >> >> Only Eric Anholt can reproduce

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix assertion failure in st_get_texture_sampler_view_from_stobj

Marek Olšák writes: > From: Marek Olšák > > Remove the assertion and replace it with a runtime check. > The reason of the failure is unknown. > > Only Eric Anholt can reproduce it with Glamor. Found the root cause. See the last patch of the

[Mesa-dev] [PATCH 3/6] broadcom/vc4: Implement GL_ARB_texture_barrier.

Improves x11perf -copywinwin100 from ~2000/sec to ~4700/sec. More importantly, this is a prerequisite for the new GL_MESA_tile_raster_order extension. --- src/gallium/drivers/vc4/vc4_context.c | 11 +++ src/gallium/drivers/vc4/vc4_screen.c | 2 +- 2 files changed, 12 insertions(+), 1

[Mesa-dev] [PATCH 6/6] vc4: Keep pipe_sampler_view->texture matching the original texture.

I was overwriting view->texture with the shadow resource when we need to do shadow copies (retiling or baselevel rebase), but that tripped up some critical new sanity checking in state_tracker (making sure that stObj->pt hasn't changed from view->texture through TexImage-related paths). To avoid

[Mesa-dev] [PATCH 5/6] mesa: Implement a new GL_MESA_tile_raster_order extension.

The intent is to use this extension on vc4 to allow X11 to do overlapping CopyArea() within a pixmap without first blitting the pixmap to a temporary. With associated glamor patches, improves x11perf -copywinwin100 performance on a Raspberry Pi 3 from ~4700/sec to ~5130/sec, and is an even larger

[Mesa-dev] [PATCH 4/6] gallium: Expose a PIPE_CAP_TILE_RASTER_ORDER on vc4.

Because vc4 can control the order that tiles are rasterized in, we can use it to implement overlapping blits using normal drawing and GL_ARB_texture_barrier as long as we can tell the kernel what order to render the tiles in. --- include/drm-uapi/vc4_drm.h| 17 ++---

[Mesa-dev] [PATCH 0/6] Proposed GL_MESA_tile_raster_order extension

This extension came from trying to get vc4's window movement in X11 to be as fast as it used to be with software rendering. Without the extension, overlapping copies need to first get read to a temporary, while with the extension the vc4 driver can be forced to rasterize the tiles in a specific

[Mesa-dev] [PATCH 1/6] docs: Fix a typo in the old MESA_program_debug spec.

Noticed that we had two 0x8bb4 in the spec while grepping to find an open slot in the MESA enums set. gl.xml had the right value. --- docs/specs/OLD/MESA_program_debug.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/specs/OLD/MESA_program_debug.spec

[Mesa-dev] [PATCH 2/6] docs: Update the list of used MESA GL enums.

--- docs/specs/enums.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/specs/enums.txt b/docs/specs/enums.txt index 222adbc72e71..00d808483a43 100644 --- a/docs/specs/enums.txt +++ b/docs/specs/enums.txt @@ -63,6 +63,16 @@ GL_MESAX_texture_stack:

[Mesa-dev] [PATCH 1/3] radeonsi: use CLEAR_STATE to initialize some registers

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 58 +++-- 1 file changed, 4 insertions(+), 54 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index b7f5566..ac76b12

[Mesa-dev] [PATCH 2/3] radeonsi: rely on CLEAR_STATE for resetting the framebuffer and sample mask

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_hw_context.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_hw_context.c b/src/gallium/drivers/radeonsi/si_hw_context.c index 345825a..cceb827 100644

[Mesa-dev] [PATCH 3/3] radeonsi: rely on CLEAR_STATE for clearing UCP and blend color registers

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_hw_context.c | 8 ++-- src/gallium/drivers/radeonsi/si_pipe.h | 2 ++ src/gallium/drivers/radeonsi/si_state.c | 4 3 files changed, 12 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] st/mesa: fix assertion failure in st_get_texture_sampler_view_from_stobj

From: Marek Olšák Remove the assertion and replace it with a runtime check. The reason of the failure is unknown. Only Eric Anholt can reproduce it with Glamor. Cc: 17.2 --- src/mesa/state_tracker/st_sampler_view.c | 4 ++-- 1 file

[Mesa-dev] [PATCH 1/2] st/mesa: release sampler views when redefining a texture in st_context_teximage

From: Marek Olšák Noticed randomly. Cc: 17.2 --- src/mesa/state_tracker/st_manager.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index 62924b0..4b4d4ac

Re: [Mesa-dev] [PATCH] mesa: init more msaa fields

Reviewed-by: Samuel Pitoiset On 07/27/2017 07:12 PM, Brian Paul wrote: The default values for GL_SAMPLE_SHADING and GL_MIN_SAMPLE_SHADING_VALUE are missing from the state tables in the GL spec, but they're supposed to be GL_FALSE and 0.0, per the

Re: [Mesa-dev] Issue with 3008161d28: st_glsl_to_tgsi: rewrite rename registers to use array fully.

On 28 July 2017 at 09:37, Brian Paul wrote: > Hi Dave, > > We found an issue with this change: > > commit 3008161d28e38336ba39aba4769a2deaf9732f55 > Author: Dave Airlie > Date: Tue May 30 15:52:13 2017 +1000 > > st_glsl_to_tgsi: rewrite rename

[Mesa-dev] Issue with 3008161d28: st_glsl_to_tgsi: rewrite rename registers to use array fully.

Hi Dave, We found an issue with this change: commit 3008161d28e38336ba39aba4769a2deaf9732f55 Author: Dave Airlie Date: Tue May 30 15:52:13 2017 +1000 st_glsl_to_tgsi: rewrite rename registers to use array fully. Instead of having to search the whole array, just

Re: [Mesa-dev] [PATCH 01/13] gallium: add PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE and corresponding cap

Am 27.07.2017 um 23:17 schrieb Roland Scheidegger: > Am 27.07.2017 um 21:14 schrieb Nicolai Hähnle: >> From: Nicolai Hähnle >> >> --- >> src/gallium/auxiliary/util/u_dump_defines.c | 1 + >> src/gallium/auxiliary/util/u_inlines.h | 1 + >>

Re: [Mesa-dev] [PATCH 01/13] gallium: add PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE and corresponding cap

Am 27.07.2017 um 21:14 schrieb Nicolai Hähnle: > From: Nicolai Hähnle > > --- > src/gallium/auxiliary/util/u_dump_defines.c | 1 + > src/gallium/auxiliary/util/u_inlines.h | 1 + > src/gallium/docs/source/context.rst | 9 +++-- >

Re: [Mesa-dev] [PATCH] st/glsl_to_tgsi: fix getting the image type for array of structs

Reviewed-by: Marek Olšák Marek On Thu, Jul 27, 2017 at 5:12 PM, Samuel Pitoiset wrote: > Since array splitting for AoA is disabled, we have to retrieve > the type of the first non-array type when an array of images is > declared inside a

Re: [Mesa-dev] [PATCH 2/2] mesa: remove gl_sync_object::Type field

For the series: Reviewed-by: Marek Olšák Marek On Thu, Jul 27, 2017 at 4:05 PM, Samuel Pitoiset wrote: > This is useless. > > Signed-off-by: Samuel Pitoiset > --- > src/mesa/main/mtypes.h | 1 - >

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/5] radeonsi/gfx9: fix vertex idx in ES with multiple waves per threadgroup

On 27.07.2017 20:48, Emil Velikov wrote: Hi Nicolai, On 17 July 2017 at 11:57, Nicolai Hähnle wrote: From: Nicolai Hähnle Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_shader.c | 7 ++- 1 file changed, 6

Re: [Mesa-dev] [PATCH] radv: force compute flush at end of command stream.

On 27 July 2017 at 07:37, Dave Airlie wrote: > On 27 July 2017 at 00:06, Nicolai Hähnle wrote: >> On 26.07.2017 05:42, Dave Airlie wrote: >>> >>> From: Dave Airlie >>> >>> This seems like a workaround, but we don't see the bug on

Re: [Mesa-dev] [PATCH] gallium/docs: document automatic per-sample FS execution

On Thu, Jul 27, 2017 at 10:29 PM, Roland Scheidegger wrote: > Ok, I suppose that makes sense. > I just wouldn't be surprised if some driver instead just relies on the > set_min_samples() value all the time and ignoring it should really run > at per sample frequency in any

Re: [Mesa-dev] [PATCH] gallium/docs: document automatic per-sample FS execution

Ok, I suppose that makes sense. I just wouldn't be surprised if some driver instead just relies on the set_min_samples() value all the time and ignoring it should really run at per sample frequency in any case. Reviewed-by: Roland Scheidegger Am 27.07.2017 um 21:31 schrieb

[Mesa-dev] [Bug 101851] [regression] libEGL_common.a undefined reference to '__gxx_personality_v0'

https://bugs.freedesktop.org/show_bug.cgi?id=101851 --- Comment #2 from Mike Lothian --- Realise I never mentioned in the bug, this only happens with ld.gold, not ld.bfd It can be controlled with passing -fuse-ld=bfd or -fuse-ld=gold in your LD_FLAGS -- You are receiving

[Mesa-dev] [Bug 101851] [regression] libEGL_common.a undefined reference to '__gxx_personality_v0'

https://bugs.freedesktop.org/show_bug.cgi?id=101851 Mike Lothian changed: What|Removed |Added CC||m...@fireburn.co.uk

Re: [Mesa-dev] [PATCH] gallium/docs: document automatic per-sample FS execution

The DX10.1 docs specify this, and there's language in both the GL_ARB_sample_shading and GLSL 4.00 specs that this behavior is expected. I think it makes sense to say the same for gallium. Mesa's _mesa_get_min_invocations_per_fragment() returns N samples when the FS uses the sample ID or

[Mesa-dev] [AppVeyor] mesa master #5055 completed

Build mesa 5055 completed Commit 06e20c4b8c by Nicolai Hähnle on 7/14/2017 1:10 PM: radeonsi: bail out instead of crashing if the main shader part failed to compile\n\nReviewed: Marek Olšák Configure your notification

[Mesa-dev] [PATCH 08/13] gallium/radeon: fix render predication by SO overflow predicate

From: Nicolai Hähnle The predication bits are "visible or no overflow" and "not visible or overflow", so we need to invert the check relative to the GL and Gallium interface semantics. Also, predication by the other streamout-related queries is not allowed. ---

[Mesa-dev] [PATCH 13/13] radeonsi: enable ARB_transform_feedback_overflow_query

From: Nicolai Hähnle --- docs/features.txt | 2 +- docs/relnotes/17.3.0.html | 2 +- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/features.txt b/docs/features.txt

[Mesa-dev] [PATCH 12/13] radeonsi: avoid redundant SET_PREDICATION packet with QBO workaround

From: Nicolai Hähnle The QBO workaround compute grid launch emits the render condition atom when dirty, so install the render condition in the context only after launching the compute grid. This avoids a redundant SET_PREDICATION. ---

[Mesa-dev] [PATCH 07/13] gallium/radeon: fix ARB_query_buffer_object conversion to boolean

From: Nicolai Hähnle The issue here is that the immediate is treated as a 64-bit value, and fetching it does not work reliably with swizzles that are different from xy and zw. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeon/r600_query.c | 3 ++- 1

[Mesa-dev] [PATCH 09/13] gallium/radeon: implement basic parts of PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE

From: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_query.c | 96 - 1 file changed, 71 insertions(+), 25 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c index

[Mesa-dev] [PATCH 10/13] gallium/radeon: implement qbo for SO_OVERFLOW_PREDICATE

From: Nicolai Hähnle --- src/gallium/drivers/radeon/r600_query.c | 44 +++-- 1 file changed, 37 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c index

[Mesa-dev] [PATCH 11/13] radeonsi: fix streamout overflow predication on VI+

From: Nicolai Hähnle There is a firmware regression that causes failures. Work around it by using the compute shader for query_buffer_objects to summarize the query results. --- src/amd/common/r600d_common.h | 1 + src/gallium/drivers/radeon/r600_query.c | 88

[Mesa-dev] [PATCH 06/13] st/mesa: implement ARB_transform_feedback_overflow_query

From: Nicolai Hähnle --- src/mesa/state_tracker/st_cb_queryobj.c | 4 +++- src/mesa/state_tracker/st_extensions.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_queryobj.c b/src/mesa/state_tracker/st_cb_queryobj.c

[Mesa-dev] [PATCH 04/13] gallium/util: add util_{str, dump}_query_value_type

From: Nicolai Hähnle --- src/gallium/auxiliary/util/u_dump.h | 6 ++ src/gallium/auxiliary/util/u_dump_defines.c | 25 + 2 files changed, 31 insertions(+) diff --git a/src/gallium/auxiliary/util/u_dump.h

[Mesa-dev] [PATCH 03/13] gallium: add util_dump_query_type and use it in ddebug

From: Nicolai Hähnle --- src/gallium/auxiliary/util/u_dump.h | 2 ++ src/gallium/auxiliary/util/u_dump_defines.c | 10 ++ src/gallium/drivers/ddebug/dd_draw.c| 12 +--- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH 05/13] ddebug: handle get_query_result_resource as a GPU call

From: Nicolai Hähnle --- src/gallium/drivers/ddebug/dd_context.c | 32 - src/gallium/drivers/ddebug/dd_draw.c| 64 + src/gallium/drivers/ddebug/dd_pipe.h| 28 +++ 3 files changed, 92 insertions(+), 32

[Mesa-dev] [PATCH 02/13] gallium: rename util_dump_* to util_str_* for enum-to-string conversion

From: Nicolai Hähnle This is mostly mechanical search-and-replace, plus touching up the macros in u_dump_defines.c manually a bit. --- src/gallium/auxiliary/util/u_dump.h | 26 src/gallium/auxiliary/util/u_dump_defines.c | 88

[Mesa-dev] [PATCH 00/13] radeonsi: implement ARB_transform_feedback_overflow_query

From: Nicolai Hähnle Hi all, Pretty much as the subject said. The two modes (one stream vs. all streams) of queries are a bit annoying, and I decided to add a new Gallium query type as well. I find this cleaner than overloading the stream/index parameter. Please review!

[Mesa-dev] [PATCH 01/13] gallium: add PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE and corresponding cap

From: Nicolai Hähnle --- src/gallium/auxiliary/util/u_dump_defines.c | 1 + src/gallium/auxiliary/util/u_inlines.h | 1 + src/gallium/docs/source/context.rst | 9 +++-- src/gallium/docs/source/screen.rst | 2 ++

[Mesa-dev] [AppVeyor] mesa master #5054 failed

Build mesa 5054 failed Commit 194ff5eed1 by George Kyriazis on 7/22/2017 4:23 AM: swr: fix transform feedback logic\n\nThe shader that is used to copy vertex data out of the vs/gs shaders to\nthe user-specified buffer (streamout or SO shader) was not using

[Mesa-dev] [Bug 101952] OpenCL enqueueReadBuffer returns trash

https://bugs.freedesktop.org/show_bug.cgi?id=101952 --- Comment #5 from Jan Vesely --- (In reply to Janpieter Sollie from comment #4) > yes, a simpler kernel works perfectly. Though I think it only makes the > search more difficult: yes, it might be miscompilation on

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

> On Jul 27, 2017, at 1:49 PM, Ilia Mirkin wrote: > > On Thu, Jul 27, 2017 at 2:45 PM, Kyriazis, George > wrote: >> >> On Jul 27, 2017, at 1:25 PM, Ilia Mirkin wrote: >> >> On Wed, Jul 26, 2017 at 6:27 PM, George

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

On Thu, Jul 27, 2017 at 2:45 PM, Kyriazis, George wrote: > > On Jul 27, 2017, at 1:25 PM, Ilia Mirkin wrote: > > On Wed, Jul 26, 2017 at 6:27 PM, George Kyriazis > wrote: > > The shader that is used to copy vertex data

Re: [Mesa-dev] [PATCH] gallium/docs: document automatic per-sample FS execution

Are you sure on this? If you can do per-sample shading (there's a cap bit for it), then you're supposed to implement set_min_samples(). The state tracker will set this accordingly if these inputs are used then. Though maybe it would make sense regardless... Roland Am 27.07.2017 um 19:54

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/5] radeonsi/gfx9: fix vertex idx in ES with multiple waves per threadgroup

Hi Nicolai, On 17 July 2017 at 11:57, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/gallium/drivers/radeonsi/si_shader.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

On Jul 27, 2017, at 1:25 PM, Ilia Mirkin > wrote: On Wed, Jul 26, 2017 at 6:27 PM, George Kyriazis > wrote: The shader that is used to copy vertex data out of the vs/gs shaders to the

Re: [Mesa-dev] [PATCH] mesa: init more msaa fields

Am 27.07.2017 um 19:12 schrieb Brian Paul: > The default values for GL_SAMPLE_SHADING and GL_MIN_SAMPLE_SHADING_VALUE > are missing from the state tables in the GL spec, but they're supposed > to be GL_FALSE and 0.0, per the GL_ARB_sample_shading spec. > > Add code for that, just to be explicit.

Re: [Mesa-dev] [PATCH 2/2] st/mesa: remove useless st_bufferobj_validate_usage()

It's an empty, unused stub ever since it was introduced. Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

On Wed, Jul 26, 2017 at 6:27 PM, George Kyriazis wrote: > The shader that is used to copy vertex data out of the vs/gs shaders to > the user-specified buffer (streamout or SO shader) was not using the > correct offsets. > > Adjust the offsets that are used just for the

Re: [Mesa-dev] [PATCH v2] swr: fix transform feedback logic

Reviewed-by: Bruce Cherniak > On Jul 26, 2017, at 5:27 PM, George Kyriazis > wrote: > > The shader that is used to copy vertex data out of the vs/gs shaders to > the user-specified buffer (streamout or SO shader) was not using the >

Re: [Mesa-dev] [PATCH 1/2] st/mesa: remove st_cache.h

On 27 July 2017 at 15:05, Samuel Pitoiset wrote: > It only contains prototypes. It contains unused prototypes, since c2afa182f31 ("mesa: remove st_cache.c") Reviewed-by: Emil Velikov -Emil ___

[Mesa-dev] [Bug 101952] OpenCL enqueueReadBuffer returns trash

https://bugs.freedesktop.org/show_bug.cgi?id=101952 --- Comment #4 from Janpieter Sollie --- yes, a simpler kernel works perfectly. Though I think it only makes the search more difficult: the combination of these functions does not work (no 255 is visible): in

[Mesa-dev] [PATCH] gallium/docs: document automatic per-sample FS execution

Both the GLSL 4.00 specs and DX10.1 specs specify that if a fragment shader uses the sample ID or sample position inputs, the shader is automatically run at per sample frequency. Document that expectation for gallium fragment shaders. --- src/gallium/docs/source/tgsi.rst | 6 ++ 1 file

[Mesa-dev] [PATCH] mesa: init more msaa fields

The default values for GL_SAMPLE_SHADING and GL_MIN_SAMPLE_SHADING_VALUE are missing from the state tables in the GL spec, but they're supposed to be GL_FALSE and 0.0, per the GL_ARB_sample_shading spec. Add code for that, just to be explicit. --- src/mesa/main/multisample.c | 2 ++ 1 file

[Mesa-dev] [Bug 101933] autotools: wayland-protocols used even if not found

https://bugs.freedesktop.org/show_bug.cgi?id=101933 --- Comment #3 from Dylan Baker --- Here's the output from make: make[3]: Entering directory '/home/dylan/source/mesa/distcheck/src/egl' make[3]: *** No rule to make target

[Mesa-dev] [Bug 101952] OpenCL enqueueReadBuffer returns trash

https://bugs.freedesktop.org/show_bug.cgi?id=101952 --- Comment #3 from Jan Vesely --- it might be, but I'd have expected that to show up more frequently, though it might be related to your hw configuration. does a simpler kernel work? kernel void outTest(global int*

[Mesa-dev] [Bug 101952] OpenCL enqueueReadBuffer returns trash

https://bugs.freedesktop.org/show_bug.cgi?id=101952 --- Comment #2 from Janpieter Sollie --- Hi Mr. Vesely, hereby a minimal extract: __kernel void startTest(__constant char* arg, __constant uchar* arg2, size_t arg3, __constant char* phrase, size_t _len, __global

[Mesa-dev] [Bug 101952] OpenCL enqueueReadBuffer returns trash

https://bugs.freedesktop.org/show_bug.cgi?id=101952 Jan Vesely changed: What|Removed |Added Blocks||99553 --- Comment

[Mesa-dev] [PATCH] st/glsl_to_tgsi: fix getting the image type for array of structs

Since array splitting for AoA is disabled, we have to retrieve the type of the first non-array type when an array of images is declared inside a structure. Otherwise, it will hit an assert in glsl_type::sampler_index() because it expects either a sampler or an image type. This fixes a regression

[Mesa-dev] [PATCH 1/2] mesa: drop fence type parameter from NewSyncObject()

This is useless. Signed-off-by: Samuel Pitoiset --- src/mesa/drivers/dri/i915/intel_syncobj.c | 2 +- src/mesa/drivers/dri/i965/brw_sync.c | 2 +- src/mesa/main/dd.h| 2 +- src/mesa/main/syncobj.c | 5 ++---

[Mesa-dev] [PATCH 2/2] st/mesa: remove useless st_bufferobj_validate_usage()

Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_cb_bufferobjects.c | 13 - src/mesa/state_tracker/st_cb_bufferobjects.h | 6 -- 2 files changed, 19 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_bufferobjects.c

[Mesa-dev] [PATCH 2/2] mesa: remove gl_sync_object::Type field

This is useless. Signed-off-by: Samuel Pitoiset --- src/mesa/main/mtypes.h | 1 - src/mesa/main/syncobj.c | 5 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 0d0536c775..404d586ff7 100644 ---

[Mesa-dev] [PATCH 1/2] st/mesa: remove st_cache.h

It only contains prototypes. Signed-off-by: Samuel Pitoiset --- src/mesa/Makefile.sources | 1 - src/mesa/state_tracker/st_cache.h | 69 --- 2 files changed, 70 deletions(-) delete mode 100644

[Mesa-dev] [Bug 101952] OpenCL enqueueReadBuffer returns trash

https://bugs.freedesktop.org/show_bug.cgi?id=101952 Janpieter Sollie changed: What|Removed |Added CC|

[Mesa-dev] [Bug 101952] OpenCL enqueueReadBuffer returns trash

https://bugs.freedesktop.org/show_bug.cgi?id=101952 Bug ID: 101952 Summary: OpenCL enqueueReadBuffer returns trash Product: Mesa Version: 17.1 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH 077/101] mesa: add KHR_no_error support to glPointSize()

76-77: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 24/24] radeonsi: enable support for EXT_memory_object

From: Andres Rodriguez v2: fix an indentation error v3: don't enable for r600 Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák Reviewed-by: Timothy Arceri --- src/gallium/drivers/radeonsi/si_pipe.c |

[Mesa-dev] [PATCH 22/24] radv: generate same device UUID as radeonsi

From: Andres Rodriguez This is required for interop use cases. The same device must report identical UUIDs through the GL and Vulkan APIs so that users can identify when it is safe to perform a memory object import. v2: use ac helpers to calculate the uuid Signed-off-by:

[Mesa-dev] [PATCH 21/24] mesa: hook up queries for NUM_TILING_TYPES and TILING_TYPES

From: Andres Rodriguez These are just basic implementations. Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri Reviewed-by: Samuel Pitoiset --- src/mesa/main/formatquery.c | 17

[Mesa-dev] [PATCH 15/24] mesa/st: expose EXT_memory_object and EXT_memory_object_fd

From: Andres Rodriguez v2: use PIPE_CAP_MEMOBJ to guard the extension v3 (Timothy Arceri): - expose extensions via the cap_mappings array Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri fir expose ---

[Mesa-dev] [PATCH 23/24] radv: generate the same driver UUID as radeonsi

From: Andres Rodriguez These need to match for interop compatibility queries. Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/amd/vulkan/radv_device.c | 9 - src/amd/vulkan/radv_private.h | 1 + 2

[Mesa-dev] [PATCH 13/24] mesa: hook up (Named)BufferStorageMem api

Include no_error variants as well. v2 (Timothy Arceri): - reduced code churn by squashing some changes into previous commits v3 (Timothy Arceri): - drop unused function declaration Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri ---

[Mesa-dev] [PATCH 16/24] mesa: implement glGetUnsignedByte{v|i_v}

From: Andres Rodriguez These are used by EXT_external_objects to present UUIDs for the device and the driver. v2 (Timothy Arceri): - remove extra break - use _mesa_problem() rather the _mesa_error() for unimplemented support for value types Signed-off-by: Andres

[Mesa-dev] [PATCH 19/24] ac/gpu: add driver/device UUID query helpers

From: Andres Rodriguez We need vulkan and gl to produce the same UUIDs. Therefore we should keep the mechanism to compute these in a common location to guarantee they are updated in lockstep. Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák

[Mesa-dev] [PATCH 20/24] radeonsi: hook up device/driver UUID queries

From: Andres Rodriguez v2: move from r600_common to radeonsi Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[Mesa-dev] [PATCH 17/24] gallium: introduce device/driver UUID queries

From: Andres Rodriguez v2: remove unnecessary returns v3 (Timothy Arceri): updated trace Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák (v2) --- src/gallium/drivers/ddebug/dd_screen.c | 18 ++

[Mesa-dev] [PATCH 18/24] mesa: hook up UUID queries for driver and device

From: Andres Rodriguez v2: respective changes for new gallium interface v3: fix UUID size asserts Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri Reviewed-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH 14/24] gallium: introduce PIPE_CAP_MEMOBJ

From: Andres Rodriguez This can be used to guard support for EXT_memory_object and related extensions. v2: update gallium docs v3 (Timothy Arceri): - add cap to nv50 Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák ---

[Mesa-dev] [PATCH 11/24] radeonsi: add basic memory object support

From: Dave Airlie v2: also consider gfx9 metadata v3: ref/unref memobj->buf v4: add refcount comment Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 7 ++

[Mesa-dev] [PATCH 12/24] mesa/st: implement memory objects as a backend for buffer objects

From: Andres Rodriguez Use a memory object instead of user memory. Signed-off-by: Andres Rodriguez Reviewed-by: Timothy Arceri --- src/mesa/main/dd.h | 12 +

[Mesa-dev] [PATCH 09/24] mesa/st: implement memory objects as a backend for texture storage

From: Dave Airlie Instead of allocating memory to back a texture, use the provided memory object. v2: split off extension exposure logic v3: de-duplicate code with st_AllocTextureStorage Signed-off-by: Andres Rodriguez Reviewed-by: Marek Olšák

  1   2   >