[Mesa-dev] [PATCH 1/2] r300: drop u_mm.h include.

2017-08-01 Thread Dave Airlie
From: Dave Airlie This is not used in any of these files. Signed-off-by: Dave Airlie --- src/gallium/drivers/r300/r300_emit.c| 1 - src/gallium/drivers/r300/r300_hyperz.c | 1 - src/gallium/drivers/r300/r300_state.c | 1 - src/gallium/drivers/r300/r300_texture.c | 1 - 4 files changed,

[Mesa-dev] [PATCH 2/2] mesa/dri: drop unneeded mm.h include

2017-08-01 Thread Dave Airlie
From: Dave Airlie This isn't used in any of these drivers. Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/i915/i830_texblend.c | 1 - src/mesa/drivers/dri/i915/intel_context.h | 1 - src/mesa/drivers/dri/r200/r200_context.h| 1 - src/mesa/drivers/dri/radeon

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #30 from John --- (In reply to Dave Airlie from comment #28) > can you try the patch on master? > > https://patchwork.freedesktop.org/series/27906/ The bevarior is the same for me as a day ago. Max Max hanged at the exact same spot

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #29 from Marko --- (In reply to Dave Airlie from comment #28) > can you try the patch on master? > > https://patchwork.freedesktop.org/series/27906/ Thanks Dave, will try! Marko -- You are receiving this mail because: You are th

Re: [Mesa-dev] [PATCH] gallivm: Fix build against LLVM SVN >= r302589

2017-08-01 Thread Michel Dänzer
On 02/08/17 01:57 PM, Keith Packard wrote: > Michel Dänzer writes: > >> +#if HAVE_LLVM >= 0x0500 >> + virtual void deregisterEHFrames() { >> + mgr()->deregisterEHFrames(); >> + } >> +#elif HAVE_LLVM >= 0x0304 >> + virtual void deregisterEHFrames(uint8_t *Addr, uint64_t Load

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #28 from Dave Airlie --- can you try the patch on master? https://patchwork.freedesktop.org/series/27906/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #27 from John --- That does not seem much better in your case :/ Maybe I'll try a few emulators such as Dolphin and RPCS3 to see what happens. It'd be great if we could get a dev back here :) -- You are receiving this mail becaus

[Mesa-dev] [Bug 101334] AMD SI cards: Some vulkan apps freeze the system

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #26 from Marko --- Hi, For the life of me can't find the commit I was using yesterday since I did a fresh checkout and deleted the source before testing, but it was something like early 2017-08-01 commits IIRC. DOOM and Dota2 stil

Re: [Mesa-dev] [PATCH] gallivm: Fix build against LLVM SVN >= r302589

2017-08-01 Thread Keith Packard
Michel Dänzer writes: > +#if HAVE_LLVM >= 0x0500 > + virtual void deregisterEHFrames() { > + mgr()->deregisterEHFrames(); > + } > +#elif HAVE_LLVM >= 0x0304 > + virtual void deregisterEHFrames(uint8_t *Addr, uint64_t LoadAddr, > size_t Size) { > + mgr()->deregister

[Mesa-dev] [PATCH 1/2] anv: Advertise support for two more sRGB formats

2017-08-01 Thread Jason Ekstrand
Unreal Engine 4 seems to really like VK_FORMAT_R8_SRGB for some reason. We don't technically have the hardware format but we do have L8_SRGB. It's easy enough to fake with that and a swizzle. While we're at it, we may as well support R8G8_SRGB using L8A8_SRGB. --- src/intel/vulkan/anv_formats.c |

[Mesa-dev] [PATCH 2/2] spirv: Fix SpvImageFormatR16ui

2017-08-01 Thread Jason Ekstrand
Cc: "17.1 17.2" --- src/compiler/spirv/spirv_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 4b9c121..7b34dad 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_

Re: [Mesa-dev] [Mesa-dev RESEND 26/26] mesa: add KHR_no_error support to glPolygonMode()

2017-08-01 Thread Timothy Arceri
\o/ 9-26: Reviewed-by: Timothy Arceri Thanks for doing all this :) Please try to knock off a few more piglit tests here and there when time permits, it would be a shame if dev's tried to start turning this stuff on only to run into strange errors.

[Mesa-dev] [PATCH] i965: Delete pitch alignment assertion in get_blit_intratile_offset_el.

2017-08-01 Thread Kenneth Graunke
The cacheline alignment restriction is on the base address; the pitch can be anything. Fixes assertion failures when using primus (say, on glxgears, which creates a 300x300 linear BGRX surface with a pitch of 1200): intel_blit.c:190: get_blit_intratile_offset_el: Assertion `mt->surf.row_pitch %

[Mesa-dev] [PATCH] build: Don't bail on OSError in git_sha1_gen.py

2017-08-01 Thread Tobias Klausmann
When building sandboxed, we may encounter additional errors. Ignore the errors, as we are in a constrained environment. This can be observed when building latest git with OBS. Signed-off-by: Tobias Klausmann --- bin/git_sha1_gen.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bin/git_

Re: [Mesa-dev] [PATCH] glsl: look up for transform feedback varyings after linking

2017-08-01 Thread Timothy Arceri
On 06/07/17 19:12, Juan A. Suarez Romero wrote: Check if shaders have transform feedback varyings also after the post-link step. This fixes: KHR-GL45.enhanced_layouts.xfb_vertex_streams piglit/spec/arb_enhanced_layouts/gs-stream-location-aliasing --- src/compiler/glsl/glsl_to_nir.cpp | 3 +++

[Mesa-dev] [Bug 102010] libvulkan_radeon crashes if loaded on Intel hardware

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102010 --- Comment #1 from Thiago Macieira --- Also submitted at libvulkan itself: https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/1978 I don't know what is at fault: whether it's libvulkan for loading the wrong driver, or the

[Mesa-dev] [Bug 102010] libvulkan_radeon crashes if loaded on Intel hardware

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102010 Bug ID: 102010 Summary: libvulkan_radeon crashes if loaded on Intel hardware Product: Mesa Version: 17.1 Hardware: Other OS: All Status: NEW Severity: no

[Mesa-dev] [PATCH] vulkan/wsi: handle UINT64_MAX timeout correctly.

2017-08-01 Thread Dave Airlie
From: Dave Airlie The spec says "If timeout is UINT64_MAX, the function will not return until an image is acquired from the presentation engine." Now I know UINT64_MAX is probably heat death of the universe, but this changes the code to avoid calculating things in that case and uses the pthread

[Mesa-dev] [PATCH 1/2] gallium: add CAPs to support HW atomic counters.

2017-08-01 Thread Dave Airlie
From: Dave Airlie This looks like an evergreen specific feature, but with atomic counters AMD have hw specific counters they use instead of operating on buffers directly. These are separate to the buffer atomics, so require different limits and code paths. I've left the CAP for atomic type exten

[Mesa-dev] [PATCH 2/2] mesa/st: add support for hw atomics

2017-08-01 Thread Dave Airlie
From: Dave Airlie This adds support for hw atomics to the state tracker, it just sets the limits using the new CAPs, and sets the maximums etc for it. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_extensions.c | 50 +++--- 1 file changed, 40 insertions(+)

[Mesa-dev] [PATCH 1/5] intel/isl: Set MOCS based on usage for surface states

2017-08-01 Thread Jason Ekstrand
This makes ISL now ignore the MOCS data provided by the caller and just set it based on surface usage. --- src/intel/isl/isl_emit_depth_stencil.c | 12 src/intel/isl/isl_genX_mocs.h | 53 ++ src/intel/isl/isl_surface_state.c | 9 +++--- 3 fil

[Mesa-dev] [PATCH 4/5] anv: Stop passing MOCS information into ISL

2017-08-01 Thread Jason Ekstrand
As of a couple of commits ago, ISL is ignoring it. --- src/intel/vulkan/anv_device.c | 1 - src/intel/vulkan/anv_image.c | 12 src/intel/vulkan/anv_private.h | 2 -- src/intel/vulkan/genX_cmd_buffer.c | 13 - src/intel/vulkan/genX_state.c | 3 --- 5

[Mesa-dev] [PATCH 2/5] intel/blorp: Delete the MOCS plumbing

2017-08-01 Thread Jason Ekstrand
--- src/intel/blorp/blorp.h | 6 -- src/intel/blorp/blorp_genX_exec.h | 37 +++ src/intel/vulkan/anv_blorp.c | 3 --- src/mesa/drivers/dri/i965/brw_blorp.c | 15 -- 4 files changed, 24 insertions(+), 37 deletions(-) diff

[Mesa-dev] [PATCH 5/5] intel/isl: Get rid of the mocs fields in fill/emit_info

2017-08-01 Thread Jason Ekstrand
They are now unused. --- src/intel/isl/isl.h | 22 -- 1 file changed, 22 deletions(-) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index dafe952..e392f72 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@ -1254,13 +1254,6 @@ struct isl_surf_fill_state_info

[Mesa-dev] [PATCH 3/5] i965: Stop passing MOCS information into ISL

2017-08-01 Thread Jason Ekstrand
As of a couple of commits ago, ISL is ignoring it. --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 26 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c

[Mesa-dev] [PATCH 0/5] intel/isl: Set MOCS based on view usage

2017-08-01 Thread Jason Ekstrand
This little series changes things around so that, instead of passing MOCS values into ISL, ISL knows how to set them itself. This allows us to centralize some of the decisions about how MOCS gets set for surfaces and hopefully, if we ever do anything crazy in the future, we can share it between GL

Re: [Mesa-dev] [PATCH 2/5] anv: Add MAX_API_VERSION to anv_extensions.py

2017-08-01 Thread Lionel Landwerlin
On 01/08/17 23:32, Jason Ekstrand wrote: On Tue, Aug 1, 2017 at 2:07 PM, Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: On 01/08/17 19:54, Jason Ekstrand wrote: The VkVersion class is probably overkill but it makes it really easy to compare version

Re: [Mesa-dev] [PATCH 2/2] anv: Advertise VK_KHR_relaxed_block_layout

2017-08-01 Thread Lionel Landwerlin
On 01/08/17 23:33, Jason Ekstrand wrote: On Tue, Aug 1, 2017 at 2:03 PM, Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: Since this is available from 1.0.57, do we need to bump the supported API version first? I don't think it really matters Rb then :) On 01/0

[Mesa-dev] [RFC] intel: Common MOCS metadata straw-man

2017-08-01 Thread Jason Ekstrand
This is more of a straw-man patch than something I intend to land today. The idea is to come up with some central way of representing MOCS that we can use from either GL or Vulkan. I have no idea if this is how we want to represent MOCS or not. There are many alternative approaches: 1) Having a

Re: [Mesa-dev] [PATCH 2/2] anv: Advertise VK_KHR_relaxed_block_layout

2017-08-01 Thread Jason Ekstrand
On Tue, Aug 1, 2017 at 2:03 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Since this is available from 1.0.57, do we need to bump the supported API > version first? > I don't think it really matters > On 01/08/17 17:02, Jason Ekstrand wrote: > >> There is literally no work for

Re: [Mesa-dev] [PATCH 2/5] anv: Add MAX_API_VERSION to anv_extensions.py

2017-08-01 Thread Jason Ekstrand
On Tue, Aug 1, 2017 at 2:07 PM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 01/08/17 19:54, Jason Ekstrand wrote: > >> The VkVersion class is probably overkill but it makes it really easy to >> compare versions in a way that's safe without the caller having to think >> about pat

[Mesa-dev] [Bug 97852] Unreal Engine corrupted preview viewport

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97852 --- Comment #10 from Markus --- Any news on this? -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freede

[Mesa-dev] [Bug 102003] Mesa demos doesn't compile due to gles1

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102003 Mike Lothian changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH 6/6] egl/x11: use dri2_create_image_khr for swrast

2017-08-01 Thread Gurchetan Singh
Thanks for the reviews! I rebased patch number #4, and added platform_wayland support and squashed this patch to form patch #5. Note it seems platform_drm already has the correct path for swrast, since gbm_dri_screen_extensions already has the lookup extension and the dri2_drm_display_vtbl is use

[Mesa-dev] [PATCH 5/5] egl/dri2: add image extension such it's usable by swrast driver

2017-08-01 Thread Gurchetan Singh
Otherwise, this extension is not visible to the EGL users who use the swrast driver. This will allow the swrast driver to use eglCreateImageKHR, provided the target is EGL_GL_TEXTURE_2D_KHR or EGL_GL_RENDERBUFFER_KHR. Note we still have to implement the create from render buffer path. v2: add it

[Mesa-dev] [PATCH 4/5] st/dri: add drisw image extension

2017-08-01 Thread Gurchetan Singh
Since the revelant functions have been moved to dri_helpers, drisw.c can make use of the extension. Note we have version 6 of the extension, since we want to support createImageFromTexture. v2: Rebase to master --- src/gallium/state_trackers/dri/drisw.c | 11 +++ 1 file changed, 11 insert

Re: [Mesa-dev] [PATCH] radeon/ac: use ds_swizzle for derivs on si/cik.

2017-08-01 Thread Marek Olšák
Tested on SI. Acked-by: Marek Olšák Marek On Tue, Aug 1, 2017 at 6:14 AM, Dave Airlie wrote: > From: Dave Airlie > > This looks like it's supported since llvm 3.9 at least, > so switch over radeonsi and radv to using it, -pro also > uses this. We can now drop creating lds for these operations

Re: [Mesa-dev] [PATCH 1/5] anv: Make some bits of anv_extensions module-private

2017-08-01 Thread Lionel Landwerlin
Patches 1, 3, 4 & 5 are: Reviewed-by: Lionel Landwerlin On 01/08/17 19:54, Jason Ekstrand wrote: This way we can use "from anv_extensions import *" in the entrypoint generator without worrying too much about pollution --- src/intel/vulkan/anv_entrypoints_gen.py | 4 ++-- src/intel/vulkan/an

Re: [Mesa-dev] [PATCH 2/5] anv: Add MAX_API_VERSION to anv_extensions.py

2017-08-01 Thread Lionel Landwerlin
On 01/08/17 19:54, Jason Ekstrand wrote: The VkVersion class is probably overkill but it makes it really easy to compare versions in a way that's safe without the caller having to think about patch vs. no patch. --- src/intel/vulkan/anv_entrypoints_gen.py | 4 +-- src/intel/vulkan/anv_extensi

Re: [Mesa-dev] [PATCH 2/2] anv: Advertise VK_KHR_relaxed_block_layout

2017-08-01 Thread Lionel Landwerlin
Since this is available from 1.0.57, do we need to bump the supported API version first? On 01/08/17 17:02, Jason Ekstrand wrote: There is literally no work for us to do here. It already just works in our driver. --- src/intel/vulkan/anv_device.c | 4 1 file changed, 4 insertions(+) d

Re: [Mesa-dev] [PATCH] ac/nir: Add float cast before shadow comparator clamp.

2017-08-01 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Aug 1, 2017 at 12:27 PM, Bas Nieuwenhuizen wrote: > LLVM complained about passing an i32 to a float clamp. > > Signed-off-by: Bas Nieuwenhuizen > Fixes: 0f9e32519bb "ac/nir: clamp shadow texture comparison value on VI" > --- > src/amd/common/ac_nir_to_ll

Re: [Mesa-dev] [PATCH] glsl: look up for transform feedback varyings after linking

2017-08-01 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jul 6, 2017 at 11:12 AM, Juan A. Suarez Romero wrote: > Check if shaders have transform feedback varyings also after the > post-link step. > > This fixes: > KHR-GL45.enhanced_layouts.xfb_vertex_streams > piglit/spec/arb_enhanced_layouts/gs-stream-location-

Re: [Mesa-dev] [PATCH 13/13] radeonsi: enable ARB_transform_feedback_overflow_query

2017-08-01 Thread Marek Olšák
I commented on patches 9 and 11. Other than that, the series is: Reviewed-by: Marek Olšák Marek On Thu, Jul 27, 2017 at 9:14 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > docs/features.txt | 2 +- > docs/relnotes/17.3.0.html | 2 +- > src/galliu

Re: [Mesa-dev] [PATCH 11/13] radeonsi: fix streamout overflow predication on VI+

2017-08-01 Thread Marek Olšák
On Thu, Jul 27, 2017 at 9:14 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > There is a firmware regression that causes failures. Work around it by > using the compute shader for query_buffer_objects to summarize the query > results. > --- > src/amd/common/r600d_common.h | 1 + >

Re: [Mesa-dev] [PATCH 09/13] gallium/radeon: implement basic parts of PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE

2017-08-01 Thread Marek Olšák
Hi Nicolai, Can you add R600_MAX_STREAM = 4 to make the code more readable? Thanks, Marek On Thu, Jul 27, 2017 at 9:14 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/radeon/r600_query.c | 96 > - > 1 file changed, 71 insertions(

Re: [Mesa-dev] [PATCH] swr: Add arch flags to support Cray and PGI compilers

2017-08-01 Thread Rowley, Timothy O
On Jul 31, 2017, at 3:51 PM, Chuck Atkins mailto:chuck.atk...@kitware.com>> wrote: Hi Tim, If the Cray flags are for wrapper scripts, why do we need specific flags for that instead of using the underlying compiler flags? Sort answer: It's the "Cray" way of doing things. Long answer: The targ

Re: [Mesa-dev] [PATCH v2 6/6] radeonsi: try to re-use previously deleted bindless descriptor slots

2017-08-01 Thread Marek Olšák
Hi Samuel, Can you move this slot allocator into a util module? It seems generic enough that it could be reused for "handle" and "ID" allocations. Some additional notes: - a bit array of uin32_t would be better. bool is too large (1 byte). - "free" is the inverse of "used", so the "used" array is

[Mesa-dev] [PATCH v2 17/17] swr/rast: fix core / knights split of AVX512 intrinsics

2017-08-01 Thread Tim Rowley
Move AVX512BW specific intrinics to be Core-only. Move some AVX512F intrinsics back to common implementation file. --- .../drivers/swr/rasterizer/common/simdlib.hpp | 2 + .../swr/rasterizer/common/simdlib_512_avx512.inl | 53 + .../rasterizer/common/simdlib_512_avx512

[Mesa-dev] [PATCH v2 14/17] swr/rast: gen_knobs template code style

2017-08-01 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/codegen/templates/gen_knobs.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_knobs.cpp b/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_knobs.cpp index e6fe165..a95

[Mesa-dev] [PATCH v2 16/17] swr/rast: simplify knob default value setup

2017-08-01 Thread Tim Rowley
--- .../drivers/swr/rasterizer/codegen/templates/gen_knobs.h| 13 - src/gallium/drivers/swr/rasterizer/core/knobs_init.h| 12 +++- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_knobs.h b/sr

[Mesa-dev] [PATCH v2 15/17] swr/rast: split gen_knobs templates into .h/.cpp

2017-08-01 Thread Tim Rowley
Switch to a 1:1 mapping template:generated for future maintenance. --- src/gallium/drivers/swr/Makefile.am| 3 +- src/gallium/drivers/swr/SConscript | 2 +- .../drivers/swr/rasterizer/codegen/gen_knobs.py| 14 +- .../swr/rasterizer/codegen/templates/gen_kno

[Mesa-dev] [PATCH v2 06/17] swr/rast: stop using MSFT types in platform independent code

2017-08-01 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/os.h | 6 -- src/gallium/drivers/swr/rasterizer/core/api.cpp| 2 +- src/gallium/drivers/swr/rasterizer/core/api.h | 4 ++-- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 4 ++-- src/gallium/dr

[Mesa-dev] [PATCH v2 08/17] swr/rast: rename frontend pVertexStore

2017-08-01 Thread Tim Rowley
Rename to reflect global nature. --- src/gallium/drivers/swr/rasterizer/core/frontend.cpp | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/frontend.cpp b/src/gallium/drivers/swr/rasterizer/core/frontend.cpp index f9eda83..

[Mesa-dev] [PATCH v2 13/17] swr/rast: switch gen_knobs.cpp license

2017-08-01 Thread Tim Rowley
Unintentionally added with an apache2 license; relicense to match the rest of the tree. --- .../swr/rasterizer/codegen/templates/gen_knobs.cpp | 29 +- 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_knobs

[Mesa-dev] [PATCH v2 12/17] swr/rast: fix scons gen_knobs.h dependency

2017-08-01 Thread Tim Rowley
Copy/paste error was duplicating a gen_knobs.cpp rule. --- src/gallium/drivers/swr/SConscript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/SConscript b/src/gallium/drivers/swr/SConscript index a32807d..c578d7a 100644 --- a/src/gallium/drivers/swr/SCo

[Mesa-dev] [PATCH v2 09/17] swr/rast: vmask() implementations for KNL

2017-08-01 Thread Tim Rowley
--- .../swr/rasterizer/common/simdlib_512_avx512_knights.inl | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512_knights.inl b/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512_knights.inl index 17001be..2e

[Mesa-dev] [PATCH v2 03/17] swr/rast: fix USE_SIMD16_FRONTEND issues

2017-08-01 Thread Tim Rowley
Fix problems found when enabling USE_SIMD16_FRONTEND, mostly related to vMask / movemask_ps(pd). --- .../drivers/swr/rasterizer/common/simd16intrin.h| 14 ++ .../drivers/swr/rasterizer/common/simdintrin.h | 21 + .../swr/rasterizer/common/simdlib_128_avx.in

[Mesa-dev] [PATCH v2 07/17] swr/rast: fix movemask_ps / movemask_pd on AVX512

2017-08-01 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl b/src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl index 1001417..1dbf

[Mesa-dev] [PATCH v2 10/17] swr/rast: SIMD16 shaders - widen fetch and vertex shaders

2017-08-01 Thread Tim Rowley
Work in progress, disabled by default. --- .../drivers/swr/rasterizer/core/frontend.cpp | 33 src/gallium/drivers/swr/rasterizer/core/knobs.h| 1 + src/gallium/drivers/swr/rasterizer/core/state.h| 10 ++ .../drivers/swr/rasterizer/jitter/JitManager.cpp | 16 ++ .../driver

[Mesa-dev] [PATCH v2 00/17] swr: update rasterizer

2017-08-01 Thread Tim Rowley
Highlights include enabling the simd16 frontend and code cleanups. v2: split previous gen_knobs patch into five chunks: scons fix, relicense to match rest of tree, code style, template split, simplification of default value setup Tim Rowley (17): swr/rast: threadID via portable std::this_th

[Mesa-dev] [PATCH v2 05/17] swr/rast: enable USE_SIMD16_FRONTEND by default

2017-08-01 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/knobs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/knobs.h b/src/gallium/drivers/swr/rasterizer/core/knobs.h index 7ad6fe3..10bd4a5 100644 --- a/src/gallium/drivers/swr/rasterizer/core/kno

[Mesa-dev] [PATCH v2 02/17] swr/rast: simdlib better seperation of core vs. knights avx512

2017-08-01 Thread Tim Rowley
--- src/gallium/drivers/swr/Makefile.am| 2 +- src/gallium/drivers/swr/Makefile.sources | 8 + .../drivers/swr/rasterizer/common/simdlib.hpp | 21 ++- .../swr/rasterizer/common/simdlib_128_avx512.inl | 108 +++- .../rasterizer/common/simdlib_128_avx512

[Mesa-dev] [PATCH v2 01/17] swr/rast: threadID via portable std::this_thread::get_id()

2017-08-01 Thread Tim Rowley
Replace use of Win32 GetCurrentThreadId() with portable std::this_thread::get_id(). --- .../codegen/templates/gen_ar_eventhandlerfile.hpp| 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_ar_eventh

[Mesa-dev] [PATCH v2 04/17] swr/rast: disable AVX512 optimization of SSE / AVX code

2017-08-01 Thread Tim Rowley
Disable an optimization which implemented sse/avx operations on avx512 using avx512 intrinsics (to avoid switching between lane widths). Compile with SIMD_OPT_128_AVX512 / SIMD_OPT_256_AVX512 defined to enable these optimizations. --- src/gallium/drivers/swr/rasterizer/common/simdlib.hpp | 4

Re: [Mesa-dev] [PATCH v2 5/6] radeonsi: use slot indexes for bindless handles

2017-08-01 Thread Marek Olšák
There is an issue independent of this patch: si_update_all_resident_texture_descriptors only updates resident descriptors. Non-resident descriptors aren't updated, and si_make_texture_handle_resident doesn't update them either. I think it should be fixed in si_make_texture_handle_resident. Same fo

[Mesa-dev] [PATCH 3/5] anv: Use python to generate ICD json files

2017-08-01 Thread Jason Ekstrand
This is more lines of code but the python is far easier to read than the sed expressions we were using before. Also, this allows us to pull the API version from anv_entrypoints.py so it never gets out-of-sync. --- src/intel/Makefile.vulkan.am | 16 ++--- src/intel/vulkan/anv_icd.py

[Mesa-dev] [PATCH 4/5] anv: Pull the API version from anv_extensions.py

2017-08-01 Thread Jason Ekstrand
This way everything stays in sync and we only have the one version number. --- src/intel/vulkan/anv_device.c | 2 +- src/intel/vulkan/anv_extensions.py | 11 +++ src/intel/vulkan/anv_private.h | 1 + 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan

[Mesa-dev] [PATCH 5/5] anv: Bump the advertised version to 1.0.57

2017-08-01 Thread Jason Ekstrand
--- src/intel/vulkan/anv_extensions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index f4bfcf1..49254c1 100644 --- a/src/intel/vulkan/anv_extensions.py +++ b/src/intel/vulkan/anv_extensions.py @@ -31

[Mesa-dev] [PATCH 2/5] anv: Add MAX_API_VERSION to anv_extensions.py

2017-08-01 Thread Jason Ekstrand
The VkVersion class is probably overkill but it makes it really easy to compare versions in a way that's safe without the caller having to think about patch vs. no patch. --- src/intel/vulkan/anv_entrypoints_gen.py | 4 +-- src/intel/vulkan/anv_extensions.py | 43

[Mesa-dev] [PATCH 1/5] anv: Make some bits of anv_extensions module-private

2017-08-01 Thread Jason Ekstrand
This way we can use "from anv_extensions import *" in the entrypoint generator without worrying too much about pollution --- src/intel/vulkan/anv_entrypoints_gen.py | 4 ++-- src/intel/vulkan/anv_extensions.py | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/in

Re: [Mesa-dev] [PATCH mesa 4/4] egl/drm: clamp image to buffer size in swrast_{get_image, put_image2}

2017-08-01 Thread Eric Engestrom
I have pushed 1-3. DanielS, do we want this one too? Emil, I just realized that 2 and 3 depend on 1, but 1 isn't nominated for stable. I'll let you decide whether to pull all 3 in 17.2 or not. On Wednesday, 2017-07-19 15:05:32 +0100, Eric Engestrom wrote: > From: Mun Gwan-gyeong > > It adds l

Re: [Mesa-dev] [PATCH] gles: Restore some lost typedefs

2017-08-01 Thread Eric Engestrom
On Monday, 2017-07-17 11:00:26 -0700, Scott D Phillips wrote: > Eric Engestrom writes: > > > On Friday, 2017-06-30 15:06:36 -0700, Ian Romanick wrote: > >> Has this been reported to upstream (i.e., Khronos)? I don't mind fixing > >> these in our tree, but they really should get fixed at the sour

[Mesa-dev] [Bug 102003] Mesa demos doesn't compile due to gles1

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102003 Eric Engestrom changed: What|Removed |Added Blocks||101191 Referenced Bugs: https://bugs

[Mesa-dev] [Bug 102003] Mesa demos doesn't compile due to gles1

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102003 Eric Engestrom changed: What|Removed |Added Blocks|101191 |101911 Referenced Bugs: https://bugs

Re: [Mesa-dev] [PATCH 12/13] swr/rast: split gen_knobs template into .cpp and .h files

2017-08-01 Thread Rowley, Timothy O
On Jul 31, 2017, at 3:18 PM, Emil Velikov mailto:emil.l.veli...@gmail.com>> wrote: Hi Tim, What's the goal behind the split. Please add a couple of words in the commit message. Will do. On 31 July 2017 at 20:40, Tim Rowley mailto:timothy.o.row...@intel.com>> wrote: --- src/gallium/drivers/s

Re: [Mesa-dev] [PATCH v2 4/6] radeonsi: add si_emit_graphics_shader_pointers() helper

2017-08-01 Thread Marek Olšák
On Wed, Jul 26, 2017 at 4:21 PM, Samuel Pitoiset wrote: > To share common code between rw buffers and bindless descriptors. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeonsi/si_descriptors.c | 57 > +++ > 1 file changed, 31 insertions(+), 26 deletio

[Mesa-dev] [Bug 102003] Mesa demos doesn't compile due to gles1

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102003 --- Comment #2 from Eric Engestrom --- This is an issue with the upstream headers, which has been reported [1] and a fix suggested [2]. We will pull the update headers once Khronos merges the fix. In the mean time, this patch [3] should fix the

Re: [Mesa-dev] [PATCH v2 2/6] radeonsi: make some si_descriptors fields 32-bit

2017-08-01 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jul 26, 2017 at 4:21 PM, Samuel Pitoiset wrote: > The number of bindless descriptors is dynamic and we definitely > have to support more than 256 slots. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/radeonsi/si_state.h | 10 +- >

Re: [Mesa-dev] [PATCH v2 3/6] radeonsi: only initialize dirty_mask when CE is used

2017-08-01 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Jul 26, 2017 at 4:21 PM, Samuel Pitoiset wrote: > Looks like it's useless to initialize that field when CE is > unused. This will also allow to declare more than 64 elements > for the array of bindless descriptors. > > Signed-off-by: Samuel Pitoiset > ---

Re: [Mesa-dev] [PATCH 1/2] anv: Add a new centralized extensions file

2017-08-01 Thread Lionel Landwerlin
Both patches are : Reviewed-by: Lionel Landwerlin On 14/07/17 07:14, Jason Ekstrand wrote: This will allow us to keep everything in one place when it comes to declaring what extensions are supported. --- src/intel/Makefile.vulkan.am| 3 +- src/intel/vulkan/anv_entrypoints_gen.p

Re: [Mesa-dev] [PATCH] Convert git_sha1_gen script to Python.

2017-08-01 Thread Rob Herring
On Tue, Aug 1, 2017 at 8:38 AM, Jose Fonseca wrote: > Python is the scripting language we've been using for scripts that need > to run across all supported platforms. > > Shell is *not* a portable language for scripts. > --- [...] > diff --git a/src/mesa/Android.libmesa_git_sha1.mk > b/src/mesa

Re: [Mesa-dev] [PATCH 11/13] swr/rast: fixes for 32-bit builds

2017-08-01 Thread Rowley, Timothy O
> On Jul 31, 2017, at 3:56 PM, Emil Velikov wrote: > > Hi Tim, > > Some of the inline functions seem unused. > Very quick search showed the following: > > InterpolateComponent > _simd128_abs_ps > _simd_abs_ps The intent of simdlib is a general purpose vector library, so some functions/method

Re: [Mesa-dev] [PATCH mesa 1/3] egl: deduplicate swap interval clamping logic

2017-08-01 Thread Tapani Pälli
lgtm Reviewed-by: Tapani Pälli On 08/01/2017 03:55 PM, Eric Engestrom wrote: Signed-off-by: Eric Engestrom Reviewed-by: Daniel Stone --- src/egl/drivers/dri2/platform_wayland.c | 14 +- src/egl/drivers/dri2/platform_x11.c | 9 + src/egl/main/eglapi.c

[Mesa-dev] [PATCH 2/2] anv: Advertise VK_KHR_relaxed_block_layout

2017-08-01 Thread Jason Ekstrand
There is literally no work for us to do here. It already just works in our driver. --- src/intel/vulkan/anv_device.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index f69ebfc..b171c2b 100644 --- a/src/intel/vulkan/anv_devic

Re: [Mesa-dev] [PATCH v2 1/6] radeonsi: declare new user SGPR indices for bindless samplers/images

2017-08-01 Thread Marek Olšák
These stages should declare it too. They don't invoke declare_default_desc_pointers: SI_SHADER_MERGED_VERTEX_TESSCTRL SI_SHADER_MERGED_VERTEX_OR_TESSEVAL_GEOMETRY These functions should also pass the pointer: - si_set_ls_return_value_for_tcs - si_set_es_return_value_for_gs Marek On Wed, Jul 26

Re: [Mesa-dev] [PATCH 6/6] egl/x11: use dri2_create_image_khr for swrast

2017-08-01 Thread Emil Velikov
On 28 July 2017 at 04:48, Gurchetan Singh wrote: > This will allow the swrast driver to use eglCreateImageKHR, > provided the target is EGL_GL_TEXTURE_2D_KHR or > EGL_GL_RENDERBUFFER_KHR. Note we still have to implement the > create from render buffer path. Thanks for the re-spin Gurchetan! Impl

Re: [Mesa-dev] [PATCH 2/2] anv: Autogenerate extension query and lookup

2017-08-01 Thread Jason Ekstrand
Nanley or Lionel, could I get a second set of eyes on this? I don't want to push with just Emil's review as this is a significant change to how we do extensions. --Jason On Fri, Jul 14, 2017 at 7:17 AM, Emil Velikov wrote: > On 14 July 2017 at 07:14, Jason Ekstrand wrote: > > As time goes on,

Re: [Mesa-dev] [PATCH] docs: Add Vulkan to features.txt

2017-08-01 Thread Jason Ekstrand
On Tue, Aug 1, 2017 at 4:29 AM, Bas Nieuwenhuizen wrote: > On Tue, Aug 1, 2017 at 1:27 AM, Jordan Justen > wrote: > > On 2017-07-31 16:08:51, Bas Nieuwenhuizen wrote: > >> On Tue, Aug 1, 2017 at 12:32 AM, Jordan Justen > >> > +Vulkan 1.0 -- all DONE: anv > >> > >> So while we don't have conforma

Re: [Mesa-dev] [PATCH] glsl: look up for transform feedback varyings after linking

2017-08-01 Thread Juan A. Suarez Romero
On Thu, 2017-07-06 at 11:12 +0200, Juan A. Suarez Romero wrote: > Check if shaders have transform feedback varyings also after the > post-link step. > > This fixes: > KHR-GL45.enhanced_layouts.xfb_vertex_streams > piglit/spec/arb_enhanced_layouts/gs-stream-location-aliasing > --- > src/compiler/g

[Mesa-dev] Thou shalt not use shell scripts on Windows (Was: Mesa (master): build systems: uniformize git_sha1.h generation)

2017-08-01 Thread Jose Fonseca
Sorry for being late to the party - I was on PTO when this review went out. Only now I was trying to diagnose why some of our builds were broken for very long time, and tracked down to this. Let me start stating what I think it should be obvious for everybody: using a shell script on Windows

Re: [Mesa-dev] [PATCH] i965: skip varyings without slot

2017-08-01 Thread Juan A. Suarez Romero
On Mon, 2017-07-10 at 12:18 +0200, Juan A. Suarez Romero wrote: > On Thu, 2017-06-29 at 14:43 +1000, Timothy Arceri wrote: > > On 27/06/17 21:20, Juan A. Suarez Romero wrote: > > > On Tue, 2017-06-27 at 09:29 +1000, Timothy Arceri wrote: > > > > On 16/06/17 18:12, Juan A. Suarez Romero wrote: > > >

Re: [Mesa-dev] [PATCH 2/2] i965: Queue the buffer with a sync fence for Android OS v4.2

2017-08-01 Thread Rafael Antognolli
On Mon, Jul 31, 2017 at 09:58:24AM -0700, Marathe, Yogesh wrote: > Rafael, Tomasz, > > > -Original Message- > > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf > > Of Rafael Antognolli > > Sent: Tuesday, July 25, 2017 9:39 PM > > To: Wu, Zhongmin > > Cc: Gao, Shu

[Mesa-dev] [Bug 102003] Mesa demos doesn't compile due to gles1

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102003 Mike Lothian changed: What|Removed |Added CC||m...@fireburn.co.uk --- Comment #1 from

[Mesa-dev] [Bug 102003] Mesa demos doesn't compile due to gles1

2017-08-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102003 Bug ID: 102003 Summary: Mesa demos doesn't compile due to gles1 Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 1/3] glsl: recognize GLSL 4.60

2017-08-01 Thread Samuel Pitoiset
On 08/01/2017 04:47 PM, Ilia Mirkin wrote: Can be done in another patch, but you should go through all the relevant extension checks and update the with something that also considers the features enabled for 460. Should be fairly mechanical. Yeah, will do in a separate patch. On Aug 1, 20

Re: [Mesa-dev] [PATCH] Convert git_sha1_gen script to Python.

2017-08-01 Thread Emil Velikov
On 1 August 2017 at 15:37, Jose Fonseca wrote: > On 01/08/17 15:32, Emil Velikov wrote: >> >> On 1 August 2017 at 14:38, Jose Fonseca wrote: >>> >>> Python is the scripting language we've been using for scripts that need >>> to run across all supported platforms. >>> >>> Shell is *not* a portable

Re: [Mesa-dev] [PATCH mesa 1/3] egl: deduplicate swap interval clamping logic

2017-08-01 Thread Emil Velikov
On 1 August 2017 at 13:55, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > Reviewed-by: Daniel Stone If we only had implementation swap_interval implementation across the board, we could have simplified things ever further. Regardless, nice cleanup. For the lot Reviewed-by: Emil Velikov

Re: [Mesa-dev] [PATCH 1/3] glsl: recognize GLSL 4.60

2017-08-01 Thread Ilia Mirkin
Can be done in another patch, but you should go through all the relevant extension checks and update the with something that also considers the features enabled for 460. Should be fairly mechanical. On Aug 1, 2017 5:26 AM, "Samuel Pitoiset" wrote: > Signed-off-by: Samuel Pitoiset > --- > src/c

Re: [Mesa-dev] [PATCH] Convert git_sha1_gen script to Python.

2017-08-01 Thread Jose Fonseca
On 01/08/17 15:32, Emil Velikov wrote: On 1 August 2017 at 14:38, Jose Fonseca wrote: Python is the scripting language we've been using for scripts that need to run across all supported platforms. Shell is *not* a portable language for scripts. Guessing that you've hit some issues on Windows

Re: [Mesa-dev] [PATCH] Convert git_sha1_gen script to Python.

2017-08-01 Thread Emil Velikov
On 1 August 2017 at 14:38, Jose Fonseca wrote: > Python is the scripting language we've been using for scripts that need > to run across all supported platforms. > > Shell is *not* a portable language for scripts. Guessing that you've hit some issues on Windows? All the other platforms should be

  1   2   >