On 08/04/2017 12:33 AM, Marek Olšák wrote:
Hi Samuel,
FLUSH_VERTICES must be called *before* any of the states are changed, not after.
My mistake, please ignore this series...
Samuel.
Marek
On Wed, Aug 2, 2017 at 9:42 PM, Samuel Pitoiset
wrote:
Before:
DrawElements (1 VBO, 8 UBO, 8 Te
From: Dave Airlie
This mirrors what Marek has done for radeonsi, and uses
a separate counter to handle the fmask surface for MSAA
MRTs.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_device.c | 2 +-
src/amd/vulkan/radv_image.c | 5 -
src/amd/vulkan/radv_private.h | 7 ++-
3 fil
From: Dave Airlie
When Marek enabled mipmapped swizzle, radv didn't
have the code in place to handle it. This fixes the
regression.
I'll look more into GFX9 once I have a vega card (soon).
Fixes: 2b7e8556 (ac/surface: enable tile swizzle for mipmapped textures)
Signed-off-by: Dave Airlie
---
Hi,
thanks for detailed explanation. I indeed missed the writeBuffer part
in specs.
On Wed, 2017-08-02 at 15:05 -0700, Francisco Jerez wrote:
> These changes are somewhat redundant and potentially
> performance-impacting, the reason is that in the OpenCL API,
> clEnqueueWrite* commands are specif
Gets rid of a bunch of errors like the following:
make[4]: Entering directory '/home/me/src/mesa/build/src/gallium/targets/opencl'
CXXLDlibOpenCL.la
../../../../src/util/.libs/libxmlconfig.a(libxmlconfig_la-xmlconfig.o): In
function `driParseOptionInfo':
/home/me/src/mesa/src/util/xmlconfig
Fixes a segfault when running clinfo on my r600 (BARTS/6850). Valgrind
led me straight to the same line.
Tested-by: Aaron Watry
On Wed, Aug 2, 2017 at 1:15 PM, Jan Vesely wrote:
> Fixes: Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create
> functions")
> Signed-off-by: Jan V
Tomasz,
> -Original Message-
> From: Tomasz Figa [mailto:tf...@chromium.org]
> Sent: Friday, August 4, 2017 6:52 AM
> To: Marathe, Yogesh
> Cc: Emil Velikov ; Gao, Shuo
> ; Liu, Zhiquan ; Daniel Stone
> ; Nicolai Hähnle ;
> Antognolli, Rafael ; Eric Engestrom
> ; Wu, Zhongmin ; Kenneth
>
On 03/08/17 09:43 PM, Nicolai Hähnle wrote:
> On 03.08.2017 04:09, Michel Dänzer wrote:
>> On 03/08/17 01:14 AM, Nicolai Hähnle wrote:
>>> On 02.08.2017 18:04, Emil Velikov wrote:
On 2 August 2017 at 16:29, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Fixes: bc7f41e11d3 ("gal
We can't sample from depth-stencil formats but on gen7 but we can sample
from depth-only formats.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102024
---
src/intel/vulkan/anv_formats.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_formats.c b
From: Dave Airlie
This is a bug in the app, but I'd rather avoid hanging the GPU,
esp if someone is running in validation and it takes out their
development environment.
v2: get it right, reverse the polarity.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_meta_resolve.c | 5 +
1 file
On 03/08/17 11:25 PM, Thomas Hellstrom wrote:
> Hi, Michel.
>
> Thanks for doing this.
No worries, thank you for coming up with the fix in the first place. :)
> Was there a follow-up st/mesa fix to this. I remember someone posting
> about a problem about the new backbuffer always being NULL?
Y
From: Andres Rodriguez
This is required for interop use cases. The same device must report
identical UUIDs through the GL and Vulkan APIs so that users can
identify when it is safe to perform a memory object import.
v2: use ac helpers to calculate the uuid
Signed-off-by: Andres Rodriguez
Revie
From: Andres Rodriguez
Includes implementation stubs.
Signed-off-by: Andres Rodriguez
Acked-by: Timothy Arceri
Acked-by: Samuel Pitoiset
---
src/mapi/glapi/gen/EXT_external_objects.xml| 234 ++
src/mapi/glapi/gen/EXT_external_objects_fd.xml | 28 +++
src/mapi/glapi/g
From: Andres Rodriguez
v2: use PIPE_CAP_MEMOBJ to guard the extension
v3 (Timothy Arceri):
- expose extensions via the cap_mappings array
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
Reviewed-by: Samuel Pitoiset
---
src/mesa/main/extensions_table.h | 2 ++
src/mesa/mai
From: Andres Rodriguez
Use a memory object instead of user memory.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
Reviewed-by: Samuel Pitoiset
---
src/mesa/main/dd.h | 12 +
src/mesa/state_tracker/st_cb_bufferobjects.c | 66 +
From: Dave Airlie
v2: pass dedicated flag
v3 (Timothy Arceri):
- remove unrequired _mesa_init_memory_object_functions()
call in the state tracker.
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
Reviewed-by: Samuel Pitoiset
---
src/mesa/Makefile.sources| 2
From: Andres Rodriguez
v2: move from r600_common to radeonsi
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeonsi/si_pipe.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/gallium/drivers/radeonsi/si_pipe.c
b/src/gallium/drivers/ra
From: Andres Rodriguez
These need to match for interop compatibility queries.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/amd/vulkan/radv_device.c | 9 -
src/amd/vulkan/radv_private.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/amd
From: Andres Rodriguez
V2 (Timothy):
- error check memory == 0 before lookup
Signed-off-by: Andres Rodriguez
Reviewed-by: Samuel Pitoiset (v1)
---
src/mesa/main/externalobjects.c | 46 +
src/mesa/main/teximage.c| 75 +
s
From: Andres Rodriguez
These are used by EXT_external_objects to present UUIDs for the device
and the driver.
v2 (Timothy Arceri):
- remove extra break
- use _mesa_problem() rather the _mesa_error() for unimplemented
support for value types
Signed-off-by: Andres Rodriguez
Reviewed-by: Tim
From: Andres Rodriguez
Plumbing for importing memobj backed textures.
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeon/r600_texture.c | 63 ++-
1 file changed, 36 insertions(+), 27 deletions(-)
diff --git a/src/gallium/driver
From: Andres Rodriguez
v2: remove unnecessary returns
v3 (Timothy Arceri): updated trace
v4 (Timothy Arceri): actually dump the params in trace
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák (v2)
---
src/gallium/drivers/ddebug/dd_screen.c | 18 ++
src/gallium/drivers
From: Dave Airlie
v2: also consider gfx9 metadata
v3: ref/unref memobj->buf
v4: add refcount comment
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/gallium/drivers/radeon/r600_pipe_common.h | 7 ++
src/gallium/drivers/radeon/r600_texture.c | 115 +++
From: Dave Airlie
Instead of allocating memory to back a texture, use the provided memory
object.
v2: split off extension exposure logic
v3: de-duplicate code with st_AllocTextureStorage
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
Reviewed-by: Samuel Pitoiset
---
src/mesa/state
From: Andres Rodriguez
v2: fix an indentation error
v3: don't enable for r600
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
Reviewed-by: Timothy Arceri
---
src/gallium/drivers/radeonsi/si_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/driver
From: Andres Rodriguez
v2: respective changes for new gallium interface
v3: fix UUID size asserts
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
Reviewed-by: Samuel Pitoiset
---
src/mesa/main/dd.h | 15 +++
src/mesa/main/get.c | 17 ++
From: Andres Rodriguez
V2 (Timothy Arceri):
- fix copy and paste error with error message
V3 (Timothy Arceri):
- drop the Protected field for now as its unused
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
---
src/mesa/main/externalobjects.c | 50 +
From: Andres Rodriguez
These are just basic implementations.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
Reviewed-by: Samuel Pitoiset
---
src/mesa/main/formatquery.c | 17 +
src/mesa/main/mtypes.h | 3 +++
src/mesa/main/texparam.c| 27 +++
From: Andres Rodriguez
We need vulkan and gl to produce the same UUIDs. Therefore we should
keep the mechanism to compute these in a common location to guarantee
they are updated in lockstep.
Signed-off-by: Andres Rodriguez
Reviewed-by: Marek Olšák
---
src/amd/common/ac_gpu_info.c | 27 ++
From: Andres Rodriguez
Plumbing for using memory objects as texture storage.
Signed-off-by: Andres Rodriguez
Reviewed-by: Timothy Arceri
Reviewed-by: Marek Olšák
---
src/mesa/state_tracker/st_cb_texture.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff
From: Dave Airlie
v2: fix comment regarding fd ownership, define pipe_memory_object
v3: remove stray return
v4 (Timothy Arceri): update trace
v5 (Timothy Arceri): actually dump the params in trace
Reviewed-by: Marek Olšák (v3)
---
src/gallium/drivers/ddebug/dd_screen.c | 40 +++
Include no_error variants as well.
v2 (Timothy Arceri):
- reduced code churn by squashing some changes into
previous commits
v3 (Timothy Arceri):
- drop unused function declaration
v4 (Timothy Arceri):
- fix Driver function assert()
- add missing GL errors
Signed-off-by: Andres Rodriguez
From: Andres Rodriguez
Used by EXT_external_objects and EXT_external_objects_fd
V2 (Timothy Arceri):
- Throw GL_OUT_OF_MEMORY error if CreateMemoryObjectsEXT()
fails.
- C99 tidy ups
- remove void cast (Constantine Kharlamov)
V3 (Timothy Arceri):
- rename mo -> memObj
- check that the ob
V6 address Samuel's comments on v5 (including the ones I missed
in v4 whoops). I also added some missing error checks for
buffer storage and made a few other tidy-up that I noticed.
There is now so a very basic piglit api error test [1] which
depends on a gl.xml update which is stuck in moderatio
From: Andres Rodriguez
V2 (Timothy Arceri):
- formating fixes
V3 (Timothy):
- error check memory == 0 before lookup
Signed-off-by: Andres Rodriguez
Reviewed-by: Samuel Pitoiset (v2)
---
src/mesa/main/dd.h | 10
src/mesa/main/externalobjects.c | 128 ++
---
src/intel/vulkan/anv_extensions.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
index 00186bc..3252e0f 100644
--- a/src/intel/vulkan/anv_extensions.py
+++ b/src/intel/vulkan/anv_extensions.py
---
src/intel/vulkan/anv_batch_chain.c | 78 ++
src/intel/vulkan/anv_device.c | 1 +
src/intel/vulkan/anv_private.h | 8
src/intel/vulkan/anv_queue.c | 76 ++---
4 files changed, 140 insertions(+), 23 deletio
This patch series implements support for VK_KHR_external_semaphore for
Intel. The series relies on DRM syncobj and, while we do have fallbacks
for if the kernel does not support syncobj, I do want to land syncobj
support in mesa before enabling the xtension. This way we can rely on the
device->ha
This is mostly a copy+paste of the BO cache but it's a bit simpler
because syncobjs don't have actual backing storage so we don't need to
check sizes or anything like that. Also, we put the refcount directly
in anv_syncobj because they will always be heap pointers.
---
src/intel/vulkan/anv_alloca
---
src/intel/vulkan/anv_gem.c | 52
src/intel/vulkan/anv_gem_stubs.c | 24 +++
src/intel/vulkan/anv_private.h | 4
3 files changed, 80 insertions(+)
diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c
index 5
Vulkan allows you to do a submit whose only job is to wait on and
trigger semaphores. The easiest way for us to support that right
now is to insert a dummy execbuf.
---
src/intel/vulkan/anv_batch_chain.c | 28 +---
src/intel/vulkan/anv_device.c | 26 ++
---
src/intel/vulkan/anv_batch_chain.c | 57 +--
src/intel/vulkan/anv_device.c | 1 +
src/intel/vulkan/anv_gem.c | 36
src/intel/vulkan/anv_private.h | 23 +
src/intel/vulkan/anv_queue.c | 69 +
This patch adds an implementation based on DRM BOs. We don't actually
advertise the extension yet because we want to add a couple more paths
first.
---
src/intel/vulkan/anv_batch_chain.c | 31 +++-
src/intel/vulkan/anv_extensions.py | 3 +
src/intel/vulkan/anv_private.h | 3 +
src/in
Reviewed-by: Chad Versace
---
src/intel/vulkan/anv_gem.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c
index ac47da4..36692f5 100644
--- a/src/intel/vulkan/anv_gem.c
+++ b/src/intel/vulkan/anv_gem.c
@@ -185,7 +185,1
---
include/drm-uapi/i915_drm.h | 30 --
1 file changed, 28 insertions(+), 2 deletions(-)
diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_drm.h
index c26bf7c..338c8c2 100644
--- a/include/drm-uapi/i915_drm.h
+++ b/include/drm-uapi/i915_drm.h
@@ -431,6
Hi Yogesh,
On Fri, Aug 4, 2017 at 1:55 AM, Marathe, Yogesh
wrote:
> Adding folks who were CCed for earlier versions.
>
> Hi Emil, few doubts and comments below.
>
>> -Original Message-
>> From: Tomasz Figa [mailto:tf...@chromium.org]
>> Sent: Thursday, August 3, 2017 7:19 PM
>> To: Marath
From: Dave Airlie
This is a bug in the app, but I'd rather avoid hanging the GPU,
esp if someone is running in validation and it takes out their
development environment.
Signed-off-by: Dave Airlie
---
src/amd/vulkan/radv_meta_resolve.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/s
Am 03.08.2017 15:44, schrieb Nicolai Hähnle:
From: Nicolai Hähnle
The config passed into the screen should be independent from the state
tracker, because at least in the case of radeonsi, the screen structure
can be shared between different state trackers.
Incidentally, this also fixes crashes
On Thu, 2017-08-03 at 15:44 +0200, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> The config passed into the screen should be independent from the state
> tracker, because at least in the case of radeonsi, the screen structure
> can be shared between different state trackers.
>
> Incidentally,
https://bugs.freedesktop.org/show_bug.cgi?id=101982
--- Comment #8 from Link Mauve ---
When not using the opengl-hq profile of mpv, I get a much better error, I’m
still not sure why it doesn’t crash the compositor in this case, and it does in
the other one:
[…]
[3156842.470] -> wl_shell_surface
From: Dave Airlie
This just copies the code from the -pro shaders,
and fixes the tests on CIK.
With this CIK passes the same set of conformance
tests as VI.
Signed-off-by: Dave Airlie
---
src/amd/common/ac_nir_to_llvm.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
d
On Fri, Aug 4, 2017 at 12:26 AM, Marek Olšák wrote:
> Hi Alex,
>
> Which game uses texturing from MSAA depth buffers?
They don't necessarily have to do that, radv could also be doing some
superfluous layout transitions that might mess the texture up due to
not taking the samples into account.
-
Same thing about FLUSH_VERTICES as in patch 1.
Marek
On Wed, Aug 2, 2017 at 9:42 PM, Samuel Pitoiset
wrote:
> Before:
> DrawElements (1 VBO, 8 UBO, 8 Tex) w/ viewport change: 3.61 million (43.7%)
>
> After:
> DrawElements (1 VBO, 8 UBO, 8 Tex) w/ viewport change: 4.95 million (60.2%)
>
> Signed-
---
Please include this patch along with the others.
docs/features.txt | 2 +-
docs/relnotes/17.3.0.html | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/docs/features.txt b/docs/features.txt
index 28842ed0f2..bb20c33990 100644
--- a/docs/features.txt
+++ b/docs/fea
Hi Samuel,
FLUSH_VERTICES must be called *before* any of the states are changed, not after.
Marek
On Wed, Aug 2, 2017 at 9:42 PM, Samuel Pitoiset
wrote:
> Before:
> DrawElements (1 VBO, 8 UBO, 8 Tex) w/ scissor change: 3.67 million (44.4%)
>
> After:
> DrawElements (1 VBO, 8 UBO, 8 Tex) w/ scis
For the series:
Reviewed-by: Marek Olšák
Marek
On Thu, Aug 3, 2017 at 3:44 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Missed updating this caller of pipe_loader_find_module.
>
> Fixes: 0d7d60b7ea ("pipe-loader: pass only the driver_name to
> pipe_loader_find_module")
> ---
> src/g
Hi Alex,
Which game uses texturing from MSAA depth buffers?
Thanks,
Marek
On Thu, Aug 3, 2017 at 4:32 PM, Alex Smith wrote:
> Need to take the sample count into account in the depth decompress and
> resummarize pipelines and render pass.
>
> Fixes: f4e499ec791 ("radv: add initial non-conformant
Hi Chris,
The HUD is drawn inside SwapBuffers. It shouldn't be in every widget
unless every widget is a separate double-buffered GL window.
Marek
On Thu, Aug 3, 2017 at 6:50 PM, Chris Healy wrote:
> Running Android on top of Mesa has exposed an issue with the
> GALLIUM_HUD where we get the HUD
Signed-off-by: Jan Vesely
---
src/gallium/state_trackers/clover/llvm/codegen/native.cpp | 2 +-
src/gallium/state_trackers/clover/llvm/compat.hpp | 6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/clover/llvm/codegen/native.cpp
b/src/gall
https://bugs.freedesktop.org/show_bug.cgi?id=102032
programmerj...@gmail.com changed:
What|Removed |Added
CC||programmerj...@gmail.com
--
https://bugs.freedesktop.org/show_bug.cgi?id=102032
Bug ID: 102032
Summary: nir_op_imod is incorrectly implemented as LLVM's srem
Product: Mesa
Version: git
Hardware: All
OS: All
Status: NEW
Severity: norm
On 2017-08-03 10:56:08, Jason Ekstrand wrote:
> On Thu, Aug 3, 2017 at 10:22 AM, Jordan Justen
> wrote:
>
> > subect: form => from
> >
> > Commit message? Why is this being removed?
> >
>
> See below...
>
>
> > On 2017-08-02 13:35:29, Jason Ekstrand wrote:
> > > ---
> > > src/mesa/drivers/dri
On Thu, Aug 3, 2017 at 3:33 PM, Aaron Watry wrote:
> On Thu, Aug 3, 2017 at 11:53 AM, Jan Vesely wrote:
>> On Thu, 2017-08-03 at 00:28 -0500, Aaron Watry wrote:
>>> /
>>>
>>> On Sat, Jul 22, 2017 at 2:27 PM, Jan Vesely wrote:
>>> > On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote:
>>> > > Fi
On 3 August 2017 at 18:38, Juan A. Suarez Romero wrote:
> Commit 0ab04ba979b7 (anv: Use python to generate ICD json files) changed
> the way ICD json files are created.
>
> Remove the old .in files from extra dist, and add the python script.
Thanks Juan. For the series
Reviewed-by: Emil Velikov
https://bugs.freedesktop.org/show_bug.cgi?id=102030
Jan Vesely changed:
What|Removed |Added
Blocks||99553
Referenced Bugs:
https://bugs.free
On Thu, Aug 3, 2017 at 11:53 AM, Jan Vesely wrote:
> On Thu, 2017-08-03 at 00:28 -0500, Aaron Watry wrote:
>> /
>>
>> On Sat, Jul 22, 2017 at 2:27 PM, Jan Vesely wrote:
>> > On Fri, 2017-07-21 at 23:19 -0500, Aaron Watry wrote:
>> > > Fixes: OpenCL CTS test/conformance/buffers/buffer_copy
>> >
>>
https://bugs.freedesktop.org/show_bug.cgi?id=102010
Thiago Macieira changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Thu, Aug 3, 2017 at 12:12 PM, Samuel Pitoiset
wrote:
>
>
> On 08/01/2017 09:54 PM, Marek Olšák wrote:
>>
>> Hi Samuel,
>>
>> Can you move this slot allocator into a util module? It seems generic
>> enough that it could be reused for "handle" and "ID" allocations.
>
>
> What do you mean by "ID"
On Thu, Aug 3, 2017 at 7:54 PM, Juan A. Suarez Romero
wrote:
> On Fri, 2017-04-28 at 14:15 +0200, Nicolai Hähnle wrote:
>> On 28.04.2017 13:08, Eric Engestrom wrote:
>> > Hi,
>> >
>> > I'm currently running llvm r299777 but I have no idea when this was
>> > changed.
>>
>> Yeah, you'll just have to
On Thu, Aug 3, 2017 at 3:12 PM, Marek Olšák wrote:
> I'm OK with the patch. I think most drivers support nr_samples of 0
> and 1, which have the same behavior.
That's definitely true for nouveau, in fact we've gone to some lengths
to support nr_samples == 1...
>
> Reviewed-by: Marek Olšák
>
> M
I'm OK with the patch. I think most drivers support nr_samples of 0
and 1, which have the same behavior.
Reviewed-by: Marek Olšák
Marek
On Wed, Aug 2, 2017 at 7:07 PM, Brian Paul wrote:
> We pretty much use the convention that if gl_renderbuffer::NumSamples
> or gl_texture_image::NumSamples is
https://bugs.freedesktop.org/show_bug.cgi?id=102010
--- Comment #4 from Bas Nieuwenhuizen ---
Also for context, libvulkan loads all drivers on the system, after which the
driver is supposed to tell libvulkan if there are any devices it supports. That
part seems WAI to me.
It seems there are link
Emil Velikov writes:
> From: Emil Velikov
>
> Back in 2012 (commit 1e7776ca2bc - egl: Remove bogus invalidate code.)
> the loader use of invalidate() was purged as "bogus". One of the factors
> defining that statement was the lack of the loader-side invalidate
> extension - __DRI_USE_INVALIDATE.
The v4 version of the patch that was committed still has regressed build
for me.
Reverting and applying v2 still builds OK.
I now get -
Making all in targets/opencl
make[4]: Entering directory '/mnt/sdb1/Gits/mesa/src/gallium/targets/opencl'
CXXLDlibOpenCL.la
../../../../src/util/.libs/l
On Thu, Aug 3, 2017 at 11:12 AM, Mauro Rossi wrote:
> 2017-08-03 16:52 GMT+02:00 Emil Velikov :
>> On 3 August 2017 at 13:24, Mauro Rossi wrote:
>>> 2017-08-03 11:57 GMT+02:00 Emil Velikov :
Hi Mauro,
Thanks for the series. I'll pull 2&3 in a second - there's a minor
suggestio
Simply the function a bit and add a comment explaining why we don't
simply destroy any buffer.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_wayland.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_wayland.c
b/s
From: Emil Velikov
The function can be called only when the type is EGL_WINDOW_BIT.
Remove the unneeded switch statement.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_drm.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/src/egl/driver
From: Emil Velikov
The current two implementations - X11 and Wayland were identical,
barrind the upper limit.
Instead of having same code twice - introduce a helper and pass the
limit as an argument.
Thus as Android/DRM/others get support - they only need to call the
function ;-)
Signed-off-by
From: Emil Velikov
Fixes: 3b7b6adf3ac ("egl: Implement __DRI_BACKGROUND_CALLABLE")
Cc: Timothy Arceri
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_x11.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/drivers/dri2/platform_x11
From: Emil Velikov
The basic (null) check is identical across all backends.
Just move it to the top.
Note that eglCreateWindowSurface* already has a guard in the *Common
helper.
Cc: Eric Engestrom
Signed-off-by: Emil Velikov
---
Eric, the X11 hunk was changed/introduced by Frank with commit
2
From: Emil Velikov
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/platform_x11.c | 2 +-
src/egl/drivers/dri2/platform_x11_dri3.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_x11.c
b/src/egl/drivers/dri2/platform_x11.c
index 66
From: Emil Velikov
Having two callbacks to manage a single int seems like an overkill.
Use a cached copy and update that when needed.
Signed-off-by: Emil Velikov
---
Might want to look if the dimensions dance in .query_surface ...
speaking of which close to nobody implements that ...
---
src/e
From: Emil Velikov
XXX: commit message
XXX: keep it inline or move to egl_dri2.c
XXX: fold createwithmodifiers - now or as follow-up
Cc: Daniel Stone
Signed-off-by: Emil Velikov
---
Dan do you think it's a wise move to have this as a helper which tries
the withmodifiers call first and falls ba
From: Emil Velikov
Introduced back in 2010 with dri2proto v2.3 and Xserver 1.9
A look through the drivers indicate that only xf86-video-ati running
a kernel older than 2.6.35 or xf86-video-freedreno using kgsl (does it
work with EGL to begin with?) may be hitting this old codepath.
Other driver
From: Emil Velikov
Back in 2012 (commit 1e7776ca2bc - egl: Remove bogus invalidate code.)
the loader use of invalidate() was purged as "bogus". One of the factors
defining that statement was the lack of the loader-side invalidate
extension - __DRI_USE_INVALIDATE.
Since then the commit was revert
From: Emil Velikov
Both are always true, so there's no point in keeping them around.
Signed-off-by: Emil Velikov
---
src/egl/drivers/dri2/egl_dri2.h | 2 --
src/egl/drivers/dri2/platform_x11.c | 14 ++
2 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/src/egl/dri
From: Emil Velikov
If we get a xfixes v1.x we'll error out, without freeing the
xfixes_query reply.
Cc:
Signed-off-by: Emil Velikov
---
I don't feel that strongly about having this in stable, but meh.
---
src/egl/drivers/dri2/platform_x11.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/
Hi,
there also is a patch needed to make this work for Xorg on the
xorg-devel list as well as preliminary piglit test to verify the
functionality on the piglit list.
Grigori
On 2017-08-03 20:07, Grigori Goronzy wrote:
---
src/glx/dri2_glx.c | 12
src/glx/dri3_glx.c |
---
src/gallium/state_trackers/glx/xlib/glx_api.c | 55 ---
src/gallium/state_trackers/glx/xlib/xm_api.c | 6 ++-
src/gallium/state_trackers/glx/xlib/xm_api.h | 4 +-
3 files changed, 57 insertions(+), 8 deletions(-)
diff --git a/src/gallium/state_trackers/glx/xlib/glx
---
src/glx/dri2_glx.c | 12
src/glx/dri3_glx.c | 8
src/glx/dri_common.c| 52 -
src/glx/dri_common.h| 5 +
src/glx/drisw_glx.c | 3 +++
src/glx/glxclient.h | 6 ++
src/glx/glxextensions.c |
https://bugs.freedesktop.org/show_bug.cgi?id=102030
Janpieter Sollie changed:
What|Removed |Added
See Also||https://bugs.freedesktop.or
https://bugs.freedesktop.org/show_bug.cgi?id=101952
Janpieter Sollie changed:
What|Removed |Added
See Also||https://bugs.freedesktop.or
https://bugs.freedesktop.org/show_bug.cgi?id=102030
--- Comment #2 from Janpieter Sollie ---
fyi: I ran the program through oclgrind, this reports no problems ...
I ran the program with pocl, there's no problem there,
I ran the program with amdgpu-pro, no problem either
--
You are receiving thi
Reviewed-by: Jordan Justen
On 2017-08-02 13:35:36, Jason Ekstrand wrote:
> The only one of the three remaining flags that has anything whatsoever
> to do with layout is TILING_NONE. This commit renames them to
> MIPTREE_CREATE_*, documents the meaning of each flag, and makes the
> create functio
https://bugs.freedesktop.org/show_bug.cgi?id=102030
--- Comment #1 from Janpieter Sollie ---
Created attachment 133230
--> https://bugs.freedesktop.org/attachment.cgi?id=133230&action=edit
clover dump files
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are th
On Thu, Aug 3, 2017 at 10:32 AM, Jordan Justen
wrote:
> Maybe add reference to bf24c3539e4b6989512968cae12da2f88d2c53e9 where
> is was removed?
>
Done.
> Reviewed-by: Jordan Justen
>
> On 2017-08-02 13:35:34, Jason Ekstrand wrote:
> > ---
> > src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 5
In Mesa we use the convention that if gl_renderbuffer::NumSamples
or gl_texture_image::NumSamples is zero, it's a non-MSAA surface.
Otherwise, it's an MSAA surface. But in gallium nr_samples=1 is a
non-MSAA surface.
Before, if the user called glRenderbufferStorageMultisample() or
glTexImage2DMult
On Thu, Aug 3, 2017 at 10:22 AM, Jordan Justen
wrote:
> subect: form => from
>
> Commit message? Why is this being removed?
>
See below...
> On 2017-08-02 13:35:29, Jason Ekstrand wrote:
> > ---
> > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 ++-
> > 1 file changed, 2 insertio
On Fri, 2017-04-28 at 14:15 +0200, Nicolai Hähnle wrote:
> On 28.04.2017 13:08, Eric Engestrom wrote:
> > Hi,
> >
> > I'm currently running llvm r299777 but I have no idea when this was
> > changed.
>
> Yeah, you'll just have to upgrade LLVM (or downgrade to LLVM 4.0).
> This
> sort of thing unf
https://bugs.freedesktop.org/show_bug.cgi?id=102030
Janpieter Sollie changed:
What|Removed |Added
CC||janpieter.sol...@dommel.be
--
You a
1 - 100 of 172 matches
Mail list logo
