Re: [Mesa-dev] [PATCH v3 4/8] anv: Implement support for exporting semaphores as FENCE_FD

2017-08-13 Thread Lionel Landwerlin
On 04/08/17 18:24, Jason Ekstrand wrote: --- src/intel/vulkan/anv_batch_chain.c | 57 +-- src/intel/vulkan/anv_device.c | 1 + src/intel/vulkan/anv_gem.c | 36 src/intel/vulkan/anv_private.h | 23 + src/intel/vul

Re: [Mesa-dev] [PATCH v3 2/8] anv: Submit a dummy batch when only semaphores are provided.

2017-08-13 Thread Lionel Landwerlin
On 04/08/17 18:24, Jason Ekstrand wrote: Vulkan allows you to do a submit whose only job is to wait on and trigger semaphores. The easiest way for us to support that right now is to insert a dummy execbuf. --- src/intel/vulkan/anv_batch_chain.c | 28 +--- src/intel/vul

Re: [Mesa-dev] [PATCH v3 0/8] anv: Implement VK_KHR_external_semaphore

2017-08-13 Thread Lionel Landwerlin
This series is : Reviewed-by: Lionel Landwerlin I have a couple of nits, feel free to ignore. Thanks! On 04/08/17 18:24, Jason Ekstrand wrote: This series is a quick re-spin of the v2 sent yesterday to address review feedback from Chris. In particular, we now set EXEC_ASYNC on the trivial b

Re: [Mesa-dev] [PATCH v2 2/4] st/omx_tizonia: Add --enable-omx-tizonia flag and build files

2017-08-13 Thread Gurkirpal Singh
On Sun, Aug 13, 2017 at 8:47 AM, Leo Liu wrote: > Where is the patch 1? Sorry for the patches got messed up somehow while sending, I could only see two patches on mail-archive but three on patchwork. Tried two times and same result. About the first one I got a mail saying that it was too large h

[Mesa-dev] [PATCH] radeonsi: disable CE by default

2017-08-13 Thread Marek Olšák
From: Marek Olšák It makes performance worse by a very small (hard to measure) amount. We've done extensive profiling of this feature internally. Cc: 17.1 17.2 --- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 4 ++-- src/gallium/drivers

Re: [Mesa-dev] [PATCH] radeonsi: disable CE by default

2017-08-13 Thread Christian König
Acked-by: Christian König Am 13.08.2017 um 19:50 schrieb Bas Nieuwenhuizen: Reviewed-by: Bas Nieuwenhuizen On Sun, Aug 13, 2017, at 19:27, Marek Olšák wrote: From: Marek Olšák It makes performance worse by a very small (hard to measure) amount. We've done extensive profiling of this featur

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix CTS regression caused by fcbb93e86024

2017-08-13 Thread Timothy Arceri
On 12/08/17 06:32, Emil Velikov wrote: On 1 August 2017 at 08:35, Timothy Arceri wrote: When generation the storage offset for struct members we need to skip opaque types as they no longer have backing storage. Fixes: fcbb93e86024 ("mesa: stop assigning unused storage for non-bindless opaque

[Mesa-dev] [PATCH 4/8] glsl: add has_uniform_storage() helper to shader cache

2017-08-13 Thread Timothy Arceri
--- src/compiler/glsl/shader_cache.cpp | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 6c878dae37..2fbab86d30 100644 --- a/src/compiler/glsl/shader_cache.cpp +++ b/src/compiler/g

[Mesa-dev] [PATCH 3/8] glsl: stop adding pointers from glsl_struct_field to the cache

2017-08-13 Thread Timothy Arceri
This is so we always create reproducible cache entries. Consistency is required for verification of any third party distributed shaders. --- src/compiler/glsl/shader_cache.cpp | 45 -- 1 file changed, 38 insertions(+), 7 deletions(-) diff --git a/src/compiler/g

[Mesa-dev] [PATCH 6/8] glsl: always write a name/label string to the cache

2017-08-13 Thread Timothy Arceri
In the following patch we will stop writing the pointer to cache. Unfortunately adding empty strings to that cache seems to be the only thing we can do here once we no longer have the pointers. --- src/compiler/glsl/shader_cache.cpp | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-

[Mesa-dev] [PATCH 8/8] glsl: stop adding pointers from bindless structs to the cache

2017-08-13 Thread Timothy Arceri
This is so we always create reproducible cache entries. Consistency is required for verification of any third party distributed shaders. --- src/compiler/glsl/shader_cache.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src

[Mesa-dev] [PATCH 2/8] glsl: stop adding pointers from gl_shader_variable to the cache

2017-08-13 Thread Timothy Arceri
This is so we always create reproducible cache entries. Consistency is required for verification of any third party distributed shaders. --- src/compiler/glsl/shader_cache.cpp | 40 ++ 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/src/compiler/

Re: [Mesa-dev] [PATCH 2/2] mesa/st: add support for hw atomics (v2)

2017-08-13 Thread Dave Airlie
On 9 August 2017 at 21:44, Nicolai Hähnle wrote: > Hi Dave, > > Thanks for the update, I prefer this. > > Have you considered Marek's query about pipeline-wide atomic buffers? > > The issue I'm thinking about is what happens when multiple shaders access > the same atomic counter. In a GDS/GWS-base

[Mesa-dev] [PATCH] [rfc] ac/surface: always increase dcc size alignment.

2017-08-13 Thread Dave Airlie
From: Dave Airlie So with tile swizzle, and dcc enabled, the vrdashboard GL app generates a bunch of VM faults, this fixes it, however it now sometimes generates garbage, but I'm just sending this out to have some place to start. (it could be a tile swizzle import/export issue still). Signed-of