This seems reasonable, thanks for fixing. Maybe just add a comment in
the code also.
/* 12 * 4 == (max # of FS outputs) * max components */
Or something similar.
Reviewed-by: Timothy Arceri
On 18/09/17 19:30, Nicolai Hähnle wrote:
From: Nicolai Hähnle
Having this separate just makes the code harder to follow, and
requires an extra walk of the IR.
---
src/compiler/Makefile.sources| 1 -
src/compiler/glsl/glsl_parser_extras.cpp | 1 -
src/compiler/glsl/loop_analysis.h| 16 -
src/compiler/glsl/loop_controls.cpp |
---
src/compiler/glsl/loop_analysis.cpp | 139
src/compiler/glsl/loop_analysis.h | 7 --
src/compiler/glsl/loop_controls.cpp | 139
3 files changed, 139 insertions(+), 146 deletions(-)
diff --git
On 2017年09月19日 05:44, Chad Versace wrote:
This implementation is correct (afaict), but takes two shortcuts
regarding the import/export of Android sync fds.
Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync
fd into a VkSemaphore or VkFence, the driver instead simply
Tested with AMD's Anvil OutOfOrderRasterization demo on a RX 560.
Signed-off-by: Nicholas Miell
---
src/amd/vulkan/radv_device.c | 17 +
src/amd/vulkan/radv_pipeline.c | 10 +-
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git
I may review some more tomorrow but I think I'm getting close to done. I
would not mind at all seeing a v2 at this point.
On September 15, 2017 9:11:51 AM Lionel Landwerlin
wrote:
Hi all,
This series implements KHR_sampler_ycbcr_conversion (and
On 19/09/17 10:12, Eric Anholt wrote:
Timothy Arceri writes:
The initial helpers as support for removing unused varyings between
stages.
---
src/compiler/Makefile.sources | 1 +
src/compiler/nir/nir.h | 6 ++
Timothy Arceri writes:
> The initial helpers as support for removing unused varyings between
> stages.
> ---
> src/compiler/Makefile.sources | 1 +
> src/compiler/nir/nir.h | 6 ++
> src/compiler/nir/nir_linking_helpers.c | 136
>
On Monday, September 11, 2017 8:51:54 AM PDT Jason Ekstrand wrote:
> Vulkan needs to be able to clear any texture you can create. We want to
> add support for VK_FORMAT_R8_SRGB and we need to use L8_UNORM_SRGB to do
> that so we need to be able to clear it.
> ---
> src/intel/blorp/blorp_clear.c
On gen7-8 where we use CCS_D, we were setting AUX_STATE_AUX_INVALID
because that's the obvious aux state when there is no modifier.
However, this doesn't work because that aux state isn't compatible with
CCS_D.
Cc: Chad Versace
---
src/intel/isl/isl.h
This implementation is correct (afaict), but takes two shortcuts
regarding the import/export of Android sync fds.
Shortcut 1. When Android calls vkAcquireImageANDROID to import a sync
fd into a VkSemaphore or VkFence, the driver instead simply blocks on
the sync fd, then puts the
On Fri 15 Sep 2017, Tapani Pälli wrote:
>
>
> On 09/15/2017 01:06 AM, Chad Versace wrote:
> > v3:
> >- Delete duplicate #include "anv_private.h". [per Tapani]
> >- Try to fix the Android-IA build in Android.vulkan.mk by following
> > Tapani's example in
> >
> >
On Fri 15 Sep 2017, zhoucm1 wrote:
>
>
> On 2017年09月14日 07:03, Chad Versace wrote:
> > From: Chad Versace
> >
> > This implementation is correct (afaict), but takes two shortcuts
> > regarding the import/export of Android sync fds.
> >
> >Shortcut 1. When Android
On Fri, Sep 15, 2017 at 3:54 PM, Jason Ekstrand
wrote:
>
> On Fri, Sep 15, 2017 at 7:11 AM, Lionel Landwerlin <
> lionel.g.landwer...@intel.com> wrote:
>
>> Signed-off-by: Lionel Landwerlin
>> ---
>> src/intel/vulkan/anv_descriptor_set.c
On Monday, September 18, 2017 11:14:35 AM PDT Chris Wilson wrote:
> Quoting Kenneth Graunke (2017-09-18 18:56:57)
> > brw_finish_batch emits commands needed at the end of every batch buffer,
> > including any workarounds. In the past, we freed up some "reserved"
> > batch space before calling it,
On 09/18/2017 12:43 PM, Eric Anholt wrote:
Thomas Hellstrom writes:
When an application decides to read from the front buffer of a window,
typically a fake front is created and initialized with the real front window
contents. However, if there was a window manager
On 09/18/2017 01:10 PM, Thomas Hellstrom wrote:
On 09/18/2017 12:43 PM, Eric Anholt wrote:
Thomas Hellstrom writes:
When an application decides to read from the front buffer of a window,
typically a fake front is created and initialized with the real
front window
On Monday, September 18, 2017 11:03:37 AM PDT Chris Wilson wrote:
> Quoting Kenneth Graunke (2017-09-18 18:56:56)
> > This is, by definition, finishing the batch.
> > ---
> > src/mesa/drivers/dri/i965/intel_batchbuffer.c | 14 +++---
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
Oh, also, these should get a Cc: mesa-stable tag.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, Sep 18, 2017 at 12:28 PM, Grazvydas Ignotas wrote:
> On some platforms, gcc generates library calls when __atomic_* functions
> are used, but does not link the required library automatically. Detect
> this and add the library when needed.
>
> This change was tested on
Hi.
On 09/18/2017 12:18 PM, Keith Packard wrote:
Thomas Hellstrom writes:
When an application decides to read from the front buffer of a window,
typically a fake front is created and initialized with the real front window
contents. However, if there was a window
It wasn't copy-paste, it was "cp".
Marek
On Mon, Sep 18, 2017 at 9:42 PM, Grazvydas Ignotas wrote:
> Has anyone ran full piglit on these with r600? Copy-paste bugs are
> very easy to introduce.
>
> Gražvydas
>
> On Mon, Sep 18, 2017 at 7:32 PM, Marek Olšák
Thomas Hellstrom writes:
> When an application decides to read from the front buffer of a window,
> typically a fake front is created and initialized with the real front window
> contents. However, if there was a window manager reparenting operation between
> the last
Has anyone ran full piglit on these with r600? Copy-paste bugs are
very easy to introduce.
Gražvydas
On Mon, Sep 18, 2017 at 7:32 PM, Marek Olšák wrote:
> Latest version with an updated commit message:
>
They are now provided by -latomic, which should be linked as needed
since previous commit.
Signed-off-by: Grazvydas Ignotas
---
src/util/u_atomic.c | 12
1 file changed, 12 deletions(-)
diff --git a/src/util/u_atomic.c b/src/util/u_atomic.c
index
On some platforms, gcc generates library calls when __atomic_* functions
are used, but does not link the required library automatically. Detect
this and add the library when needed.
This change was tested on armel (library was added) and on x86_64 (was
not, as expected).
Fixes: 8915f0c0 "util:
On Sun, Sep 17, 2017 at 3:31 AM, Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> On 15/09/17 23:36, Jason Ekstrand wrote:
>
> struct anv_format_plane {
>> enum isl_format isl_format:16;
>> struct isl_swizzle swizzle;
>> +
>> + /* Whether this plane contains chroma channels
Thomas Hellstrom writes:
> When an application decides to read from the front buffer of a window,
> typically a fake front is created and initialized with the real front window
> contents. However, if there was a window manager reparenting operation between
> the last
On Mon, Sep 18, 2017 at 10:12 AM, Eric Anholt wrote:
> Jason Ekstrand writes:
>
> > On Mon, Sep 18, 2017 at 9:20 AM, Chad Versace
> > wrote:
> >
> >> On Thu 14 Sep 2017, Eric Anholt wrote:
> >> > Jason Ekstrand
On Fri, Sep 15, 2017 at 7:11 AM, Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> A given Vulkan format can now be decomposed into a set of planes. We
> now use 'struct anv_format_plane' to represent the format of those
> planes.
>
> Signed-off-by: Lionel Landwerlin
Both patches are:
Reviewed-by: Samuel Pitoiset
On 09/18/2017 07:15 PM, Eric Engestrom wrote:
Signed-off-by: Eric Engestrom
---
src/amd/vulkan/radv_wsi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
On Mon, 2017-09-18 at 17:00 +0100, Emil Velikov wrote:
> Hi all,
>
> As you may know, different components in Mesa use LLVM for various purposes.
>
> In particular:
> - 3.3.0 for the aux gallium module, gallivm
> - 3.6.0 for the opencl state-tracker, clover
> - 3.9.0 for multiple drivers
On Mon, 2017-09-18 at 16:46 +0100, Eric Engestrom wrote:
> On Monday, 2017-09-18 11:10:37 -0400, Jan Vesely wrote:
> > On Mon, 2017-09-18 at 11:13 +0100, Eric Engestrom wrote:
> > > On Sunday, 2017-09-17 02:02:33 -0400, Jan Vesely wrote:
> > > > v2: Use direct llvm repo link instead of alias
> > >
Am Montag, den 18.09.2017, 16:07 +0100 schrieb Emil Velikov:
> Hi Gert,
>
> On 17 September 2017 at 08:32, Gert Wollny
> wrote:
> > The tests in mesa/st/tests require C++11. Check whether the
> > compiler
> > supports the -std=c++11 flag and if so, enable the tests.
Quoting Kenneth Graunke (2017-09-18 18:56:57)
> brw_finish_batch emits commands needed at the end of every batch buffer,
> including any workarounds. In the past, we freed up some "reserved"
> batch space before calling it, so we would never have to flush during
> it. This was error prone and
Quoting Kenneth Graunke (2017-09-18 18:56:56)
> This is, by definition, finishing the batch.
> ---
> src/mesa/drivers/dri/i965/intel_batchbuffer.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
>
This is, by definition, finishing the batch.
---
src/mesa/drivers/dri/i965/intel_batchbuffer.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
index
brw_finish_batch emits commands needed at the end of every batch buffer,
including any workarounds. In the past, we freed up some "reserved"
batch space before calling it, so we would never have to flush during
it. This was error prone and easy to screw up, so I deleted it a while
back in favor
Am 18.09.2017 um 19:11 schrieb Roland Scheidegger:
> Am 18.09.2017 um 17:36 schrieb Nicolai Hähnle:
>> On 18.09.2017 17:02, Roland Scheidegger wrote:
>>> This looks like a horrendous solution which will break the world - well
>>> for us :-). Because integers simply will cease to work, always
Signed-off-by: Eric Engestrom
---
src/amd/vulkan/radv_wsi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/amd/vulkan/radv_wsi.c b/src/amd/vulkan/radv_wsi.c
index 8a551c48bb..c9d4bbce8b 100644
--- a/src/amd/vulkan/radv_wsi.c
+++
Suggested-by: Nicolai Hähnle
Signed-off-by: Eric Engestrom
---
src/compiler/glsl/ir_validate.cpp | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/compiler/glsl/ir_validate.cpp
b/src/compiler/glsl/ir_validate.cpp
index
Jason Ekstrand writes:
> On Mon, Sep 18, 2017 at 9:20 AM, Chad Versace
> wrote:
>
>> On Thu 14 Sep 2017, Eric Anholt wrote:
>> > Jason Ekstrand writes:
>> >
>> > > The setTexBuffer2 hook from GLX is used to implement
Am 18.09.2017 um 17:36 schrieb Nicolai Hähnle:
> On 18.09.2017 17:02, Roland Scheidegger wrote:
>> This looks like a horrendous solution which will break the world - well
>> for us :-). Because integers simply will cease to work, always flushed
>> to zero (bye bye loop counter...).
>> The reason
On Mon, Sep 18, 2017 at 9:20 AM, Chad Versace
wrote:
> On Thu 14 Sep 2017, Eric Anholt wrote:
> > Jason Ekstrand writes:
> >
> > > The setTexBuffer2 hook from GLX is used to implement glxBindTexImageEXT
> > > which has tighter restrictions than
Reviewed-by: Marek Olšák
Marek
On Mon, Sep 18, 2017 at 5:21 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> If we don't have a depth piece, we don't get a correct
> swizzle mode and we hit an assert in addrlib.
>
> In case of no depth
I commented on patch 1. Other than that, the series is:
Reviewed-by: Marek Olšák
Marek
On Mon, Sep 18, 2017 at 4:57 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> This fixes a bug with nearest ("point") mip selection
On Mon, Sep 18, 2017 at 4:57 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> Like for cube map (array) gather, we need to round to nearest on <= VI.
>
> Fixes tests in dEQP-GLES3.functional.shaders.texture_functions.texture.*
>
> Cc:
Latest version with an updated commit message:
https://cgit.freedesktop.org/~mareko/mesa/commit/?h=master=8671613ed19586ac1eceda48eb067a416f9c93be
Marek
On Mon, Sep 18, 2017 at 6:18 PM, Emil Velikov wrote:
> On 18 September 2017 at 17:08, Marek Olšák
On Thu 14 Sep 2017, Eric Anholt wrote:
> Jason Ekstrand writes:
>
> > The setTexBuffer2 hook from GLX is used to implement glxBindTexImageEXT
> > which has tighter restrictions than just "it's shared". In particular,
> > it says that any rendering to the image while it is
On 18 September 2017 at 17:08, Marek Olšák wrote:
> On Thu, Sep 14, 2017 at 4:52 PM, Nicolai Hähnle wrote:
>> On 14.09.2017 16:19, Emil Velikov wrote:
>>>
>>> Hi Marek,
>>>
>>> On 14 September 2017 at 14:06, Marek Olšák wrote:
On Thu, Sep 14, 2017 at 4:52 PM, Nicolai Hähnle wrote:
> On 14.09.2017 16:19, Emil Velikov wrote:
>>
>> Hi Marek,
>>
>> On 14 September 2017 at 14:06, Marek Olšák wrote:
>>>
>>> From: Marek Olšák
>>>
>>> This marks the end of code
On 18.09.2017 15:27, Benedikt Schemmer wrote:
There is a small typo that prevents compilation.
Please kindly review and push.
Cheers,
Benedikt
Signed-off-by: Benedikt Schemmer
Ilia pointed this out to me, but I dropped it (I think because the mail
didn't go to the mailing
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_buffer_common.c | 13 -
src/gallium/drivers/radeon/r600_texture.c | 4
2 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c
Hi Jan,
On 17 September 2017 at 03:05, Jan Vesely wrote:
> Disable for now, travis does not allow llvm-3.7 trusty toolchain
>
I've just fired up a thread about bumping the Clover requirement to 3.9.
The reason why I brought it up is that all modern platforms actually
On Tue 12 Sep 2017, Jason Ekstrand wrote:
> When we get a miptree in through glxBindImageEXT, we don't know the
> current aux state so we have to assume the worst-case. If the image
> gets recreated, everything is fine because miptreecreate_for_dri_image
> sets it to the default. However, if our
On Tue 12 Sep 2017, Jason Ekstrand wrote:
> The old code made a new miptree that referenced the same BO as the
> renderbuffer and just trusted in the memory aliasing to work. There are
> only two ways in which the new miptree is liable to differ from the one
> in the renderbuffer and neither of
Hi all,
As you may know, different components in Mesa use LLVM for various purposes.
In particular:
- 3.3.0 for the aux gallium module, gallivm
- 3.6.0 for the opencl state-tracker, clover
- 3.9.0 for multiple drivers r600, radeonsi, radv and swr
AFAICT gallivm is build on Windows, and using
In GLSL ES 3.10 session 4.9 [Memory Access Qualifiers], it has the following
description:
"A variable could be qualified as both readonly and writeonly, disallowing both
read and write, but still be passed to
imageSize() to have the size queried.".
This is for image variable, but not for
On Mon, 2017-09-18 at 10:50 +0200, Samuel Pitoiset wrote:
>
> On 09/15/2017 04:56 PM, Juan A. Suarez Romero wrote:
> > On Fri, 2017-09-15 at 13:04 +0200, Juan A. Suarez Romero wrote:
> > > On Fri, 2017-09-15 at 12:47 +0200, Samuel Pitoiset wrote:
> > > > I guess this will break some piglits.
> >
On Monday, 2017-09-18 11:10:37 -0400, Jan Vesely wrote:
> On Mon, 2017-09-18 at 11:13 +0100, Eric Engestrom wrote:
> > On Sunday, 2017-09-17 02:02:33 -0400, Jan Vesely wrote:
> > > v2: Use direct llvm repo link instead of alias
> > > Enable
> > >
> > > Signed-off-by: Jan Vesely
On 18/09/17 03:53, srol...@vmware.com wrote:
From: Roland Scheidegger
This uses all the existing code to calculate lod values for mip linear
filtering. Though we'll have to disable the simplifications (if we know some
parts of the lod calculation won't actually matter for
On 18.09.2017 17:22, Jan Vesely wrote:
On Wed, 2017-09-13 at 18:53 +0200, Nicolai Hähnle wrote:
From: Nicolai Hähnle
To be able to properly distinguish between GL_ANY_SAMPLES_PASSED
and GL_ANY_SAMPLES_PASSED_CONSERVATIVE.
This patch goes through all drivers, having
Jan Vesely writes:
> Fixes build issues with llvm-3.6
> Fixes: 3115687f9b9830417c408228db2bc679e346bba6 (clover: Fix build after
> LLVM r313390)
>
> Signed-off-by: Jan Vesely
Reviewed-by: Francisco Jerez
> ---
>
On Tue 12 Sep 2017, Jason Ekstrand wrote:
> ---
> src/intel/isl/isl.h | 20
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +--
> 2 files changed, 21 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
>
On 18.09.2017 17:02, Roland Scheidegger wrote:
This looks like a horrendous solution which will break the world - well
for us :-). Because integers simply will cease to work, always flushed
to zero (bye bye loop counter...).
The reason is that when you translate from something with a untyped
On Saturday, 2017-09-16 22:05:39 -0400, Jan Vesely wrote:
> Fixes build issues with llvm-3.6
> Fixes: 3115687f9b9830417c408228db2bc679e346bba6 (clover: Fix build after
> LLVM r313390)
>
> Signed-off-by: Jan Vesely
R-b and pushed this with Gert's t-b, without waiting any
On Wed, 2017-09-13 at 18:53 +0200, Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> To be able to properly distinguish between GL_ANY_SAMPLES_PASSED
> and GL_ANY_SAMPLES_PASSED_CONSERVATIVE.
>
> This patch goes through all drivers, having them treat the two
> query
On Mon, 2017-09-18 at 11:13 +0100, Eric Engestrom wrote:
> On Sunday, 2017-09-17 02:02:33 -0400, Jan Vesely wrote:
> > v2: Use direct llvm repo link instead of alias
> > Enable
> >
> > Signed-off-by: Jan Vesely
> > ---
> > .travis.yml | 40
Hi Gert,
On 17 September 2017 at 08:32, Gert Wollny wrote:
> The tests in mesa/st/tests require C++11. Check whether the compiler
> supports the -std=c++11 flag and if so, enable the tests. Otherwise
> skip compiling and running the tests altogether.
>
> Fixes: 7be6d8fe12
This looks like a horrendous solution which will break the world - well
for us :-). Because integers simply will cease to work, always flushed
to zero (bye bye loop counter...).
The reason is that when you translate from something with a untyped
register file to something typed, the obvious
On 18 September 2017 at 15:42, Marathe, Yogesh wrote:
> Hi Emil, as discussed, we are leaving this at 3/3 split you've created.
>
> I've marked my earlier series "Not Applicable" in patchwork. Thanks.
>
Right, thanks. I'll push the series in an hour or so... with a
There is a small typo that prevents compilation.
Please kindly review and push.
Cheers,
Benedikt
Signed-off-by: Benedikt Schemmer
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c
b/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c
---
No, this is all I had.
Tables of tables formats are just in anv :
https://github.com/djdeath/mesa/commit/b40dd5245cdaa5d686b8494f0e8c784b2eea4211#diff-8d7721e9d80d390ff503d2c3b4e1adc5L274
On 18/09/17 15:48, Jason Ekstrand wrote:
Did you have a patch to the enum generator to actually generate
From: Nicolai Hähnle
Like for cube map (array) gather, we need to round to nearest on <= VI.
Fixes tests in dEQP-GLES3.functional.shaders.texture_functions.texture.*
Cc: mesa-sta...@lists.freedesktop.org
---
src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 12
From: Nicolai Hähnle
This fixes a bug with nearest ("point") mip selection when the fractional
part of max_lod is in (0.5,1). In this case, the spec mandates that
we still select the mip level ceil(max_lod) in the clamping case. However,
MIP_POINT_PRECLAMP will clamp
Did you have a patch to the enum generator to actually generate the table
of tables for the formats? I don't see that in ithe series.
On Mon, Sep 18, 2017 at 7:46 AM, Jason Ekstrand
wrote:
> On Fri, Sep 15, 2017 at 7:10 AM, Lionel Landwerlin <
>
On Fri, Sep 15, 2017 at 7:10 AM, Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> New extensions can introduce additional enums. Most of the new enums
> will have disjoint numbers from the initial enums. For example new
> formats introduced by VK_IMG_format_pvrtc :
>
>
Hi Emil, as discussed, we are leaving this at 3/3 split you've created.
I've marked my earlier series "Not Applicable" in patchwork. Thanks.
-Yogesh.
>-Original Message-
>From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of
>Emil Velikov
>Sent: Friday, September
Wrong commit, correct one is:
gallium: add PIPE_QUERY_OCCLUSION_PREDICATE_CONSERVATIVE
Am 18.09.2017 um 15:27 schrieb Benedikt Schemmer:
> There is a small typo that prevents compilation.
> Please kindly review and push.
> Cheers,
> Benedikt
>
> Signed-off-by: Benedikt Schemmer
>
There is a small typo that prevents compilation.
Please kindly review and push.
Cheers,
Benedikt
Signed-off-by: Benedikt Schemmer
---
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c
b/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw.c
---
On 18 September 2017 at 11:48, Eric Engestrom wrote:
> On Monday, 2017-09-18 11:29:21 +0100, Emil Velikov wrote:
>> From: Bernhard Rosenkraenzer
>>
>> The current convinince function GetEnv feeds the results of getenv
>> directly into std::string().
On 18/09/17 20:50, Nicolai Hähnle wrote:
On 14.09.2017 06:47, Timothy Arceri wrote:
The old code incorrectly assumed that loop terminators will always
be at the start of the loop. It really seems to be just luck that
we haven't triggered any bugs here, for example if there is a loop
Le lundi 18 septembre 2017, 12:48:45 CEST Eric Engestrom a écrit :
> On Monday, 2017-09-18 11:29:21 +0100, Emil Velikov wrote:
> > From: Bernhard Rosenkraenzer
> >
> > The current convinince function GetEnv feeds the results of getenv
> > directly into std::string(). That is a
On Sunday, 2017-09-17 02:02:33 -0400, Jan Vesely wrote:
> v2: Use direct llvm repo link instead of alias
> Enable
>
> Signed-off-by: Jan Vesely
> ---
> .travis.yml | 40
> 1 file changed, 40 insertions(+)
>
> diff --git
On 15.09.2017 21:46, Bas Nieuwenhuizen wrote:
Only on GFX9 we implement them as 2D images.
This fixes:
dEQP-VK.image.image_size.1d_array.readonly_12x34
dEQP-VK.image.image_size.1d_array.readonly_1x1
dEQP-VK.image.image_size.1d_array.readonly_32x32
dEQP-VK.image.image_size.1d_array.readonly_7x1
On 14.09.2017 06:47, Timothy Arceri wrote:
The old code incorrectly assumed that loop terminators will always
be at the start of the loop. It really seems to be just luck that
we haven't triggered any bugs here, for example if there is a loop
terminator at the start of the loop we might actually
On 18/09/17 20:09, Nicolai Hähnle wrote:
On 14.09.2017 06:47, Timothy Arceri wrote:
These instruction will be executed on every iteration of the loop
we cannot drop them.
---
src/compiler/glsl/loop_analysis.h | 7 +++
src/compiler/glsl/loop_controls.cpp | 15 +++
On Monday, 2017-09-18 11:29:21 +0100, Emil Velikov wrote:
> From: Bernhard Rosenkraenzer
>
> The current convinince function GetEnv feeds the results of getenv
> directly into std::string(). That is a bad idea, since the variable
> may be unset, thus we feed NULL into the C++
On Monday, 2017-09-18 11:10:39 +0200, Laurent Carlier wrote:
> Return an empty string instead of a NULL pointer.
> Patch from Bernhard Rosenkraenzer.
I guess attributing the patch to him in git would be nice too:
From: Bernhard Rosenkraenzer
>
>
From: Bernhard Rosenkraenzer
The current convinince function GetEnv feeds the results of getenv
directly into std::string(). That is a bad idea, since the variable
may be unset, thus we feed NULL into the C++ construct.
The latter of which is not allowed and leads to a crash.
On 14.09.2017 06:47, Timothy Arceri wrote:
do-while loops can increment the starting value before the
condition is checked. e.g.
do {
ndx++;
} while (ndx < 3);
This commit changes the code to detect this and reduces the
iteration count by 1 if found.
With Eric's remark fixes, this
For the series:
Reviewed-by: Juan A. Suarez Romero
On Fri, 2017-09-15 at 10:17 -0700, Kenneth Graunke wrote:
> If transform feedback is recording a varying, it needs a slot in the
> VUE map, regardless of whether or not the shader writes it.
>
> Together with the previous
On 14.09.2017 06:47, Timothy Arceri wrote:
These instruction will be executed on every iteration of the loop
*instructions
Als, the title of the patch is missing an s ;)
Cheers,
Nicolai
we cannot drop them.
---
src/compiler/glsl/loop_analysis.h | 7 +++
On Wed, 2017-09-06 at 10:32 +1000, Timothy Arceri wrote:
>
> On 01/09/17 21:15, Juan A. Suarez Romero wrote:
> > On Thu, 2017-06-29 at 14:43 +1000, Timothy Arceri wrote:
> > > On 27/06/17 21:20, Juan A. Suarez Romero wrote:
> > > > On Tue, 2017-06-27 at 09:29 +1000, Timothy Arceri wrote:
> > > >
On 14.09.2017 06:47, Timothy Arceri wrote:
These instruction will be executed on every iteration of the loop
we cannot drop them.
---
src/compiler/glsl/loop_analysis.h | 7 +++
src/compiler/glsl/loop_controls.cpp | 15 +++
src/compiler/glsl/loop_unroll.cpp | 7 ---
Both patches:
Reviewed-by: Nicolai Hähnle
On 14.09.2017 19:40, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_texture.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
On 09/15/2017 05:40 PM, Fredrik Höglund wrote:
On Thursday 14 September 2017, Samuel Pitoiset wrote:
On 09/13/2017 06:34 PM, Fredrik Höglund wrote:
On Wednesday 13 September 2017, Samuel Pitoiset wrote:
When binding a new pipeline, we applied all dynamic states
without checking if they
The Vulkan spec (1.0.61) says:
"The number of scissors used by a pipeline is still specified
by the scissorCount member of VkPipelinescissorStateCreateInfo."
So, the number of scissors is defined at pipeline creation
time and shouldn't be updated when they are set dynamically.
The Vulkan spec (1.0.61) says:
"The number of viewports used by a pipeline is still specified
by the viewportCount member of VkPipelineViewportStateCreateInfo."
So, the number of viewports is defined at pipeline creation
time and shouldn't be updated when they are set dynamically.
To check some valid usage requirements.
Signed-off-by: Samuel Pitoiset
---
src/amd/vulkan/radv_cmd_buffer.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index
1 - 100 of 112 matches
Mail list logo