Re: [Mesa-dev] [PATCH] Revert "Revert "radv: fallback to an in-memory cache when no pipline cache is provided""

On 25/09/17 14:43, Bas Nieuwenhuizen wrote: I tested this 10 times with ./deqp-vk --deqp-case=dEQP-VK.texture.filtering.3d.formats.r4g4b4a4* and one full run of CTS, seems the issue is gone. Also reduces CTS runtime by 30% or so. Nice :) For what its worth: Reviewed-by: Timothy Arceri

Re: [Mesa-dev] [Mesa-stable] [PATCH] vulkan/wsi/wayland: Stop printing out the DRM device

Reviewed-by: Samuel Iglesias Gonsálvez On Friday, September 22, 2017 12:45:27 PM CEST Jason Ekstrand wrote: > Cc: mesa-sta...@lists.freedesktop.org > --- > src/vulkan/wsi/wsi_common_wayland.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

[Mesa-dev] [PATCH] radv: Fix VK_KHR_image_format_list.

Spec adding corner cases ... Fixes: 969537d9358 "radv: Add support for more DCC compression with VK_KHR_image_format_list." --- src/amd/vulkan/radv_image.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index

[Mesa-dev] [PATCH] Revert "Revert "radv: fallback to an in-memory cache when no pipline cache is provided""

I tested this 10 times with ./deqp-vk --deqp-case=dEQP-VK.texture.filtering.3d.formats.r4g4b4a4* and one full run of CTS, seems the issue is gone. Also reduces CTS runtime by 30% or so. --- src/amd/vulkan/radv_pipeline.c | 13 - src/amd/vulkan/radv_pipeline_cache.c | 7

Re: [Mesa-dev] [PATCH 3/8] nir: add a helper for getting the bitmask for a variable's location

On 23/09/17 04:33, Kenneth Graunke wrote: On Tuesday, September 12, 2017 4:37:30 PM PDT Timothy Arceri wrote: --- src/compiler/nir/nir.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index

Re: [Mesa-dev] [PATCH 1/3] i965/vec4: Actually handle atomic op intrinsics.

This is all a bit embarrassing... Can't review yet because I'm not at my computer. On September 24, 2017 5:10:31 PM Kenneth Graunke wrote: Embarassingly, someone enabled the ARB_shader_atomic_counter_ops extension for Gen7+ but never added the intrinsics to the switch

[Mesa-dev] [PATCH 2/3] i965/vec4: Fix swizzles on atomic sources.

Atomic operation sources are scalar values, but we were failing to select the .x component of the second operand. For example, atomicCounterCompSwapARB(counter, 5u, 10u) would generate mov(8) vgrf4.x:D, 5D mov(8) vgrf5.x:D, 10D mov(8) vgrf9.x:UD, vgrf4.xyzw:D mov(8) vgrf9.y:UD,

[Mesa-dev] [PATCH 1/3] i965/vec4: Actually handle atomic op intrinsics.

Embarassingly, someone enabled the ARB_shader_atomic_counter_ops extension for Gen7+ but never added the intrinsics to the switch statement in the vec4 backend, so they just hit an unreachable() call and died. Fixes: 40dd45d0c6aa4a9d (i965: Enable ARB_shader_atomic_counter_ops) Cc: "17.2 17.1

[Mesa-dev] [PATCH 3/3] i965: Support copy propagating of untyped atomic surface indexes.

In the vec4 backend, SHADER_OPCODE_UNTYPED_ATOMIC's src[1] is the surface index. We want to copy propagate so we can use an immediate message descriptor, rather than an indirect send. --- src/intel/compiler/brw_vec4_copy_propagation.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 4/4] i965: Drop the batch and limp along if execbuf fails.

I've got this a few times recently and it's really annoying. I don't know if this will fix anything or not but it may be worth a go. I fear, however, that ignoring an execbuf failure will lead to permanently corrupted rendering or even additional hangs due to a chunk of the stream being

[Mesa-dev] [Bug 102964] [amdgpu][tahiti xt] dota2-vulkan tournament drafting phase has no skys

https://bugs.freedesktop.org/show_bug.cgi?id=102964 --- Comment #1 from Bas Nieuwenhuizen --- Do you have images of intended ad actual skies? (i.e. vulkan vs. GL or such?) -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

[Mesa-dev] [Bug 102964] [amdgpu][tahiti xt] dota2-vulkan tournament drafting phase has no skys

https://bugs.freedesktop.org/show_bug.cgi?id=102964 Bug ID: 102964 Summary: [amdgpu][tahiti xt] dota2-vulkan tournament drafting phase has no skys Product: Mesa Version: git Hardware: x86-64 (AMD64) OS:

Re: [Mesa-dev] [PATCH 1/4] i965: Convert brw_bufmgr to use C11 mutexes instead of pthreads.

On Sunday, September 24, 2017 7:36:17 AM PDT Jason Ekstrand wrote: > On September 24, 2017 01:02:21 Kenneth Graunke wrote: > > There's no real advantage or disadvantage here, it's just for stylistic > > consistency with the rest of the codebase. > > Didn't Kristian do a

Re: [Mesa-dev] [PATCH 1/4] i965: Convert brw_bufmgr to use C11 mutexes instead of pthreads.

On September 24, 2017 01:02:21 Kenneth Graunke wrote: There's no real advantage or disadvantage here, it's just for stylistic consistency with the rest of the codebase. Didn't Kristian do a bunch of work done time ago to make mutexes faster by not using pthread on

[Mesa-dev] [Bug 101378] interpolateAtSample check for input parameter is too strict

https://bugs.freedesktop.org/show_bug.cgi?id=101378 --- Comment #5 from Nicolai Hähnle --- Thanks for the reminder. There were some related spec issues that we cleared up with the GL and ES working groups, but I have a set of patches that is almost ready to go in. -- You

[Mesa-dev] [Bug 101378] interpolateAtSample check for input parameter is too strict

https://bugs.freedesktop.org/show_bug.cgi?id=101378 Matias N. Goldberg changed: What|Removed |Added CC|

[Mesa-dev] [PATCH 1/4] i965: Convert brw_bufmgr to use C11 mutexes instead of pthreads.

There's no real advantage or disadvantage here, it's just for stylistic consistency with the rest of the codebase. --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 35 +- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git

[Mesa-dev] [PATCH 2/4] i965: Use atomic ops in get_new_program_id().

We have a nice utility function for this, which eliminates the need for locking stuff. This isn't really performance critical, but it's less code to use the atomic. p_atomic_inc_return does pre-increment rather than post-increment, so we change screen->program_id to be initialized to 0 instead

[Mesa-dev] [PATCH 3/4] i965: Rename do_flush_locked to submit_batch().

do_flush_locked isn't a great name - especially given that there's no locking going on in our code relating to execbuf. --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c

[Mesa-dev] [PATCH 4/4] i965: Drop the batch and limp along if execbuf fails.

The execbuf2 ioctl can fail for several reasons: - a catastrophic bug in Mesa (we're programming garbage commands) - repeated GPU hangs, where the kernel has stepped in and banned our process (or at least fd) from talking to the GPU anymore - some sort of transient failures (low memory, GPU