Re: [Mesa-dev] [PATCH] radv: Don't use vgpr indexing for outputs on GFX9.

2017-10-21 Thread Timothy Arceri
On 22/10/17 09:57, Bas Nieuwenhuizen wrote: Due to LLVM bugs. Fixes a bunch of dEQP-VK.glsl.indexing.* tests. --- src/amd/vulkan/radv_shader.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index e572f693203..07e68d6032b

[Mesa-dev] [PATCH] radv: Don't use vgpr indexing for outputs on GFX9.

2017-10-21 Thread Bas Nieuwenhuizen
Due to LLVM bugs. Fixes a bunch of dEQP-VK.glsl.indexing.* tests. --- src/amd/vulkan/radv_shader.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index e572f693203..07e68d6032b 100644 --- a/src/amd/vulkan/radv_shader.c +++

Re: [Mesa-dev] meson build for etnaviv and imx

2017-10-21 Thread Christian Gmeiner
Hi Dylan 2017-10-21 12:17 GMT+02:00 Christian Gmeiner : > 2017-10-21 1:04 GMT+02:00 Dylan Baker : >> This is all pretty straight-forward, it builds on my system, but I don't have >> any actual hardware to test on. >> >> Christian and/or Wladimir,

Re: [Mesa-dev] meson build for etnaviv and imx

2017-10-21 Thread Christian Gmeiner
Hi 2017-10-21 8:54 GMT+02:00 Wladimir J. van der Laan : > On Fri, Oct 20, 2017 at 04:04:09PM -0700, Dylan Baker wrote: >> This is all pretty straight-forward, it builds on my system, but I don't have >> any actual hardware to test on. >> >> Christian and/or Wladimir, could one

Re: [Mesa-dev] [PATCH 2/2] meson: build imx driver

2017-10-21 Thread Christian Gmeiner
2017-10-21 1:04 GMT+02:00 Dylan Baker : > This is build tested only. > > Signed-off-by: Dylan Baker Reviewed-by: Christian Gmeiner > --- > meson.build| 5 + > meson_options.txt

Re: [Mesa-dev] [PATCH 1/2] meson: build etnaviv driver + winsys

2017-10-21 Thread Christian Gmeiner
2017-10-21 1:04 GMT+02:00 Dylan Baker : > Build tested only. > > Signed-off-by: Dylan Baker Reviewed-by: Christian Gmeiner > --- > meson.build| 6 ++ > meson_options.txt

[Mesa-dev] [PATCH] ac/nir: Account for compact array index in GS input load from LDS.

2017-10-21 Thread Bas Nieuwenhuizen
Mirrors the vram path. Fixes: d4ecc3c9299 'ac/nir: Add loading from LDS for merged GS.' --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index ca856bb2f9e..83b49b535c6 100644

Re: [Mesa-dev] [PATCH] glsl: fix derived cs variables for variable group sizes

2017-10-21 Thread Ilia Mirkin
On Sat, Oct 21, 2017 at 3:18 PM, Ilia Mirkin wrote: > Both gl_GlobalInvocationID and gl_LocalInvocationIndex depend on the > gl_WorkGroupSize. However with variable group sizes, this value is not > available. Use the gl_LocalGroupSizeARB instead, which contains the >

[Mesa-dev] [PATCH] glsl: fix derived cs variables for variable group sizes

2017-10-21 Thread Ilia Mirkin
Both gl_GlobalInvocationID and gl_LocalInvocationIndex depend on the gl_WorkGroupSize. However with variable group sizes, this value is not available. Use the gl_LocalGroupSizeARB instead, which contains the relevant value. There should not be any situation where at least one of those is not

[Mesa-dev] [PATCH] radv: Don't compile shaders when they are cached already.

2017-10-21 Thread Bas Nieuwenhuizen
When the gs_copy_shader is NULL (due to an incomplete cache), but the main shaders are found, we still do the nir, but we shouldn't compile the shaders again. For merged shaders we should also account for the missing shaders. Fixes: ce03c119ce0 'radv: Add code to compile merged shaders.' ---

[Mesa-dev] [PATCH] radv: Don't check for max GL GS invocations.

2017-10-21 Thread Bas Nieuwenhuizen
We specify 127 instead of 32 as the limit in vulkan. Fixes: 6bc42855f92 'radv: enable GS on GFX9' --- src/amd/vulkan/radv_pipeline.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index eac4456a3fb..db550811eaf 100644 ---

Re: [Mesa-dev] [PATCH 3/3] radv: Don't explicitly reference vertex shader for draw_id.

2017-10-21 Thread Samuel Pitoiset
With my comment on patch 2 addressed, series is: Reviewed-by: Samuel Pitoiset Thanks for fixing this! On 10/21/2017 06:25 PM, Bas Nieuwenhuizen wrote: With merged shaders the vertex shader may not exist. This got in because the offending patch was written before

Re: [Mesa-dev] [PATCH 2/3] radv: Keep RADV_CMD_DIRTY_INDEX_BUFFER.

2017-10-21 Thread Samuel Pitoiset
On 10/21/2017 06:25 PM, Bas Nieuwenhuizen wrote: Otherwise for non-indexed draws we set and immediately unset it. Fixes: 341529dbee5 'radv: use optimal packet order for draws' --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 103388] Linking libcltgsi.la (llvm/codegen/libclllvm_la-common.lo) fails with "error: no match for 'operator-'" with GCC-7, Mesa from Git and current LLVM revisions

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103388 --- Comment #4 from Kai --- (In reply to Andy Furniss from comment #3) > Don't know why it would work with 4.8, but it's a known issue. Sorry, should have made that clear in my comment: I only tested the GCC from

[Mesa-dev] [PATCH 3/3] radv: Don't explicitly reference vertex shader for draw_id.

2017-10-21 Thread Bas Nieuwenhuizen
With merged shaders the vertex shader may not exist. This got in because the offending patch was written before merged shaders were upstream, but committed after. Fixes: 75dfab24a2c 'radv: refactor indirect draws with radv_draw_info' --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH 1/3] radv: Correctly detect changed shaders for vertex descriptors.

2017-10-21 Thread Bas Nieuwenhuizen
As they were emitted after the new pipeline, the changed pipeline detection was not working anymore. Fixes: 341529dbee5 'radv: use optimal packet order for draws' --- src/amd/vulkan/radv_cmd_buffer.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] radv: Keep RADV_CMD_DIRTY_INDEX_BUFFER.

2017-10-21 Thread Bas Nieuwenhuizen
Otherwise for non-indexed draws we set and immediately unset it. Fixes: 341529dbee5 'radv: use optimal packet order for draws' --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

[Mesa-dev] [Bug 103388] Linking libcltgsi.la (llvm/codegen/libclllvm_la-common.lo) fails with "error: no match for 'operator-'" with GCC-7, Mesa from Git and current LLVM revisions

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103388 --- Comment #3 from Andy Furniss --- Don't know why it would work with 4.8, but it's a known issue. You could remove --enable-opencl as a temp workaround or apply this patch until the alternate fix that's discussed goes

[Mesa-dev] [PATCH 0/3] OpenGL 3.1 with ARB_compatibility

2017-10-21 Thread Marek Olšák
Hi, This shouldn't be a surprise to some of you. Let's say this is a new trend in Mesa. OpenGL 3.1 with ARB_compatibility is tiny since most of the work was done a long time ago. This is not really a Compatibility profile because the first Compatibility profile starts at OpenGL 3.2, but it's

[Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-21 Thread Marek Olšák
From: Marek Olšák We already have piglit tests testing alpha, luminance, and intensity formats. They were skipped by piglit until now. Additionally, I'm enabling one ARB_texture_buffer_range piglit test to run with the compat profile. --- src/mapi/glapi/gen/apiexec.py

[Mesa-dev] [PATCH 1/3] mesa: return 0 for GL_INTERNALFORMAT_SUPPORTED for unsupported TBO formats

2017-10-21 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/formatquery.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index 77c7faa..05b7810 100644 --- a/src/mesa/main/formatquery.c +++ b/src/mesa/main/formatquery.c @@ -895,20

[Mesa-dev] [PATCH 3/3] mesa: final changes to expose OpenGL 3.1 with ARB_compatibility

2017-10-21 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/extensions_table.h | 1 + src/mesa/main/mtypes.h | 1 + src/mesa/main/version.c | 13 - 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/extensions_table.h

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 mirh changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 103388] Linking libcltgsi.la (llvm/codegen/libclllvm_la-common.lo) fails with "error: no match for 'operator-'" with GCC-7, Mesa from Git and current LLVM revisions

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103388 Kai changed: What|Removed |Added Keywords||regression

[Mesa-dev] [Bug 103388] Mesa git fails to build with recent llvm trunk & ggc-7

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103388 Kai changed: What|Removed |Added CC|

[Mesa-dev] [Bug 103388] Mesa git fails to build with recent llvm trunk & ggc-7

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103388 --- Comment #1 from network...@rkmail.ru --- My build options: ./configure --host=x86_64-suse-linux-gnu --build=x86_64-suse-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin

[Mesa-dev] [Bug 103388] Mesa git fails to build with recent llvm trunk & ggc-7

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103388 Bug ID: 103388 Summary: Mesa git fails to build with recent llvm trunk & ggc-7 Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] meson build for etnaviv and imx

2017-10-21 Thread Christian Gmeiner
2017-10-21 1:04 GMT+02:00 Dylan Baker : > This is all pretty straight-forward, it builds on my system, but I don't have > any actual hardware to test on. > > Christian and/or Wladimir, could one of you build this and do some kind of > testing to ensure it works? > Thanks for

Re: [Mesa-dev] [PATCH v3 05/43] nir: Populate conversion opcodes to/from 16-bit types

2017-10-21 Thread Pohjolainen, Topi
On Sat, Oct 21, 2017 at 11:22:45AM +0300, Pohjolainen, Topi wrote: > On Thu, Oct 12, 2017 at 08:37:54PM +0200, Jose Maria Casanova Crespo wrote: > > From: Eduardo Lima Mitev > > > > This will include the following NIR ALU opcodes: > > * nir_op_i2i16 > > * nir_op_i2f16 > > *

[Mesa-dev] [Bug 103386] Cross compilation fails with undefined reference

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103386 bkarthik...@gmail.com changed: What|Removed |Added Resolution|--- |DUPLICATE

[Mesa-dev] [Bug 103385] Cross compilation fails with undefined reference

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103385 --- Comment #1 from bkarthik...@gmail.com --- *** Bug 103386 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 103386] Cross compilation fails with undefined reference

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103386 bkarthik...@gmail.com changed: What|Removed |Added CC||bkarthik...@gmail.com -- You

[Mesa-dev] [Bug 103386] Cross compilation fails with undefined reference

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103386 bkarthik...@gmail.com changed: What|Removed |Added Whiteboard||cross compilation -- You are

[Mesa-dev] [Bug 103386] Cross compilation fails with undefined reference

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103386 Bug ID: 103386 Summary: Cross compilation fails with undefined reference Product: Mesa Version: 13.0 Hardware: ARM OS: Linux (All) Status: NEW Severity:

[Mesa-dev] [Bug 103385] Cross compilation fails with undefined reference

2017-10-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103385 Bug ID: 103385 Summary: Cross compilation fails with undefined reference Product: Mesa Version: 13.0 Hardware: ARM OS: Linux (All) Status: NEW Severity:

Re: [Mesa-dev] [PATCH 8/8] etnaviv: fix rs blit for formats with blocksize of 8

2017-10-21 Thread Wladimir J. van der Laan
On Sat, Oct 21, 2017 at 10:22:09AM +0200, Christian Gmeiner wrote: > Hi Wladimir > > 2017-10-21 7:28 GMT+02:00 Wladimir J. van der Laan : > > On Fri, Oct 20, 2017 at 10:21:28PM +0200, Christian Gmeiner wrote: > >> Fixes piglit/bin/oes_texture_float half > >> > >> Signed-off-by:

Re: [Mesa-dev] [PATCH v3 05/43] nir: Populate conversion opcodes to/from 16-bit types

2017-10-21 Thread Pohjolainen, Topi
On Thu, Oct 12, 2017 at 08:37:54PM +0200, Jose Maria Casanova Crespo wrote: > From: Eduardo Lima Mitev > > This will include the following NIR ALU opcodes: > * nir_op_i2i16 > * nir_op_i2f16 > * nir_op_u2u16 > * nir_op_u2f16 > * nir_op_f2i16 > * nir_op_f2u16 > *

Re: [Mesa-dev] [PATCH 8/8] etnaviv: fix rs blit for formats with blocksize of 8

2017-10-21 Thread Christian Gmeiner
Hi Wladimir 2017-10-21 7:28 GMT+02:00 Wladimir J. van der Laan : > On Fri, Oct 20, 2017 at 10:21:28PM +0200, Christian Gmeiner wrote: >> Fixes piglit/bin/oes_texture_float half >> >> Signed-off-by: Christian Gmeiner >> --- >>

Re: [Mesa-dev] [PATCH 7/8] etnaviv: add float formats

2017-10-21 Thread Christian Gmeiner
Hi Wladimir 2017-10-21 8:27 GMT+02:00 Wladimir J. van der Laan : > On Fri, Oct 20, 2017 at 10:21:27PM +0200, Christian Gmeiner wrote: >> Signed-off-by: Christian Gmeiner > > Reviewed-by: Wladimir J. van der Laan > > Optional

Re: [Mesa-dev] [PATCH 4/8] etnaviv: add support for extended PE formats

2017-10-21 Thread Christian Gmeiner
Hi Wladimir 2017-10-21 7:27 GMT+02:00 Wladimir J. van der Laan : > On Fri, Oct 20, 2017 at 10:21:24PM +0200, Christian Gmeiner wrote: >> Use the extended format if an such a format was passed. >> >> Signed-off-by: Christian Gmeiner >> --- >>

Re: [Mesa-dev] meson build for etnaviv and imx

2017-10-21 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 04:04:09PM -0700, Dylan Baker wrote: > This is all pretty straight-forward, it builds on my system, but I don't have > any actual hardware to test on. > > Christian and/or Wladimir, could one of you build this and do some kind of > testing to ensure it works? Sure, if you

Re: [Mesa-dev] [PATCH 1/8] mesa: handle OES_texture_half_float formats in _mesa_base_tex_format()

2017-10-21 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:21PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner > --- > src/mesa/main/glformats.c | 19 +++ > 1 file changed, 19 insertions(+) Reviewed-by: Wladimir J. van der Laan (as far as

Re: [Mesa-dev] [PATCH v2 23/32] mesa/glsl: add api_enabled flag to gl_transform_feedback_info

2017-10-21 Thread Timothy Arceri
On 21/10/17 10:14, Jason Ekstrand wrote: On Wed, Oct 18, 2017 at 10:32 PM, Jordan Justen > wrote: From: Timothy Arceri > This will be used to disable

Re: [Mesa-dev] [PATCH 7/8] etnaviv: add float formats

2017-10-21 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:27PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan Optional suggestions inline. > --- > src/gallium/drivers/etnaviv/etnaviv_format.c | 22

Re: [Mesa-dev] [PATCH 6/8] etnaviv: expose float formats only if GPU supports it

2017-10-21 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:26PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c | 4 > 1 file changed, 4 insertions(+) > > diff

Re: [Mesa-dev] [PATCH 5/8] etnaviv: handle 8 byte block in tiling

2017-10-21 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:25PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_tiling.c | 8 ++-- > 1 file changed, 6 insertions(+), 2

Re: [Mesa-dev] [PATCH 3/8] etnaviv: update RS_FORMAT_MASK to include extended formats

2017-10-21 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:23PM +0200, Christian Gmeiner wrote: > Also update RS_FORMAT_RB_SWAP. > > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_format.c | 4 ++-- > 1

Re: [Mesa-dev] [PATCH 2/8] etnaviv: HALTI0 indicates extended PE formats

2017-10-21 Thread Wladimir J. van der Laan
On Fri, Oct 20, 2017 at 10:21:22PM +0200, Christian Gmeiner wrote: > Signed-off-by: Christian Gmeiner Reviewed-by: Wladimir J. van der Laan Verified that HALTI0 has PE TEXTURE_FORMAT_EXT by looking at GC2000 blob replays. > --- >