Re: [Mesa-dev] [PATCH v3 19/48] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

2017-10-26 Thread Iago Toral
On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > --- >  src/intel/compiler/brw_fs_nir.cpp | 33 +-- > -- >  1 file changed, 21 insertions(+), 12 deletions(-) > > diff --git a/src/intel/compiler/brw_fs_nir.cpp > b/src/intel/compiler/brw_fs_nir.cpp > index e008e2

[Mesa-dev] [PATCH] i965: unref push_const_bo in intelDestroyContext

2017-10-26 Thread Tapani Pälli
Valgrind shows that leak is caused by gen6_upload_push_constant, add unref push_const_bo per stage to destructor to fix this (like done for scratch_bo). ==10952== 144 bytes in 1 blocks are definitely lost in loss record 44 of 66 ==10952==at 0x4C30A1E: calloc (vg_replace_malloc.c:711)

Re: [Mesa-dev] [PATCH v3 18/48] i965/fs/nir: Minor refactor of store_output

2017-10-26 Thread Iago Toral
On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > Stop retyping the output of shuffle_64bit_data_for_32bit_write.  It's > always BRW_REGISTER_TYPE_D which is perfectly fine for writing out. > Also, when we change get_nir_src to return something with a 64-bit > type > for 64-bit values, the

[Mesa-dev] [PATCH v3.5] intel/compiler: Add union types for prog_data and prog_key stages

2017-10-26 Thread Jordan Justen
Signed-off-by: Jordan Justen Reviewed-by: Jason Ekstrand Cc: Jason Ekstrand Cc: Kenneth Graunke --- * Add comment (Ken) * No typedef (Jason) src/intel/compiler/brw_compiler.h | 20 1 file changed, 20 insertions(+) diff --git a/src/intel/compiler/brw_compiler.h b/src/

Re: [Mesa-dev] [PATCH] mesa: Accept GL_BACK in get_fb0_attachment with ARB_ES3_1_compatibility.

2017-10-26 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 10/26/2017 11:26 PM, Kenneth Graunke wrote: According to the ARB_ES3_1_compatibility specification, glGetFramebufferAttachmentParameteriv is supposed to accept BACK, and it behaves exactly like BACK_LEFT. Fixes a GL error in GFXBench 5 Aztec Ruins. Cc: mesa-sta...

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

2017-10-26 Thread Harish Krupo
Hi Eric, Eric Engestrom writes: > On Monday, 2017-10-23 16:20:54 +0530, Harish Krupo wrote: >> This passes 33/37 deqp tests related to partial_update, 4 are not >> supported. Tests not supported: >> dEQP-EGL.functional.negative_partial_update.not_postable_surface >> dEQP-EGL.functional.negative_

Re: [Mesa-dev] [PATCH] nir: fix load/store_var validation for matrix types

2017-10-26 Thread Connor Abbott
Also, NIR doesn't (yet) have matrix SSA values so load_var/store_var wouldn't really make sense on them. On Fri, Oct 27, 2017 at 12:25 AM, Timothy Arceri wrote: > On second thoughts I'm splitting the matrix as well so I probably don't need > this. > > > On 27/10/17 14:58, Timothy Arceri wrote: >>

Re: [Mesa-dev] [PATCH] nir: fix load/store_var validation for matrix types

2017-10-26 Thread Timothy Arceri
On second thoughts I'm splitting the matrix as well so I probably don't need this. On 27/10/17 14:58, Timothy Arceri wrote: For some reason when we convert the following from GLSL IR to NIR: out mat4 var; The derefence type ends up as vec4 so we don't currently end up asserting here. However

[Mesa-dev] [PATCH] nir: fix load/store_var validation for matrix types

2017-10-26 Thread Timothy Arceri
For some reason when we convert the following from GLSL IR to NIR: out mat4 var; The derefence type ends up as vec4 so we don't currently end up asserting here. However I hit this with a NIR array splitting pass I'm working on. --- src/compiler/nir/nir_validate.c | 2 ++ 1 file changed, 2 insert

Re: [Mesa-dev] [PATCH 2/2] anv: Fix assert about source attrs.

2017-10-26 Thread Jason Ekstrand
Rb to both On October 26, 2017 18:38:52 Kenneth Graunke wrote: Asserting slot >= 2 made sense when the URB read offset was always 1 (pair of slots). Commit 566a0c43f0b9fbf5106161471dd5061c7275f761 made it possible to read from the VUE header in slot 0, by adjusting the offset to be 0. So, t

Re: [Mesa-dev] [PATCH 3/3] gallium/u_vbuf: use signed vertex buffers offsets for optimal uploads

2017-10-26 Thread Roland Scheidegger
Am 27.10.2017 um 04:50 schrieb Marek Olšák: > On Fri, Oct 27, 2017 at 1:44 AM, Roland Scheidegger > wrote: >> Am 26.10.2017 um 17:31 schrieb Marek Olšák: >>> From: Marek Olšák >>> >>> Uploaded data must start at (stride * start), because we can't modify >>> start in all cases. >> I'm probably mi

Re: [Mesa-dev] [PATCH 3/3] gallium/u_vbuf: use signed vertex buffers offsets for optimal uploads

2017-10-26 Thread Marek Olšák
On Fri, Oct 27, 2017 at 1:44 AM, Roland Scheidegger wrote: > Am 26.10.2017 um 17:31 schrieb Marek Olšák: >> From: Marek Olšák >> >> Uploaded data must start at (stride * start), because we can't modify >> start in all cases. > I'm probably missing something here, but why not actually? 1) Mixed V

[Mesa-dev] [PATCH 1/2] anv: Drop URB entry output read handling in 3DSTATE_XS.

2017-10-26 Thread Kenneth Graunke
Commit 566a0c43f0b9fbf5106161471dd5061c7275f761 started setting the 3DSTATE_SBE bit to override these values with the one calculated there. So, they're dead. Stop setting them. --- src/intel/vulkan/genX_pipeline.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 2/2] anv: Fix assert about source attrs.

2017-10-26 Thread Kenneth Graunke
Asserting slot >= 2 made sense when the URB read offset was always 1 (pair of slots). Commit 566a0c43f0b9fbf5106161471dd5061c7275f761 made it possible to read from the VUE header in slot 0, by adjusting the offset to be 0. So, this assert is now bogus. Use the one from GL. --- src/intel/vulkan/

Re: [Mesa-dev] [PATCH] i965: Delete unused brw_vs_prog_data::nr_attributes field.

2017-10-26 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 19/34] intel/compiler: Add union types for prog_data and prog_key stages

2017-10-26 Thread Jason Ekstrand
On Sun, Oct 22, 2017 at 1:01 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/intel/compiler/brw_compiler.h | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/src/intel/compiler/brw_compiler.h b/src/intel/compiler/brw_ > compiler.h > index 701b4a80bf

Re: [Mesa-dev] [PATCH 00/12] anv: Add support for the variablePointers feature

2017-10-26 Thread Jason Ekstrand
+idr On Thu, Oct 19, 2017 at 11:04 AM, Jason Ekstrand wrote: > Not to be confused with variablePointersStorageBuffer which is the > subset of VK_KHR_variable_pointers required to enable the extension. > This gives us "full" support for variable pointers. > > The approach chosen here was to do th

Re: [Mesa-dev] [PATCH 3/3] gallium/u_vbuf: use signed vertex buffers offsets for optimal uploads

2017-10-26 Thread Roland Scheidegger
Am 26.10.2017 um 17:31 schrieb Marek Olšák: > From: Marek Olšák > > Uploaded data must start at (stride * start), because we can't modify > start in all cases. I'm probably missing something here, but why not actually? Roland If it's the first allocation, it's also the amount > of memory wast

[Mesa-dev] [PATCH 4/7] meson: build r300 driver

2017-10-26 Thread Dylan Baker
This is build tested only Signed-off-by: Dylan Baker --- meson.build | 4 +- meson_options.txt| 2 +- src/gallium/drivers/r300/meson.build | 156 +++ src/gallium/meson.build | 4 +- src/gallium/target

[Mesa-dev] [PATCH 7/7] meson: build virgl driver

2017-10-26 Thread Dylan Baker
Build tested only. cc: Dave Airlie Signed-off-by: Dylan Baker --- meson.build| 12 ++--- meson_options.txt | 2 +- src/gallium/drivers/virgl/meson.build | 39 ++ src/gallium/meson.build

[Mesa-dev] [PATCH 1/7] svga: Use __asm__ instead of asm

2017-10-26 Thread Dylan Baker
Which allows the code to be compiled with c99 instead of gnu99. A little history. This code is guarded by #ifdef __GNUC__, so it's only compiled with autotools on *nix, SCons with MSVC wont hit that code. However, meson is going to build both MSVC and GCC/Clang paths. As such it makes sense to not

[Mesa-dev] Meson for remaining gallium drivers (except SWR)

2017-10-26 Thread Dylan Baker
This series implements the rest of the remaining gallium drivers except SWR. I have a branch for SWR, but it needs some upstream meson patches that haven't landed, but will hopefully be in 0.44.0 Most of this is pretty straight forward, except for one change to svga. I have no hardware/software t

[Mesa-dev] [PATCH 2/7] meson: add proper LLVM modules to check for RadeonSI as well

2017-10-26 Thread Dylan Baker
Signed-off-by: Dylan Baker --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 1da1bb06798..64084d686e3 100644 --- a/meson.build +++ b/meson.build @@ -647,7 +647,7 @@ if with_gallium_freedreno endif llvm_modules = ['bitwriter', '

[Mesa-dev] [PATCH 6/7] meson: build svga driver on linux

2017-10-26 Thread Dylan Baker
Build tested only. cc: Brian Paul Signed-off-by: Dylan Baker --- meson.build | 2 + meson_options.txt | 2 +- src/gallium/drivers/svga/meson.build| 88 + src/gallium/meson.build | 7 ++- src

[Mesa-dev] [PATCH 5/7] meson: build r600

2017-10-26 Thread Dylan Baker
This has been build tested only. Signed-off-by: Dylan Baker --- meson.build | 20 -- meson_options.txt| 2 +- src/gallium/drivers/r600/meson.build | 128 +++ src/gallium/meson.build | 4 +- src/gal

[Mesa-dev] [PATCH 3/7] meson: build i915g driver

2017-10-26 Thread Dylan Baker
Build tested only. Signed-off-by: Dylan Baker --- meson.build | 7 +++- src/gallium/drivers/i915/meson.build| 70 + src/gallium/meson.build | 7 +++- src/gallium/targets/dri/meson.build | 5 +++ src/gallium/wi

Re: [Mesa-dev] [PATCH v3 02/48] intel/fs: Be more explicit about our placement of [un]zip

2017-10-26 Thread Jason Ekstrand
On Thu, Oct 26, 2017 at 1:39 AM, Iago Toral wrote: > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > Before, we were careful to place the zip after the last of the split > > instructions but did unzip on-demand. This changes things so that > > the > > unzips go before all of the spl

[Mesa-dev] [PATCH] i965: Delete unused brw_vs_prog_data::nr_attributes field.

2017-10-26 Thread Kenneth Graunke
--- src/intel/compiler/brw_compiler.h | 1 - src/intel/compiler/brw_vec4.cpp | 1 - 2 files changed, 2 deletions(-) diff --git a/src/intel/compiler/brw_compiler.h b/src/intel/compiler/brw_compiler.h index 014202d36ca..6a330537a5b 100644 --- a/src/intel/compiler/brw_compiler.h +++ b/src/intel/c

[Mesa-dev] [PATCH] Android: move drivers' symlinks to /vendor

2017-10-26 Thread Mauro Rossi
Having moved gallium_dri.so library to /vendor/lib/dri also symlinks need to be coherently created using TARGET_OUT_VENDOR insted of TARGET_OUT or all non Intel drivers will not be loaded with Android N and earlier, thus causing SurfaceFlinger SIGABRT Fixes: c3f75d483c ("Android: move libraries t

Re: [Mesa-dev] [Mesa-stable] [PATCH] amd/common/gfx9: workaround DCC corruption more conservatively

2017-10-26 Thread Marek Olšák
On Thu, Oct 26, 2017 at 11:37 PM, Andres Gomez wrote: > Nicolai, this patch depends on 759526813be which didn't make it for > 17.2 > > Hence, I could recover that if you want to nominate it or we would need > a backport. Otherwise, I'm dropping this patch. > > Let me know what you think. Yes, ple

Re: [Mesa-dev] [Mesa-stable] [PATCH] amd/common/gfx9: workaround DCC corruption more conservatively

2017-10-26 Thread Andres Gomez
Nicolai, this patch depends on 759526813be which didn't make it for 17.2 Hence, I could recover that if you want to nominate it or we would need a backport. Otherwise, I'm dropping this patch. Let me know what you think. On Thu, 2017-10-12 at 11:24 +0200, Nicolai Hähnle wrote: > From: Nicolai Hä

Re: [Mesa-dev] [PATCH 9/9] meson: build gallium based osmesa

2017-10-26 Thread Dylan Baker
Quoting Eric Engestrom (2017-10-26 02:40:20) > On Wednesday, 2017-10-25 15:58:23 -0700, Dylan Baker wrote: > > This has been tested with the osdemo from mesa-demos > > > > Signed-off-by: Dylan Baker > > --- > > meson.build | 3 ++ > > meson_options.txt

Re: [Mesa-dev] [PATCH v2] radeonsi: update hack for HTILE corruption in ARK: Survival Evolved

2017-10-26 Thread Marek Olšák
Please "clear_db_cache_before_clear" and the option too. With that, the patch is: Reviewed-by: Marek Olšák Thanks, Marek On Thu, Oct 26, 2017 at 6:08 PM, Samuel Pitoiset wrote: > It appears that flushing the DB metadata is actually not sufficient > since the driver uses the new VS blit shaders

[Mesa-dev] [PATCH] mesa: Accept GL_BACK in get_fb0_attachment with ARB_ES3_1_compatibility.

2017-10-26 Thread Kenneth Graunke
According to the ARB_ES3_1_compatibility specification, glGetFramebufferAttachmentParameteriv is supposed to accept BACK, and it behaves exactly like BACK_LEFT. Fixes a GL error in GFXBench 5 Aztec Ruins. Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/fbobject.c | 9 + 1 file ch

Re: [Mesa-dev] [PATCH 1/3] gallium: add PIPE_CAP_SIGNED_VERTEX_BUFFER_OFFSET

2017-10-26 Thread Marek Olšák
On Thu, Oct 26, 2017 at 7:23 PM, Eric Anholt wrote: > Marek Olšák writes: > >> From: Marek Olšák > > Could you hit vc5, as well? > > I'm not clear on why this is a pipe_cap instead of just updating type or > comments on the pipe structs to say what the new behavior is -- aren't > most of us usin

Re: [Mesa-dev] [PATCH] draw: don't cull tris with zero aera

2017-10-26 Thread Brian Paul
In subject and comments: s/aera/area/ I'm not sure about DX line rasterization, but IIRC for GL, if a line's endpoints are identical, nothing should be drawn. I can see how this is relevant for point mode though. Reviewed-by: Brian Paul On 10/26/2017 01:24 PM, srol...@vmware.com wrote: Fr

[Mesa-dev] [PATCH] draw: don't cull tris with zero aera

2017-10-26 Thread sroland
From: Roland Scheidegger Culling tris with zero aera seems like a great idea, but apparently with fill mode line (and point) we're supposed to draw them, at least some tests for some other state tracker complained otherwise. Such tris also always seem to be back facing (not sure if this can be in

[Mesa-dev] [PATCH] Android: egl: add dependency on libnativewindow

2017-10-26 Thread Rob Herring
system/window.h is no longer available by default and is part of libnativewindow, so add it to the shared libraries. It has to be conditional because the library is only present in O and later. Really, we should only be depending on vndk/window.h now, but that's only in O and changing would be pre

Re: [Mesa-dev] [PATCH v2] clover: Fix compilation after clang r315871

2017-10-26 Thread Vedran Miletić
26.10.2017 u 01:09, Jan Vesely je napisao/la: > On Tue, 2017-10-24 at 15:32 +0200, Vedran Miletić wrote: >> On 10/23/2017 05:24 AM, Jan Vesely wrote: >>> From: Jan Vesely >>> >>> v2: use a more generic compat function >>> >>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103388 >>> Signed

Re: [Mesa-dev] [PATCH v3 10/48] intel/eu: Fix broadcast instruction for

2017-10-26 Thread Jason Ekstrand
On Thu, Oct 26, 2017 at 3:49 AM, Iago Toral wrote: > The subject line is incomplete, it misses the '64-bit types' at the > end. > That must be a git-send-email fail. The commit message I have says: Fix broadcast instruction for 64-bit values on little-core > On Wed, 2017-10-25 at 16:25 -0700

Re: [Mesa-dev] [PATCH v3 08/48] intel/eu: Just modify the offset in brw_broadcast

2017-10-26 Thread Jason Ekstrand
On Thu, Oct 26, 2017 at 3:18 AM, Iago Toral wrote: > I am not sure I get the purpose of this, there is nothing wrong with > the change, but the subject suggests that was so that we modified that > offset only inside brw_broadcast()... but that was already happening > and in fact this patch only c

Re: [Mesa-dev] [PATCH v3 00/48] nir, intel: Prerequisites for subgroups

2017-10-26 Thread Jason Ekstrand
On Thu, Oct 26, 2017 at 5:15 AM, Iago Toral wrote: > I left a few minor comments in patches 1, 2, 8 and 14. Otherwise > patches 1-2, 4-5 and 7-14 (3 and 6 already have Rb) are: > > Reviewed-by: Iago Toral Quiroga > > I feel like patches 10, 11 could maybe use another extra review if > there is s

Re: [Mesa-dev] [PATCH 2/3] i965/blorp: Use more temporary isl_format variables

2017-10-26 Thread Jason Ekstrand
On Thu, Oct 26, 2017 at 9:10 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Oct 25, 2017 at 02:58:40PM -0700, Jason Ekstrand wrote: > > On Mon, Oct 23, 2017 at 11:07 PM, Pohjolainen, Topi < > > topi.pohjolai...@gmail.com> wrote: > > > > > On Mon, Oct 23, 2017 at 05:23:08PM -0

Re: [Mesa-dev] [PATCH 1/2] radv: make radv_fill_buffer() return the needed flush bits

2017-10-26 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Thu, Oct 26, 2017 at 6:03 PM, Samuel Pitoiset wrote: > Only needed when the CS path is used. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 46 +-- > src/amd/vulkan/radv_meta_buff

Re: [Mesa-dev] [PATCH v5 00/10] new series of Mesa for Tizen

2017-10-26 Thread Eric Anholt
Gwan-gyeong Mun writes: > Hi, > > These Patch v5 series modified with new helper function series [1]. > > These series only have mesa for tizen feature. > > [1] https://patchwork.freedesktop.org/series/32577/ Rather than have another giant pile of window system code in the tree, I'd like to see

Re: [Mesa-dev] [PATCH] spirv: Claim support for the simple memory model

2017-10-26 Thread Bas Nieuwenhuizen
I couldn't find in the SPIR-V spec what the actual difference is supposed by the two? Seems like in both cases the compiler can assume no aliasing. Reviewed-by: Bas Nieuwenhuizen On Thu, Oct 26, 2017 at 7:11 PM, Jason Ekstrand wrote: > It's rather surprising that we've never actually hit this b

Re: [Mesa-dev] [PATCH 1/3] gallium: add PIPE_CAP_SIGNED_VERTEX_BUFFER_OFFSET

2017-10-26 Thread Ilia Mirkin
On Thu, Oct 26, 2017 at 1:23 PM, Eric Anholt wrote: > Marek Olšák writes: > >> From: Marek Olšák > > Could you hit vc5, as well? > > I'm not clear on why this is a pipe_cap instead of just updating type or > comments on the pipe structs to say what the new behavior is -- aren't > most of us usin

Re: [Mesa-dev] meson for remaining class drivers

2017-10-26 Thread Dylan Baker
Quoting Eric Anholt (2017-10-26 10:33:11) > Dylan Baker writes: > > > [ Unknown signature status ] > > ping > > You had my r-b other than one comment. Are you pinging for something > else? Ilia and Timothy had expressed that they wanted to look at it, I wanted to make sure they didn't have com

Re: [Mesa-dev] meson for remaining class drivers

2017-10-26 Thread Eric Anholt
Dylan Baker writes: > [ Unknown signature status ] > ping You had my r-b other than one comment. Are you pinging for something else? signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.free

Re: [Mesa-dev] [PATCH 1/3] gallium: add PIPE_CAP_SIGNED_VERTEX_BUFFER_OFFSET

2017-10-26 Thread Eric Anholt
Marek Olšák writes: > From: Marek Olšák Could you hit vc5, as well? I'm not clear on why this is a pipe_cap instead of just updating type or comments on the pipe structs to say what the new behavior is -- aren't most of us using 32-bit math that will wrap the same on addition? signature.asc

Re: [Mesa-dev] [PATCH] meson: do not search for needless deps

2017-10-26 Thread Dylan Baker
Quoting Gert Wollny (2017-10-26 02:49:56) > > Am Mittwoch, den 25.10.2017, 10:24 +0200 schrieb Erik Faye-Lund: > > If we don't want to use these deps, there's no good reason to search > > for them in the first place. This should shave a bit of time for the > > initial build. > > --- > > > > This

Re: [Mesa-dev] [PATCH mesa v2 2/2] meson: bring MESA_GIT_SHA1 in line with other build systems

2017-10-26 Thread Dylan Baker
one small nit, otherwise, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-26 08:40:57) > From: Eric Engestrom > > Meson's vcs_tag() uses the output of `git describe`, eg. > 17.3-branchpoint-5-gfbf29c3cd15ae831e249+ > > Whereas the other build systems used a script that outputs only

Re: [Mesa-dev] [PATCH mesa 1/2] buildsys: move file regeneration logic to the script itself

2017-10-26 Thread Jordan Justen
Both Reviewed-by: Jordan Justen Cc: Dylan On 2017-10-26 08:40:56, Eric Engestrom wrote: > Suggested-by: Jordan Justen > Signed-off-by: Eric Engestrom > --- > bin/git_sha1_gen.py | 13 - > src/Makefile.am | 15 --- > src/SConscript

[Mesa-dev] [PATCH] spirv: Claim support for the simple memory model

2017-10-26 Thread Jason Ekstrand
It's rather surprising that we've never actually hit this before. Aparently, Ian's SPIR-V generator currently claims the Simple when you don't do anything complex. We really shouldn't assert-fail on it. Reviewed-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/spirv/spirv

Re: [Mesa-dev] [PATCH mesa 1/2] buildsys: move file regeneration logic to the script itself

2017-10-26 Thread Dylan Baker
I have a few tiny nits, but otherwise this seems fine: Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-26 08:40:56) > Suggested-by: Jordan Justen > Signed-off-by: Eric Engestrom > --- > bin/git_sha1_gen.py | 13 - > src/Makefile.am | 1

Re: [Mesa-dev] [PATCH mesa v2] vc4: fix release build

2017-10-26 Thread Eric Anholt
Eric Engestrom writes: > Mesa's DEBUG and assert's NDEBUG are not tied to each other, so we need > to explicitly compile this code out. > > Fixes: 3df78928786134874eafa "vc4: Drop reloc_count tracking for debug >asserts on non-debug builds." > Cc: Eric Anholt > Signed-off-by: Eric Engest

Re: [Mesa-dev] [PATCH mesa] wayland-egl: fix wayland cflags

2017-10-26 Thread Tobias Klausmann
On 10/26/17 6:25 PM, Eric Engestrom wrote: > Fixes: 80bfff5c4f1d4d8c842a0 "wayland-egl: adds CFLAGS for wayland.egl.h > include" > Suggested-by: Daniel Stone > Signed-off-by: Eric Engestrom > --- > src/egl/wayland/wayland-egl/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH mesa v2] meson: wire up selinux

2017-10-26 Thread Dylan Baker
I don't have an selinux enabled system to test with either, but this looks correct and doesn't break the build. Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-26 09:30:24) > Signed-off-by: Eric Engestrom > --- > build-tested only > --- > meson.build | 5 - > meson_options.t

Re: [Mesa-dev] [PATCH] i965: Fix ARB_indirect_parameters logic.

2017-10-26 Thread Kenneth Graunke
On Thursday, October 26, 2017 4:24:10 AM PDT Manolova, Plamena wrote: [snip] > After taking another look you're absolutely right. For some reason > propagating the predicates like this didn't occur to me. > If we use this approach couldn't we get away with just having one predicate > per draw call?

Re: [Mesa-dev] [PATCH mesa] wayland-egl: fix wayland cflags

2017-10-26 Thread Emil Velikov
On 26 October 2017 at 17:25, Eric Engestrom wrote: > Fixes: 80bfff5c4f1d4d8c842a0 "wayland-egl: adds CFLAGS for wayland.egl.h > include" > Suggested-by: Daniel Stone > Signed-off-by: Eric Engestrom > --- > src/egl/wayland/wayland-egl/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 dele

[Mesa-dev] [PATCH mesa v2] meson: wire up selinux

2017-10-26 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- build-tested only --- meson.build | 5 - meson_options.txt | 6 ++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 2a89b6482f966293282f..d245fbcea2ee9b02baf5 100644 --- a/meson.build +++ b/meson.build @

Re: [Mesa-dev] [PATCH mesa] wayland-egl: fix wayland cflags

2017-10-26 Thread Daniel Stone
On 26 October 2017 at 17:25, Eric Engestrom wrote: > Fixes: 80bfff5c4f1d4d8c842a0 "wayland-egl: adds CFLAGS for wayland.egl.h > include" > Suggested-by: Daniel Stone Acked-by: Daniel Stone ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH v3 00/10] glsl_to_tgsi: Further improvement of lifetime tracking for register merge

2017-10-26 Thread Emil Velikov
On 25 October 2017 at 10:51, Gert Wollny wrote: > Dear all, > > this is a minor update to the patch set that adds enhanced tracking of IF/ELSE > branches and tracking of reladdr* registers for the register_merge step. > > So far patches 1 & 5 (now 8) are > > Reviewed-by: Nicolai Hähnle > > Chan

[Mesa-dev] [PATCH mesa] wayland-egl: fix wayland cflags

2017-10-26 Thread Eric Engestrom
Fixes: 80bfff5c4f1d4d8c842a0 "wayland-egl: adds CFLAGS for wayland.egl.h include" Suggested-by: Daniel Stone Signed-off-by: Eric Engestrom --- src/egl/wayland/wayland-egl/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/wayland/wayland-egl/Makefile.am b/s

Re: [Mesa-dev] [PATCH v5 1/3] configure+mesa/st: check for -std=c++11 support and enable mesa/st/test accordingly

2017-10-26 Thread Emil Velikov
On 18 October 2017 at 16:05, Gert Wollny wrote: > Add a check that tests whether the c++ compiler supports c++11, either by > default, > by adding the compiler flag -std=c++11, or by adding a compiler flag that the > user > has specified via the environment variable CXX11_CXXFLAGS. > > The test

Re: [Mesa-dev] [PATCH 2/2] radv: Implement VK_AMD_shader_info

2017-10-26 Thread Samuel Pitoiset
On 10/25/2017 10:58 PM, Bas Nieuwenhuizen wrote: On Wed, Oct 25, 2017 at 4:03 PM, Samuel Pitoiset wrote: On 10/25/2017 02:20 PM, Alex Smith wrote: On 25 October 2017 at 12:46, Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: I have something similar on my local tree (starte

Re: [Mesa-dev] [PATCH 2/3] i965/blorp: Use more temporary isl_format variables

2017-10-26 Thread Pohjolainen, Topi
On Wed, Oct 25, 2017 at 02:58:40PM -0700, Jason Ekstrand wrote: > On Mon, Oct 23, 2017 at 11:07 PM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Mon, Oct 23, 2017 at 05:23:08PM -0700, Jason Ekstrand wrote: > > > --- > > > src/mesa/drivers/dri/i965/brw_blorp.c | 15 +++

[Mesa-dev] [PATCH v2] radeonsi: update hack for HTILE corruption in ARK: Survival Evolved

2017-10-26 Thread Samuel Pitoiset
It appears that flushing the DB metadata is actually not sufficient since the driver uses the new VS blit shaders. This looks quite strange though, but it seems like we need to flush DB for fixing the corruption. v2: rename the drirc option Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=1

Re: [Mesa-dev] [PATCH] radeonsi: update hack for HTILE corruption in ARK: Survival Evolved

2017-10-26 Thread Samuel Pitoiset
On 10/26/2017 04:26 PM, Marek Olšák wrote: Hi Samuel, Can you also rename the drirc option and the bool? Hi Marek, Yes, you are right. I will send a v2. Thanks. Thanks, Marek On Tue, Oct 24, 2017 at 11:59 AM, Samuel Pitoiset wrote: It appears that flushing the DB metadata is actually

[Mesa-dev] [PATCH 1/2] radv: make radv_fill_buffer() return the needed flush bits

2017-10-26 Thread Samuel Pitoiset
Only needed when the CS path is used. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 46 +-- src/amd/vulkan/radv_meta_buffer.c | 13 +++--- src/amd/vulkan/radv_meta_clear.c | 50 +-- src/amd/vulkan/r

[Mesa-dev] [PATCH 2/2] radv: allow to use a compute shader for resetting the query pool

2017-10-26 Thread Samuel Pitoiset
Serious Sam Fusion 2017 uses a huge number of occlusion queries, and the allocated query pool buffer is greater than 4096 bytes. This slightly improves performance (tested in Ultra) from 117.2 FPS to 119.7 FPS (~+2%) on my RX480. This also improves Talos, from 69 FPS to 72/73 FPS (~+5%). v2: - a

Re: [Mesa-dev] [PATCH v4 0/2] build system: Unify c++11 detection and used [was: configure+mesa/st:check -std=c++11 support and enable tests accordingly]

2017-10-26 Thread Emil Velikov
On 17 October 2017 at 16:54, Chuck Atkins wrote: >> I also think adding a test for each C++11 feature used in the code is >> >> too tedious, regardless of the build system, and it would really need a >> dedicated maintainer. > > > Certainly. Rather than checking for everything, I think a code sni

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

2017-10-26 Thread Mark Janes
That fixed many issues, but: On deqp EGL tests, we get: dEQP-EGL.functional.create_context_ext.gl_42.rgba_no_depth_no_stencil deqp-egl: main/api_exec.c:135: _mesa_initialize_exec_table: Assertion `ctx->Version > 0' failed. On ES31 CTS tests: ES31-CTS.functional.texture.texture_buffer.render

[Mesa-dev] [PATCH mesa v2 2/2] meson: bring MESA_GIT_SHA1 in line with other build systems

2017-10-26 Thread Eric Engestrom
From: Eric Engestrom Meson's vcs_tag() uses the output of `git describe`, eg. 17.3-branchpoint-5-gfbf29c3cd15ae831e249+ Whereas the other build systems used a script that outputs only the sha1 of the HEAD commit, eg. fbf29c3cd1 Given that this information is used by printing it next to the

Re: [Mesa-dev] [PATCH 1/5] anv: add ETIME fallback define

2017-10-26 Thread Emil Velikov
On 26 October 2017 at 15:37, Greg V wrote: > On 10/26/2017 17:02, Emil Velikov wrote: > >> On 24 October 2017 at 18:21, Greg V wrote: >>> >>> >>> On 10/24/2017 20:16, Dylan Baker wrote: Quoting Greg V (2017-10-23 13:20:39) > > FreeBSD only has ETIMEDOUT, not ETIME > ---

[Mesa-dev] [PATCH mesa 1/2] buildsys: move file regeneration logic to the script itself

2017-10-26 Thread Eric Engestrom
Suggested-by: Jordan Justen Signed-off-by: Eric Engestrom --- bin/git_sha1_gen.py | 13 - src/Makefile.am | 15 --- src/SConscript | 22 ++ src/mesa/Android.libmesa_git_sha1.mk | 4 ++-- 4 fi

[Mesa-dev] [PATCH mesa v2] vc4: fix release build

2017-10-26 Thread Eric Engestrom
Mesa's DEBUG and assert's NDEBUG are not tied to each other, so we need to explicitly compile this code out. Fixes: 3df78928786134874eafa "vc4: Drop reloc_count tracking for debug asserts on non-debug builds." Cc: Eric Anholt Signed-off-by: Eric Engestrom --- Changes in v2: - change DEBUG

[Mesa-dev] [PATCH 2/3] radeonsi: enable signed vertex buffer offsets

2017-10-26 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 25 +++-- src/gallium/drivers/radeonsi/si_pipe.c| 2 +- 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeons

[Mesa-dev] [PATCH 0/3] Gallium: Signed VBO offsets to fix SPECviewperf stability

2017-10-26 Thread Marek Olšák
Hi, This is a necessary feature to prevent out-of-memory errors with SPECviewperf for drivers relying on u_vbuf for vertex uploads. Only RadeonSI supports it at the moment. I don't think we need to change pipe_vertex_buffer::buffer_offset to int64_t just yet. Please review. Thanks, Marek __

[Mesa-dev] [PATCH 3/3] gallium/u_vbuf: use signed vertex buffers offsets for optimal uploads

2017-10-26 Thread Marek Olšák
From: Marek Olšák Uploaded data must start at (stride * start), because we can't modify start in all cases. If it's the first allocation, it's also the amount of memory wasted. If the starting offset is larger than the size of the upload buffer, the buffer is re-created, used for 1 upload, and th

[Mesa-dev] [PATCH 1/3] gallium: add PIPE_CAP_SIGNED_VERTEX_BUFFER_OFFSET

2017-10-26 Thread Marek Olšák
From: Marek Olšák --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH mesa] meson: wire up selinux

2017-10-26 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- build-tested only --- meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 485889590041545c4de0..738ebc510ace26fd7917 100644 --- a/meson.build +++ b/meson.build @@ -697,8 +697,11 @@ endif prog_bison

Re: [Mesa-dev] [PATCH mesa] loader: drop empty function alias

2017-10-26 Thread Emil Velikov
On 26 October 2017 at 15:40, Eric Engestrom wrote: > While at it, drop the duplicate return. > The dup return is a left-over from the times we had three different, all optional, codepaths. Reviewed-by: Emil Velikov Thanks Emil ___ mesa-dev mailing lis

Re: [Mesa-dev] [PATCH 3/5] compiler: define endian for FreeBSD

2017-10-26 Thread Greg V
On 10/26/2017 17:07, Emil Velikov wrote: On 23 October 2017 at 21:20, Greg V wrote: Obtained from: FreeBSD ports --- src/mesa/main/compiler.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h index 43a06b4313..8652aac36c 100644 --- a/

Re: [Mesa-dev] [PATCH 1/5] anv: add ETIME fallback define

2017-10-26 Thread Greg V
On 10/26/2017 17:02, Emil Velikov wrote: On 24 October 2017 at 18:21, Greg V wrote: On 10/24/2017 20:16, Dylan Baker wrote: Quoting Greg V (2017-10-23 13:20:39) FreeBSD only has ETIMEDOUT, not ETIME --- src/intel/vulkan/anv_device.c | 4 src/intel/vulkan/anv_gem.c| 4 s

Re: [Mesa-dev] [PATCH 03/25] threads: update for late C11 changes

2017-10-26 Thread Brian Paul
On 10/25/2017 10:55 PM, Jose Fonseca wrote: On 23/10/17 20:15, Emil Velikov wrote: Hi Nicolai, On 22 October 2017 at 20:07, Nicolai Hähnle wrote: From: Nicolai Hähnle C11 threads were changed to use struct timespec instead of xtime, and thrd_sleep got a second argument. As xtime was repla

[Mesa-dev] [Bug 103283] drm_get_device_name_for_fd is broken on FreeBSD

2017-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103283 Greg V changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] etnaviv: keep track of buffer valid ranges

2017-10-26 Thread Wladimir
On Thu, Oct 19, 2017 at 11:52 AM, Christian Gmeiner wrote: >>> + if ((usage & PIPE_TRANSFER_WRITE) && >>> + prsc->target == PIPE_BUFFER && >>> + !util_ranges_intersect(&rsc->valid_buffer_range, >>> +box->x, box->x + box->width)) { >>> + /*

[Mesa-dev] [PATCH mesa] loader: drop empty function alias

2017-10-26 Thread Eric Engestrom
While at it, drop the duplicate return. Signed-off-by: Eric Engestrom --- src/loader/loader.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/loader/loader.c b/src/loader/loader.c index f7f85e37c2094f52175e..3c67f9dc2448a34dbf8e 100644 --- a/src/loader/load

Re: [Mesa-dev] [PATCH] etnaviv: make use of TEXTURE_TYPE_1D

2017-10-26 Thread Wladimir
On Thu, Oct 26, 2017 at 4:16 PM, PrasannaKumar Muralidharan wrote: > > GCW Zero gaming console uses etnaviv for GC860. But they use very old > version from 2013. It is not based on upstream version I think, does > that count? They use my initial version of etnaviv, which *only* had pre-GC2000 sup

Re: [Mesa-dev] [PATCH] radeonsi: update hack for HTILE corruption in ARK: Survival Evolved

2017-10-26 Thread Marek Olšák
Hi Samuel, Can you also rename the drirc option and the bool? Thanks, Marek On Tue, Oct 24, 2017 at 11:59 AM, Samuel Pitoiset wrote: > It appears that flushing the DB metadata is actually not sufficient > since the driver uses the new VS blit shaders. This looks quite > strange though, but it s

Re: [Mesa-dev] [PATCH 5/5] util: use OpenBSD/NetBSD code on FreeBSD/DragonFly

2017-10-26 Thread Emil Velikov
On 24 October 2017 at 14:28, Eric Engestrom wrote: > On Monday, 2017-10-23 23:20:43 +0300, Greg V wrote: >> Obtained from: FreeBSD ports >> --- >> src/util/u_endian.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/util/u_endian.h b/src/util/u_endian.h >> index b9d

Re: [Mesa-dev] [PATCH] etnaviv: make use of TEXTURE_TYPE_1D

2017-10-26 Thread Christian Gmeiner
2017-10-26 15:51 GMT+02:00 Wladimir : > On Thu, Oct 26, 2017 at 9:45 AM, Lucas Stach wrote: >> Am Donnerstag, den 26.10.2017, 03:17 +0200 schrieb Christian Gmeiner: >>> Signed-off-by: Christian Gmeiner >> >> Has this been tested on older GPU cores like the GC600? > Not yet. > To be fair, I doub

Re: [Mesa-dev] [PATCH] etnaviv: make use of TEXTURE_TYPE_1D

2017-10-26 Thread PrasannaKumar Muralidharan
On 26 October 2017 at 19:21, Wladimir wrote: > On Thu, Oct 26, 2017 at 9:45 AM, Lucas Stach wrote: >> Am Donnerstag, den 26.10.2017, 03:17 +0200 schrieb Christian Gmeiner: >>> Signed-off-by: Christian Gmeiner >> >> Has this been tested on older GPU cores like the GC600? > > To be fair, I doubt a

Re: [Mesa-dev] [PATCH] etnaviv: make use of TEXTURE_TYPE_1D

2017-10-26 Thread Christian Gmeiner
2017-10-26 9:45 GMT+02:00 Lucas Stach : > Am Donnerstag, den 26.10.2017, 03:17 +0200 schrieb Christian Gmeiner: >> Signed-off-by: Christian Gmeiner > > Has this been tested on older GPU cores like the GC600? > Not yet... only looked what binary blob is using. >> --- >> src/gallium/drivers/etnav

Re: [Mesa-dev] [PATCH 3/5] compiler: define endian for FreeBSD

2017-10-26 Thread Emil Velikov
On 23 October 2017 at 21:20, Greg V wrote: > Obtained from: FreeBSD ports > --- > src/mesa/main/compiler.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h > index 43a06b4313..8652aac36c 100644 > --- a/src/mesa/main/compiler.h > +++ b

Re: [Mesa-dev] [PATCH 1/5] anv: add ETIME fallback define

2017-10-26 Thread Emil Velikov
On 24 October 2017 at 18:21, Greg V wrote: > > > On 10/24/2017 20:16, Dylan Baker wrote: >> >> Quoting Greg V (2017-10-23 13:20:39) >>> >>> FreeBSD only has ETIMEDOUT, not ETIME >>> --- >>> src/intel/vulkan/anv_device.c | 4 >>> src/intel/vulkan/anv_gem.c| 4 >>> src/intel/vulkan

Re: [Mesa-dev] [PATCH] etnaviv: make use of TEXTURE_TYPE_1D

2017-10-26 Thread Wladimir
On Thu, Oct 26, 2017 at 9:45 AM, Lucas Stach wrote: > Am Donnerstag, den 26.10.2017, 03:17 +0200 schrieb Christian Gmeiner: >> Signed-off-by: Christian Gmeiner > > Has this been tested on older GPU cores like the GC600? To be fair, I doubt any of the recent changes have been tested on GC600. Is

Re: [Mesa-dev] [PATCH v2 6/8] Haiku: add src/gallium/targets/haiku-softpipe/Makefile.am

2017-10-26 Thread Emil Velikov
On 24 October 2017 at 17:11, Jerome Duval wrote: > +libswpipe_la_SOURCES = \ > + GalliumContext.cpp \ > + SoftwareRenderer.cpp > + Please enhance this and move to Makefile.sources. Bonus points for reusing it in SConscript (at a later stage) GalliumContext.cpp Gallium

Re: [Mesa-dev] [PATCH v2 4/8] Haiku: add src/gallium/state_trackers/hgl/Makefile.am

2017-10-26 Thread Emil Velikov
On 24 October 2017 at 17:11, Jerome Duval wrote: > +libhgl_la_LIBADD = -ltranslation New library - please document or remove, if not needed. > +libhgl_la_SOURCES = $(common_SOURCES) > + > + > +EXTRA_DIST = SConscript > diff --git a/src/gallium/state_trackers/hgl/Makefile.sources > b/src/gallium

  1   2   >