[Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

I tested this in a setup where the builddir was outside of the srcdir. --- src/intel/vulkan/meson.build | 12 1 file changed, 12 insertions(+) diff --git a/src/intel/vulkan/meson.build b/src/intel/vulkan/meson.build index ff24e304ef5..e8b7f407507 100644 ---

[Mesa-dev] [Bug 103538] vkDestroySwapchain causes deadlock on Wayland compositor with X11

https://bugs.freedesktop.org/show_bug.cgi?id=103538 --- Comment #1 from mais...@archlinux.us --- Running Wayland on Gnome 3 if that helps. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

[Mesa-dev] [Bug 103538] vkDestroySwapchain causes deadlock on Wayland compositor with X11

https://bugs.freedesktop.org/show_bug.cgi?id=103538 Bug ID: 103538 Summary: vkDestroySwapchain causes deadlock on Wayland compositor with X11 Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH v3 24/43] i965/fs: Use byte scattered read

On Thu, Oct 12, 2017 at 11:38 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > Added on do_untyped_vector_read, that is used on the following > intrinsics: >* nir_intrinsic_load_shared >* nir_intrinsic_load_ubo >* nir_intrinsic_load_ssbo > > v2: Removed use of stride =

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

Quoting Scott D Phillips (2017-11-01 10:30:09) > Lionel Landwerlin writes: > > > On 31/10/17 21:11, Scott D Phillips wrote: > >>> +} > >> [snip imgui] > >> > >> imgui seems to be the first instance of someone pasting a sizeable third > >> party library into the

Re: [Mesa-dev] [PATCH] gallivm: allow arch rounding with avx512

I agree that we’re probably dropping into fallback paths in a variety of locations as there are a number of width==256 tests in the gallivm code. Right now I’m working through piglit regressions versus avx2 in our driver, and the rounding tests weren't passing. Thanks. > On Nov 1, 2017, at

[Mesa-dev] [PATCH] radv: Don't expose heaps with 0 memory.

It confuses CTS. This pregenerates the heap info into the physical device, so we can use it for translating contiguous indices into our "standard" ones. This also makes the WSI a bit smarter in case the first preferred heap does not exist. CC: ---

Re: [Mesa-dev] [PATCH 2/2] etnaviv: ASTC texture support

On Wed, Nov 1, 2017 at 3:32 PM, Wladimir J. van der Laan wrote: > >> These formats are in a completely different space from the others, in the >> hardware (programmed through a different register), so IMO it makes sense to >> add a new format bit for it, just like for

Re: [Mesa-dev] [PATCH 2/2] etnaviv: ASTC texture support

> These formats are in a completely different space from the others, in the > hardware (programmed through a different register), so IMO it makes sense to > add a new format bit for it, just like for EXT_FORMAT. > > Relying on mesa's judgement on whether something is astc seems brittle. > > >

Re: [Mesa-dev] [PATCH] gallivm: allow arch rounding with avx512

Looks good to me. Albeit I think there's quite a few more places which probably should handle avx512... Reviewed-by: Roland Scheidegger Am 01.11.2017 um 20:17 schrieb Tim Rowley: > Fixes piglit vs-roundeven-{float,vec[234]} with simd16 VS. > --- >

[Mesa-dev] [PATCH] gallivm: allow arch rounding with avx512

Fixes piglit vs-roundeven-{float,vec[234]} with simd16 VS. --- src/gallium/auxiliary/gallivm/lp_bld_arit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c b/src/gallium/auxiliary/gallivm/lp_bld_arit.c index cf1958b3b6..a1edd349f1

Re: [Mesa-dev] [PATCH v3 23/43] i965/fs: Add byte scattered read message and fs support

On Wed, Nov 1, 2017 at 12:09 PM, Jason Ekstrand wrote: > On Thu, Oct 12, 2017 at 11:38 AM, Jose Maria Casanova Crespo < > jmcasan...@igalia.com> wrote: > >> --- >> src/intel/compiler/brw_eu.h| 7 + >> src/intel/compiler/brw_eu_defines.h

Re: [Mesa-dev] [PATCH v3 23/43] i965/fs: Add byte scattered read message and fs support

On Thu, Oct 12, 2017 at 11:38 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > --- > src/intel/compiler/brw_eu.h| 7 + > src/intel/compiler/brw_eu_defines.h| 2 ++ > src/intel/compiler/brw_eu_emit.c | 41 >

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

On 11/01/2017 06:33 PM, Jason Ekstrand wrote: Do either of you mind if I cc the first one to stable?  It does fix a potential memory leak in the case where compilation fails. IMO CC stable would be fine for that one. On Wed, Nov 1, 2017 at 9:26 AM, Tapani Pälli

[Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

Meson has up until this point set it's version in the root meson.build script. While there are other build systems them creates "one more thing" to duplicate between meson and every other build system, this script is a simple "read, strip, print" sort of deal to allow meson to read the VERSION

Re: [Mesa-dev] [PATCH 2/2] etnaviv: ASTC texture support

Am 01.11.2017 7:06 nachm. schrieb "Wladimir J. van der Laan" < laa...@gmail.com>: On Wed, Nov 01, 2017 at 06:38:21PM +0100, Christian Gmeiner wrote: > I would love to see a new format helper (util_format_is_astc(..) and not > even start thinking about adding a new format bit (ASTC_FORMAT).

Re: [Mesa-dev] create src/wsi

Quoting Eric Engestrom (2017-11-01 07:05:02) > On Friday, 2017-10-20 18:00:13 -0700, Dylan Baker wrote: > > This very short series creates a new src/wsi folder, and moves wayland-drm > > into > > it. Basically wsi stuff is scattered about, and is needed by multiple > > components > > within

Re: [Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

On Wed, Nov 01, 2017 at 02:27:40PM +0100, Lucas Stach wrote: > Am Montag, den 30.10.2017, 17:14 +0100 schrieb Wladimir J. van der Laan: > > On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote: > > > I would prefer the shorter expression (!cb->buffer && !cb->user_buffer)  > > > here, which

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use format_ccs_compat_with_miptree for textures

On Wed, Nov 01, 2017 at 10:58:03AM -0700, Jason Ekstrand wrote: > On Wed, Nov 1, 2017 at 10:46 AM, Nanley Chery wrote: > > > On Tue, Oct 31, 2017 at 08:01:05PM -0700, Jason Ekstrand wrote: > > > This function is a bit more accurate because it lets us sample from sRGB > > >

Re: [Mesa-dev] [PATCH v2] meson: Allow building glvnd with EGL and non-dri based GLX

Quoting Emil Velikov (2017-11-01 10:41:10) > On 1 November 2017 at 17:24, Dylan Baker wrote: > > Because meson mirrors the auototools logic, it needs the same changes to > > allow building glvnd based egl. > > > > v2: - change if to elif (Eric) > > > > Signed-off-by: Dylan

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

Tested-by: Chris Healy I tested this with i.MX6qp (and i.MX6q) and found that the rendering issues I experienced with Wayland/Weston and the i.MX6qp went away with this patch applied. Also, I ran glmark2-es2-drm and saw no regressions. On Wed, Nov 1, 2017 at 3:17 AM,

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

I haven't run the CTS tests, but both the deqp and the piglit test pass on my skl with Marek's patches applied. Dylan Quoting Marek Olšák (2017-10-31 18:16:51) > This is how I run piglit on i965: > WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm > piglit/bin/glinfo|head > GL_RENDERER

[Mesa-dev] [PATCH v2 10/11] intel: decoder: add function to query shader length

Signed-off-by: Lionel Landwerlin --- src/intel/tools/disasm.c | 34 ++ src/intel/tools/gen_disasm.h | 2 ++ 2 files changed, 36 insertions(+) diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c index

[Mesa-dev] [PATCH v2 09/11] intel: decoder: decouple decoding from memory pointers

We want to introduce a reader interface for accessing memory, so that later on we can use different ways of storing the content of the GTT address space that don't involve a pointer to a linear buffer. Signed-off-by: Lionel Landwerlin ---

[Mesa-dev] [PATCH v2 08/11] intel: decoder: change find_instruction() to take first dword

Another step into decoupling memory access from pointers. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c| 4 ++-- src/intel/common/gen_decoder.h| 2 +- src/intel/tools/aubinator.c | 2 +-

[Mesa-dev] [PATCH v2 07/11] intel: decoder: change group_get_length() to take first dword

This is a first step in not accessing the dwords through pointers. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c| 29 +-- src/intel/common/gen_decoder.h| 2 +-

[Mesa-dev] [PATCH v2 06/11] intel: genxml: rename output urb offset field

"Output Read Offset" is a bit non-sensical, let's just make this match "Output Length". Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml| 6 +++--- src/intel/genxml/gen8.xml | 6 +++---

[Mesa-dev] [PATCH v2 05/11] intel: genxml: be consistent about register offset naming

Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 8 src/intel/genxml/gen4.xml | 2 +- src/intel/genxml/gen45.xml | 2 +- src/intel/genxml/gen5.xml | 2 +- src/intel/genxml/gen6.xml | 2 +-

[Mesa-dev] [PATCH v2 01/11] intel: aubinator: factor out MI_BATCH_BUFFER_END

Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 6 -- src/intel/tools/intel_aub.h | 1 + 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 48d4456cc16..728edad37ff

[Mesa-dev] [PATCH v2 02/11] intel: decoder: remove duplicate of gen_spec_find_enum() declaration

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/common/gen_decoder.h b/src/intel/common/gen_decoder.h index 8b00b6edc2f..28bf94b099e 100644 --- a/src/intel/common/gen_decoder.h +++

[Mesa-dev] [PATCH v2 00/11] intel: UI for aubinator

Hi, A quick update following a number of comments. Scott's suggestion of using aubdumps' mmapped memory to decode instruction instead of another structure isn't implemented yet (I'll probably post a v3 with that). Meanwhile a few other small patches could make it onto master. Cheers, Lionel

[Mesa-dev] [PATCH v2 03/11] intel: decoder: enable search for instruction by name

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 8 src/intel/common/gen_decoder.h | 1 + 2 files changed, 9 insertions(+) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index d09b6ea32b6..736bfd6df16

Re: [Mesa-dev] [PATCH 2/2] etnaviv: ASTC texture support

On Wed, Nov 01, 2017 at 06:38:21PM +0100, Christian Gmeiner wrote: > I would love to see a new format helper (util_format_is_astc(..) and not > even start thinking about adding a new format bit (ASTC_FORMAT). These formats are in a completely different space from the others, in the hardware

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

On Wed, Nov 1, 2017 at 6:56 PM, Dylan Baker wrote: > I'm asking a dumb question, but we always build with --enable-debug, are you > building with --enable-debug? Yes. If ctx->Version == 0, something is terribly wrong and the OpenGL driver should be non-functional. Marek

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use format_ccs_compat_with_miptree for textures

On Wed, Nov 1, 2017 at 10:46 AM, Nanley Chery wrote: > On Tue, Oct 31, 2017 at 08:01:05PM -0700, Jason Ekstrand wrote: > > This function is a bit more accurate because it lets us sample from sRGB > > textures if sRGB decode is off. This should improve performance in >

Re: [Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

I'm asking a dumb question, but we always build with --enable-debug, are you building with --enable-debug? Dylan Quoting Marek Olšák (2017-10-31 18:16:51) > This is how I run piglit on i965: > WAFFLE_GBM_DEVICE=/dev/dri/renderD128 PIGLIT_PLATFORM=gbm > piglit/bin/glinfo|head > GL_RENDERER =

Re: [Mesa-dev] create src/wsi

On Wed, Nov 1, 2017 at 10:33 AM, Emil Velikov wrote: > On 31 October 2017 at 21:07, Dylan Baker wrote: > > Quoting Emil Velikov (2017-10-30 10:47:22) > >> On 30 October 2017 at 17:05, Dylan Baker wrote: > >> > So I think the

Re: [Mesa-dev] [PATCH 2/2] i965/miptree: Use format_ccs_compat_with_miptree for textures

On Tue, Oct 31, 2017 at 08:01:05PM -0700, Jason Ekstrand wrote: > This function is a bit more accurate because it lets us sample from sRGB > textures if sRGB decode is off. This should improve performance in ^ ^ missing "with

Re: [Mesa-dev] [PATCH v2] meson: Allow building glvnd with EGL and non-dri based GLX

On 1 November 2017 at 17:24, Dylan Baker wrote: > Because meson mirrors the auototools logic, it needs the same changes to > allow building glvnd based egl. > > v2: - change if to elif (Eric) > > Signed-off-by: Dylan Baker > Reviewed-by: Eric

Re: [Mesa-dev] [PATCH 2/2] etnaviv: ASTC texture support

Hi.. First quick review send from my smartphone... Am 01.11.2017 6:19 nachm. schrieb "Wladimir J. van der Laan" < laa...@gmail.com>: Add ASTC texture support for hardware that supports this (currently only GC3000 on i.MX6qp is known to have this). Signed-off-by: Wladimir J. van der Laan

Re: [Mesa-dev] [PATCH v2] meson: implement default driver arguments

Quoting Eric Engestrom (2017-11-01 04:09:26) > On Tuesday, 2017-10-31 15:50:49 -0700, Dylan Baker wrote: > > This allows drivers to be set by OS/arch in a sane manner. > > > > v2: - set _drivers to a list of drivers instead of manually assigning > > each with_* > > > > cc: Eric Engestrom

Re: [Mesa-dev] create src/wsi

On 31 October 2017 at 21:07, Dylan Baker wrote: > Quoting Emil Velikov (2017-10-30 10:47:22) >> On 30 October 2017 at 17:05, Dylan Baker wrote: >> > So I think the consensus is this is okay? >> > >> > Emil, is the autotools right here? >> > >> >> Without

Re: [Mesa-dev] [PATCH] gallium: increase pipe_sampler_view::target bitfield size for MSVC

Nice catch. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, November 1, 2017 7:45:29 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] gallium: increase

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

Lionel Landwerlin writes: > On 31/10/17 21:11, Scott D Phillips wrote: >>> +} >> [snip imgui] >> >> imgui seems to be the first instance of someone pasting a sizeable third >> party library into the repo. I'm not sure how everyone feels about >> that.

Re: [Mesa-dev] [PATCH 0/2] etnaviv: ASTC texture support

On Wed, Nov 1, 2017 at 1:19 PM, Wladimir J. van der Laan wrote: > Add ASTC texture support for hardware that supports this > (currently only GC3000 on i.MX6qp is known to have this). > > Piglit output: > > $ bin/khr_compressed_astc-miptree_gles2 > PIGLIT: {"subtest":

[Mesa-dev] [PATCH v2] meson: Allow building glvnd with EGL and non-dri based GLX

Because meson mirrors the auototools logic, it needs the same changes to allow building glvnd based egl. v2: - change if to elif (Eric) Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom --- meson.build | 8 ++-- 1 file changed, 6

Re: [Mesa-dev] [PATCH] meson: Allow building glvnd with EGL and non-dri based GLX

Quoting Eric Engestrom (2017-11-01 06:36:35) > On Tuesday, 2017-10-31 13:57:25 -0700, Dylan Baker wrote: > > Because meson mirrors the auototools logic, it needs the same changes to > > allow building glvnd based EGL without building any GLX. > > > > Signed-off-by: Dylan Baker

[Mesa-dev] [PATCH 1/2] etnaviv: Update from rnndb

Updated as of etnav_viv commit 3b4a8ec. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 2 +- src/gallium/drivers/etnaviv/etnaviv_format.c | 9 +- src/gallium/drivers/etnaviv/etnaviv_state.c | 2 +-

[Mesa-dev] [PATCH 0/2] etnaviv: ASTC texture support

Add ASTC texture support for hardware that supports this (currently only GC3000 on i.MX6qp is known to have this). Piglit output: $ bin/khr_compressed_astc-miptree_gles2 PIGLIT: {"subtest": {"LDR Profile" : "pass"}} PIGLIT: {"subtest": {"HDR Profile" : "pass"}} PIGLIT:

[Mesa-dev] [PATCH 2/2] etnaviv: ASTC texture support

Add ASTC texture support for hardware that supports this (currently only GC3000 on i.MX6qp is known to have this). Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 8 +++ src/gallium/drivers/etnaviv/etnaviv_format.c | 30

Re: [Mesa-dev] [PATCH] gallium: increase pipe_sampler_view::target bitfield size for MSVC

On 11/01/2017 10:33 AM, Roland Scheidegger wrote: Oh no msvc enums strike again... (A real pity c doesn't allow to explicitly make enums signed or unsigned.) There's a proposal for that feature for a future std C version. We use bitfields for compact representation, so if we need an extra

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

On 31/10/17 21:11, Scott D Phillips wrote: +} [snip imgui] imgui seems to be the first instance of someone pasting a sizeable third party library into the repo. I'm not sure how everyone feels about that. Unfortunately it seems like imgui isn't packaged by any distros that I can see either.

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

On Wed, Nov 1, 2017 at 9:24 AM, Tapani Pälli wrote: > > > On 11/01/2017 04:55 PM, Jason Ekstrand wrote: > >> On Wed, Nov 1, 2017 at 7:53 AM, Jason Ekstrand > > wrote: >> >> On Fri, Oct 27, 2017 at 5:55 AM, Tapani

Re: [Mesa-dev] [PATCH] gallium: increase pipe_sampler_view::target bitfield size for MSVC

Oh no msvc enums strike again... (A real pity c doesn't allow to explicitly make enums signed or unsigned.) We use bitfields for compact representation, so if we need an extra bit that seems a bit counterintuitive (even if it dosen't increase the overall size here). Also, I believe the 16 bits for

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

Do either of you mind if I cc the first one to stable? It does fix a potential memory leak in the case where compilation fails. On Wed, Nov 1, 2017 at 9:26 AM, Tapani Pälli wrote: > series > Reviewed-by: Tapani Pälli > > > On 11/01/2017 06:00

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

series Reviewed-by: Tapani Pälli On 11/01/2017 06:00 PM, Jason Ekstrand wrote: It doesn't actually matter since the only user of push constants, i965, ralloc_steals it back to NULL but it's more consistent and probably fixes memory leaks in some error cases. ---

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

On 11/01/2017 04:55 PM, Jason Ekstrand wrote: On Wed, Nov 1, 2017 at 7:53 AM, Jason Ekstrand > wrote: On Fri, Oct 27, 2017 at 5:55 AM, Tapani Pälli > wrote: Patch uses

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

On 11/01/2017 12:59 PM, Andres Gomez wrote: Tapani, this patch landed with the "mesa-sta...@lists.freedesktop.org" tag without specifying branch. However, it addresses a fix for 8d90e28839, which didn't land in 17.2 so I'm skipping this patch for that queue. I hope this is OK with you. Let

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

Both patches are : Reviewed-by: Lionel Landwerlin On 01/11/17 16:00, Jason Ekstrand wrote: It doesn't actually matter since the only user of push constants, i965, ralloc_steals it back to NULL but it's more consistent and probably fixes memory leaks in some

[Mesa-dev] [PATCH 2/2] intel/fs: Don't allocate a param array for zero push constants

Thanks to the ralloc invariant of "any pointer returned from ralloc can be used as a context", calling ralloc_size with a size of zero will cause it to allocate at least a header. If we don't have any push constants, then NULL is perfectly acceptable (and even preferred). ---

[Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

It doesn't actually matter since the only user of push constants, i965, ralloc_steals it back to NULL but it's more consistent and probably fixes memory leaks in some error cases. --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/3] gallium: add PIPE_CAP_SIGNED_VERTEX_BUFFER_OFFSET

Any reviewers? BTW I enabled the CAP for vc5. Marek On Thu, Oct 26, 2017 at 5:31 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/docs/source/screen.rst | 4 > src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + >

Re: [Mesa-dev] [PATCH 31/33] intel: decoder: decouple decoding from memory pointers

On 01/11/17 15:09, Scott D Phillips wrote: Lionel Landwerlin writes: On 31/10/17 23:04, Scott D Phillips wrote: Lionel Landwerlin writes: On 31/10/17 20:54, Scott D Phillips wrote: Lionel Landwerlin

Re: [Mesa-dev] [PATCH] gallium: increase pipe_sampler_view::target bitfield size for MSVC

Reviewed-by: Marek Olšák Marek On Wed, Nov 1, 2017 at 3:45 PM, Brian Paul wrote: > MSVC treats enums as being signed. The 4-bit target field isn't large > enough to correctly store the value 8 (for PIPE_TEXTURE_CUBE_ARRAY). > The bitfield value 0x8 was

Re: [Mesa-dev] [PATCH mesa] mapi: fix .so path in ABI-check

On 31/10/17 07:50 PM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > Didn't find when this was broken, but it looks like the tests had been > silently ignored by `make check` for a long time... > --- > src/mapi/es1api/ABI-check | 2 +- >

Re: [Mesa-dev] [PATCH 2/3] es2api/ABI-check: Add es3.x symbols

On 31/10/17 07:57 PM, Dylan Baker wrote: > Currently this ABI check only checks for es2.x symbols, but es3.x > symbols are also exposed. Exposing these symbols is recommended by > Khronos, and as such the test should accept that as ABI. > > see:

Re: [Mesa-dev] [PATCH] i965: Disable L3 cache allocation for external buffers

On Tue, Oct 24, 2017 at 05:06:33PM +0100, Chris Wilson wrote: > Through the use of mocs, we can define the cache usage for any surface > used by the GPU. In particular, we can request that L3 cache be > allocated for either a read/write miss so that subsequent reads can be > fetched from cache

Re: [Mesa-dev] [PATCH 31/33] intel: decoder: decouple decoding from memory pointers

Lionel Landwerlin writes: > On 31/10/17 23:04, Scott D Phillips wrote: >> Lionel Landwerlin writes: >> >>> On 31/10/17 20:54, Scott D Phillips wrote: Lionel Landwerlin writes: > We want

Re: [Mesa-dev] [PATCH 2/2] configure.ac: require xcb* for the omx/va/... when using x11 platform

Working as expected. Thanks! On Tue, Oct 31, 2017 at 12:05 PM Emil Velikov wrote: > From: Emil Velikov > > Targets such as omx and va can work w/o anything X related. Mandate the > xcb* dependencies only when the X11 platform is selected. >

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

On Wed, Nov 1, 2017 at 7:53 AM, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 5:55 AM, Tapani Pälli > wrote: > >> Patch uses mem_ctx for allocation to ensure param array gets freed >> later, in blorp clear case this happens in

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

On Fri, Oct 27, 2017 at 5:55 AM, Tapani Pälli wrote: > Patch uses mem_ctx for allocation to ensure param array gets freed > later, in blorp clear case this happens in blorp_params_get_clear_kernel. > > ==6164== 48 bytes in 1 blocks are definitely lost in loss record 61 of

[Mesa-dev] [PATCH] gallium: increase pipe_sampler_view::target bitfield size for MSVC

MSVC treats enums as being signed. The 4-bit target field isn't large enough to correctly store the value 8 (for PIPE_TEXTURE_CUBE_ARRAY). The bitfield value 0x8 was being interpreted as -8 so matching the target with PIPE_TEXTURE_CUBE_ARRAY in switch statements, etc. was failing. To keep the

Re: [Mesa-dev] create src/wsi

On Friday, 2017-10-20 18:00:13 -0700, Dylan Baker wrote: > This very short series creates a new src/wsi folder, and moves wayland-drm > into > it. Basically wsi stuff is scattered about, and is needed by multiple > components > within mesa, wayland-drm, for example, is used by EGL, GBM, and

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

Yeah, it should be called when the winsys is created. Marek On Wed, Nov 1, 2017 at 9:49 AM, Christian König wrote: > I'm not 100% sure that patch was correct. > > When is amdgpu_ctx_create() called? The VMID is reserved for the whole > process, not just a

Re: [Mesa-dev] [PATCH] meson: Allow building glvnd with EGL and non-dri based GLX

On Tuesday, 2017-10-31 13:57:25 -0700, Dylan Baker wrote: > Because meson mirrors the auototools logic, it needs the same changes to > allow building glvnd based EGL without building any GLX. > > Signed-off-by: Dylan Baker > --- > > Emil, > > This implements the same

Re: [Mesa-dev] [PATCH 1/2] configure: loosen --enable-glvnd check to honour egl

On Tuesday, 2017-10-31 18:58:09 +, Emil Velikov wrote: > From: Emil Velikov > > Currently we error out when building GLVND w/o GLX. > > That was the original premice before we had EGL. As the commit says, > that error should be reworked to honour both - do so. >

Re: [Mesa-dev] [PATCH v2] etnaviv: Allow clearing constant buffer using buffer==NULL user_buffer==NULL

Am Montag, den 30.10.2017, 17:14 +0100 schrieb Wladimir J. van der Laan: > On Mon, Oct 30, 2017 at 02:21:07PM +0100, Lucas Stach wrote: > > I would prefer the shorter expression (!cb->buffer && !cb->user_buffer)  > > here, which seems more consistent with the rest of the codebase. > > Well, I

Re: [Mesa-dev] [PATCH 2/3] es2api/ABI-check: Add es3.x symbols

On Tuesday, 2017-10-31 11:57:34 -0700, Dylan Baker wrote: > Currently this ABI check only checks for es2.x symbols, but es3.x > symbols are also exposed. Exposing these symbols is recommended by > Khronos, and as such the test should accept that as ABI. > > see:

Re: [Mesa-dev] [PATCH 1/3] meson: Set c visibility args for wayland-drm

On Tuesday, 2017-10-31 11:57:33 -0700, Dylan Baker wrote: > Because otherwise gbm will expose wayland symbols that it shouldn't. > > Signed-off-by: Dylan Baker Reviewed-and-Tested-by: Eric Engestrom > --- >

Re: [Mesa-dev] [PATCH] gallium: fix typos in README.portability

This is: Reviewed-by: Andres Gomez I would drop the mesa-stable nomination, though. These are just typos and not even in the docs/ directory ... On Mon, 2017-10-30 at 10:55 -0400, Ben Crocker wrote: > Cc: "17.2" > Signed-off-by: Ben

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

On Wed, Nov 1, 2017 at 11:35 AM, Eric Engestrom wrote: > On Wednesday, 2017-11-01 11:17:53 +0100, Wladimir J. van der Laan wrote: >> GC3000 resolve-in-place assumes that the TS state is configured. >> If it is not, this will result in MMU errors. This is especially >>

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

Am Mittwoch, den 01.11.2017, 12:34 +0100 schrieb Wladimir J. van der Laan: > On Wed, Nov 01, 2017 at 11:52:55AM +0100, Lucas Stach wrote: > > Am Mittwoch, den 01.11.2017, 11:17 +0100 schrieb Wladimir J. van der Laan: > > > GC3000 resolve-in-place assumes that the TS state is configured. > > > If

Re: [Mesa-dev] [PATCH 05/19] etnaviv: Use only DRAW_INSTANCED on GC3000+

On Wed, Nov 01, 2017 at 11:57:39AM +0100, Philipp Zabel wrote: > On Mon, 2017-10-30 at 17:16 +0100, Wladimir J. van der Laan wrote: > > The blob does this, as DRAW_INSTANCED can replace fully all the other > > draw commands - the other path is only there for compatibility and > > will go away (or

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

On Wed, Nov 01, 2017 at 11:52:55AM +0100, Lucas Stach wrote: > Am Mittwoch, den 01.11.2017, 11:17 +0100 schrieb Wladimir J. van der Laan: > > GC3000 resolve-in-place assumes that the TS state is configured. > > If it is not, this will result in MMU errors. This is especially > > apparent when

Re: [Mesa-dev] [PATCH v2] meson: implement default driver arguments

On Tuesday, 2017-10-31 15:50:49 -0700, Dylan Baker wrote: > This allows drivers to be set by OS/arch in a sane manner. > > v2: - set _drivers to a list of drivers instead of manually assigning > each with_* > > cc: Eric Engestrom > Signed-off-by: Dylan Baker

[Mesa-dev] [PATCH 1/2] st/glsl_to_nir: generate NIR earlier

We want to use nir_shader_gather_info() the GLSL IR version might be including varyings that NIR later eliminates. To do this we need to generate NIR before we we start using the in/out bitmasks. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 6 + src/mesa/state_tracker/st_program.c |

[Mesa-dev] [PATCH 2/2] st/glsl_to_nir: use nir_shader_gather_info()

Use the NIR helper rather than the GLSL IR helper to get in/out masks. This allows us to ignore varyings removed by NIR optimisations. --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

Tapani, this patch landed with the "mesa-sta...@lists.freedesktop.org" tag without specifying branch. However, it addresses a fix for 8d90e28839, which didn't land in 17.2 so I'm skipping this patch for that queue. I hope this is OK with you. Let me know otherwise. On Fri, 2017-10-27 at 15:55

Re: [Mesa-dev] [PATCH 05/19] etnaviv: Use only DRAW_INSTANCED on GC3000+

On Mon, 2017-10-30 at 17:16 +0100, Wladimir J. van der Laan wrote: > The blob does this, as DRAW_INSTANCED can replace fully all the other > draw commands - the other path is only there for compatibility and > will go away (or at least rot to become buggy due to dis-use) in newer > hardware. > >

Re: [Mesa-dev] [PATCH 02/19] etnaviv: Const-correctness etnaviv_emit.h

On Mon, 2017-10-30 at 17:16 +0100, Wladimir J. van der Laan wrote: > The relocation structure is never changed by submitting it. > > Signed-off-by: Wladimir J. van der Laan > --- > src/gallium/drivers/etnaviv/etnaviv_emit.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

Am Mittwoch, den 01.11.2017, 11:17 +0100 schrieb Wladimir J. van der Laan: > GC3000 resolve-in-place assumes that the TS state is configured. > If it is not, this will result in MMU errors. This is especially > apparent when using glGenMipmaps(). > > Fixes a problem introduced in

Re: [Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

On Wednesday, 2017-11-01 11:17:53 +0100, Wladimir J. van der Laan wrote: > GC3000 resolve-in-place assumes that the TS state is configured. > If it is not, this will result in MMU errors. This is especially > apparent when using glGenMipmaps(). > > Fixes a problem introduced in

[Mesa-dev] [PATCH] etnaviv: bugfix: Don't do resolve-in-place without valid TS

GC3000 resolve-in-place assumes that the TS state is configured. If it is not, this will result in MMU errors. This is especially apparent when using glGenMipmaps(). Fixes a problem introduced in 78ade659569ee6fe9bd244170956139f19dd8c6c. Signed-off-by: Wladimir J. van der Laan

Re: [Mesa-dev] [PATCH 1/2] configure.ac: append to existing MSVC compat flags

On Tuesday, 2017-10-31 19:26:32 +, Emil Velikov wrote: > From: Emil Velikov > > Currently we were overwriting the existing warning flags, instead of > adding new [as applicable]. > > Fixes e4b2b69e828 ("configure: Add and use AX_CHECK_COMPILE_FLAG") > Cc: Matt

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

I'm not 100% sure that patch was correct. When is amdgpu_ctx_create() called? The VMID is reserved for the whole process, not just a context. Regards, Christian. Am 31.10.2017 um 16:57 schrieb Marek Olšák: I addressed the feedback and pushed the patch. Marek On Tue, Oct 31, 2017 at 4:50

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

Am 31.10.2017 um 16:50 schrieb Michel Dänzer: On 31/10/17 04:40 PM, Andrey Grodzovsky wrote: Signed-off-by: Andrey Grodzovsky [...] diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c index 8f43e93..1155492 100644

Re: [Mesa-dev] [PATCH] i965: Disable L3 cache allocation for external buffers

On 24.10.2017 19:06, Chris Wilson wrote: > Through the use of mocs, we can define the cache usage for any surface > used by the GPU. In particular, we can request that L3 cache be > allocated for either a read/write miss so that subsequent reads can be > fetched from cache rather than memory. A

<    1   2